actionview 6.1.4 → 7.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d032131f3879f298ee73bdec251c6b71bcf05c12bda0bb4a8156cb77096c8cb8
-  data.tar.gz: '034379d2e8c7d137f60fcc3044aef37b94f2d5f7b441d634f7e24f72f01c817d'
+  metadata.gz: 1fdc27b2d3fd239b03e012b641bd23a23a031aa1363a500604091d9ed9754a26
+  data.tar.gz: c3271b7fb9828ee34975baafe1fa8140327aec4f4f7a5368e101644e90f94120
 SHA512:
-  metadata.gz: d8a6276b5517f7991936433c76543041c35a7521eae07ec5afd46db1b3fa7292aa15ed92b74784774a72ff5b7af8bf5e07c3bff70f4a25c5fb2d0ec55d2092d5
-  data.tar.gz: 940c438d6ce952627e2bc08a6d7272a6ceae8fe4b89095acc9daa889d8a8eb3f1ceced29ee4c9c3c8ffc41ed9104eae2be6a62c643eba66679d6ab744b125961
+  metadata.gz: 93c9d5284b53225c766696483e059f5063a495a2f46179c575fc5538fdb523e3a313385b308a8242dfc839b489d803cdbcedf7effb6a56ff6d8e0ac67a1272b1
+  data.tar.gz: ab29bbd902f1a4cf97cd7b23b71a202918bdfaf461a9ffec421f671d2eb68a1834b5f74179278b662d5fa3bb315e35e1e517912336a72f2224b81a674645270a

data/CHANGELOG.md

@@ -1,345 +1,289 @@
-## Rails 6.1.4 (June 24, 2021) ##
+*   Support `fields model: [@nested, @model]` the same way as `form_with model:
+    [@nested, @model]`.
 
-*   The `translate` helper now passes `default` values that aren't
-    translation keys through `I18n.translate` for interpolation.
-
-    *Jonathan Hefner*
-
-*   Don't attach UJS form submission handlers to Turbo forms.
-
-    *David Heinemeier Hansson*
-
-*   Allow both `current_page?(url_hash)` and `current_page?(**url_hash)` on Ruby 2.7.
-
-    *Ryuta Kamizono*
-
-
-## Rails 6.1.3.2 (May 05, 2021) ##
-
-*   No changes.
-
-
-## Rails 6.1.3.1 (March 26, 2021) ##
-
-*   No changes.
-
-
-## Rails 6.1.3 (February 17, 2021) ##
-
-*   No changes.
-
-
-## Rails 6.1.2.1 (February 10, 2021) ##
-
-*   No changes.
-
-
-## Rails 6.1.2 (February 09, 2021) ##
-
-*   No changes.
-
-
-## Rails 6.1.1 (January 07, 2021) ##
-
-*   Fix lazy translation in partial with block.
-
-    *Marek Kasztelnik*
-
-*   Avoid extra `SELECT COUNT` queries when rendering Active Record collections.
-
-    *aar0nr*
-
-*   Link preloading keep integrity hashes in the header.
-
-    *Étienne Barrié*
-
-*   Add `config.action_view.preload_links_header` to allow disabling of
-    the `Link` header being added by default when using `stylesheet_link_tag`
-    and `javascript_include_tag`.
-
-    *Andrew White*
-
-*   The `translate` helper now resolves `default` values when a `nil` key is
-    specified, instead of always returning `nil`.
-
-    *Jonathan Hefner*
-
-
-## Rails 6.1.0 (December 09, 2020) ##
+    *Sean Doyle*
 
-*   SanitizeHelper.sanitized_allowed_attributes and SanitizeHelper.sanitized_allowed_tags
-    call safe_list_sanitizer's class method
+*   Infer HTTP verb `[method]` from a model or Array with model as the first
+    argument to `button_to` when combined with a block:
 
-    Fixes #39586
+    ```ruby
+    button_to(Workshop.find(1)){ "Update" }
+    #=> <form method="post" action="/workshops/1" class="button_to">
+    #=>   <input type="hidden" name="_method" value="patch" autocomplete="off" />
+    #=>   <button type="submit">Update</button>
+    #=> </form>
+
+    button_to([ Workshop.find(1), Session.find(1) ]) { "Update" }
+    #=> <form method="post" action="/workshops/1/sessions/1" class="button_to">
+    #=>   <input type="hidden" name="_method" value="patch" autocomplete="off" />
+    #=>   <button type="submit">Update</button>
+    #=> </form>
+    ```
 
-    *Taufiq Muhammadi*
+    *Sean Doyle*
 
-*   Change form_with to generate non-remote forms by default.
+*   Support passing a Symbol as the first argument to `FormBuilder#button`:
 
-    `form_with` would generate a remote form by default. This would confuse
-    users because they were forced to handle remote requests.
+    ```ruby
+    form.button(:draft, value: true)
+    # => <button name="post[draft]" value="true" type="submit">Create post</button>
+
+    form.button(:draft, value: true) do
+      content_tag(:strong, "Save as draft")
+    end
+    # =>  <button name="post[draft]" value="true" type="submit">
+    #       <strong>Save as draft</strong>
+    #     </button>
+    ```
 
-    All new 6.1 applications will generate non-remote forms by default.
-    When upgrading a 6.0 application you can enable remote forms by default by
-    setting `config.action_view.form_with_generates_remote_forms` to `true`.
+    *Sean Doyle*
 
-    *Petrik de Heus*
+*   Introduce the `field_name` view helper, along with the
+    `FormBuilder#field_name` counterpart:
 
-*   Yield translated strings to calls of `ActionView::FormBuilder#button`
-    when a block is given.
+    ```ruby
+    form_for @post do |f|
+      f.field_tag :tag, name: f.field_name(:tag, multiple: true)
+      # => <input type="text" name="post[tag][]">
+    end
+    ```
 
     *Sean Doyle*
 
-*   Alias `ActionView::Helpers::Tags::Label::LabelBuilder#translation` to
-    `#to_s` so that `form.label` calls can yield that value to their blocks.
+*   Execute the `ActionView::Base.field_error_proc` within the context of the
+    `ActionView::Base` instance:
+
+    ```ruby
+    config.action_view.field_error_proc = proc { |html| content_tag(:div, html, class: "field_with_errors") }
+    ```
 
     *Sean Doyle*
 
-*   Rename the new `TagHelper#class_names` method to `TagHelper#token_list`,
-    and make the original available as an alias.
+*   Add support for `button_to ..., authenticity_token: false`
 
-        token_list("foo", "foo bar")
-        # => "foo bar"
+    ```ruby
+    button_to "Create", Post.new, authenticity_token: false
+    # => <form class="button_to" method="post" action="/posts"><button type="submit">Create</button></form>
 
-    *Sean Doyle*
+    button_to "Create", Post.new, authenticity_token: true
+    # => <form class="button_to" method="post" action="/posts"><button type="submit">Create</button><input type="hidden" name="form_token" value="abc123..." autocomplete="off" /></form>
 
-*   ARIA Array and Hash attributes are treated as space separated `DOMTokenList`
-    values. This is useful when declaring lists of label text identifiers in
-    `aria-labelledby` or `aria-describedby`.
-
-        tag.input type: 'checkbox', name: 'published', aria: {
-          invalid: @post.errors[:published].any?,
-          labelledby: ['published_context', 'published_label'],
-          describedby: { published_errors: @post.errors[:published].any? }
-        }
-        #=> <input
-              type="checkbox" name="published" aria-invalid="true"
-              aria-labelledby="published_context published_label"
-              aria-describedby="published_errors"
-            >
+    button_to "Create", Post.new, authenticity_token: "secret"
+    # => <form class="button_to" method="post" action="/posts"><button type="submit">Create</button><input type="hidden" name="form_token" value="secret" autocomplete="off" /></form>
+    ```
 
     *Sean Doyle*
 
-*   Remove deprecated `escape_whitelist` from `ActionView::Template::Handlers::ERB`.
+*   Support rendering `<form>` elements _without_ `[action]` attributes by:
 
-    *Rafael Mendonça França*
+    * `form_with url: false` or `form_with ..., html: { action: false }`
+    * `form_for ..., url: false` or `form_for ..., html: { action: false }`
+    * `form_tag false` or `form_tag ..., action: false`
+    * `button_to "...", false` or `button_to(false) { ... }`
 
-*   Remove deprecated `find_all_anywhere` from `ActionView::Resolver`.
-
-    *Rafael Mendonça França*
+    *Sean Doyle*
 
-*   Remove deprecated `formats` from `ActionView::Template::HTML`.
+*   Add `:day_format` option to `date_select`
 
-    *Rafael Mendonça França*
+        date_select("article", "written_on", day_format: ->(day) { day.ordinalize })
+        # generates day options like <option value="1">1st</option>\n<option value="2">2nd</option>...
 
-*   Remove deprecated `formats` from `ActionView::Template::RawFile`.
+    *Shunichi Ikegami*
 
-    *Rafael Mendonça França*
+*   Allow `link_to` helper to infer link name from `Model#to_s` when it
+    is used with a single argument:
 
-*   Remove deprecated `formats` from `ActionView::Template::Text`.
+        link_to @profile
+        #=> <a href="/profiles/1">Eileen</a>
 
-    *Rafael Mendonça França*
+    This assumes the model class implements a `to_s` method like this:
 
-*   Remove deprecated `find_file` from `ActionView::PathSet`.
+        class Profile < ApplicationRecord
+          # ...
+          def to_s
+            name
+          end
+        end
 
-    *Rafael Mendonça França*
+    Previously you had to supply a second argument even if the `Profile`
+    model implemented a `#to_s` method that called the `name` method.
 
-*   Remove deprecated `rendered_format` from `ActionView::LookupContext`.
+        link_to @profile, @profile.name
+        #=> <a href="/profiles/1">Eileen</a>
 
-    *Rafael Mendonça França*
+    *Olivier Lacan*
 
-*   Remove deprecated `find_file` from `ActionView::ViewPaths`.
+*   Support svg unpaired tags for `tag` helper.
 
-    *Rafael Mendonça França*
+        tag.svg { tag.use('href' => "#cool-icon") }
+        # => <svg><use href="#cool-icon"></svg>
 
-*   Require that `ActionView::Base` subclasses implement `#compiled_method_container`.
+    *Oleksii Vasyliev*
 
-    *Rafael Mendonça França*
 
-*   Remove deprecated support to pass an object that is not a `ActionView::LookupContext` as the first argument
-    in `ActionView::Base#initialize`.
+## Rails 7.0.0.alpha2 (September 15, 2021) ##
 
-    *Rafael Mendonça França*
+*   No changes.
 
-*   Remove deprecated `format` argument `ActionView::Base#initialize`.
 
-    *Rafael Mendonça França*
+## Rails 7.0.0.alpha1 (September 15, 2021) ##
 
-*   Remove deprecated `ActionView::Template#refresh`.
+*   Improves the performance of ActionView::Helpers::NumberHelper formatters by avoiding the use of
+    exceptions as flow control.
 
-    *Rafael Mendonça França*
+    *Mike Dalessio*
 
-*   Remove deprecated `ActionView::Template#original_encoding`.
+*   `preload_link_tag` properly inserts `as` attributes for files with `image` MIME types, such as JPG or SVG.
 
-    *Rafael Mendonça França*
+    *Nate Berkopec*
 
-*   Remove deprecated `ActionView::Template#variants`.
+*   Add `weekday_options_for_select` and `weekday_select` helper methods. Also adds `weekday_select` to `FormBuilder`.
 
-    *Rafael Mendonça França*
+    *Drew Bragg*, *Dana Kashubeck*, *Kasper Timm Hansen*
 
-*   Remove deprecated `ActionView::Template#formats`.
+*   Add `caching?` helper that returns whether the current code path is being cached and `uncacheable!` to denote helper methods that can't participate in fragment caching.
 
-    *Rafael Mendonça França*
+    *Ben Toews*, *John Hawthorn*, *Kasper Timm Hansen*, *Joel Hawksley*
 
-*   Remove deprecated `ActionView::Template#virtual_path=`.
+*   Add `include_seconds` option for `time_field`.
 
-    *Rafael Mendonça França*
+        <%= form.time_field :foo, include_seconds: false %>
+        # => <input value="16:22" type="time" />
 
-*   Remove deprecated `ActionView::Template#updated_at`.
+    Default includes seconds:
 
-    *Rafael Mendonça França*
+        <%= form.time_field :foo %>
+        # => <input value="16:22:01.440" type="time" />
 
-*   Remove deprecated `updated_at` argument required on `ActionView::Template#initialize`.
+    This allows you to take advantage of [different rendering options](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time#time_value_format) in some browsers.
 
-    *Rafael Mendonça França*
+    *Alex Ghiculescu*
 
-*   Make `locals` argument required on `ActionView::Template#initialize`.
+*   Improve error messages when template file does not exist at absolute filepath.
 
-    *Rafael Mendonça França*
+    *Ted Whang*
 
-*   Remove deprecated `ActionView::Template.finalize_compiled_template_methods`.
+*   Add `:country_code` option to `sms_to` for consistency with `phone_to`.
 
-    *Rafael Mendonça França*
+    *Jonathan Hefner*
 
-*   Remove deprecated `config.action_view.finalize_compiled_template_methods`
+*   OpenSSL constants are now used for Digest computations.
 
-    *Rafael Mendonça França*
+    *Dirkjan Bussink*
 
-*   Remove deprecated support to calling `ActionView::ViewPaths#with_fallback` with a block.
+*   The `translate` helper now passes `default` values that aren't
+    translation keys through `I18n.translate` for interpolation.
 
-    *Rafael Mendonça França*
+    *Jonathan Hefner*
 
-*   Remove deprecated support to passing absolute paths to `render template:`.
+*   Adds option `extname` to `stylesheet_link_tag` to skip default
+    `.css` extension appended to the stylesheet path.
 
-    *Rafael Mendonça França*
+    Before:
 
-*   Remove deprecated support to passing relative paths to `render file:`.
+    ```ruby
+    stylesheet_link_tag "style.less"
+    # <link href="/stylesheets/style.less.scss" rel="stylesheet">
+    ```
 
-    *Rafael Mendonça França*
+    After:
 
-*   Remove support to template handlers that don't accept two arguments.
+    ```ruby
+    stylesheet_link_tag "style.less", extname: false, skip_pipeline: true, rel: "stylesheet/less"
+    # <link href="/stylesheets/style.less" rel="stylesheet/less">
+    ```
 
-    *Rafael Mendonça França*
+    *Abhay Nikam*
 
-*   Remove deprecated pattern argument in `ActionView::Template::PathResolver`.
+*   Deprecate `render` locals to be assigned to instance variables.
 
-    *Rafael Mendonça França*
+    *Petrik de Heus*
 
-*   Remove deprecated support to call private methods from object in some view helpers.
+*   Remove legacy default `media=screen` from `stylesheet_link_tag`.
 
-    *Rafael Mendonça França*
+    *André Luis Leal Cardoso Junior*
 
-*   `ActionView::Helpers::TranslationHelper#translate` accepts a block, yielding
-    the translated text and the fully resolved translation key:
+*   Change `ActionView::Helpers::FormBuilder#button` to transform `formmethod`
+    attributes into `_method="$VERB"` Form Data to enable varied same-form actions:
 
-        <%= translate(".relative_key") do |translation, resolved_key| %>
-          <span title="<%= resolved_key %>"><%= translation %></span>
+        <%= form_with model: post, method: :put do %>
+          <%= form.button "Update" %>
+          <%= form.button "Delete", formmethod: :delete %>
         <% end %>
+        <%# => <form action="posts/1">
+            =>   <input type="hidden" name="_method" value="put">
+            =>   <button type="submit">Update</button>
+            =>   <button type="submit" formmethod="post" name="_method" value="delete">Delete</button>
+            => </form>
+        %>
 
     *Sean Doyle*
 
-*   Ensure cache fragment digests include all relevant template dependencies when
-    fragments are contained in a block passed to the render helper. Remove the
-    virtual_path keyword arguments found in CacheHelper as they no longer possess
-    any function following 1581cab.
-
-    Fixes #38984.
-
-    *Aaron Lipman*
-
-*   Deprecate `config.action_view.raise_on_missing_translations` in favor of
-    `config.i18n.raise_on_missing_translations`.
-
-    New generalized configuration option now determines whether an error should be raised
-    for missing translations in controllers and views.
+*   Change `ActionView::Helpers::UrlHelper#button_to` to *always* render a
+    `<button>` element, regardless of whether or not the content is passed as
+    the first argument or as a block.
 
-    *fatkodima*
+        <%= button_to "Delete", post_path(@post), method: :delete %>
+        # => <form action="/posts/1"><input type="hidden" name="_method" value="delete"><button type="submit">Delete</button></form>
 
-*   Instrument layout rendering in `TemplateRenderer#render_with_layout` as `render_layout.action_view`,
-    and include (when necessary) the layout's virtual path in notification payloads for collection and partial renders.
-
-    *Zach Kemp*
-
-*   `ActionView::Base.annotate_rendered_view_with_filenames` annotates HTML output with template file names.
-
-    *Joel Hawksley*, *Aaron Patterson*
-
-*   `ActionView::Helpers::TranslationHelper#translate` returns nil when
-    passed `default: nil` without a translation matching `I18n#translate`.
-
-    *Stefan Wrobel*
-
-*   `OptimizedFileSystemResolver` prefers template details in order of locale,
-    formats, variants, handlers.
-
-    *Iago Pimenta*
-
-*   Added `class_names` helper to create a CSS class value with conditional classes.
-
-    *Joel Hawksley*, *Aaron Patterson*
-
-*   Add support for conditional values to TagBuilder.
-
-    *Joel Hawksley*
+        <%= button_to post_path(@post), method: :delete do %>
+          Delete
+        <% end %>
+        # => <form action="/posts/1"><input type="hidden" name="_method" value="delete"><button type="submit">Delete</button></form>
 
-*   `ActionView::Helpers::FormOptionsHelper#select` should mark option for `nil` as selected.
+    *Sean Doyle*, *Dusan Orlovic*
 
-    ```ruby
-    @post = Post.new
-    @post.category = nil
-
-    # Before
-    select("post", "category", none: nil, programming: 1, economics: 2)
-    # =>
-    # <select name="post[category]" id="post_category">
-    #   <option value="">none</option>
-    #  <option value="1">programming</option>
-    #  <option value="2">economics</option>
-    # </select>
-
-    # After
-    select("post", "category", none: nil, programming: 1, economics: 2)
-    # =>
-    # <select name="post[category]" id="post_category">
-    #   <option selected="selected" value="">none</option>
-    #  <option value="1">programming</option>
-    #  <option value="2">economics</option>
-    # </select>
-    ```
+*   Add `config.action_view.preload_links_header` to allow disabling of
+    the `Link` header being added by default when using `stylesheet_link_tag`
+    and `javascript_include_tag`.
 
-    *bogdanvlviv*
+    *Andrew White*
 
-*   Log lines for partial renders and started template renders are now
-    emitted at the `DEBUG` level instead of `INFO`.
+*   The `translate` helper now resolves `default` values when a `nil` key is
+    specified, instead of always returning `nil`.
 
-    Completed template renders are still logged at the `INFO` level.
+    *Jonathan Hefner*
 
-    *DHH*
+*   Add `config.action_view.image_loading` to configure the default value of
+    the `image_tag` `:loading` option.
 
-*   ActionView::Helpers::SanitizeHelper: support rails-html-sanitizer 1.1.0.
+    By setting `config.action_view.image_loading = "lazy"`, an application can opt in to
+    lazy loading images sitewide, without changing view code.
 
-    *Juanito Fatas*
+    *Jonathan Hefner*
 
-*   Added `phone_to` helper method to create a link from mobile numbers.
+*   `ActionView::Helpers::FormBuilder#id` returns the value
+    of the `<form>` element's `id` attribute. With a `method` argument, returns
+    the `id` attribute for a form field with that name.
 
-    *Pietro Moro*
+        <%= form_for @post do |f| %>
+          <%# ... %>
 
-*   annotated_source_code returns an empty array so TemplateErrors without a
-    template in the backtrace are surfaced properly by DebugExceptions.
+          <% content_for :sticky_footer do %>
+            <%= form.button(form: f.id) %>
+          <% end %>
+        <% end %>
 
-    *Guilherme Mansur*, *Kasper Timm Hansen*
+    *Sean Doyle*
 
-*   Add autoload for SyntaxErrorInTemplate so syntax errors are correctly raised by DebugExceptions.
+*   `ActionView::Helpers::FormBuilder#field_id` returns the value generated by
+    the FormBuilder for the given attribute name.
 
-    *Guilherme Mansur*, *Gannon McGibbon*
+        <%= form_for @post do |f| %>
+          <%= f.label :title %>
+          <%= f.text_field :title, aria: { describedby: f.field_id(:title, :error) } %>
+          <%= tag.span("is blank", id: f.field_id(:title, :error) %>
+        <% end %>
 
-*   `RenderingHelper` supports rendering objects that `respond_to?` `:render_in`.
+    *Sean Doyle*
 
-    *Joel Hawksley*, *Natasha Umer*, *Aaron Patterson*, *Shawn Allen*, *Emily Plummer*, *Diana Mounter*, *John Hawthorn*, *Nathan Herald*, *Zaid Zawaideh*, *Zach Ahn*
+*   Add `tag.attributes` to transform a Hash into HTML Attributes, ready to be
+    interpolated into ERB.
 
-*   Fix `select_tag` so that it doesn't change `options` when `include_blank` is present.
+        <input <%= tag.attributes(type: :text, aria: { label: "Search" }) %> >
+        # => <input type="text" aria-label="Search">
 
-    *Younes SERRAJ*
+    *Sean Doyle*
 
 
-Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionview/CHANGELOG.md) for previous changes.
+Please check [6-1-stable](https://github.com/rails/rails/blob/6-1-stable/actionview/CHANGELOG.md) for previous changes.

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2004-2020 David Heinemeier Hansson
+Copyright (c) 2004-2021 David Heinemeier Hansson
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/lib/action_view/base.rb

@@ -9,7 +9,7 @@ require "action_view/context"
 require "action_view/template"
 require "action_view/lookup_context"
 
-module ActionView #:nodoc:
+module ActionView # :nodoc:
   # = Action View Base
   #
   # Action View templates can be written in several ways.
@@ -142,7 +142,7 @@ module ActionView #:nodoc:
     include Helpers, ::ERB::Util, Context
 
     # Specify the proc used to decorate input tags that refer to attributes with errors.
-    cattr_accessor :field_error_proc, default: Proc.new { |html_tag, instance| "<div class=\"field_with_errors\">#{html_tag}</div>".html_safe }
+    cattr_accessor :field_error_proc, default: Proc.new { |html_tag, instance| content_tag :div, html_tag, class: "field_with_errors" }
 
     # How to complete the streaming when an exception occurs.
     # This is our best guess: first try to close the attribute, then the tag.
@@ -156,9 +156,6 @@ module ActionView #:nodoc:
     # Specify default_formats that can be rendered.
     cattr_accessor :default_formats
 
-    # Specify whether an error should be raised for missing translations
-    cattr_accessor :raise_on_missing_translations, default: false
-
     # Specify whether submit_tag should automatically disable on click
     cattr_accessor :automatically_disable_submit_tag, default: true
 
@@ -179,7 +176,7 @@ module ActionView #:nodoc:
         ActionView::Resolver.caching = value
       end
 
-      def xss_safe? #:nodoc:
+      def xss_safe? # :nodoc:
         true
       end
 
@@ -227,7 +224,7 @@ module ActionView #:nodoc:
 
     # :startdoc:
 
-    def initialize(lookup_context, assigns, controller) #:nodoc:
+    def initialize(lookup_context, assigns, controller) # :nodoc:
       @_config = ActiveSupport::InheritableOptions.new
 
       @lookup_context = lookup_context

data/lib/action_view/buffers.rb

@@ -18,7 +18,7 @@ module ActionView
   #   sbuf << 5
   #   puts sbuf # => "hello\u0005"
   #
-  class OutputBuffer < ActiveSupport::SafeBuffer #:nodoc:
+  class OutputBuffer < ActiveSupport::SafeBuffer # :nodoc:
     def initialize(*)
       super
       encode!
@@ -38,7 +38,7 @@ module ActionView
     alias :safe_append= :safe_concat
   end
 
-  class StreamingBuffer #:nodoc:
+  class StreamingBuffer # :nodoc:
     def initialize(block)
       @block = block
     end