actionview 5.0.0.rc1 → 5.0.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18a90de0809651abe647f6226ad50a18a850dd74
-  data.tar.gz: 5efd67dfbbaef15c7a8b9924dc75649c050b178b
+  metadata.gz: e8b3721ce2507d7b9067da855ad90f146cee478c
+  data.tar.gz: 3b1ac62c559fa959bb7d23a5d37e489236c735af
 SHA512:
-  metadata.gz: 3e49e650795fc92a4a1b172e367c9e6a91e94b65de26e22194f3e504375cbb30f26cbd6fb1a9b84936560cb79e2cfb10c89b4cc7a77b42d4bbb4385cbe95032c
-  data.tar.gz: bc8f526cabd17074af1ce3665850f7da7f431b8ac842237cdbfc4f5831a89d86c5a544e38e260e44549b96bcbbe68ca6fe541e57378ca879dc88c963e67683e2
+  metadata.gz: 1780255cdb54fe0685814e5104a5faf7bde16ffb7cba4fd07abc4033e82c386bd2d63011bc7a398493f399f7fc0291490f0f5a5bdc428dcf30c11a3be444332d
+  data.tar.gz: c6596a1577f814cca03c60680acf688e211f5c36e6e9503a86700f9f47d351e6841dc33531831bc14d499ea79bbd9e3ebee8bb76e42521e840acb4f994a94d43

data/CHANGELOG.md

@@ -1,3 +1,43 @@
+## Rails 5.0.0.rc2 (June 22, 2016) ##
+
+*   Change `datetime_field` and `datetime_field_tag` to generate `datetime-local` fields.
+
+    As a new specification of the HTML 5 the text field type `datetime` will no longer exist
+    and it is recomended to use `datetime-local`.
+    Ref: https://html.spec.whatwg.org/multipage/forms.html#local-date-and-time-state-(type=datetime-local)
+
+    *Herminio Torres*
+
+*   Raw template handler (which is also the default template handler in Rails 5) now outputs
+    HTML-safe strings.
+
+    In Rails 5 the default template handler was changed to the raw template handler. Because
+    the ERB template handler escaped strings by default this broke some applications that
+    expected plain JS or HTML files to be rendered unescaped. This fixes the issue caused
+    by changing the default handler by changing the Raw template handler to output HTML-safe
+    strings.
+
+    *Eileen M. Uchitelle*
+
+*   `select_tag`'s `include_blank` option for generation for blank option tag, now adds an empty space label,
+     when the value as well as content for option tag are empty, so that we confirm with html specification.
+     Ref: https://www.w3.org/TR/html5/forms.html#the-option-element.
+
+    Generation of option before:
+
+    ```html
+    <option value=""></option>
+    ```
+
+    Generation of option after:
+
+    ```html
+    <option value="" label=" "></option>
+    ```
+
+    *Vipul A M *
+
+
 ## Rails 5.0.0.rc1 (May 06, 2016) ##
 
 *   No changes.
@@ -25,12 +65,6 @@
 
     *Neil Matatall*
 
-*   Deprecate `datetime_field` and `datetime_field_tag` helpers.
-    Datetime input type was removed from HTML specification.
-    One can use `datetime_local_field` and `datetime_local_field_tag` instead.
-
-    *Wojciech Wnętrzak*
-
 *   Added log "Rendering ...", when starting to render a template to log that
     we have started rendering something. This helps to easily identify the origin
     of queries in the log whether they came from controller or views.
@@ -314,6 +348,10 @@
 
     *Mauro George*
 
+*   Add support for Reply-To field in `mail_to` helper.
+
+    *Mark Dodwell*
+
 *   Add an explicit error message, in `ActionView::PartialRenderer` for partial
     `rendering`, when the value of option `as` has invalid characters.
 

data/lib/action_view/digestor.rb

@@ -6,13 +6,6 @@ module ActionView
   class Digestor
     @@digest_mutex   = Mutex.new
 
-    class PerRequestDigestCacheExpiry < Struct.new(:app) # :nodoc:
-      def call(env)
-        ActionView::LookupContext::DetailsKey.clear
-        app.call(env)
-      end
-    end
-
     class << self
       # Supported options:
       #
@@ -22,7 +15,7 @@ module ActionView
       # * <tt>partial</tt>  - Specifies whether the template is a partial
       def digest(name:, finder:, dependencies: [])
         dependencies ||= []
-        cache_key = ([ name ].compact + dependencies).join('.')
+        cache_key = [ name, finder.rendered_format, dependencies ].flatten.compact.join('.')
 
         # this is a correctly done double-checked locking idiom
         # (Concurrent::Map's lookups have volatile semantics)
@@ -46,8 +39,12 @@ module ActionView
       def tree(name, finder, partial = false, seen = {})
         logical_name = name.gsub(%r|/_|, "/")
 
-        if finder.disable_cache { finder.exists?(logical_name, [], partial) }
-          template = finder.disable_cache { finder.find(logical_name, [], partial) }
+        options = {}
+        options[:formats] = [finder.rendered_format] if finder.rendered_format
+
+        if finder.disable_cache { finder.exists?(logical_name, [], partial, [], options) }
+          template = finder.disable_cache { finder.find(logical_name, [], partial, [], options) }
+          finder.rendered_format ||= template.formats.first
 
           if node = seen[template.identifier] # handle cycles in the tree
             node

data/lib/action_view/gem_version.rb

@@ -8,7 +8,7 @@ module ActionView
     MAJOR = 5
     MINOR = 0
     TINY  = 0
-    PRE   = "rc1"
+    PRE   = "rc2"
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/action_view/helpers/date_helper.rb

@@ -3,6 +3,7 @@ require 'action_view/helpers/tag_helper'
 require 'active_support/core_ext/array/extract_options'
 require 'active_support/core_ext/date/conversions'
 require 'active_support/core_ext/hash/slice'
+require 'active_support/core_ext/object/acts_like'
 require 'active_support/core_ext/object/with_options'
 
 module ActionView

data/lib/action_view/helpers/form_helper.rb

@@ -860,24 +860,6 @@ module ActionView
       #
       #   file_field(:attachment, :file, class: 'file_input')
       #   # => <input type="file" id="attachment_file" name="attachment[file]" class="file_input" />
-      #
-      # ==== Gotcha
-      #
-      # The HTML specification says that when a file field is empty, web browsers
-      # do not send any value to the server. Unfortunately this introduces a
-      # gotcha: if a +User+ model has an +avatar+ field, and no file is selected,
-      # then the +avatar+ parameter is empty. Thus, any mass-assignment idiom like
-      #
-      #   @user.update(params[:user])
-      #
-      # wouldn't update the +avatar+ field.
-      #
-      # To prevent this, the helper generates an auxiliary hidden field before
-      # every file field. The hidden field has the same name as the file one and
-      # a blank value.
-      #
-      # In case you don't want the helper to generate this hidden field you can
-      # specify the <tt>include_hidden: false</tt> option.
       def file_field(object_name, method, options = {})
         Tags::FileField.new(object_name, method, self, options).render
       end
@@ -1092,42 +1074,9 @@ module ActionView
         Tags::TimeField.new(object_name, method, self, options).render
       end
 
-      # Returns a text_field of type "datetime".
-      #
-      #   datetime_field("user", "born_on")
-      #   # => <input id="user_born_on" name="user[born_on]" type="datetime" />
-      #
-      # The default value is generated by trying to call +strftime+ with "%Y-%m-%dT%T.%L%z"
-      # on the object's value, which makes it behave as expected for instances
-      # of DateTime and ActiveSupport::TimeWithZone.
-      #
-      #   @user.born_on = Date.new(1984, 1, 12)
-      #   datetime_field("user", "born_on")
-      #   # => <input id="user_born_on" name="user[born_on]" type="datetime" value="1984-01-12T00:00:00.000+0000" />
-      #
-      # You can create values for the "min" and "max" attributes by passing
-      # instances of Date or Time to the options hash.
-      #
-      #   datetime_field("user", "born_on", min: Date.today)
-      #   # => <input id="user_born_on" name="user[born_on]" type="datetime" min="2014-05-20T00:00:00.000+0000" />
-      #
-      # Alternatively, you can pass a String formatted as an ISO8601 datetime
-      # with UTC offset as the values for "min" and "max."
-      #
-      #   datetime_field("user", "born_on", min: "2014-05-20T00:00:00+0000")
-      #   # => <input id="user_born_on" name="user[born_on]" type="datetime" min="2014-05-20T00:00:00.000+0000" />
-      #
-      def datetime_field(object_name, method, options = {})
-        ActiveSupport::Deprecation.warn(<<-MESSAGE.squish)
-          datetime_field is deprecated and will be removed in Rails 5.1.
-          Use datetime_local_field instead.
-        MESSAGE
-        Tags::DatetimeField.new(object_name, method, self, options).render
-      end
-
       # Returns a text_field of type "datetime-local".
       #
-      #   datetime_local_field("user", "born_on")
+      #   datetime_field("user", "born_on")
       #   # => <input id="user_born_on" name="user[born_on]" type="datetime-local" />
       #
       # The default value is generated by trying to call +strftime+ with "%Y-%m-%dT%T"
@@ -1135,25 +1084,27 @@ module ActionView
       # of DateTime and ActiveSupport::TimeWithZone.
       #
       #   @user.born_on = Date.new(1984, 1, 12)
-      #   datetime_local_field("user", "born_on")
+      #   datetime_field("user", "born_on")
       #   # => <input id="user_born_on" name="user[born_on]" type="datetime-local" value="1984-01-12T00:00:00" />
       #
       # You can create values for the "min" and "max" attributes by passing
       # instances of Date or Time to the options hash.
       #
-      #   datetime_local_field("user", "born_on", min: Date.today)
+      #   datetime_field("user", "born_on", min: Date.today)
       #   # => <input id="user_born_on" name="user[born_on]" type="datetime-local" min="2014-05-20T00:00:00.000" />
       #
       # Alternatively, you can pass a String formatted as an ISO8601 datetime as
       # the values for "min" and "max."
       #
-      #   datetime_local_field("user", "born_on", min: "2014-05-20T00:00:00")
+      #   datetime_field("user", "born_on", min: "2014-05-20T00:00:00")
       #   # => <input id="user_born_on" name="user[born_on]" type="datetime-local" min="2014-05-20T00:00:00.000" />
       #
-      def datetime_local_field(object_name, method, options = {})
+      def datetime_field(object_name, method, options = {})
         Tags::DatetimeLocalField.new(object_name, method, self, options).render
       end
 
+      alias datetime_local_field datetime_field
+
       # Returns a text_field of type "month".
       #
       #   month_field("user", "born_on")

data/lib/action_view/helpers/form_tag_helper.rb

@@ -134,13 +134,15 @@ module ActionView
 
         if options.include?(:include_blank)
           include_blank = options.delete(:include_blank)
+          options_for_blank_options_tag = { value: '' }
 
           if include_blank == true
             include_blank = ''
+            options_for_blank_options_tag[:label] = ' '
           end
 
           if include_blank
-            option_tags = content_tag("option".freeze, include_blank, value: '').safe_concat(option_tags)
+            option_tags = content_tag("option".freeze, include_blank, options_for_blank_options_tag).safe_concat(option_tags)
           end
         end
 
@@ -683,21 +685,6 @@ module ActionView
         text_field_tag(name, value, options.merge(type: :time))
       end
 
-      # Creates a text field of type "datetime".
-      #
-      # === Options
-      # * <tt>:min</tt> - The minimum acceptable value.
-      # * <tt>:max</tt> - The maximum acceptable value.
-      # * <tt>:step</tt> - The acceptable value granularity.
-      # * Otherwise accepts the same options as text_field_tag.
-      def datetime_field_tag(name, value = nil, options = {})
-        ActiveSupport::Deprecation.warn(<<-MESSAGE.squish)
-          datetime_field_tag is deprecated and will be removed in Rails 5.1.
-          Use datetime_local_field_tag instead.
-        MESSAGE
-        text_field_tag(name, value, options.merge(type: :datetime))
-      end
-
       # Creates a text field of type "datetime-local".
       #
       # === Options
@@ -705,10 +692,12 @@ module ActionView
       # * <tt>:max</tt> - The maximum acceptable value.
       # * <tt>:step</tt> - The acceptable value granularity.
       # * Otherwise accepts the same options as text_field_tag.
-      def datetime_local_field_tag(name, value = nil, options = {})
+      def datetime_field_tag(name, value = nil, options = {})
         text_field_tag(name, value, options.merge(type: 'datetime-local'))
       end
 
+      alias datetime_local_field_tag datetime_field_tag
+
       # Creates a text field of type "month".
       #
       # === Options

data/lib/action_view/helpers/tags/datetime_field.rb

@@ -14,7 +14,7 @@ module ActionView
         private
 
           def format_date(value)
-            value.try(:strftime, "%Y-%m-%dT%T.%L%z")
+            raise NoImplementedError
           end
 
           def datetime_value(value)

data/lib/action_view/helpers/tags/file_field.rb

@@ -2,21 +2,6 @@ module ActionView
   module Helpers
     module Tags # :nodoc:
       class FileField < TextField # :nodoc:
-
-        def render
-          options = @options.stringify_keys
-
-          if options.fetch("include_hidden", true)
-            add_default_name_and_id(options)
-            options[:type] = "file"
-            tag("input", name: options["name"], type: "hidden", value: "") + tag("input", options)
-          else
-            options.delete("include_hidden")
-            @options = options
-
-            super
-          end
-        end
       end
     end
   end

data/lib/action_view/railtie.rb

@@ -40,7 +40,7 @@ module ActionView
     initializer "action_view.per_request_digest_cache" do |app|
       ActiveSupport.on_load(:action_view) do
         if app.config.consider_all_requests_local
-          app.middleware.use ActionView::Digestor::PerRequestDigestCacheExpiry
+          app.executor.to_run { ActionView::LookupContext::DetailsKey.clear }
         end
       end
     end

data/lib/action_view/template/handlers/raw.rb

@@ -2,7 +2,7 @@ module ActionView
   module Template::Handlers
     class Raw
       def call(template)
-        "#{template.source.inspect};"
+        "#{template.source.inspect}.html_safe;"
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionview
 version: !ruby/object:Gem::Version
-  version: 5.0.0.rc1
+  version: 5.0.0.rc2
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-06 00:00:00.000000000 Z
+date: 2016-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.rc1
+        version: 5.0.0.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.rc1
+        version: 5.0.0.rc2
 - !ruby/object:Gem::Dependency
   name: builder
   requirement: !ruby/object:Gem::Requirement
@@ -98,28 +98,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.rc1
+        version: 5.0.0.rc2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.rc1
+        version: 5.0.0.rc2
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.rc1
+        version: 5.0.0.rc2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.rc1
+        version: 5.0.0.rc2
 description: Simple, battle-tested conventions and helpers for building web pages.
 email: david@loudthinking.com
 executables: []
@@ -250,7 +250,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - none
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: Rendering framework putting the V in MVC (part of Rails).