actionview-link_to_blank 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d94df4b22bc97e22f3f7bf4481a8a6da7f46b74e
-  data.tar.gz: db5845fcd712e90a911633b6aed88698a80b89c3
+  metadata.gz: 0837a75705362f414dcb9dd238aea537af4eabd1
+  data.tar.gz: 3d620166ab6a1ab7c0621835627cc8943f30fda4
 SHA512:
-  metadata.gz: d98dcb095120c4a4425b6a390143cb8f2273673105f708bb1a676623a68cd156485a32b6c8dd9f79e9f960b42e27236f20d8815a195508cba2c682be1f244412
-  data.tar.gz: 16d233161d4c60b986303c855253be0f92458eb9da6afce71043572d1a94c7dcb5023bb38f64a1dcc361b185b92558d2c32f8cdc95ff7bd1ca166aa864113a9e
+  metadata.gz: 37c1f11a79b91925f569596f5d0abff9f5bb6428b2a5a109cf163779827cfb8d8487571d07c352b7d1fe7ea9d728146948b90214b3c1511e848648197c2c0c98
+  data.tar.gz: 1f769ba6546238ea40ea7407f8e115a824bf15d4bff76a16650a7026d4d25288f81c3667c5ab852c1dcc0f6cf0f0ef94a60fc378c0ceff384befaef95378be01

data/.travis.yml

@@ -2,11 +2,16 @@ language: ruby
 rvm:
  - 1.9.3
  - 2.0.0
+ - 2.1.1
+before_install:
+  - gem update bundler
 gemfile:
  - gemfiles/rails_3_2.gemfile
  - gemfiles/rails_3_2_stable.gemfile
  - gemfiles/rails_4_0.gemfile
  - gemfiles/rails_4_0_stable.gemfile
+ - gemfiles/rails_4_1.gemfile
+ - gemfiles/rails_4_1_stable.gemfile
  - gemfiles/rails_master.gemfile
 branches:
   only:

data/Appraisals

@@ -5,12 +5,19 @@ appraise "rails_3_2" do
 end
 
 appraise "rails_4_0" do
-  version = '~> 4.0.0.beta'
+  version = '~> 4.0.0'
+  gem 'actionpack', version
+  gem 'activesupport', version
+end
+
+appraise "rails_4_1" do
+  version = '~> 4.1.0'
   gem 'actionpack', version
   gem 'activesupport', version
 end
 
 appraise "rails_master" do
+  gem 'actionview', github: 'rails/rails', branch: 'master'
   gem 'actionpack', github: 'rails/rails', branch: 'master'
   gem 'activesupport', github: 'rails/rails', branch: 'master'
 end
@@ -24,3 +31,8 @@ appraise "rails_4_0_stable" do
   gem 'actionpack', github: 'rails/rails', branch: '4-0-stable'
   gem 'activesupport', github: 'rails/rails', branch: '4-0-stable'
 end
+
+appraise "rails_4_1_stable" do
+  gem 'actionpack', github: 'rails/rails', branch: '4-1-stable'
+  gem 'activesupport', github: 'rails/rails', branch: '4-1-stable'
+end

data/README.md

@@ -73,17 +73,18 @@ Use the `link_to_blank` helper method, equal `link_to('foo', target: '_blank')`
 
     $ bundle exec rake
 
-If you want to run against actionpack v3 and v4, run below:
+If you want to run against actionpack v3.2, v4.0, v4.1, and v4.2 run below:
 
-    $ bundle exec rake appraisal:install
-    $ bundle exec rake appraisal
+    $ bundle exec appraisal install
+    $ bundle exec appraisal rake
 
 Test for specific version:
 
-    $ bundle exec rake appraisal:install
-    $ bundle exec rake appraisal:rails4_0
+    $ bundle exec appraisal install
+    $ bundle exec appraisal rails_4_0 rake
 
-Prepare rails4_0 and rails3_2
+Prepare rails_3_2(gem), rails_3_2_stable(github), rails_4_0(gem), rails_4_0_stable(github), rails_4_1(gem),
+rails_4_1_stable(github), rails_master(github)
 
 ## Contributing
 

data/actionview-link_to_blank.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "bundler", '>= 1.3'
   spec.add_development_dependency "rake"
   spec.add_development_dependency 'minitest'
 

data/gemfiles/rails_4_0.gemfile

@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "coveralls", :require=>false
 gem "pry"
 gem "appraisal", :github=>"thoughtbot/appraisal"
-gem "actionpack", "~> 4.0.0.beta"
-gem "activesupport", "~> 4.0.0.beta"
+gem "actionpack", "~> 4.0.0"
+gem "activesupport", "~> 4.0.0"
 
 gemspec :path=>".././"

data/gemfiles/rails_4_1.gemfile

@@ -0,0 +1,11 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "coveralls", :require=>false
+gem "pry"
+gem "appraisal", :github=>"thoughtbot/appraisal"
+gem "actionpack", "~> 4.1.0"
+gem "activesupport", "~> 4.1.0"
+
+gemspec :path=>".././"

data/gemfiles/rails_4_1_stable.gemfile

@@ -0,0 +1,11 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "coveralls", :require=>false
+gem "pry"
+gem "appraisal", :github=>"thoughtbot/appraisal"
+gem "actionpack", :github=>"rails/rails", :branch=>"4-1-stable"
+gem "activesupport", :github=>"rails/rails", :branch=>"4-1-stable"
+
+gemspec :path=>".././"

data/gemfiles/rails_master.gemfile

@@ -5,6 +5,7 @@ source "https://rubygems.org"
 gem "coveralls", :require=>false
 gem "pry"
 gem "appraisal", :github=>"thoughtbot/appraisal"
+gem "actionview", :github=>"rails/rails", :branch=>"master"
 gem "actionpack", :github=>"rails/rails", :branch=>"master"
 gem "activesupport", :github=>"rails/rails", :branch=>"master"
 

data/lib/action_view/link_to_blank/link_to_blank.rb

@@ -24,7 +24,7 @@ module LinkToBlank
             if block_given?
               block.arity <= 1 ? capture(name, &block) : capture(name, options, html_options, &block)
             else
-              name
+              ERB::Util.html_escape(name)
             end
           else
             link_to_blank(name, options, html_options)

data/lib/action_view/link_to_blank/version.rb

@@ -1,5 +1,5 @@
 module ActionView
   module LinkToBlank
-    VERSION = "1.0.2"
+    VERSION = "1.0.3"
   end
 end

data/test/test_actionview-link_to_blank.rb

@@ -4,6 +4,7 @@ Coveralls.wear!
 
 require 'minitest/autorun'
 require 'active_support/concern'
+require 'active_support/deprecation'
 require 'active_support/core_ext'
 require 'active_support/testing/deprecation'
 require 'action_view'
@@ -25,7 +26,14 @@ module RenderERBUtils
   end
 end
 
-class TestActionViewLinkToBlank < MiniTest::Unit::TestCase
+# Rails4.1, this code is here:
+# actionview/test/template/url_helper_test.rb
+# and base class is ActiveSupport::TestCase
+
+# Ensure backward compatibility with Minitest 4
+Minitest::Test = MiniTest::Unit::TestCase unless defined?(Minitest::Test)
+
+class TestActionViewLinkToBlank < MiniTest::Test
 
   # In a few cases, the helper proxies to 'controller'
   # or request.
@@ -33,6 +41,9 @@ class TestActionViewLinkToBlank < MiniTest::Unit::TestCase
   # In those cases, we'll set up a simple mock
   attr_accessor :controller, :request
 
+  cattr_accessor :request_forgery
+  self.request_forgery = false
+
   routes = ActionDispatch::Routing::RouteSet.new
   routes.draw do
     get "/" => "foo#bar"
@@ -109,6 +120,7 @@ class TestActionViewLinkToBlank < MiniTest::Unit::TestCase
 
   def test_link_tag_with_custom_onclick
     link = link_to_blank("Hello", "http://www.example.com", onclick: "alert('yay!')")
+    # NOTE: differences between AP v3 and v4
     escaped_onclick = ActionPack::VERSION::MAJOR == 3 ? %{alert(&#x27;yay!&#x27;)} : %{alert(&#39;yay!&#39;)}
     expected = %{<a href="http://www.example.com" onclick="#{escaped_onclick}" target="_blank">Hello</a>}
     assert_dom_equal expected, link
@@ -131,7 +143,7 @@ class TestActionViewLinkToBlank < MiniTest::Unit::TestCase
 
   def test_link_tag_with_deprecated_confirm
     skip('Not deprecate in Rails3.2') if ActionPack::VERSION::MAJOR == 3
-    skip('Remove in Rails4.1') if ActionPack::VERSION::MAJOR == 4 && ActionPack::VERSION::MINOR >= 1
+    skip('Remove in Rails4.1') if ActionPack::VERSION::MAJOR >= 4 && ActionPack::VERSION::MINOR >= 1
     assert_deprecated ":confirm option is deprecated and will be removed from Rails 4.1. Use 'data: { confirm: \'Text\' }' instead" do
       assert_dom_equal(
         %{<a href="http://www.example.com" data-confirm="Are you sure?" target="_blank">Hello</a>},
@@ -217,7 +229,7 @@ class TestActionViewLinkToBlank < MiniTest::Unit::TestCase
 
   def test_link_tag_using_post_javascript_and_with_deprecated_confirm
     skip('Not deprecate in Rails3.2') if ActionPack::VERSION::MAJOR == 3
-    skip('Remove in Rails4.1') if ActionPack::VERSION::MAJOR == 4 && ActionPack::VERSION::MINOR >= 1
+    skip('Remove in Rails4.1') if ActionPack::VERSION::MAJOR >= 4 && ActionPack::VERSION::MINOR >= 1
     assert_deprecated ":confirm option is deprecated and will be removed from Rails 4.1. Use 'data: { confirm: \'Text\' }' instead" do
       assert_dom_equal(
         %{<a href="http://www.example.com" data-method="post" rel="nofollow" data-confirm="Are you serious?" target="_blank">Hello</a>},
@@ -235,7 +247,7 @@ class TestActionViewLinkToBlank < MiniTest::Unit::TestCase
 
   def test_link_tag_using_delete_javascript_and_href_and_with_deprecated_confirm
     skip('Not deprecate in Rails3.2') if ActionPack::VERSION::MAJOR == 3
-    skip('Remove in Rails4.1') if ActionPack::VERSION::MAJOR == 4 && ActionPack::VERSION::MINOR >= 1
+    skip('Remove in Rails4.1') if ActionPack::VERSION::MAJOR >= 4 && ActionPack::VERSION::MINOR >= 1
     assert_deprecated ":confirm option is deprecated and will be removed from Rails 4.1. Use 'data: { confirm: \'Text\' }' instead" do
       assert_dom_equal(
         %{<a href="\#" rel="nofollow" data-confirm="Are you serious?" data-method="delete" target="_blank">Destroy</a>},
@@ -254,6 +266,13 @@ class TestActionViewLinkToBlank < MiniTest::Unit::TestCase
       link_to_blank('/', class: "special") { content_tag(:span, 'Example site') }
   end
 
+  def test_link_tag_using_block_and_hash
+    assert_dom_equal(
+      %{<a href="/" target="_blank"><span>Example site</span></a>},
+      link_to_blank(url_hash) { content_tag(:span, 'Example site') }
+    )
+  end
+
   def test_link_tag_using_block_in_erb
     out = render_erb %{<%= link_to_blank('/') do %>Example site<% end %>}
     assert_equal '<a href="/" target="_blank">Example site</a>', out
@@ -297,12 +316,17 @@ class TestActionViewLinkToBlank < MiniTest::Unit::TestCase
       link_to_blank_unless(true, "Showing", url_hash) {
         "test"
       }
+
+    # FIXME
+    assert_equal %{&lt;b&gt;Showing&lt;/b&gt;}, link_to_blank_unless(true, "<b>Showing</b>", url_hash)
+    assert_equal %{<a href="/">&lt;b&gt;Showing&lt;/b&gt;</a>}, link_to_unless(false, "<b>Showing</b>", url_hash)
+    assert_equal %{<b>Showing</b>}, link_to_unless(true, "<b>Showing</b>".html_safe, url_hash)
+    assert_equal %{<a href="/"><b>Showing</b></a>}, link_to_unless(false, "<b>Showing</b>".html_safe, url_hash)
   end
 
   def test_link_to_if
     assert_equal "Showing", link_to_blank_if(false, "Showing", url_hash)
     assert_dom_equal %{<a href="/" target="_blank">Listing</a>}, link_to_blank_if(true, "Listing", url_hash)
-    assert_equal "Showing", link_to_blank_if(false, "Showing", url_hash)
   end
 
   def request_for_url(url, opts = {})

metadata

@@ -1,83 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: actionview-link_to_blank
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - sanemat
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-16 00:00:00.000000000 Z
+date: 2014-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Alias link_to with target _blank
@@ -87,8 +87,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Appraisals
 - Gemfile
 - LICENSE.txt
@@ -99,6 +99,8 @@ files:
 - gemfiles/rails_3_2_stable.gemfile
 - gemfiles/rails_4_0.gemfile
 - gemfiles/rails_4_0_stable.gemfile
+- gemfiles/rails_4_1.gemfile
+- gemfiles/rails_4_1_stable.gemfile
 - gemfiles/rails_master.gemfile
 - lib/action_view/link_to_blank/link_to_blank.rb
 - lib/action_view/link_to_blank/railtie.rb
@@ -115,17 +117,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Alias link_to with target _blank