actionview-link_to_blank 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 882f89144dc2e878857d65ac92b50d38ca234072
-  data.tar.gz: 3700974c556b62a290bff69c8fd5a061dbbce275
+  metadata.gz: 715f878476a9378270e1a4604e8fea8902d76b0d
+  data.tar.gz: 446cce5ca24c5ccbe7c32292f2f35f97eb1213ac
 SHA512:
-  metadata.gz: d2299f2ee20a6a6f901f7ed8aabff6a2b002ac3d9d617f0435022969571598c16a1477ecb6d79a669811074b8a47c13dad4e8edcd4c793c48809c71fb3621385
-  data.tar.gz: 4332768310ecab9833f07ba114080efc482b54a59d6232f19c65b52a83033db84b1d4de70ade7d0268a61459a09ac0fe92bb36fbaa02c0107b6e0bfc1d6a7734
+  metadata.gz: ecd1af6c26c444bb273bff7eb31a0105f17cba233fed92c52767ec850947e3228d9d09c886f9da497ad17a510f0c0419d7dc55ecd38fc2774a10e43b3e8a31d4
+  data.tar.gz: a83cabe7ee673970841c3d42d25e2e28d06c8cbd8d52e2534ac03a5ba3aab9d78eb3189598509036bda43893bf042ce7d67cff0ebf269bf78e8582079f8074de

data/.travis.yml

@@ -0,0 +1,10 @@
+language: ruby
+rvm:
+ - 1.9.3
+ - 2.0.0
+gemfile:
+ - gemfiles/rails3.2/Gemfile
+ - gemfiles/rails4.0/Gemfile
+branches:
+  only:
+    - master

data/README.md

@@ -1,6 +1,8 @@
-# Actionview::LinkToBlank
+# ActionView::LinkToBlank
 
-TODO: Write a gem description
+[![Build Status](https://api.travis-ci.org/sanemat/actionview-link_to_blank.png?branch=master)](https://travis-ci.org/sanemat/actionview-link_to_blank)
+
+Add helper method, link_to with target _blank
 
 ## Installation
 
@@ -18,7 +20,51 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+Use the `link_to_blank` helper method, equal `link_to('foo', target: '_blank')`
+
+### Signatures
+
+    link_to_blank(body, url, html_options = {})
+      # url is a String; you can use URL helpers like
+      # posts_path
+
+    link_to_blank(body, url_options = {}, html_options = {})
+      # url_options, except :confirm or :method,
+      # is passed to url_for
+
+    link_to_blank(options = {}, html_options = {}) do
+      # name
+    end
+
+    link_to_blank(url, html_options = {}) do
+      # name
+    end
+
+### Examples
+
+    link_to_blank "Profile", profile_path(@profile)
+    # => <a href="/profiles/1" target="_blank">Profile</a>
+
+    <%= link_to_blank(@profile) do %>
+      <strong><%= @profile.name %></strong> -- <span>Check it out!</span>
+    <% end %>
+    # => <a href="/profiles/1" target="_blank">
+           <strong>David</strong> -- <span>Check it out!</span>
+         </a>
+
+## Testing
+
+    $ bundle exec rake
+
+If you want to run against actionpack v3 and v4, run below:
+
+    $ bundle --gemfile=gemfiles/rails3.2/Gemfile --path=.bundle
+    # this install gems to gemfiles/rails3.2/.bundle/xxx
+    $ bundle exec rake BUNDLE_GEMFILE=gemfiles/rails3.2/Gemfile
+
+    $ bundle --gemfile=gemfiles/rails4.0/Gemfile --path=.bundle
+    # this install gems to gemfiles/rails4.0/.bundle/xxx
+    $ bundle exec rake BUNDLE_GEMFILE=gemfiles/rails4.0/Gemfile
 
 ## Contributing
 

data/Rakefile

@@ -1 +1,10 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rake/testtask'
+
+desc 'Default Task'
+task :default => :test
+
+Rake::TestTask.new do |t|
+  t.libs << 'test'
+  t.pattern = 'test/test_*.rb'
+end

data/actionview-link_to_blank.gemspec

@@ -20,6 +20,9 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency 'minitest'
+  spec.add_development_dependency 'pry'
 
   spec.add_dependency 'actionpack'
+  spec.add_dependency 'activesupport'
 end

data/gemfiles/rails3.2/Gemfile

@@ -0,0 +1,8 @@
+source 'https://rubygems.org'
+
+version = '~> 3.2'
+gem 'actionpack', version
+gem 'activesupport', version
+
+# Specify your gem's dependencies in actionview-link_to_blank.gemspec
+gemspec path: File.join('..', '..')

data/gemfiles/rails4.0/Gemfile

@@ -0,0 +1,8 @@
+source 'https://rubygems.org'
+
+version = '~> 4.0.0.beta'
+gem 'actionpack', version
+gem 'activesupport', version
+
+# Specify your gem's dependencies in actionview-link_to_blank.gemspec
+gemspec path: File.join('..', '..')

data/lib/action_view/link_to_blank/link_to_blank.rb

@@ -13,7 +13,7 @@ module LinkToBlank
             html_options = args[2] || {}
 
             # override
-            html_options.merge!(target: '_blank')
+            html_options.reverse_merge! target: '_blank'
 
             link_to(name, options, html_options)
           end

data/lib/action_view/link_to_blank/version.rb

@@ -1,5 +1,5 @@
 module ActionView
   module LinkToBlank
-    VERSION = "0.0.2"
+    VERSION = "0.0.4"
   end
 end

data/test/test_actionview-link_to_blank.rb

@@ -0,0 +1,289 @@
+#coding: utf-8
+require 'minitest/autorun'
+require 'active_support/concern'
+require 'active_support/core_ext'
+require 'active_support/testing/deprecation'
+require 'action_view'
+require 'action_view/link_to_blank/link_to_blank'
+require 'action_dispatch'
+
+# Copy from actionpack/test/abstract_unit.rb
+module RenderERBUtils
+  def render_erb(string)
+    @virtual_path = nil
+
+    template = ActionView::Template.new(
+      string.strip,
+      "test template",
+      ActionView::Template::Handlers::ERB,
+      {})
+
+    template.render(self, {}).strip
+  end
+end
+
+class TestActionViewLinkToBlank < MiniTest::Unit::TestCase
+
+  # In a few cases, the helper proxies to 'controller'
+  # or request.
+  #
+  # In those cases, we'll set up a simple mock
+  attr_accessor :controller, :request
+
+  routes = ActionDispatch::Routing::RouteSet.new
+  routes.draw do
+    get "/" => "foo#bar"
+    get "/other" => "foo#other"
+    get "/article/:id" => "foo#article", :as => :article
+  end
+
+  include ActionView::Helpers::UrlHelper
+  include routes.url_helpers
+
+  include ActionDispatch::Assertions::DomAssertions
+  include ActiveSupport::Testing::Deprecation
+  include ActionView::Context
+  include RenderERBUtils
+
+  def hash_for(options = {})
+    { controller: "foo", action: "bar" }.merge!(options)
+  end
+  alias url_hash hash_for
+
+  def test_initialization
+    [:link_to_blank].each do |method|
+      assert_includes ActionView::Helpers::UrlHelper.instance_methods, method
+    end
+  end
+
+  def test_link_tag_with_straight_url
+    assert_dom_equal %{<a href="http://www.example.com" target="_blank">Hello</a>}, link_to_blank("Hello", "http://www.example.com")
+  end
+
+  def test_link_tag_without_host_option
+    assert_dom_equal(%{<a href="/" target="_blank">Test Link</a>}, link_to_blank('Test Link', url_hash))
+  end
+
+  def test_link_tag_with_host_option
+    hash = hash_for(host: "www.example.com")
+    expected = %{<a href="http://www.example.com/" target="_blank">Test Link</a>}
+    assert_dom_equal(expected, link_to_blank('Test Link', hash))
+  end
+
+  def test_link_tag_with_query
+    expected = %{<a href="http://www.example.com?q1=v1&amp;q2=v2" target="_blank">Hello</a>}
+    assert_dom_equal expected, link_to_blank("Hello", "http://www.example.com?q1=v1&q2=v2")
+  end
+
+  def test_link_tag_with_query_and_no_name
+    expected = %{<a href="http://www.example.com?q1=v1&amp;q2=v2" target="_blank">http://www.example.com?q1=v1&amp;q2=v2</a>}
+    assert_dom_equal expected, link_to_blank(nil, "http://www.example.com?q1=v1&q2=v2")
+  end
+
+  def test_link_tag_with_back
+    env = {"HTTP_REFERER" => "http://www.example.com/referer"}
+    @controller = Struct.new(:request).new(Struct.new(:env).new(env))
+    expected = %{<a href="#{env["HTTP_REFERER"]}" target="_blank">go back</a>}
+    assert_dom_equal expected, link_to_blank('go back', :back)
+  end
+
+  def test_link_tag_with_back_and_no_referer
+    @controller = Struct.new(:request).new(Struct.new(:env).new({}))
+    link = link_to_blank('go back', :back)
+    assert_dom_equal %{<a href="javascript:history.back()" target="_blank">go back</a>}, link
+  end
+
+  def test_link_tag_with_img
+    link = link_to_blank("<img src='/favicon.jpg' />".html_safe, "/")
+    expected = %{<a href="/" target="_blank"><img src='/favicon.jpg' /></a>}
+    assert_dom_equal expected, link
+  end
+
+  def test_link_with_nil_html_options
+    link = link_to_blank("Hello", url_hash, nil)
+    assert_dom_equal %{<a href="/" target="_blank">Hello</a>}, link
+  end
+
+  def test_link_tag_with_custom_onclick
+    link = link_to_blank("Hello", "http://www.example.com", onclick: "alert('yay!')")
+    escaped_onclick = ActionPack::VERSION::MAJOR == 3 ? %{alert(&#x27;yay!&#x27;)} : %{alert(&#39;yay!&#39;)}
+    expected = %{<a href="http://www.example.com" onclick="#{escaped_onclick}" target="_blank">Hello</a>}
+    assert_dom_equal expected, link
+  end
+
+  def test_link_tag_with_javascript_confirm
+    assert_dom_equal(
+      %{<a href="http://www.example.com" data-confirm="Are you sure?" target="_blank">Hello</a>},
+      link_to_blank("Hello", "http://www.example.com", data: { confirm: "Are you sure?" })
+    )
+    assert_dom_equal(
+      %{<a href="http://www.example.com" data-confirm="You cant possibly be sure, can you?" target="_blank">Hello</a>},
+      link_to_blank("Hello", "http://www.example.com", data: { confirm: "You cant possibly be sure, can you?" })
+    )
+    assert_dom_equal(
+      %{<a href="http://www.example.com" data-confirm="You cant possibly be sure,\n can you?" target="_blank">Hello</a>},
+      link_to_blank("Hello", "http://www.example.com", data: { confirm: "You cant possibly be sure,\n can you?" })
+    )
+  end
+
+  def test_link_tag_with_deprecated_confirm
+    skip('Not deprecate in Rails3.2') if ActionPack::VERSION::MAJOR == 3
+    assert_deprecated ":confirm option is deprecated and will be removed from Rails 4.1. Use 'data: { confirm: \'Text\' }' instead" do
+      assert_dom_equal(
+        %{<a href="http://www.example.com" data-confirm="Are you sure?" target="_blank">Hello</a>},
+        link_to_blank("Hello", "http://www.example.com", confirm: "Are you sure?")
+      )
+    end
+    assert_deprecated ":confirm option is deprecated and will be removed from Rails 4.1. Use 'data: { confirm: \'Text\' }' instead" do
+      assert_dom_equal(
+        %{<a href="http://www.example.com" data-confirm="You cant possibly be sure, can you?" target="_blank">Hello</a>},
+        link_to_blank("Hello", "http://www.example.com", confirm: "You cant possibly be sure, can you?")
+      )
+    end
+    assert_deprecated ":confirm option is deprecated and will be removed from Rails 4.1. Use 'data: { confirm: \'Text\' }' instead" do
+      assert_dom_equal(
+        %{<a href="http://www.example.com" data-confirm="You cant possibly be sure,\n can you?" target="_blank">Hello</a>},
+        link_to_blank("Hello", "http://www.example.com", confirm: "You cant possibly be sure,\n can you?")
+      )
+    end
+  end
+
+  def test_link_to_with_remote
+    assert_dom_equal(
+      %{<a href="http://www.example.com" data-remote="true" target="_blank">Hello</a>},
+      link_to_blank("Hello", "http://www.example.com", remote: true)
+    )
+  end
+
+  def test_link_to_with_remote_false
+    assert_dom_equal(
+      %{<a href="http://www.example.com" target="_blank">Hello</a>},
+      link_to_blank("Hello", "http://www.example.com", remote: false)
+    )
+  end
+
+  def test_link_to_with_symbolic_remote_in_non_html_options
+    assert_dom_equal(
+      %{<a href="/" data-remote="true" target="_blank">Hello</a>},
+      link_to_blank("Hello", hash_for(remote: true), {})
+    )
+  end
+
+  def test_link_to_with_string_remote_in_non_html_options
+    assert_dom_equal(
+      %{<a href="/" data-remote="true" target="_blank">Hello</a>},
+      link_to_blank("Hello", hash_for('remote' => true), {})
+    )
+  end
+
+  def test_link_tag_using_post_javascript
+    assert_dom_equal(
+      %{<a href="http://www.example.com" data-method="post" rel="nofollow" target="_blank">Hello</a>},
+      link_to_blank("Hello", "http://www.example.com", method: :post)
+    )
+  end
+
+  def test_link_tag_using_delete_javascript
+    assert_dom_equal(
+      %{<a href="http://www.example.com" rel="nofollow" data-method="delete" target="_blank">Destroy</a>},
+      link_to_blank("Destroy", "http://www.example.com", method: :delete)
+    )
+  end
+
+  def test_link_tag_using_delete_javascript_and_href
+    assert_dom_equal(
+      %{<a href="\#" rel="nofollow" data-method="delete" target="_blank">Destroy</a>},
+      link_to_blank("Destroy", "http://www.example.com", method: :delete, href: '#')
+    )
+  end
+
+  def test_link_tag_using_post_javascript_and_rel
+    assert_dom_equal(
+      %{<a href="http://www.example.com" data-method="post" rel="example nofollow" target="_blank">Hello</a>},
+      link_to_blank("Hello", "http://www.example.com", method: :post, rel: 'example')
+    )
+  end
+
+  def test_link_tag_using_post_javascript_and_confirm
+    assert_dom_equal(
+      %{<a href="http://www.example.com" data-method="post" rel="nofollow" data-confirm="Are you serious?" target="_blank">Hello</a>},
+      link_to_blank("Hello", "http://www.example.com", method: :post, data: { confirm: "Are you serious?" })
+    )
+  end
+
+  def test_link_tag_using_post_javascript_and_with_deprecated_confirm
+    skip('Not deprecate in Rails3.2') if ActionPack::VERSION::MAJOR == 3
+    assert_deprecated ":confirm option is deprecated and will be removed from Rails 4.1. Use 'data: { confirm: \'Text\' }' instead" do
+      assert_dom_equal(
+        %{<a href="http://www.example.com" data-method="post" rel="nofollow" data-confirm="Are you serious?" target="_blank">Hello</a>},
+        link_to_blank("Hello", "http://www.example.com", method: :post, confirm: "Are you serious?")
+      )
+    end
+  end
+
+  def test_link_tag_using_delete_javascript_and_href_and_confirm
+    assert_dom_equal(
+      %{<a href="\#" rel="nofollow" data-confirm="Are you serious?" data-method="delete" target="_blank">Destroy</a>},
+      link_to_blank("Destroy", "http://www.example.com", method: :delete, href: '#', data: { confirm: "Are you serious?" })
+    )
+  end
+
+  def test_link_tag_using_delete_javascript_and_href_and_with_deprecated_confirm
+    skip('Not deprecate in Rails3.2') if ActionPack::VERSION::MAJOR == 3
+    assert_deprecated ":confirm option is deprecated and will be removed from Rails 4.1. Use 'data: { confirm: \'Text\' }' instead" do
+      assert_dom_equal(
+        %{<a href="\#" rel="nofollow" data-confirm="Are you serious?" data-method="delete" target="_blank">Destroy</a>},
+        link_to_blank("Destroy", "http://www.example.com", method: :delete, href: '#', confirm: "Are you serious?")
+      )
+    end
+  end
+
+  def test_link_tag_with_block
+    assert_dom_equal %{<a href="/" target="_blank"><span>Example site</span></a>},
+      link_to_blank('/') { content_tag(:span, 'Example site') }
+  end
+
+  def test_link_tag_with_block_and_html_options
+    assert_dom_equal %{<a class="special" href="/" target="_blank"><span>Example site</span></a>},
+      link_to_blank('/', class: "special") { content_tag(:span, 'Example site') }
+  end
+
+  def test_link_tag_using_block_in_erb
+    out = render_erb %{<%= link_to_blank('/') do %>Example site<% end %>}
+    assert_equal '<a href="/" target="_blank">Example site</a>', out
+  end
+
+  def test_link_tag_with_html_safe_string
+    assert_dom_equal(
+      %{<a href="/article/Gerd_M%C3%BCller" target="_blank">Gerd Müller</a>},
+      link_to_blank("Gerd Müller", article_path("Gerd_Müller".html_safe))
+    )
+  end
+
+  def test_link_tag_escapes_content
+    assert_dom_equal %{<a href="/" target="_blank">Malicious &lt;script&gt;content&lt;/script&gt;</a>},
+      link_to_blank("Malicious <script>content</script>", "/")
+  end
+
+  def test_link_tag_does_not_escape_html_safe_content
+    assert_dom_equal %{<a href="/" target="_blank">Malicious <script>content</script></a>},
+      link_to_blank("Malicious <script>content</script>".html_safe, "/")
+  end
+
+  def test_link_tag_override_specific
+    assert_dom_equal %{<a href="http://www.example.com" target="override">Hello</a>}, link_to_blank("Hello", "http://www.example.com", target: 'override')
+  end
+
+  private
+    # MiniTest does not have build_message method, so I copy from below:
+    # https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/testing/assertions/dom.rb
+    # Test::Unit
+    # http://doc.ruby-lang.org/ja/1.9.3/method/Test=3a=3aUnit=3a=3aAssertions/i/build_message.html
+    # Test::Unit (based on MiniTest)
+    # http://www.ruby-doc.org/stdlib-2.0/libdoc/test/unit/rdoc/Test/Unit/Assertions.html#method-i-message
+    def assert_dom_equal(expected, actual, message = "")
+      expected_dom = HTML::Document.new(expected).root
+      actual_dom   = HTML::Document.new(actual).root
+      assert_equal expected_dom, actual_dom
+    end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionview-link_to_blank
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - sanemat
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-11 00:00:00.000000000 Z
+date: 2013-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,6 +38,34 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +80,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Alias link_to with target _blank
 email:
 - o.gata.ken@gmail.com
@@ -60,15 +102,19 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - actionview-link_to_blank.gemspec
+- gemfiles/rails3.2/Gemfile
+- gemfiles/rails4.0/Gemfile
 - lib/action_view/link_to_blank/link_to_blank.rb
 - lib/action_view/link_to_blank/railtie.rb
 - lib/action_view/link_to_blank/version.rb
 - lib/actionview-link_to_blank.rb
+- test/test_actionview-link_to_blank.rb
 homepage: https://github.com/sanemat/actionview-link_to_blank
 licenses:
 - MIT
@@ -93,4 +139,5 @@ rubygems_version: 2.0.0
 signing_key: 
 specification_version: 4
 summary: Alias link_to with target _blank
-test_files: []
+test_files:
+- test/test_actionview-link_to_blank.rb