actionview-component 1.6.1 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 642717e715c2f33794d3647e8756af86226bf90a9ee40c28496109288fa63201
-  data.tar.gz: a2144dc99b735c2e0cd27b86e5f5b95f60031facc7b47af0e35f3ab0ff2562ba
+  metadata.gz: 57dd1d0375f05f3a5849670716be000a0c8074f4ae63b1d422278006b07e5b32
+  data.tar.gz: 42309cc4774f3405e338cd48a84bc6ee6619ffa3306d98ab8432e8a196d6cb5f
 SHA512:
-  metadata.gz: 34973a14a10b96e2905b2fadfa93828de4014c12f97239a367527aabea8218d13281cdc8dbad7808f9575afafb66172202612a65e51506db4f2e8be4a6055354
-  data.tar.gz: 893531f33aaf0982973df46acc708e42de316464a3860bda12a693e810283d12d7d5a3a5a743149fa406645ff7242f9ef04509f18a0c855379b867f6ef4f9117
+  metadata.gz: fdaad351b7db8bb6aab8e94294c221c50993cdd851fac8d43f64c3628627b5652be8fd3bb93f450467f74401433d4d3fffea560ca9ddc8c78fe645fbe0596056
+  data.tar.gz: f75561cba609fd4eecf3ac958a0cf9ef9ee9300772c3016749cf3ab5bea5e5ac5f4c2005f47623587e5a80fb9c9d71a18aeaad33fc9d89ba8c1123191dc0345b

data/.github/ISSUE_TEMPLATE

@@ -0,0 +1,30 @@
+<!-- **** Filing a Feature Request? Include these sections. **** -->
+
+### Feature request
+<!-- Provide a summary of the behavior. -->
+
+### Motivation
+
+<!-- What would you like to do with this feature? Can you provide
+context or references to similar behavior in other libraries. -->
+
+
+
+
+
+<!-- **** Filing a Bug Report? Include these sections. **** -->
+
+### Steps to reproduce
+<!-- Provide an series of steps or, better yet, a link to a repo to
+demonstrate the bug you've identified. -->
+
+### Expected behavior
+<!-- Tell us what should happen -->
+
+### Actual behavior
+<!-- Tell us what happens instead -->
+
+### System configuration
+**Rails version**:
+
+**Ruby version**:

data/.github/PULL_REQUEST_TEMPLATE

@@ -0,0 +1,19 @@
+<!-- https://github.com/github/actionview-component/blob/master/CONTRIBUTING.md#submitting-a-pull-request  -->
+
+### Summary
+
+<!-- Provide a general description of the code changes in your pull
+request... were there any bugs you had fixed? If so, mention them. If
+these bugs have open GitHub issues, be sure to tag them here as well,
+to keep the conversation linked together. -->
+
+### Other Information
+
+<!-- If there's anything else that's important and relevant to your pull
+request, mention that information here. This could include
+benchmarks, or other information.
+
+If you are updating any of the CHANGELOG files or are asked to update the
+CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.
+
+Thanks for contributing to actionview-component! -->

data/.gitignore

@@ -10,6 +10,7 @@
 /test/version_tmp/
 /tmp/
 /test/log/*
+/test/app/tmp/*
 
 # Used by dotenv library to load environment variables.
 # .env

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+# v1.6.2
+
+* Fix Uninitialized Constant error.
+
+    *Jon Palmer*
+
+* Add basic github issue and PR templates.
+
+    *Dylan Clark*
+
+* Update readme phrasing around previews.
+
+    *Justin Coyne*
+
 # v1.6.1
 
 * Allow Previews to have no layout.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    actionview-component (1.6.1)
+    actionview-component (1.6.2)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -234,7 +234,7 @@ end
 ```
 
 ### Previewing Components
-`ActionView::Component::Preview`s provide a way to see how components look by visiting a special URL that renders them.
+`ActionView::Component::Preview` provides a way to see how components look by visiting a special URL that renders them.
 In the previous example, the preview class for `TestComponent` would be called `TestComponentPreview` and located in `test/components/previews/test_component_preview.rb`.
 To see the preview of the component with a given title, implement a method that renders the component.
 You can define as many examples as you want:

data/lib/action_view/component/base.rb

@@ -127,12 +127,6 @@ module ActionView
           instance_method(:initialize).source_location[0]
         end
 
-        def eager_load!
-          self.descendants.each do |descendant|
-            descendant.compile if descendant.has_initializer?
-          end
-        end
-
         def compiled?
           @compiled && ActionView::Base.cache_template_loading
         end

data/lib/action_view/component/railtie.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "rails"
+require "action_view/component"
 
 module ActionView
   module Component
@@ -25,7 +26,6 @@ module ActionView
         require "railties/lib/rails/components_controller"
         require "railties/lib/rails/component_examples_controller"
 
-        app.config.eager_load_namespaces << ActionView::Component::Base
         options = app.config.action_view_component
 
         if options.show_previews && options.preview_path
@@ -33,6 +33,14 @@ module ActionView
         end
       end
 
+      initializer "action_view_component.eager_load_actions" do
+        ActiveSupport.on_load(:after_initialize) do
+          ActionView::Component::Base.descendants.each do |descendant|
+            descendant.compile if descendant.has_initializer? && config.eager_load
+          end
+        end
+      end
+
       initializer "action_view_component.compile_config_methods" do
         ActiveSupport.on_load(:action_view_component) do
           config.compile_methods! if config.respond_to?(:compile_methods!)

data/lib/action_view/component/version.rb

@@ -5,7 +5,7 @@ module ActionView
     module VERSION
       MAJOR = 1
       MINOR = 6
-      PATCH = 1
+      PATCH = 2
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionview-component
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.6.2
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-25 00:00:00.000000000 Z
+date: 2020-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -129,6 +129,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/ISSUE_TEMPLATE"
+- ".github/PULL_REQUEST_TEMPLATE"
 - ".github/workflows/ruby_on_rails.yml"
 - ".gitignore"
 - ".rubocop.yml"