actionview-component 1.5.3 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00a684cf9aea1c6f1a94dd0c980fd7d1889e2b17fb165006817063de69b6f721
-  data.tar.gz: 30766fd4333fb8d708369e48192b000ba4a5136898bd82e98273d5fc9445fb67
+  metadata.gz: e0d1497b59c35721a9d9c48906ca5b1a64eb30f72e9bfd17d0da2437820e7e87
+  data.tar.gz: e703a27db8cac4a589f6d8f78e3ffc2bb7783af16d7c49c8986d06db7155bcd4
 SHA512:
-  metadata.gz: aeaf7ae830c1b2e099a974228c0c072c41481c9ddd0f000c488727066df837f872b9616f064962bc3e8adee2fd20d86e0894d97cbc1a6c049faa5b6eea4636b1
-  data.tar.gz: ef32ebd537e7d36ae192b29b7aa756a8bf2efca96ef19d87e751e0dea11369616e0fc6e8a5848c2ea45230eb7eb46fac18e6e6eb6778ee58749193f22d3f2a44
+  metadata.gz: 481e35fdf095d48a1c3a33795d8e1d8b0be6a6b6944b149e5a6320add88f8748f4ea8e19282cd90bb62f9858291cd07084e9b1221051fcfb89f70b7dd6471281
+  data.tar.gz: 45fd087cc394799a8f21044c58de91a3aeee93dc29c8fbd8ff8c4a1979977bb86bc47d38341f51a37bbe93038c81b77908ec8d634d4d41b064a11585a684ae44

data/CHANGELOG.md

@@ -1,3 +1,33 @@
+# v1.6.0
+
+* Avoid dropping elements in the render_inline test helper.
+
+    *@dark-panda*
+
+* Add test for helpers.asset_url.
+
+    *Christopher Coleman*
+
+* Add rudimentary compatibility with better_html.
+
+    *Joel Hawksley*
+
+* Template-less variants fall back to default template.
+
+    *Asger Behncke Jacobsen*, *Cesario Uy*
+
+* Generated tests use new naming convention.
+
+    *Simon Træls Ravn*
+
+* Eliminate sqlite dependency.
+
+    *Simon Dawson*
+
+* Add support for rendering components via #to_component_class
+
+    *Vinicius Stock*
+
 # v1.5.3
 
 * Add support for RSpec to generators.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    actionview-component (1.5.3)
+    actionview-component (1.6.0)
 
 GEM
   remote: https://rubygems.org/
@@ -62,6 +62,14 @@ GEM
       tzinfo (~> 1.1)
       zeitwerk (~> 2.1, >= 2.1.8)
     ast (2.4.0)
+    better_html (1.0.14)
+      actionview (>= 4.0)
+      activesupport (>= 4.0)
+      ast (~> 2.0)
+      erubi (~> 1.4)
+      html_tokenizer (~> 0.0.6)
+      parser (>= 2.4)
+      smart_properties
     builder (3.2.3)
     concurrent-ruby (1.1.5)
     crass (1.0.5)
@@ -71,6 +79,7 @@ GEM
     haml (5.1.2)
       temple (>= 0.8.0)
       tilt
+    html_tokenizer (0.0.7)
     i18n (1.6.0)
       concurrent-ruby (~> 1.0)
     jaro_winkler (1.5.3)
@@ -139,6 +148,7 @@ GEM
     slim (4.0.1)
       temple (>= 0.7.6, < 0.9)
       tilt (>= 2.0.6, < 2.1)
+    smart_properties (1.15.0)
     sprockets (3.7.2)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
@@ -163,6 +173,7 @@ PLATFORMS
 
 DEPENDENCIES
   actionview-component!
+  better_html (~> 1)
   bundler (>= 1.14)
   haml (~> 5)
   minitest (= 5.1.0)

data/README.md

@@ -7,7 +7,7 @@
 
 This gem is meant to serve as a precursor to upstreaming the `ActionView::Component` class into Rails. It also serves to enable the usage of `ActionView::Component` in older versions of Rails.
 
-Preliminary support for rendering components was merged into Rails `6.1.0.alpha` in https://github.com/rails/rails/pull/36388. Assuming `ActionView::Component` makes it into Rails `6.1`, this gem will then exist to serve as a backport.
+Preliminary support for rendering components was merged into Rails `6.1.0.alpha` in https://github.com/rails/rails/pull/36388. Assuming `ActionView::Component` makes it into Rails, this gem will then exist to serve as a backport.
 
 ## Design philosophy
 
@@ -163,6 +163,24 @@ Components can be rendered via:
 
 `render(component: TestComponent, locals: { foo: :bar })`
 
+**Rendering components through models**
+
+Passing model instances will cause `render` to look for its respective component class.
+
+The component is instantiated with the rendered model instance.
+
+Example for a `Post` model:
+
+`render(@post)`
+
+```ruby
+class PostComponent < ActionView::Component
+  def initialize(post)
+    @post = post
+  end
+end
+```
+
 The following syntax has been deprecated and will be removed in v2.0.0:
 
 `render(TestComponent.new(foo: :bar))`

data/actionview-component.gemspec

@@ -39,6 +39,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest", "= 5.1.0"
   spec.add_development_dependency "haml", "~> 5"
   spec.add_development_dependency "slim", "~> 4.0"
+  spec.add_development_dependency "better_html", "~> 1"
   spec.add_development_dependency "rubocop", "= 0.74"
   spec.add_development_dependency "rubocop-github", "~> 0.13.0"
 end

data/lib/action_view/component.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
 require "action_view/component/monkey_patch"
+require "action_view/component/active_model_conversion_monkey_patch"
 require "action_view/component/base"
 require "action_view/component/railtie"

data/lib/action_view/component/active_model_conversion_monkey_patch.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module ActiveModel
+  module Conversion
+    def to_component_class
+      "#{self.class.name}Component".safe_constantize
+    end
+  end
+end

data/lib/action_view/component/base.rb

@@ -14,8 +14,6 @@ module ActionView
 
       delegate :form_authenticity_token, :protect_against_forgery?, to: :helpers
 
-      validate :variant_exists
-
       # Entrypoint for rendering components. Called by ActionView::Base#render.
       #
       # view_context: ActionView context from calling view
@@ -94,12 +92,6 @@ module ActionView
 
       private
 
-      def variant_exists
-        return if self.class.variants.include?(@variant) || @variant.nil?
-
-        errors.add(:variant, "'#{@variant}' has no template defined")
-      end
-
       def request
         @request ||= controller.request
       end
@@ -114,7 +106,7 @@ module ActionView
         end
 
         def call_method_name(variant)
-          if variant.present?
+          if variant.present? && variants.include?(variant)
             "call_#{variant}"
           else
             "call"
@@ -164,7 +156,7 @@ module ActionView
         end
 
         def identifier
-          ""
+          source_location
         end
 
         private

data/lib/action_view/component/monkey_patch.rb

@@ -17,6 +17,8 @@ class ActionView::Base
         options.new(args).render_in(self, &block)
       elsif options.is_a?(Hash) && options.has_key?(:component)
         options[:component].new(options[:locals]).render_in(self, &block)
+      elsif options.respond_to?(:to_component_class) && !options.to_component_class.nil?
+        options.to_component_class.new(options).render_in(self, &block)
       else
         super
       end

data/lib/action_view/component/test_helpers.rb

@@ -4,7 +4,7 @@ module ActionView
   module Component
     module TestHelpers
       def render_inline(component, **args, &block)
-        Nokogiri::HTML(controller.view_context.render(component, args, &block)).css("body > *")
+        Nokogiri::HTML.fragment(controller.view_context.render(component, args, &block))
       end
 
       def controller

data/lib/action_view/component/version.rb

@@ -4,8 +4,8 @@ module ActionView
   module Component
     module VERSION
       MAJOR = 1
-      MINOR = 5
-      PATCH = 3
+      MINOR = 6
+      PATCH = 0
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/lib/rails/generators/test_unit/templates/component_test.rb.tt

@@ -6,7 +6,7 @@ class <%= class_name %>ComponentTest < ActiveSupport::TestCase
   test "component renders something useful" do
     # assert_equal(
     #   %(<span title="my title">Hello, components!</span>),
-    #   render_inline(<%= class_name %>, attr: "value") { "Hello, components!" }.css("span").to_html
+    #   render_inline(<%= class_name %>Component, attr: "value") { "Hello, components!" }.css("span").to_html
     # )
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionview-component
 version: !ruby/object:Gem::Version
-  version: 1.5.3
+  version: 1.6.0
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-26 00:00:00.000000000 Z
+date: 2019-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: better_html
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -128,6 +142,7 @@ files:
 - Rakefile
 - actionview-component.gemspec
 - lib/action_view/component.rb
+- lib/action_view/component/active_model_conversion_monkey_patch.rb
 - lib/action_view/component/base.rb
 - lib/action_view/component/monkey_patch.rb
 - lib/action_view/component/preview.rb