actionview-component 1.3.5 → 1.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6dcbc0baecff7159dafaf87120583a68055e931c926679bd8b3300b54232c769
-  data.tar.gz: b5eda121857a5dd034457e1fda306bfb1fa1e666159d20729feaee2f2da699c1
+  metadata.gz: c2e23869593e0482d71b3ea0b082ad050fe3c9a5e1ad4b5e05e5cac866c7f31d
+  data.tar.gz: 9ce7d1453f35246746f90153959c9848baa221042eec5a6376aae59c1433d3f7
 SHA512:
-  metadata.gz: cf003dfb9c8dc68e7cef33e4c78fa947006b58ec076658586c95bece8a65e98516989cba81a58bcd632a1706c9b7b93b19bd51006b6f8291256dc0062ba4db1c
-  data.tar.gz: f7707687dee6494852ad1520154d57acff346f4fa6dcdb2bfc0e2f324ed4a4683fe7f2e3b8b1f3a69a38ff4dae0e0a72b53a7f73a3f524d0f7f6e9b07a625fd3
+  metadata.gz: 11bacc8bde616fb29d27bf8fc7b56d5cea3d42c645fd425e56ea638427755ebb89c6b6575702b37f18cf33e56026a7fdbe11582be0bdd610deaea236043ba736
+  data.tar.gz: 59a4a1e938c98e5c942581181e11f4af00d1ac36e49dace1ad42dfc1b10ca8da6cb589d68b07a7adcd3f6a80facab0621cd5be03e1e2eaf082dd18bf0daaf305

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# v1.3.6
+
+* Allow template file names without format.
+
+    *Joel Hawksley*
+
+* Add support for translations.
+
+    *Juan Manuel Ramallo*
+
 # v1.3.5
 
 * Re-expose `controller` method.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    actionview-component (1.3.5)
+    actionview-component (1.3.6)
 
 GEM
   remote: https://rubygems.org/

data/lib/action_view/component/base.rb

@@ -64,6 +64,7 @@ module ActionView
         @view_renderer ||= view_context.view_renderer
         @lookup_context ||= view_context.lookup_context
         @view_flow ||= view_context.view_flow
+        @virtual_path ||= virtual_path
 
         @content = view_context.capture(&block) if block_given?
         validate!
@@ -84,6 +85,12 @@ module ActionView
         @controller ||= view_context.controller
       end
 
+      # Looks for the source file path of the initialize method of the instance's class.
+      # Removes the first part of the path and the extension.
+      def virtual_path
+        self.class.source_location.gsub(%r{(.*app/)|(.rb)}, "")
+      end
+
       class << self
         def inherited(child)
           child.include Rails.application.routes.url_helpers unless child < Rails.application.routes.url_helpers
@@ -91,11 +98,16 @@ module ActionView
           super
         end
 
+        def source_location
+          instance_method(:initialize).source_location[0]
+        end
+
         # Compile template to #call instance method, assuming it hasn't been compiled already.
         # We could in theory do this on app boot, at least in production environments.
         # Right now this just compiles the template the first time the component is rendered.
         def compile
           return if @compiled && ActionView::Base.cache_template_loading
+          ensure_initializer_defined
 
           class_eval <<-RUBY, __FILE__, __LINE__ + 1
             def call
@@ -109,6 +121,17 @@ module ActionView
 
         private
 
+        # Require #initialize to be defined so that we can use
+        # method#source_location to look up the file name
+        # of the component.
+        #
+        # If we were able to only support Ruby 2.7+,
+        # We could just use Module#const_source_location,
+        # rendering this unnecessary.
+        def ensure_initializer_defined
+          raise NotImplementedError.new("#{self} must implement #initialize.") unless self.instance_method(:initialize).owner == self
+        end
+
         def compiled_template
           handler = ActionView::Template.handler_for_extension(File.extname(template_file_path).gsub(".", ""))
           template = File.read(template_file_path)
@@ -121,20 +144,15 @@ module ActionView
         end
 
         def template_file_path
-          raise NotImplementedError.new("#{self} must implement #initialize.") unless self.instance_method(:initialize).owner == self
-
-          filename = self.instance_method(:initialize).source_location[0]
-          filename_without_extension = filename[0..-(File.extname(filename).length + 1)]
-          sibling_template_files = Dir["#{filename_without_extension}.????.{#{ActionView::Template.template_handler_extensions.join(',')}}"] - [filename]
+          sibling_template_files =
+            Dir["#{source_location.split(".")[0]}.*{#{ActionView::Template.template_handler_extensions.join(',')}}"] - [source_location]
 
           if sibling_template_files.length > 1
             raise StandardError.new("More than one template found for #{self}. There can only be one sidecar template file per component.")
           end
 
           if sibling_template_files.length == 0
-            raise NotImplementedError.new(
-              "Could not find a template file for #{self}."
-            )
+            raise NotImplementedError.new("Could not find a template file for #{self}.")
           end
 
           sibling_template_files[0]

data/lib/action_view/component/version.rb

@@ -5,7 +5,7 @@ module ActionView
     module VERSION
       MAJOR = 1
       MINOR = 3
-      PATCH = 5
+      PATCH = 6
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionview-component
 version: !ruby/object:Gem::Version
-  version: 1.3.5
+  version: 1.3.6
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-17 00:00:00.000000000 Z
+date: 2019-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler