actionpack 6.1.6 → 7.0.0.alpha1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of actionpack might be problematic. Click here for more details.

Files changed (107) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +99 -527
  3. data/MIT-LICENSE +2 -1
  4. data/README.rdoc +2 -3
  5. data/lib/abstract_controller/asset_paths.rb +1 -1
  6. data/lib/abstract_controller/base.rb +7 -21
  7. data/lib/abstract_controller/caching/fragments.rb +2 -2
  8. data/lib/abstract_controller/caching.rb +1 -1
  9. data/lib/abstract_controller/callbacks.rb +9 -8
  10. data/lib/abstract_controller/collector.rb +2 -2
  11. data/lib/abstract_controller/error.rb +1 -1
  12. data/lib/abstract_controller/helpers.rb +3 -2
  13. data/lib/abstract_controller/logger.rb +1 -1
  14. data/lib/abstract_controller/railties/routes_helpers.rb +2 -0
  15. data/lib/abstract_controller/translation.rb +0 -2
  16. data/lib/abstract_controller/url_for.rb +4 -6
  17. data/lib/action_controller/api.rb +1 -1
  18. data/lib/action_controller/log_subscriber.rb +3 -1
  19. data/lib/action_controller/metal/conditional_get.rb +38 -1
  20. data/lib/action_controller/metal/content_security_policy.rb +1 -1
  21. data/lib/action_controller/metal/cookies.rb +1 -1
  22. data/lib/action_controller/metal/data_streaming.rb +5 -13
  23. data/lib/action_controller/metal/exceptions.rb +19 -30
  24. data/lib/action_controller/metal/flash.rb +6 -2
  25. data/lib/action_controller/metal/http_authentication.rb +15 -16
  26. data/lib/action_controller/metal/instrumentation.rb +55 -52
  27. data/lib/action_controller/metal/live.rb +42 -2
  28. data/lib/action_controller/metal/mime_responds.rb +3 -3
  29. data/lib/action_controller/metal/params_wrapper.rb +7 -7
  30. data/lib/action_controller/metal/permissions_policy.rb +1 -1
  31. data/lib/action_controller/metal/query_tags.rb +16 -0
  32. data/lib/action_controller/metal/redirecting.rb +50 -16
  33. data/lib/action_controller/metal/rendering.rb +7 -7
  34. data/lib/action_controller/metal/request_forgery_protection.rb +64 -20
  35. data/lib/action_controller/metal/rescue.rb +1 -1
  36. data/lib/action_controller/metal/streaming.rb +1 -3
  37. data/lib/action_controller/metal/strong_parameters.rb +25 -29
  38. data/lib/action_controller/metal/testing.rb +0 -2
  39. data/lib/action_controller/metal.rb +7 -10
  40. data/lib/action_controller/railtie.rb +42 -5
  41. data/lib/action_controller/test_case.rb +6 -2
  42. data/lib/action_controller.rb +2 -5
  43. data/lib/action_dispatch/http/cache.rb +13 -6
  44. data/lib/action_dispatch/http/content_security_policy.rb +47 -37
  45. data/lib/action_dispatch/http/filter_parameters.rb +5 -0
  46. data/lib/action_dispatch/http/mime_negotiation.rb +13 -3
  47. data/lib/action_dispatch/http/mime_type.rb +9 -11
  48. data/lib/action_dispatch/http/parameters.rb +4 -4
  49. data/lib/action_dispatch/http/permissions_policy.rb +1 -1
  50. data/lib/action_dispatch/http/request.rb +10 -19
  51. data/lib/action_dispatch/http/response.rb +3 -3
  52. data/lib/action_dispatch/http/url.rb +9 -10
  53. data/lib/action_dispatch/journey/gtg/builder.rb +11 -12
  54. data/lib/action_dispatch/journey/gtg/simulator.rb +10 -4
  55. data/lib/action_dispatch/journey/gtg/transition_table.rb +77 -21
  56. data/lib/action_dispatch/journey/nodes/node.rb +70 -5
  57. data/lib/action_dispatch/journey/path/pattern.rb +22 -13
  58. data/lib/action_dispatch/journey/route.rb +5 -12
  59. data/lib/action_dispatch/journey/router/utils.rb +2 -2
  60. data/lib/action_dispatch/journey/router.rb +1 -1
  61. data/lib/action_dispatch/journey/routes.rb +3 -3
  62. data/lib/action_dispatch/journey/visualizer/fsm.js +49 -24
  63. data/lib/action_dispatch/journey/visualizer/index.html.erb +1 -1
  64. data/lib/action_dispatch/middleware/actionable_exceptions.rb +0 -1
  65. data/lib/action_dispatch/middleware/cookies.rb +7 -3
  66. data/lib/action_dispatch/middleware/debug_exceptions.rb +6 -4
  67. data/lib/action_dispatch/middleware/debug_locks.rb +3 -3
  68. data/lib/action_dispatch/middleware/exception_wrapper.rb +4 -0
  69. data/lib/action_dispatch/middleware/executor.rb +1 -1
  70. data/lib/action_dispatch/middleware/flash.rb +9 -11
  71. data/lib/action_dispatch/middleware/host_authorization.rb +25 -73
  72. data/lib/action_dispatch/middleware/remote_ip.rb +16 -4
  73. data/lib/action_dispatch/middleware/session/abstract_store.rb +1 -1
  74. data/lib/action_dispatch/middleware/show_exceptions.rb +6 -18
  75. data/lib/action_dispatch/middleware/stack.rb +50 -9
  76. data/lib/action_dispatch/middleware/static.rb +2 -5
  77. data/lib/action_dispatch/middleware/templates/rescues/_message_and_suggestions.html.erb +1 -1
  78. data/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb +4 -11
  79. data/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb +2 -2
  80. data/lib/action_dispatch/middleware/templates/rescues/blocked_host.html.erb +2 -2
  81. data/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb +4 -4
  82. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.html.erb +3 -3
  83. data/lib/action_dispatch/middleware/templates/rescues/layout.erb +28 -18
  84. data/lib/action_dispatch/middleware/templates/rescues/missing_exact_template.html.erb +3 -3
  85. data/lib/action_dispatch/middleware/templates/rescues/missing_template.html.erb +3 -3
  86. data/lib/action_dispatch/middleware/templates/rescues/routing_error.html.erb +3 -3
  87. data/lib/action_dispatch/middleware/templates/rescues/template_error.html.erb +3 -3
  88. data/lib/action_dispatch/middleware/templates/rescues/unknown_action.html.erb +3 -3
  89. data/lib/action_dispatch/middleware/templates/routes/_table.html.erb +5 -14
  90. data/lib/action_dispatch/railtie.rb +8 -2
  91. data/lib/action_dispatch/request/session.rb +43 -13
  92. data/lib/action_dispatch/routing/mapper.rb +44 -72
  93. data/lib/action_dispatch/routing/redirection.rb +0 -2
  94. data/lib/action_dispatch/routing/route_set.rb +7 -4
  95. data/lib/action_dispatch/routing/routes_proxy.rb +1 -1
  96. data/lib/action_dispatch/routing/url_for.rb +1 -2
  97. data/lib/action_dispatch/routing.rb +2 -2
  98. data/lib/action_dispatch/system_test_case.rb +6 -12
  99. data/lib/action_dispatch/system_testing/driver.rb +24 -4
  100. data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb +10 -6
  101. data/lib/action_dispatch/testing/assertions.rb +2 -5
  102. data/lib/action_dispatch/testing/integration.rb +6 -8
  103. data/lib/action_dispatch/testing/test_process.rb +2 -2
  104. data/lib/action_dispatch.rb +1 -1
  105. data/lib/action_pack/gem_version.rb +4 -4
  106. data/lib/action_pack.rb +1 -1
  107. metadata +21 -21
data/CHANGELOG.md CHANGED
@@ -1,107 +1,69 @@
1
- ## Rails 6.1.5.1 (April 26, 2022) ##
1
+ ## Rails 7.0.0.alpha1 (September 15, 2021) ##
2
2
 
3
- * Allow Content Security Policy DSL to generate for API responses.
3
+ * Use a static error message when raising `ActionDispatch::Http::Parameters::ParseError`
4
+ to avoid inadvertently logging the HTTP request body at the `fatal` level when it contains
5
+ malformed JSON.
4
6
 
5
- *Tim Wade*
7
+ Fixes #41145
6
8
 
7
- ## Rails 6.1.5 (March 09, 2022) ##
9
+ *Aaron Lahey*
8
10
 
9
- * Fix `content_security_policy` returning invalid directives.
11
+ * Add `Middleware#delete!` to delete middleware or raise if not found.
10
12
 
11
- Directives such as `self`, `unsafe-eval` and few others were not
12
- single quoted when the directive was the result of calling a lambda
13
- returning an array.
13
+ `Middleware#delete!` works just like `Middleware#delete` but will
14
+ raise an error if the middleware isn't found.
14
15
 
15
- ```ruby
16
- content_security_policy do |policy|
17
- policy.frame_ancestors lambda { [:self, "https://example.com"] }
18
- end
19
- ```
20
-
21
- With this fix the policy generated from above will now be valid.
22
-
23
- *Edouard Chin*
24
-
25
- * Update `HostAuthorization` middleware to render debug info only
26
- when `config.consider_all_requests_local` is set to true.
27
-
28
- Also, blocked host info is always logged with level `error`.
29
-
30
- Fixes #42813.
31
-
32
- *Nikita Vyrko*
33
-
34
- * Dup arrays that get "converted".
35
-
36
- Fixes #43681.
37
-
38
- *Aaron Patterson*
39
-
40
- * Don't show deprecation warning for equal paths.
41
-
42
- *Anton Rieder*
16
+ *Alex Ghiculescu*, *Petrik de Heus*, *Junichi Sato*
43
17
 
44
- * Fix crash in `ActionController::Instrumentation` with invalid HTTP formats.
18
+ * Raise error on unpermitted open redirects.
45
19
 
46
- Fixes #43094.
20
+ Add `allow_other_host` options to `redirect_to`.
21
+ Opt in to this behaviour with `ActionController::Base.raise_on_open_redirects = true`.
47
22
 
48
- *Alex Ghiculescu*
49
-
50
- * Add fallback host for SystemTestCase driven by RackTest.
51
-
52
- Fixes #42780.
53
-
54
- *Petrik de Heus*
55
-
56
- * Add more detail about what hosts are allowed.
57
-
58
- *Alex Ghiculescu*
59
-
60
-
61
- ## Rails 6.1.4.7 (March 08, 2022) ##
62
-
63
- * No changes.
64
-
65
-
66
- ## Rails 6.1.4.6 (February 11, 2022) ##
67
-
68
- * No changes.
23
+ *Gannon McGibbon*
69
24
 
25
+ * Deprecate `poltergeist` and `webkit` (capybara-webkit) driver registration for system testing (they will be removed in Rails 7.1). Add `cuprite` instead.
70
26
 
71
- ## Rails 6.1.4.5 (February 11, 2022) ##
27
+ [Poltergeist](https://github.com/teampoltergeist/poltergeist) and [capybara-webkit](https://github.com/thoughtbot/capybara-webkit) are already not maintained. These usage in Rails are removed for avoiding confusing users.
72
28
 
73
- * Under certain circumstances, the middleware isn't informed that the
74
- response body has been fully closed which result in request state not
75
- being fully reset before the next request
29
+ [Cuprite](https://github.com/rubycdp/cuprite) is a good alternative to Poltergeist. Some guide descriptions are replaced from Poltergeist to Cuprite.
76
30
 
77
- [CVE-2022-23633]
31
+ *Yusuke Iwaki*
78
32
 
33
+ * Exclude additional flash types from `ActionController::Base.action_methods`.
79
34
 
80
- ## Rails 6.1.4.4 (December 15, 2021) ##
35
+ Ensures that additional flash types defined on ActionController::Base subclasses
36
+ are not listed as actions on that controller.
81
37
 
82
- * Fix issue with host protection not allowing host with port in development.
38
+ class MyController < ApplicationController
39
+ add_flash_types :hype
40
+ end
83
41
 
42
+ MyController.action_methods.include?('hype') # => false
84
43
 
85
- ## Rails 6.1.4.3 (December 14, 2021) ##
44
+ *Gavin Morrice*
86
45
 
87
- * Fix issue with host protection not allowing localhost in development.
46
+ * OpenSSL constants are now used for Digest computations.
88
47
 
48
+ *Dirkjan Bussink*
89
49
 
90
- ## Rails 6.1.4.2 (December 14, 2021) ##
50
+ * Remove IE6-7-8 file download related hack/fix from ActionController::DataStreaming module.
91
51
 
92
- * Fix X_FORWARDED_HOST protection. [CVE-2021-44528]
52
+ Due to the age of those versions of IE this fix is no longer relevant, more importantly it creates an edge-case for unexpected Cache-Control headers.
93
53
 
94
- ## Rails 6.1.4.1 (August 19, 2021) ##
54
+ *Tadas Sasnauskas*
95
55
 
96
- * [CVE-2021-22942] Fix possible open redirect in Host Authorization middleware.
56
+ * Configuration setting to skip logging an uncaught exception backtrace when the exception is
57
+ present in `rescued_responses`.
97
58
 
98
- Specially crafted "X-Forwarded-Host" headers in combination with certain
99
- "allowed host" formats can cause the Host Authorization middleware in Action
100
- Pack to redirect users to a malicious website.
59
+ It may be too noisy to get all backtraces logged for applications that manage uncaught
60
+ exceptions via `rescued_responses` and `exceptions_app`.
61
+ `config.action_dispatch.log_rescued_responses` (defaults to `true`) can be set to `false` in
62
+ this case, so that only exceptions not found in `rescued_responses` will be logged.
101
63
 
102
- ## Rails 6.1.4 (June 24, 2021) ##
64
+ *Alexander Azarov*, *Mike Dalessio*
103
65
 
104
- * Ignore file fixtures on `db:fixtures:load`
66
+ * Ignore file fixtures on `db:fixtures:load`.
105
67
 
106
68
  *Kevin Sjöberg*
107
69
 
@@ -109,513 +71,123 @@
109
71
 
110
72
  *Dylan Thacker-Smith*
111
73
 
112
- * Correctly place optional path parameter booleans.
113
-
114
- Previously, if you specify a url parameter that is part of the path as false it would include that part
115
- of the path as parameter for example:
116
-
117
- ```
118
- get "(/optional/:optional_id)/things" => "foo#foo", as: :things
119
- things_path(optional_id: false) # => /things?optional_id=false
120
- ```
121
-
122
- After this change, true and false will be treated the same when used as optional path parameters. Meaning now:
123
-
124
- ```
125
- get '(this/:my_bool)/that' as: :that
126
-
127
- that_path(my_bool: true) # => `/this/true/that`
128
- that_path(my_bool: false) # => `/this/false/that`
129
- ```
130
-
131
- *Adam Hess*
132
-
133
- * Add support for 'private, no-store' Cache-Control headers.
134
-
135
- Previously, 'no-store' was exclusive; no other directives could be specified.
136
-
137
- *Alex Smith*
138
-
139
-
140
- ## Rails 6.1.3.2 (May 05, 2021) ##
141
-
142
- * Prevent open redirects by correctly escaping the host allow list
143
- CVE-2021-22903
144
-
145
- * Prevent catastrophic backtracking during mime parsing
146
- CVE-2021-22902
147
-
148
- * Prevent regex DoS in HTTP token authentication
149
- CVE-2021-22904
150
-
151
- * Prevent string polymorphic route arguments.
152
-
153
- `url_for` supports building polymorphic URLs via an array
154
- of arguments (usually symbols and records). If a developer passes a
155
- user input array, strings can result in unwanted route helper calls.
156
-
157
- CVE-2021-22885
158
-
159
- *Gannon McGibbon*
160
-
161
- ## Rails 6.1.3.1 (March 26, 2021) ##
162
-
163
- * No changes.
164
-
165
-
166
- ## Rails 6.1.3 (February 17, 2021) ##
167
-
168
- * Re-define routes when not set correctly via inheritance.
169
-
170
- *John Hawthorn*
171
-
172
-
173
- ## Rails 6.1.2.1 (February 10, 2021) ##
174
-
175
- * Prevent open redirect when allowed host starts with a dot
176
-
177
- [CVE-2021-22881]
178
-
179
- Thanks to @tktech (https://hackerone.com/tktech) for reporting this
180
- issue and the patch!
181
-
182
- *Aaron Patterson*
183
-
184
-
185
- ## Rails 6.1.2 (February 09, 2021) ##
186
-
187
- * Fix error in `ActionController::LogSubscriber` that would happen when throwing inside a controller action.
188
-
189
- *Janko Marohnić*
190
-
191
- * Fix `fixture_file_upload` deprecation when `file_fixture_path` is a relative path.
192
-
193
- *Eugene Kenny*
194
-
195
-
196
- ## Rails 6.1.1 (January 07, 2021) ##
197
-
198
- * Fix nil translation key lookup in controllers/
199
-
200
- *Jan Klimo*
201
-
202
- * Quietly handle unknown HTTP methods in Action Dispatch SSL middleware.
203
-
204
- *Alex Robbin*
205
-
206
- * Change the request method to a `GET` when passing failed requests down to `config.exceptions_app`.
207
-
208
- *Alex Robbin*
209
-
210
-
211
- ## Rails 6.1.0 (December 09, 2020) ##
212
-
213
- * Support for the HTTP header `Feature-Policy` has been revised to reflect
214
- its [rename](https://github.com/w3c/webappsec-permissions-policy/pull/379) to [`Permissions-Policy`](https://w3c.github.io/webappsec-permissions-policy/#permissions-policy-http-header-field).
215
-
216
- ```ruby
217
- Rails.application.config.permissions_policy do |p|
218
- p.camera :none
219
- p.gyroscope :none
220
- p.microphone :none
221
- p.usb :none
222
- p.fullscreen :self
223
- p.payment :self, "https://secure-example.com"
224
- end
225
- ```
226
-
227
- *Julien Grillot*
228
-
229
- * Allow `ActionDispatch::HostAuthorization` to exclude specific requests.
230
-
231
- Host Authorization checks can be skipped for specific requests. This allows for health check requests to be permitted for requests with missing or non-matching host headers.
232
-
233
- *Chris Bisnett*
234
-
235
- * Add `config.action_dispatch.request_id_header` to allow changing the name of
236
- the unique X-Request-Id header
237
-
238
- *Arlston Fernandes*
239
-
240
- * Deprecate `config.action_dispatch.return_only_media_type_on_content_type`.
241
-
242
- *Rafael Mendonça França*
243
-
244
- * Change `ActionDispatch::Response#content_type` to return the full Content-Type header.
245
-
246
- *Rafael Mendonça França*
247
-
248
- * Remove deprecated `ActionDispatch::Http::ParameterFilter`.
249
-
250
- *Rafael Mendonça França*
251
-
252
- * Added support for exclusive no-store Cache-Control header.
253
-
254
- If `no-store` is set on Cache-Control header it is exclusive (all other cache directives are dropped).
74
+ * New `ActionController::ConditionalGet#no_store` method to set HTTP cache control `no-store` directive.
255
75
 
256
- *Chris Kruger*
76
+ *Tadas Sasnauskas*
257
77
 
258
- * Catch invalid UTF-8 parameters for POST requests and respond with BadRequest.
78
+ * Drop support for the `SERVER_ADDR` header.
259
79
 
260
- Additionally, perform `#set_binary_encoding` in `ActionDispatch::Http::Request#GET` and
261
- `ActionDispatch::Http::Request#POST` prior to validating encoding.
80
+ Following up https://github.com/rack/rack/pull/1573 and https://github.com/rails/rails/pull/42349.
262
81
 
263
- *Adrianna Chang*
82
+ *Ricardo Díaz*
264
83
 
265
- * Allow `assert_recognizes` routing assertions to work on mounted root routes.
84
+ * Set session options when initializing a basic session.
266
85
 
267
86
  *Gannon McGibbon*
268
87
 
269
- * Change default redirection status code for non-GET/HEAD requests to 308 Permanent Redirect for `ActionDispatch::SSL`.
88
+ * Add `cache_control: {}` option to `fresh_when` and `stale?`.
270
89
 
271
- *Alan Tan*, *Oz Ben-David*
90
+ Works as a shortcut to set `response.cache_control` with the above methods.
272
91
 
273
- * Fix `follow_redirect!` to follow redirection with same HTTP verb when following
274
- a 308 redirection.
92
+ *Jacopo Beschi*
275
93
 
276
- *Alan Tan*
94
+ * Writing into a disabled session will now raise an error.
277
95
 
278
- * When multiple domains are specified for a cookie, a domain will now be
279
- chosen only if it is equal to or is a superdomain of the request host.
96
+ Previously when no session store was set, writing into the session would silently fail.
280
97
 
281
- *Jonathan Hefner*
98
+ *Jean Boussier*
282
99
 
283
- * `ActionDispatch::Static` handles precompiled Brotli (.br) files.
100
+ * Add support for 'require-trusted-types-for' and 'trusted-types' headers.
284
101
 
285
- Adds to existing support for precompiled gzip (.gz) files.
286
- Brotli files are preferred due to much better compression.
102
+ Fixes #42034.
287
103
 
288
- When the browser requests /some.js with `Accept-Encoding: br`,
289
- we check for public/some.js.br and serve that file, if present, with
290
- `Content-Encoding: br` and `Vary: Accept-Encoding` headers.
104
+ *lfalcao*
291
105
 
292
- *Ryan Edward Hall*, *Jeremy Daer*
106
+ * Remove inline styles and address basic accessibility issues on rescue templates.
293
107
 
294
- * Add raise_on_missing_translations support for controllers.
108
+ *Jacob Herrington*
295
109
 
296
- This configuration determines whether an error should be raised for missing translations.
297
- It can be enabled through `config.i18n.raise_on_missing_translations`. Note that described
298
- configuration also affects raising error for missing translations in views.
299
-
300
- *fatkodima*
301
-
302
- * Added `compact` and `compact!` to `ActionController::Parameters`.
303
-
304
- *Eugene Kenny*
305
-
306
- * Calling `each_pair` or `each_value` on an `ActionController::Parameters`
307
- without passing a block now returns an enumerator.
308
-
309
- *Eugene Kenny*
310
-
311
- * `fixture_file_upload` now uses path relative to `file_fixture_path`
312
-
313
- Previously the path had to be relative to `fixture_path`.
314
- You can change your existing code as follow:
315
-
316
- ```ruby
317
- # Before
318
- fixture_file_upload('files/dog.png')
319
-
320
- # After
321
- fixture_file_upload('dog.png')
322
- ```
323
-
324
- *Edouard Chin*
325
-
326
- * Remove deprecated `force_ssl` at the controller level.
327
-
328
- *Rafael Mendonça França*
329
-
330
- * The +helper+ class method for controllers loads helper modules specified as
331
- strings/symbols with `String#constantize` instead of `require_dependency`.
332
-
333
- Remember that support for strings/symbols is only a convenient API. You can
334
- always pass a module object:
335
-
336
- ```ruby
337
- helper UtilsHelper
338
- ```
339
-
340
- which is recommended because it is simple and direct. When a string/symbol
341
- is received, `helper` just manipulates and inflects the argument to obtain
342
- that same module object.
343
-
344
- *Xavier Noria*, *Jean Boussier*
345
-
346
- * Correctly identify the entire localhost IPv4 range as trusted proxy.
347
-
348
- *Nick Soracco*
349
-
350
- * `url_for` will now use "https://" as the default protocol when
351
- `Rails.application.config.force_ssl` is set to true.
352
-
353
- *Jonathan Hefner*
354
-
355
- * Accept and default to base64_urlsafe CSRF tokens.
356
-
357
- Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
358
- them difficult to deal with. For example, the common practice of sending
359
- the CSRF token to a browser in a client-readable cookie does not work properly
360
- out of the box: the value has to be url-encoded and decoded to survive transport.
361
-
362
- Now, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently safe
363
- to transport. Validation accepts both urlsafe tokens, and strict-encoded tokens
364
- for backwards compatibility.
365
-
366
- *Scott Blum*
367
-
368
- * Support rolling deploys for cookie serialization/encryption changes.
369
-
370
- In a distributed configuration like rolling update, users may observe
371
- both old and new instances during deployment. Users may be served by a
372
- new instance and then by an old instance.
373
-
374
- That means when the server changes `cookies_serializer` from `:marshal`
375
- to `:hybrid` or the server changes `use_authenticated_cookie_encryption`
376
- from `false` to `true`, users may lose their sessions if they access the
377
- server during deployment.
378
-
379
- We added fallbacks to downgrade the cookie format when necessary during
380
- deployment, ensuring compatibility on both old and new instances.
381
-
382
- *Masaki Hara*
383
-
384
- * `ActionDispatch::Request.remote_ip` has ip address even when all sites are trusted.
385
-
386
- Before, if all `X-Forwarded-For` sites were trusted, the `remote_ip` would default to `127.0.0.1`.
387
- Now, the furthest proxy site is used. e.g.: It now gives an ip address when using curl from the load balancer.
388
-
389
- *Keenan Brock*
390
-
391
- * Fix possible information leak / session hijacking vulnerability.
392
-
393
- The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the
394
- gem dalli to be updated as well.
395
-
396
- CVE-2019-16782.
397
-
398
- * Include child session assertion count in ActionDispatch::IntegrationTest.
399
-
400
- `IntegrationTest#open_session` uses `dup` to create the new session, which
401
- meant it had its own copy of `@assertions`. This prevented the assertions
402
- from being correctly counted and reported.
403
-
404
- Child sessions now have their `attr_accessor` overridden to delegate to the
405
- root session.
406
-
407
- Fixes #32142.
408
-
409
- *Sam Bostock*
410
-
411
- * Add SameSite protection to every written cookie.
412
-
413
- Enabling `SameSite` cookie protection is an addition to CSRF protection,
414
- where cookies won't be sent by browsers in cross-site POST requests when set to `:lax`.
415
-
416
- `:strict` disables cookies being sent in cross-site GET or POST requests.
417
-
418
- Passing `:none` disables this protection and is the same as previous versions albeit a `; SameSite=None` is appended to the cookie.
419
-
420
- See upgrade instructions in config/initializers/new_framework_defaults_6_1.rb.
110
+ * Add support for 'private, no-store' Cache-Control headers.
421
111
 
422
- More info [here](https://tools.ietf.org/html/draft-west-first-party-cookies-07)
112
+ Previously, 'no-store' was exclusive; no other directives could be specified.
423
113
 
424
- _NB: Technically already possible as Rack supports SameSite protection, this is to ensure it's applied to all cookies_
114
+ *Alex Smith*
425
115
 
426
- *Cédric Fabianski*
116
+ * Expand payload of `unpermitted_parameters.action_controller` instrumentation to allow subscribers to
117
+ know which controller action received unpermitted parameters.
427
118
 
428
- * Bring back the feature that allows loading external route files from the router.
119
+ *bbuchalter*
429
120
 
430
- This feature existed back in 2012 but got reverted with the incentive that
431
- https://github.com/rails/routing_concerns was a better approach. Turned out
432
- that this wasn't fully the case and loading external route files from the router
433
- can be helpful for applications with a really large set of routes.
434
- Without this feature, application needs to implement routes reloading
435
- themselves and it's not straightforward.
121
+ * Add `ActionController::Live#send_stream` that makes it more convenient to send generated streams:
436
122
 
437
123
  ```ruby
438
- # config/routes.rb
124
+ send_stream(filename: "subscribers.csv") do |stream|
125
+ stream.writeln "email_address,updated_at"
439
126
 
440
- Rails.application.routes.draw do
441
- draw(:admin)
442
- end
443
-
444
- # config/routes/admin.rb
445
-
446
- get :foo, to: 'foo#bar'
447
- ```
448
-
449
- *Yehuda Katz*, *Edouard Chin*
450
-
451
- * Fix system test driver option initialization for non-headless browsers.
452
-
453
- *glaszig*
454
-
455
- * `redirect_to.action_controller` notifications now include the `ActionDispatch::Request` in
456
- their payloads as `:request`.
457
-
458
- *Austin Story*
459
-
460
- * `respond_to#any` no longer returns a response's Content-Type based on the
461
- request format but based on the block given.
462
-
463
- Example:
464
-
465
- ```ruby
466
- def my_action
467
- respond_to do |format|
468
- format.any { render(json: { foo: 'bar' }) }
469
- end
127
+ @subscribers.find_each do |subscriber|
128
+ stream.writeln [ subscriber.email_address, subscriber.updated_at ].join(",")
470
129
  end
471
-
472
- get('my_action.csv')
473
- ```
474
-
475
- The previous behaviour was to respond with a `text/csv` Content-Type which
476
- is inaccurate since a JSON response is being rendered.
477
-
478
- Now it correctly returns a `application/json` Content-Type.
479
-
480
- *Edouard Chin*
481
-
482
- * Replaces (back)slashes in failure screenshot image paths with dashes.
483
-
484
- If a failed test case contained a slash or a backslash, a screenshot would be created in a
485
- nested directory, causing issues with `tmp:clear`.
486
-
487
- *Damir Zekic*
488
-
489
- * Add `params.member?` to mimic Hash behavior.
490
-
491
- *Younes Serraj*
492
-
493
- * `process_action.action_controller` notifications now include the following in their payloads:
494
-
495
- * `:request` - the `ActionDispatch::Request`
496
- * `:response` - the `ActionDispatch::Response`
497
-
498
- *George Claghorn*
499
-
500
- * Updated `ActionDispatch::Request.remote_ip` setter to clear set the instance
501
- `remote_ip` to `nil` before setting the header that the value is derived
502
- from.
503
-
504
- Fixes #37383.
505
-
506
- *Norm Provost*
507
-
508
- * `ActionController::Base.log_at` allows setting a different log level per request.
509
-
510
- ```ruby
511
- # Use the debug level if a particular cookie is set.
512
- class ApplicationController < ActionController::Base
513
- log_at :debug, if: -> { cookies[:debug] }
514
130
  end
515
131
  ```
516
132
 
517
- *George Claghorn*
518
-
519
- * Allow system test screen shots to be taken more than once in
520
- a test by prefixing the file name with an incrementing counter.
521
-
522
- Add an environment variable `RAILS_SYSTEM_TESTING_SCREENSHOT_HTML` to
523
- enable saving of HTML during a screenshot in addition to the image.
524
- This uses the same image name, with the extension replaced with `.html`
525
-
526
- *Tom Fakes*
527
-
528
- * Add `Vary: Accept` header when using `Accept` header for response.
529
-
530
- For some requests like `/users/1`, Rails uses requests' `Accept`
531
- header to determine what to return. And if we don't add `Vary`
532
- in the response header, browsers might accidentally cache different
533
- types of content, which would cause issues: e.g. javascript got displayed
534
- instead of html content. This PR fixes these issues by adding `Vary: Accept`
535
- in these types of requests. For more detailed problem description, please read:
536
-
537
- https://github.com/rails/rails/pull/36213
538
-
539
- Fixes #25842.
540
-
541
- *Stan Lo*
133
+ *DHH*
542
134
 
543
- * Fix IntegrationTest `follow_redirect!` to follow redirection using the same HTTP verb when following
544
- a 307 redirection.
135
+ * Add `ActionController::Live::Buffer#writeln` to write a line to the stream with a newline included.
545
136
 
546
- *Edouard Chin*
137
+ *DHH*
547
138
 
548
- * System tests require Capybara 3.26 or newer.
139
+ * `ActionDispatch::Request#content_type` now returned Content-Type header as it is.
549
140
 
550
- *George Claghorn*
141
+ Previously, `ActionDispatch::Request#content_type` returned value does NOT contain charset part.
142
+ This behavior changed to returned Content-Type header containing charset part as it is.
551
143
 
552
- * Reduced log noise handling ActionController::RoutingErrors.
144
+ If you want just MIME type, please use `ActionDispatch::Request#media_type` instead.
553
145
 
554
- *Alberto Fernández-Capel*
555
-
556
- * Add DSL for configuring HTTP Feature Policy.
557
-
558
- This new DSL provides a way to configure an HTTP Feature Policy at a
559
- global or per-controller level. Full details of HTTP Feature Policy
560
- specification and guidelines can be found at MDN:
561
-
562
- https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy
563
-
564
- Example global policy:
146
+ Before:
565
147
 
566
148
  ```ruby
567
- Rails.application.config.feature_policy do |f|
568
- f.camera :none
569
- f.gyroscope :none
570
- f.microphone :none
571
- f.usb :none
572
- f.fullscreen :self
573
- f.payment :self, "https://secure.example.com"
574
- end
149
+ request = ActionDispatch::Request.new("CONTENT_TYPE" => "text/csv; header=present; charset=utf-16", "REQUEST_METHOD" => "GET")
150
+ request.content_type #=> "text/csv"
575
151
  ```
576
152
 
577
- Example controller level policy:
153
+ After:
578
154
 
579
155
  ```ruby
580
- class PagesController < ApplicationController
581
- feature_policy do |p|
582
- p.geolocation "https://example.com"
583
- end
584
- end
156
+ request = ActionDispatch::Request.new("Content-Type" => "text/csv; header=present; charset=utf-16", "REQUEST_METHOD" => "GET")
157
+ request.content_type #=> "text/csv; header=present; charset=utf-16"
158
+ request.media_type #=> "text/csv"
585
159
  ```
586
160
 
587
- *Jacob Bednarz*
161
+ *Rafael Mendonça França*
588
162
 
589
- * Add the ability to set the CSP nonce only to the specified directives.
163
+ * Change `ActionDispatch::Request#media_type` to return `nil` when the request don't have a `Content-Type` header.
590
164
 
591
- Fixes #35137.
165
+ *Rafael Mendonça França*
592
166
 
593
- *Yuji Yaginuma*
167
+ * Fix error in `ActionController::LogSubscriber` that would happen when throwing inside a controller action.
594
168
 
595
- * Keep part when scope option has value.
169
+ *Janko Marohnić*
596
170
 
597
- When a route was defined within an optional scope, if that route didn't
598
- take parameters the scope was lost when using path helpers. This commit
599
- ensures scope is kept both when the route takes parameters or when it
600
- doesn't.
171
+ * Allow anything with `#to_str` (like `Addressable::URI`) as a `redirect_to` location.
601
172
 
602
- Fixes #33219.
173
+ *ojab*
603
174
 
604
- *Alberto Almagro*
175
+ * Change the request method to a `GET` when passing failed requests down to `config.exceptions_app`.
605
176
 
606
- * Added `deep_transform_keys` and `deep_transform_keys!` methods to ActionController::Parameters.
177
+ *Alex Robbin*
607
178
 
608
- *Gustavo Gutierrez*
179
+ * Deprecate the ability to assign a single value to `config.action_dispatch.trusted_proxies`
180
+ as `RemoteIp` middleware behaves inconsistently depending on whether this is configured
181
+ with a single value or an enumerable.
609
182
 
610
- * Calling `ActionController::Parameters#transform_keys`/`!` without a block now returns
611
- an enumerator for the parameters instead of the underlying hash.
183
+ Fixes #40772.
612
184
 
613
- *Eugene Kenny*
185
+ *Christian Sutter*
614
186
 
615
- * Fix strong parameters blocks all attributes even when only some keys are invalid (non-numerical).
616
- It should only block invalid key's values instead.
187
+ * Add `redirect_back_or_to(fallback_location, **)` as a more aesthetically pleasing version of `redirect_back fallback_location:, **`.
188
+ The old method name is retained without explicit deprecation.
617
189
 
618
- *Stan Lo*
190
+ *DHH*
619
191
 
620
192
 
621
- Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionpack/CHANGELOG.md) for previous changes.
193
+ Please check [6-1-stable](https://github.com/rails/rails/blob/6-1-stable/actionpack/CHANGELOG.md) for previous changes.