actionpack 6.0.6.1 → 6.1.0.rc1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of actionpack might be problematic. Click here for more details.

Files changed (115) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +232 -354
  3. data/MIT-LICENSE +1 -1
  4. data/README.rdoc +1 -1
  5. data/lib/abstract_controller/base.rb +35 -2
  6. data/lib/abstract_controller/callbacks.rb +2 -2
  7. data/lib/abstract_controller/helpers.rb +105 -90
  8. data/lib/abstract_controller/rendering.rb +9 -9
  9. data/lib/abstract_controller/translation.rb +8 -2
  10. data/lib/abstract_controller.rb +1 -0
  11. data/lib/action_controller/api.rb +2 -2
  12. data/lib/action_controller/base.rb +4 -2
  13. data/lib/action_controller/caching.rb +0 -1
  14. data/lib/action_controller/log_subscriber.rb +3 -3
  15. data/lib/action_controller/metal/conditional_get.rb +10 -2
  16. data/lib/action_controller/metal/content_security_policy.rb +1 -1
  17. data/lib/action_controller/metal/data_streaming.rb +1 -1
  18. data/lib/action_controller/metal/etag_with_template_digest.rb +2 -4
  19. data/lib/action_controller/metal/exceptions.rb +33 -0
  20. data/lib/action_controller/metal/feature_policy.rb +46 -0
  21. data/lib/action_controller/metal/head.rb +7 -4
  22. data/lib/action_controller/metal/helpers.rb +11 -1
  23. data/lib/action_controller/metal/http_authentication.rb +5 -3
  24. data/lib/action_controller/metal/implicit_render.rb +1 -1
  25. data/lib/action_controller/metal/instrumentation.rb +11 -9
  26. data/lib/action_controller/metal/live.rb +1 -1
  27. data/lib/action_controller/metal/logging.rb +20 -0
  28. data/lib/action_controller/metal/mime_responds.rb +6 -2
  29. data/lib/action_controller/metal/parameter_encoding.rb +35 -4
  30. data/lib/action_controller/metal/params_wrapper.rb +16 -11
  31. data/lib/action_controller/metal/redirecting.rb +1 -1
  32. data/lib/action_controller/metal/rendering.rb +6 -0
  33. data/lib/action_controller/metal/request_forgery_protection.rb +1 -1
  34. data/lib/action_controller/metal/rescue.rb +1 -1
  35. data/lib/action_controller/metal/strong_parameters.rb +103 -15
  36. data/lib/action_controller/metal.rb +2 -2
  37. data/lib/action_controller/renderer.rb +23 -13
  38. data/lib/action_controller/test_case.rb +62 -56
  39. data/lib/action_controller.rb +2 -3
  40. data/lib/action_dispatch/http/cache.rb +12 -10
  41. data/lib/action_dispatch/http/content_security_policy.rb +11 -0
  42. data/lib/action_dispatch/http/feature_policy.rb +168 -0
  43. data/lib/action_dispatch/http/filter_parameters.rb +1 -1
  44. data/lib/action_dispatch/http/filter_redirect.rb +1 -1
  45. data/lib/action_dispatch/http/headers.rb +3 -2
  46. data/lib/action_dispatch/http/mime_negotiation.rb +14 -8
  47. data/lib/action_dispatch/http/mime_type.rb +29 -16
  48. data/lib/action_dispatch/http/parameters.rb +1 -19
  49. data/lib/action_dispatch/http/request.rb +24 -8
  50. data/lib/action_dispatch/http/response.rb +17 -16
  51. data/lib/action_dispatch/http/url.rb +3 -2
  52. data/lib/action_dispatch/journey/formatter.rb +53 -28
  53. data/lib/action_dispatch/journey/gtg/builder.rb +22 -36
  54. data/lib/action_dispatch/journey/gtg/simulator.rb +8 -7
  55. data/lib/action_dispatch/journey/gtg/transition_table.rb +6 -4
  56. data/lib/action_dispatch/journey/nfa/dot.rb +0 -11
  57. data/lib/action_dispatch/journey/nodes/node.rb +4 -3
  58. data/lib/action_dispatch/journey/parser.rb +13 -13
  59. data/lib/action_dispatch/journey/parser.y +1 -1
  60. data/lib/action_dispatch/journey/path/pattern.rb +13 -18
  61. data/lib/action_dispatch/journey/route.rb +7 -18
  62. data/lib/action_dispatch/journey/router/utils.rb +6 -4
  63. data/lib/action_dispatch/journey/router.rb +26 -30
  64. data/lib/action_dispatch/journey.rb +0 -2
  65. data/lib/action_dispatch/middleware/actionable_exceptions.rb +1 -1
  66. data/lib/action_dispatch/middleware/cookies.rb +67 -32
  67. data/lib/action_dispatch/middleware/debug_exceptions.rb +8 -15
  68. data/lib/action_dispatch/middleware/debug_view.rb +1 -1
  69. data/lib/action_dispatch/middleware/exception_wrapper.rb +28 -16
  70. data/lib/action_dispatch/middleware/executor.rb +1 -1
  71. data/lib/action_dispatch/middleware/host_authorization.rb +35 -35
  72. data/lib/action_dispatch/middleware/remote_ip.rb +5 -4
  73. data/lib/action_dispatch/middleware/request_id.rb +4 -5
  74. data/lib/action_dispatch/middleware/session/abstract_store.rb +2 -2
  75. data/lib/action_dispatch/middleware/session/cookie_store.rb +2 -2
  76. data/lib/action_dispatch/middleware/ssl.rb +9 -6
  77. data/lib/action_dispatch/middleware/stack.rb +18 -0
  78. data/lib/action_dispatch/middleware/static.rb +154 -93
  79. data/lib/action_dispatch/middleware/templates/rescues/_message_and_suggestions.html.erb +18 -0
  80. data/lib/action_dispatch/middleware/templates/rescues/blocked_host.html.erb +1 -1
  81. data/lib/action_dispatch/middleware/templates/rescues/blocked_host.text.erb +1 -1
  82. data/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb +2 -5
  83. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.html.erb +2 -2
  84. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.text.erb +2 -3
  85. data/lib/action_dispatch/middleware/templates/rescues/layout.erb +88 -8
  86. data/lib/action_dispatch/middleware/templates/rescues/unknown_action.html.erb +1 -1
  87. data/lib/action_dispatch/middleware/templates/routes/_table.html.erb +12 -1
  88. data/lib/action_dispatch/railtie.rb +3 -2
  89. data/lib/action_dispatch/request/session.rb +2 -8
  90. data/lib/action_dispatch/request/utils.rb +26 -2
  91. data/lib/action_dispatch/routing/inspector.rb +8 -7
  92. data/lib/action_dispatch/routing/mapper.rb +102 -71
  93. data/lib/action_dispatch/routing/polymorphic_routes.rb +16 -19
  94. data/lib/action_dispatch/routing/redirection.rb +3 -3
  95. data/lib/action_dispatch/routing/route_set.rb +49 -41
  96. data/lib/action_dispatch/system_test_case.rb +29 -24
  97. data/lib/action_dispatch/system_testing/browser.rb +33 -27
  98. data/lib/action_dispatch/system_testing/driver.rb +6 -7
  99. data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb +47 -6
  100. data/lib/action_dispatch/system_testing/test_helpers/setup_and_teardown.rb +4 -7
  101. data/lib/action_dispatch/testing/assertions/response.rb +2 -4
  102. data/lib/action_dispatch/testing/assertions/routing.rb +5 -5
  103. data/lib/action_dispatch/testing/assertions.rb +1 -1
  104. data/lib/action_dispatch/testing/integration.rb +38 -27
  105. data/lib/action_dispatch/testing/test_process.rb +29 -4
  106. data/lib/action_dispatch/testing/test_request.rb +3 -3
  107. data/lib/action_dispatch.rb +3 -2
  108. data/lib/action_pack/gem_version.rb +3 -3
  109. data/lib/action_pack.rb +1 -1
  110. metadata +23 -25
  111. data/lib/action_controller/metal/force_ssl.rb +0 -58
  112. data/lib/action_dispatch/http/parameter_filter.rb +0 -12
  113. data/lib/action_dispatch/journey/nfa/builder.rb +0 -78
  114. data/lib/action_dispatch/journey/nfa/simulator.rb +0 -47
  115. data/lib/action_dispatch/journey/nfa/transition_table.rb +0 -119
data/CHANGELOG.md CHANGED
@@ -1,517 +1,395 @@
1
- ## Rails 6.0.6.1 (January 17, 2023) ##
1
+ ## Rails 6.1.0.rc1 (November 02, 2020) ##
2
2
 
3
- * No changes.
3
+ * Allow `ActionDispatch::HostAuthorization` to exclude specific requests.
4
4
 
5
+ Host Authorization checks can be skipped for specific requests. This allows for health check requests to be permitted for requests with missing or non-matching host headers.
5
6
 
6
- ## Rails 6.0.6 (September 09, 2022) ##
7
+ *Chris Bisnett*
7
8
 
8
- * No changes.
9
+ * Add `config.action_dispatch.request_id_header` to allow changing the name of
10
+ the unique X-Request-Id header
9
11
 
12
+ *Arlston Fernandes*
10
13
 
11
- ## Rails 6.0.5.1 (July 12, 2022) ##
14
+ * Deprecate `config.action_dispatch.return_only_media_type_on_content_type`.
12
15
 
13
- * No changes.
14
-
15
-
16
- ## Rails 6.0.5 (May 09, 2022) ##
16
+ *Rafael Mendonça França*
17
17
 
18
- * No changes.
18
+ * Change `ActionDispatch::Response#content_type` to return the full Content-Type header.
19
19
 
20
+ *Rafael Mendonça França*
20
21
 
21
- ## Rails 6.0.4.8 (April 26, 2022) ##
22
+ * Remove deprecated `ActionDispatch::Http::ParameterFilter`.
22
23
 
23
- * Allow Content Security Policy DSL to generate for API responses.
24
+ *Rafael Mendonça França*
24
25
 
25
- *Tim Wade*
26
+ * Added support for exclusive no-store Cache-Control header.
26
27
 
27
- ## Rails 6.0.4.7 (March 08, 2022) ##
28
+ If `no-store` is set on Cache-Control header it is exclusive (all other cache directives are dropped).
28
29
 
29
- * No changes.
30
+ *Chris Kruger*
30
31
 
32
+ * Catch invalid UTF-8 parameters for POST requests and respond with BadRequest.
31
33
 
32
- ## Rails 6.0.4.6 (February 11, 2022) ##
34
+ Additionally, perform `#set_binary_encoding` in `ActionDispatch::Http::Request#GET` and
35
+ `ActionDispatch::Http::Request#POST` prior to validating encoding.
33
36
 
34
- * No changes.
37
+ *Adrianna Chang*
35
38
 
39
+ * Allow `assert_recognizes` routing assertions to work on mounted root routes.
36
40
 
37
- ## Rails 6.0.4.5 (February 11, 2022) ##
41
+ *Gannon McGibbon*
38
42
 
39
- * Under certain circumstances, the middleware isn't informed that the
40
- response body has been fully closed which result in request state not
41
- being fully reset before the next request
43
+ * Change default redirection status code for non-GET/HEAD requests to 308 Permanent Redirect for `ActionDispatch::SSL`.
42
44
 
43
- [CVE-2022-23633]
45
+ *Alan Tan*, *Oz Ben-David*
44
46
 
47
+ * Fix `follow_redirect!` to follow redirection with same HTTP verb when following
48
+ a 308 redirection.
45
49
 
46
- ## Rails 6.0.4.4 (December 15, 2021) ##
50
+ *Alan Tan*
47
51
 
48
- * Fix issue with host protection not allowing host with port in development.
52
+ * When multiple domains are specified for a cookie, a domain will now be
53
+ chosen only if it is equal to or is a superdomain of the request host.
49
54
 
55
+ *Jonathan Hefner*
50
56
 
51
- ## Rails 6.0.4.3 (December 14, 2021) ##
57
+ * `ActionDispatch::Static` handles precompiled Brotli (.br) files.
52
58
 
53
- * Fix issue with host protection not allowing localhost in development.
59
+ Adds to existing support for precompiled gzip (.gz) files.
60
+ Brotli files are preferred due to much better compression.
54
61
 
62
+ When the browser requests /some.js with `Accept-Encoding: br`,
63
+ we check for public/some.js.br and serve that file, if present, with
64
+ `Content-Encoding: br` and `Vary: Accept-Encoding` headers.
55
65
 
56
- ## Rails 6.0.4.2 (December 14, 2021) ##
66
+ *Ryan Edward Hall*, *Jeremy Daer*
57
67
 
58
- * Fix X_FORWARDED_HOST protection. [CVE-2021-44528]
68
+ * Add raise_on_missing_translations support for controllers.
59
69
 
60
- ## Rails 6.1.4.1 (August 19, 2021) ##
70
+ This configuration determines whether an error should be raised for missing translations.
71
+ It can be enabled through `config.i18n.raise_on_missing_translations`. Note that described
72
+ configuration also affects raising error for missing translations in views.
61
73
 
62
- * [CVE-2021-22942] Fix possible open redirect in Host Authorization middleware.
74
+ *fatkodima*
63
75
 
64
- Specially crafted "X-Forwarded-Host" headers in combination with certain
65
- "allowed host" formats can cause the Host Authorization middleware in Action
66
- Pack to redirect users to a malicious website.
76
+ * Added `compact` and `compact!` to `ActionController::Parameters`.
67
77
 
68
- ## Rails 6.0.4 (June 15, 2021) ##
78
+ *Eugene Kenny*
69
79
 
70
- * Accept base64_urlsafe CSRF tokens to make forward compatible.
80
+ * Calling `each_pair` or `each_value` on an `ActionController::Parameters`
81
+ without passing a block now returns an enumerator.
71
82
 
72
- Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
73
- them difficult to deal with. For example, the common practice of sending
74
- the CSRF token to a browser in a client-readable cookie does not work properly
75
- out of the box: the value has to be url-encoded and decoded to survive transport.
83
+ *Eugene Kenny*
76
84
 
77
- In Rails 6.1, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently
78
- safe to transport. Validation accepts both urlsafe tokens, and strict-encoded
79
- tokens for backwards compatibility.
85
+ * `fixture_file_upload` now uses path relative to `file_fixture_path`
80
86
 
81
- In Rails 5.2.5, the CSRF token format is accidentally changed to urlsafe-encoded.
82
- If you upgrade apps from 5.2.5, set the config `urlsafe_csrf_tokens = true`.
87
+ Previously the path had to be relative to `fixture_path`.
88
+ You can change your existing code as follow:
83
89
 
84
90
  ```ruby
85
- Rails.application.config.action_controller.urlsafe_csrf_tokens = true
86
- ```
87
-
88
- *Scott Blum*, *Étienne Barrié*
89
-
90
- * Signed and encrypted cookies can now store `false` as their value when
91
- `action_dispatch.use_cookies_with_metadata` is enabled.
91
+ # Before
92
+ fixture_file_upload('files/dog.png')
92
93
 
93
- *Rolandas Barysas*
94
-
95
-
96
- ## Rails 6.0.3.7 (May 05, 2021) ##
97
-
98
- * Prevent catastrophic backtracking during mime parsing
99
- CVE-2021-22902
94
+ # After
95
+ fixture_file_upload('dog.png')
96
+ ```
100
97
 
101
- * Prevent regex DoS in HTTP token authentication
102
- CVE-2021-22904
98
+ *Edouard Chin*
103
99
 
104
- * Prevent string polymorphic route arguments.
100
+ * Remove deprecated `force_ssl` at the controller level.
105
101
 
106
- `url_for` supports building polymorphic URLs via an array
107
- of arguments (usually symbols and records). If a developer passes a
108
- user input array, strings can result in unwanted route helper calls.
102
+ *Rafael Mendonça França*
109
103
 
110
- CVE-2021-22885
104
+ * The +helper+ class method for controllers loads helper modules specified as
105
+ strings/symbols with `String#constantize` instead of `require_dependency`.
111
106
 
112
- *Gannon McGibbon*
107
+ Remember that support for strings/symbols is only a convenient API. You can
108
+ always pass a module object:
113
109
 
114
- ## Rails 6.0.3.6 (March 26, 2021) ##
110
+ ```ruby
111
+ helper UtilsHelper
112
+ ```
115
113
 
116
- * No changes.
114
+ which is recommended because it is simple and direct. When a string/symbol
115
+ is received, `helper` just manipulates and inflects the argument to obtain
116
+ that same module object.
117
117
 
118
+ *Xavier Noria*, *Jean Boussier*
118
119
 
119
- ## Rails 6.0.3.5 (February 10, 2021) ##
120
+ * Correctly identify the entire localhost IPv4 range as trusted proxy.
120
121
 
121
- * Prevent open redirect when allowed host starts with a dot
122
+ *Nick Soracco*
122
123
 
123
- [CVE-2021-22881]
124
+ * `url_for` will now use "https://" as the default protocol when
125
+ `Rails.application.config.force_ssl` is set to true.
124
126
 
125
- Thanks to @tktech (https://hackerone.com/tktech) for reporting this
126
- issue and the patch!
127
+ *Jonathan Hefner*
127
128
 
128
- *Aaron Patterson*
129
+ * Accept and default to base64_urlsafe CSRF tokens.
129
130
 
131
+ Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
132
+ them difficult to deal with. For example, the common practice of sending
133
+ the CSRF token to a browser in a client-readable cookie does not work properly
134
+ out of the box: the value has to be url-encoded and decoded to survive transport.
130
135
 
131
- ## Rails 6.0.3.4 (October 07, 2020) ##
136
+ Now, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently safe
137
+ to transport. Validation accepts both urlsafe tokens, and strict-encoded tokens
138
+ for backwards compatibility.
132
139
 
133
- * [CVE-2020-8264] Prevent XSS in Actionable Exceptions
140
+ *Scott Blum*
134
141
 
142
+ * Support rolling deploys for cookie serialization/encryption changes.
135
143
 
136
- ## Rails 6.0.3.3 (September 09, 2020) ##
144
+ In a distributed configuration like rolling update, users may observe
145
+ both old and new instances during deployment. Users may be served by a
146
+ new instance and then by an old instance.
137
147
 
138
- * No changes.
148
+ That means when the server changes `cookies_serializer` from `:marshal`
149
+ to `:hybrid` or the server changes `use_authenticated_cookie_encryption`
150
+ from `false` to `true`, users may lose their sessions if they access the
151
+ server during deployment.
139
152
 
153
+ We added fallbacks to downgrade the cookie format when necessary during
154
+ deployment, ensuring compatibility on both old and new instances.
140
155
 
141
- ## Rails 6.0.3.2 (June 17, 2020) ##
156
+ *Masaki Hara*
142
157
 
143
- * [CVE-2020-8185] Only allow ActionableErrors if show_detailed_exceptions is enabled
158
+ * `ActionDispatch::Request.remote_ip` has ip address even when all sites are trusted.
144
159
 
145
- ## Rails 6.0.3.1 (May 18, 2020) ##
160
+ Before, if all `X-Forwarded-For` sites were trusted, the `remote_ip` would default to `127.0.0.1`.
161
+ Now, the furthest proxy site is used. e.g.: It now gives an ip address when using curl from the load balancer.
146
162
 
147
- * [CVE-2020-8166] HMAC raw CSRF token before masking it, so it cannot be used to reconstruct a per-form token
163
+ *Keenan Brock*
148
164
 
149
- * [CVE-2020-8164] Return self when calling #each, #each_pair, and #each_value instead of the raw @parameters hash
165
+ * Fix possible information leak / session hijacking vulnerability.
150
166
 
167
+ The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the
168
+ gem dalli to be updated as well.
151
169
 
152
- ## Rails 6.0.3 (May 06, 2020) ##
170
+ CVE-2019-16782.
153
171
 
154
- * Include child session assertion count in ActionDispatch::IntegrationTest
172
+ * Include child session assertion count in ActionDispatch::IntegrationTest.
155
173
 
156
174
  `IntegrationTest#open_session` uses `dup` to create the new session, which
157
175
  meant it had its own copy of `@assertions`. This prevented the assertions
158
176
  from being correctly counted and reported.
159
177
 
160
- Child sessions now have their `attr_accessor` overriden to delegate to the
178
+ Child sessions now have their `attr_accessor` overridden to delegate to the
161
179
  root session.
162
180
 
163
- Fixes #32142
181
+ Fixes #32142.
164
182
 
165
183
  *Sam Bostock*
166
184
 
185
+ * Add SameSite protection to every written cookie.
167
186
 
168
- ## Rails 6.0.2.2 (March 19, 2020) ##
169
-
170
- * No changes.
171
-
172
-
173
- ## Rails 6.0.2.1 (December 18, 2019) ##
174
-
175
- * Fix possible information leak / session hijacking vulnerability.
176
-
177
- The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the
178
- gem dalli to be updated as well.
179
-
180
- CVE-2019-16782.
181
-
187
+ Enabling `SameSite` cookie protection is an addition to CSRF protection,
188
+ where cookies won't be sent by browsers in cross-site POST requests when set to `:lax`.
182
189
 
183
- ## Rails 6.0.2 (December 13, 2019) ##
190
+ `:strict` disables cookies being sent in cross-site GET or POST requests.
184
191
 
185
- * Allow using mountable engine route helpers in System Tests.
192
+ Passing `:none` disables this protection and is the same as previous versions albeit a `; SameSite=None` is appended to the cookie.
186
193
 
187
- *Chalo Fernandez*
194
+ See upgrade instructions in config/initializers/new_framework_defaults_6_1.rb.
188
195
 
196
+ More info [here](https://tools.ietf.org/html/draft-west-first-party-cookies-07)
189
197
 
190
- ## Rails 6.0.1 (November 5, 2019) ##
198
+ _NB: Technically already possible as Rack supports SameSite protection, this is to ensure it's applied to all cookies_
191
199
 
192
- * `ActionDispatch::SystemTestCase` now inherits from `ActiveSupport::TestCase`
193
- rather than `ActionDispatch::IntegrationTest`. This permits running jobs in
194
- system tests.
200
+ *Cédric Fabianski*
195
201
 
196
- *George Claghorn*, *Edouard Chin*
202
+ * Bring back the feature that allows loading external route files from the router.
197
203
 
198
- * Registered MIME types may contain extra flags:
204
+ This feature existed back in 2012 but got reverted with the incentive that
205
+ https://github.com/rails/routing_concerns was a better approach. Turned out
206
+ that this wasn't fully the case and loading external route files from the router
207
+ can be helpful for applications with a really large set of routes.
208
+ Without this feature, application needs to implement routes reloading
209
+ themselves and it's not straightforward.
199
210
 
200
211
  ```ruby
201
- Mime::Type.register "text/html; fragment", :html_fragment
202
- ```
203
-
204
- *Aaron Patterson*
212
+ # config/routes.rb
205
213
 
214
+ Rails.application.routes.draw do
215
+ draw(:admin)
216
+ end
206
217
 
207
- ## Rails 6.0.0 (August 16, 2019) ##
208
-
209
- * No changes.
218
+ # config/routes/admin.rb
210
219
 
220
+ get :foo, to: 'foo#bar'
221
+ ```
211
222
 
212
- ## Rails 6.0.0.rc2 (July 22, 2019) ##
223
+ *Yehuda Katz*, *Edouard Chin*
213
224
 
214
- * Add the ability to set the CSP nonce only to the specified directives.
225
+ * Fix system test driver option initialization for non-headless browsers.
215
226
 
216
- Fixes #35137.
227
+ *glaszig*
217
228
 
218
- *Yuji Yaginuma*
229
+ * `redirect_to.action_controller` notifications now include the `ActionDispatch::Request` in
230
+ their payloads as `:request`.
219
231
 
220
- * Keep part when scope option has value.
232
+ *Austin Story*
221
233
 
222
- When a route was defined within an optional scope, if that route didn't
223
- take parameters the scope was lost when using path helpers. This commit
224
- ensures scope is kept both when the route takes parameters or when it
225
- doesn't.
234
+ * `respond_to#any` no longer returns a response's Content-Type based on the
235
+ request format but based on the block given.
226
236
 
227
- Fixes #33219
237
+ Example:
228
238
 
229
- *Alberto Almagro*
230
-
231
- * Change `ActionDispatch::Response#content_type` to return Content-Type header as it is.
232
-
233
- Previously, `ActionDispatch::Response#content_type` returned value does NOT
234
- contain charset part. This behavior changed to returned Content-Type header
235
- containing charset part as it is.
236
-
237
- If you want just MIME type, please use `ActionDispatch::Response#media_type`
238
- instead.
239
-
240
- Enable `action_dispatch.return_only_media_type_on_content_type` to use this change.
241
- If not enabled, `ActionDispatch::Response#content_type` returns the same
242
- value as before version, but its behavior is deprecate.
239
+ ```ruby
240
+ def my_action
241
+ respond_to do |format|
242
+ format.any { render(json: { foo: 'bar' }) }
243
+ end
244
+ end
243
245
 
244
- *Yuji Yaginuma*
246
+ get('my_action.csv')
247
+ ```
245
248
 
246
- * Calling `ActionController::Parameters#transform_keys/!` without a block now returns
247
- an enumerator for the parameters instead of the underlying hash.
249
+ The previous behaviour was to respond with a `text/csv` Content-Type which
250
+ is inaccurate since a JSON response is being rendered.
248
251
 
249
- *Eugene Kenny*
252
+ Now it correctly returns a `application/json` Content-Type.
250
253
 
251
- * Fix a bug where DebugExceptions throws an error when malformed query parameters are provided
254
+ *Edouard Chin*
252
255
 
253
- *Yuki Nishijima*, *Stan Lo*
256
+ * Replaces (back)slashes in failure screenshot image paths with dashes.
254
257
 
258
+ If a failed test case contained a slash or a backslash, a screenshot would be created in a
259
+ nested directory, causing issues with `tmp:clear`.
255
260
 
256
- ## Rails 6.0.0.rc1 (April 24, 2019) ##
261
+ *Damir Zekic*
257
262
 
258
- * Make system tests take a failed screenshot in a `before_teardown` hook
259
- rather than an `after_teardown` hook.
263
+ * Add `params.member?` to mimic Hash behavior.
260
264
 
261
- This helps minimize the time gap between when an assertion fails and when
262
- the screenshot is taken (reducing the time in which the page could have
263
- been dynamically updated after the assertion failed).
265
+ *Younes Serraj*
264
266
 
265
- *Richard Macklin*
267
+ * `process_action.action_controller` notifications now include the following in their payloads:
266
268
 
267
- * Introduce `ActionDispatch::ActionableExceptions`.
269
+ * `:request` - the `ActionDispatch::Request`
270
+ * `:response` - the `ActionDispatch::Response`
268
271
 
269
- The `ActionDispatch::ActionableExceptions` middleware dispatches actions
270
- from `ActiveSupport::ActionableError` descendants.
272
+ *George Claghorn*
271
273
 
272
- Actionable errors let's you dispatch actions from Rails' error pages.
274
+ * Updated `ActionDispatch::Request.remote_ip` setter to clear set the instance
275
+ `remote_ip` to `nil` before setting the header that the value is derived
276
+ from.
273
277
 
274
- *Vipul A M*, *Yao Jie*, *Genadi Samokovarov*
278
+ Fixes #37383.
275
279
 
276
- * Raise an `ArgumentError` if a resource custom param contains a colon (`:`).
280
+ *Norm Provost*
277
281
 
278
- After this change it's not possible anymore to configure routes like this:
282
+ * `ActionController::Base.log_at` allows setting a different log level per request.
279
283
 
280
- ```
281
- routes.draw do
282
- resources :users, param: 'name/:sneaky'
284
+ ```ruby
285
+ # Use the debug level if a particular cookie is set.
286
+ class ApplicationController < ActionController::Base
287
+ log_at :debug, if: -> { cookies[:debug] }
283
288
  end
284
289
  ```
285
290
 
286
- Fixes #30467.
291
+ *George Claghorn*
287
292
 
288
- *Josua Schmid*
293
+ * Allow system test screen shots to be taken more than once in
294
+ a test by prefixing the file name with an incrementing counter.
289
295
 
296
+ Add an environment variable `RAILS_SYSTEM_TESTING_SCREENSHOT_HTML` to
297
+ enable saving of HTML during a screenshot in addition to the image.
298
+ This uses the same image name, with the extension replaced with `.html`
290
299
 
291
- ## Rails 6.0.0.beta3 (March 11, 2019) ##
300
+ *Tom Fakes*
292
301
 
293
- * No changes.
302
+ * Add `Vary: Accept` header when using `Accept` header for response.
294
303
 
304
+ For some requests like `/users/1`, Rails uses requests' `Accept`
305
+ header to determine what to return. And if we don't add `Vary`
306
+ in the response header, browsers might accidentally cache different
307
+ types of content, which would cause issues: e.g. javascript got displayed
308
+ instead of html content. This PR fixes these issues by adding `Vary: Accept`
309
+ in these types of requests. For more detailed problem description, please read:
295
310
 
296
- ## Rails 6.0.0.beta2 (February 25, 2019) ##
311
+ https://github.com/rails/rails/pull/36213
297
312
 
298
- * Make debug exceptions works in an environment where ActiveStorage is not loaded.
313
+ Fixes #25842.
299
314
 
300
- *Tomoyuki Kurosawa*
315
+ *Stan Lo*
301
316
 
302
- * `ActionDispatch::SystemTestCase.driven_by` can now be called with a block
303
- to define specific browser capabilities.
317
+ * Fix IntegrationTest `follow_redirect!` to follow redirection using the same HTTP verb when following
318
+ a 307 redirection.
304
319
 
305
320
  *Edouard Chin*
306
321
 
322
+ * System tests require Capybara 3.26 or newer.
307
323
 
308
- ## Rails 6.0.0.beta1 (January 18, 2019) ##
309
-
310
- * Remove deprecated `fragment_cache_key` helper in favor of `combined_fragment_cache_key`.
311
-
312
- *Rafael Mendonça França*
313
-
314
- * Remove deprecated methods in `ActionDispatch::TestResponse`.
315
-
316
- `#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
317
- `#successful?`, `not_found?` and `server_error?`.
324
+ *George Claghorn*
318
325
 
319
- *Rafael Mendonça França*
326
+ * Reduced log noise handling ActionController::RoutingErrors.
320
327
 
321
- * Introduce `ActionDispatch::HostAuthorization`.
328
+ *Alberto Fernández-Capel*
322
329
 
323
- This is a new middleware that guards against DNS rebinding attacks by
324
- explicitly permitting the hosts a request can be made to.
330
+ * Add DSL for configuring HTTP Feature Policy.
325
331
 
326
- Each host is checked with the case operator (`#===`) to support `Regexp`,
327
- `Proc`, `IPAddr` and custom objects as host allowances.
332
+ This new DSL provides a way to configure an HTTP Feature Policy at a
333
+ global or per-controller level. Full details of HTTP Feature Policy
334
+ specification and guidelines can be found at MDN:
328
335
 
329
- *Genadi Samokovarov*
336
+ https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy
330
337
 
331
- * Allow using `parsed_body` in `ActionController::TestCase`.
338
+ Example global policy:
332
339
 
333
- In addition to `ActionDispatch::IntegrationTest`, allow using
334
- `parsed_body` in `ActionController::TestCase`:
335
-
336
- ```
337
- class SomeControllerTest < ActionController::TestCase
338
- def test_some_action
339
- post :action, body: { foo: 'bar' }
340
- assert_equal({ "foo" => "bar" }, response.parsed_body)
341
- end
340
+ ```ruby
341
+ Rails.application.config.feature_policy do |f|
342
+ f.camera :none
343
+ f.gyroscope :none
344
+ f.microphone :none
345
+ f.usb :none
346
+ f.fullscreen :self
347
+ f.payment :self, "https://secure.example.com"
342
348
  end
343
349
  ```
344
350
 
345
- Fixes #34676.
346
-
347
- *Tobias Bühlmann*
348
-
349
- * Raise an error on root route naming conflicts.
350
-
351
- Raises an `ArgumentError` when multiple root routes are defined in the
352
- same context instead of assigning nil names to subsequent roots.
351
+ Example controller level policy:
353
352
 
354
- *Gannon McGibbon*
355
-
356
- * Allow rescue from parameter parse errors:
357
-
358
- ```
359
- rescue_from ActionDispatch::Http::Parameters::ParseError do
360
- head :unauthorized
353
+ ```ruby
354
+ class PagesController < ApplicationController
355
+ feature_policy do |p|
356
+ p.geolocation "https://example.com"
357
+ end
361
358
  end
362
359
  ```
363
360
 
364
- *Gannon McGibbon*, *Josh Cheek*
365
-
366
- * Reset Capybara sessions if failed system test screenshot raising an exception.
367
-
368
- Reset Capybara sessions if `take_failed_screenshot` raise exception
369
- in system test `after_teardown`.
370
-
371
- *Maxim Perepelitsa*
372
-
373
- * Use request object for context if there's no controller
374
-
375
- There is no controller instance when using a redirect route or a
376
- mounted rack application so pass the request object as the context
377
- when resolving dynamic CSP sources in this scenario.
378
-
379
- Fixes #34200.
380
-
381
- *Andrew White*
382
-
383
- * Apply mapping to symbols returned from dynamic CSP sources
384
-
385
- Previously if a dynamic source returned a symbol such as :self it
386
- would be converted to a string implicitly, e.g:
387
-
388
- policy.default_src -> { :self }
389
-
390
- would generate the header:
391
-
392
- Content-Security-Policy: default-src self
393
-
394
- and now it generates:
395
-
396
- Content-Security-Policy: default-src 'self'
397
-
398
- *Andrew White*
399
-
400
- * Add `ActionController::Parameters#each_value`.
401
-
402
- *Lukáš Zapletal*
403
-
404
- * Deprecate `ActionDispatch::Http::ParameterFilter` in favor of `ActiveSupport::ParameterFilter`.
405
-
406
- *Yoshiyuki Kinjo*
407
-
408
- * Encode Content-Disposition filenames on `send_data` and `send_file`.
409
- Previously, `send_data 'data', filename: "\u{3042}.txt"` sends
410
- `"filename=\"\u{3042}.txt\""` as Content-Disposition and it can be
411
- garbled.
412
- Now it follows [RFC 2231](https://tools.ietf.org/html/rfc2231) and
413
- [RFC 5987](https://tools.ietf.org/html/rfc5987) and sends
414
- `"filename=\"%3F.txt\"; filename*=UTF-8''%E3%81%82.txt"`.
415
- Most browsers can find filename correctly and old browsers fallback to ASCII
416
- converted name.
417
-
418
- *Fumiaki Matsushima*
361
+ *Jacob Bednarz*
419
362
 
420
- * Expose `ActionController::Parameters#each_key` which allows iterating over
421
- keys without allocating an array.
422
-
423
- *Richard Schneeman*
424
-
425
- * Purpose metadata for signed/encrypted cookies.
426
-
427
- Rails can now thwart attacks that attempt to copy signed/encrypted value
428
- of a cookie and use it as the value of another cookie.
429
-
430
- It does so by stashing the cookie-name in the purpose field which is
431
- then signed/encrypted along with the cookie value. Then, on a server-side
432
- read, we verify the cookie-names and discard any attacked cookies.
433
-
434
- Enable `action_dispatch.use_cookies_with_metadata` to use this feature, which
435
- writes cookies with the new purpose and expiry metadata embedded.
436
-
437
- *Assain Jaleel*
438
-
439
- * Raises `ActionController::RespondToMismatchError` with conflicting `respond_to` invocations.
440
-
441
- `respond_to` can match multiple types and lead to undefined behavior when
442
- multiple invocations are made and the types do not match:
443
-
444
- respond_to do |outer_type|
445
- outer_type.js do
446
- respond_to do |inner_type|
447
- inner_type.html { render body: "HTML" }
448
- end
449
- end
450
- end
451
-
452
- *Patrick Toomey*
453
-
454
- * `ActionDispatch::Http::UploadedFile` now delegates `to_path` to its tempfile.
455
-
456
- This allows uploaded file objects to be passed directly to `File.read`
457
- without raising a `TypeError`:
458
-
459
- uploaded_file = ActionDispatch::Http::UploadedFile.new(tempfile: tmp_file)
460
- File.read(uploaded_file)
461
-
462
- *Aaron Kromer*
463
-
464
- * Pass along arguments to underlying `get` method in `follow_redirect!`
465
-
466
- Now all arguments passed to `follow_redirect!` are passed to the underlying
467
- `get` method. This for example allows to set custom headers for the
468
- redirection request to the server.
469
-
470
- follow_redirect!(params: { foo: :bar })
471
-
472
- *Remo Fritzsche*
473
-
474
- * Introduce a new error page to when the implicit render page is accessed in the browser.
475
-
476
- Now instead of showing an error page that with exception and backtraces we now show only
477
- one informative page.
478
-
479
- *Vinicius Stock*
480
-
481
- * Introduce `ActionDispatch::DebugExceptions.register_interceptor`.
482
-
483
- Exception aware plugin authors can use the newly introduced
484
- `.register_interceptor` method to get the processed exception, instead of
485
- monkey patching DebugExceptions.
486
-
487
- ActionDispatch::DebugExceptions.register_interceptor do |request, exception|
488
- HypoteticalPlugin.capture_exception(request, exception)
489
- end
363
+ * Add the ability to set the CSP nonce only to the specified directives.
490
364
 
491
- *Genadi Samokovarov*
365
+ Fixes #35137.
492
366
 
493
- * Output only one Content-Security-Policy nonce header value per request.
367
+ *Yuji Yaginuma*
494
368
 
495
- Fixes #32597.
369
+ * Keep part when scope option has value.
496
370
 
497
- *Andrey Novikov*, *Andrew White*
371
+ When a route was defined within an optional scope, if that route didn't
372
+ take parameters the scope was lost when using path helpers. This commit
373
+ ensures scope is kept both when the route takes parameters or when it
374
+ doesn't.
498
375
 
499
- * Move default headers configuration into their own module that can be included in controllers.
376
+ Fixes #33219.
500
377
 
501
- *Kevin Deisz*
378
+ *Alberto Almagro*
502
379
 
503
- * Add method `dig` to `session`.
380
+ * Added `deep_transform_keys` and `deep_transform_keys!` methods to ActionController::Parameters.
504
381
 
505
- *claudiob*, *Takumi Shotoku*
382
+ *Gustavo Gutierrez*
506
383
 
507
- * Controller level `force_ssl` has been deprecated in favor of
508
- `config.force_ssl`.
384
+ * Calling `ActionController::Parameters#transform_keys`/`!` without a block now returns
385
+ an enumerator for the parameters instead of the underlying hash.
509
386
 
510
- *Derek Prior*
387
+ *Eugene Kenny*
511
388
 
512
- * Rails 6 requires Ruby 2.5.0 or newer.
389
+ * Fix strong parameters blocks all attributes even when only some keys are invalid (non-numerical).
390
+ It should only block invalid key's values instead.
513
391
 
514
- *Jeremy Daer*, *Kasper Timm Hansen*
392
+ *Stan Lo*
515
393
 
516
394
 
517
- Please check [5-2-stable](https://github.com/rails/rails/blob/5-2-stable/actionpack/CHANGELOG.md) for previous changes.
395
+ Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionpack/CHANGELOG.md) for previous changes.