actionpack 6.0.4.8 → 6.1.0.rc1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of actionpack might be problematic. Click here for more details.

Files changed (113) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +235 -337
  3. data/MIT-LICENSE +1 -1
  4. data/README.rdoc +1 -1
  5. data/lib/abstract_controller/base.rb +35 -2
  6. data/lib/abstract_controller/callbacks.rb +2 -2
  7. data/lib/abstract_controller/helpers.rb +105 -90
  8. data/lib/abstract_controller/rendering.rb +9 -9
  9. data/lib/abstract_controller/translation.rb +8 -2
  10. data/lib/abstract_controller.rb +1 -0
  11. data/lib/action_controller/api.rb +2 -2
  12. data/lib/action_controller/base.rb +4 -2
  13. data/lib/action_controller/caching.rb +0 -1
  14. data/lib/action_controller/log_subscriber.rb +3 -3
  15. data/lib/action_controller/metal/conditional_get.rb +10 -2
  16. data/lib/action_controller/metal/content_security_policy.rb +1 -1
  17. data/lib/action_controller/metal/data_streaming.rb +1 -1
  18. data/lib/action_controller/metal/etag_with_template_digest.rb +2 -4
  19. data/lib/action_controller/metal/exceptions.rb +33 -0
  20. data/lib/action_controller/metal/feature_policy.rb +46 -0
  21. data/lib/action_controller/metal/head.rb +7 -4
  22. data/lib/action_controller/metal/helpers.rb +11 -1
  23. data/lib/action_controller/metal/http_authentication.rb +5 -3
  24. data/lib/action_controller/metal/implicit_render.rb +1 -1
  25. data/lib/action_controller/metal/instrumentation.rb +11 -9
  26. data/lib/action_controller/metal/live.rb +1 -1
  27. data/lib/action_controller/metal/logging.rb +20 -0
  28. data/lib/action_controller/metal/mime_responds.rb +6 -2
  29. data/lib/action_controller/metal/parameter_encoding.rb +35 -4
  30. data/lib/action_controller/metal/params_wrapper.rb +16 -11
  31. data/lib/action_controller/metal/redirecting.rb +1 -1
  32. data/lib/action_controller/metal/rendering.rb +6 -0
  33. data/lib/action_controller/metal/request_forgery_protection.rb +1 -1
  34. data/lib/action_controller/metal/rescue.rb +1 -1
  35. data/lib/action_controller/metal/strong_parameters.rb +103 -15
  36. data/lib/action_controller/metal.rb +2 -2
  37. data/lib/action_controller/renderer.rb +24 -13
  38. data/lib/action_controller/test_case.rb +62 -56
  39. data/lib/action_controller.rb +2 -3
  40. data/lib/action_dispatch/http/cache.rb +12 -10
  41. data/lib/action_dispatch/http/content_security_policy.rb +11 -0
  42. data/lib/action_dispatch/http/feature_policy.rb +168 -0
  43. data/lib/action_dispatch/http/filter_parameters.rb +1 -1
  44. data/lib/action_dispatch/http/filter_redirect.rb +1 -1
  45. data/lib/action_dispatch/http/headers.rb +3 -2
  46. data/lib/action_dispatch/http/mime_negotiation.rb +14 -8
  47. data/lib/action_dispatch/http/mime_type.rb +29 -16
  48. data/lib/action_dispatch/http/parameters.rb +1 -19
  49. data/lib/action_dispatch/http/request.rb +24 -8
  50. data/lib/action_dispatch/http/response.rb +17 -16
  51. data/lib/action_dispatch/http/url.rb +3 -2
  52. data/lib/action_dispatch/journey/formatter.rb +53 -28
  53. data/lib/action_dispatch/journey/gtg/builder.rb +22 -36
  54. data/lib/action_dispatch/journey/gtg/simulator.rb +8 -7
  55. data/lib/action_dispatch/journey/gtg/transition_table.rb +6 -4
  56. data/lib/action_dispatch/journey/nfa/dot.rb +0 -11
  57. data/lib/action_dispatch/journey/nodes/node.rb +4 -3
  58. data/lib/action_dispatch/journey/parser.rb +13 -13
  59. data/lib/action_dispatch/journey/parser.y +1 -1
  60. data/lib/action_dispatch/journey/path/pattern.rb +13 -18
  61. data/lib/action_dispatch/journey/route.rb +7 -18
  62. data/lib/action_dispatch/journey/router/utils.rb +6 -4
  63. data/lib/action_dispatch/journey/router.rb +26 -30
  64. data/lib/action_dispatch/journey.rb +0 -2
  65. data/lib/action_dispatch/middleware/actionable_exceptions.rb +1 -1
  66. data/lib/action_dispatch/middleware/cookies.rb +67 -32
  67. data/lib/action_dispatch/middleware/debug_exceptions.rb +8 -15
  68. data/lib/action_dispatch/middleware/debug_view.rb +1 -1
  69. data/lib/action_dispatch/middleware/exception_wrapper.rb +28 -16
  70. data/lib/action_dispatch/middleware/executor.rb +1 -1
  71. data/lib/action_dispatch/middleware/host_authorization.rb +35 -35
  72. data/lib/action_dispatch/middleware/remote_ip.rb +5 -4
  73. data/lib/action_dispatch/middleware/request_id.rb +4 -5
  74. data/lib/action_dispatch/middleware/session/abstract_store.rb +2 -2
  75. data/lib/action_dispatch/middleware/session/cookie_store.rb +2 -2
  76. data/lib/action_dispatch/middleware/ssl.rb +9 -6
  77. data/lib/action_dispatch/middleware/stack.rb +18 -0
  78. data/lib/action_dispatch/middleware/static.rb +154 -93
  79. data/lib/action_dispatch/middleware/templates/rescues/_message_and_suggestions.html.erb +18 -0
  80. data/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb +2 -5
  81. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.html.erb +2 -2
  82. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.text.erb +2 -3
  83. data/lib/action_dispatch/middleware/templates/rescues/layout.erb +88 -8
  84. data/lib/action_dispatch/middleware/templates/rescues/unknown_action.html.erb +1 -1
  85. data/lib/action_dispatch/middleware/templates/routes/_table.html.erb +12 -1
  86. data/lib/action_dispatch/railtie.rb +3 -2
  87. data/lib/action_dispatch/request/session.rb +2 -8
  88. data/lib/action_dispatch/request/utils.rb +26 -2
  89. data/lib/action_dispatch/routing/inspector.rb +8 -7
  90. data/lib/action_dispatch/routing/mapper.rb +102 -71
  91. data/lib/action_dispatch/routing/polymorphic_routes.rb +16 -19
  92. data/lib/action_dispatch/routing/redirection.rb +3 -3
  93. data/lib/action_dispatch/routing/route_set.rb +49 -41
  94. data/lib/action_dispatch/system_test_case.rb +29 -24
  95. data/lib/action_dispatch/system_testing/browser.rb +33 -27
  96. data/lib/action_dispatch/system_testing/driver.rb +6 -7
  97. data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb +47 -6
  98. data/lib/action_dispatch/system_testing/test_helpers/setup_and_teardown.rb +4 -7
  99. data/lib/action_dispatch/testing/assertions/response.rb +2 -4
  100. data/lib/action_dispatch/testing/assertions/routing.rb +5 -5
  101. data/lib/action_dispatch/testing/assertions.rb +1 -1
  102. data/lib/action_dispatch/testing/integration.rb +38 -27
  103. data/lib/action_dispatch/testing/test_process.rb +29 -4
  104. data/lib/action_dispatch/testing/test_request.rb +3 -3
  105. data/lib/action_dispatch.rb +3 -2
  106. data/lib/action_pack/gem_version.rb +3 -3
  107. data/lib/action_pack.rb +1 -1
  108. metadata +23 -24
  109. data/lib/action_controller/metal/force_ssl.rb +0 -58
  110. data/lib/action_dispatch/http/parameter_filter.rb +0 -12
  111. data/lib/action_dispatch/journey/nfa/builder.rb +0 -78
  112. data/lib/action_dispatch/journey/nfa/simulator.rb +0 -47
  113. data/lib/action_dispatch/journey/nfa/transition_table.rb +0 -119
data/CHANGELOG.md CHANGED
@@ -1,156 +1,166 @@
1
- ## Rails 6.0.4.8 (April 26, 2022) ##
1
+ ## Rails 6.1.0.rc1 (November 02, 2020) ##
2
2
 
3
- * Allow Content Security Policy DSL to generate for API responses.
3
+ * Allow `ActionDispatch::HostAuthorization` to exclude specific requests.
4
4
 
5
- *Tim Wade*
5
+ Host Authorization checks can be skipped for specific requests. This allows for health check requests to be permitted for requests with missing or non-matching host headers.
6
6
 
7
- ## Rails 6.0.4.7 (March 08, 2022) ##
7
+ *Chris Bisnett*
8
8
 
9
- * No changes.
9
+ * Add `config.action_dispatch.request_id_header` to allow changing the name of
10
+ the unique X-Request-Id header
10
11
 
12
+ *Arlston Fernandes*
11
13
 
12
- ## Rails 6.0.4.6 (February 11, 2022) ##
13
-
14
- * No changes.
15
-
16
-
17
- ## Rails 6.0.4.5 (February 11, 2022) ##
18
-
19
- * Under certain circumstances, the middleware isn't informed that the
20
- response body has been fully closed which result in request state not
21
- being fully reset before the next request
22
-
23
- [CVE-2022-23633]
24
-
25
-
26
- ## Rails 6.0.4.4 (December 15, 2021) ##
27
-
28
- * Fix issue with host protection not allowing host with port in development.
14
+ * Deprecate `config.action_dispatch.return_only_media_type_on_content_type`.
29
15
 
16
+ *Rafael Mendonça França*
30
17
 
31
- ## Rails 6.0.4.3 (December 14, 2021) ##
18
+ * Change `ActionDispatch::Response#content_type` to return the full Content-Type header.
32
19
 
33
- * Fix issue with host protection not allowing localhost in development.
20
+ *Rafael Mendonça França*
34
21
 
22
+ * Remove deprecated `ActionDispatch::Http::ParameterFilter`.
35
23
 
36
- ## Rails 6.0.4.2 (December 14, 2021) ##
24
+ *Rafael Mendonça França*
37
25
 
38
- * Fix X_FORWARDED_HOST protection. [CVE-2021-44528]
26
+ * Added support for exclusive no-store Cache-Control header.
39
27
 
40
- ## Rails 6.1.4.1 (August 19, 2021) ##
28
+ If `no-store` is set on Cache-Control header it is exclusive (all other cache directives are dropped).
41
29
 
42
- * [CVE-2021-22942] Fix possible open redirect in Host Authorization middleware.
30
+ *Chris Kruger*
43
31
 
44
- Specially crafted "X-Forwarded-Host" headers in combination with certain
45
- "allowed host" formats can cause the Host Authorization middleware in Action
46
- Pack to redirect users to a malicious website.
32
+ * Catch invalid UTF-8 parameters for POST requests and respond with BadRequest.
47
33
 
48
- ## Rails 6.0.4 (June 15, 2021) ##
34
+ Additionally, perform `#set_binary_encoding` in `ActionDispatch::Http::Request#GET` and
35
+ `ActionDispatch::Http::Request#POST` prior to validating encoding.
49
36
 
50
- * Accept base64_urlsafe CSRF tokens to make forward compatible.
37
+ *Adrianna Chang*
51
38
 
52
- Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
53
- them difficult to deal with. For example, the common practice of sending
54
- the CSRF token to a browser in a client-readable cookie does not work properly
55
- out of the box: the value has to be url-encoded and decoded to survive transport.
39
+ * Allow `assert_recognizes` routing assertions to work on mounted root routes.
56
40
 
57
- In Rails 6.1, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently
58
- safe to transport. Validation accepts both urlsafe tokens, and strict-encoded
59
- tokens for backwards compatibility.
41
+ *Gannon McGibbon*
60
42
 
61
- In Rails 5.2.5, the CSRF token format is accidentally changed to urlsafe-encoded.
62
- If you upgrade apps from 5.2.5, set the config `urlsafe_csrf_tokens = true`.
43
+ * Change default redirection status code for non-GET/HEAD requests to 308 Permanent Redirect for `ActionDispatch::SSL`.
63
44
 
64
- ```ruby
65
- Rails.application.config.action_controller.urlsafe_csrf_tokens = true
66
- ```
45
+ *Alan Tan*, *Oz Ben-David*
67
46
 
68
- *Scott Blum*, *Étienne Barrié*
47
+ * Fix `follow_redirect!` to follow redirection with same HTTP verb when following
48
+ a 308 redirection.
69
49
 
70
- * Signed and encrypted cookies can now store `false` as their value when
71
- `action_dispatch.use_cookies_with_metadata` is enabled.
50
+ *Alan Tan*
72
51
 
73
- *Rolandas Barysas*
52
+ * When multiple domains are specified for a cookie, a domain will now be
53
+ chosen only if it is equal to or is a superdomain of the request host.
74
54
 
55
+ *Jonathan Hefner*
75
56
 
76
- ## Rails 6.0.3.7 (May 05, 2021) ##
57
+ * `ActionDispatch::Static` handles precompiled Brotli (.br) files.
77
58
 
78
- * Prevent catastrophic backtracking during mime parsing
79
- CVE-2021-22902
59
+ Adds to existing support for precompiled gzip (.gz) files.
60
+ Brotli files are preferred due to much better compression.
80
61
 
81
- * Prevent regex DoS in HTTP token authentication
82
- CVE-2021-22904
62
+ When the browser requests /some.js with `Accept-Encoding: br`,
63
+ we check for public/some.js.br and serve that file, if present, with
64
+ `Content-Encoding: br` and `Vary: Accept-Encoding` headers.
83
65
 
84
- * Prevent string polymorphic route arguments.
66
+ *Ryan Edward Hall*, *Jeremy Daer*
85
67
 
86
- `url_for` supports building polymorphic URLs via an array
87
- of arguments (usually symbols and records). If a developer passes a
88
- user input array, strings can result in unwanted route helper calls.
68
+ * Add raise_on_missing_translations support for controllers.
89
69
 
90
- CVE-2021-22885
70
+ This configuration determines whether an error should be raised for missing translations.
71
+ It can be enabled through `config.i18n.raise_on_missing_translations`. Note that described
72
+ configuration also affects raising error for missing translations in views.
91
73
 
92
- *Gannon McGibbon*
74
+ *fatkodima*
93
75
 
94
- ## Rails 6.0.3.6 (March 26, 2021) ##
76
+ * Added `compact` and `compact!` to `ActionController::Parameters`.
95
77
 
96
- * No changes.
78
+ *Eugene Kenny*
97
79
 
80
+ * Calling `each_pair` or `each_value` on an `ActionController::Parameters`
81
+ without passing a block now returns an enumerator.
98
82
 
99
- ## Rails 6.0.3.5 (February 10, 2021) ##
83
+ *Eugene Kenny*
100
84
 
101
- * Prevent open redirect when allowed host starts with a dot
85
+ * `fixture_file_upload` now uses path relative to `file_fixture_path`
102
86
 
103
- [CVE-2021-22881]
87
+ Previously the path had to be relative to `fixture_path`.
88
+ You can change your existing code as follow:
104
89
 
105
- Thanks to @tktech (https://hackerone.com/tktech) for reporting this
106
- issue and the patch!
90
+ ```ruby
91
+ # Before
92
+ fixture_file_upload('files/dog.png')
107
93
 
108
- *Aaron Patterson*
94
+ # After
95
+ fixture_file_upload('dog.png')
96
+ ```
109
97
 
98
+ *Edouard Chin*
110
99
 
111
- ## Rails 6.0.3.4 (October 07, 2020) ##
100
+ * Remove deprecated `force_ssl` at the controller level.
112
101
 
113
- * [CVE-2020-8264] Prevent XSS in Actionable Exceptions
102
+ *Rafael Mendonça França*
114
103
 
104
+ * The +helper+ class method for controllers loads helper modules specified as
105
+ strings/symbols with `String#constantize` instead of `require_dependency`.
115
106
 
116
- ## Rails 6.0.3.3 (September 09, 2020) ##
107
+ Remember that support for strings/symbols is only a convenient API. You can
108
+ always pass a module object:
117
109
 
118
- * No changes.
110
+ ```ruby
111
+ helper UtilsHelper
112
+ ```
119
113
 
114
+ which is recommended because it is simple and direct. When a string/symbol
115
+ is received, `helper` just manipulates and inflects the argument to obtain
116
+ that same module object.
120
117
 
121
- ## Rails 6.0.3.2 (June 17, 2020) ##
118
+ *Xavier Noria*, *Jean Boussier*
122
119
 
123
- * [CVE-2020-8185] Only allow ActionableErrors if show_detailed_exceptions is enabled
120
+ * Correctly identify the entire localhost IPv4 range as trusted proxy.
124
121
 
125
- ## Rails 6.0.3.1 (May 18, 2020) ##
122
+ *Nick Soracco*
126
123
 
127
- * [CVE-2020-8166] HMAC raw CSRF token before masking it, so it cannot be used to reconstruct a per-form token
124
+ * `url_for` will now use "https://" as the default protocol when
125
+ `Rails.application.config.force_ssl` is set to true.
128
126
 
129
- * [CVE-2020-8164] Return self when calling #each, #each_pair, and #each_value instead of the raw @parameters hash
127
+ *Jonathan Hefner*
130
128
 
129
+ * Accept and default to base64_urlsafe CSRF tokens.
131
130
 
132
- ## Rails 6.0.3 (May 06, 2020) ##
131
+ Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
132
+ them difficult to deal with. For example, the common practice of sending
133
+ the CSRF token to a browser in a client-readable cookie does not work properly
134
+ out of the box: the value has to be url-encoded and decoded to survive transport.
133
135
 
134
- * Include child session assertion count in ActionDispatch::IntegrationTest
136
+ Now, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently safe
137
+ to transport. Validation accepts both urlsafe tokens, and strict-encoded tokens
138
+ for backwards compatibility.
135
139
 
136
- `IntegrationTest#open_session` uses `dup` to create the new session, which
137
- meant it had its own copy of `@assertions`. This prevented the assertions
138
- from being correctly counted and reported.
140
+ *Scott Blum*
139
141
 
140
- Child sessions now have their `attr_accessor` overriden to delegate to the
141
- root session.
142
+ * Support rolling deploys for cookie serialization/encryption changes.
142
143
 
143
- Fixes #32142
144
+ In a distributed configuration like rolling update, users may observe
145
+ both old and new instances during deployment. Users may be served by a
146
+ new instance and then by an old instance.
144
147
 
145
- *Sam Bostock*
148
+ That means when the server changes `cookies_serializer` from `:marshal`
149
+ to `:hybrid` or the server changes `use_authenticated_cookie_encryption`
150
+ from `false` to `true`, users may lose their sessions if they access the
151
+ server during deployment.
146
152
 
153
+ We added fallbacks to downgrade the cookie format when necessary during
154
+ deployment, ensuring compatibility on both old and new instances.
147
155
 
148
- ## Rails 6.0.2.2 (March 19, 2020) ##
156
+ *Masaki Hara*
149
157
 
150
- * No changes.
158
+ * `ActionDispatch::Request.remote_ip` has ip address even when all sites are trusted.
151
159
 
160
+ Before, if all `X-Forwarded-For` sites were trusted, the `remote_ip` would default to `127.0.0.1`.
161
+ Now, the furthest proxy site is used. e.g.: It now gives an ip address when using curl from the load balancer.
152
162
 
153
- ## Rails 6.0.2.1 (December 18, 2019) ##
163
+ *Keenan Brock*
154
164
 
155
165
  * Fix possible information leak / session hijacking vulnerability.
156
166
 
@@ -159,339 +169,227 @@
159
169
 
160
170
  CVE-2019-16782.
161
171
 
172
+ * Include child session assertion count in ActionDispatch::IntegrationTest.
162
173
 
163
- ## Rails 6.0.2 (December 13, 2019) ##
174
+ `IntegrationTest#open_session` uses `dup` to create the new session, which
175
+ meant it had its own copy of `@assertions`. This prevented the assertions
176
+ from being correctly counted and reported.
164
177
 
165
- * Allow using mountable engine route helpers in System Tests.
178
+ Child sessions now have their `attr_accessor` overridden to delegate to the
179
+ root session.
166
180
 
167
- *Chalo Fernandez*
181
+ Fixes #32142.
168
182
 
183
+ *Sam Bostock*
169
184
 
170
- ## Rails 6.0.1 (November 5, 2019) ##
185
+ * Add SameSite protection to every written cookie.
171
186
 
172
- * `ActionDispatch::SystemTestCase` now inherits from `ActiveSupport::TestCase`
173
- rather than `ActionDispatch::IntegrationTest`. This permits running jobs in
174
- system tests.
187
+ Enabling `SameSite` cookie protection is an addition to CSRF protection,
188
+ where cookies won't be sent by browsers in cross-site POST requests when set to `:lax`.
175
189
 
176
- *George Claghorn*, *Edouard Chin*
190
+ `:strict` disables cookies being sent in cross-site GET or POST requests.
177
191
 
178
- * Registered MIME types may contain extra flags:
192
+ Passing `:none` disables this protection and is the same as previous versions albeit a `; SameSite=None` is appended to the cookie.
179
193
 
180
- ```ruby
181
- Mime::Type.register "text/html; fragment", :html_fragment
182
- ```
194
+ See upgrade instructions in config/initializers/new_framework_defaults_6_1.rb.
183
195
 
184
- *Aaron Patterson*
196
+ More info [here](https://tools.ietf.org/html/draft-west-first-party-cookies-07)
185
197
 
198
+ _NB: Technically already possible as Rack supports SameSite protection, this is to ensure it's applied to all cookies_
186
199
 
187
- ## Rails 6.0.0 (August 16, 2019) ##
200
+ *Cédric Fabianski*
188
201
 
189
- * No changes.
202
+ * Bring back the feature that allows loading external route files from the router.
190
203
 
204
+ This feature existed back in 2012 but got reverted with the incentive that
205
+ https://github.com/rails/routing_concerns was a better approach. Turned out
206
+ that this wasn't fully the case and loading external route files from the router
207
+ can be helpful for applications with a really large set of routes.
208
+ Without this feature, application needs to implement routes reloading
209
+ themselves and it's not straightforward.
191
210
 
192
- ## Rails 6.0.0.rc2 (July 22, 2019) ##
211
+ ```ruby
212
+ # config/routes.rb
193
213
 
194
- * Add the ability to set the CSP nonce only to the specified directives.
214
+ Rails.application.routes.draw do
215
+ draw(:admin)
216
+ end
195
217
 
196
- Fixes #35137.
218
+ # config/routes/admin.rb
197
219
 
198
- *Yuji Yaginuma*
220
+ get :foo, to: 'foo#bar'
221
+ ```
199
222
 
200
- * Keep part when scope option has value.
223
+ *Yehuda Katz*, *Edouard Chin*
201
224
 
202
- When a route was defined within an optional scope, if that route didn't
203
- take parameters the scope was lost when using path helpers. This commit
204
- ensures scope is kept both when the route takes parameters or when it
205
- doesn't.
225
+ * Fix system test driver option initialization for non-headless browsers.
206
226
 
207
- Fixes #33219
227
+ *glaszig*
208
228
 
209
- *Alberto Almagro*
229
+ * `redirect_to.action_controller` notifications now include the `ActionDispatch::Request` in
230
+ their payloads as `:request`.
210
231
 
211
- * Change `ActionDispatch::Response#content_type` to return Content-Type header as it is.
232
+ *Austin Story*
212
233
 
213
- Previously, `ActionDispatch::Response#content_type` returned value does NOT
214
- contain charset part. This behavior changed to returned Content-Type header
215
- containing charset part as it is.
234
+ * `respond_to#any` no longer returns a response's Content-Type based on the
235
+ request format but based on the block given.
216
236
 
217
- If you want just MIME type, please use `ActionDispatch::Response#media_type`
218
- instead.
237
+ Example:
219
238
 
220
- Enable `action_dispatch.return_only_media_type_on_content_type` to use this change.
221
- If not enabled, `ActionDispatch::Response#content_type` returns the same
222
- value as before version, but its behavior is deprecate.
239
+ ```ruby
240
+ def my_action
241
+ respond_to do |format|
242
+ format.any { render(json: { foo: 'bar' }) }
243
+ end
244
+ end
223
245
 
224
- *Yuji Yaginuma*
246
+ get('my_action.csv')
247
+ ```
225
248
 
226
- * Calling `ActionController::Parameters#transform_keys/!` without a block now returns
227
- an enumerator for the parameters instead of the underlying hash.
249
+ The previous behaviour was to respond with a `text/csv` Content-Type which
250
+ is inaccurate since a JSON response is being rendered.
228
251
 
229
- *Eugene Kenny*
252
+ Now it correctly returns a `application/json` Content-Type.
230
253
 
231
- * Fix a bug where DebugExceptions throws an error when malformed query parameters are provided
254
+ *Edouard Chin*
232
255
 
233
- *Yuki Nishijima*, *Stan Lo*
256
+ * Replaces (back)slashes in failure screenshot image paths with dashes.
234
257
 
258
+ If a failed test case contained a slash or a backslash, a screenshot would be created in a
259
+ nested directory, causing issues with `tmp:clear`.
235
260
 
236
- ## Rails 6.0.0.rc1 (April 24, 2019) ##
261
+ *Damir Zekic*
237
262
 
238
- * Make system tests take a failed screenshot in a `before_teardown` hook
239
- rather than an `after_teardown` hook.
263
+ * Add `params.member?` to mimic Hash behavior.
240
264
 
241
- This helps minimize the time gap between when an assertion fails and when
242
- the screenshot is taken (reducing the time in which the page could have
243
- been dynamically updated after the assertion failed).
265
+ *Younes Serraj*
244
266
 
245
- *Richard Macklin*
267
+ * `process_action.action_controller` notifications now include the following in their payloads:
246
268
 
247
- * Introduce `ActionDispatch::ActionableExceptions`.
269
+ * `:request` - the `ActionDispatch::Request`
270
+ * `:response` - the `ActionDispatch::Response`
248
271
 
249
- The `ActionDispatch::ActionableExceptions` middleware dispatches actions
250
- from `ActiveSupport::ActionableError` descendants.
272
+ *George Claghorn*
251
273
 
252
- Actionable errors let's you dispatch actions from Rails' error pages.
274
+ * Updated `ActionDispatch::Request.remote_ip` setter to clear set the instance
275
+ `remote_ip` to `nil` before setting the header that the value is derived
276
+ from.
253
277
 
254
- *Vipul A M*, *Yao Jie*, *Genadi Samokovarov*
278
+ Fixes #37383.
255
279
 
256
- * Raise an `ArgumentError` if a resource custom param contains a colon (`:`).
280
+ *Norm Provost*
257
281
 
258
- After this change it's not possible anymore to configure routes like this:
282
+ * `ActionController::Base.log_at` allows setting a different log level per request.
259
283
 
260
- ```
261
- routes.draw do
262
- resources :users, param: 'name/:sneaky'
284
+ ```ruby
285
+ # Use the debug level if a particular cookie is set.
286
+ class ApplicationController < ActionController::Base
287
+ log_at :debug, if: -> { cookies[:debug] }
263
288
  end
264
289
  ```
265
290
 
266
- Fixes #30467.
291
+ *George Claghorn*
267
292
 
268
- *Josua Schmid*
293
+ * Allow system test screen shots to be taken more than once in
294
+ a test by prefixing the file name with an incrementing counter.
269
295
 
296
+ Add an environment variable `RAILS_SYSTEM_TESTING_SCREENSHOT_HTML` to
297
+ enable saving of HTML during a screenshot in addition to the image.
298
+ This uses the same image name, with the extension replaced with `.html`
270
299
 
271
- ## Rails 6.0.0.beta3 (March 11, 2019) ##
300
+ *Tom Fakes*
272
301
 
273
- * No changes.
302
+ * Add `Vary: Accept` header when using `Accept` header for response.
274
303
 
304
+ For some requests like `/users/1`, Rails uses requests' `Accept`
305
+ header to determine what to return. And if we don't add `Vary`
306
+ in the response header, browsers might accidentally cache different
307
+ types of content, which would cause issues: e.g. javascript got displayed
308
+ instead of html content. This PR fixes these issues by adding `Vary: Accept`
309
+ in these types of requests. For more detailed problem description, please read:
275
310
 
276
- ## Rails 6.0.0.beta2 (February 25, 2019) ##
311
+ https://github.com/rails/rails/pull/36213
277
312
 
278
- * Make debug exceptions works in an environment where ActiveStorage is not loaded.
313
+ Fixes #25842.
279
314
 
280
- *Tomoyuki Kurosawa*
315
+ *Stan Lo*
281
316
 
282
- * `ActionDispatch::SystemTestCase.driven_by` can now be called with a block
283
- to define specific browser capabilities.
317
+ * Fix IntegrationTest `follow_redirect!` to follow redirection using the same HTTP verb when following
318
+ a 307 redirection.
284
319
 
285
320
  *Edouard Chin*
286
321
 
322
+ * System tests require Capybara 3.26 or newer.
287
323
 
288
- ## Rails 6.0.0.beta1 (January 18, 2019) ##
289
-
290
- * Remove deprecated `fragment_cache_key` helper in favor of `combined_fragment_cache_key`.
291
-
292
- *Rafael Mendonça França*
293
-
294
- * Remove deprecated methods in `ActionDispatch::TestResponse`.
295
-
296
- `#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
297
- `#successful?`, `not_found?` and `server_error?`.
298
-
299
- *Rafael Mendonça França*
324
+ *George Claghorn*
300
325
 
301
- * Introduce `ActionDispatch::HostAuthorization`.
326
+ * Reduced log noise handling ActionController::RoutingErrors.
302
327
 
303
- This is a new middleware that guards against DNS rebinding attacks by
304
- explicitly permitting the hosts a request can be made to.
328
+ *Alberto Fernández-Capel*
305
329
 
306
- Each host is checked with the case operator (`#===`) to support `Regexp`,
307
- `Proc`, `IPAddr` and custom objects as host allowances.
330
+ * Add DSL for configuring HTTP Feature Policy.
308
331
 
309
- *Genadi Samokovarov*
332
+ This new DSL provides a way to configure an HTTP Feature Policy at a
333
+ global or per-controller level. Full details of HTTP Feature Policy
334
+ specification and guidelines can be found at MDN:
310
335
 
311
- * Allow using `parsed_body` in `ActionController::TestCase`.
336
+ https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy
312
337
 
313
- In addition to `ActionDispatch::IntegrationTest`, allow using
314
- `parsed_body` in `ActionController::TestCase`:
338
+ Example global policy:
315
339
 
316
- ```
317
- class SomeControllerTest < ActionController::TestCase
318
- def test_some_action
319
- post :action, body: { foo: 'bar' }
320
- assert_equal({ "foo" => "bar" }, response.parsed_body)
321
- end
340
+ ```ruby
341
+ Rails.application.config.feature_policy do |f|
342
+ f.camera :none
343
+ f.gyroscope :none
344
+ f.microphone :none
345
+ f.usb :none
346
+ f.fullscreen :self
347
+ f.payment :self, "https://secure.example.com"
322
348
  end
323
349
  ```
324
350
 
325
- Fixes #34676.
326
-
327
- *Tobias Bühlmann*
328
-
329
- * Raise an error on root route naming conflicts.
330
-
331
- Raises an `ArgumentError` when multiple root routes are defined in the
332
- same context instead of assigning nil names to subsequent roots.
333
-
334
- *Gannon McGibbon*
335
-
336
- * Allow rescue from parameter parse errors:
351
+ Example controller level policy:
337
352
 
338
- ```
339
- rescue_from ActionDispatch::Http::Parameters::ParseError do
340
- head :unauthorized
353
+ ```ruby
354
+ class PagesController < ApplicationController
355
+ feature_policy do |p|
356
+ p.geolocation "https://example.com"
357
+ end
341
358
  end
342
359
  ```
343
360
 
344
- *Gannon McGibbon*, *Josh Cheek*
345
-
346
- * Reset Capybara sessions if failed system test screenshot raising an exception.
347
-
348
- Reset Capybara sessions if `take_failed_screenshot` raise exception
349
- in system test `after_teardown`.
350
-
351
- *Maxim Perepelitsa*
352
-
353
- * Use request object for context if there's no controller
354
-
355
- There is no controller instance when using a redirect route or a
356
- mounted rack application so pass the request object as the context
357
- when resolving dynamic CSP sources in this scenario.
358
-
359
- Fixes #34200.
360
-
361
- *Andrew White*
362
-
363
- * Apply mapping to symbols returned from dynamic CSP sources
364
-
365
- Previously if a dynamic source returned a symbol such as :self it
366
- would be converted to a string implicitly, e.g:
367
-
368
- policy.default_src -> { :self }
369
-
370
- would generate the header:
371
-
372
- Content-Security-Policy: default-src self
373
-
374
- and now it generates:
375
-
376
- Content-Security-Policy: default-src 'self'
377
-
378
- *Andrew White*
379
-
380
- * Add `ActionController::Parameters#each_value`.
381
-
382
- *Lukáš Zapletal*
383
-
384
- * Deprecate `ActionDispatch::Http::ParameterFilter` in favor of `ActiveSupport::ParameterFilter`.
385
-
386
- *Yoshiyuki Kinjo*
387
-
388
- * Encode Content-Disposition filenames on `send_data` and `send_file`.
389
- Previously, `send_data 'data', filename: "\u{3042}.txt"` sends
390
- `"filename=\"\u{3042}.txt\""` as Content-Disposition and it can be
391
- garbled.
392
- Now it follows [RFC 2231](https://tools.ietf.org/html/rfc2231) and
393
- [RFC 5987](https://tools.ietf.org/html/rfc5987) and sends
394
- `"filename=\"%3F.txt\"; filename*=UTF-8''%E3%81%82.txt"`.
395
- Most browsers can find filename correctly and old browsers fallback to ASCII
396
- converted name.
397
-
398
- *Fumiaki Matsushima*
399
-
400
- * Expose `ActionController::Parameters#each_key` which allows iterating over
401
- keys without allocating an array.
402
-
403
- *Richard Schneeman*
361
+ *Jacob Bednarz*
404
362
 
405
- * Purpose metadata for signed/encrypted cookies.
406
-
407
- Rails can now thwart attacks that attempt to copy signed/encrypted value
408
- of a cookie and use it as the value of another cookie.
409
-
410
- It does so by stashing the cookie-name in the purpose field which is
411
- then signed/encrypted along with the cookie value. Then, on a server-side
412
- read, we verify the cookie-names and discard any attacked cookies.
413
-
414
- Enable `action_dispatch.use_cookies_with_metadata` to use this feature, which
415
- writes cookies with the new purpose and expiry metadata embedded.
416
-
417
- *Assain Jaleel*
418
-
419
- * Raises `ActionController::RespondToMismatchError` with conflicting `respond_to` invocations.
420
-
421
- `respond_to` can match multiple types and lead to undefined behavior when
422
- multiple invocations are made and the types do not match:
423
-
424
- respond_to do |outer_type|
425
- outer_type.js do
426
- respond_to do |inner_type|
427
- inner_type.html { render body: "HTML" }
428
- end
429
- end
430
- end
431
-
432
- *Patrick Toomey*
433
-
434
- * `ActionDispatch::Http::UploadedFile` now delegates `to_path` to its tempfile.
435
-
436
- This allows uploaded file objects to be passed directly to `File.read`
437
- without raising a `TypeError`:
438
-
439
- uploaded_file = ActionDispatch::Http::UploadedFile.new(tempfile: tmp_file)
440
- File.read(uploaded_file)
441
-
442
- *Aaron Kromer*
443
-
444
- * Pass along arguments to underlying `get` method in `follow_redirect!`
445
-
446
- Now all arguments passed to `follow_redirect!` are passed to the underlying
447
- `get` method. This for example allows to set custom headers for the
448
- redirection request to the server.
449
-
450
- follow_redirect!(params: { foo: :bar })
451
-
452
- *Remo Fritzsche*
453
-
454
- * Introduce a new error page to when the implicit render page is accessed in the browser.
455
-
456
- Now instead of showing an error page that with exception and backtraces we now show only
457
- one informative page.
458
-
459
- *Vinicius Stock*
460
-
461
- * Introduce `ActionDispatch::DebugExceptions.register_interceptor`.
462
-
463
- Exception aware plugin authors can use the newly introduced
464
- `.register_interceptor` method to get the processed exception, instead of
465
- monkey patching DebugExceptions.
466
-
467
- ActionDispatch::DebugExceptions.register_interceptor do |request, exception|
468
- HypoteticalPlugin.capture_exception(request, exception)
469
- end
363
+ * Add the ability to set the CSP nonce only to the specified directives.
470
364
 
471
- *Genadi Samokovarov*
365
+ Fixes #35137.
472
366
 
473
- * Output only one Content-Security-Policy nonce header value per request.
367
+ *Yuji Yaginuma*
474
368
 
475
- Fixes #32597.
369
+ * Keep part when scope option has value.
476
370
 
477
- *Andrey Novikov*, *Andrew White*
371
+ When a route was defined within an optional scope, if that route didn't
372
+ take parameters the scope was lost when using path helpers. This commit
373
+ ensures scope is kept both when the route takes parameters or when it
374
+ doesn't.
478
375
 
479
- * Move default headers configuration into their own module that can be included in controllers.
376
+ Fixes #33219.
480
377
 
481
- *Kevin Deisz*
378
+ *Alberto Almagro*
482
379
 
483
- * Add method `dig` to `session`.
380
+ * Added `deep_transform_keys` and `deep_transform_keys!` methods to ActionController::Parameters.
484
381
 
485
- *claudiob*, *Takumi Shotoku*
382
+ *Gustavo Gutierrez*
486
383
 
487
- * Controller level `force_ssl` has been deprecated in favor of
488
- `config.force_ssl`.
384
+ * Calling `ActionController::Parameters#transform_keys`/`!` without a block now returns
385
+ an enumerator for the parameters instead of the underlying hash.
489
386
 
490
- *Derek Prior*
387
+ *Eugene Kenny*
491
388
 
492
- * Rails 6 requires Ruby 2.5.0 or newer.
389
+ * Fix strong parameters blocks all attributes even when only some keys are invalid (non-numerical).
390
+ It should only block invalid key's values instead.
493
391
 
494
- *Jeremy Daer*, *Kasper Timm Hansen*
392
+ *Stan Lo*
495
393
 
496
394
 
497
- Please check [5-2-stable](https://github.com/rails/rails/blob/5-2-stable/actionpack/CHANGELOG.md) for previous changes.
395
+ Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionpack/CHANGELOG.md) for previous changes.