actionpack 6.0.4.7 → 6.1.0.rc1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of actionpack might be problematic. Click here for more details.

Files changed (113) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +235 -331
  3. data/MIT-LICENSE +1 -1
  4. data/README.rdoc +1 -1
  5. data/lib/abstract_controller/base.rb +35 -2
  6. data/lib/abstract_controller/callbacks.rb +2 -2
  7. data/lib/abstract_controller/helpers.rb +105 -90
  8. data/lib/abstract_controller/rendering.rb +9 -9
  9. data/lib/abstract_controller/translation.rb +8 -2
  10. data/lib/abstract_controller.rb +1 -0
  11. data/lib/action_controller/api.rb +2 -2
  12. data/lib/action_controller/base.rb +4 -2
  13. data/lib/action_controller/caching.rb +0 -1
  14. data/lib/action_controller/log_subscriber.rb +3 -3
  15. data/lib/action_controller/metal/conditional_get.rb +10 -2
  16. data/lib/action_controller/metal/content_security_policy.rb +1 -1
  17. data/lib/action_controller/metal/data_streaming.rb +1 -1
  18. data/lib/action_controller/metal/etag_with_template_digest.rb +2 -4
  19. data/lib/action_controller/metal/exceptions.rb +33 -0
  20. data/lib/action_controller/metal/feature_policy.rb +46 -0
  21. data/lib/action_controller/metal/head.rb +7 -4
  22. data/lib/action_controller/metal/helpers.rb +11 -1
  23. data/lib/action_controller/metal/http_authentication.rb +5 -3
  24. data/lib/action_controller/metal/implicit_render.rb +1 -1
  25. data/lib/action_controller/metal/instrumentation.rb +11 -9
  26. data/lib/action_controller/metal/live.rb +1 -1
  27. data/lib/action_controller/metal/logging.rb +20 -0
  28. data/lib/action_controller/metal/mime_responds.rb +6 -2
  29. data/lib/action_controller/metal/parameter_encoding.rb +35 -4
  30. data/lib/action_controller/metal/params_wrapper.rb +16 -11
  31. data/lib/action_controller/metal/redirecting.rb +1 -1
  32. data/lib/action_controller/metal/rendering.rb +6 -0
  33. data/lib/action_controller/metal/request_forgery_protection.rb +1 -1
  34. data/lib/action_controller/metal/rescue.rb +1 -1
  35. data/lib/action_controller/metal/strong_parameters.rb +103 -15
  36. data/lib/action_controller/metal.rb +2 -2
  37. data/lib/action_controller/renderer.rb +24 -13
  38. data/lib/action_controller/test_case.rb +62 -56
  39. data/lib/action_controller.rb +2 -3
  40. data/lib/action_dispatch/http/cache.rb +12 -10
  41. data/lib/action_dispatch/http/content_security_policy.rb +5 -1
  42. data/lib/action_dispatch/http/feature_policy.rb +168 -0
  43. data/lib/action_dispatch/http/filter_parameters.rb +1 -1
  44. data/lib/action_dispatch/http/filter_redirect.rb +1 -1
  45. data/lib/action_dispatch/http/headers.rb +3 -2
  46. data/lib/action_dispatch/http/mime_negotiation.rb +14 -8
  47. data/lib/action_dispatch/http/mime_type.rb +29 -16
  48. data/lib/action_dispatch/http/parameters.rb +1 -19
  49. data/lib/action_dispatch/http/request.rb +24 -8
  50. data/lib/action_dispatch/http/response.rb +17 -16
  51. data/lib/action_dispatch/http/url.rb +3 -2
  52. data/lib/action_dispatch/journey/formatter.rb +53 -28
  53. data/lib/action_dispatch/journey/gtg/builder.rb +22 -36
  54. data/lib/action_dispatch/journey/gtg/simulator.rb +8 -7
  55. data/lib/action_dispatch/journey/gtg/transition_table.rb +6 -4
  56. data/lib/action_dispatch/journey/nfa/dot.rb +0 -11
  57. data/lib/action_dispatch/journey/nodes/node.rb +4 -3
  58. data/lib/action_dispatch/journey/parser.rb +13 -13
  59. data/lib/action_dispatch/journey/parser.y +1 -1
  60. data/lib/action_dispatch/journey/path/pattern.rb +13 -18
  61. data/lib/action_dispatch/journey/route.rb +7 -18
  62. data/lib/action_dispatch/journey/router/utils.rb +6 -4
  63. data/lib/action_dispatch/journey/router.rb +26 -30
  64. data/lib/action_dispatch/journey.rb +0 -2
  65. data/lib/action_dispatch/middleware/actionable_exceptions.rb +1 -1
  66. data/lib/action_dispatch/middleware/cookies.rb +67 -32
  67. data/lib/action_dispatch/middleware/debug_exceptions.rb +8 -15
  68. data/lib/action_dispatch/middleware/debug_view.rb +1 -1
  69. data/lib/action_dispatch/middleware/exception_wrapper.rb +28 -16
  70. data/lib/action_dispatch/middleware/executor.rb +1 -1
  71. data/lib/action_dispatch/middleware/host_authorization.rb +35 -35
  72. data/lib/action_dispatch/middleware/remote_ip.rb +5 -4
  73. data/lib/action_dispatch/middleware/request_id.rb +4 -5
  74. data/lib/action_dispatch/middleware/session/abstract_store.rb +2 -2
  75. data/lib/action_dispatch/middleware/session/cookie_store.rb +2 -2
  76. data/lib/action_dispatch/middleware/ssl.rb +9 -6
  77. data/lib/action_dispatch/middleware/stack.rb +18 -0
  78. data/lib/action_dispatch/middleware/static.rb +154 -93
  79. data/lib/action_dispatch/middleware/templates/rescues/_message_and_suggestions.html.erb +18 -0
  80. data/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb +2 -5
  81. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.html.erb +2 -2
  82. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.text.erb +2 -3
  83. data/lib/action_dispatch/middleware/templates/rescues/layout.erb +88 -8
  84. data/lib/action_dispatch/middleware/templates/rescues/unknown_action.html.erb +1 -1
  85. data/lib/action_dispatch/middleware/templates/routes/_table.html.erb +12 -1
  86. data/lib/action_dispatch/railtie.rb +3 -2
  87. data/lib/action_dispatch/request/session.rb +2 -8
  88. data/lib/action_dispatch/request/utils.rb +26 -2
  89. data/lib/action_dispatch/routing/inspector.rb +8 -7
  90. data/lib/action_dispatch/routing/mapper.rb +102 -71
  91. data/lib/action_dispatch/routing/polymorphic_routes.rb +16 -19
  92. data/lib/action_dispatch/routing/redirection.rb +3 -3
  93. data/lib/action_dispatch/routing/route_set.rb +49 -41
  94. data/lib/action_dispatch/system_test_case.rb +29 -24
  95. data/lib/action_dispatch/system_testing/browser.rb +33 -27
  96. data/lib/action_dispatch/system_testing/driver.rb +6 -7
  97. data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb +47 -6
  98. data/lib/action_dispatch/system_testing/test_helpers/setup_and_teardown.rb +4 -7
  99. data/lib/action_dispatch/testing/assertions/response.rb +2 -4
  100. data/lib/action_dispatch/testing/assertions/routing.rb +5 -5
  101. data/lib/action_dispatch/testing/assertions.rb +1 -1
  102. data/lib/action_dispatch/testing/integration.rb +38 -27
  103. data/lib/action_dispatch/testing/test_process.rb +29 -4
  104. data/lib/action_dispatch/testing/test_request.rb +3 -3
  105. data/lib/action_dispatch.rb +3 -2
  106. data/lib/action_pack/gem_version.rb +3 -3
  107. data/lib/action_pack.rb +1 -1
  108. metadata +23 -24
  109. data/lib/action_controller/metal/force_ssl.rb +0 -58
  110. data/lib/action_dispatch/http/parameter_filter.rb +0 -12
  111. data/lib/action_dispatch/journey/nfa/builder.rb +0 -78
  112. data/lib/action_dispatch/journey/nfa/simulator.rb +0 -47
  113. data/lib/action_dispatch/journey/nfa/transition_table.rb +0 -119
data/CHANGELOG.md CHANGED
@@ -1,150 +1,166 @@
1
- ## Rails 6.0.4.7 (March 08, 2022) ##
1
+ ## Rails 6.1.0.rc1 (November 02, 2020) ##
2
2
 
3
- * No changes.
3
+ * Allow `ActionDispatch::HostAuthorization` to exclude specific requests.
4
4
 
5
+ Host Authorization checks can be skipped for specific requests. This allows for health check requests to be permitted for requests with missing or non-matching host headers.
5
6
 
6
- ## Rails 6.0.4.6 (February 11, 2022) ##
7
+ *Chris Bisnett*
7
8
 
8
- * No changes.
9
+ * Add `config.action_dispatch.request_id_header` to allow changing the name of
10
+ the unique X-Request-Id header
9
11
 
12
+ *Arlston Fernandes*
10
13
 
11
- ## Rails 6.0.4.5 (February 11, 2022) ##
12
-
13
- * Under certain circumstances, the middleware isn't informed that the
14
- response body has been fully closed which result in request state not
15
- being fully reset before the next request
16
-
17
- [CVE-2022-23633]
18
-
19
-
20
- ## Rails 6.0.4.4 (December 15, 2021) ##
21
-
22
- * Fix issue with host protection not allowing host with port in development.
14
+ * Deprecate `config.action_dispatch.return_only_media_type_on_content_type`.
23
15
 
16
+ *Rafael Mendonça França*
24
17
 
25
- ## Rails 6.0.4.3 (December 14, 2021) ##
18
+ * Change `ActionDispatch::Response#content_type` to return the full Content-Type header.
26
19
 
27
- * Fix issue with host protection not allowing localhost in development.
20
+ *Rafael Mendonça França*
28
21
 
22
+ * Remove deprecated `ActionDispatch::Http::ParameterFilter`.
29
23
 
30
- ## Rails 6.0.4.2 (December 14, 2021) ##
24
+ *Rafael Mendonça França*
31
25
 
32
- * Fix X_FORWARDED_HOST protection. [CVE-2021-44528]
26
+ * Added support for exclusive no-store Cache-Control header.
33
27
 
34
- ## Rails 6.1.4.1 (August 19, 2021) ##
28
+ If `no-store` is set on Cache-Control header it is exclusive (all other cache directives are dropped).
35
29
 
36
- * [CVE-2021-22942] Fix possible open redirect in Host Authorization middleware.
30
+ *Chris Kruger*
37
31
 
38
- Specially crafted "X-Forwarded-Host" headers in combination with certain
39
- "allowed host" formats can cause the Host Authorization middleware in Action
40
- Pack to redirect users to a malicious website.
32
+ * Catch invalid UTF-8 parameters for POST requests and respond with BadRequest.
41
33
 
42
- ## Rails 6.0.4 (June 15, 2021) ##
34
+ Additionally, perform `#set_binary_encoding` in `ActionDispatch::Http::Request#GET` and
35
+ `ActionDispatch::Http::Request#POST` prior to validating encoding.
43
36
 
44
- * Accept base64_urlsafe CSRF tokens to make forward compatible.
37
+ *Adrianna Chang*
45
38
 
46
- Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
47
- them difficult to deal with. For example, the common practice of sending
48
- the CSRF token to a browser in a client-readable cookie does not work properly
49
- out of the box: the value has to be url-encoded and decoded to survive transport.
39
+ * Allow `assert_recognizes` routing assertions to work on mounted root routes.
50
40
 
51
- In Rails 6.1, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently
52
- safe to transport. Validation accepts both urlsafe tokens, and strict-encoded
53
- tokens for backwards compatibility.
41
+ *Gannon McGibbon*
54
42
 
55
- In Rails 5.2.5, the CSRF token format is accidentally changed to urlsafe-encoded.
56
- If you upgrade apps from 5.2.5, set the config `urlsafe_csrf_tokens = true`.
43
+ * Change default redirection status code for non-GET/HEAD requests to 308 Permanent Redirect for `ActionDispatch::SSL`.
57
44
 
58
- ```ruby
59
- Rails.application.config.action_controller.urlsafe_csrf_tokens = true
60
- ```
45
+ *Alan Tan*, *Oz Ben-David*
61
46
 
62
- *Scott Blum*, *Étienne Barrié*
47
+ * Fix `follow_redirect!` to follow redirection with same HTTP verb when following
48
+ a 308 redirection.
63
49
 
64
- * Signed and encrypted cookies can now store `false` as their value when
65
- `action_dispatch.use_cookies_with_metadata` is enabled.
50
+ *Alan Tan*
66
51
 
67
- *Rolandas Barysas*
52
+ * When multiple domains are specified for a cookie, a domain will now be
53
+ chosen only if it is equal to or is a superdomain of the request host.
68
54
 
55
+ *Jonathan Hefner*
69
56
 
70
- ## Rails 6.0.3.7 (May 05, 2021) ##
57
+ * `ActionDispatch::Static` handles precompiled Brotli (.br) files.
71
58
 
72
- * Prevent catastrophic backtracking during mime parsing
73
- CVE-2021-22902
59
+ Adds to existing support for precompiled gzip (.gz) files.
60
+ Brotli files are preferred due to much better compression.
74
61
 
75
- * Prevent regex DoS in HTTP token authentication
76
- CVE-2021-22904
62
+ When the browser requests /some.js with `Accept-Encoding: br`,
63
+ we check for public/some.js.br and serve that file, if present, with
64
+ `Content-Encoding: br` and `Vary: Accept-Encoding` headers.
77
65
 
78
- * Prevent string polymorphic route arguments.
66
+ *Ryan Edward Hall*, *Jeremy Daer*
79
67
 
80
- `url_for` supports building polymorphic URLs via an array
81
- of arguments (usually symbols and records). If a developer passes a
82
- user input array, strings can result in unwanted route helper calls.
68
+ * Add raise_on_missing_translations support for controllers.
83
69
 
84
- CVE-2021-22885
70
+ This configuration determines whether an error should be raised for missing translations.
71
+ It can be enabled through `config.i18n.raise_on_missing_translations`. Note that described
72
+ configuration also affects raising error for missing translations in views.
85
73
 
86
- *Gannon McGibbon*
74
+ *fatkodima*
87
75
 
88
- ## Rails 6.0.3.6 (March 26, 2021) ##
76
+ * Added `compact` and `compact!` to `ActionController::Parameters`.
89
77
 
90
- * No changes.
78
+ *Eugene Kenny*
91
79
 
80
+ * Calling `each_pair` or `each_value` on an `ActionController::Parameters`
81
+ without passing a block now returns an enumerator.
92
82
 
93
- ## Rails 6.0.3.5 (February 10, 2021) ##
83
+ *Eugene Kenny*
94
84
 
95
- * Prevent open redirect when allowed host starts with a dot
85
+ * `fixture_file_upload` now uses path relative to `file_fixture_path`
96
86
 
97
- [CVE-2021-22881]
87
+ Previously the path had to be relative to `fixture_path`.
88
+ You can change your existing code as follow:
98
89
 
99
- Thanks to @tktech (https://hackerone.com/tktech) for reporting this
100
- issue and the patch!
90
+ ```ruby
91
+ # Before
92
+ fixture_file_upload('files/dog.png')
101
93
 
102
- *Aaron Patterson*
94
+ # After
95
+ fixture_file_upload('dog.png')
96
+ ```
103
97
 
98
+ *Edouard Chin*
104
99
 
105
- ## Rails 6.0.3.4 (October 07, 2020) ##
100
+ * Remove deprecated `force_ssl` at the controller level.
106
101
 
107
- * [CVE-2020-8264] Prevent XSS in Actionable Exceptions
102
+ *Rafael Mendonça França*
108
103
 
104
+ * The +helper+ class method for controllers loads helper modules specified as
105
+ strings/symbols with `String#constantize` instead of `require_dependency`.
109
106
 
110
- ## Rails 6.0.3.3 (September 09, 2020) ##
107
+ Remember that support for strings/symbols is only a convenient API. You can
108
+ always pass a module object:
111
109
 
112
- * No changes.
110
+ ```ruby
111
+ helper UtilsHelper
112
+ ```
113
113
 
114
+ which is recommended because it is simple and direct. When a string/symbol
115
+ is received, `helper` just manipulates and inflects the argument to obtain
116
+ that same module object.
114
117
 
115
- ## Rails 6.0.3.2 (June 17, 2020) ##
118
+ *Xavier Noria*, *Jean Boussier*
116
119
 
117
- * [CVE-2020-8185] Only allow ActionableErrors if show_detailed_exceptions is enabled
120
+ * Correctly identify the entire localhost IPv4 range as trusted proxy.
118
121
 
119
- ## Rails 6.0.3.1 (May 18, 2020) ##
122
+ *Nick Soracco*
120
123
 
121
- * [CVE-2020-8166] HMAC raw CSRF token before masking it, so it cannot be used to reconstruct a per-form token
124
+ * `url_for` will now use "https://" as the default protocol when
125
+ `Rails.application.config.force_ssl` is set to true.
122
126
 
123
- * [CVE-2020-8164] Return self when calling #each, #each_pair, and #each_value instead of the raw @parameters hash
127
+ *Jonathan Hefner*
124
128
 
129
+ * Accept and default to base64_urlsafe CSRF tokens.
125
130
 
126
- ## Rails 6.0.3 (May 06, 2020) ##
131
+ Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
132
+ them difficult to deal with. For example, the common practice of sending
133
+ the CSRF token to a browser in a client-readable cookie does not work properly
134
+ out of the box: the value has to be url-encoded and decoded to survive transport.
127
135
 
128
- * Include child session assertion count in ActionDispatch::IntegrationTest
136
+ Now, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently safe
137
+ to transport. Validation accepts both urlsafe tokens, and strict-encoded tokens
138
+ for backwards compatibility.
129
139
 
130
- `IntegrationTest#open_session` uses `dup` to create the new session, which
131
- meant it had its own copy of `@assertions`. This prevented the assertions
132
- from being correctly counted and reported.
140
+ *Scott Blum*
133
141
 
134
- Child sessions now have their `attr_accessor` overriden to delegate to the
135
- root session.
142
+ * Support rolling deploys for cookie serialization/encryption changes.
136
143
 
137
- Fixes #32142
144
+ In a distributed configuration like rolling update, users may observe
145
+ both old and new instances during deployment. Users may be served by a
146
+ new instance and then by an old instance.
138
147
 
139
- *Sam Bostock*
148
+ That means when the server changes `cookies_serializer` from `:marshal`
149
+ to `:hybrid` or the server changes `use_authenticated_cookie_encryption`
150
+ from `false` to `true`, users may lose their sessions if they access the
151
+ server during deployment.
140
152
 
153
+ We added fallbacks to downgrade the cookie format when necessary during
154
+ deployment, ensuring compatibility on both old and new instances.
141
155
 
142
- ## Rails 6.0.2.2 (March 19, 2020) ##
156
+ *Masaki Hara*
143
157
 
144
- * No changes.
158
+ * `ActionDispatch::Request.remote_ip` has ip address even when all sites are trusted.
145
159
 
160
+ Before, if all `X-Forwarded-For` sites were trusted, the `remote_ip` would default to `127.0.0.1`.
161
+ Now, the furthest proxy site is used. e.g.: It now gives an ip address when using curl from the load balancer.
146
162
 
147
- ## Rails 6.0.2.1 (December 18, 2019) ##
163
+ *Keenan Brock*
148
164
 
149
165
  * Fix possible information leak / session hijacking vulnerability.
150
166
 
@@ -153,339 +169,227 @@
153
169
 
154
170
  CVE-2019-16782.
155
171
 
172
+ * Include child session assertion count in ActionDispatch::IntegrationTest.
156
173
 
157
- ## Rails 6.0.2 (December 13, 2019) ##
174
+ `IntegrationTest#open_session` uses `dup` to create the new session, which
175
+ meant it had its own copy of `@assertions`. This prevented the assertions
176
+ from being correctly counted and reported.
158
177
 
159
- * Allow using mountable engine route helpers in System Tests.
178
+ Child sessions now have their `attr_accessor` overridden to delegate to the
179
+ root session.
160
180
 
161
- *Chalo Fernandez*
181
+ Fixes #32142.
162
182
 
183
+ *Sam Bostock*
163
184
 
164
- ## Rails 6.0.1 (November 5, 2019) ##
185
+ * Add SameSite protection to every written cookie.
165
186
 
166
- * `ActionDispatch::SystemTestCase` now inherits from `ActiveSupport::TestCase`
167
- rather than `ActionDispatch::IntegrationTest`. This permits running jobs in
168
- system tests.
187
+ Enabling `SameSite` cookie protection is an addition to CSRF protection,
188
+ where cookies won't be sent by browsers in cross-site POST requests when set to `:lax`.
169
189
 
170
- *George Claghorn*, *Edouard Chin*
190
+ `:strict` disables cookies being sent in cross-site GET or POST requests.
171
191
 
172
- * Registered MIME types may contain extra flags:
192
+ Passing `:none` disables this protection and is the same as previous versions albeit a `; SameSite=None` is appended to the cookie.
173
193
 
174
- ```ruby
175
- Mime::Type.register "text/html; fragment", :html_fragment
176
- ```
194
+ See upgrade instructions in config/initializers/new_framework_defaults_6_1.rb.
177
195
 
178
- *Aaron Patterson*
196
+ More info [here](https://tools.ietf.org/html/draft-west-first-party-cookies-07)
179
197
 
198
+ _NB: Technically already possible as Rack supports SameSite protection, this is to ensure it's applied to all cookies_
180
199
 
181
- ## Rails 6.0.0 (August 16, 2019) ##
200
+ *Cédric Fabianski*
182
201
 
183
- * No changes.
202
+ * Bring back the feature that allows loading external route files from the router.
184
203
 
204
+ This feature existed back in 2012 but got reverted with the incentive that
205
+ https://github.com/rails/routing_concerns was a better approach. Turned out
206
+ that this wasn't fully the case and loading external route files from the router
207
+ can be helpful for applications with a really large set of routes.
208
+ Without this feature, application needs to implement routes reloading
209
+ themselves and it's not straightforward.
185
210
 
186
- ## Rails 6.0.0.rc2 (July 22, 2019) ##
211
+ ```ruby
212
+ # config/routes.rb
187
213
 
188
- * Add the ability to set the CSP nonce only to the specified directives.
214
+ Rails.application.routes.draw do
215
+ draw(:admin)
216
+ end
189
217
 
190
- Fixes #35137.
218
+ # config/routes/admin.rb
191
219
 
192
- *Yuji Yaginuma*
220
+ get :foo, to: 'foo#bar'
221
+ ```
193
222
 
194
- * Keep part when scope option has value.
223
+ *Yehuda Katz*, *Edouard Chin*
195
224
 
196
- When a route was defined within an optional scope, if that route didn't
197
- take parameters the scope was lost when using path helpers. This commit
198
- ensures scope is kept both when the route takes parameters or when it
199
- doesn't.
225
+ * Fix system test driver option initialization for non-headless browsers.
200
226
 
201
- Fixes #33219
227
+ *glaszig*
202
228
 
203
- *Alberto Almagro*
229
+ * `redirect_to.action_controller` notifications now include the `ActionDispatch::Request` in
230
+ their payloads as `:request`.
204
231
 
205
- * Change `ActionDispatch::Response#content_type` to return Content-Type header as it is.
232
+ *Austin Story*
206
233
 
207
- Previously, `ActionDispatch::Response#content_type` returned value does NOT
208
- contain charset part. This behavior changed to returned Content-Type header
209
- containing charset part as it is.
234
+ * `respond_to#any` no longer returns a response's Content-Type based on the
235
+ request format but based on the block given.
210
236
 
211
- If you want just MIME type, please use `ActionDispatch::Response#media_type`
212
- instead.
237
+ Example:
213
238
 
214
- Enable `action_dispatch.return_only_media_type_on_content_type` to use this change.
215
- If not enabled, `ActionDispatch::Response#content_type` returns the same
216
- value as before version, but its behavior is deprecate.
239
+ ```ruby
240
+ def my_action
241
+ respond_to do |format|
242
+ format.any { render(json: { foo: 'bar' }) }
243
+ end
244
+ end
217
245
 
218
- *Yuji Yaginuma*
246
+ get('my_action.csv')
247
+ ```
219
248
 
220
- * Calling `ActionController::Parameters#transform_keys/!` without a block now returns
221
- an enumerator for the parameters instead of the underlying hash.
249
+ The previous behaviour was to respond with a `text/csv` Content-Type which
250
+ is inaccurate since a JSON response is being rendered.
222
251
 
223
- *Eugene Kenny*
252
+ Now it correctly returns a `application/json` Content-Type.
224
253
 
225
- * Fix a bug where DebugExceptions throws an error when malformed query parameters are provided
254
+ *Edouard Chin*
226
255
 
227
- *Yuki Nishijima*, *Stan Lo*
256
+ * Replaces (back)slashes in failure screenshot image paths with dashes.
228
257
 
258
+ If a failed test case contained a slash or a backslash, a screenshot would be created in a
259
+ nested directory, causing issues with `tmp:clear`.
229
260
 
230
- ## Rails 6.0.0.rc1 (April 24, 2019) ##
261
+ *Damir Zekic*
231
262
 
232
- * Make system tests take a failed screenshot in a `before_teardown` hook
233
- rather than an `after_teardown` hook.
263
+ * Add `params.member?` to mimic Hash behavior.
234
264
 
235
- This helps minimize the time gap between when an assertion fails and when
236
- the screenshot is taken (reducing the time in which the page could have
237
- been dynamically updated after the assertion failed).
265
+ *Younes Serraj*
238
266
 
239
- *Richard Macklin*
267
+ * `process_action.action_controller` notifications now include the following in their payloads:
240
268
 
241
- * Introduce `ActionDispatch::ActionableExceptions`.
269
+ * `:request` - the `ActionDispatch::Request`
270
+ * `:response` - the `ActionDispatch::Response`
242
271
 
243
- The `ActionDispatch::ActionableExceptions` middleware dispatches actions
244
- from `ActiveSupport::ActionableError` descendants.
272
+ *George Claghorn*
245
273
 
246
- Actionable errors let's you dispatch actions from Rails' error pages.
274
+ * Updated `ActionDispatch::Request.remote_ip` setter to clear set the instance
275
+ `remote_ip` to `nil` before setting the header that the value is derived
276
+ from.
247
277
 
248
- *Vipul A M*, *Yao Jie*, *Genadi Samokovarov*
278
+ Fixes #37383.
249
279
 
250
- * Raise an `ArgumentError` if a resource custom param contains a colon (`:`).
280
+ *Norm Provost*
251
281
 
252
- After this change it's not possible anymore to configure routes like this:
282
+ * `ActionController::Base.log_at` allows setting a different log level per request.
253
283
 
254
- ```
255
- routes.draw do
256
- resources :users, param: 'name/:sneaky'
284
+ ```ruby
285
+ # Use the debug level if a particular cookie is set.
286
+ class ApplicationController < ActionController::Base
287
+ log_at :debug, if: -> { cookies[:debug] }
257
288
  end
258
289
  ```
259
290
 
260
- Fixes #30467.
291
+ *George Claghorn*
261
292
 
262
- *Josua Schmid*
293
+ * Allow system test screen shots to be taken more than once in
294
+ a test by prefixing the file name with an incrementing counter.
263
295
 
296
+ Add an environment variable `RAILS_SYSTEM_TESTING_SCREENSHOT_HTML` to
297
+ enable saving of HTML during a screenshot in addition to the image.
298
+ This uses the same image name, with the extension replaced with `.html`
264
299
 
265
- ## Rails 6.0.0.beta3 (March 11, 2019) ##
300
+ *Tom Fakes*
266
301
 
267
- * No changes.
302
+ * Add `Vary: Accept` header when using `Accept` header for response.
268
303
 
304
+ For some requests like `/users/1`, Rails uses requests' `Accept`
305
+ header to determine what to return. And if we don't add `Vary`
306
+ in the response header, browsers might accidentally cache different
307
+ types of content, which would cause issues: e.g. javascript got displayed
308
+ instead of html content. This PR fixes these issues by adding `Vary: Accept`
309
+ in these types of requests. For more detailed problem description, please read:
269
310
 
270
- ## Rails 6.0.0.beta2 (February 25, 2019) ##
311
+ https://github.com/rails/rails/pull/36213
271
312
 
272
- * Make debug exceptions works in an environment where ActiveStorage is not loaded.
313
+ Fixes #25842.
273
314
 
274
- *Tomoyuki Kurosawa*
315
+ *Stan Lo*
275
316
 
276
- * `ActionDispatch::SystemTestCase.driven_by` can now be called with a block
277
- to define specific browser capabilities.
317
+ * Fix IntegrationTest `follow_redirect!` to follow redirection using the same HTTP verb when following
318
+ a 307 redirection.
278
319
 
279
320
  *Edouard Chin*
280
321
 
322
+ * System tests require Capybara 3.26 or newer.
281
323
 
282
- ## Rails 6.0.0.beta1 (January 18, 2019) ##
324
+ *George Claghorn*
283
325
 
284
- * Remove deprecated `fragment_cache_key` helper in favor of `combined_fragment_cache_key`.
326
+ * Reduced log noise handling ActionController::RoutingErrors.
285
327
 
286
- *Rafael Mendonça França*
287
-
288
- * Remove deprecated methods in `ActionDispatch::TestResponse`.
289
-
290
- `#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
291
- `#successful?`, `not_found?` and `server_error?`.
292
-
293
- *Rafael Mendonça França*
294
-
295
- * Introduce `ActionDispatch::HostAuthorization`.
328
+ *Alberto Fernández-Capel*
296
329
 
297
- This is a new middleware that guards against DNS rebinding attacks by
298
- explicitly permitting the hosts a request can be made to.
330
+ * Add DSL for configuring HTTP Feature Policy.
299
331
 
300
- Each host is checked with the case operator (`#===`) to support `Regexp`,
301
- `Proc`, `IPAddr` and custom objects as host allowances.
332
+ This new DSL provides a way to configure an HTTP Feature Policy at a
333
+ global or per-controller level. Full details of HTTP Feature Policy
334
+ specification and guidelines can be found at MDN:
302
335
 
303
- *Genadi Samokovarov*
336
+ https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy
304
337
 
305
- * Allow using `parsed_body` in `ActionController::TestCase`.
338
+ Example global policy:
306
339
 
307
- In addition to `ActionDispatch::IntegrationTest`, allow using
308
- `parsed_body` in `ActionController::TestCase`:
309
-
310
- ```
311
- class SomeControllerTest < ActionController::TestCase
312
- def test_some_action
313
- post :action, body: { foo: 'bar' }
314
- assert_equal({ "foo" => "bar" }, response.parsed_body)
315
- end
340
+ ```ruby
341
+ Rails.application.config.feature_policy do |f|
342
+ f.camera :none
343
+ f.gyroscope :none
344
+ f.microphone :none
345
+ f.usb :none
346
+ f.fullscreen :self
347
+ f.payment :self, "https://secure.example.com"
316
348
  end
317
349
  ```
318
350
 
319
- Fixes #34676.
320
-
321
- *Tobias Bühlmann*
322
-
323
- * Raise an error on root route naming conflicts.
324
-
325
- Raises an `ArgumentError` when multiple root routes are defined in the
326
- same context instead of assigning nil names to subsequent roots.
351
+ Example controller level policy:
327
352
 
328
- *Gannon McGibbon*
329
-
330
- * Allow rescue from parameter parse errors:
331
-
332
- ```
333
- rescue_from ActionDispatch::Http::Parameters::ParseError do
334
- head :unauthorized
353
+ ```ruby
354
+ class PagesController < ApplicationController
355
+ feature_policy do |p|
356
+ p.geolocation "https://example.com"
357
+ end
335
358
  end
336
359
  ```
337
360
 
338
- *Gannon McGibbon*, *Josh Cheek*
339
-
340
- * Reset Capybara sessions if failed system test screenshot raising an exception.
341
-
342
- Reset Capybara sessions if `take_failed_screenshot` raise exception
343
- in system test `after_teardown`.
344
-
345
- *Maxim Perepelitsa*
346
-
347
- * Use request object for context if there's no controller
348
-
349
- There is no controller instance when using a redirect route or a
350
- mounted rack application so pass the request object as the context
351
- when resolving dynamic CSP sources in this scenario.
352
-
353
- Fixes #34200.
354
-
355
- *Andrew White*
356
-
357
- * Apply mapping to symbols returned from dynamic CSP sources
358
-
359
- Previously if a dynamic source returned a symbol such as :self it
360
- would be converted to a string implicitly, e.g:
361
-
362
- policy.default_src -> { :self }
363
-
364
- would generate the header:
365
-
366
- Content-Security-Policy: default-src self
367
-
368
- and now it generates:
369
-
370
- Content-Security-Policy: default-src 'self'
371
-
372
- *Andrew White*
373
-
374
- * Add `ActionController::Parameters#each_value`.
375
-
376
- *Lukáš Zapletal*
377
-
378
- * Deprecate `ActionDispatch::Http::ParameterFilter` in favor of `ActiveSupport::ParameterFilter`.
379
-
380
- *Yoshiyuki Kinjo*
381
-
382
- * Encode Content-Disposition filenames on `send_data` and `send_file`.
383
- Previously, `send_data 'data', filename: "\u{3042}.txt"` sends
384
- `"filename=\"\u{3042}.txt\""` as Content-Disposition and it can be
385
- garbled.
386
- Now it follows [RFC 2231](https://tools.ietf.org/html/rfc2231) and
387
- [RFC 5987](https://tools.ietf.org/html/rfc5987) and sends
388
- `"filename=\"%3F.txt\"; filename*=UTF-8''%E3%81%82.txt"`.
389
- Most browsers can find filename correctly and old browsers fallback to ASCII
390
- converted name.
391
-
392
- *Fumiaki Matsushima*
393
-
394
- * Expose `ActionController::Parameters#each_key` which allows iterating over
395
- keys without allocating an array.
396
-
397
- *Richard Schneeman*
398
-
399
- * Purpose metadata for signed/encrypted cookies.
361
+ *Jacob Bednarz*
400
362
 
401
- Rails can now thwart attacks that attempt to copy signed/encrypted value
402
- of a cookie and use it as the value of another cookie.
403
-
404
- It does so by stashing the cookie-name in the purpose field which is
405
- then signed/encrypted along with the cookie value. Then, on a server-side
406
- read, we verify the cookie-names and discard any attacked cookies.
407
-
408
- Enable `action_dispatch.use_cookies_with_metadata` to use this feature, which
409
- writes cookies with the new purpose and expiry metadata embedded.
410
-
411
- *Assain Jaleel*
412
-
413
- * Raises `ActionController::RespondToMismatchError` with conflicting `respond_to` invocations.
414
-
415
- `respond_to` can match multiple types and lead to undefined behavior when
416
- multiple invocations are made and the types do not match:
417
-
418
- respond_to do |outer_type|
419
- outer_type.js do
420
- respond_to do |inner_type|
421
- inner_type.html { render body: "HTML" }
422
- end
423
- end
424
- end
425
-
426
- *Patrick Toomey*
427
-
428
- * `ActionDispatch::Http::UploadedFile` now delegates `to_path` to its tempfile.
429
-
430
- This allows uploaded file objects to be passed directly to `File.read`
431
- without raising a `TypeError`:
432
-
433
- uploaded_file = ActionDispatch::Http::UploadedFile.new(tempfile: tmp_file)
434
- File.read(uploaded_file)
435
-
436
- *Aaron Kromer*
437
-
438
- * Pass along arguments to underlying `get` method in `follow_redirect!`
439
-
440
- Now all arguments passed to `follow_redirect!` are passed to the underlying
441
- `get` method. This for example allows to set custom headers for the
442
- redirection request to the server.
443
-
444
- follow_redirect!(params: { foo: :bar })
445
-
446
- *Remo Fritzsche*
447
-
448
- * Introduce a new error page to when the implicit render page is accessed in the browser.
449
-
450
- Now instead of showing an error page that with exception and backtraces we now show only
451
- one informative page.
452
-
453
- *Vinicius Stock*
454
-
455
- * Introduce `ActionDispatch::DebugExceptions.register_interceptor`.
456
-
457
- Exception aware plugin authors can use the newly introduced
458
- `.register_interceptor` method to get the processed exception, instead of
459
- monkey patching DebugExceptions.
460
-
461
- ActionDispatch::DebugExceptions.register_interceptor do |request, exception|
462
- HypoteticalPlugin.capture_exception(request, exception)
463
- end
363
+ * Add the ability to set the CSP nonce only to the specified directives.
464
364
 
465
- *Genadi Samokovarov*
365
+ Fixes #35137.
466
366
 
467
- * Output only one Content-Security-Policy nonce header value per request.
367
+ *Yuji Yaginuma*
468
368
 
469
- Fixes #32597.
369
+ * Keep part when scope option has value.
470
370
 
471
- *Andrey Novikov*, *Andrew White*
371
+ When a route was defined within an optional scope, if that route didn't
372
+ take parameters the scope was lost when using path helpers. This commit
373
+ ensures scope is kept both when the route takes parameters or when it
374
+ doesn't.
472
375
 
473
- * Move default headers configuration into their own module that can be included in controllers.
376
+ Fixes #33219.
474
377
 
475
- *Kevin Deisz*
378
+ *Alberto Almagro*
476
379
 
477
- * Add method `dig` to `session`.
380
+ * Added `deep_transform_keys` and `deep_transform_keys!` methods to ActionController::Parameters.
478
381
 
479
- *claudiob*, *Takumi Shotoku*
382
+ *Gustavo Gutierrez*
480
383
 
481
- * Controller level `force_ssl` has been deprecated in favor of
482
- `config.force_ssl`.
384
+ * Calling `ActionController::Parameters#transform_keys`/`!` without a block now returns
385
+ an enumerator for the parameters instead of the underlying hash.
483
386
 
484
- *Derek Prior*
387
+ *Eugene Kenny*
485
388
 
486
- * Rails 6 requires Ruby 2.5.0 or newer.
389
+ * Fix strong parameters blocks all attributes even when only some keys are invalid (non-numerical).
390
+ It should only block invalid key's values instead.
487
391
 
488
- *Jeremy Daer*, *Kasper Timm Hansen*
392
+ *Stan Lo*
489
393
 
490
394
 
491
- Please check [5-2-stable](https://github.com/rails/rails/blob/5-2-stable/actionpack/CHANGELOG.md) for previous changes.
395
+ Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionpack/CHANGELOG.md) for previous changes.