actionpack 6.0.4.4 → 6.1.0.rc1
Sign up to get free protection for your applications and to get access to all the features.
Potentially problematic release.
This version of actionpack might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/CHANGELOG.md +240 -317
- data/MIT-LICENSE +1 -1
- data/README.rdoc +1 -1
- data/lib/abstract_controller/base.rb +35 -2
- data/lib/abstract_controller/callbacks.rb +2 -2
- data/lib/abstract_controller/helpers.rb +105 -90
- data/lib/abstract_controller/rendering.rb +9 -9
- data/lib/abstract_controller/translation.rb +8 -2
- data/lib/abstract_controller.rb +1 -0
- data/lib/action_controller/api.rb +2 -2
- data/lib/action_controller/base.rb +4 -2
- data/lib/action_controller/caching.rb +0 -1
- data/lib/action_controller/log_subscriber.rb +3 -3
- data/lib/action_controller/metal/conditional_get.rb +10 -2
- data/lib/action_controller/metal/content_security_policy.rb +1 -1
- data/lib/action_controller/metal/data_streaming.rb +1 -1
- data/lib/action_controller/metal/etag_with_template_digest.rb +2 -4
- data/lib/action_controller/metal/exceptions.rb +33 -0
- data/lib/action_controller/metal/feature_policy.rb +46 -0
- data/lib/action_controller/metal/head.rb +7 -4
- data/lib/action_controller/metal/helpers.rb +11 -1
- data/lib/action_controller/metal/http_authentication.rb +5 -3
- data/lib/action_controller/metal/implicit_render.rb +1 -1
- data/lib/action_controller/metal/instrumentation.rb +11 -9
- data/lib/action_controller/metal/live.rb +1 -1
- data/lib/action_controller/metal/logging.rb +20 -0
- data/lib/action_controller/metal/mime_responds.rb +6 -2
- data/lib/action_controller/metal/parameter_encoding.rb +35 -4
- data/lib/action_controller/metal/params_wrapper.rb +16 -11
- data/lib/action_controller/metal/redirecting.rb +1 -1
- data/lib/action_controller/metal/rendering.rb +6 -0
- data/lib/action_controller/metal/request_forgery_protection.rb +1 -1
- data/lib/action_controller/metal/rescue.rb +1 -1
- data/lib/action_controller/metal/strong_parameters.rb +103 -15
- data/lib/action_controller/metal.rb +2 -2
- data/lib/action_controller/renderer.rb +24 -13
- data/lib/action_controller/test_case.rb +62 -56
- data/lib/action_controller.rb +2 -3
- data/lib/action_dispatch/http/cache.rb +12 -10
- data/lib/action_dispatch/http/content_security_policy.rb +5 -1
- data/lib/action_dispatch/http/feature_policy.rb +168 -0
- data/lib/action_dispatch/http/filter_parameters.rb +1 -1
- data/lib/action_dispatch/http/filter_redirect.rb +1 -1
- data/lib/action_dispatch/http/headers.rb +3 -2
- data/lib/action_dispatch/http/mime_negotiation.rb +14 -8
- data/lib/action_dispatch/http/mime_type.rb +29 -16
- data/lib/action_dispatch/http/parameters.rb +1 -19
- data/lib/action_dispatch/http/request.rb +24 -8
- data/lib/action_dispatch/http/response.rb +17 -16
- data/lib/action_dispatch/http/url.rb +3 -2
- data/lib/action_dispatch/journey/formatter.rb +53 -28
- data/lib/action_dispatch/journey/gtg/builder.rb +22 -36
- data/lib/action_dispatch/journey/gtg/simulator.rb +8 -7
- data/lib/action_dispatch/journey/gtg/transition_table.rb +6 -4
- data/lib/action_dispatch/journey/nfa/dot.rb +0 -11
- data/lib/action_dispatch/journey/nodes/node.rb +4 -3
- data/lib/action_dispatch/journey/parser.rb +13 -13
- data/lib/action_dispatch/journey/parser.y +1 -1
- data/lib/action_dispatch/journey/path/pattern.rb +13 -18
- data/lib/action_dispatch/journey/route.rb +7 -18
- data/lib/action_dispatch/journey/router/utils.rb +6 -4
- data/lib/action_dispatch/journey/router.rb +26 -30
- data/lib/action_dispatch/journey.rb +0 -2
- data/lib/action_dispatch/middleware/actionable_exceptions.rb +1 -1
- data/lib/action_dispatch/middleware/cookies.rb +67 -32
- data/lib/action_dispatch/middleware/debug_exceptions.rb +8 -15
- data/lib/action_dispatch/middleware/debug_view.rb +1 -1
- data/lib/action_dispatch/middleware/exception_wrapper.rb +28 -16
- data/lib/action_dispatch/middleware/host_authorization.rb +35 -35
- data/lib/action_dispatch/middleware/remote_ip.rb +5 -4
- data/lib/action_dispatch/middleware/request_id.rb +4 -5
- data/lib/action_dispatch/middleware/session/abstract_store.rb +2 -2
- data/lib/action_dispatch/middleware/session/cookie_store.rb +2 -2
- data/lib/action_dispatch/middleware/ssl.rb +9 -6
- data/lib/action_dispatch/middleware/stack.rb +18 -0
- data/lib/action_dispatch/middleware/static.rb +154 -93
- data/lib/action_dispatch/middleware/templates/rescues/_message_and_suggestions.html.erb +18 -0
- data/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb +2 -5
- data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.html.erb +2 -2
- data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.text.erb +2 -3
- data/lib/action_dispatch/middleware/templates/rescues/layout.erb +88 -8
- data/lib/action_dispatch/middleware/templates/rescues/unknown_action.html.erb +1 -1
- data/lib/action_dispatch/middleware/templates/routes/_table.html.erb +12 -1
- data/lib/action_dispatch/railtie.rb +3 -2
- data/lib/action_dispatch/request/session.rb +2 -8
- data/lib/action_dispatch/request/utils.rb +26 -2
- data/lib/action_dispatch/routing/inspector.rb +8 -7
- data/lib/action_dispatch/routing/mapper.rb +102 -71
- data/lib/action_dispatch/routing/polymorphic_routes.rb +16 -19
- data/lib/action_dispatch/routing/redirection.rb +3 -3
- data/lib/action_dispatch/routing/route_set.rb +49 -41
- data/lib/action_dispatch/system_test_case.rb +29 -24
- data/lib/action_dispatch/system_testing/browser.rb +33 -27
- data/lib/action_dispatch/system_testing/driver.rb +6 -7
- data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb +47 -6
- data/lib/action_dispatch/system_testing/test_helpers/setup_and_teardown.rb +4 -7
- data/lib/action_dispatch/testing/assertions/response.rb +2 -4
- data/lib/action_dispatch/testing/assertions/routing.rb +5 -5
- data/lib/action_dispatch/testing/assertions.rb +1 -1
- data/lib/action_dispatch/testing/integration.rb +38 -27
- data/lib/action_dispatch/testing/test_process.rb +29 -4
- data/lib/action_dispatch/testing/test_request.rb +3 -3
- data/lib/action_dispatch.rb +3 -2
- data/lib/action_pack/gem_version.rb +3 -3
- data/lib/action_pack.rb +1 -1
- metadata +20 -21
- data/lib/action_controller/metal/force_ssl.rb +0 -58
- data/lib/action_dispatch/http/parameter_filter.rb +0 -12
- data/lib/action_dispatch/journey/nfa/builder.rb +0 -78
- data/lib/action_dispatch/journey/nfa/simulator.rb +0 -47
- data/lib/action_dispatch/journey/nfa/transition_table.rb +0 -119
data/CHANGELOG.md
CHANGED
@@ -1,131 +1,166 @@
|
|
1
|
-
## Rails 6.0.
|
1
|
+
## Rails 6.1.0.rc1 (November 02, 2020) ##
|
2
2
|
|
3
|
-
*
|
3
|
+
* Allow `ActionDispatch::HostAuthorization` to exclude specific requests.
|
4
4
|
|
5
|
+
Host Authorization checks can be skipped for specific requests. This allows for health check requests to be permitted for requests with missing or non-matching host headers.
|
5
6
|
|
6
|
-
|
7
|
+
*Chris Bisnett*
|
7
8
|
|
8
|
-
*
|
9
|
+
* Add `config.action_dispatch.request_id_header` to allow changing the name of
|
10
|
+
the unique X-Request-Id header
|
9
11
|
|
12
|
+
*Arlston Fernandes*
|
10
13
|
|
11
|
-
|
14
|
+
* Deprecate `config.action_dispatch.return_only_media_type_on_content_type`.
|
12
15
|
|
13
|
-
*
|
16
|
+
*Rafael Mendonça França*
|
14
17
|
|
15
|
-
|
18
|
+
* Change `ActionDispatch::Response#content_type` to return the full Content-Type header.
|
16
19
|
|
17
|
-
*
|
20
|
+
*Rafael Mendonça França*
|
18
21
|
|
19
|
-
|
20
|
-
"allowed host" formats can cause the Host Authorization middleware in Action
|
21
|
-
Pack to redirect users to a malicious website.
|
22
|
+
* Remove deprecated `ActionDispatch::Http::ParameterFilter`.
|
22
23
|
|
23
|
-
|
24
|
+
*Rafael Mendonça França*
|
24
25
|
|
25
|
-
*
|
26
|
+
* Added support for exclusive no-store Cache-Control header.
|
26
27
|
|
27
|
-
|
28
|
-
them difficult to deal with. For example, the common practice of sending
|
29
|
-
the CSRF token to a browser in a client-readable cookie does not work properly
|
30
|
-
out of the box: the value has to be url-encoded and decoded to survive transport.
|
28
|
+
If `no-store` is set on Cache-Control header it is exclusive (all other cache directives are dropped).
|
31
29
|
|
32
|
-
|
33
|
-
safe to transport. Validation accepts both urlsafe tokens, and strict-encoded
|
34
|
-
tokens for backwards compatibility.
|
30
|
+
*Chris Kruger*
|
35
31
|
|
36
|
-
|
37
|
-
If you upgrade apps from 5.2.5, set the config `urlsafe_csrf_tokens = true`.
|
32
|
+
* Catch invalid UTF-8 parameters for POST requests and respond with BadRequest.
|
38
33
|
|
39
|
-
|
40
|
-
|
41
|
-
```
|
34
|
+
Additionally, perform `#set_binary_encoding` in `ActionDispatch::Http::Request#GET` and
|
35
|
+
`ActionDispatch::Http::Request#POST` prior to validating encoding.
|
42
36
|
|
43
|
-
*
|
37
|
+
*Adrianna Chang*
|
44
38
|
|
45
|
-
*
|
46
|
-
`action_dispatch.use_cookies_with_metadata` is enabled.
|
39
|
+
* Allow `assert_recognizes` routing assertions to work on mounted root routes.
|
47
40
|
|
48
|
-
*
|
41
|
+
*Gannon McGibbon*
|
49
42
|
|
43
|
+
* Change default redirection status code for non-GET/HEAD requests to 308 Permanent Redirect for `ActionDispatch::SSL`.
|
50
44
|
|
51
|
-
|
45
|
+
*Alan Tan*, *Oz Ben-David*
|
52
46
|
|
53
|
-
*
|
54
|
-
|
47
|
+
* Fix `follow_redirect!` to follow redirection with same HTTP verb when following
|
48
|
+
a 308 redirection.
|
55
49
|
|
56
|
-
*
|
57
|
-
CVE-2021-22904
|
50
|
+
*Alan Tan*
|
58
51
|
|
59
|
-
*
|
52
|
+
* When multiple domains are specified for a cookie, a domain will now be
|
53
|
+
chosen only if it is equal to or is a superdomain of the request host.
|
60
54
|
|
61
|
-
|
62
|
-
of arguments (usually symbols and records). If a developer passes a
|
63
|
-
user input array, strings can result in unwanted route helper calls.
|
55
|
+
*Jonathan Hefner*
|
64
56
|
|
65
|
-
|
57
|
+
* `ActionDispatch::Static` handles precompiled Brotli (.br) files.
|
66
58
|
|
67
|
-
|
59
|
+
Adds to existing support for precompiled gzip (.gz) files.
|
60
|
+
Brotli files are preferred due to much better compression.
|
68
61
|
|
69
|
-
|
62
|
+
When the browser requests /some.js with `Accept-Encoding: br`,
|
63
|
+
we check for public/some.js.br and serve that file, if present, with
|
64
|
+
`Content-Encoding: br` and `Vary: Accept-Encoding` headers.
|
70
65
|
|
71
|
-
*
|
66
|
+
*Ryan Edward Hall*, *Jeremy Daer*
|
72
67
|
|
68
|
+
* Add raise_on_missing_translations support for controllers.
|
73
69
|
|
74
|
-
|
70
|
+
This configuration determines whether an error should be raised for missing translations.
|
71
|
+
It can be enabled through `config.i18n.raise_on_missing_translations`. Note that described
|
72
|
+
configuration also affects raising error for missing translations in views.
|
75
73
|
|
76
|
-
*
|
74
|
+
*fatkodima*
|
77
75
|
|
78
|
-
|
76
|
+
* Added `compact` and `compact!` to `ActionController::Parameters`.
|
79
77
|
|
80
|
-
|
81
|
-
issue and the patch!
|
78
|
+
*Eugene Kenny*
|
82
79
|
|
83
|
-
|
80
|
+
* Calling `each_pair` or `each_value` on an `ActionController::Parameters`
|
81
|
+
without passing a block now returns an enumerator.
|
84
82
|
|
83
|
+
*Eugene Kenny*
|
85
84
|
|
86
|
-
|
85
|
+
* `fixture_file_upload` now uses path relative to `file_fixture_path`
|
87
86
|
|
88
|
-
|
87
|
+
Previously the path had to be relative to `fixture_path`.
|
88
|
+
You can change your existing code as follow:
|
89
89
|
|
90
|
+
```ruby
|
91
|
+
# Before
|
92
|
+
fixture_file_upload('files/dog.png')
|
90
93
|
|
91
|
-
|
94
|
+
# After
|
95
|
+
fixture_file_upload('dog.png')
|
96
|
+
```
|
92
97
|
|
93
|
-
*
|
98
|
+
*Edouard Chin*
|
94
99
|
|
100
|
+
* Remove deprecated `force_ssl` at the controller level.
|
95
101
|
|
96
|
-
|
102
|
+
*Rafael Mendonça França*
|
97
103
|
|
98
|
-
*
|
104
|
+
* The +helper+ class method for controllers loads helper modules specified as
|
105
|
+
strings/symbols with `String#constantize` instead of `require_dependency`.
|
99
106
|
|
100
|
-
|
107
|
+
Remember that support for strings/symbols is only a convenient API. You can
|
108
|
+
always pass a module object:
|
101
109
|
|
102
|
-
|
110
|
+
```ruby
|
111
|
+
helper UtilsHelper
|
112
|
+
```
|
103
113
|
|
104
|
-
|
114
|
+
which is recommended because it is simple and direct. When a string/symbol
|
115
|
+
is received, `helper` just manipulates and inflects the argument to obtain
|
116
|
+
that same module object.
|
105
117
|
|
118
|
+
*Xavier Noria*, *Jean Boussier*
|
106
119
|
|
107
|
-
|
120
|
+
* Correctly identify the entire localhost IPv4 range as trusted proxy.
|
108
121
|
|
109
|
-
*
|
122
|
+
*Nick Soracco*
|
110
123
|
|
111
|
-
|
112
|
-
|
113
|
-
from being correctly counted and reported.
|
124
|
+
* `url_for` will now use "https://" as the default protocol when
|
125
|
+
`Rails.application.config.force_ssl` is set to true.
|
114
126
|
|
115
|
-
|
116
|
-
root session.
|
127
|
+
*Jonathan Hefner*
|
117
128
|
|
118
|
-
|
129
|
+
* Accept and default to base64_urlsafe CSRF tokens.
|
119
130
|
|
120
|
-
|
131
|
+
Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
|
132
|
+
them difficult to deal with. For example, the common practice of sending
|
133
|
+
the CSRF token to a browser in a client-readable cookie does not work properly
|
134
|
+
out of the box: the value has to be url-encoded and decoded to survive transport.
|
135
|
+
|
136
|
+
Now, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently safe
|
137
|
+
to transport. Validation accepts both urlsafe tokens, and strict-encoded tokens
|
138
|
+
for backwards compatibility.
|
139
|
+
|
140
|
+
*Scott Blum*
|
141
|
+
|
142
|
+
* Support rolling deploys for cookie serialization/encryption changes.
|
121
143
|
|
144
|
+
In a distributed configuration like rolling update, users may observe
|
145
|
+
both old and new instances during deployment. Users may be served by a
|
146
|
+
new instance and then by an old instance.
|
122
147
|
|
123
|
-
|
148
|
+
That means when the server changes `cookies_serializer` from `:marshal`
|
149
|
+
to `:hybrid` or the server changes `use_authenticated_cookie_encryption`
|
150
|
+
from `false` to `true`, users may lose their sessions if they access the
|
151
|
+
server during deployment.
|
124
152
|
|
125
|
-
|
153
|
+
We added fallbacks to downgrade the cookie format when necessary during
|
154
|
+
deployment, ensuring compatibility on both old and new instances.
|
126
155
|
|
156
|
+
*Masaki Hara*
|
127
157
|
|
128
|
-
|
158
|
+
* `ActionDispatch::Request.remote_ip` has ip address even when all sites are trusted.
|
159
|
+
|
160
|
+
Before, if all `X-Forwarded-For` sites were trusted, the `remote_ip` would default to `127.0.0.1`.
|
161
|
+
Now, the furthest proxy site is used. e.g.: It now gives an ip address when using curl from the load balancer.
|
162
|
+
|
163
|
+
*Keenan Brock*
|
129
164
|
|
130
165
|
* Fix possible information leak / session hijacking vulnerability.
|
131
166
|
|
@@ -134,339 +169,227 @@
|
|
134
169
|
|
135
170
|
CVE-2019-16782.
|
136
171
|
|
172
|
+
* Include child session assertion count in ActionDispatch::IntegrationTest.
|
137
173
|
|
138
|
-
|
174
|
+
`IntegrationTest#open_session` uses `dup` to create the new session, which
|
175
|
+
meant it had its own copy of `@assertions`. This prevented the assertions
|
176
|
+
from being correctly counted and reported.
|
139
177
|
|
140
|
-
|
178
|
+
Child sessions now have their `attr_accessor` overridden to delegate to the
|
179
|
+
root session.
|
141
180
|
|
142
|
-
|
181
|
+
Fixes #32142.
|
143
182
|
|
183
|
+
*Sam Bostock*
|
144
184
|
|
145
|
-
|
185
|
+
* Add SameSite protection to every written cookie.
|
146
186
|
|
147
|
-
|
148
|
-
|
149
|
-
system tests.
|
187
|
+
Enabling `SameSite` cookie protection is an addition to CSRF protection,
|
188
|
+
where cookies won't be sent by browsers in cross-site POST requests when set to `:lax`.
|
150
189
|
|
151
|
-
|
190
|
+
`:strict` disables cookies being sent in cross-site GET or POST requests.
|
152
191
|
|
153
|
-
|
192
|
+
Passing `:none` disables this protection and is the same as previous versions albeit a `; SameSite=None` is appended to the cookie.
|
154
193
|
|
155
|
-
|
156
|
-
Mime::Type.register "text/html; fragment", :html_fragment
|
157
|
-
```
|
194
|
+
See upgrade instructions in config/initializers/new_framework_defaults_6_1.rb.
|
158
195
|
|
159
|
-
|
196
|
+
More info [here](https://tools.ietf.org/html/draft-west-first-party-cookies-07)
|
160
197
|
|
198
|
+
_NB: Technically already possible as Rack supports SameSite protection, this is to ensure it's applied to all cookies_
|
161
199
|
|
162
|
-
|
200
|
+
*Cédric Fabianski*
|
163
201
|
|
164
|
-
*
|
202
|
+
* Bring back the feature that allows loading external route files from the router.
|
165
203
|
|
204
|
+
This feature existed back in 2012 but got reverted with the incentive that
|
205
|
+
https://github.com/rails/routing_concerns was a better approach. Turned out
|
206
|
+
that this wasn't fully the case and loading external route files from the router
|
207
|
+
can be helpful for applications with a really large set of routes.
|
208
|
+
Without this feature, application needs to implement routes reloading
|
209
|
+
themselves and it's not straightforward.
|
166
210
|
|
167
|
-
|
211
|
+
```ruby
|
212
|
+
# config/routes.rb
|
168
213
|
|
169
|
-
|
214
|
+
Rails.application.routes.draw do
|
215
|
+
draw(:admin)
|
216
|
+
end
|
170
217
|
|
171
|
-
|
218
|
+
# config/routes/admin.rb
|
172
219
|
|
173
|
-
|
220
|
+
get :foo, to: 'foo#bar'
|
221
|
+
```
|
174
222
|
|
175
|
-
*
|
223
|
+
*Yehuda Katz*, *Edouard Chin*
|
176
224
|
|
177
|
-
|
178
|
-
take parameters the scope was lost when using path helpers. This commit
|
179
|
-
ensures scope is kept both when the route takes parameters or when it
|
180
|
-
doesn't.
|
225
|
+
* Fix system test driver option initialization for non-headless browsers.
|
181
226
|
|
182
|
-
|
227
|
+
*glaszig*
|
183
228
|
|
184
|
-
|
229
|
+
* `redirect_to.action_controller` notifications now include the `ActionDispatch::Request` in
|
230
|
+
their payloads as `:request`.
|
185
231
|
|
186
|
-
*
|
232
|
+
*Austin Story*
|
187
233
|
|
188
|
-
|
189
|
-
|
190
|
-
containing charset part as it is.
|
234
|
+
* `respond_to#any` no longer returns a response's Content-Type based on the
|
235
|
+
request format but based on the block given.
|
191
236
|
|
192
|
-
|
193
|
-
instead.
|
237
|
+
Example:
|
194
238
|
|
195
|
-
|
196
|
-
|
197
|
-
|
239
|
+
```ruby
|
240
|
+
def my_action
|
241
|
+
respond_to do |format|
|
242
|
+
format.any { render(json: { foo: 'bar' }) }
|
243
|
+
end
|
244
|
+
end
|
198
245
|
|
199
|
-
|
246
|
+
get('my_action.csv')
|
247
|
+
```
|
200
248
|
|
201
|
-
|
202
|
-
|
249
|
+
The previous behaviour was to respond with a `text/csv` Content-Type which
|
250
|
+
is inaccurate since a JSON response is being rendered.
|
203
251
|
|
204
|
-
|
252
|
+
Now it correctly returns a `application/json` Content-Type.
|
205
253
|
|
206
|
-
*
|
254
|
+
*Edouard Chin*
|
207
255
|
|
208
|
-
|
256
|
+
* Replaces (back)slashes in failure screenshot image paths with dashes.
|
209
257
|
|
258
|
+
If a failed test case contained a slash or a backslash, a screenshot would be created in a
|
259
|
+
nested directory, causing issues with `tmp:clear`.
|
210
260
|
|
211
|
-
|
261
|
+
*Damir Zekic*
|
212
262
|
|
213
|
-
*
|
214
|
-
rather than an `after_teardown` hook.
|
263
|
+
* Add `params.member?` to mimic Hash behavior.
|
215
264
|
|
216
|
-
|
217
|
-
the screenshot is taken (reducing the time in which the page could have
|
218
|
-
been dynamically updated after the assertion failed).
|
265
|
+
*Younes Serraj*
|
219
266
|
|
220
|
-
|
267
|
+
* `process_action.action_controller` notifications now include the following in their payloads:
|
221
268
|
|
222
|
-
*
|
269
|
+
* `:request` - the `ActionDispatch::Request`
|
270
|
+
* `:response` - the `ActionDispatch::Response`
|
223
271
|
|
224
|
-
|
225
|
-
from `ActiveSupport::ActionableError` descendants.
|
272
|
+
*George Claghorn*
|
226
273
|
|
227
|
-
|
274
|
+
* Updated `ActionDispatch::Request.remote_ip` setter to clear set the instance
|
275
|
+
`remote_ip` to `nil` before setting the header that the value is derived
|
276
|
+
from.
|
228
277
|
|
229
|
-
|
278
|
+
Fixes #37383.
|
230
279
|
|
231
|
-
*
|
280
|
+
*Norm Provost*
|
232
281
|
|
233
|
-
|
282
|
+
* `ActionController::Base.log_at` allows setting a different log level per request.
|
234
283
|
|
235
|
-
```
|
236
|
-
|
237
|
-
|
284
|
+
```ruby
|
285
|
+
# Use the debug level if a particular cookie is set.
|
286
|
+
class ApplicationController < ActionController::Base
|
287
|
+
log_at :debug, if: -> { cookies[:debug] }
|
238
288
|
end
|
239
289
|
```
|
240
290
|
|
241
|
-
|
291
|
+
*George Claghorn*
|
242
292
|
|
243
|
-
|
293
|
+
* Allow system test screen shots to be taken more than once in
|
294
|
+
a test by prefixing the file name with an incrementing counter.
|
244
295
|
|
296
|
+
Add an environment variable `RAILS_SYSTEM_TESTING_SCREENSHOT_HTML` to
|
297
|
+
enable saving of HTML during a screenshot in addition to the image.
|
298
|
+
This uses the same image name, with the extension replaced with `.html`
|
245
299
|
|
246
|
-
|
300
|
+
*Tom Fakes*
|
247
301
|
|
248
|
-
*
|
302
|
+
* Add `Vary: Accept` header when using `Accept` header for response.
|
249
303
|
|
304
|
+
For some requests like `/users/1`, Rails uses requests' `Accept`
|
305
|
+
header to determine what to return. And if we don't add `Vary`
|
306
|
+
in the response header, browsers might accidentally cache different
|
307
|
+
types of content, which would cause issues: e.g. javascript got displayed
|
308
|
+
instead of html content. This PR fixes these issues by adding `Vary: Accept`
|
309
|
+
in these types of requests. For more detailed problem description, please read:
|
250
310
|
|
251
|
-
|
311
|
+
https://github.com/rails/rails/pull/36213
|
252
312
|
|
253
|
-
|
313
|
+
Fixes #25842.
|
254
314
|
|
255
|
-
*
|
315
|
+
*Stan Lo*
|
256
316
|
|
257
|
-
* `
|
258
|
-
|
317
|
+
* Fix IntegrationTest `follow_redirect!` to follow redirection using the same HTTP verb when following
|
318
|
+
a 307 redirection.
|
259
319
|
|
260
320
|
*Edouard Chin*
|
261
321
|
|
322
|
+
* System tests require Capybara 3.26 or newer.
|
262
323
|
|
263
|
-
|
324
|
+
*George Claghorn*
|
264
325
|
|
265
|
-
*
|
326
|
+
* Reduced log noise handling ActionController::RoutingErrors.
|
266
327
|
|
267
|
-
*
|
268
|
-
|
269
|
-
* Remove deprecated methods in `ActionDispatch::TestResponse`.
|
270
|
-
|
271
|
-
`#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
|
272
|
-
`#successful?`, `not_found?` and `server_error?`.
|
273
|
-
|
274
|
-
*Rafael Mendonça França*
|
275
|
-
|
276
|
-
* Introduce `ActionDispatch::HostAuthorization`.
|
328
|
+
*Alberto Fernández-Capel*
|
277
329
|
|
278
|
-
|
279
|
-
explicitly permitting the hosts a request can be made to.
|
330
|
+
* Add DSL for configuring HTTP Feature Policy.
|
280
331
|
|
281
|
-
|
282
|
-
|
332
|
+
This new DSL provides a way to configure an HTTP Feature Policy at a
|
333
|
+
global or per-controller level. Full details of HTTP Feature Policy
|
334
|
+
specification and guidelines can be found at MDN:
|
283
335
|
|
284
|
-
|
336
|
+
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy
|
285
337
|
|
286
|
-
|
338
|
+
Example global policy:
|
287
339
|
|
288
|
-
|
289
|
-
|
290
|
-
|
291
|
-
|
292
|
-
|
293
|
-
|
294
|
-
|
295
|
-
|
296
|
-
end
|
340
|
+
```ruby
|
341
|
+
Rails.application.config.feature_policy do |f|
|
342
|
+
f.camera :none
|
343
|
+
f.gyroscope :none
|
344
|
+
f.microphone :none
|
345
|
+
f.usb :none
|
346
|
+
f.fullscreen :self
|
347
|
+
f.payment :self, "https://secure.example.com"
|
297
348
|
end
|
298
349
|
```
|
299
350
|
|
300
|
-
|
301
|
-
|
302
|
-
*Tobias Bühlmann*
|
303
|
-
|
304
|
-
* Raise an error on root route naming conflicts.
|
305
|
-
|
306
|
-
Raises an `ArgumentError` when multiple root routes are defined in the
|
307
|
-
same context instead of assigning nil names to subsequent roots.
|
351
|
+
Example controller level policy:
|
308
352
|
|
309
|
-
|
310
|
-
|
311
|
-
|
312
|
-
|
313
|
-
|
314
|
-
rescue_from ActionDispatch::Http::Parameters::ParseError do
|
315
|
-
head :unauthorized
|
353
|
+
```ruby
|
354
|
+
class PagesController < ApplicationController
|
355
|
+
feature_policy do |p|
|
356
|
+
p.geolocation "https://example.com"
|
357
|
+
end
|
316
358
|
end
|
317
359
|
```
|
318
360
|
|
319
|
-
*
|
320
|
-
|
321
|
-
* Reset Capybara sessions if failed system test screenshot raising an exception.
|
322
|
-
|
323
|
-
Reset Capybara sessions if `take_failed_screenshot` raise exception
|
324
|
-
in system test `after_teardown`.
|
325
|
-
|
326
|
-
*Maxim Perepelitsa*
|
327
|
-
|
328
|
-
* Use request object for context if there's no controller
|
329
|
-
|
330
|
-
There is no controller instance when using a redirect route or a
|
331
|
-
mounted rack application so pass the request object as the context
|
332
|
-
when resolving dynamic CSP sources in this scenario.
|
333
|
-
|
334
|
-
Fixes #34200.
|
335
|
-
|
336
|
-
*Andrew White*
|
337
|
-
|
338
|
-
* Apply mapping to symbols returned from dynamic CSP sources
|
339
|
-
|
340
|
-
Previously if a dynamic source returned a symbol such as :self it
|
341
|
-
would be converted to a string implicitly, e.g:
|
342
|
-
|
343
|
-
policy.default_src -> { :self }
|
344
|
-
|
345
|
-
would generate the header:
|
346
|
-
|
347
|
-
Content-Security-Policy: default-src self
|
348
|
-
|
349
|
-
and now it generates:
|
350
|
-
|
351
|
-
Content-Security-Policy: default-src 'self'
|
352
|
-
|
353
|
-
*Andrew White*
|
354
|
-
|
355
|
-
* Add `ActionController::Parameters#each_value`.
|
356
|
-
|
357
|
-
*Lukáš Zapletal*
|
358
|
-
|
359
|
-
* Deprecate `ActionDispatch::Http::ParameterFilter` in favor of `ActiveSupport::ParameterFilter`.
|
360
|
-
|
361
|
-
*Yoshiyuki Kinjo*
|
362
|
-
|
363
|
-
* Encode Content-Disposition filenames on `send_data` and `send_file`.
|
364
|
-
Previously, `send_data 'data', filename: "\u{3042}.txt"` sends
|
365
|
-
`"filename=\"\u{3042}.txt\""` as Content-Disposition and it can be
|
366
|
-
garbled.
|
367
|
-
Now it follows [RFC 2231](https://tools.ietf.org/html/rfc2231) and
|
368
|
-
[RFC 5987](https://tools.ietf.org/html/rfc5987) and sends
|
369
|
-
`"filename=\"%3F.txt\"; filename*=UTF-8''%E3%81%82.txt"`.
|
370
|
-
Most browsers can find filename correctly and old browsers fallback to ASCII
|
371
|
-
converted name.
|
372
|
-
|
373
|
-
*Fumiaki Matsushima*
|
374
|
-
|
375
|
-
* Expose `ActionController::Parameters#each_key` which allows iterating over
|
376
|
-
keys without allocating an array.
|
377
|
-
|
378
|
-
*Richard Schneeman*
|
379
|
-
|
380
|
-
* Purpose metadata for signed/encrypted cookies.
|
361
|
+
*Jacob Bednarz*
|
381
362
|
|
382
|
-
|
383
|
-
of a cookie and use it as the value of another cookie.
|
384
|
-
|
385
|
-
It does so by stashing the cookie-name in the purpose field which is
|
386
|
-
then signed/encrypted along with the cookie value. Then, on a server-side
|
387
|
-
read, we verify the cookie-names and discard any attacked cookies.
|
388
|
-
|
389
|
-
Enable `action_dispatch.use_cookies_with_metadata` to use this feature, which
|
390
|
-
writes cookies with the new purpose and expiry metadata embedded.
|
391
|
-
|
392
|
-
*Assain Jaleel*
|
393
|
-
|
394
|
-
* Raises `ActionController::RespondToMismatchError` with conflicting `respond_to` invocations.
|
395
|
-
|
396
|
-
`respond_to` can match multiple types and lead to undefined behavior when
|
397
|
-
multiple invocations are made and the types do not match:
|
398
|
-
|
399
|
-
respond_to do |outer_type|
|
400
|
-
outer_type.js do
|
401
|
-
respond_to do |inner_type|
|
402
|
-
inner_type.html { render body: "HTML" }
|
403
|
-
end
|
404
|
-
end
|
405
|
-
end
|
406
|
-
|
407
|
-
*Patrick Toomey*
|
408
|
-
|
409
|
-
* `ActionDispatch::Http::UploadedFile` now delegates `to_path` to its tempfile.
|
410
|
-
|
411
|
-
This allows uploaded file objects to be passed directly to `File.read`
|
412
|
-
without raising a `TypeError`:
|
413
|
-
|
414
|
-
uploaded_file = ActionDispatch::Http::UploadedFile.new(tempfile: tmp_file)
|
415
|
-
File.read(uploaded_file)
|
416
|
-
|
417
|
-
*Aaron Kromer*
|
418
|
-
|
419
|
-
* Pass along arguments to underlying `get` method in `follow_redirect!`
|
420
|
-
|
421
|
-
Now all arguments passed to `follow_redirect!` are passed to the underlying
|
422
|
-
`get` method. This for example allows to set custom headers for the
|
423
|
-
redirection request to the server.
|
424
|
-
|
425
|
-
follow_redirect!(params: { foo: :bar })
|
426
|
-
|
427
|
-
*Remo Fritzsche*
|
428
|
-
|
429
|
-
* Introduce a new error page to when the implicit render page is accessed in the browser.
|
430
|
-
|
431
|
-
Now instead of showing an error page that with exception and backtraces we now show only
|
432
|
-
one informative page.
|
433
|
-
|
434
|
-
*Vinicius Stock*
|
435
|
-
|
436
|
-
* Introduce `ActionDispatch::DebugExceptions.register_interceptor`.
|
437
|
-
|
438
|
-
Exception aware plugin authors can use the newly introduced
|
439
|
-
`.register_interceptor` method to get the processed exception, instead of
|
440
|
-
monkey patching DebugExceptions.
|
441
|
-
|
442
|
-
ActionDispatch::DebugExceptions.register_interceptor do |request, exception|
|
443
|
-
HypoteticalPlugin.capture_exception(request, exception)
|
444
|
-
end
|
363
|
+
* Add the ability to set the CSP nonce only to the specified directives.
|
445
364
|
|
446
|
-
|
365
|
+
Fixes #35137.
|
447
366
|
|
448
|
-
*
|
367
|
+
*Yuji Yaginuma*
|
449
368
|
|
450
|
-
|
369
|
+
* Keep part when scope option has value.
|
451
370
|
|
452
|
-
|
371
|
+
When a route was defined within an optional scope, if that route didn't
|
372
|
+
take parameters the scope was lost when using path helpers. This commit
|
373
|
+
ensures scope is kept both when the route takes parameters or when it
|
374
|
+
doesn't.
|
453
375
|
|
454
|
-
|
376
|
+
Fixes #33219.
|
455
377
|
|
456
|
-
*
|
378
|
+
*Alberto Almagro*
|
457
379
|
|
458
|
-
*
|
380
|
+
* Added `deep_transform_keys` and `deep_transform_keys!` methods to ActionController::Parameters.
|
459
381
|
|
460
|
-
*
|
382
|
+
*Gustavo Gutierrez*
|
461
383
|
|
462
|
-
*
|
463
|
-
|
384
|
+
* Calling `ActionController::Parameters#transform_keys`/`!` without a block now returns
|
385
|
+
an enumerator for the parameters instead of the underlying hash.
|
464
386
|
|
465
|
-
*
|
387
|
+
*Eugene Kenny*
|
466
388
|
|
467
|
-
*
|
389
|
+
* Fix strong parameters blocks all attributes even when only some keys are invalid (non-numerical).
|
390
|
+
It should only block invalid key's values instead.
|
468
391
|
|
469
|
-
*
|
392
|
+
*Stan Lo*
|
470
393
|
|
471
394
|
|
472
|
-
Please check [
|
395
|
+
Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionpack/CHANGELOG.md) for previous changes.
|