actionpack 6.0.4.1 → 6.1.0.rc1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of actionpack might be problematic. Click here for more details.

Files changed (112) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +241 -304
  3. data/MIT-LICENSE +1 -1
  4. data/README.rdoc +1 -1
  5. data/lib/abstract_controller/base.rb +35 -2
  6. data/lib/abstract_controller/callbacks.rb +2 -2
  7. data/lib/abstract_controller/helpers.rb +105 -90
  8. data/lib/abstract_controller/rendering.rb +9 -9
  9. data/lib/abstract_controller/translation.rb +8 -2
  10. data/lib/abstract_controller.rb +1 -0
  11. data/lib/action_controller/api.rb +2 -2
  12. data/lib/action_controller/base.rb +4 -2
  13. data/lib/action_controller/caching.rb +0 -1
  14. data/lib/action_controller/log_subscriber.rb +3 -3
  15. data/lib/action_controller/metal/conditional_get.rb +10 -2
  16. data/lib/action_controller/metal/content_security_policy.rb +1 -1
  17. data/lib/action_controller/metal/data_streaming.rb +1 -1
  18. data/lib/action_controller/metal/etag_with_template_digest.rb +2 -4
  19. data/lib/action_controller/metal/exceptions.rb +33 -0
  20. data/lib/action_controller/metal/feature_policy.rb +46 -0
  21. data/lib/action_controller/metal/head.rb +7 -4
  22. data/lib/action_controller/metal/helpers.rb +11 -1
  23. data/lib/action_controller/metal/http_authentication.rb +5 -3
  24. data/lib/action_controller/metal/implicit_render.rb +1 -1
  25. data/lib/action_controller/metal/instrumentation.rb +11 -9
  26. data/lib/action_controller/metal/live.rb +1 -1
  27. data/lib/action_controller/metal/logging.rb +20 -0
  28. data/lib/action_controller/metal/mime_responds.rb +6 -2
  29. data/lib/action_controller/metal/parameter_encoding.rb +35 -4
  30. data/lib/action_controller/metal/params_wrapper.rb +16 -11
  31. data/lib/action_controller/metal/redirecting.rb +1 -1
  32. data/lib/action_controller/metal/rendering.rb +6 -0
  33. data/lib/action_controller/metal/request_forgery_protection.rb +1 -1
  34. data/lib/action_controller/metal/rescue.rb +1 -1
  35. data/lib/action_controller/metal/strong_parameters.rb +103 -15
  36. data/lib/action_controller/metal.rb +2 -2
  37. data/lib/action_controller/renderer.rb +24 -13
  38. data/lib/action_controller/test_case.rb +62 -56
  39. data/lib/action_controller.rb +2 -3
  40. data/lib/action_dispatch/http/cache.rb +12 -10
  41. data/lib/action_dispatch/http/content_security_policy.rb +5 -1
  42. data/lib/action_dispatch/http/feature_policy.rb +168 -0
  43. data/lib/action_dispatch/http/filter_parameters.rb +1 -1
  44. data/lib/action_dispatch/http/filter_redirect.rb +1 -1
  45. data/lib/action_dispatch/http/headers.rb +3 -2
  46. data/lib/action_dispatch/http/mime_negotiation.rb +14 -8
  47. data/lib/action_dispatch/http/mime_type.rb +29 -16
  48. data/lib/action_dispatch/http/parameters.rb +1 -19
  49. data/lib/action_dispatch/http/request.rb +24 -8
  50. data/lib/action_dispatch/http/response.rb +17 -16
  51. data/lib/action_dispatch/http/url.rb +3 -2
  52. data/lib/action_dispatch/journey/formatter.rb +53 -28
  53. data/lib/action_dispatch/journey/gtg/builder.rb +22 -36
  54. data/lib/action_dispatch/journey/gtg/simulator.rb +8 -7
  55. data/lib/action_dispatch/journey/gtg/transition_table.rb +6 -4
  56. data/lib/action_dispatch/journey/nfa/dot.rb +0 -11
  57. data/lib/action_dispatch/journey/nodes/node.rb +4 -3
  58. data/lib/action_dispatch/journey/parser.rb +13 -13
  59. data/lib/action_dispatch/journey/parser.y +1 -1
  60. data/lib/action_dispatch/journey/path/pattern.rb +13 -18
  61. data/lib/action_dispatch/journey/route.rb +7 -18
  62. data/lib/action_dispatch/journey/router/utils.rb +6 -4
  63. data/lib/action_dispatch/journey/router.rb +26 -30
  64. data/lib/action_dispatch/journey.rb +0 -2
  65. data/lib/action_dispatch/middleware/actionable_exceptions.rb +1 -1
  66. data/lib/action_dispatch/middleware/cookies.rb +67 -32
  67. data/lib/action_dispatch/middleware/debug_exceptions.rb +8 -15
  68. data/lib/action_dispatch/middleware/debug_view.rb +1 -1
  69. data/lib/action_dispatch/middleware/exception_wrapper.rb +28 -16
  70. data/lib/action_dispatch/middleware/host_authorization.rb +29 -12
  71. data/lib/action_dispatch/middleware/remote_ip.rb +5 -4
  72. data/lib/action_dispatch/middleware/request_id.rb +4 -5
  73. data/lib/action_dispatch/middleware/session/abstract_store.rb +2 -2
  74. data/lib/action_dispatch/middleware/session/cookie_store.rb +2 -2
  75. data/lib/action_dispatch/middleware/ssl.rb +9 -6
  76. data/lib/action_dispatch/middleware/stack.rb +18 -0
  77. data/lib/action_dispatch/middleware/static.rb +154 -93
  78. data/lib/action_dispatch/middleware/templates/rescues/_message_and_suggestions.html.erb +18 -0
  79. data/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb +2 -5
  80. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.html.erb +2 -2
  81. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.text.erb +2 -3
  82. data/lib/action_dispatch/middleware/templates/rescues/layout.erb +88 -8
  83. data/lib/action_dispatch/middleware/templates/rescues/unknown_action.html.erb +1 -1
  84. data/lib/action_dispatch/middleware/templates/routes/_table.html.erb +12 -1
  85. data/lib/action_dispatch/railtie.rb +3 -2
  86. data/lib/action_dispatch/request/session.rb +2 -8
  87. data/lib/action_dispatch/request/utils.rb +26 -2
  88. data/lib/action_dispatch/routing/inspector.rb +8 -7
  89. data/lib/action_dispatch/routing/mapper.rb +102 -71
  90. data/lib/action_dispatch/routing/polymorphic_routes.rb +16 -19
  91. data/lib/action_dispatch/routing/redirection.rb +3 -3
  92. data/lib/action_dispatch/routing/route_set.rb +49 -41
  93. data/lib/action_dispatch/system_test_case.rb +29 -24
  94. data/lib/action_dispatch/system_testing/browser.rb +33 -27
  95. data/lib/action_dispatch/system_testing/driver.rb +6 -7
  96. data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb +47 -6
  97. data/lib/action_dispatch/system_testing/test_helpers/setup_and_teardown.rb +4 -7
  98. data/lib/action_dispatch/testing/assertions/response.rb +2 -4
  99. data/lib/action_dispatch/testing/assertions/routing.rb +5 -5
  100. data/lib/action_dispatch/testing/assertions.rb +1 -1
  101. data/lib/action_dispatch/testing/integration.rb +38 -27
  102. data/lib/action_dispatch/testing/test_process.rb +29 -4
  103. data/lib/action_dispatch/testing/test_request.rb +3 -3
  104. data/lib/action_dispatch.rb +3 -2
  105. data/lib/action_pack/gem_version.rb +3 -3
  106. data/lib/action_pack.rb +1 -1
  107. metadata +23 -24
  108. data/lib/action_controller/metal/force_ssl.rb +0 -58
  109. data/lib/action_dispatch/http/parameter_filter.rb +0 -12
  110. data/lib/action_dispatch/journey/nfa/builder.rb +0 -78
  111. data/lib/action_dispatch/journey/nfa/simulator.rb +0 -47
  112. data/lib/action_dispatch/journey/nfa/transition_table.rb +0 -119
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: a1ce7e505c443ac3626576f8ee7d9f877df0f805a2f200993f67d377ffb39637
4
- data.tar.gz: 63c9a462a845c3775f90d60d4a7554c3ec67c9090d67199210cf9978f8117469
3
+ metadata.gz: 9a4a41e1ca0c25578fbd6a0ea8a05295194ae1bd4583adec81c901d36df926af
4
+ data.tar.gz: 8582c26944953ae947cf95b4582f3b000af462b0786476d4dc84a268963bbdd8
5
5
  SHA512:
6
- metadata.gz: b38a9f6e715de35d394eae37a599abf39e277b3f87916b648ede6489d499c9c638408f6d874eb47a22ce1b1fcf6eeac682125bbec92881b90002baf838df0e7e
7
- data.tar.gz: 28abb4b6e0e463cba47474ea4e2c7d6c5fded3f4bace5853a32acdfd36bc0ebcaa699ea5c7444c5ca9a98210d23f7d63660c9237ba0389ffe2647e22d95d52e3
6
+ metadata.gz: c6ae9cf119acfd74a41566d30f6d499ed3590355134a7a00ebc77b25a8516f1037448bc202c543b0c92cedc842d38e1b787df12f4260bebf5f1595c42c192d2a
7
+ data.tar.gz: 69965930679b64e98df6a5b4edaefa9f15a7c38480fd179507b3a27c663b07478411a6ae04355dd5a30f97f18be8b4441e083b5c97d0015f95963d5adf29dcda
data/CHANGELOG.md CHANGED
@@ -1,458 +1,395 @@
1
- ## Rails 6.0.4.1 (August 19, 2021) ##
1
+ ## Rails 6.1.0.rc1 (November 02, 2020) ##
2
2
 
3
- * [CVE-2021-22942] Fix possible open redirect in Host Authorization middleware.
3
+ * Allow `ActionDispatch::HostAuthorization` to exclude specific requests.
4
4
 
5
- Specially crafted "X-Forwarded-Host" headers in combination with certain
6
- "allowed host" formats can cause the Host Authorization middleware in Action
7
- Pack to redirect users to a malicious website.
5
+ Host Authorization checks can be skipped for specific requests. This allows for health check requests to be permitted for requests with missing or non-matching host headers.
8
6
 
9
- ## Rails 6.0.4 (June 15, 2021) ##
7
+ *Chris Bisnett*
10
8
 
11
- * Accept base64_urlsafe CSRF tokens to make forward compatible.
9
+ * Add `config.action_dispatch.request_id_header` to allow changing the name of
10
+ the unique X-Request-Id header
12
11
 
13
- Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
14
- them difficult to deal with. For example, the common practice of sending
15
- the CSRF token to a browser in a client-readable cookie does not work properly
16
- out of the box: the value has to be url-encoded and decoded to survive transport.
12
+ *Arlston Fernandes*
17
13
 
18
- In Rails 6.1, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently
19
- safe to transport. Validation accepts both urlsafe tokens, and strict-encoded
20
- tokens for backwards compatibility.
14
+ * Deprecate `config.action_dispatch.return_only_media_type_on_content_type`.
21
15
 
22
- In Rails 5.2.5, the CSRF token format is accidentally changed to urlsafe-encoded.
23
- If you upgrade apps from 5.2.5, set the config `urlsafe_csrf_tokens = true`.
16
+ *Rafael Mendonça França*
24
17
 
25
- ```ruby
26
- Rails.application.config.action_controller.urlsafe_csrf_tokens = true
27
- ```
18
+ * Change `ActionDispatch::Response#content_type` to return the full Content-Type header.
28
19
 
29
- *Scott Blum*, *Étienne Barrié*
20
+ *Rafael Mendonça França*
30
21
 
31
- * Signed and encrypted cookies can now store `false` as their value when
32
- `action_dispatch.use_cookies_with_metadata` is enabled.
22
+ * Remove deprecated `ActionDispatch::Http::ParameterFilter`.
33
23
 
34
- *Rolandas Barysas*
24
+ *Rafael Mendonça França*
35
25
 
26
+ * Added support for exclusive no-store Cache-Control header.
36
27
 
37
- ## Rails 6.0.3.7 (May 05, 2021) ##
28
+ If `no-store` is set on Cache-Control header it is exclusive (all other cache directives are dropped).
38
29
 
39
- * Prevent catastrophic backtracking during mime parsing
40
- CVE-2021-22902
30
+ *Chris Kruger*
41
31
 
42
- * Prevent regex DoS in HTTP token authentication
43
- CVE-2021-22904
32
+ * Catch invalid UTF-8 parameters for POST requests and respond with BadRequest.
44
33
 
45
- * Prevent string polymorphic route arguments.
34
+ Additionally, perform `#set_binary_encoding` in `ActionDispatch::Http::Request#GET` and
35
+ `ActionDispatch::Http::Request#POST` prior to validating encoding.
46
36
 
47
- `url_for` supports building polymorphic URLs via an array
48
- of arguments (usually symbols and records). If a developer passes a
49
- user input array, strings can result in unwanted route helper calls.
37
+ *Adrianna Chang*
50
38
 
51
- CVE-2021-22885
39
+ * Allow `assert_recognizes` routing assertions to work on mounted root routes.
52
40
 
53
41
  *Gannon McGibbon*
54
42
 
55
- ## Rails 6.0.3.6 (March 26, 2021) ##
56
-
57
- * No changes.
58
-
59
-
60
- ## Rails 6.0.3.5 (February 10, 2021) ##
61
-
62
- * Prevent open redirect when allowed host starts with a dot
63
-
64
- [CVE-2021-22881]
65
-
66
- Thanks to @tktech (https://hackerone.com/tktech) for reporting this
67
- issue and the patch!
68
-
69
- *Aaron Patterson*
70
-
43
+ * Change default redirection status code for non-GET/HEAD requests to 308 Permanent Redirect for `ActionDispatch::SSL`.
71
44
 
72
- ## Rails 6.0.3.4 (October 07, 2020) ##
45
+ *Alan Tan*, *Oz Ben-David*
73
46
 
74
- * [CVE-2020-8264] Prevent XSS in Actionable Exceptions
47
+ * Fix `follow_redirect!` to follow redirection with same HTTP verb when following
48
+ a 308 redirection.
75
49
 
50
+ *Alan Tan*
76
51
 
77
- ## Rails 6.0.3.3 (September 09, 2020) ##
52
+ * When multiple domains are specified for a cookie, a domain will now be
53
+ chosen only if it is equal to or is a superdomain of the request host.
78
54
 
79
- * No changes.
55
+ *Jonathan Hefner*
80
56
 
57
+ * `ActionDispatch::Static` handles precompiled Brotli (.br) files.
81
58
 
82
- ## Rails 6.0.3.2 (June 17, 2020) ##
59
+ Adds to existing support for precompiled gzip (.gz) files.
60
+ Brotli files are preferred due to much better compression.
83
61
 
84
- * [CVE-2020-8185] Only allow ActionableErrors if show_detailed_exceptions is enabled
62
+ When the browser requests /some.js with `Accept-Encoding: br`,
63
+ we check for public/some.js.br and serve that file, if present, with
64
+ `Content-Encoding: br` and `Vary: Accept-Encoding` headers.
85
65
 
86
- ## Rails 6.0.3.1 (May 18, 2020) ##
66
+ *Ryan Edward Hall*, *Jeremy Daer*
87
67
 
88
- * [CVE-2020-8166] HMAC raw CSRF token before masking it, so it cannot be used to reconstruct a per-form token
68
+ * Add raise_on_missing_translations support for controllers.
89
69
 
90
- * [CVE-2020-8164] Return self when calling #each, #each_pair, and #each_value instead of the raw @parameters hash
70
+ This configuration determines whether an error should be raised for missing translations.
71
+ It can be enabled through `config.i18n.raise_on_missing_translations`. Note that described
72
+ configuration also affects raising error for missing translations in views.
91
73
 
74
+ *fatkodima*
92
75
 
93
- ## Rails 6.0.3 (May 06, 2020) ##
76
+ * Added `compact` and `compact!` to `ActionController::Parameters`.
94
77
 
95
- * Include child session assertion count in ActionDispatch::IntegrationTest
96
-
97
- `IntegrationTest#open_session` uses `dup` to create the new session, which
98
- meant it had its own copy of `@assertions`. This prevented the assertions
99
- from being correctly counted and reported.
100
-
101
- Child sessions now have their `attr_accessor` overriden to delegate to the
102
- root session.
103
-
104
- Fixes #32142
105
-
106
- *Sam Bostock*
107
-
108
-
109
- ## Rails 6.0.2.2 (March 19, 2020) ##
110
-
111
- * No changes.
112
-
113
-
114
- ## Rails 6.0.2.1 (December 18, 2019) ##
78
+ *Eugene Kenny*
115
79
 
116
- * Fix possible information leak / session hijacking vulnerability.
80
+ * Calling `each_pair` or `each_value` on an `ActionController::Parameters`
81
+ without passing a block now returns an enumerator.
117
82
 
118
- The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the
119
- gem dalli to be updated as well.
120
-
121
- CVE-2019-16782.
83
+ *Eugene Kenny*
122
84
 
85
+ * `fixture_file_upload` now uses path relative to `file_fixture_path`
123
86
 
124
- ## Rails 6.0.2 (December 13, 2019) ##
87
+ Previously the path had to be relative to `fixture_path`.
88
+ You can change your existing code as follow:
125
89
 
126
- * Allow using mountable engine route helpers in System Tests.
90
+ ```ruby
91
+ # Before
92
+ fixture_file_upload('files/dog.png')
127
93
 
128
- *Chalo Fernandez*
94
+ # After
95
+ fixture_file_upload('dog.png')
96
+ ```
129
97
 
98
+ *Edouard Chin*
130
99
 
131
- ## Rails 6.0.1 (November 5, 2019) ##
100
+ * Remove deprecated `force_ssl` at the controller level.
132
101
 
133
- * `ActionDispatch::SystemTestCase` now inherits from `ActiveSupport::TestCase`
134
- rather than `ActionDispatch::IntegrationTest`. This permits running jobs in
135
- system tests.
102
+ *Rafael Mendonça França*
136
103
 
137
- *George Claghorn*, *Edouard Chin*
104
+ * The +helper+ class method for controllers loads helper modules specified as
105
+ strings/symbols with `String#constantize` instead of `require_dependency`.
138
106
 
139
- * Registered MIME types may contain extra flags:
107
+ Remember that support for strings/symbols is only a convenient API. You can
108
+ always pass a module object:
140
109
 
141
110
  ```ruby
142
- Mime::Type.register "text/html; fragment", :html_fragment
111
+ helper UtilsHelper
143
112
  ```
144
113
 
145
- *Aaron Patterson*
114
+ which is recommended because it is simple and direct. When a string/symbol
115
+ is received, `helper` just manipulates and inflects the argument to obtain
116
+ that same module object.
146
117
 
118
+ *Xavier Noria*, *Jean Boussier*
147
119
 
148
- ## Rails 6.0.0 (August 16, 2019) ##
120
+ * Correctly identify the entire localhost IPv4 range as trusted proxy.
149
121
 
150
- * No changes.
122
+ *Nick Soracco*
151
123
 
124
+ * `url_for` will now use "https://" as the default protocol when
125
+ `Rails.application.config.force_ssl` is set to true.
152
126
 
153
- ## Rails 6.0.0.rc2 (July 22, 2019) ##
127
+ *Jonathan Hefner*
154
128
 
155
- * Add the ability to set the CSP nonce only to the specified directives.
129
+ * Accept and default to base64_urlsafe CSRF tokens.
156
130
 
157
- Fixes #35137.
158
-
159
- *Yuji Yaginuma*
160
-
161
- * Keep part when scope option has value.
162
-
163
- When a route was defined within an optional scope, if that route didn't
164
- take parameters the scope was lost when using path helpers. This commit
165
- ensures scope is kept both when the route takes parameters or when it
166
- doesn't.
167
-
168
- Fixes #33219
169
-
170
- *Alberto Almagro*
171
-
172
- * Change `ActionDispatch::Response#content_type` to return Content-Type header as it is.
173
-
174
- Previously, `ActionDispatch::Response#content_type` returned value does NOT
175
- contain charset part. This behavior changed to returned Content-Type header
176
- containing charset part as it is.
177
-
178
- If you want just MIME type, please use `ActionDispatch::Response#media_type`
179
- instead.
180
-
181
- Enable `action_dispatch.return_only_media_type_on_content_type` to use this change.
182
- If not enabled, `ActionDispatch::Response#content_type` returns the same
183
- value as before version, but its behavior is deprecate.
184
-
185
- *Yuji Yaginuma*
186
-
187
- * Calling `ActionController::Parameters#transform_keys/!` without a block now returns
188
- an enumerator for the parameters instead of the underlying hash.
131
+ Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
132
+ them difficult to deal with. For example, the common practice of sending
133
+ the CSRF token to a browser in a client-readable cookie does not work properly
134
+ out of the box: the value has to be url-encoded and decoded to survive transport.
189
135
 
190
- *Eugene Kenny*
136
+ Now, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently safe
137
+ to transport. Validation accepts both urlsafe tokens, and strict-encoded tokens
138
+ for backwards compatibility.
191
139
 
192
- * Fix a bug where DebugExceptions throws an error when malformed query parameters are provided
140
+ *Scott Blum*
193
141
 
194
- *Yuki Nishijima*, *Stan Lo*
142
+ * Support rolling deploys for cookie serialization/encryption changes.
195
143
 
144
+ In a distributed configuration like rolling update, users may observe
145
+ both old and new instances during deployment. Users may be served by a
146
+ new instance and then by an old instance.
196
147
 
197
- ## Rails 6.0.0.rc1 (April 24, 2019) ##
148
+ That means when the server changes `cookies_serializer` from `:marshal`
149
+ to `:hybrid` or the server changes `use_authenticated_cookie_encryption`
150
+ from `false` to `true`, users may lose their sessions if they access the
151
+ server during deployment.
198
152
 
199
- * Make system tests take a failed screenshot in a `before_teardown` hook
200
- rather than an `after_teardown` hook.
153
+ We added fallbacks to downgrade the cookie format when necessary during
154
+ deployment, ensuring compatibility on both old and new instances.
201
155
 
202
- This helps minimize the time gap between when an assertion fails and when
203
- the screenshot is taken (reducing the time in which the page could have
204
- been dynamically updated after the assertion failed).
156
+ *Masaki Hara*
205
157
 
206
- *Richard Macklin*
158
+ * `ActionDispatch::Request.remote_ip` has ip address even when all sites are trusted.
207
159
 
208
- * Introduce `ActionDispatch::ActionableExceptions`.
160
+ Before, if all `X-Forwarded-For` sites were trusted, the `remote_ip` would default to `127.0.0.1`.
161
+ Now, the furthest proxy site is used. e.g.: It now gives an ip address when using curl from the load balancer.
209
162
 
210
- The `ActionDispatch::ActionableExceptions` middleware dispatches actions
211
- from `ActiveSupport::ActionableError` descendants.
163
+ *Keenan Brock*
212
164
 
213
- Actionable errors let's you dispatch actions from Rails' error pages.
165
+ * Fix possible information leak / session hijacking vulnerability.
214
166
 
215
- *Vipul A M*, *Yao Jie*, *Genadi Samokovarov*
167
+ The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the
168
+ gem dalli to be updated as well.
216
169
 
217
- * Raise an `ArgumentError` if a resource custom param contains a colon (`:`).
170
+ CVE-2019-16782.
218
171
 
219
- After this change it's not possible anymore to configure routes like this:
172
+ * Include child session assertion count in ActionDispatch::IntegrationTest.
220
173
 
221
- ```
222
- routes.draw do
223
- resources :users, param: 'name/:sneaky'
224
- end
225
- ```
174
+ `IntegrationTest#open_session` uses `dup` to create the new session, which
175
+ meant it had its own copy of `@assertions`. This prevented the assertions
176
+ from being correctly counted and reported.
226
177
 
227
- Fixes #30467.
178
+ Child sessions now have their `attr_accessor` overridden to delegate to the
179
+ root session.
228
180
 
229
- *Josua Schmid*
181
+ Fixes #32142.
230
182
 
183
+ *Sam Bostock*
231
184
 
232
- ## Rails 6.0.0.beta3 (March 11, 2019) ##
185
+ * Add SameSite protection to every written cookie.
233
186
 
234
- * No changes.
187
+ Enabling `SameSite` cookie protection is an addition to CSRF protection,
188
+ where cookies won't be sent by browsers in cross-site POST requests when set to `:lax`.
235
189
 
190
+ `:strict` disables cookies being sent in cross-site GET or POST requests.
236
191
 
237
- ## Rails 6.0.0.beta2 (February 25, 2019) ##
192
+ Passing `:none` disables this protection and is the same as previous versions albeit a `; SameSite=None` is appended to the cookie.
238
193
 
239
- * Make debug exceptions works in an environment where ActiveStorage is not loaded.
194
+ See upgrade instructions in config/initializers/new_framework_defaults_6_1.rb.
240
195
 
241
- *Tomoyuki Kurosawa*
196
+ More info [here](https://tools.ietf.org/html/draft-west-first-party-cookies-07)
242
197
 
243
- * `ActionDispatch::SystemTestCase.driven_by` can now be called with a block
244
- to define specific browser capabilities.
198
+ _NB: Technically already possible as Rack supports SameSite protection, this is to ensure it's applied to all cookies_
245
199
 
246
- *Edouard Chin*
200
+ *Cédric Fabianski*
247
201
 
202
+ * Bring back the feature that allows loading external route files from the router.
248
203
 
249
- ## Rails 6.0.0.beta1 (January 18, 2019) ##
204
+ This feature existed back in 2012 but got reverted with the incentive that
205
+ https://github.com/rails/routing_concerns was a better approach. Turned out
206
+ that this wasn't fully the case and loading external route files from the router
207
+ can be helpful for applications with a really large set of routes.
208
+ Without this feature, application needs to implement routes reloading
209
+ themselves and it's not straightforward.
250
210
 
251
- * Remove deprecated `fragment_cache_key` helper in favor of `combined_fragment_cache_key`.
211
+ ```ruby
212
+ # config/routes.rb
252
213
 
253
- *Rafael Mendonça França*
214
+ Rails.application.routes.draw do
215
+ draw(:admin)
216
+ end
254
217
 
255
- * Remove deprecated methods in `ActionDispatch::TestResponse`.
218
+ # config/routes/admin.rb
256
219
 
257
- `#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
258
- `#successful?`, `not_found?` and `server_error?`.
220
+ get :foo, to: 'foo#bar'
221
+ ```
259
222
 
260
- *Rafael Mendonça França*
223
+ *Yehuda Katz*, *Edouard Chin*
261
224
 
262
- * Introduce `ActionDispatch::HostAuthorization`.
225
+ * Fix system test driver option initialization for non-headless browsers.
263
226
 
264
- This is a new middleware that guards against DNS rebinding attacks by
265
- explicitly permitting the hosts a request can be made to.
227
+ *glaszig*
266
228
 
267
- Each host is checked with the case operator (`#===`) to support `Regexp`,
268
- `Proc`, `IPAddr` and custom objects as host allowances.
229
+ * `redirect_to.action_controller` notifications now include the `ActionDispatch::Request` in
230
+ their payloads as `:request`.
269
231
 
270
- *Genadi Samokovarov*
232
+ *Austin Story*
271
233
 
272
- * Allow using `parsed_body` in `ActionController::TestCase`.
234
+ * `respond_to#any` no longer returns a response's Content-Type based on the
235
+ request format but based on the block given.
273
236
 
274
- In addition to `ActionDispatch::IntegrationTest`, allow using
275
- `parsed_body` in `ActionController::TestCase`:
237
+ Example:
276
238
 
277
- ```
278
- class SomeControllerTest < ActionController::TestCase
279
- def test_some_action
280
- post :action, body: { foo: 'bar' }
281
- assert_equal({ "foo" => "bar" }, response.parsed_body)
239
+ ```ruby
240
+ def my_action
241
+ respond_to do |format|
242
+ format.any { render(json: { foo: 'bar' }) }
243
+ end
282
244
  end
283
- end
284
- ```
285
245
 
286
- Fixes #34676.
287
-
288
- *Tobias Bühlmann*
289
-
290
- * Raise an error on root route naming conflicts.
291
-
292
- Raises an `ArgumentError` when multiple root routes are defined in the
293
- same context instead of assigning nil names to subsequent roots.
294
-
295
- *Gannon McGibbon*
296
-
297
- * Allow rescue from parameter parse errors:
298
-
299
- ```
300
- rescue_from ActionDispatch::Http::Parameters::ParseError do
301
- head :unauthorized
302
- end
246
+ get('my_action.csv')
303
247
  ```
304
248
 
305
- *Gannon McGibbon*, *Josh Cheek*
306
-
307
- * Reset Capybara sessions if failed system test screenshot raising an exception.
308
-
309
- Reset Capybara sessions if `take_failed_screenshot` raise exception
310
- in system test `after_teardown`.
311
-
312
- *Maxim Perepelitsa*
313
-
314
- * Use request object for context if there's no controller
249
+ The previous behaviour was to respond with a `text/csv` Content-Type which
250
+ is inaccurate since a JSON response is being rendered.
315
251
 
316
- There is no controller instance when using a redirect route or a
317
- mounted rack application so pass the request object as the context
318
- when resolving dynamic CSP sources in this scenario.
252
+ Now it correctly returns a `application/json` Content-Type.
319
253
 
320
- Fixes #34200.
321
-
322
- *Andrew White*
323
-
324
- * Apply mapping to symbols returned from dynamic CSP sources
325
-
326
- Previously if a dynamic source returned a symbol such as :self it
327
- would be converted to a string implicitly, e.g:
254
+ *Edouard Chin*
328
255
 
329
- policy.default_src -> { :self }
256
+ * Replaces (back)slashes in failure screenshot image paths with dashes.
330
257
 
331
- would generate the header:
258
+ If a failed test case contained a slash or a backslash, a screenshot would be created in a
259
+ nested directory, causing issues with `tmp:clear`.
332
260
 
333
- Content-Security-Policy: default-src self
261
+ *Damir Zekic*
334
262
 
335
- and now it generates:
263
+ * Add `params.member?` to mimic Hash behavior.
336
264
 
337
- Content-Security-Policy: default-src 'self'
265
+ *Younes Serraj*
338
266
 
339
- *Andrew White*
267
+ * `process_action.action_controller` notifications now include the following in their payloads:
340
268
 
341
- * Add `ActionController::Parameters#each_value`.
269
+ * `:request` - the `ActionDispatch::Request`
270
+ * `:response` - the `ActionDispatch::Response`
342
271
 
343
- *Lukáš Zapletal*
272
+ *George Claghorn*
344
273
 
345
- * Deprecate `ActionDispatch::Http::ParameterFilter` in favor of `ActiveSupport::ParameterFilter`.
274
+ * Updated `ActionDispatch::Request.remote_ip` setter to clear set the instance
275
+ `remote_ip` to `nil` before setting the header that the value is derived
276
+ from.
346
277
 
347
- *Yoshiyuki Kinjo*
278
+ Fixes #37383.
348
279
 
349
- * Encode Content-Disposition filenames on `send_data` and `send_file`.
350
- Previously, `send_data 'data', filename: "\u{3042}.txt"` sends
351
- `"filename=\"\u{3042}.txt\""` as Content-Disposition and it can be
352
- garbled.
353
- Now it follows [RFC 2231](https://tools.ietf.org/html/rfc2231) and
354
- [RFC 5987](https://tools.ietf.org/html/rfc5987) and sends
355
- `"filename=\"%3F.txt\"; filename*=UTF-8''%E3%81%82.txt"`.
356
- Most browsers can find filename correctly and old browsers fallback to ASCII
357
- converted name.
280
+ *Norm Provost*
358
281
 
359
- *Fumiaki Matsushima*
282
+ * `ActionController::Base.log_at` allows setting a different log level per request.
360
283
 
361
- * Expose `ActionController::Parameters#each_key` which allows iterating over
362
- keys without allocating an array.
284
+ ```ruby
285
+ # Use the debug level if a particular cookie is set.
286
+ class ApplicationController < ActionController::Base
287
+ log_at :debug, if: -> { cookies[:debug] }
288
+ end
289
+ ```
363
290
 
364
- *Richard Schneeman*
291
+ *George Claghorn*
365
292
 
366
- * Purpose metadata for signed/encrypted cookies.
293
+ * Allow system test screen shots to be taken more than once in
294
+ a test by prefixing the file name with an incrementing counter.
367
295
 
368
- Rails can now thwart attacks that attempt to copy signed/encrypted value
369
- of a cookie and use it as the value of another cookie.
296
+ Add an environment variable `RAILS_SYSTEM_TESTING_SCREENSHOT_HTML` to
297
+ enable saving of HTML during a screenshot in addition to the image.
298
+ This uses the same image name, with the extension replaced with `.html`
370
299
 
371
- It does so by stashing the cookie-name in the purpose field which is
372
- then signed/encrypted along with the cookie value. Then, on a server-side
373
- read, we verify the cookie-names and discard any attacked cookies.
300
+ *Tom Fakes*
374
301
 
375
- Enable `action_dispatch.use_cookies_with_metadata` to use this feature, which
376
- writes cookies with the new purpose and expiry metadata embedded.
302
+ * Add `Vary: Accept` header when using `Accept` header for response.
377
303
 
378
- *Assain Jaleel*
304
+ For some requests like `/users/1`, Rails uses requests' `Accept`
305
+ header to determine what to return. And if we don't add `Vary`
306
+ in the response header, browsers might accidentally cache different
307
+ types of content, which would cause issues: e.g. javascript got displayed
308
+ instead of html content. This PR fixes these issues by adding `Vary: Accept`
309
+ in these types of requests. For more detailed problem description, please read:
379
310
 
380
- * Raises `ActionController::RespondToMismatchError` with conflicting `respond_to` invocations.
311
+ https://github.com/rails/rails/pull/36213
381
312
 
382
- `respond_to` can match multiple types and lead to undefined behavior when
383
- multiple invocations are made and the types do not match:
313
+ Fixes #25842.
384
314
 
385
- respond_to do |outer_type|
386
- outer_type.js do
387
- respond_to do |inner_type|
388
- inner_type.html { render body: "HTML" }
389
- end
390
- end
391
- end
315
+ *Stan Lo*
392
316
 
393
- *Patrick Toomey*
317
+ * Fix IntegrationTest `follow_redirect!` to follow redirection using the same HTTP verb when following
318
+ a 307 redirection.
394
319
 
395
- * `ActionDispatch::Http::UploadedFile` now delegates `to_path` to its tempfile.
320
+ *Edouard Chin*
396
321
 
397
- This allows uploaded file objects to be passed directly to `File.read`
398
- without raising a `TypeError`:
322
+ * System tests require Capybara 3.26 or newer.
399
323
 
400
- uploaded_file = ActionDispatch::Http::UploadedFile.new(tempfile: tmp_file)
401
- File.read(uploaded_file)
324
+ *George Claghorn*
402
325
 
403
- *Aaron Kromer*
326
+ * Reduced log noise handling ActionController::RoutingErrors.
404
327
 
405
- * Pass along arguments to underlying `get` method in `follow_redirect!`
328
+ *Alberto Fernández-Capel*
406
329
 
407
- Now all arguments passed to `follow_redirect!` are passed to the underlying
408
- `get` method. This for example allows to set custom headers for the
409
- redirection request to the server.
330
+ * Add DSL for configuring HTTP Feature Policy.
410
331
 
411
- follow_redirect!(params: { foo: :bar })
332
+ This new DSL provides a way to configure an HTTP Feature Policy at a
333
+ global or per-controller level. Full details of HTTP Feature Policy
334
+ specification and guidelines can be found at MDN:
412
335
 
413
- *Remo Fritzsche*
336
+ https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy
414
337
 
415
- * Introduce a new error page to when the implicit render page is accessed in the browser.
338
+ Example global policy:
416
339
 
417
- Now instead of showing an error page that with exception and backtraces we now show only
418
- one informative page.
340
+ ```ruby
341
+ Rails.application.config.feature_policy do |f|
342
+ f.camera :none
343
+ f.gyroscope :none
344
+ f.microphone :none
345
+ f.usb :none
346
+ f.fullscreen :self
347
+ f.payment :self, "https://secure.example.com"
348
+ end
349
+ ```
419
350
 
420
- *Vinicius Stock*
351
+ Example controller level policy:
421
352
 
422
- * Introduce `ActionDispatch::DebugExceptions.register_interceptor`.
353
+ ```ruby
354
+ class PagesController < ApplicationController
355
+ feature_policy do |p|
356
+ p.geolocation "https://example.com"
357
+ end
358
+ end
359
+ ```
423
360
 
424
- Exception aware plugin authors can use the newly introduced
425
- `.register_interceptor` method to get the processed exception, instead of
426
- monkey patching DebugExceptions.
361
+ *Jacob Bednarz*
427
362
 
428
- ActionDispatch::DebugExceptions.register_interceptor do |request, exception|
429
- HypoteticalPlugin.capture_exception(request, exception)
430
- end
363
+ * Add the ability to set the CSP nonce only to the specified directives.
431
364
 
432
- *Genadi Samokovarov*
365
+ Fixes #35137.
433
366
 
434
- * Output only one Content-Security-Policy nonce header value per request.
367
+ *Yuji Yaginuma*
435
368
 
436
- Fixes #32597.
369
+ * Keep part when scope option has value.
437
370
 
438
- *Andrey Novikov*, *Andrew White*
371
+ When a route was defined within an optional scope, if that route didn't
372
+ take parameters the scope was lost when using path helpers. This commit
373
+ ensures scope is kept both when the route takes parameters or when it
374
+ doesn't.
439
375
 
440
- * Move default headers configuration into their own module that can be included in controllers.
376
+ Fixes #33219.
441
377
 
442
- *Kevin Deisz*
378
+ *Alberto Almagro*
443
379
 
444
- * Add method `dig` to `session`.
380
+ * Added `deep_transform_keys` and `deep_transform_keys!` methods to ActionController::Parameters.
445
381
 
446
- *claudiob*, *Takumi Shotoku*
382
+ *Gustavo Gutierrez*
447
383
 
448
- * Controller level `force_ssl` has been deprecated in favor of
449
- `config.force_ssl`.
384
+ * Calling `ActionController::Parameters#transform_keys`/`!` without a block now returns
385
+ an enumerator for the parameters instead of the underlying hash.
450
386
 
451
- *Derek Prior*
387
+ *Eugene Kenny*
452
388
 
453
- * Rails 6 requires Ruby 2.5.0 or newer.
389
+ * Fix strong parameters blocks all attributes even when only some keys are invalid (non-numerical).
390
+ It should only block invalid key's values instead.
454
391
 
455
- *Jeremy Daer*, *Kasper Timm Hansen*
392
+ *Stan Lo*
456
393
 
457
394
 
458
- Please check [5-2-stable](https://github.com/rails/rails/blob/5-2-stable/actionpack/CHANGELOG.md) for previous changes.
395
+ Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionpack/CHANGELOG.md) for previous changes.