actionpack 6.0.3 → 6.1.0.rc1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of actionpack might be problematic. Click here for more details.

Files changed (114) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +246 -217
  3. data/MIT-LICENSE +1 -1
  4. data/lib/abstract_controller.rb +1 -0
  5. data/lib/abstract_controller/base.rb +35 -2
  6. data/lib/abstract_controller/callbacks.rb +2 -2
  7. data/lib/abstract_controller/helpers.rb +105 -90
  8. data/lib/abstract_controller/rendering.rb +9 -9
  9. data/lib/abstract_controller/translation.rb +8 -2
  10. data/lib/action_controller.rb +2 -3
  11. data/lib/action_controller/api.rb +2 -2
  12. data/lib/action_controller/base.rb +4 -2
  13. data/lib/action_controller/caching.rb +0 -1
  14. data/lib/action_controller/log_subscriber.rb +3 -3
  15. data/lib/action_controller/metal.rb +2 -2
  16. data/lib/action_controller/metal/conditional_get.rb +10 -2
  17. data/lib/action_controller/metal/content_security_policy.rb +1 -1
  18. data/lib/action_controller/metal/data_streaming.rb +1 -1
  19. data/lib/action_controller/metal/etag_with_template_digest.rb +2 -4
  20. data/lib/action_controller/metal/exceptions.rb +33 -0
  21. data/lib/action_controller/metal/feature_policy.rb +46 -0
  22. data/lib/action_controller/metal/head.rb +7 -4
  23. data/lib/action_controller/metal/helpers.rb +11 -1
  24. data/lib/action_controller/metal/http_authentication.rb +4 -2
  25. data/lib/action_controller/metal/implicit_render.rb +1 -1
  26. data/lib/action_controller/metal/instrumentation.rb +11 -9
  27. data/lib/action_controller/metal/live.rb +1 -1
  28. data/lib/action_controller/metal/logging.rb +20 -0
  29. data/lib/action_controller/metal/mime_responds.rb +6 -2
  30. data/lib/action_controller/metal/parameter_encoding.rb +35 -4
  31. data/lib/action_controller/metal/params_wrapper.rb +14 -8
  32. data/lib/action_controller/metal/redirecting.rb +1 -1
  33. data/lib/action_controller/metal/rendering.rb +6 -0
  34. data/lib/action_controller/metal/request_forgery_protection.rb +74 -30
  35. data/lib/action_controller/metal/rescue.rb +1 -1
  36. data/lib/action_controller/metal/strong_parameters.rb +107 -15
  37. data/lib/action_controller/renderer.rb +24 -13
  38. data/lib/action_controller/test_case.rb +62 -56
  39. data/lib/action_dispatch.rb +3 -2
  40. data/lib/action_dispatch/http/cache.rb +12 -10
  41. data/lib/action_dispatch/http/content_disposition.rb +2 -2
  42. data/lib/action_dispatch/http/content_security_policy.rb +5 -1
  43. data/lib/action_dispatch/http/feature_policy.rb +168 -0
  44. data/lib/action_dispatch/http/filter_parameters.rb +1 -1
  45. data/lib/action_dispatch/http/filter_redirect.rb +1 -1
  46. data/lib/action_dispatch/http/headers.rb +3 -2
  47. data/lib/action_dispatch/http/mime_negotiation.rb +20 -8
  48. data/lib/action_dispatch/http/mime_type.rb +28 -15
  49. data/lib/action_dispatch/http/parameters.rb +1 -19
  50. data/lib/action_dispatch/http/request.rb +26 -8
  51. data/lib/action_dispatch/http/response.rb +17 -16
  52. data/lib/action_dispatch/http/url.rb +3 -2
  53. data/lib/action_dispatch/journey.rb +0 -2
  54. data/lib/action_dispatch/journey/formatter.rb +53 -28
  55. data/lib/action_dispatch/journey/gtg/builder.rb +22 -36
  56. data/lib/action_dispatch/journey/gtg/simulator.rb +8 -7
  57. data/lib/action_dispatch/journey/gtg/transition_table.rb +6 -4
  58. data/lib/action_dispatch/journey/nfa/dot.rb +0 -11
  59. data/lib/action_dispatch/journey/nodes/node.rb +4 -3
  60. data/lib/action_dispatch/journey/parser.rb +13 -13
  61. data/lib/action_dispatch/journey/parser.y +1 -1
  62. data/lib/action_dispatch/journey/path/pattern.rb +13 -18
  63. data/lib/action_dispatch/journey/route.rb +7 -18
  64. data/lib/action_dispatch/journey/router.rb +26 -30
  65. data/lib/action_dispatch/journey/router/utils.rb +6 -4
  66. data/lib/action_dispatch/middleware/actionable_exceptions.rb +9 -2
  67. data/lib/action_dispatch/middleware/cookies.rb +74 -33
  68. data/lib/action_dispatch/middleware/debug_exceptions.rb +10 -17
  69. data/lib/action_dispatch/middleware/debug_view.rb +1 -1
  70. data/lib/action_dispatch/middleware/exception_wrapper.rb +29 -17
  71. data/lib/action_dispatch/middleware/host_authorization.rb +23 -3
  72. data/lib/action_dispatch/middleware/public_exceptions.rb +1 -1
  73. data/lib/action_dispatch/middleware/remote_ip.rb +5 -4
  74. data/lib/action_dispatch/middleware/request_id.rb +4 -5
  75. data/lib/action_dispatch/middleware/session/abstract_store.rb +2 -2
  76. data/lib/action_dispatch/middleware/session/cookie_store.rb +2 -2
  77. data/lib/action_dispatch/middleware/ssl.rb +9 -6
  78. data/lib/action_dispatch/middleware/stack.rb +18 -0
  79. data/lib/action_dispatch/middleware/static.rb +154 -93
  80. data/lib/action_dispatch/middleware/templates/rescues/_message_and_suggestions.html.erb +18 -0
  81. data/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb +2 -5
  82. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.html.erb +2 -2
  83. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.text.erb +2 -2
  84. data/lib/action_dispatch/middleware/templates/rescues/layout.erb +88 -8
  85. data/lib/action_dispatch/middleware/templates/rescues/unknown_action.html.erb +1 -1
  86. data/lib/action_dispatch/middleware/templates/routes/_table.html.erb +12 -1
  87. data/lib/action_dispatch/railtie.rb +3 -2
  88. data/lib/action_dispatch/request/session.rb +2 -8
  89. data/lib/action_dispatch/request/utils.rb +26 -2
  90. data/lib/action_dispatch/routing/inspector.rb +8 -7
  91. data/lib/action_dispatch/routing/mapper.rb +102 -71
  92. data/lib/action_dispatch/routing/polymorphic_routes.rb +12 -11
  93. data/lib/action_dispatch/routing/redirection.rb +3 -3
  94. data/lib/action_dispatch/routing/route_set.rb +49 -41
  95. data/lib/action_dispatch/routing/url_for.rb +1 -0
  96. data/lib/action_dispatch/system_test_case.rb +29 -24
  97. data/lib/action_dispatch/system_testing/browser.rb +33 -27
  98. data/lib/action_dispatch/system_testing/driver.rb +6 -7
  99. data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb +47 -6
  100. data/lib/action_dispatch/system_testing/test_helpers/setup_and_teardown.rb +4 -7
  101. data/lib/action_dispatch/testing/assertions.rb +1 -1
  102. data/lib/action_dispatch/testing/assertions/response.rb +2 -4
  103. data/lib/action_dispatch/testing/assertions/routing.rb +5 -5
  104. data/lib/action_dispatch/testing/integration.rb +38 -27
  105. data/lib/action_dispatch/testing/test_process.rb +29 -4
  106. data/lib/action_dispatch/testing/test_request.rb +3 -3
  107. data/lib/action_pack.rb +1 -1
  108. data/lib/action_pack/gem_version.rb +3 -3
  109. metadata +20 -21
  110. data/lib/action_controller/metal/force_ssl.rb +0 -58
  111. data/lib/action_dispatch/http/parameter_filter.rb +0 -12
  112. data/lib/action_dispatch/journey/nfa/builder.rb +0 -78
  113. data/lib/action_dispatch/journey/nfa/simulator.rb +0 -47
  114. data/lib/action_dispatch/journey/nfa/transition_table.rb +0 -119
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 83e2bf0b5fc55b0a124c11102a56872aee141828a3cfe5cd23ed4fade856a989
4
- data.tar.gz: 3b647d17bd0ed5076ac0a12966cdfa271b1a4e67a680df373c0553beeaab83c3
3
+ metadata.gz: 9a4a41e1ca0c25578fbd6a0ea8a05295194ae1bd4583adec81c901d36df926af
4
+ data.tar.gz: 8582c26944953ae947cf95b4582f3b000af462b0786476d4dc84a268963bbdd8
5
5
  SHA512:
6
- metadata.gz: c7ff17b8e1abc4205e8c52f741a09b77cac48df7343db0d5c76d8946e47ac51d41b182b464e19e3c3de2004e558dd5161bbbb1c8c45f33efeda0ab1037d28111
7
- data.tar.gz: be46931210b005daf32e2c9f7408a050e41806d554d1b5d24056557a84bd76ebc20911a83ef1c8e727c43798f4ff3836acd03d82a4f07ae3562be52346a051a8
6
+ metadata.gz: c6ae9cf119acfd74a41566d30f6d499ed3590355134a7a00ebc77b25a8516f1037448bc202c543b0c92cedc842d38e1b787df12f4260bebf5f1595c42c192d2a
7
+ data.tar.gz: 69965930679b64e98df6a5b4edaefa9f15a7c38480fd179507b3a27c663b07478411a6ae04355dd5a30f97f18be8b4441e083b5c97d0015f95963d5adf29dcda
@@ -1,366 +1,395 @@
1
- ## Rails 6.0.3 (May 06, 2020) ##
1
+ ## Rails 6.1.0.rc1 (November 02, 2020) ##
2
2
 
3
- * Include child session assertion count in ActionDispatch::IntegrationTest
3
+ * Allow `ActionDispatch::HostAuthorization` to exclude specific requests.
4
4
 
5
- `IntegrationTest#open_session` uses `dup` to create the new session, which
6
- meant it had its own copy of `@assertions`. This prevented the assertions
7
- from being correctly counted and reported.
5
+ Host Authorization checks can be skipped for specific requests. This allows for health check requests to be permitted for requests with missing or non-matching host headers.
8
6
 
9
- Child sessions now have their `attr_accessor` overriden to delegate to the
10
- root session.
7
+ *Chris Bisnett*
11
8
 
12
- Fixes #32142
9
+ * Add `config.action_dispatch.request_id_header` to allow changing the name of
10
+ the unique X-Request-Id header
13
11
 
14
- *Sam Bostock*
12
+ *Arlston Fernandes*
15
13
 
14
+ * Deprecate `config.action_dispatch.return_only_media_type_on_content_type`.
16
15
 
17
- ## Rails 6.0.2.2 (March 19, 2020) ##
16
+ *Rafael Mendonça França*
18
17
 
19
- * No changes.
18
+ * Change `ActionDispatch::Response#content_type` to return the full Content-Type header.
20
19
 
20
+ *Rafael Mendonça França*
21
21
 
22
- ## Rails 6.0.2.1 (December 18, 2019) ##
22
+ * Remove deprecated `ActionDispatch::Http::ParameterFilter`.
23
23
 
24
- * Fix possible information leak / session hijacking vulnerability.
24
+ *Rafael Mendonça França*
25
25
 
26
- The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the
27
- gem dalli to be updated as well.
26
+ * Added support for exclusive no-store Cache-Control header.
28
27
 
29
- CVE-2019-16782.
28
+ If `no-store` is set on Cache-Control header it is exclusive (all other cache directives are dropped).
30
29
 
30
+ *Chris Kruger*
31
31
 
32
- ## Rails 6.0.2 (December 13, 2019) ##
32
+ * Catch invalid UTF-8 parameters for POST requests and respond with BadRequest.
33
33
 
34
- * Allow using mountable engine route helpers in System Tests.
34
+ Additionally, perform `#set_binary_encoding` in `ActionDispatch::Http::Request#GET` and
35
+ `ActionDispatch::Http::Request#POST` prior to validating encoding.
35
36
 
36
- *Chalo Fernandez*
37
+ *Adrianna Chang*
37
38
 
39
+ * Allow `assert_recognizes` routing assertions to work on mounted root routes.
38
40
 
39
- ## Rails 6.0.1 (November 5, 2019) ##
41
+ *Gannon McGibbon*
40
42
 
41
- * `ActionDispatch::SystemTestCase` now inherits from `ActiveSupport::TestCase`
42
- rather than `ActionDispatch::IntegrationTest`. This permits running jobs in
43
- system tests.
43
+ * Change default redirection status code for non-GET/HEAD requests to 308 Permanent Redirect for `ActionDispatch::SSL`.
44
44
 
45
- *George Claghorn*, *Edouard Chin*
45
+ *Alan Tan*, *Oz Ben-David*
46
46
 
47
- * Registered MIME types may contain extra flags:
47
+ * Fix `follow_redirect!` to follow redirection with same HTTP verb when following
48
+ a 308 redirection.
48
49
 
49
- ```ruby
50
- Mime::Type.register "text/html; fragment", :html_fragment
51
- ```
50
+ *Alan Tan*
52
51
 
53
- *Aaron Patterson*
52
+ * When multiple domains are specified for a cookie, a domain will now be
53
+ chosen only if it is equal to or is a superdomain of the request host.
54
54
 
55
+ *Jonathan Hefner*
55
56
 
56
- ## Rails 6.0.0 (August 16, 2019) ##
57
+ * `ActionDispatch::Static` handles precompiled Brotli (.br) files.
57
58
 
58
- * No changes.
59
+ Adds to existing support for precompiled gzip (.gz) files.
60
+ Brotli files are preferred due to much better compression.
59
61
 
62
+ When the browser requests /some.js with `Accept-Encoding: br`,
63
+ we check for public/some.js.br and serve that file, if present, with
64
+ `Content-Encoding: br` and `Vary: Accept-Encoding` headers.
60
65
 
61
- ## Rails 6.0.0.rc2 (July 22, 2019) ##
66
+ *Ryan Edward Hall*, *Jeremy Daer*
62
67
 
63
- * Add the ability to set the CSP nonce only to the specified directives.
68
+ * Add raise_on_missing_translations support for controllers.
64
69
 
65
- Fixes #35137.
70
+ This configuration determines whether an error should be raised for missing translations.
71
+ It can be enabled through `config.i18n.raise_on_missing_translations`. Note that described
72
+ configuration also affects raising error for missing translations in views.
66
73
 
67
- *Yuji Yaginuma*
74
+ *fatkodima*
68
75
 
69
- * Keep part when scope option has value.
70
-
71
- When a route was defined within an optional scope, if that route didn't
72
- take parameters the scope was lost when using path helpers. This commit
73
- ensures scope is kept both when the route takes parameters or when it
74
- doesn't.
76
+ * Added `compact` and `compact!` to `ActionController::Parameters`.
75
77
 
76
- Fixes #33219
78
+ *Eugene Kenny*
77
79
 
78
- *Alberto Almagro*
80
+ * Calling `each_pair` or `each_value` on an `ActionController::Parameters`
81
+ without passing a block now returns an enumerator.
79
82
 
80
- * Change `ActionDispatch::Response#content_type` to return Content-Type header as it is.
83
+ *Eugene Kenny*
81
84
 
82
- Previously, `ActionDispatch::Response#content_type` returned value does NOT
83
- contain charset part. This behavior changed to returned Content-Type header
84
- containing charset part as it is.
85
+ * `fixture_file_upload` now uses path relative to `file_fixture_path`
85
86
 
86
- If you want just MIME type, please use `ActionDispatch::Response#media_type`
87
- instead.
87
+ Previously the path had to be relative to `fixture_path`.
88
+ You can change your existing code as follow:
88
89
 
89
- Enable `action_dispatch.return_only_media_type_on_content_type` to use this change.
90
- If not enabled, `ActionDispatch::Response#content_type` returns the same
91
- value as before version, but its behavior is deprecate.
90
+ ```ruby
91
+ # Before
92
+ fixture_file_upload('files/dog.png')
92
93
 
93
- *Yuji Yaginuma*
94
+ # After
95
+ fixture_file_upload('dog.png')
96
+ ```
94
97
 
95
- * Calling `ActionController::Parameters#transform_keys/!` without a block now returns
96
- an enumerator for the parameters instead of the underlying hash.
98
+ *Edouard Chin*
97
99
 
98
- *Eugene Kenny*
100
+ * Remove deprecated `force_ssl` at the controller level.
99
101
 
100
- * Fix a bug where DebugExceptions throws an error when malformed query parameters are provided
102
+ *Rafael Mendonça França*
101
103
 
102
- *Yuki Nishijima*, *Stan Lo*
104
+ * The +helper+ class method for controllers loads helper modules specified as
105
+ strings/symbols with `String#constantize` instead of `require_dependency`.
103
106
 
107
+ Remember that support for strings/symbols is only a convenient API. You can
108
+ always pass a module object:
104
109
 
105
- ## Rails 6.0.0.rc1 (April 24, 2019) ##
110
+ ```ruby
111
+ helper UtilsHelper
112
+ ```
106
113
 
107
- * Make system tests take a failed screenshot in a `before_teardown` hook
108
- rather than an `after_teardown` hook.
114
+ which is recommended because it is simple and direct. When a string/symbol
115
+ is received, `helper` just manipulates and inflects the argument to obtain
116
+ that same module object.
109
117
 
110
- This helps minimize the time gap between when an assertion fails and when
111
- the screenshot is taken (reducing the time in which the page could have
112
- been dynamically updated after the assertion failed).
118
+ *Xavier Noria*, *Jean Boussier*
113
119
 
114
- *Richard Macklin*
120
+ * Correctly identify the entire localhost IPv4 range as trusted proxy.
115
121
 
116
- * Introduce `ActionDispatch::ActionableExceptions`.
122
+ *Nick Soracco*
117
123
 
118
- The `ActionDispatch::ActionableExceptions` middleware dispatches actions
119
- from `ActiveSupport::ActionableError` descendants.
124
+ * `url_for` will now use "https://" as the default protocol when
125
+ `Rails.application.config.force_ssl` is set to true.
120
126
 
121
- Actionable errors let's you dispatch actions from Rails' error pages.
127
+ *Jonathan Hefner*
122
128
 
123
- *Vipul A M*, *Yao Jie*, *Genadi Samokovarov*
129
+ * Accept and default to base64_urlsafe CSRF tokens.
124
130
 
125
- * Raise an `ArgumentError` if a resource custom param contains a colon (`:`).
131
+ Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
132
+ them difficult to deal with. For example, the common practice of sending
133
+ the CSRF token to a browser in a client-readable cookie does not work properly
134
+ out of the box: the value has to be url-encoded and decoded to survive transport.
126
135
 
127
- After this change it's not possible anymore to configure routes like this:
136
+ Now, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently safe
137
+ to transport. Validation accepts both urlsafe tokens, and strict-encoded tokens
138
+ for backwards compatibility.
128
139
 
129
- ```
130
- routes.draw do
131
- resources :users, param: 'name/:sneaky'
132
- end
133
- ```
140
+ *Scott Blum*
134
141
 
135
- Fixes #30467.
142
+ * Support rolling deploys for cookie serialization/encryption changes.
136
143
 
137
- *Josua Schmid*
144
+ In a distributed configuration like rolling update, users may observe
145
+ both old and new instances during deployment. Users may be served by a
146
+ new instance and then by an old instance.
138
147
 
148
+ That means when the server changes `cookies_serializer` from `:marshal`
149
+ to `:hybrid` or the server changes `use_authenticated_cookie_encryption`
150
+ from `false` to `true`, users may lose their sessions if they access the
151
+ server during deployment.
139
152
 
140
- ## Rails 6.0.0.beta3 (March 11, 2019) ##
153
+ We added fallbacks to downgrade the cookie format when necessary during
154
+ deployment, ensuring compatibility on both old and new instances.
141
155
 
142
- * No changes.
156
+ *Masaki Hara*
143
157
 
158
+ * `ActionDispatch::Request.remote_ip` has ip address even when all sites are trusted.
144
159
 
145
- ## Rails 6.0.0.beta2 (February 25, 2019) ##
160
+ Before, if all `X-Forwarded-For` sites were trusted, the `remote_ip` would default to `127.0.0.1`.
161
+ Now, the furthest proxy site is used. e.g.: It now gives an ip address when using curl from the load balancer.
146
162
 
147
- * Make debug exceptions works in an environment where ActiveStorage is not loaded.
163
+ *Keenan Brock*
148
164
 
149
- *Tomoyuki Kurosawa*
165
+ * Fix possible information leak / session hijacking vulnerability.
150
166
 
151
- * `ActionDispatch::SystemTestCase.driven_by` can now be called with a block
152
- to define specific browser capabilities.
167
+ The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the
168
+ gem dalli to be updated as well.
153
169
 
154
- *Edouard Chin*
170
+ CVE-2019-16782.
155
171
 
172
+ * Include child session assertion count in ActionDispatch::IntegrationTest.
156
173
 
157
- ## Rails 6.0.0.beta1 (January 18, 2019) ##
174
+ `IntegrationTest#open_session` uses `dup` to create the new session, which
175
+ meant it had its own copy of `@assertions`. This prevented the assertions
176
+ from being correctly counted and reported.
158
177
 
159
- * Remove deprecated `fragment_cache_key` helper in favor of `combined_fragment_cache_key`.
178
+ Child sessions now have their `attr_accessor` overridden to delegate to the
179
+ root session.
160
180
 
161
- *Rafael Mendonça França*
181
+ Fixes #32142.
162
182
 
163
- * Remove deprecated methods in `ActionDispatch::TestResponse`.
183
+ *Sam Bostock*
164
184
 
165
- `#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
166
- `#successful?`, `not_found?` and `server_error?`.
185
+ * Add SameSite protection to every written cookie.
167
186
 
168
- *Rafael Mendonça França*
187
+ Enabling `SameSite` cookie protection is an addition to CSRF protection,
188
+ where cookies won't be sent by browsers in cross-site POST requests when set to `:lax`.
169
189
 
170
- * Introduce `ActionDispatch::HostAuthorization`.
190
+ `:strict` disables cookies being sent in cross-site GET or POST requests.
171
191
 
172
- This is a new middleware that guards against DNS rebinding attacks by
173
- explicitly permitting the hosts a request can be made to.
192
+ Passing `:none` disables this protection and is the same as previous versions albeit a `; SameSite=None` is appended to the cookie.
174
193
 
175
- Each host is checked with the case operator (`#===`) to support `Regexp`,
176
- `Proc`, `IPAddr` and custom objects as host allowances.
194
+ See upgrade instructions in config/initializers/new_framework_defaults_6_1.rb.
177
195
 
178
- *Genadi Samokovarov*
196
+ More info [here](https://tools.ietf.org/html/draft-west-first-party-cookies-07)
179
197
 
180
- * Allow using `parsed_body` in `ActionController::TestCase`.
198
+ _NB: Technically already possible as Rack supports SameSite protection, this is to ensure it's applied to all cookies_
181
199
 
182
- In addition to `ActionDispatch::IntegrationTest`, allow using
183
- `parsed_body` in `ActionController::TestCase`:
200
+ *Cédric Fabianski*
184
201
 
185
- ```
186
- class SomeControllerTest < ActionController::TestCase
187
- def test_some_action
188
- post :action, body: { foo: 'bar' }
189
- assert_equal({ "foo" => "bar" }, response.parsed_body)
190
- end
191
- end
192
- ```
202
+ * Bring back the feature that allows loading external route files from the router.
193
203
 
194
- Fixes #34676.
204
+ This feature existed back in 2012 but got reverted with the incentive that
205
+ https://github.com/rails/routing_concerns was a better approach. Turned out
206
+ that this wasn't fully the case and loading external route files from the router
207
+ can be helpful for applications with a really large set of routes.
208
+ Without this feature, application needs to implement routes reloading
209
+ themselves and it's not straightforward.
195
210
 
196
- *Tobias Bühlmann*
211
+ ```ruby
212
+ # config/routes.rb
197
213
 
198
- * Raise an error on root route naming conflicts.
214
+ Rails.application.routes.draw do
215
+ draw(:admin)
216
+ end
199
217
 
200
- Raises an `ArgumentError` when multiple root routes are defined in the
201
- same context instead of assigning nil names to subsequent roots.
218
+ # config/routes/admin.rb
202
219
 
203
- *Gannon McGibbon*
220
+ get :foo, to: 'foo#bar'
221
+ ```
204
222
 
205
- * Allow rescue from parameter parse errors:
223
+ *Yehuda Katz*, *Edouard Chin*
206
224
 
207
- ```
208
- rescue_from ActionDispatch::Http::Parameters::ParseError do
209
- head :unauthorized
210
- end
211
- ```
225
+ * Fix system test driver option initialization for non-headless browsers.
212
226
 
213
- *Gannon McGibbon*, *Josh Cheek*
227
+ *glaszig*
214
228
 
215
- * Reset Capybara sessions if failed system test screenshot raising an exception.
229
+ * `redirect_to.action_controller` notifications now include the `ActionDispatch::Request` in
230
+ their payloads as `:request`.
216
231
 
217
- Reset Capybara sessions if `take_failed_screenshot` raise exception
218
- in system test `after_teardown`.
232
+ *Austin Story*
219
233
 
220
- *Maxim Perepelitsa*
234
+ * `respond_to#any` no longer returns a response's Content-Type based on the
235
+ request format but based on the block given.
221
236
 
222
- * Use request object for context if there's no controller
237
+ Example:
223
238
 
224
- There is no controller instance when using a redirect route or a
225
- mounted rack application so pass the request object as the context
226
- when resolving dynamic CSP sources in this scenario.
239
+ ```ruby
240
+ def my_action
241
+ respond_to do |format|
242
+ format.any { render(json: { foo: 'bar' }) }
243
+ end
244
+ end
227
245
 
228
- Fixes #34200.
246
+ get('my_action.csv')
247
+ ```
229
248
 
230
- *Andrew White*
249
+ The previous behaviour was to respond with a `text/csv` Content-Type which
250
+ is inaccurate since a JSON response is being rendered.
231
251
 
232
- * Apply mapping to symbols returned from dynamic CSP sources
252
+ Now it correctly returns a `application/json` Content-Type.
233
253
 
234
- Previously if a dynamic source returned a symbol such as :self it
235
- would be converted to a string implicitly, e.g:
254
+ *Edouard Chin*
236
255
 
237
- policy.default_src -> { :self }
256
+ * Replaces (back)slashes in failure screenshot image paths with dashes.
238
257
 
239
- would generate the header:
258
+ If a failed test case contained a slash or a backslash, a screenshot would be created in a
259
+ nested directory, causing issues with `tmp:clear`.
240
260
 
241
- Content-Security-Policy: default-src self
261
+ *Damir Zekic*
242
262
 
243
- and now it generates:
263
+ * Add `params.member?` to mimic Hash behavior.
244
264
 
245
- Content-Security-Policy: default-src 'self'
265
+ *Younes Serraj*
246
266
 
247
- *Andrew White*
267
+ * `process_action.action_controller` notifications now include the following in their payloads:
248
268
 
249
- * Add `ActionController::Parameters#each_value`.
269
+ * `:request` - the `ActionDispatch::Request`
270
+ * `:response` - the `ActionDispatch::Response`
250
271
 
251
- *Lukáš Zapletal*
272
+ *George Claghorn*
252
273
 
253
- * Deprecate `ActionDispatch::Http::ParameterFilter` in favor of `ActiveSupport::ParameterFilter`.
274
+ * Updated `ActionDispatch::Request.remote_ip` setter to clear set the instance
275
+ `remote_ip` to `nil` before setting the header that the value is derived
276
+ from.
254
277
 
255
- *Yoshiyuki Kinjo*
278
+ Fixes #37383.
256
279
 
257
- * Encode Content-Disposition filenames on `send_data` and `send_file`.
258
- Previously, `send_data 'data', filename: "\u{3042}.txt"` sends
259
- `"filename=\"\u{3042}.txt\""` as Content-Disposition and it can be
260
- garbled.
261
- Now it follows [RFC 2231](https://tools.ietf.org/html/rfc2231) and
262
- [RFC 5987](https://tools.ietf.org/html/rfc5987) and sends
263
- `"filename=\"%3F.txt\"; filename*=UTF-8''%E3%81%82.txt"`.
264
- Most browsers can find filename correctly and old browsers fallback to ASCII
265
- converted name.
280
+ *Norm Provost*
266
281
 
267
- *Fumiaki Matsushima*
282
+ * `ActionController::Base.log_at` allows setting a different log level per request.
268
283
 
269
- * Expose `ActionController::Parameters#each_key` which allows iterating over
270
- keys without allocating an array.
284
+ ```ruby
285
+ # Use the debug level if a particular cookie is set.
286
+ class ApplicationController < ActionController::Base
287
+ log_at :debug, if: -> { cookies[:debug] }
288
+ end
289
+ ```
271
290
 
272
- *Richard Schneeman*
291
+ *George Claghorn*
273
292
 
274
- * Purpose metadata for signed/encrypted cookies.
293
+ * Allow system test screen shots to be taken more than once in
294
+ a test by prefixing the file name with an incrementing counter.
275
295
 
276
- Rails can now thwart attacks that attempt to copy signed/encrypted value
277
- of a cookie and use it as the value of another cookie.
296
+ Add an environment variable `RAILS_SYSTEM_TESTING_SCREENSHOT_HTML` to
297
+ enable saving of HTML during a screenshot in addition to the image.
298
+ This uses the same image name, with the extension replaced with `.html`
278
299
 
279
- It does so by stashing the cookie-name in the purpose field which is
280
- then signed/encrypted along with the cookie value. Then, on a server-side
281
- read, we verify the cookie-names and discard any attacked cookies.
300
+ *Tom Fakes*
282
301
 
283
- Enable `action_dispatch.use_cookies_with_metadata` to use this feature, which
284
- writes cookies with the new purpose and expiry metadata embedded.
302
+ * Add `Vary: Accept` header when using `Accept` header for response.
285
303
 
286
- *Assain Jaleel*
304
+ For some requests like `/users/1`, Rails uses requests' `Accept`
305
+ header to determine what to return. And if we don't add `Vary`
306
+ in the response header, browsers might accidentally cache different
307
+ types of content, which would cause issues: e.g. javascript got displayed
308
+ instead of html content. This PR fixes these issues by adding `Vary: Accept`
309
+ in these types of requests. For more detailed problem description, please read:
287
310
 
288
- * Raises `ActionController::RespondToMismatchError` with conflicting `respond_to` invocations.
311
+ https://github.com/rails/rails/pull/36213
289
312
 
290
- `respond_to` can match multiple types and lead to undefined behavior when
291
- multiple invocations are made and the types do not match:
313
+ Fixes #25842.
292
314
 
293
- respond_to do |outer_type|
294
- outer_type.js do
295
- respond_to do |inner_type|
296
- inner_type.html { render body: "HTML" }
297
- end
298
- end
299
- end
315
+ *Stan Lo*
300
316
 
301
- *Patrick Toomey*
317
+ * Fix IntegrationTest `follow_redirect!` to follow redirection using the same HTTP verb when following
318
+ a 307 redirection.
302
319
 
303
- * `ActionDispatch::Http::UploadedFile` now delegates `to_path` to its tempfile.
320
+ *Edouard Chin*
304
321
 
305
- This allows uploaded file objects to be passed directly to `File.read`
306
- without raising a `TypeError`:
322
+ * System tests require Capybara 3.26 or newer.
307
323
 
308
- uploaded_file = ActionDispatch::Http::UploadedFile.new(tempfile: tmp_file)
309
- File.read(uploaded_file)
324
+ *George Claghorn*
310
325
 
311
- *Aaron Kromer*
326
+ * Reduced log noise handling ActionController::RoutingErrors.
312
327
 
313
- * Pass along arguments to underlying `get` method in `follow_redirect!`
328
+ *Alberto Fernández-Capel*
314
329
 
315
- Now all arguments passed to `follow_redirect!` are passed to the underlying
316
- `get` method. This for example allows to set custom headers for the
317
- redirection request to the server.
330
+ * Add DSL for configuring HTTP Feature Policy.
318
331
 
319
- follow_redirect!(params: { foo: :bar })
332
+ This new DSL provides a way to configure an HTTP Feature Policy at a
333
+ global or per-controller level. Full details of HTTP Feature Policy
334
+ specification and guidelines can be found at MDN:
320
335
 
321
- *Remo Fritzsche*
336
+ https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy
322
337
 
323
- * Introduce a new error page to when the implicit render page is accessed in the browser.
338
+ Example global policy:
324
339
 
325
- Now instead of showing an error page that with exception and backtraces we now show only
326
- one informative page.
340
+ ```ruby
341
+ Rails.application.config.feature_policy do |f|
342
+ f.camera :none
343
+ f.gyroscope :none
344
+ f.microphone :none
345
+ f.usb :none
346
+ f.fullscreen :self
347
+ f.payment :self, "https://secure.example.com"
348
+ end
349
+ ```
327
350
 
328
- *Vinicius Stock*
351
+ Example controller level policy:
329
352
 
330
- * Introduce `ActionDispatch::DebugExceptions.register_interceptor`.
353
+ ```ruby
354
+ class PagesController < ApplicationController
355
+ feature_policy do |p|
356
+ p.geolocation "https://example.com"
357
+ end
358
+ end
359
+ ```
331
360
 
332
- Exception aware plugin authors can use the newly introduced
333
- `.register_interceptor` method to get the processed exception, instead of
334
- monkey patching DebugExceptions.
361
+ *Jacob Bednarz*
335
362
 
336
- ActionDispatch::DebugExceptions.register_interceptor do |request, exception|
337
- HypoteticalPlugin.capture_exception(request, exception)
338
- end
363
+ * Add the ability to set the CSP nonce only to the specified directives.
339
364
 
340
- *Genadi Samokovarov*
365
+ Fixes #35137.
341
366
 
342
- * Output only one Content-Security-Policy nonce header value per request.
367
+ *Yuji Yaginuma*
343
368
 
344
- Fixes #32597.
369
+ * Keep part when scope option has value.
345
370
 
346
- *Andrey Novikov*, *Andrew White*
371
+ When a route was defined within an optional scope, if that route didn't
372
+ take parameters the scope was lost when using path helpers. This commit
373
+ ensures scope is kept both when the route takes parameters or when it
374
+ doesn't.
347
375
 
348
- * Move default headers configuration into their own module that can be included in controllers.
376
+ Fixes #33219.
349
377
 
350
- *Kevin Deisz*
378
+ *Alberto Almagro*
351
379
 
352
- * Add method `dig` to `session`.
380
+ * Added `deep_transform_keys` and `deep_transform_keys!` methods to ActionController::Parameters.
353
381
 
354
- *claudiob*, *Takumi Shotoku*
382
+ *Gustavo Gutierrez*
355
383
 
356
- * Controller level `force_ssl` has been deprecated in favor of
357
- `config.force_ssl`.
384
+ * Calling `ActionController::Parameters#transform_keys`/`!` without a block now returns
385
+ an enumerator for the parameters instead of the underlying hash.
358
386
 
359
- *Derek Prior*
387
+ *Eugene Kenny*
360
388
 
361
- * Rails 6 requires Ruby 2.5.0 or newer.
389
+ * Fix strong parameters blocks all attributes even when only some keys are invalid (non-numerical).
390
+ It should only block invalid key's values instead.
362
391
 
363
- *Jeremy Daer*, *Kasper Timm Hansen*
392
+ *Stan Lo*
364
393
 
365
394
 
366
- Please check [5-2-stable](https://github.com/rails/rails/blob/5-2-stable/actionpack/CHANGELOG.md) for previous changes.
395
+ Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionpack/CHANGELOG.md) for previous changes.