actionpack 6.0.3.7 → 6.1.0.rc1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of actionpack might be problematic. Click here for more details.

Files changed (114) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +242 -268
  3. data/MIT-LICENSE +1 -1
  4. data/lib/abstract_controller.rb +1 -0
  5. data/lib/abstract_controller/base.rb +35 -2
  6. data/lib/abstract_controller/callbacks.rb +2 -2
  7. data/lib/abstract_controller/helpers.rb +105 -90
  8. data/lib/abstract_controller/rendering.rb +9 -9
  9. data/lib/abstract_controller/translation.rb +8 -2
  10. data/lib/action_controller.rb +2 -3
  11. data/lib/action_controller/api.rb +2 -2
  12. data/lib/action_controller/base.rb +4 -2
  13. data/lib/action_controller/caching.rb +0 -1
  14. data/lib/action_controller/log_subscriber.rb +3 -3
  15. data/lib/action_controller/metal.rb +2 -2
  16. data/lib/action_controller/metal/conditional_get.rb +10 -2
  17. data/lib/action_controller/metal/content_security_policy.rb +1 -1
  18. data/lib/action_controller/metal/data_streaming.rb +1 -1
  19. data/lib/action_controller/metal/etag_with_template_digest.rb +2 -4
  20. data/lib/action_controller/metal/exceptions.rb +33 -0
  21. data/lib/action_controller/metal/feature_policy.rb +46 -0
  22. data/lib/action_controller/metal/head.rb +7 -4
  23. data/lib/action_controller/metal/helpers.rb +11 -1
  24. data/lib/action_controller/metal/http_authentication.rb +5 -3
  25. data/lib/action_controller/metal/implicit_render.rb +1 -1
  26. data/lib/action_controller/metal/instrumentation.rb +11 -9
  27. data/lib/action_controller/metal/live.rb +1 -1
  28. data/lib/action_controller/metal/logging.rb +20 -0
  29. data/lib/action_controller/metal/mime_responds.rb +6 -2
  30. data/lib/action_controller/metal/parameter_encoding.rb +35 -4
  31. data/lib/action_controller/metal/params_wrapper.rb +14 -8
  32. data/lib/action_controller/metal/redirecting.rb +1 -1
  33. data/lib/action_controller/metal/rendering.rb +6 -0
  34. data/lib/action_controller/metal/request_forgery_protection.rb +48 -24
  35. data/lib/action_controller/metal/rescue.rb +1 -1
  36. data/lib/action_controller/metal/strong_parameters.rb +103 -15
  37. data/lib/action_controller/renderer.rb +24 -13
  38. data/lib/action_controller/test_case.rb +62 -56
  39. data/lib/action_dispatch.rb +3 -2
  40. data/lib/action_dispatch/http/cache.rb +12 -10
  41. data/lib/action_dispatch/http/content_disposition.rb +2 -2
  42. data/lib/action_dispatch/http/content_security_policy.rb +5 -1
  43. data/lib/action_dispatch/http/feature_policy.rb +168 -0
  44. data/lib/action_dispatch/http/filter_parameters.rb +1 -1
  45. data/lib/action_dispatch/http/filter_redirect.rb +1 -1
  46. data/lib/action_dispatch/http/headers.rb +3 -2
  47. data/lib/action_dispatch/http/mime_negotiation.rb +20 -8
  48. data/lib/action_dispatch/http/mime_type.rb +29 -16
  49. data/lib/action_dispatch/http/parameters.rb +1 -19
  50. data/lib/action_dispatch/http/request.rb +26 -8
  51. data/lib/action_dispatch/http/response.rb +17 -16
  52. data/lib/action_dispatch/http/url.rb +3 -2
  53. data/lib/action_dispatch/journey.rb +0 -2
  54. data/lib/action_dispatch/journey/formatter.rb +53 -28
  55. data/lib/action_dispatch/journey/gtg/builder.rb +22 -36
  56. data/lib/action_dispatch/journey/gtg/simulator.rb +8 -7
  57. data/lib/action_dispatch/journey/gtg/transition_table.rb +6 -4
  58. data/lib/action_dispatch/journey/nfa/dot.rb +0 -11
  59. data/lib/action_dispatch/journey/nodes/node.rb +4 -3
  60. data/lib/action_dispatch/journey/parser.rb +13 -13
  61. data/lib/action_dispatch/journey/parser.y +1 -1
  62. data/lib/action_dispatch/journey/path/pattern.rb +13 -18
  63. data/lib/action_dispatch/journey/route.rb +7 -18
  64. data/lib/action_dispatch/journey/router.rb +26 -30
  65. data/lib/action_dispatch/journey/router/utils.rb +6 -4
  66. data/lib/action_dispatch/middleware/actionable_exceptions.rb +2 -2
  67. data/lib/action_dispatch/middleware/cookies.rb +74 -33
  68. data/lib/action_dispatch/middleware/debug_exceptions.rb +10 -17
  69. data/lib/action_dispatch/middleware/debug_view.rb +1 -1
  70. data/lib/action_dispatch/middleware/exception_wrapper.rb +29 -17
  71. data/lib/action_dispatch/middleware/host_authorization.rb +28 -17
  72. data/lib/action_dispatch/middleware/public_exceptions.rb +1 -1
  73. data/lib/action_dispatch/middleware/remote_ip.rb +5 -4
  74. data/lib/action_dispatch/middleware/request_id.rb +4 -5
  75. data/lib/action_dispatch/middleware/session/abstract_store.rb +2 -2
  76. data/lib/action_dispatch/middleware/session/cookie_store.rb +2 -2
  77. data/lib/action_dispatch/middleware/ssl.rb +9 -6
  78. data/lib/action_dispatch/middleware/stack.rb +18 -0
  79. data/lib/action_dispatch/middleware/static.rb +154 -93
  80. data/lib/action_dispatch/middleware/templates/rescues/_message_and_suggestions.html.erb +18 -0
  81. data/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb +2 -5
  82. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.html.erb +2 -2
  83. data/lib/action_dispatch/middleware/templates/rescues/invalid_statement.text.erb +2 -2
  84. data/lib/action_dispatch/middleware/templates/rescues/layout.erb +88 -8
  85. data/lib/action_dispatch/middleware/templates/rescues/unknown_action.html.erb +1 -1
  86. data/lib/action_dispatch/middleware/templates/routes/_table.html.erb +12 -1
  87. data/lib/action_dispatch/railtie.rb +3 -2
  88. data/lib/action_dispatch/request/session.rb +2 -8
  89. data/lib/action_dispatch/request/utils.rb +26 -2
  90. data/lib/action_dispatch/routing/inspector.rb +8 -7
  91. data/lib/action_dispatch/routing/mapper.rb +102 -71
  92. data/lib/action_dispatch/routing/polymorphic_routes.rb +16 -19
  93. data/lib/action_dispatch/routing/redirection.rb +3 -3
  94. data/lib/action_dispatch/routing/route_set.rb +49 -41
  95. data/lib/action_dispatch/routing/url_for.rb +1 -0
  96. data/lib/action_dispatch/system_test_case.rb +29 -24
  97. data/lib/action_dispatch/system_testing/browser.rb +33 -27
  98. data/lib/action_dispatch/system_testing/driver.rb +6 -7
  99. data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb +47 -6
  100. data/lib/action_dispatch/system_testing/test_helpers/setup_and_teardown.rb +4 -7
  101. data/lib/action_dispatch/testing/assertions.rb +1 -1
  102. data/lib/action_dispatch/testing/assertions/response.rb +2 -4
  103. data/lib/action_dispatch/testing/assertions/routing.rb +5 -5
  104. data/lib/action_dispatch/testing/integration.rb +38 -27
  105. data/lib/action_dispatch/testing/test_process.rb +29 -4
  106. data/lib/action_dispatch/testing/test_request.rb +3 -3
  107. data/lib/action_pack.rb +1 -1
  108. data/lib/action_pack/gem_version.rb +3 -3
  109. metadata +23 -24
  110. data/lib/action_controller/metal/force_ssl.rb +0 -58
  111. data/lib/action_dispatch/http/parameter_filter.rb +0 -12
  112. data/lib/action_dispatch/journey/nfa/builder.rb +0 -78
  113. data/lib/action_dispatch/journey/nfa/simulator.rb +0 -47
  114. data/lib/action_dispatch/journey/nfa/transition_table.rb +0 -119
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 689cadf2c5055a30bce24daa0dbd2c5f4e9b62b8e05f318527556df6a1bbc0bd
4
- data.tar.gz: db971eb4537c26d3c61aaeb5933a936ab80465ab7533c3a1fd96fed34bc98159
3
+ metadata.gz: 9a4a41e1ca0c25578fbd6a0ea8a05295194ae1bd4583adec81c901d36df926af
4
+ data.tar.gz: 8582c26944953ae947cf95b4582f3b000af462b0786476d4dc84a268963bbdd8
5
5
  SHA512:
6
- metadata.gz: bb3325660659b91dd7917b48dfd211078d28812bfae7695e224599573835d7c42994ead64ebeb5c121d1dbc4ac30da9ae0f3a0be304892c914ce2309d8b3fc2b
7
- data.tar.gz: 826160c64038886b1bc08301f8d4782cd1564f5b167d452bd87b8870043581dc971bb9f5a54075001fe254148fc8845187f660f4cf4fcb84f5dfdf17bfb85dda
6
+ metadata.gz: c6ae9cf119acfd74a41566d30f6d499ed3590355134a7a00ebc77b25a8516f1037448bc202c543b0c92cedc842d38e1b787df12f4260bebf5f1595c42c192d2a
7
+ data.tar.gz: 69965930679b64e98df6a5b4edaefa9f15a7c38480fd179507b3a27c663b07478411a6ae04355dd5a30f97f18be8b4441e083b5c97d0015f95963d5adf29dcda
data/CHANGELOG.md CHANGED
@@ -1,421 +1,395 @@
1
- ## Rails 6.0.3.7 (May 05, 2021) ##
1
+ ## Rails 6.1.0.rc1 (November 02, 2020) ##
2
2
 
3
- * Prevent catastrophic backtracking during mime parsing
4
- CVE-2021-22902
3
+ * Allow `ActionDispatch::HostAuthorization` to exclude specific requests.
5
4
 
6
- * Prevent regex DoS in HTTP token authentication
7
- CVE-2021-22904
5
+ Host Authorization checks can be skipped for specific requests. This allows for health check requests to be permitted for requests with missing or non-matching host headers.
8
6
 
9
- * Prevent string polymorphic route arguments.
7
+ *Chris Bisnett*
10
8
 
11
- `url_for` supports building polymorphic URLs via an array
12
- of arguments (usually symbols and records). If a developer passes a
13
- user input array, strings can result in unwanted route helper calls.
9
+ * Add `config.action_dispatch.request_id_header` to allow changing the name of
10
+ the unique X-Request-Id header
14
11
 
15
- CVE-2021-22885
16
-
17
- *Gannon McGibbon*
18
-
19
- ## Rails 6.0.3.6 (March 26, 2021) ##
20
-
21
- * No changes.
12
+ *Arlston Fernandes*
22
13
 
14
+ * Deprecate `config.action_dispatch.return_only_media_type_on_content_type`.
23
15
 
24
- ## Rails 6.0.3.5 (February 10, 2021) ##
25
-
26
- * Prevent open redirect when allowed host starts with a dot
16
+ *Rafael Mendonça França*
27
17
 
28
- [CVE-2021-22881]
18
+ * Change `ActionDispatch::Response#content_type` to return the full Content-Type header.
29
19
 
30
- Thanks to @tktech (https://hackerone.com/tktech) for reporting this
31
- issue and the patch!
20
+ *Rafael Mendonça França*
32
21
 
33
- *Aaron Patterson*
22
+ * Remove deprecated `ActionDispatch::Http::ParameterFilter`.
34
23
 
24
+ *Rafael Mendonça França*
35
25
 
36
- ## Rails 6.0.3.4 (October 07, 2020) ##
26
+ * Added support for exclusive no-store Cache-Control header.
37
27
 
38
- * [CVE-2020-8264] Prevent XSS in Actionable Exceptions
28
+ If `no-store` is set on Cache-Control header it is exclusive (all other cache directives are dropped).
39
29
 
30
+ *Chris Kruger*
40
31
 
41
- ## Rails 6.0.3.3 (September 09, 2020) ##
32
+ * Catch invalid UTF-8 parameters for POST requests and respond with BadRequest.
42
33
 
43
- * No changes.
34
+ Additionally, perform `#set_binary_encoding` in `ActionDispatch::Http::Request#GET` and
35
+ `ActionDispatch::Http::Request#POST` prior to validating encoding.
44
36
 
37
+ *Adrianna Chang*
45
38
 
46
- ## Rails 6.0.3.2 (June 17, 2020) ##
39
+ * Allow `assert_recognizes` routing assertions to work on mounted root routes.
47
40
 
48
- * [CVE-2020-8185] Only allow ActionableErrors if show_detailed_exceptions is enabled
41
+ *Gannon McGibbon*
49
42
 
50
- ## Rails 6.0.3.1 (May 18, 2020) ##
43
+ * Change default redirection status code for non-GET/HEAD requests to 308 Permanent Redirect for `ActionDispatch::SSL`.
51
44
 
52
- * [CVE-2020-8166] HMAC raw CSRF token before masking it, so it cannot be used to reconstruct a per-form token
45
+ *Alan Tan*, *Oz Ben-David*
53
46
 
54
- * [CVE-2020-8164] Return self when calling #each, #each_pair, and #each_value instead of the raw @parameters hash
47
+ * Fix `follow_redirect!` to follow redirection with same HTTP verb when following
48
+ a 308 redirection.
55
49
 
56
- ## Rails 6.0.3 (May 06, 2020) ##
50
+ *Alan Tan*
57
51
 
58
- * Include child session assertion count in ActionDispatch::IntegrationTest
52
+ * When multiple domains are specified for a cookie, a domain will now be
53
+ chosen only if it is equal to or is a superdomain of the request host.
59
54
 
60
- `IntegrationTest#open_session` uses `dup` to create the new session, which
61
- meant it had its own copy of `@assertions`. This prevented the assertions
62
- from being correctly counted and reported.
55
+ *Jonathan Hefner*
63
56
 
64
- Child sessions now have their `attr_accessor` overriden to delegate to the
65
- root session.
57
+ * `ActionDispatch::Static` handles precompiled Brotli (.br) files.
66
58
 
67
- Fixes #32142
59
+ Adds to existing support for precompiled gzip (.gz) files.
60
+ Brotli files are preferred due to much better compression.
68
61
 
69
- *Sam Bostock*
62
+ When the browser requests /some.js with `Accept-Encoding: br`,
63
+ we check for public/some.js.br and serve that file, if present, with
64
+ `Content-Encoding: br` and `Vary: Accept-Encoding` headers.
70
65
 
66
+ *Ryan Edward Hall*, *Jeremy Daer*
71
67
 
72
- ## Rails 6.0.2.2 (March 19, 2020) ##
68
+ * Add raise_on_missing_translations support for controllers.
73
69
 
74
- * No changes.
70
+ This configuration determines whether an error should be raised for missing translations.
71
+ It can be enabled through `config.i18n.raise_on_missing_translations`. Note that described
72
+ configuration also affects raising error for missing translations in views.
75
73
 
74
+ *fatkodima*
76
75
 
77
- ## Rails 6.0.2.1 (December 18, 2019) ##
76
+ * Added `compact` and `compact!` to `ActionController::Parameters`.
78
77
 
79
- * Fix possible information leak / session hijacking vulnerability.
78
+ *Eugene Kenny*
80
79
 
81
- The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the
82
- gem dalli to be updated as well.
80
+ * Calling `each_pair` or `each_value` on an `ActionController::Parameters`
81
+ without passing a block now returns an enumerator.
83
82
 
84
- CVE-2019-16782.
83
+ *Eugene Kenny*
85
84
 
85
+ * `fixture_file_upload` now uses path relative to `file_fixture_path`
86
86
 
87
- ## Rails 6.0.2 (December 13, 2019) ##
87
+ Previously the path had to be relative to `fixture_path`.
88
+ You can change your existing code as follow:
88
89
 
89
- * Allow using mountable engine route helpers in System Tests.
90
+ ```ruby
91
+ # Before
92
+ fixture_file_upload('files/dog.png')
90
93
 
91
- *Chalo Fernandez*
94
+ # After
95
+ fixture_file_upload('dog.png')
96
+ ```
92
97
 
98
+ *Edouard Chin*
93
99
 
94
- ## Rails 6.0.1 (November 5, 2019) ##
100
+ * Remove deprecated `force_ssl` at the controller level.
95
101
 
96
- * `ActionDispatch::SystemTestCase` now inherits from `ActiveSupport::TestCase`
97
- rather than `ActionDispatch::IntegrationTest`. This permits running jobs in
98
- system tests.
102
+ *Rafael Mendonça França*
99
103
 
100
- *George Claghorn*, *Edouard Chin*
104
+ * The +helper+ class method for controllers loads helper modules specified as
105
+ strings/symbols with `String#constantize` instead of `require_dependency`.
101
106
 
102
- * Registered MIME types may contain extra flags:
107
+ Remember that support for strings/symbols is only a convenient API. You can
108
+ always pass a module object:
103
109
 
104
110
  ```ruby
105
- Mime::Type.register "text/html; fragment", :html_fragment
111
+ helper UtilsHelper
106
112
  ```
107
113
 
108
- *Aaron Patterson*
109
-
110
-
111
- ## Rails 6.0.0 (August 16, 2019) ##
112
-
113
- * No changes.
114
-
114
+ which is recommended because it is simple and direct. When a string/symbol
115
+ is received, `helper` just manipulates and inflects the argument to obtain
116
+ that same module object.
115
117
 
116
- ## Rails 6.0.0.rc2 (July 22, 2019) ##
118
+ *Xavier Noria*, *Jean Boussier*
117
119
 
118
- * Add the ability to set the CSP nonce only to the specified directives.
119
-
120
- Fixes #35137.
121
-
122
- *Yuji Yaginuma*
123
-
124
- * Keep part when scope option has value.
125
-
126
- When a route was defined within an optional scope, if that route didn't
127
- take parameters the scope was lost when using path helpers. This commit
128
- ensures scope is kept both when the route takes parameters or when it
129
- doesn't.
130
-
131
- Fixes #33219
132
-
133
- *Alberto Almagro*
120
+ * Correctly identify the entire localhost IPv4 range as trusted proxy.
134
121
 
135
- * Change `ActionDispatch::Response#content_type` to return Content-Type header as it is.
122
+ *Nick Soracco*
136
123
 
137
- Previously, `ActionDispatch::Response#content_type` returned value does NOT
138
- contain charset part. This behavior changed to returned Content-Type header
139
- containing charset part as it is.
124
+ * `url_for` will now use "https://" as the default protocol when
125
+ `Rails.application.config.force_ssl` is set to true.
140
126
 
141
- If you want just MIME type, please use `ActionDispatch::Response#media_type`
142
- instead.
127
+ *Jonathan Hefner*
143
128
 
144
- Enable `action_dispatch.return_only_media_type_on_content_type` to use this change.
145
- If not enabled, `ActionDispatch::Response#content_type` returns the same
146
- value as before version, but its behavior is deprecate.
129
+ * Accept and default to base64_urlsafe CSRF tokens.
147
130
 
148
- *Yuji Yaginuma*
131
+ Base64 strict-encoded CSRF tokens are not inherently websafe, which makes
132
+ them difficult to deal with. For example, the common practice of sending
133
+ the CSRF token to a browser in a client-readable cookie does not work properly
134
+ out of the box: the value has to be url-encoded and decoded to survive transport.
149
135
 
150
- * Calling `ActionController::Parameters#transform_keys/!` without a block now returns
151
- an enumerator for the parameters instead of the underlying hash.
136
+ Now, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently safe
137
+ to transport. Validation accepts both urlsafe tokens, and strict-encoded tokens
138
+ for backwards compatibility.
152
139
 
153
- *Eugene Kenny*
140
+ *Scott Blum*
154
141
 
155
- * Fix a bug where DebugExceptions throws an error when malformed query parameters are provided
142
+ * Support rolling deploys for cookie serialization/encryption changes.
156
143
 
157
- *Yuki Nishijima*, *Stan Lo*
144
+ In a distributed configuration like rolling update, users may observe
145
+ both old and new instances during deployment. Users may be served by a
146
+ new instance and then by an old instance.
158
147
 
148
+ That means when the server changes `cookies_serializer` from `:marshal`
149
+ to `:hybrid` or the server changes `use_authenticated_cookie_encryption`
150
+ from `false` to `true`, users may lose their sessions if they access the
151
+ server during deployment.
159
152
 
160
- ## Rails 6.0.0.rc1 (April 24, 2019) ##
153
+ We added fallbacks to downgrade the cookie format when necessary during
154
+ deployment, ensuring compatibility on both old and new instances.
161
155
 
162
- * Make system tests take a failed screenshot in a `before_teardown` hook
163
- rather than an `after_teardown` hook.
156
+ *Masaki Hara*
164
157
 
165
- This helps minimize the time gap between when an assertion fails and when
166
- the screenshot is taken (reducing the time in which the page could have
167
- been dynamically updated after the assertion failed).
158
+ * `ActionDispatch::Request.remote_ip` has ip address even when all sites are trusted.
168
159
 
169
- *Richard Macklin*
160
+ Before, if all `X-Forwarded-For` sites were trusted, the `remote_ip` would default to `127.0.0.1`.
161
+ Now, the furthest proxy site is used. e.g.: It now gives an ip address when using curl from the load balancer.
170
162
 
171
- * Introduce `ActionDispatch::ActionableExceptions`.
163
+ *Keenan Brock*
172
164
 
173
- The `ActionDispatch::ActionableExceptions` middleware dispatches actions
174
- from `ActiveSupport::ActionableError` descendants.
175
-
176
- Actionable errors let's you dispatch actions from Rails' error pages.
165
+ * Fix possible information leak / session hijacking vulnerability.
177
166
 
178
- *Vipul A M*, *Yao Jie*, *Genadi Samokovarov*
167
+ The `ActionDispatch::Session::MemcacheStore` is still vulnerable given it requires the
168
+ gem dalli to be updated as well.
179
169
 
180
- * Raise an `ArgumentError` if a resource custom param contains a colon (`:`).
170
+ CVE-2019-16782.
181
171
 
182
- After this change it's not possible anymore to configure routes like this:
172
+ * Include child session assertion count in ActionDispatch::IntegrationTest.
183
173
 
184
- ```
185
- routes.draw do
186
- resources :users, param: 'name/:sneaky'
187
- end
188
- ```
174
+ `IntegrationTest#open_session` uses `dup` to create the new session, which
175
+ meant it had its own copy of `@assertions`. This prevented the assertions
176
+ from being correctly counted and reported.
189
177
 
190
- Fixes #30467.
178
+ Child sessions now have their `attr_accessor` overridden to delegate to the
179
+ root session.
191
180
 
192
- *Josua Schmid*
181
+ Fixes #32142.
193
182
 
183
+ *Sam Bostock*
194
184
 
195
- ## Rails 6.0.0.beta3 (March 11, 2019) ##
185
+ * Add SameSite protection to every written cookie.
196
186
 
197
- * No changes.
187
+ Enabling `SameSite` cookie protection is an addition to CSRF protection,
188
+ where cookies won't be sent by browsers in cross-site POST requests when set to `:lax`.
198
189
 
190
+ `:strict` disables cookies being sent in cross-site GET or POST requests.
199
191
 
200
- ## Rails 6.0.0.beta2 (February 25, 2019) ##
192
+ Passing `:none` disables this protection and is the same as previous versions albeit a `; SameSite=None` is appended to the cookie.
201
193
 
202
- * Make debug exceptions works in an environment where ActiveStorage is not loaded.
194
+ See upgrade instructions in config/initializers/new_framework_defaults_6_1.rb.
203
195
 
204
- *Tomoyuki Kurosawa*
196
+ More info [here](https://tools.ietf.org/html/draft-west-first-party-cookies-07)
205
197
 
206
- * `ActionDispatch::SystemTestCase.driven_by` can now be called with a block
207
- to define specific browser capabilities.
198
+ _NB: Technically already possible as Rack supports SameSite protection, this is to ensure it's applied to all cookies_
208
199
 
209
- *Edouard Chin*
200
+ *Cédric Fabianski*
210
201
 
202
+ * Bring back the feature that allows loading external route files from the router.
211
203
 
212
- ## Rails 6.0.0.beta1 (January 18, 2019) ##
204
+ This feature existed back in 2012 but got reverted with the incentive that
205
+ https://github.com/rails/routing_concerns was a better approach. Turned out
206
+ that this wasn't fully the case and loading external route files from the router
207
+ can be helpful for applications with a really large set of routes.
208
+ Without this feature, application needs to implement routes reloading
209
+ themselves and it's not straightforward.
213
210
 
214
- * Remove deprecated `fragment_cache_key` helper in favor of `combined_fragment_cache_key`.
211
+ ```ruby
212
+ # config/routes.rb
215
213
 
216
- *Rafael Mendonça França*
214
+ Rails.application.routes.draw do
215
+ draw(:admin)
216
+ end
217
217
 
218
- * Remove deprecated methods in `ActionDispatch::TestResponse`.
218
+ # config/routes/admin.rb
219
219
 
220
- `#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
221
- `#successful?`, `not_found?` and `server_error?`.
220
+ get :foo, to: 'foo#bar'
221
+ ```
222
222
 
223
- *Rafael Mendonça França*
223
+ *Yehuda Katz*, *Edouard Chin*
224
224
 
225
- * Introduce `ActionDispatch::HostAuthorization`.
225
+ * Fix system test driver option initialization for non-headless browsers.
226
226
 
227
- This is a new middleware that guards against DNS rebinding attacks by
228
- explicitly permitting the hosts a request can be made to.
227
+ *glaszig*
229
228
 
230
- Each host is checked with the case operator (`#===`) to support `Regexp`,
231
- `Proc`, `IPAddr` and custom objects as host allowances.
229
+ * `redirect_to.action_controller` notifications now include the `ActionDispatch::Request` in
230
+ their payloads as `:request`.
232
231
 
233
- *Genadi Samokovarov*
232
+ *Austin Story*
234
233
 
235
- * Allow using `parsed_body` in `ActionController::TestCase`.
234
+ * `respond_to#any` no longer returns a response's Content-Type based on the
235
+ request format but based on the block given.
236
236
 
237
- In addition to `ActionDispatch::IntegrationTest`, allow using
238
- `parsed_body` in `ActionController::TestCase`:
237
+ Example:
239
238
 
240
- ```
241
- class SomeControllerTest < ActionController::TestCase
242
- def test_some_action
243
- post :action, body: { foo: 'bar' }
244
- assert_equal({ "foo" => "bar" }, response.parsed_body)
239
+ ```ruby
240
+ def my_action
241
+ respond_to do |format|
242
+ format.any { render(json: { foo: 'bar' }) }
243
+ end
245
244
  end
246
- end
247
- ```
248
-
249
- Fixes #34676.
250
-
251
- *Tobias Bühlmann*
252
-
253
- * Raise an error on root route naming conflicts.
254
-
255
- Raises an `ArgumentError` when multiple root routes are defined in the
256
- same context instead of assigning nil names to subsequent roots.
257
-
258
- *Gannon McGibbon*
259
-
260
- * Allow rescue from parameter parse errors:
261
245
 
246
+ get('my_action.csv')
262
247
  ```
263
- rescue_from ActionDispatch::Http::Parameters::ParseError do
264
- head :unauthorized
265
- end
266
- ```
267
-
268
- *Gannon McGibbon*, *Josh Cheek*
269
-
270
- * Reset Capybara sessions if failed system test screenshot raising an exception.
271
-
272
- Reset Capybara sessions if `take_failed_screenshot` raise exception
273
- in system test `after_teardown`.
274
-
275
- *Maxim Perepelitsa*
276
-
277
- * Use request object for context if there's no controller
278
248
 
279
- There is no controller instance when using a redirect route or a
280
- mounted rack application so pass the request object as the context
281
- when resolving dynamic CSP sources in this scenario.
249
+ The previous behaviour was to respond with a `text/csv` Content-Type which
250
+ is inaccurate since a JSON response is being rendered.
282
251
 
283
- Fixes #34200.
252
+ Now it correctly returns a `application/json` Content-Type.
284
253
 
285
- *Andrew White*
286
-
287
- * Apply mapping to symbols returned from dynamic CSP sources
288
-
289
- Previously if a dynamic source returned a symbol such as :self it
290
- would be converted to a string implicitly, e.g:
254
+ *Edouard Chin*
291
255
 
292
- policy.default_src -> { :self }
256
+ * Replaces (back)slashes in failure screenshot image paths with dashes.
293
257
 
294
- would generate the header:
258
+ If a failed test case contained a slash or a backslash, a screenshot would be created in a
259
+ nested directory, causing issues with `tmp:clear`.
295
260
 
296
- Content-Security-Policy: default-src self
261
+ *Damir Zekic*
297
262
 
298
- and now it generates:
263
+ * Add `params.member?` to mimic Hash behavior.
299
264
 
300
- Content-Security-Policy: default-src 'self'
265
+ *Younes Serraj*
301
266
 
302
- *Andrew White*
267
+ * `process_action.action_controller` notifications now include the following in their payloads:
303
268
 
304
- * Add `ActionController::Parameters#each_value`.
269
+ * `:request` - the `ActionDispatch::Request`
270
+ * `:response` - the `ActionDispatch::Response`
305
271
 
306
- *Lukáš Zapletal*
272
+ *George Claghorn*
307
273
 
308
- * Deprecate `ActionDispatch::Http::ParameterFilter` in favor of `ActiveSupport::ParameterFilter`.
274
+ * Updated `ActionDispatch::Request.remote_ip` setter to clear set the instance
275
+ `remote_ip` to `nil` before setting the header that the value is derived
276
+ from.
309
277
 
310
- *Yoshiyuki Kinjo*
278
+ Fixes #37383.
311
279
 
312
- * Encode Content-Disposition filenames on `send_data` and `send_file`.
313
- Previously, `send_data 'data', filename: "\u{3042}.txt"` sends
314
- `"filename=\"\u{3042}.txt\""` as Content-Disposition and it can be
315
- garbled.
316
- Now it follows [RFC 2231](https://tools.ietf.org/html/rfc2231) and
317
- [RFC 5987](https://tools.ietf.org/html/rfc5987) and sends
318
- `"filename=\"%3F.txt\"; filename*=UTF-8''%E3%81%82.txt"`.
319
- Most browsers can find filename correctly and old browsers fallback to ASCII
320
- converted name.
280
+ *Norm Provost*
321
281
 
322
- *Fumiaki Matsushima*
282
+ * `ActionController::Base.log_at` allows setting a different log level per request.
323
283
 
324
- * Expose `ActionController::Parameters#each_key` which allows iterating over
325
- keys without allocating an array.
284
+ ```ruby
285
+ # Use the debug level if a particular cookie is set.
286
+ class ApplicationController < ActionController::Base
287
+ log_at :debug, if: -> { cookies[:debug] }
288
+ end
289
+ ```
326
290
 
327
- *Richard Schneeman*
291
+ *George Claghorn*
328
292
 
329
- * Purpose metadata for signed/encrypted cookies.
293
+ * Allow system test screen shots to be taken more than once in
294
+ a test by prefixing the file name with an incrementing counter.
330
295
 
331
- Rails can now thwart attacks that attempt to copy signed/encrypted value
332
- of a cookie and use it as the value of another cookie.
296
+ Add an environment variable `RAILS_SYSTEM_TESTING_SCREENSHOT_HTML` to
297
+ enable saving of HTML during a screenshot in addition to the image.
298
+ This uses the same image name, with the extension replaced with `.html`
333
299
 
334
- It does so by stashing the cookie-name in the purpose field which is
335
- then signed/encrypted along with the cookie value. Then, on a server-side
336
- read, we verify the cookie-names and discard any attacked cookies.
300
+ *Tom Fakes*
337
301
 
338
- Enable `action_dispatch.use_cookies_with_metadata` to use this feature, which
339
- writes cookies with the new purpose and expiry metadata embedded.
302
+ * Add `Vary: Accept` header when using `Accept` header for response.
340
303
 
341
- *Assain Jaleel*
304
+ For some requests like `/users/1`, Rails uses requests' `Accept`
305
+ header to determine what to return. And if we don't add `Vary`
306
+ in the response header, browsers might accidentally cache different
307
+ types of content, which would cause issues: e.g. javascript got displayed
308
+ instead of html content. This PR fixes these issues by adding `Vary: Accept`
309
+ in these types of requests. For more detailed problem description, please read:
342
310
 
343
- * Raises `ActionController::RespondToMismatchError` with conflicting `respond_to` invocations.
311
+ https://github.com/rails/rails/pull/36213
344
312
 
345
- `respond_to` can match multiple types and lead to undefined behavior when
346
- multiple invocations are made and the types do not match:
313
+ Fixes #25842.
347
314
 
348
- respond_to do |outer_type|
349
- outer_type.js do
350
- respond_to do |inner_type|
351
- inner_type.html { render body: "HTML" }
352
- end
353
- end
354
- end
315
+ *Stan Lo*
355
316
 
356
- *Patrick Toomey*
317
+ * Fix IntegrationTest `follow_redirect!` to follow redirection using the same HTTP verb when following
318
+ a 307 redirection.
357
319
 
358
- * `ActionDispatch::Http::UploadedFile` now delegates `to_path` to its tempfile.
320
+ *Edouard Chin*
359
321
 
360
- This allows uploaded file objects to be passed directly to `File.read`
361
- without raising a `TypeError`:
322
+ * System tests require Capybara 3.26 or newer.
362
323
 
363
- uploaded_file = ActionDispatch::Http::UploadedFile.new(tempfile: tmp_file)
364
- File.read(uploaded_file)
324
+ *George Claghorn*
365
325
 
366
- *Aaron Kromer*
326
+ * Reduced log noise handling ActionController::RoutingErrors.
367
327
 
368
- * Pass along arguments to underlying `get` method in `follow_redirect!`
328
+ *Alberto Fernández-Capel*
369
329
 
370
- Now all arguments passed to `follow_redirect!` are passed to the underlying
371
- `get` method. This for example allows to set custom headers for the
372
- redirection request to the server.
330
+ * Add DSL for configuring HTTP Feature Policy.
373
331
 
374
- follow_redirect!(params: { foo: :bar })
332
+ This new DSL provides a way to configure an HTTP Feature Policy at a
333
+ global or per-controller level. Full details of HTTP Feature Policy
334
+ specification and guidelines can be found at MDN:
375
335
 
376
- *Remo Fritzsche*
336
+ https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy
377
337
 
378
- * Introduce a new error page to when the implicit render page is accessed in the browser.
338
+ Example global policy:
379
339
 
380
- Now instead of showing an error page that with exception and backtraces we now show only
381
- one informative page.
340
+ ```ruby
341
+ Rails.application.config.feature_policy do |f|
342
+ f.camera :none
343
+ f.gyroscope :none
344
+ f.microphone :none
345
+ f.usb :none
346
+ f.fullscreen :self
347
+ f.payment :self, "https://secure.example.com"
348
+ end
349
+ ```
382
350
 
383
- *Vinicius Stock*
351
+ Example controller level policy:
384
352
 
385
- * Introduce `ActionDispatch::DebugExceptions.register_interceptor`.
353
+ ```ruby
354
+ class PagesController < ApplicationController
355
+ feature_policy do |p|
356
+ p.geolocation "https://example.com"
357
+ end
358
+ end
359
+ ```
386
360
 
387
- Exception aware plugin authors can use the newly introduced
388
- `.register_interceptor` method to get the processed exception, instead of
389
- monkey patching DebugExceptions.
361
+ *Jacob Bednarz*
390
362
 
391
- ActionDispatch::DebugExceptions.register_interceptor do |request, exception|
392
- HypoteticalPlugin.capture_exception(request, exception)
393
- end
363
+ * Add the ability to set the CSP nonce only to the specified directives.
394
364
 
395
- *Genadi Samokovarov*
365
+ Fixes #35137.
396
366
 
397
- * Output only one Content-Security-Policy nonce header value per request.
367
+ *Yuji Yaginuma*
398
368
 
399
- Fixes #32597.
369
+ * Keep part when scope option has value.
400
370
 
401
- *Andrey Novikov*, *Andrew White*
371
+ When a route was defined within an optional scope, if that route didn't
372
+ take parameters the scope was lost when using path helpers. This commit
373
+ ensures scope is kept both when the route takes parameters or when it
374
+ doesn't.
402
375
 
403
- * Move default headers configuration into their own module that can be included in controllers.
376
+ Fixes #33219.
404
377
 
405
- *Kevin Deisz*
378
+ *Alberto Almagro*
406
379
 
407
- * Add method `dig` to `session`.
380
+ * Added `deep_transform_keys` and `deep_transform_keys!` methods to ActionController::Parameters.
408
381
 
409
- *claudiob*, *Takumi Shotoku*
382
+ *Gustavo Gutierrez*
410
383
 
411
- * Controller level `force_ssl` has been deprecated in favor of
412
- `config.force_ssl`.
384
+ * Calling `ActionController::Parameters#transform_keys`/`!` without a block now returns
385
+ an enumerator for the parameters instead of the underlying hash.
413
386
 
414
- *Derek Prior*
387
+ *Eugene Kenny*
415
388
 
416
- * Rails 6 requires Ruby 2.5.0 or newer.
389
+ * Fix strong parameters blocks all attributes even when only some keys are invalid (non-numerical).
390
+ It should only block invalid key's values instead.
417
391
 
418
- *Jeremy Daer*, *Kasper Timm Hansen*
392
+ *Stan Lo*
419
393
 
420
394
 
421
- Please check [5-2-stable](https://github.com/rails/rails/blob/5-2-stable/actionpack/CHANGELOG.md) for previous changes.
395
+ Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionpack/CHANGELOG.md) for previous changes.