actionpack 5.1.4.rc1 → 5.1.4

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.

This version of actionpack might be problematic. Click here for more details.

Files changed (5) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +8 -0
  3. data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb +9 -5
  4. data/lib/action_pack/gem_version.rb +1 -1
  5. metadata +11 -11
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: f4f8ad00d3fae78fec762b134cda31adef2b2691
4
- data.tar.gz: 42ca1f1ed7e1af5d650a53689bc780da77d167b5
3
+ metadata.gz: 85dc188ae1e7ed19f6c1409f13cfe436eaf142ac
4
+ data.tar.gz: 40b27e97b125b37721f47cfce1732c4889f889a0
5
5
  SHA512:
6
- metadata.gz: c2840a0d64ffb582932c09cd3ce1290f426a168149de1489789f12cd74c0993e99b82556bd4c05a1b047d5662801d57ffb399bd19fd792f827628fbeb4e7c547
7
- data.tar.gz: bc4f58ffc37b521110b58934de8abb00badc1f2598fed16a19e1d175e6bc00fb7b5b919f329240864ad6fe1c4f6269a1a3ba796912bd85378363f625e3203820
6
+ metadata.gz: 290bee22ac3d4866472152b68a4a474525030619b74e2fc4a3ea2ab58250bd68b7e8003edb27af290c111efdbd846e986fa6327305892b9230cf5f7b603fc0f1
7
+ data.tar.gz: 717b382b37b6a10cc5eabe65ca66f4966012c5814f51137ceccd8fea4440c53cef9c02fcc7459d828db73d5e3e7d4a045b3cb881ea0e3ee90ff54f2dc799a41c
data/CHANGELOG.md CHANGED
@@ -1,3 +1,11 @@
1
+ ## Rails 5.1.4 (September 07, 2017) ##
2
+
3
+ * Make `take_failed_screenshot` work within engine.
4
+
5
+ Fixes #30405.
6
+
7
+ *Yuji Yaginuma*
8
+
1
9
  ## Rails 5.1.4.rc1 (August 24, 2017) ##
2
10
 
3
11
  * No changes.
data/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb CHANGED
@@ -42,11 +42,15 @@ module ActionDispatch
42
42
  end
43
43
 
44
44
  def image_path
45
- "tmp/screenshots/#{image_name}.png"
45
+ @image_path ||= absolute_image_path.relative_path_from(Pathname.pwd).to_s
46
+ end
47
+
48
+ def absolute_image_path
49
+ Rails.root.join("tmp/screenshots/#{image_name}.png")
46
50
  end
47
51
 
48
52
  def save_image
49
- page.save_screenshot(Rails.root.join(image_path))
53
+ page.save_screenshot(absolute_image_path)
50
54
  end
51
55
 
52
56
  def output_type
@@ -67,10 +71,10 @@ module ActionDispatch
67
71
 
68
72
  case output_type
69
73
  when "artifact"
70
- message << "\e]1338;url=artifact://#{image_path}\a\n"
74
+ message << "\e]1338;url=artifact://#{absolute_image_path}\a\n"
71
75
  when "inline"
72
- name = inline_base64(File.basename(image_path))
73
- image = inline_base64(File.read(image_path))
76
+ name = inline_base64(File.basename(absolute_image_path))
77
+ image = inline_base64(File.read(absolute_image_path))
74
78
  message << "\e]1337;File=name=#{name};height=400px;inline=1:#{image}\a\n"
75
79
  end
76
80
 
data/lib/action_pack/gem_version.rb CHANGED
@@ -8,7 +8,7 @@ module ActionPack
8
8
  MAJOR = 5
9
9
  MINOR = 1
10
10
  TINY = 4
11
- PRE = "rc1"
11
+ PRE = nil
12
12
 
13
13
  STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
14
14
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: actionpack
3
3
  version: !ruby/object:Gem::Version
4
- version: 5.1.4.rc1
4
+ version: 5.1.4
5
5
  platform: ruby
6
6
  authors:
7
7
  - David Heinemeier Hansson
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2017-08-24 00:00:00.000000000 Z
11
+ date: 2017-09-08 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activesupport
@@ -16,14 +16,14 @@ dependencies:
16
16
  requirements:
17
17
  - - '='
18
18
  - !ruby/object:Gem::Version
19
- version: 5.1.4.rc1
19
+ version: 5.1.4
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - '='
25
25
  - !ruby/object:Gem::Version
26
- version: 5.1.4.rc1
26
+ version: 5.1.4
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: rack
29
29
  requirement: !ruby/object:Gem::Requirement
@@ -92,28 +92,28 @@ dependencies:
92
92
  requirements:
93
93
  - - '='
94
94
  - !ruby/object:Gem::Version
95
- version: 5.1.4.rc1
95
+ version: 5.1.4
96
96
  type: :runtime
97
97
  prerelease: false
98
98
  version_requirements: !ruby/object:Gem::Requirement
99
99
  requirements:
100
100
  - - '='
101
101
  - !ruby/object:Gem::Version
102
- version: 5.1.4.rc1
102
+ version: 5.1.4
103
103
  - !ruby/object:Gem::Dependency
104
104
  name: activemodel
105
105
  requirement: !ruby/object:Gem::Requirement
106
106
  requirements:
107
107
  - - '='
108
108
  - !ruby/object:Gem::Version
109
- version: 5.1.4.rc1
109
+ version: 5.1.4
110
110
  type: :development
111
111
  prerelease: false
112
112
  version_requirements: !ruby/object:Gem::Requirement
113
113
  requirements:
114
114
  - - '='
115
115
  - !ruby/object:Gem::Version
116
- version: 5.1.4.rc1
116
+ version: 5.1.4
117
117
  description: Web apps on Rails. Simple, battle-tested conventions for building and
118
118
  testing MVC web applications. Works with any Rack-compatible server.
119
119
  email: david@loudthinking.com
@@ -298,13 +298,13 @@ required_ruby_version: !ruby/object:Gem::Requirement
298
298
  version: 2.2.2
299
299
  required_rubygems_version: !ruby/object:Gem::Requirement
300
300
  requirements:
301
- - - ">"
301
+ - - ">="
302
302
  - !ruby/object:Gem::Version
303
- version: 1.3.1
303
+ version: '0'
304
304
  requirements:
305
305
  - none
306
306
  rubyforge_project:
307
- rubygems_version: 2.6.12
307
+ rubygems_version: 2.6.13
308
308
  signing_key:
309
309
  specification_version: 4
310
310
  summary: Web-flow and rendering framework putting the VC in MVC (part of Rails).