actionpack 5.0.1.rc1 → 5.0.1.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec4e939e3051bb6e62c29b8e14be2cf7fd3c1067
-  data.tar.gz: 52f14ea10ddf0ee7e4536f52ee615e08377ac783
+  metadata.gz: 78120e6032355f83a541aea2b9244d9af059a336
+  data.tar.gz: a7363d48f334f9ce6da98514d719349041c400df
 SHA512:
-  metadata.gz: 558700b79b1d18c569d846bb1e44a3384c3e1c7f5dd6e4322f4d8a428b1d91e02cb5cc44b4e68facf0e6531f66dd05fcee2be7844c2f2320c5ac6b9763542a26
-  data.tar.gz: 7a8eee67d4a321617be9c909be937b7f0f0603404c731946d07b33a343bafc1e00656caef764c73b3ad6314625f44373a4db90d2255f6067906cd0def1476bd3
+  metadata.gz: 516c9c4d7c5993d2b6dbd6ff382fae0aff3b1789065431988f00c2a556ab5855b74e054575b1ec3f696479085369098973b3f0354d07300ae9f482562531b9d2
+  data.tar.gz: 8c7bc165fea6532ec1caec33fa10f9995e5af2b5c665c935c7e230e5bc6af552448ce3f00eedee229ca1b7716e5856f688835c49c7dd7919915335587dcc7571

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+## Rails 5.0.1.rc2 (December 10, 2016) ##
+
+*   Move `cookies`, `flash`, and `session` methods back to
+    `ActionDispatch::Integration::Session`.
+
+    *Matthew Draper*
+
+*   Do not reset in `ActionDispatch::IntegrationTest#open_session`; doing so
+    is incompatible with existing (unintended) API usage.
+
+    *Sean Griffin*
+
+
 ## Rails 5.0.1.rc1 (December 01, 2016) ##
 
 *   Fixed error caused by `force_ssl_redirect` when `session_store` is
@@ -119,6 +132,12 @@
 
     *David Chen*
 
+*   Reset a new session directly after its creation in `ActionDispatch::IntegrationTest#open_session`.
+
+    Fixes #22742.
+
+    *Tawan Sierek*
+
 *   Fix 'defaults' option for root route.
 
     A regression from some refactoring for the 5.0 release, this change

data/lib/action_dispatch/testing/integration.rb

@@ -140,7 +140,7 @@ module ActionDispatch
       DEFAULT_HOST = "www.example.com"
 
       include Minitest::Assertions
-      include RequestHelpers, Assertions
+      include TestProcess, RequestHelpers, Assertions
 
       %w( status status_message headers body redirect? ).each do |method|
         delegate method, :to => :response, :allow_nil => true
@@ -453,7 +453,6 @@ module ActionDispatch
       # simultaneously.
       def open_session
         dup.tap do |session|
-          session.reset!
           yield session if block_given?
         end
       end
@@ -685,7 +684,7 @@ module ActionDispatch
   # Consult the Rails Testing Guide for more.
 
   class IntegrationTest < ActiveSupport::TestCase
-    include TestProcess
+    include TestProcess::FixtureFile
 
     module UrlOptions
       extend ActiveSupport::Concern

data/lib/action_dispatch/testing/test_process.rb

@@ -3,6 +3,26 @@ require 'action_dispatch/middleware/flash'
 
 module ActionDispatch
   module TestProcess
+    module FixtureFile
+      # Shortcut for <tt>Rack::Test::UploadedFile.new(File.join(ActionDispatch::IntegrationTest.fixture_path, path), type)</tt>:
+      #
+      #   post :change_avatar, avatar: fixture_file_upload('files/spongebob.png', 'image/png')
+      #
+      # To upload binary files on Windows, pass <tt>:binary</tt> as the last parameter.
+      # This will not affect other platforms:
+      #
+      #   post :change_avatar, avatar: fixture_file_upload('files/spongebob.png', 'image/png', :binary)
+      def fixture_file_upload(path, mime_type = nil, binary = false)
+        if self.class.respond_to?(:fixture_path) && self.class.fixture_path &&
+            !File.exist?(path)
+          path = File.join(self.class.fixture_path, path)
+        end
+        Rack::Test::UploadedFile.new(path, mime_type, binary)
+      end
+    end
+
+    include FixtureFile
+
     def assigns(key = nil)
       raise NoMethodError,
         "assigns has been extracted to a gem. To continue using it,
@@ -24,21 +44,5 @@ module ActionDispatch
     def redirect_to_url
       @response.redirect_url
     end
-
-    # Shortcut for <tt>Rack::Test::UploadedFile.new(File.join(ActionDispatch::IntegrationTest.fixture_path, path), type)</tt>:
-    #
-    #   post :change_avatar, avatar: fixture_file_upload('files/spongebob.png', 'image/png')
-    #
-    # To upload binary files on Windows, pass <tt>:binary</tt> as the last parameter.
-    # This will not affect other platforms:
-    #
-    #   post :change_avatar, avatar: fixture_file_upload('files/spongebob.png', 'image/png', :binary)
-    def fixture_file_upload(path, mime_type = nil, binary = false)
-      if self.class.respond_to?(:fixture_path) && self.class.fixture_path &&
-          !File.exist?(path)
-        path = File.join(self.class.fixture_path, path)
-      end
-      Rack::Test::UploadedFile.new(path, mime_type, binary)
-    end
   end
 end

data/lib/action_pack/gem_version.rb

@@ -8,7 +8,7 @@ module ActionPack
     MAJOR = 5
     MINOR = 0
     TINY  = 1
-    PRE   = "rc1"
+    PRE   = "rc2"
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionpack
 version: !ruby/object:Gem::Version
-  version: 5.0.1.rc1
+  version: 5.0.1.rc2
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-30 00:00:00.000000000 Z
+date: 2016-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.1.rc1
+        version: 5.0.1.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.1.rc1
+        version: 5.0.1.rc2
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -92,28 +92,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.1.rc1
+        version: 5.0.1.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.1.rc1
+        version: 5.0.1.rc2
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.1.rc1
+        version: 5.0.1.rc2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.1.rc1
+        version: 5.0.1.rc2
 description: Web apps on Rails. Simple, battle-tested conventions for building and
   testing MVC web applications. Works with any Rack-compatible server.
 email: david@loudthinking.com