actionpack 4.0.1 → 4.2.11.1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of actionpack might be problematic. Click here for more details.

Files changed (241) hide show
  1. checksums.yaml +5 -5
  2. data/CHANGELOG.md +402 -1173
  3. data/MIT-LICENSE +1 -1
  4. data/README.rdoc +7 -7
  5. data/lib/abstract_controller/base.rb +39 -7
  6. data/lib/abstract_controller/callbacks.rb +32 -53
  7. data/lib/abstract_controller/collector.rb +11 -1
  8. data/lib/abstract_controller/helpers.rb +26 -16
  9. data/lib/abstract_controller/railties/routes_helpers.rb +3 -3
  10. data/lib/abstract_controller/rendering.rb +57 -127
  11. data/lib/abstract_controller/url_for.rb +1 -1
  12. data/lib/abstract_controller.rb +1 -2
  13. data/lib/action_controller/base.rb +19 -10
  14. data/lib/action_controller/caching/fragments.rb +7 -1
  15. data/lib/action_controller/caching.rb +2 -12
  16. data/lib/action_controller/log_subscriber.rb +29 -20
  17. data/lib/action_controller/metal/conditional_get.rb +37 -12
  18. data/lib/action_controller/metal/data_streaming.rb +1 -1
  19. data/lib/action_controller/metal/etag_with_template_digest.rb +50 -0
  20. data/lib/action_controller/metal/exceptions.rb +1 -1
  21. data/lib/action_controller/metal/flash.rb +17 -0
  22. data/lib/action_controller/metal/force_ssl.rb +2 -2
  23. data/lib/action_controller/metal/head.rb +8 -6
  24. data/lib/action_controller/metal/helpers.rb +6 -2
  25. data/lib/action_controller/metal/http_authentication.rb +45 -23
  26. data/lib/action_controller/metal/instrumentation.rb +9 -6
  27. data/lib/action_controller/metal/live.rb +173 -20
  28. data/lib/action_controller/metal/mime_responds.rb +127 -232
  29. data/lib/action_controller/metal/params_wrapper.rb +16 -9
  30. data/lib/action_controller/metal/rack_delegation.rb +1 -1
  31. data/lib/action_controller/metal/redirecting.rb +34 -26
  32. data/lib/action_controller/metal/renderers.rb +39 -12
  33. data/lib/action_controller/metal/rendering.rb +41 -14
  34. data/lib/action_controller/metal/request_forgery_protection.rb +147 -19
  35. data/lib/action_controller/metal/streaming.rb +19 -21
  36. data/lib/action_controller/metal/strong_parameters.rb +166 -22
  37. data/lib/action_controller/metal/testing.rb +0 -1
  38. data/lib/action_controller/metal/url_for.rb +11 -12
  39. data/lib/action_controller/metal.rb +14 -8
  40. data/lib/action_controller/model_naming.rb +1 -1
  41. data/lib/action_controller/railtie.rb +5 -1
  42. data/lib/action_controller/test_case.rb +160 -94
  43. data/lib/action_controller.rb +2 -18
  44. data/lib/action_dispatch/http/cache.rb +5 -4
  45. data/lib/action_dispatch/http/filter_parameters.rb +2 -2
  46. data/lib/action_dispatch/http/filter_redirect.rb +5 -4
  47. data/lib/action_dispatch/http/headers.rb +46 -10
  48. data/lib/action_dispatch/http/mime_negotiation.rb +31 -4
  49. data/lib/action_dispatch/http/mime_type.rb +25 -26
  50. data/lib/action_dispatch/http/mime_types.rb +1 -0
  51. data/lib/action_dispatch/http/parameter_filter.rb +1 -1
  52. data/lib/action_dispatch/http/parameters.rb +25 -41
  53. data/lib/action_dispatch/http/request.rb +49 -32
  54. data/lib/action_dispatch/http/response.rb +127 -25
  55. data/lib/action_dispatch/http/upload.rb +9 -21
  56. data/lib/action_dispatch/http/url.rb +97 -70
  57. data/lib/action_dispatch/journey/formatter.rb +35 -19
  58. data/lib/action_dispatch/journey/gtg/builder.rb +3 -3
  59. data/lib/action_dispatch/journey/gtg/simulator.rb +10 -7
  60. data/lib/action_dispatch/journey/gtg/transition_table.rb +23 -33
  61. data/lib/action_dispatch/journey/nfa/dot.rb +2 -2
  62. data/lib/action_dispatch/journey/nfa/simulator.rb +1 -1
  63. data/lib/action_dispatch/journey/nfa/transition_table.rb +5 -5
  64. data/lib/action_dispatch/journey/nodes/node.rb +4 -0
  65. data/lib/action_dispatch/journey/parser.rb +51 -59
  66. data/lib/action_dispatch/journey/parser.y +12 -10
  67. data/lib/action_dispatch/journey/path/pattern.rb +16 -19
  68. data/lib/action_dispatch/journey/route.rb +8 -19
  69. data/lib/action_dispatch/journey/router/strexp.rb +9 -6
  70. data/lib/action_dispatch/journey/router/utils.rb +54 -18
  71. data/lib/action_dispatch/journey/router.rb +53 -75
  72. data/lib/action_dispatch/journey/routes.rb +4 -0
  73. data/lib/action_dispatch/journey/scanner.rb +5 -5
  74. data/lib/action_dispatch/journey/visitors.rb +81 -60
  75. data/lib/action_dispatch/journey/visualizer/fsm.css +0 -4
  76. data/lib/action_dispatch/journey/visualizer/index.html.erb +2 -2
  77. data/lib/action_dispatch/middleware/callbacks.rb +7 -7
  78. data/lib/action_dispatch/middleware/cookies.rb +119 -43
  79. data/lib/action_dispatch/middleware/debug_exceptions.rb +32 -13
  80. data/lib/action_dispatch/middleware/exception_wrapper.rb +60 -20
  81. data/lib/action_dispatch/middleware/flash.rb +37 -24
  82. data/lib/action_dispatch/middleware/params_parser.rb +2 -2
  83. data/lib/action_dispatch/middleware/public_exceptions.rb +12 -3
  84. data/lib/action_dispatch/middleware/reloader.rb +11 -2
  85. data/lib/action_dispatch/middleware/remote_ip.rb +40 -54
  86. data/lib/action_dispatch/middleware/request_id.rb +1 -1
  87. data/lib/action_dispatch/middleware/session/cache_store.rb +3 -3
  88. data/lib/action_dispatch/middleware/session/cookie_store.rb +8 -7
  89. data/lib/action_dispatch/middleware/show_exceptions.rb +6 -2
  90. data/lib/action_dispatch/middleware/ssl.rb +10 -7
  91. data/lib/action_dispatch/middleware/static.rb +79 -23
  92. data/lib/action_dispatch/middleware/templates/rescues/{_request_and_response.erb → _request_and_response.html.erb} +0 -0
  93. data/lib/action_dispatch/middleware/templates/rescues/_request_and_response.text.erb +23 -0
  94. data/lib/action_dispatch/middleware/templates/rescues/_source.erb +21 -19
  95. data/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb +52 -0
  96. data/lib/action_dispatch/middleware/templates/rescues/_trace.text.erb +9 -0
  97. data/lib/action_dispatch/middleware/templates/rescues/{diagnostics.erb → diagnostics.html.erb} +1 -1
  98. data/lib/action_dispatch/middleware/templates/rescues/diagnostics.text.erb +9 -0
  99. data/lib/action_dispatch/middleware/templates/rescues/layout.erb +6 -0
  100. data/lib/action_dispatch/middleware/templates/rescues/missing_template.html.erb +11 -0
  101. data/lib/action_dispatch/middleware/templates/rescues/missing_template.text.erb +3 -0
  102. data/lib/action_dispatch/middleware/templates/rescues/{routing_error.erb → routing_error.html.erb} +3 -1
  103. data/lib/action_dispatch/middleware/templates/rescues/routing_error.text.erb +11 -0
  104. data/lib/action_dispatch/middleware/templates/rescues/template_error.html.erb +20 -0
  105. data/lib/action_dispatch/middleware/templates/rescues/template_error.text.erb +7 -0
  106. data/lib/action_dispatch/middleware/templates/rescues/{unknown_action.erb → unknown_action.html.erb} +1 -1
  107. data/lib/action_dispatch/middleware/templates/rescues/unknown_action.text.erb +3 -0
  108. data/lib/action_dispatch/middleware/templates/routes/_table.html.erb +120 -64
  109. data/lib/action_dispatch/railtie.rb +5 -2
  110. data/lib/action_dispatch/request/session.rb +12 -0
  111. data/lib/action_dispatch/request/utils.rb +35 -0
  112. data/lib/action_dispatch/routing/endpoint.rb +10 -0
  113. data/lib/action_dispatch/routing/inspector.rb +11 -17
  114. data/lib/action_dispatch/routing/mapper.rb +519 -312
  115. data/lib/action_dispatch/routing/polymorphic_routes.rb +204 -79
  116. data/lib/action_dispatch/routing/redirection.rb +51 -26
  117. data/lib/action_dispatch/routing/route_set.rb +331 -206
  118. data/lib/action_dispatch/routing/routes_proxy.rb +5 -4
  119. data/lib/action_dispatch/routing/url_for.rb +19 -5
  120. data/lib/action_dispatch/routing.rb +9 -6
  121. data/lib/action_dispatch/testing/assertions/dom.rb +2 -26
  122. data/lib/action_dispatch/testing/assertions/response.rb +9 -15
  123. data/lib/action_dispatch/testing/assertions/routing.rb +22 -22
  124. data/lib/action_dispatch/testing/assertions/selector.rb +2 -429
  125. data/lib/action_dispatch/testing/assertions/tag.rb +2 -134
  126. data/lib/action_dispatch/testing/assertions.rb +11 -7
  127. data/lib/action_dispatch/testing/integration.rb +31 -29
  128. data/lib/action_dispatch/testing/test_request.rb +1 -1
  129. data/lib/action_dispatch/testing/test_response.rb +1 -5
  130. data/lib/action_dispatch.rb +5 -8
  131. data/lib/action_pack/gem_version.rb +15 -0
  132. data/lib/action_pack/version.rb +4 -7
  133. data/lib/action_pack.rb +1 -1
  134. metadata +77 -159
  135. data/lib/abstract_controller/layouts.rb +0 -423
  136. data/lib/abstract_controller/view_paths.rb +0 -96
  137. data/lib/action_controller/deprecated/integration_test.rb +0 -5
  138. data/lib/action_controller/deprecated.rb +0 -7
  139. data/lib/action_controller/metal/responder.rb +0 -287
  140. data/lib/action_controller/record_identifier.rb +0 -31
  141. data/lib/action_controller/vendor/html-scanner.rb +0 -5
  142. data/lib/action_dispatch/middleware/templates/rescues/_trace.erb +0 -24
  143. data/lib/action_dispatch/middleware/templates/rescues/missing_template.erb +0 -7
  144. data/lib/action_dispatch/middleware/templates/rescues/template_error.erb +0 -43
  145. data/lib/action_view/base.rb +0 -201
  146. data/lib/action_view/buffers.rb +0 -49
  147. data/lib/action_view/context.rb +0 -36
  148. data/lib/action_view/dependency_tracker.rb +0 -93
  149. data/lib/action_view/digestor.rb +0 -113
  150. data/lib/action_view/flows.rb +0 -76
  151. data/lib/action_view/helpers/active_model_helper.rb +0 -49
  152. data/lib/action_view/helpers/asset_tag_helper.rb +0 -320
  153. data/lib/action_view/helpers/asset_url_helper.rb +0 -355
  154. data/lib/action_view/helpers/atom_feed_helper.rb +0 -203
  155. data/lib/action_view/helpers/cache_helper.rb +0 -196
  156. data/lib/action_view/helpers/capture_helper.rb +0 -216
  157. data/lib/action_view/helpers/controller_helper.rb +0 -25
  158. data/lib/action_view/helpers/csrf_helper.rb +0 -30
  159. data/lib/action_view/helpers/date_helper.rb +0 -1083
  160. data/lib/action_view/helpers/debug_helper.rb +0 -39
  161. data/lib/action_view/helpers/form_helper.rb +0 -1880
  162. data/lib/action_view/helpers/form_options_helper.rb +0 -838
  163. data/lib/action_view/helpers/form_tag_helper.rb +0 -785
  164. data/lib/action_view/helpers/javascript_helper.rb +0 -117
  165. data/lib/action_view/helpers/number_helper.rb +0 -441
  166. data/lib/action_view/helpers/output_safety_helper.rb +0 -38
  167. data/lib/action_view/helpers/record_tag_helper.rb +0 -106
  168. data/lib/action_view/helpers/rendering_helper.rb +0 -90
  169. data/lib/action_view/helpers/sanitize_helper.rb +0 -256
  170. data/lib/action_view/helpers/tag_helper.rb +0 -173
  171. data/lib/action_view/helpers/tags/base.rb +0 -148
  172. data/lib/action_view/helpers/tags/check_box.rb +0 -64
  173. data/lib/action_view/helpers/tags/checkable.rb +0 -16
  174. data/lib/action_view/helpers/tags/collection_check_boxes.rb +0 -44
  175. data/lib/action_view/helpers/tags/collection_helpers.rb +0 -84
  176. data/lib/action_view/helpers/tags/collection_radio_buttons.rb +0 -36
  177. data/lib/action_view/helpers/tags/collection_select.rb +0 -28
  178. data/lib/action_view/helpers/tags/color_field.rb +0 -25
  179. data/lib/action_view/helpers/tags/date_field.rb +0 -13
  180. data/lib/action_view/helpers/tags/date_select.rb +0 -72
  181. data/lib/action_view/helpers/tags/datetime_field.rb +0 -22
  182. data/lib/action_view/helpers/tags/datetime_local_field.rb +0 -19
  183. data/lib/action_view/helpers/tags/datetime_select.rb +0 -8
  184. data/lib/action_view/helpers/tags/email_field.rb +0 -8
  185. data/lib/action_view/helpers/tags/file_field.rb +0 -8
  186. data/lib/action_view/helpers/tags/grouped_collection_select.rb +0 -29
  187. data/lib/action_view/helpers/tags/hidden_field.rb +0 -8
  188. data/lib/action_view/helpers/tags/label.rb +0 -66
  189. data/lib/action_view/helpers/tags/month_field.rb +0 -13
  190. data/lib/action_view/helpers/tags/number_field.rb +0 -18
  191. data/lib/action_view/helpers/tags/password_field.rb +0 -12
  192. data/lib/action_view/helpers/tags/radio_button.rb +0 -31
  193. data/lib/action_view/helpers/tags/range_field.rb +0 -8
  194. data/lib/action_view/helpers/tags/search_field.rb +0 -24
  195. data/lib/action_view/helpers/tags/select.rb +0 -40
  196. data/lib/action_view/helpers/tags/tel_field.rb +0 -8
  197. data/lib/action_view/helpers/tags/text_area.rb +0 -18
  198. data/lib/action_view/helpers/tags/text_field.rb +0 -29
  199. data/lib/action_view/helpers/tags/time_field.rb +0 -13
  200. data/lib/action_view/helpers/tags/time_select.rb +0 -8
  201. data/lib/action_view/helpers/tags/time_zone_select.rb +0 -20
  202. data/lib/action_view/helpers/tags/url_field.rb +0 -8
  203. data/lib/action_view/helpers/tags/week_field.rb +0 -13
  204. data/lib/action_view/helpers/tags.rb +0 -39
  205. data/lib/action_view/helpers/text_helper.rb +0 -443
  206. data/lib/action_view/helpers/translation_helper.rb +0 -107
  207. data/lib/action_view/helpers/url_helper.rb +0 -635
  208. data/lib/action_view/helpers.rb +0 -58
  209. data/lib/action_view/locale/en.yml +0 -56
  210. data/lib/action_view/log_subscriber.rb +0 -30
  211. data/lib/action_view/lookup_context.rb +0 -241
  212. data/lib/action_view/model_naming.rb +0 -12
  213. data/lib/action_view/path_set.rb +0 -77
  214. data/lib/action_view/railtie.rb +0 -43
  215. data/lib/action_view/record_identifier.rb +0 -84
  216. data/lib/action_view/renderer/abstract_renderer.rb +0 -47
  217. data/lib/action_view/renderer/partial_renderer.rb +0 -492
  218. data/lib/action_view/renderer/renderer.rb +0 -50
  219. data/lib/action_view/renderer/streaming_template_renderer.rb +0 -103
  220. data/lib/action_view/renderer/template_renderer.rb +0 -96
  221. data/lib/action_view/routing_url_for.rb +0 -107
  222. data/lib/action_view/tasks/dependencies.rake +0 -17
  223. data/lib/action_view/template/error.rb +0 -138
  224. data/lib/action_view/template/handlers/builder.rb +0 -26
  225. data/lib/action_view/template/handlers/erb.rb +0 -146
  226. data/lib/action_view/template/handlers/raw.rb +0 -11
  227. data/lib/action_view/template/handlers.rb +0 -53
  228. data/lib/action_view/template/resolver.rb +0 -326
  229. data/lib/action_view/template/text.rb +0 -34
  230. data/lib/action_view/template/types.rb +0 -57
  231. data/lib/action_view/template.rb +0 -339
  232. data/lib/action_view/test_case.rb +0 -270
  233. data/lib/action_view/testing/resolvers.rb +0 -50
  234. data/lib/action_view/vendor/html-scanner/html/document.rb +0 -68
  235. data/lib/action_view/vendor/html-scanner/html/node.rb +0 -532
  236. data/lib/action_view/vendor/html-scanner/html/sanitizer.rb +0 -188
  237. data/lib/action_view/vendor/html-scanner/html/selector.rb +0 -830
  238. data/lib/action_view/vendor/html-scanner/html/tokenizer.rb +0 -107
  239. data/lib/action_view/vendor/html-scanner/html/version.rb +0 -11
  240. data/lib/action_view/vendor/html-scanner.rb +0 -20
  241. data/lib/action_view.rb +0 -93
data/CHANGELOG.md CHANGED
@@ -1,1451 +1,680 @@
1
- ## Rails 4.0.1 (November 01, 2013) ##
1
+ ## Rails 4.2.11.1 (March 11, 2019) ##
2
2
 
3
- * Respect `SCRIPT_NAME` when using `redirect` with a relative path
3
+ * No changes.
4
4
 
5
- Example:
6
- # application routes.rb
7
- mount BlogEngine => '/blog'
8
-
9
- # engine routes.rb
10
- get '/admin' => redirect('admin/dashboard')
11
-
12
- This now redirects to the path `/blog/admin/dashboard`, whereas before it would've
13
- generated an invalid url because there would be no slash between the host name and
14
- the path. It also allows redirects to work where the application is deployed to a
15
- subdirectory of a website.
16
-
17
- Fixes #7977.
18
-
19
- *Andrew White*
20
-
21
- * Fix `ActionDispatch::RemoteIp::GetIp#calculate_ip` to only check for spoofing
22
- attacks if both `HTTP_CLIENT_IP` and `HTTP_X_FORWARDED_FOR` are set.
23
-
24
- Fixes #10844.
25
-
26
- *Tamir Duberstein*
27
-
28
- * Strong parameters should permit nested number as key.
29
-
30
- Fixes #12293.
31
-
32
- *kennyj*
33
-
34
- * Fix `collection_check_boxes` generated hidden input to use the name attribute provided
35
- in the options hash.
36
-
37
- *Angel N. Sciortino*
38
-
39
- * Fix some edge cases for AV `select` helper with `:selected` option
40
-
41
- *Bogdan Gusiev*
42
-
43
- * Handle `:namespace` form option in collection labels
44
-
45
- *Vasiliy Ermolovich*
46
-
47
- * Fix an issue where router can't recognize downcased url encoding path.
48
-
49
- Fixes #12269.
50
-
51
- *kennyj*
52
-
53
- * Fix custom flash type definition. Misusage of the `_flash_types` class variable
54
- caused an error when reloading controllers with custom flash types.
55
-
56
- Fixes #12057.
57
-
58
- *Ricardo de Cillo*
59
-
60
- * Do not break params filtering on `nil` values.
61
-
62
- Fixes #12149.
63
-
64
- *Vasiliy Ermolovich*
65
-
66
- * Fix `excerpt` when `:separator` is `nil`.
67
-
68
- *Paul Nikitochkin*
69
-
70
- * Make Live Streaming work with basic authentication or builder.
71
-
72
- Fixes #10984.
73
-
74
- *Aaron Patterson*
75
-
76
- * Always use `Rack::Sendfile` to make possible to it be automatically
77
- configured by the webserver.
78
-
79
- Fixes #11440.
80
-
81
- *Martin Schürrer*
82
-
83
- * Flag cookies as secure with ignore case in `ActionDispatch::SSL`.
84
-
85
- *Yamagishi Kazutoshi*
86
-
87
- * Don't include STS header in non-HTTPS responses.
88
-
89
- *Geoff Buesing*
90
-
91
- * Fix an issue where rails raise exception about missing helper where it
92
- should throw `LoadError`. When helper file exists and only loaded file from
93
- this helper does not exist rails should throw LoadError instead of
94
- `MissingHelperError`.
95
-
96
- *Piotr Niełacny*
97
-
98
- * Only cache template digests if `config.cache_template_loading` is true.
99
5
 
100
- *Josh Lauer*, *Justin Ridgewell*
6
+ ## Rails 4.2.11 (November 27, 2018) ##
101
7
 
102
- * Fix an issue where `:if` and `:unless` controller action procs were being run
103
- before checking for the correct action in the `:only` and `:unless` options.
8
+ * No changes.
104
9
 
105
- Fixes #11799.
106
10
 
107
- *Nicholas Jakobsen*
11
+ ## Rails 4.2.10 (September 27, 2017) ##
108
12
 
109
- * Fix an issue where `assert_dom_equal` and `assert_dom_not_equal` were
110
- ignoring the passed failure message argument.
13
+ * Fix regression in behavior of `normalize_path`.
111
14
 
112
- Fixes #11751.
15
+ In Rails 5 there was a change to ensure the encoding of the original string
16
+ in a path was maintained. This was incorrectly backported to Rails 4.2 which
17
+ caused a regression.
113
18
 
114
- *Ryan McGeary*
19
+ *Eileen M. Uchitelle*
115
20
 
116
- * Fix `current_page?` when the URL contains escaped characters and the
117
- original URL is using the hexadecimal lowercased.
21
+ ## Rails 4.2.9 (June 26, 2017) ##
118
22
 
119
- *Rafael Mendonça França*
120
-
121
- * Allow `REMOTE_ADDR`, `HTTP_HOST` and `HTTP_USER_AGENT` to be overridden from
122
- the environment passed into `ActionDispatch::TestRequest.new`.
123
-
124
- Fixes #11590.
125
-
126
- *Andrew White*
127
-
128
- * Fix `text_area` to behave like `text_field` when `nil` is given as
129
- value.
23
+ * Use more specific check for :format in route path
130
24
 
131
- Before:
25
+ The current check for whether to add an optional format to the path is very lax
26
+ and will match things like `:format_id` where there are nested resources, e.g:
132
27
 
133
- f.text_field :field, value: nil #=> <input value="">
134
- f.text_area :field, value: nil #=> <textarea>value of field</textarea>
28
+ ``` ruby
29
+ resources :formats do
30
+ resources :items
31
+ end
32
+ ```
135
33
 
136
- After:
34
+ Fix this by using a more restrictive regex pattern that looks for the patterns
35
+ `(.:format)`, `.:format` or `/` at the end of the path. Note that we need to
36
+ allow for multiple closing parenthesis since the route may be of this form:
137
37
 
138
- f.text_area :field, value: nil #=> <textarea></textarea>
38
+ ``` ruby
39
+ get "/books(/:action(.:format))", controller: "books"
40
+ ```
139
41
 
140
- *Joel Cogen*
42
+ This probably isn't what's intended since it means that the default index action
43
+ route doesn't support a format but we have a test for it so we need to allow it.
141
44
 
142
- * Fix an issue where Journey was failing to clear the named routes hash when the
143
- routes were reloaded and since it doesn't overwrite existing routes then if a
144
- route changed but wasn't renamed it kept the old definition. This was being
145
- masked by the optimised url helpers so it only became apparent when passing an
146
- options hash to the url helper.
45
+ Fixes #28517.
147
46
 
148
47
  *Andrew White*
149
48
 
150
- * Skip routes pointing to a redirect or mounted application when generating urls
151
- using an options hash as they aren't relevant and generate incorrect urls.
152
-
153
- Fixes #8018.
154
-
155
- *Andrew White*
156
-
157
- * Fix default rendered format problem when calling `render` without `:content_type` option.
158
- It should return `:html`.
159
-
160
- Fixes #11393.
161
49
 
162
- *Gleb Mazovetskiy*, *Oleg*, *kennyj*
50
+ ## Rails 4.2.8 (February 21, 2017) ##
163
51
 
164
- * Fix `ActionDispatch::ParamsParser#parse_formatted_parameters` to rewind body input stream on
165
- parsing json params.
52
+ * No changes.
166
53
 
167
- Fixes #11345.
168
-
169
- *Yuri Bol*, *Paul Nikitochkin*
170
-
171
- * Fix `link_to` with block and url hashes.
172
-
173
- Before:
174
-
175
- link_to(action: 'bar', controller: 'foo') { content_tag(:span, 'Example site') }
176
- # => "<a action=\"bar\" controller=\"foo\"><span>Example site</span></a>"
177
-
178
- After:
179
-
180
- link_to(action: 'bar', controller: 'foo') { content_tag(:span, 'Example site') }
181
- # => "<a href=\"/foo/bar\"><span>Example site</span></a>"
182
-
183
- *Murahashi Sanemat Kenichi*
184
-
185
- * Fix "Stack Level Too Deep" error when redering recursive partials.
186
-
187
- Fixes #11340.
188
-
189
- *Rafael Mendonça França*
190
54
 
191
- * Pick `DateField` `DateTimeField` and `ColorField` values from stringified options allowing use of symbol keys with helpers.
55
+ ## Rails 4.2.7 (July 12, 2016) ##
192
56
 
193
- *Jon Rowe*
57
+ * No changes.
194
58
 
195
- * Fix `Mime::Type.parse` when bad accepts header is looked up. Previously it
196
- was setting `request.formats` with an array containing a `nil` value, which
197
- raised an error when setting the controller formats.
198
59
 
199
- Fixes #10965.
60
+ ## Rails 4.2.6 (March 07, 2016) ##
200
61
 
201
- *Becker*
62
+ * No changes.
202
63
 
203
- * Always escape the result of `link_to_unless` method.
204
64
 
205
- Before:
65
+ ## Rails 4.2.5.2 (February 26, 2016) ##
206
66
 
207
- link_to_unless(true, '<b>Showing</b>', 'github.com')
208
- # => "<b>Showing</b>"
67
+ * Do not allow render with unpermitted parameter.
209
68
 
210
- After:
69
+ Fixes CVE-2016-2098.
211
70
 
212
- link_to_unless(true, '<b>Showing</b>', 'github.com')
213
- # => "&lt;b&gt;Showing&lt;/b&gt;"
71
+ *Arthur Neves*
214
72
 
215
- *dtaniwaki*
216
73
 
74
+ ## Rails 4.2.5.1 (January 25, 2015) ##
217
75
 
218
- ## Rails 4.0.0 (June 25, 2013) ##
76
+ * No changes.
219
77
 
220
- * Merge `:action` from routing scope and assign endpoint if both `:controller`
221
- and `:action` are present. The endpoint assignment only occurs if there is
222
- no `:to` present in the options hash so should only affect routes using the
223
- shorthand syntax (i.e. endpoint is inferred from the the path).
224
78
 
225
- Fixes #9856
79
+ ## Rails 4.2.5 (November 12, 2015) ##
226
80
 
227
- *Yves Senn*, *Andrew White*
81
+ * `ActionController::TestCase` can teardown gracefully if an error is raised
82
+ early in the `setup` chain.
228
83
 
229
- * Use a case insensitive URI Regexp for #asset_path.
230
-
231
- This fix a problem where the same asset path using different case are generating
232
- different URIs.
233
-
234
- Before:
235
-
236
- image_tag("HTTP://google.com")
237
- # => "<img alt=\"Google\" src=\"/assets/HTTP://google.com\" />"
238
- image_tag("http://google.com")
239
- # => "<img alt=\"Google\" src=\"http://google.com\" />"
84
+ *Yves Senn*
240
85
 
241
- After:
86
+ * Parse RSS/ATOM responses as XML, not HTML.
242
87
 
243
- image_tag("HTTP://google.com")
244
- # => "<img alt=\"Google\" src=\"HTTP://google.com\" />"
245
- image_tag("http://google.com")
246
- # => "<img alt=\"Google\" src=\"http://google.com\" />"
88
+ *Alexander Kaupanin*
247
89
 
248
- *David Celis*
90
+ * Fix regression in mounted engine named routes generation for app deployed to
91
+ a subdirectory. `relative_url_root` was prepended to the path twice (e.g.
92
+ "/subdir/subdir/engine_path" instead of "/subdir/engine_path")
249
93
 
250
- * Add `has_named_route?(route_name)` to the mapper API.
94
+ Fixes #20920. Fixes #21459.
251
95
 
252
- *José Valim*
96
+ *Matthew Erhard*
253
97
 
254
- * Fix an issue where partials with a number in the filename weren't being digested for cache dependencies.
98
+ * `url_for` does not modify its arguments when generating polymorphic URLs.
255
99
 
256
- *Bryan Ricker*
100
+ *Bernerd Schaefer*
257
101
 
258
- * Add support for passing custom url options other than `:host` and custom
259
- status and flash options to `force_ssl`.
102
+ * Update `ActionController::TestSession#fetch` to behave more like
103
+ `ActionDispatch::Request::Session#fetch` when using non-string keys.
260
104
 
261
- *Andrew White*
105
+ *Jeremy Friesen*
262
106
 
263
- * The `force_ssl` command now builds the redirect url from `request.fullpath`.
264
- This ensures that the format is maintained and it doesn't redirect to a route
265
- that has the same parameters but is defined earlier in `routes.rb`. Also any
266
- optional segments are maintained.
267
107
 
268
- Fixes #7528, #9061, #10305.
108
+ ## Rails 4.2.4 (August 24, 2015) ##
269
109
 
270
- *Andrew White*
110
+ * ActionController::TestSession now accepts a default value as well as
111
+ a block for generating a default value based off the key provided.
271
112
 
272
- * Return a 405 Method Not Allowed response when a request contains an unknown
273
- HTTP method.
113
+ This fixes calls to session#fetch in ApplicationController instances that
114
+ take more two arguments or a block from raising `ArgumentError: wrong
115
+ number of arguments (2 for 1)` when performing controller tests.
274
116
 
275
- *Lewis Marshall*
117
+ *Matthew Gerrior*
276
118
 
277
- * Add support for extracting the port from the `:host` option passed to `url_for`.
119
+ * Fix to keep original header instance in `ActionDispatch::SSL`
278
120
 
279
- *Andrew White*
121
+ `ActionDispatch::SSL` changes headers to `Hash`.
122
+ So some headers will be broken if there are some middlewares
123
+ on `ActionDispatch::SSL` and if it uses `Rack::Utils::HeaderHash`.
280
124
 
281
- * Add support for removing the subdomain from a url by passing `nil`, `false` or `''`.
282
- Fixes #10180.
125
+ *Fumiaki Matsushima*
283
126
 
284
- *Derek Watson + Andrew White*
285
127
 
286
- * Element of the collection for `options_from_collection_for_select` helper can
287
- optionally contain html attributes as the last element of the array as
288
- `options_for_select` helper.
128
+ ## Rails 4.2.3 (June 25, 2015) ##
289
129
 
290
- *Vasiliy Ermolovich*
130
+ * Fix rake routes not showing the right format when
131
+ nesting multiple routes.
291
132
 
292
- * Fix explicit names on multiple file fields. If a file field tag has
293
- the multiple option, it is turned into an array field (appending `[]`),
294
- but if an explicit name is passed to `file_field` the `[]` is not
295
- appended.
296
- Fixes #9830.
133
+ See #18373.
297
134
 
298
- *Ryan McGeary*
135
+ *Ravil Bayramgalin*
299
136
 
300
- * Add block support for the `mail_to` helper, similar to the `link_to` helper.
137
+ * Fix regression where a gzip file response would have a Content-type,
138
+ even when it was a 304 status code.
301
139
 
302
- *Sam Pohlenz*
140
+ See #19271.
303
141
 
304
- * Automatically configure cookie-based sessions to be encrypted if
305
- `secret_key_base` is set, falling back to signed if only `secret_token`
306
- is set. Automatically upgrade existing signed cookie-based sessions from
307
- Rails 3.x to be encrypted if both `secret_key_base` and `secret_token`
308
- are set, or signed with the new key generator if only `secret_token` is
309
- set. This leaves only the `config.session_store :cookie_store` option and
310
- removes the two new options introduced in 4.0.0.beta1:
311
- `encrypted_cookie_store` and `upgrade_signature_to_encryption_cookie_store`.
142
+ *Kohei Suzuki*
312
143
 
313
- *Trevor Turk*
144
+ * Fix handling of empty X_FORWARDED_HOST header in raw_host_with_port
314
145
 
315
- * Ensure consistent fallback to the default layout lookup for layouts set
316
- using symbols or procs that return `nil`.
146
+ Previously, an empty X_FORWARDED_HOST header would cause
147
+ Actiondispatch::Http:URL.raw_host_with_port to return nil, causing
148
+ Actiondispatch::Http:URL.host to raise a NoMethodError.
317
149
 
318
- All of the following layouts will result in the default layout lookup:
150
+ *Adam Forsyth*
319
151
 
320
- layout nil
152
+ * Fallback to `ENV['RAILS_RELATIVE_URL_ROOT']` in `url_for`.
321
153
 
322
- layout proc { nil }
154
+ Fixed an issue where the `RAILS_RELATIVE_URL_ROOT` environment variable is not
155
+ prepended to the path when `url_for` is called. If `SCRIPT_NAME` (used by Rack)
156
+ is set, it takes precedence.
323
157
 
324
- layout :returns_nil
325
- def returns_nil
326
- nil
327
- end
158
+ Fixes #5122.
328
159
 
329
- Previously symbols and procs which returned `nil` resulted in no layout which
330
- differed from the `layout nil` behavior. To get the "no layout" behavior just
331
- return `false` instead of `nil` for `layout`.
160
+ *Yasyf Mohamedali*
332
161
 
333
- *Chris Nicola*
162
+ * Fix regression in functional tests. Responses should have default headers
163
+ assigned.
334
164
 
335
- * Create `UpgradeLegacySignedCookieJar` to transparently upgrade existing signed
336
- cookies generated by Rails 3.x to avoid invalidating them when upgrading to Rails 4.x.
165
+ See #18423.
337
166
 
338
- *Trevor Turk + Neeraj Singh*
167
+ *Jeremy Kemper*, *Yves Senn*
339
168
 
340
- * Raise an `ArgumentError` when a clashing named route is defined.
341
169
 
342
- *Trevor Turk*
170
+ ## Rails 4.2.2 (June 16, 2015) ##
343
171
 
344
- * Allow default url options to accept host with protocol such as `http://`
172
+ * No Changes *
345
173
 
346
- config.action_mailer.default_url_options = { host: "http://mydomain.com" }
347
-
348
- *Richard Schneeman*
349
174
 
350
- * Ensure that digest authentication responds with a 401 status when a basic
351
- header is received.
175
+ ## Rails 4.2.1 (March 19, 2015) ##
352
176
 
353
- *Brad Dunbar*
177
+ * Non-string authenticity tokens do not raise NoMethodError when decoding
178
+ the masked token.
354
179
 
355
- * Include I18n locale fallbacks in view lookup.
356
- Fixes #3512.
180
+ *Ville Lautanala*
357
181
 
358
- *Juan Barreneche*
182
+ * Explicitly ignored wildcard verbs when searching for HEAD routes before fallback
359
183
 
360
- * Integration and functional tests allow headers and rack env
361
- variables to be passed when performing requests.
362
- Fixes #6513.
184
+ Fixes an issue where a mounted rack app at root would intercept the HEAD
185
+ request causing an incorrect behavior during the fall back to GET requests.
363
186
 
364
187
  Example:
188
+ ```ruby
189
+ draw do
190
+ get '/home' => 'test#index'
191
+ mount rack_app, at: '/'
192
+ end
193
+ head '/home'
194
+ assert_response :success
195
+ ```
196
+ In this case, a HEAD request runs through the routes the first time and fails
197
+ to match anything. Then, it runs through the list with the fallback and matches
198
+ `get '/home'`. The original behavior would match the rack app in the first pass.
365
199
 
366
- # integration test
367
- get "/success", {}, "HTTP_REFERER" => "http://test.com/",
368
- "Accepts" => "text/plain, text/html"
200
+ *Terence Sun*
369
201
 
370
- # functional test
371
- @request.headers["Accepts"] = "text/plain, text/html"
202
+ * Preserve default format when generating URLs
372
203
 
373
- *Yves Senn*
374
-
375
- * Http::Headers respects headers that are not prefixed with HTTP_
204
+ Fixes an issue that would cause the format set in default_url_options to be
205
+ lost when generating URLs with fewer positional arguments than parameters in
206
+ the route definition.
376
207
 
377
- *Yves Senn*
208
+ Backport of #18627
378
209
 
379
- * Fix incorrectly appended square brackets to a multiple select box
380
- if an explicit name has been given and it already ends with "[]"
210
+ *Tekin Suleyman*, *Dominic Baggott*
381
211
 
382
- Before:
212
+ * Default headers, removed in controller actions, are no longer reapplied on
213
+ the test response.
383
214
 
384
- select(:category, [], {}, multiple: true, name: "post[category][]")
385
- # => <select name="post[category][][]" ...>
215
+ *Jonas Baumann*
386
216
 
387
- After:
217
+ * Ensure `append_info_to_payload` is called even if an exception is raised.
388
218
 
389
- select(:category, [], {}, multiple: true, name: "post[category][]")
390
- # => <select name="post[category][]" ...>
219
+ Fixes an issue where when an exception is raised in the request the additonal
220
+ payload data is not available.
391
221
 
392
- *Olek Janiszewski*
222
+ See:
223
+ * #14903
224
+ * https://github.com/roidrage/lograge/issues/37
393
225
 
394
- * Fixed regression when using `assert_template` to verify files sent using
395
- `render file: 'README.md'`.
396
- Fixes #9464.
226
+ *Dieter Komendera*, *Margus Pärt*
397
227
 
398
- *Justin Coyne*
228
+ * Correctly rely on the response's status code to handle calls to `head`.
399
229
 
400
- * Fixed `ActionView::Helpers::CaptureHelper#content_for` regression when trying to use it in
401
- a boolean statement.
402
- Fixes #9360.
230
+ *Robin Dupret*
403
231
 
404
- *Nikolay Shebanov*
232
+ * Using `head` method returns empty response_body instead
233
+ of returning a single space " ".
405
234
 
406
- * `format: true` does not override existing format constraints.
407
- Fixes #9466.
408
-
409
- Example:
235
+ The old behavior was added as a workaround for a bug in an early
236
+ version of Safari, where the HTTP headers are not returned correctly
237
+ if the response body has a 0-length. This is been fixed since and
238
+ the workaround is no longer necessary.
410
239
 
411
- # This will force the .json extension.
412
- get '/json_only', to: ok, format: true, constraints: { format: /json/ }
240
+ Fixes #18253.
413
241
 
414
- *Yves Senn*
242
+ *Prathamesh Sonpatki*
415
243
 
416
- * Skip valid encoding checks for non-String parameters that come
417
- from the matched route's defaults.
418
- Fixes #9435.
244
+ * Fix how polymorphic routes works with objects that implement `to_model`.
419
245
 
420
- Example:
246
+ *Travis Grathwell*
421
247
 
422
- root to: 'main#posts', page: 1
248
+ * Fixed handling of positional url helper arguments when `format: false`.
423
249
 
424
- *Yves Senn*
250
+ Fixes #17819.
425
251
 
426
- * Don't verify Regexp requirements for non-Regexp `:constraints`.
427
- Fixes #9432.
252
+ *Andrew White*, *Tatiana Soukiassian*
428
253
 
429
- Example:
254
+ * Fixed usage of optional scopes in URL helpers.
430
255
 
431
- get '/photos.:format' => 'feeds#photos', constraints: {format: 'xml'}
256
+ *Alex Robbin*
432
257
 
433
- *Yves Senn*
434
258
 
435
- * Make `ActionDispatch::Journey::Path::Pattern#new` raise more meaningful exception message.
259
+ ## Rails 4.2.0 (December 20, 2014) ##
436
260
 
437
- *Thierry Zires*
438
-
439
- * Fix `respond_to` not using formats that have no block if all is present. *Michael Grosser*
440
-
441
- * New applications use an encrypted session store by default.
442
-
443
- *Santiago Pastorino*
444
-
445
- * Determine the controller#action from only the matched path when using the
446
- shorthand syntax. Previously the complete path was used, which led
447
- to problems with nesting (scopes and namespaces).
448
- Fixes #7554.
449
-
450
- Example:
451
-
452
- # This will route to questions#new.
453
- scope ':locale' do
454
- get 'questions/new'
455
- end
456
-
457
- *Yves Senn*
458
-
459
- * Remove support for parsing XML parameters from request. If you still want to parse XML
460
- parameters, please install `actionpack-xml_parser' gem.
261
+ * Add `ActionController::Parameters#to_unsafe_h` to return an unfiltered
262
+ `Hash` representation of Parameters object. This is now a preferred way to
263
+ retrieve unfiltered parameters as we will stop inheriting `AC::Parameters`
264
+ object in Rails 5.0.
461
265
 
462
266
  *Prem Sichanugrist*
463
267
 
464
- * Remove support for parsing YAML parameters from request.
465
-
466
- *Aaron Patterson*
467
-
468
- * Add a message when you have no routes defined to both `rake routes` and
469
- GET "/rails/info/routes" that lets you know you have none defined and links
470
- to the Rails guide on the topic.
471
-
472
- *Steve Klabnik*
268
+ * Restore handling of a bare `Authorization` header, without `token=`
269
+ prefix.
473
270
 
474
- * Change `image_alt` method to replace underscores/hyphens to spaces in filenames.
271
+ Fixes #17108.
475
272
 
476
- Previously, underscored filenames became `alt="A_long_file_name_with_underscores"`
477
- in HTML, which is poor for accessibility. For instance, Apple's VoiceOver Utility
478
- pronounces each underscore. `A_long_file_name` thus would be read as `A underscore
479
- long underscore file underscore name.` Now underscored or hyphenated filenames
480
- (both of which are very popular naming conventions) read more naturally in
481
- screen readers by converting both hyphens and underscores to spaces.
273
+ *Guo Xiang Tan*
482
274
 
483
- Before:
275
+ * Deprecate use of string keys in URL helpers.
484
276
 
485
- image_tag('underscored_file_name.png')
486
- # => <img alt="Underscored_file_name" src="/assets/underscored_file_name.png" />
277
+ Use symbols instead.
278
+ Fixes #16958.
487
279
 
488
- After:
280
+ *Byron Bischoff*, *Melanie Gilman*
489
281
 
490
- image_tag('underscored_file_name.png')
491
- # => <img alt="Underscored file name" src="/assets/underscored_file_name.png" />
282
+ * Deprecate the `only_path` option on `*_path` helpers.
492
283
 
493
- *Nick Cox*
284
+ In cases where this option is set to `true`, the option is redundant and can
285
+ be safely removed; otherwise, the corresponding `*_url` helper should be
286
+ used instead.
494
287
 
495
- * We don't support Ruby constant notation in the `:controller` option for route
496
- definitions. So, this raises an `ArgumentError` now:
288
+ Fixes #17294.
497
289
 
498
- resources :posts, controller: "Admin::Posts" # WRONG
290
+ *Dan Olson*, *Godfrey Chan*
499
291
 
500
- Use path notation instead:
501
-
502
- resources :posts, controller: "admin/posts" # RIGHT
503
-
504
- *Yves Senn*
292
+ * Improve Journey compliance to RFC 3986.
505
293
 
506
- * `assert_template` can be used to verify the locals of partials,
507
- which live inside a directory.
508
-
509
- # Prefixed partials inside directories worked and still work.
510
- assert_template partial: 'directory/_partial', locals: {name: 'John'}
511
-
512
- # This did not work but does now.
513
- assert_template partial: 'directory/partial', locals: {name: 'John'}
514
-
515
- Fixes #8516.
516
-
517
- *Yves Senn*
294
+ The scanner in Journey failed to recognize routes that use literals
295
+ from the sub-delims section of RFC 3986. It's now able to parse those
296
+ authorized delimiters and route as expected.
518
297
 
519
- * Fix `content_tag_for` with array HTML option.
520
- It would embed array as string instead of joining it like `content_tag` does:
298
+ Fixes #17212.
521
299
 
522
- content_tag(:td, class: ["foo", "bar"]){}
523
- # => <td class="foo bar"></td>
524
-
525
- Before:
526
-
527
- content_tag_for(:td, item, class: ["foo", "bar"])
528
- # => <td class="item [&quot;foo&quot;, &quot;bar&quot;]" id="item_1"></td>
529
-
530
- After:
531
-
532
- content_tag_for(:td, item, class: ["foo", "bar"])
533
- # => <td class="item foo bar" id="item_1"></td>
534
-
535
- *Semyon Perepelitsa*
536
-
537
- * Remove `BestStandardsSupport` middleware, !DOCTYPE html already triggers
538
- standards mode per http://msdn.microsoft.com/en-us/library/jj676915(v=vs.85).aspx
539
- and ChromeFrame header has been moved to `config.action_dispatch.default_headers`
540
-
541
- *Guillermo Iguaran*
542
-
543
- * Fix CSRF protection and `current_url?` helper to work with HEAD requests
544
- now that `ActionDispatch::Head` has been removed in favor of `Rack::Head`.
545
-
546
- *Michiel Sikkes*
547
-
548
- * Change `asset_path` to not include `SCRIPT_NAME` when it's used
549
- from a mounted engine. Fixes #8119.
550
-
551
- *Piotr Sarnacki*
552
-
553
- * Add JavaScript based routing path matcher to `/rails/info/routes`.
554
- Routes can now be filtered by whether or not they match a path.
555
-
556
- *Richard Schneeman*
557
-
558
- * Change the behavior of route defaults so that explicit defaults are no longer
559
- required where the key is not part of the path. For example:
560
-
561
- resources :posts, bucket_type: 'posts'
562
-
563
- will be required whenever constructing the url from a hash such as a functional
564
- test or using `url_for` directly. However using the explicit form alters the
565
- behavior so it's not required:
566
-
567
- resources :projects, defaults: { bucket_type: 'projects' }
568
-
569
- This changes existing behavior slightly in that any routes which only differ
570
- in their defaults will match the first route rather than the closest match.
571
-
572
- *Andrew White*
300
+ *Nicolas Cavigneaux*
573
301
 
574
- * Add support for routing constraints other than Regexp and String.
575
- For example this now allows the use of arrays like this:
302
+ * Deprecate implicit Array conversion for Response objects. It was added
303
+ (using `#to_ary`) so we could conveniently use implicit splatting:
576
304
 
577
- get '/foo/:action', to: 'foo', constraints: { subdomain: %w[www admin] }
305
+ status, headers, body = response
578
306
 
579
- or constraints where the request method returns an Fixnum like this:
307
+ But it also means `response + response` works and `[response].flatten`
308
+ cascades down to the Rack body. Nonsense behavior. Instead, rely on
309
+ explicit conversion and splatting with `#to_a`:
580
310
 
581
- get '/foo', to: 'foo#index', constraints: { port: 8080 }
311
+ status, header, body = *response
582
312
 
583
- Note that this only applies to constraints on the request - path constraints
584
- still need to be specified as Regexps as the various constraints are compiled
585
- into a single Regexp.
586
-
587
- *Andrew White*
588
-
589
- * Fix a bug in integration tests where setting the port via a url passed to
590
- the process method was ignored when constructing the request environment.
591
-
592
- *Andrew White*
593
-
594
- * Allow `:selected` to be set on `date_select` tag helper.
595
-
596
- *Colin Burn-Murdoch*
597
-
598
- * Fixed JSON params parsing regression for non-object JSON content.
599
-
600
- *Dylan Smith*
601
-
602
- * Extract `ActionDispatch::PerformanceTest` into https://github.com/rails/rails-perftest
603
- You can add the gem to your Gemfile to keep using performance tests.
604
-
605
- gem 'rails-perftest'
606
-
607
- *Yves Senn*
608
-
609
- * Added view_cache_dependency API for declaring dependencies that affect
610
- cache digest computation.
611
-
612
- *Jamis Buck*
613
-
614
- * `image_submit_tag` will set `alt` attribute from image source if not
615
- specified.
616
-
617
- *Nihad Abbasov*
618
-
619
- * Do not generate local variables for partials without object or collection.
620
- Previously rendering a partial without giving `:object` or `:collection`
621
- would generate a local variable with the partial name by default.
622
-
623
- *Carlos Antonio da Silva*
624
-
625
- * Return the last valid, non-private IP address from the X-Forwarded-For,
626
- Client-IP and Remote-Addr headers, in that order. Document the rationale
627
- for that decision, and describe the options that can be passed to the
628
- RemoteIp middleware to change it.
629
- Fixes #7979.
630
-
631
- *André Arko*, *Steve Klabnik*, *Alexey Gaziev*
632
-
633
- * Do not append second slash to `root_url` when using `trailing_slash: true`
634
- Fixes #8700.
635
-
636
- Before:
637
-
638
- root_url(trailing_slash: true) # => http://test.host//
639
-
640
- After:
641
-
642
- root_url(trailing_slash: true) # => http://test.host/
643
-
644
- *Yves Senn*
645
-
646
- * Allow to toggle dumps on error pages.
647
-
648
- *Gosha Arinich*
649
-
650
- * Fix a bug in `content_tag_for` that prevents it from working without a block.
651
-
652
- *Jasl*
653
-
654
- * Change the stylesheet of exception pages for development mode.
655
- Additionally display also the line of code and fragment that raised
656
- the exception in all exceptions pages.
657
-
658
- *Guillermo Iguaran + Jorge Cuadrado*
659
-
660
- * Do not append `charset=` parameter when `head` is called with a
661
- `:content_type` option.
662
- Fixes #8661.
663
-
664
- *Yves Senn*
665
-
666
- * Added `Mime::NullType` class. This allows to use `html?`, `xml?`, `json?`, etc.
667
- when the format of the request is unknown, without raising an exception.
668
-
669
- *Angelo Capilleri*
670
-
671
- * Integrate the Journey gem into Action Dispatch so that the global namespace
672
- is not polluted with names that may be used as models.
673
-
674
- *Andrew White*
675
-
676
- * Extract support for email address obfuscation via `:encode`, `:replace_at`, and `replace_dot`
677
- options from the `mail_to` helper into the `actionview-encoded_mail_to` gem.
678
-
679
- *Nick Reed + DHH*
680
-
681
- * Handle `:protocol` option in `stylesheet_link_tag` and `javascript_include_tag`
682
-
683
- *Vasiliy Ermolovich*
684
-
685
- * Clear url helper methods when routes are reloaded. *Andrew White*
686
-
687
- * Fix a bug in `ActionDispatch::Request#raw_post` that caused `env['rack.input']`
688
- to be read but not rewound.
689
-
690
- *Matt Venables*
691
-
692
- * Prevent raising `EOFError` on multipart GET request (IE issue). *Adam Stankiewicz*
693
-
694
- * Rename all action callbacks from *_filter to *_action to avoid the misconception that these
695
- callbacks are only suited for transforming or halting the response. With the new style,
696
- it's more inviting to use them as they were intended, like setting shared ivars for views.
697
-
698
- Example:
313
+ *Jeremy Kemper*
699
314
 
700
- class PeopleController < ActionController::Base
701
- before_action :set_person, except: [:index, :new, :create]
702
- before_action :ensure_permission, only: [:edit, :update]
315
+ * Don't rescue `IPAddr::InvalidAddressError`.
703
316
 
704
- ...
317
+ `IPAddr::InvalidAddressError` does not exist in Ruby 1.9.3
318
+ and fails for JRuby in 1.9 mode.
705
319
 
706
- private
707
- def set_person
708
- @person = current_account.people.find(params[:id])
709
- end
320
+ *Peter Suschlik*
710
321
 
711
- def ensure_permission
712
- current_person.can_change?(@person)
713
- end
714
- end
322
+ * Fix bug where the router would ignore any constraints added to redirect
323
+ routes.
715
324
 
716
- The old *_filter methods still work with no deprecation notice.
325
+ Fixes #16605.
717
326
 
718
- *DHH*
327
+ *Agis Anastasopoulos*
719
328
 
720
- * Add `cache_if` and `cache_unless` for conditional fragment caching:
329
+ * Allow `config.action_dispatch.trusted_proxies` to accept an IPAddr object.
721
330
 
722
331
  Example:
723
332
 
724
- <%= cache_if condition, project do %>
725
- <b>All the topics on this project</b>
726
- <%= render project.topics %>
727
- <% end %>
728
-
729
- # and
730
-
731
- <%= cache_unless condition, project do %>
732
- <b>All the topics on this project</b>
733
- <%= render project.topics %>
734
- <% end %>
735
-
736
- *Stephen Ausman + Fabrizio Regini + Angelo Capilleri*
737
-
738
- * Add logging filter capability for redirect URLs:
739
-
740
- config.filter_redirect << 'http://please.hide.it/'
741
-
742
- *Fabrizio Regini*
743
-
744
- * Fixed a bug that ignores constraints on a glob route. This was caused because the constraint
745
- regular expression is overwritten when the `routes.rb` file is processed. Fixes #7924
746
-
747
- *Maura Fitzgerald*
748
-
749
- * More descriptive error messages when calling `render :partial` with
750
- an invalid `:layout` argument.
751
-
752
- Fixes #8376.
753
-
754
- render partial: 'partial', layout: true
755
-
756
- # results in ActionView::MissingTemplate: Missing partial /true
757
-
758
- *Yves Senn*
759
-
760
- * Sweepers was extracted from Action Controller as `rails-observers` gem.
761
-
762
- *Rafael Mendonça França*
763
-
764
- * Add option flag to `CacheHelper#cache` to manually bypass automatic template digests:
765
-
766
- <% cache project, skip_digest: true do %>
767
- ...
768
- <% end %>
769
-
770
- *Drew Ulmer*
771
-
772
- * Do not sort Hash options in `grouped_options_for_select`. *Sergey Kojin*
773
-
774
- * Accept symbols as `send_data :disposition` value *Elia Schito*
775
-
776
- * Add i18n scope to `distance_of_time_in_words`. *Steve Klabnik*
777
-
778
- * `assert_template`:
779
- - is no more passing with empty string.
780
- - is now validating option keys. It accepts: `:layout`, `:partial`, `:locals` and `:count`.
781
-
782
- *Roberto Soares*
783
-
784
- * Allow setting a symbol as path in scope on routes. This is now allowed:
785
-
786
- scope :api do
787
- resources :users
788
- end
789
-
790
- It is also possible to pass multiple symbols to scope to shorten multiple nested scopes:
791
-
792
- scope :api do
793
- scope :v1 do
794
- resources :users
795
- end
796
- end
797
-
798
- can be rewritten as:
799
-
800
- scope :api, :v1 do
801
- resources :users
802
- end
333
+ # config/environments/production.rb
334
+ config.action_dispatch.trusted_proxies = IPAddr.new('4.8.15.0/16')
803
335
 
804
- *Guillermo Iguaran + Amparo Luna*
336
+ *Sam Aarons*
805
337
 
806
- * Fix error when using a non-hash query argument named "params" in `url_for`.
338
+ * Avoid duplicating routes for HEAD requests.
807
339
 
808
- Before:
340
+ Instead of duplicating the routes, we will first match the HEAD request to
341
+ HEAD routes. If no match is found, we will then map the HEAD request to
342
+ GET routes.
809
343
 
810
- url_for(params: "") # => undefined method `reject!' for "":String
344
+ *Guo Xiang Tan*, *Andrew White*
811
345
 
812
- After:
346
+ * Requests that hit `ActionDispatch::Static` can now take advantage
347
+ of gzipped assets on disk. By default a gzip asset will be served if
348
+ the client supports gzip and a compressed file is on disk.
813
349
 
814
- url_for(params: "") # => http://www.example.com?params=
815
-
816
- *tumayun + Carlos Antonio da Silva*
817
-
818
- * Render every partial with a new `ActionView::PartialRenderer`. This resolves
819
- issues when rendering nested partials.
820
- Fixes #8197.
821
-
822
- *Yves Senn*
823
-
824
- * Introduce `ActionView::Template::Handlers::ERB.escape_whitelist`. This is a list
825
- of mime types where template text is not html escaped by default. It prevents `Jack & Joe`
826
- from rendering as `Jack &amp; Joe` for the whitelisted mime types. The default whitelist
827
- contains `text/plain`.
828
- Fixes #7976.
829
-
830
- *Joost Baaij*
831
-
832
- * Fix input name when `multiple: true` and `:index` are set.
833
-
834
- Before:
835
-
836
- check_box("post", "comment_ids", { multiple: true, index: "foo" }, 1)
837
- # => <input name=\"post[foo][comment_ids]\" type=\"hidden\" value=\"0\" /><input id=\"post_foo_comment_ids_1\" name=\"post[foo][comment_ids]\" type=\"checkbox\" value=\"1\" />
838
-
839
- After:
840
-
841
- check_box("post", "comment_ids", { multiple: true, index: "foo" }, 1)
842
- # => <input name=\"post[foo][comment_ids][]\" type=\"hidden\" value=\"0\" /><input id=\"post_foo_comment_ids_1\" name=\"post[foo][comment_ids][]\" type=\"checkbox\" value=\"1\" />
843
-
844
- Fixes #8108.
845
-
846
- *Daniel Fox, Grant Hutchins & Trace Wax*
847
-
848
- * `date_select` helper accepts `with_css_classes: true` to add css classes similar with type
849
- of generated select tags.
850
-
851
- *Pavel Nikitin*
852
-
853
- * Only non-js/css under `app/assets` path will be included in default `config.assets.precompile`.
854
-
855
- *Josh Peek*
856
-
857
- * Remove support for the `RAILS_ASSET_ID` environment configuration
858
- (no longer needed now that we have the asset pipeline).
859
-
860
- *Josh Peek*
861
-
862
- * Remove old `asset_path` configuration (no longer needed now that we have the asset pipeline).
350
+ *Richard Schneeman*
863
351
 
864
- *Josh Peek*
352
+ * `ActionController::Parameters` will stop inheriting from `Hash` and
353
+ `HashWithIndifferentAccess` in the next major release. If you use any method
354
+ that is not available on `ActionController::Parameters` you should consider
355
+ calling `#to_h` to convert it to a `Hash` first before calling that method.
865
356
 
866
- * `assert_template` can be used to assert on the same template with different locals
867
- Fixes #3675.
357
+ *Prem Sichanugrist*
868
358
 
869
- *Yves Senn*
359
+ * `ActionController::Parameters#to_h` now returns a `Hash` with unpermitted
360
+ keys removed. This change is to reflect on a security concern where some
361
+ method performed on an `ActionController::Parameters` may yield a `Hash`
362
+ object which does not maintain `permitted?` status. If you would like to
363
+ get a `Hash` with all the keys intact, duplicate and mark it as permitted
364
+ before calling `#to_h`.
870
365
 
871
- * Remove old asset tag concatenation (no longer needed now that we have the asset pipeline).
366
+ params = ActionController::Parameters.new({
367
+ name: 'Senjougahara Hitagi',
368
+ oddity: 'Heavy stone crab'
369
+ })
370
+ params.to_h
371
+ # => {}
872
372
 
873
- *Josh Peek*
373
+ unsafe_params = params.dup.permit!
374
+ unsafe_params.to_h
375
+ # => {"name"=>"Senjougahara Hitagi", "oddity"=>"Heavy stone crab"}
874
376
 
875
- * Accept `:remote` as symbolic option for `link_to` helper. *Riley Lynch*
377
+ safe_params = params.permit(:name)
378
+ safe_params.to_h
379
+ # => {"name"=>"Senjougahara Hitagi"}
876
380
 
877
- * Warn when the `:locals` option is passed to `assert_template` outside of a view test case
878
- Fixes #3415.
381
+ This change is consider a stopgap as we cannot change the code to stop
382
+ `ActionController::Parameters` to inherit from `HashWithIndifferentAccess`
383
+ in the next minor release.
879
384
 
880
- *Yves Senn*
385
+ *Prem Sichanugrist*
881
386
 
882
- * The `Rack::Cache` middleware is now disabled by default. To enable it,
883
- set `config.action_dispatch.rack_cache = true` and add `gem rack-cache` to your Gemfile.
387
+ * Deprecated `TagAssertions`.
884
388
 
885
- *Guillermo Iguaran*
389
+ *Kasper Timm Hansen*
886
390
 
887
- * `ActionController::Base.page_cache_extension` option is deprecated
888
- in favour of `ActionController::Base.default_static_extension`.
391
+ * Use the Active Support JSON encoder for cookie jars using the `:json` or
392
+ `:hybrid` serializer. This allows you to serialize custom Ruby objects into
393
+ cookies by defining the `#as_json` hook on such objects.
889
394
 
890
- *Francesco Rodriguez*
395
+ Fixes #16520.
891
396
 
892
- * Action and Page caching has been extracted from Action Dispatch
893
- as `actionpack-action_caching` and `actionpack-page_caching` gems.
894
- Please read the `README.md` file on both gems for the usage.
397
+ *Godfrey Chan*
895
398
 
896
- *Francesco Rodriguez*
399
+ * Add `config.action_dispatch.cookies_digest` option for setting custom
400
+ digest. The default remains the same - 'SHA1'.
897
401
 
898
- * Failsafe exception returns `text/plain`. *Steve Klabnik*
402
+ *Łukasz Strzałkowski*
899
403
 
900
- * Rename internal variables on `ActionController::TemplateAssertions` to prevent
901
- naming collisions. `@partials`, `@templates` and `@layouts` are now prefixed with an underscore.
902
- Fixes #7459.
404
+ * Move `respond_with` (and the class-level `respond_to`) to
405
+ the `responders` gem.
903
406
 
904
- *Yves Senn*
407
+ *José Valim*
905
408
 
906
- * `resource` and `resources` don't modify the passed options hash.
907
- Fixes #7777.
409
+ * When your templates change, browser caches bust automatically.
908
410
 
909
- *Yves Senn*
411
+ New default: the template digest is automatically included in your ETags.
412
+ When you call `fresh_when @post`, the digest for `posts/show.html.erb`
413
+ is mixed in so future changes to the HTML will blow HTTP caches for you.
414
+ This makes it easy to HTTP-cache many more of your actions.
910
415
 
911
- * Precompiled assets include aliases from `foo.js` to `foo/index.js` and vice versa.
416
+ If you render a different template, you can now pass the `:template`
417
+ option to include its digest instead:
912
418
 
913
- # Precompiles phone-<digest>.css and aliases phone/index.css to phone.css.
914
- config.assets.precompile = [ 'phone.css' ]
419
+ fresh_when @post, template: 'widgets/show'
915
420
 
916
- # Precompiles phone/index-<digest>.css and aliases phone.css to phone/index.css.
917
- config.assets.precompile = [ 'phone/index.css' ]
421
+ Pass `template: false` to skip the lookup. To turn this off entirely, set:
918
422
 
919
- # Both of these work with either precompile thanks to their aliases.
920
- <%= stylesheet_link_tag 'phone', media: 'all' %>
921
- <%= stylesheet_link_tag 'phone/index', media: 'all' %>
423
+ config.action_controller.etag_with_template_digest = false
922
424
 
923
425
  *Jeremy Kemper*
924
426
 
925
- * `assert_template` is no more passing with what ever string that matches
926
- with the template name.
927
-
928
- Before when we have a template `/layout/hello.html.erb`, `assert_template`
929
- was passing with any string that matches. This behavior allowed false
930
- positive like:
931
-
932
- assert_template "layout"
933
- assert_template "out/hello"
934
-
935
- Now it only passes with:
936
-
937
- assert_template "layout/hello"
938
- assert_template "hello"
939
-
940
- Fixes #3849.
941
-
942
- *Hugolnx*
943
-
944
- * `image_tag` will set the same width and height for image if numerical value
945
- passed to `size` option.
946
-
947
- *Nihad Abbasov*
948
-
949
- * Deprecate `Mime::Type#verify_request?` and `Mime::Type.browser_generated_types`,
950
- since they are no longer used inside of Rails, they will be removed in Rails 4.1.
951
-
952
- *Michael Grosser*
953
-
954
- * `ActionDispatch::Http::UploadedFile` now delegates `close` to its tempfile. *Sergio Gil*
955
-
956
- * Add `ActionController::StrongParameters`, this module converts `params` hash into
957
- an instance of ActionController::Parameters that allows whitelisting of permitted
958
- parameters. Non-permitted parameters are forbidden to be used in Active Model by default
959
- For more details check the documentation of the module or the
960
- [strong_parameters gem](https://github.com/rails/strong_parameters)
961
-
962
- *DHH + Guillermo Iguaran*
963
-
964
- * Remove Integration between `attr_accessible`/`attr_protected` and
965
- `ActionController::ParamsWrapper`. ParamWrapper now wraps all the parameters returned
966
- by the class method `attribute_names`.
967
-
968
- *Guillermo Iguaran*
969
-
970
- * Log now displays the correct status code when an exception is raised.
971
- Fixes #7646.
427
+ * Remove deprecated `AbstractController::Helpers::ClassMethods::MissingHelperError`
428
+ in favor of `AbstractController::Helpers::MissingHelperError`.
972
429
 
973
430
  *Yves Senn*
974
431
 
975
- * Allow pass couple extensions to `ActionView::Template.register_template_handler` call.
976
-
977
- *Tima Maslyuchenko*
978
-
979
- * Sprockets integration has been extracted from Action Pack to the `sprockets-rails`
980
- gem. `rails` gem is depending on `sprockets-rails` by default.
981
-
982
- *Guillermo Iguaran*
983
-
984
- * `ActionDispatch::Session::MemCacheStore` now uses `dalli` instead of the deprecated
985
- `memcache-client` gem.
986
-
987
- *Arun Agrawal + Guillermo Iguaran*
988
-
989
- * Support multiple etags in If-None-Match header. *Travis Warlick*
990
-
991
- * Allow to configure how unverified request will be handled using `:with`
992
- option in `protect_from_forgery` method.
993
-
994
- Valid unverified request handling methods are:
995
-
996
- - `:exception` - Raises ActionController::InvalidAuthenticityToken exception.
997
- - `:reset_session` - Resets the session.
998
- - `:null_session` - Provides an empty session during request but doesn't
999
- reset it completely. Used as default if `:with` option is not specified.
432
+ * Fix `assert_template` not being able to assert that no files were rendered.
1000
433
 
1001
- New applications are generated with:
434
+ *Guo Xiang Tan*
1002
435
 
1003
- protect_from_forgery with: :exception
436
+ * Extract source code for the entire exception stack trace for
437
+ better debugging and diagnosis.
1004
438
 
1005
- *Sergey Nartimov*
439
+ *Ryan Dao*
1006
440
 
1007
- * Add `.ruby` template handler, this handler simply allows arbitrary Ruby code as a template. *Guillermo Iguaran*
441
+ * Allows ActionDispatch::Request::LOCALHOST to match any IPv4 127.0.0.0/8
442
+ loopback address.
1008
443
 
1009
- * Add `separator` option for `ActionView::Helpers::TextHelper#excerpt`:
444
+ *Earl St Sauver*, *Sven Riedel*
1010
445
 
1011
- excerpt('This is a very beautiful morning', 'very', separator: ' ', radius: 1)
1012
- # => ...a very beautiful...
446
+ * Preserve original path in `ShowExceptions` middleware by stashing it as
447
+ `env["action_dispatch.original_path"]`
1013
448
 
1014
- *Guirec Corbel*
449
+ `ActionDispatch::ShowExceptions` overwrites `PATH_INFO` with the status code
450
+ for the exception defined in `ExceptionWrapper`, so the path
451
+ the user was visiting when an exception occurred was not previously
452
+ available to any custom exceptions_app. The original `PATH_INFO` is now
453
+ stashed in `env["action_dispatch.original_path"]`.
1015
454
 
1016
- * Added controller-level etag additions that will be part of the action etag computation *Jeremy Kemper/DHH*
455
+ *Grey Baker*
1017
456
 
1018
- class InvoicesController < ApplicationController
1019
- etag { current_user.try :id }
457
+ * Use `String#bytesize` instead of `String#size` when checking for cookie
458
+ overflow.
1020
459
 
1021
- def show
1022
- # Etag will differ even for the same invoice when it's viewed by a different current_user
1023
- @invoice = Invoice.find(params[:id])
1024
- fresh_when(@invoice)
1025
- end
1026
- end
460
+ *Agis Anastasopoulos*
1027
461
 
1028
- * Add automatic template digests to all `CacheHelper#cache` calls (originally spiked in the `cache_digests` plugin) *DHH*
462
+ * `render nothing: true` or rendering a `nil` body no longer add a single
463
+ space to the response body.
1029
464
 
1030
- * When building a URL fails, add missing keys provided by Journey. Failed URL
1031
- generation now returns a 500 status instead of a 404.
465
+ The old behavior was added as a workaround for a bug in an early version of
466
+ Safari, where the HTTP headers are not returned correctly if the response
467
+ body has a 0-length. This is been fixed since and the workaround is no
468
+ longer necessary.
1032
469
 
1033
- *Richard Schneeman*
1034
-
1035
- * Deprecate availability of `ActionView::RecordIdentifier` in controllers by default.
1036
- It's view specific and can be easily included in controllers manually if someone
1037
- really needs it. Also deprecate calling `ActionController::RecordIdentifier.dom_id` and
1038
- `dom_class` directly, in favor of `ActionView::RecordIdentifier.dom_id` and `dom_class`.
1039
- `RecordIdentifier` will be removed from `ActionController::Base` in Rails 4.1.
1040
-
1041
- *Piotr Sarnacki*
1042
-
1043
- * Fix `ActionView::RecordIdentifier` to work as a singleton. *Piotr Sarnacki*
1044
-
1045
- * Deprecate `Template#mime_type`, it will be removed in Rails 4.1 in favor of `#type`.
1046
- *Piotr Sarnacki*
1047
-
1048
- * Move vendored html-scanner from `action_controller` to `action_view` directory. If you
1049
- require it directly, please use 'action_view/vendor/html-scanner', reference to
1050
- 'action_controller/vendor/html-scanner' will be removed in Rails 4.1. *Piot Sarnacki*
470
+ Use `render body: ' '` if the old behavior is desired.
1051
471
 
1052
- * Fix handling of date selects when using both disabled and discard options.
1053
- Fixes #7431.
472
+ See #14883 for details.
1054
473
 
1055
- *Vasiliy Ermolovich*
474
+ *Godfrey Chan*
1056
475
 
1057
- * `ActiveRecord::SessionStore` is extracted out of Rails into a gem `activerecord-session_store`.
1058
- Setting `config.session_store` to `:active_record_store` will no longer work and will break
1059
- if the `activerecord-session_store` gem isn't available. *Prem Sichanugrist*
476
+ * Prepend a JS comment to JSONP callbacks. Addresses CVE-2014-4671
477
+ ("Rosetta Flash").
1060
478
 
1061
- * Fix `select_tag` when `option_tags` is nil.
1062
- Fixes #7404.
479
+ *Greg Campbell*
1063
480
 
1064
- *Sandeep Ravichandran*
481
+ * Because URI paths may contain non US-ASCII characters we need to force
482
+ the encoding of any unescaped URIs to UTF-8 if they are US-ASCII.
483
+ This essentially replicates the functionality of the monkey patch to
484
+ URI.parser.unescape in active_support/core_ext/uri.rb.
1065
485
 
1066
- * Add `Request#formats=(extensions)` that lets you set multiple formats directly in a prioritized order.
486
+ Fixes #16104.
1067
487
 
1068
- Example of using this for custom iphone views with an HTML fallback:
488
+ *Karl Entwistle*
1069
489
 
1070
- class ApplicationController < ActionController::Base
1071
- before_filter :adjust_format_for_iphone_with_html_fallback
490
+ * Generate shallow paths for all children of shallow resources.
1072
491
 
1073
- private
1074
- def adjust_format_for_iphone_with_html_fallback
1075
- request.formats = [ :iphone, :html ] if request.env["HTTP_USER_AGENT"][/iPhone/]
1076
- end
1077
- end
492
+ Fixes #15783.
1078
493
 
1079
- *DHH*
494
+ *Seb Jacobs*
1080
495
 
1081
- * Add Routing Concerns to declare common routes that can be reused inside
1082
- others resources and routes.
496
+ * JSONP responses are now rendered with the `text/javascript` content type
497
+ when rendering through a `respond_to` block.
1083
498
 
1084
- Code before:
499
+ Fixes #15081.
1085
500
 
1086
- resources :messages do
1087
- resources :comments
1088
- end
501
+ *Lucas Mazza*
1089
502
 
1090
- resources :posts do
1091
- resources :comments
1092
- resources :images, only: :index
1093
- end
503
+ * Add `config.action_controller.always_permitted_parameters` to configure which
504
+ parameters are permitted globally. The default value of this configuration is
505
+ `['controller', 'action']`.
1094
506
 
1095
- Code after:
507
+ *Gary S. Weaver*, *Rafael Chacon*
1096
508
 
1097
- concern :commentable do
1098
- resources :comments
1099
- end
509
+ * Fix env['PATH_INFO'] missing leading slash when a rack app mounted at '/'.
1100
510
 
1101
- concern :image_attachable do
1102
- resources :images, only: :index
1103
- end
511
+ Fixes #15511.
1104
512
 
1105
- resources :messages, concerns: :commentable
513
+ *Larry Lv*
1106
514
 
1107
- resources :posts, concerns: [:commentable, :image_attachable]
1108
-
1109
- *DHH + Rafael Mendonça França*
1110
-
1111
- * Add `start_hour` and `end_hour` options to the `select_hour` helper. *Evan Tann*
1112
-
1113
- * Raises an `ArgumentError` when the first argument in `form_for` contain `nil`
1114
- or is empty.
1115
-
1116
- *Richard Schneeman*
515
+ * ActionController::Parameters#require now accepts `false` values.
1117
516
 
1118
- * Add 'X-Frame-Options' => 'SAMEORIGIN'
1119
- 'X-XSS-Protection' => '1; mode=block' and
1120
- 'X-Content-Type-Options' => 'nosniff'
1121
- as default headers.
517
+ Fixes #15685.
1122
518
 
1123
- *Egor Homakov*
519
+ *Sergio Romano*
1124
520
 
1125
- * Allow data attributes to be set as a first-level option for `form_for`, so you can write `form_for @record, data: { behavior: 'autosave' }` instead of `form_for @record, html: { data: { behavior: 'autosave' } }` *DHH*
521
+ * With authorization header `Authorization: Token token=`, `authenticate` now
522
+ recognize token as nil, instead of "token".
1126
523
 
1127
- * Deprecate `button_to_function` and `link_to_function` helpers.
524
+ Fixes #14846.
1128
525
 
1129
- We recommend the use of Unobtrusive JavaScript instead. For example:
526
+ *Larry Lv*
1130
527
 
1131
- link_to "Greeting", "#", class: "nav_link"
528
+ * Ensure the controller is always notified as soon as the client disconnects
529
+ during live streaming, even when the controller is blocked on a write.
1132
530
 
1133
- $(function() {
1134
- $('.nav_link').click(function() {
1135
- // Some complex code
531
+ *Nicholas Jakobsen*, *Matthew Draper*
1136
532
 
1137
- return false;
1138
- });
1139
- });
1140
-
1141
- or
1142
-
1143
- link_to "Greeting", '#', onclick: "alert('Hello world!'); return false", class: "nav_link"
1144
-
1145
- for simple cases.
1146
-
1147
- *Rafael Mendonça França*
1148
-
1149
- * `javascript_include_tag :all` will now not include `application.js` if the file does not exists. *Prem Sichanugrist*
1150
-
1151
- * Send an empty response body when call `head` with status between 100 and 199, 204, 205 or 304.
1152
-
1153
- *Armand du Plessis*
1154
-
1155
- * Fixed issue with where digest authentication would not work behind a proxy. *Arthur Smith*
1156
-
1157
- * Added `ActionController::Live`. Mix it in to your controller and you can
1158
- stream data to the client live. For example:
1159
-
1160
- class FooController < ActionController::Base
1161
- include ActionController::Live
1162
-
1163
- def index
1164
- 100.times {
1165
- # Client will see this as it's written
1166
- response.stream.write "hello world\n"
1167
- sleep 1
1168
- }
1169
- response.stream.close
1170
- end
1171
- end
533
+ * Routes specifying 'to:' must be a string that contains a "#" or a rack
534
+ application. Use of a symbol should be replaced with `action: symbol`.
535
+ Use of a string without a "#" should be replaced with `controller: string`.
1172
536
 
1173
537
  *Aaron Patterson*
1174
538
 
1175
- * Remove `ActionDispatch::Head` middleware in favor of `Rack::Head`. *Santiago Pastorino*
1176
-
1177
- * Deprecate `:confirm` in favor of `data: { confirm: "Text" }` option for `button_to`, `button_tag`, `image_submit_tag`, `link_to` and `submit_tag` helpers.
539
+ * Fix URL generation with `:trailing_slash` such that it does not add
540
+ a trailing slash after `.:format`
1178
541
 
1179
- *Carlos Galdino + Rafael Mendonça França*
542
+ *Dan Langevin*
1180
543
 
1181
- * Show routes in exception page while debugging a `RoutingError` in development.
544
+ * Build full URI as string when processing path in integration tests for
545
+ performance reasons. One consequence of this is that the leading slash
546
+ is now required in integration test `process` helpers, whereas previously
547
+ it could be omitted. The fact that this worked was a unintended consequence
548
+ of the implementation and was never an intentional feature.
1182
549
 
1183
- *Richard Schneeman + Mattt Thompson + Yves Senn*
550
+ *Guo Xiang Tan*
1184
551
 
1185
- * Add `ActionController::Flash.add_flash_types` method to allow people to register their own flash types. e.g.:
552
+ * Fix `'Stack level too deep'` when rendering `head :ok` in an action method
553
+ called 'status' in a controller.
1186
554
 
1187
- class ApplicationController
1188
- add_flash_types :error, :warning
1189
- end
555
+ Fixes #13905.
1190
556
 
1191
- If you add the above code, you can use `<%= error %>` in an erb, and `redirect_to /foo, error: 'message'` in a controller.
557
+ *Christiaan Van den Poel*
1192
558
 
1193
- *kennyj*
559
+ * Add MKCALENDAR HTTP method (RFC 4791).
1194
560
 
1195
- * Remove Active Model dependency from Action Pack. *Guillermo Iguaran*
561
+ *Sergey Karpesh*
1196
562
 
1197
- * Support unicode characters in routes. Route will be automatically escaped, so instead of manually escaping:
563
+ * Instrument fragment cache metrics.
1198
564
 
1199
- get Rack::Utils.escape('こんにちは') => 'home#index'
565
+ Adds `:controller`: and `:action` keys to the instrumentation payload
566
+ for the `*_fragment.action_controller` notifications. This allows tracking
567
+ e.g. the fragment cache hit rates for each controller action.
1200
568
 
1201
- You just have to write the unicode route:
569
+ *Daniel Schierbeck*
1202
570
 
1203
- get 'こんにちは' => 'home#index'
571
+ * Always use the provided port if the protocol is relative.
1204
572
 
1205
- *kennyj*
573
+ Fixes #15043.
1206
574
 
1207
- * Return proper format on exceptions. *Santiago Pastorino*
575
+ *Guilherme Cavalcanti*, *Andrew White*
1208
576
 
1209
- * Allow to use `mounted_helpers` (helpers for accessing mounted engines) in `ActionView::TestCase`. *Piotr Sarnacki*
577
+ * Moved `params[request_forgery_protection_token]` into its own method
578
+ and improved tests.
1210
579
 
1211
- * Include `mounted_helpers` (helpers for accessing mounted engines) in `ActionDispatch::IntegrationTest` by default. *Piotr Sarnacki*
580
+ Fixes #11316.
1212
581
 
1213
- * Extracted redirect logic from `ActionController::ForceSSL::ClassMethods.force_ssl` into `ActionController::ForceSSL#force_ssl_redirect`
582
+ *Tom Kadwill*
1214
583
 
1215
- *Jeremy Friesen*
584
+ * Added verification of route constraints given as a Proc or an object responding
585
+ to `:matches?`. Previously, when given an non-complying object, it would just
586
+ silently fail to enforce the constraint. It will now raise an `ArgumentError`
587
+ when setting up the routes.
1216
588
 
1217
- * Make possible to use a block in `button_to` if the button text is hard
1218
- to fit into the name parameter, e.g.:
589
+ *Xavier Defrang*
1219
590
 
1220
- <%= button_to [:make_happy, @user] do %>
1221
- Make happy <strong><%= @user.name %></strong>
1222
- <% end %>
1223
- # => "<form method="post" action="/users/1/make_happy" class="button_to">
1224
- # <div>
1225
- # <button type="submit">
1226
- # Make happy <strong>Name</strong>
1227
- # </button>
1228
- # </div>
1229
- # </form>"
591
+ * Properly treat the entire IPv6 User Local Address space as private for
592
+ purposes of remote IP detection. Also handle uppercase private IPv6
593
+ addresses.
1230
594
 
1231
- *Sergey Nartimov*
595
+ Fixes #12638.
1232
596
 
1233
- * Change a way of ordering helpers from several directories. Previously,
1234
- when loading helpers from multiple paths, all of the helpers files were
1235
- gathered into one array an then they were sorted. Helpers from different
1236
- directories should not be mixed before loading them to make loading more
1237
- predictable. The most common use case for such behavior is loading helpers
1238
- from engines. When you load helpers from application and engine Foo, in
1239
- that order, first rails will load all of the helpers from application,
1240
- sorted alphabetically and then it will do the same for Foo engine.
597
+ *Caleb Spare*
1241
598
 
1242
- *Piotr Sarnacki*
599
+ * Fixed an issue with migrating legacy json cookies.
1243
600
 
1244
- * `truncate` now always returns an escaped HTML-safe string. The option `:escape` can be used as
1245
- false to not escape the result.
601
+ Previously, the `VerifyAndUpgradeLegacySignedMessage` assumes all incoming
602
+ cookies are marshal-encoded. This is not the case when `secret_token` is
603
+ used in conjunction with the `:json` or `:hybrid` serializer.
1246
604
 
1247
- *Li Ellis Gallardo + Rafael Mendonça França*
605
+ In those case, when upgrading to use `secret_key_base`, this would cause a
606
+ `TypeError: incompatible marshal file format` and a 500 error for the user.
1248
607
 
1249
- * `truncate` now accepts a block to show extra content when the text is truncated. *Li Ellis Gallardo*
608
+ Fixes #14774.
1250
609
 
1251
- * Add `week_field`, `week_field_tag`, `month_field`, `month_field_tag`, `datetime_local_field`,
1252
- `datetime_local_field_tag`, `datetime_field` and `datetime_field_tag` helpers. *Carlos Galdino*
610
+ *Godfrey Chan*
1253
611
 
1254
- * Add `color_field` and `color_field_tag` helpers. *Carlos Galdino*
612
+ * Make URL escaping more consistent:
1255
613
 
1256
- * `assert_generates`, `assert_recognizes`, and `assert_routing` all raise
1257
- `Assertion` instead of `RoutingError` *David Chelimsky*
614
+ 1. Escape '%' characters in URLs - only unescaped data should be passed to URL helpers
615
+ 2. Add an `escape_segment` helper to `Router::Utils` that escapes '/' characters
616
+ 3. Use `escape_segment` rather than `escape_fragment` in optimized URL generation
617
+ 4. Use `escape_segment` rather than `escape_path` in URL generation
1258
618
 
1259
- * URL path parameters with invalid encoding now raise `ActionController::BadRequest`. *Andrew White*
619
+ For point 4 there are two exceptions. Firstly, when a route uses wildcard segments
620
+ (e.g. `*foo`) then we use `escape_path` as the value may contain '/' characters. This
621
+ means that wildcard routes can't be optimized. Secondly, if a `:controller` segment
622
+ is used in the path then this uses `escape_path` as the controller may be namespaced.
1260
623
 
1261
- * Malformed query and request parameter hashes now raise `ActionController::BadRequest`. *Andrew White*
624
+ Fixes #14629, #14636 and #14070.
1262
625
 
1263
- * Add `divider` option to `grouped_options_for_select` to generate a separator
1264
- `optgroup` automatically, and deprecate `prompt` as third argument, in favor
1265
- of using an options hash. *Nicholas Greenfield*
626
+ *Andrew White*, *Edho Arief*
1266
627
 
1267
- * Add `time_field` and `time_field_tag` helpers which render an `input[type="time"]` tag. *Alex Soulim*
628
+ * Add alias `ActionDispatch::Http::UploadedFile#to_io` to
629
+ `ActionDispatch::Http::UploadedFile#tempfile`.
1268
630
 
1269
- * Removed old text helper apis from `highlight`, `excerpt` and `word_wrap`. *Jeremy Walker*
631
+ *Tim Linquist*
1270
632
 
1271
- * Templates without a handler extension now raises a deprecation warning but still
1272
- defaults to ERB. In future releases, it will simply return the template contents. *Steve Klabnik*
633
+ * Returns null type format when format is not know and controller is using `any`
634
+ format block.
1273
635
 
1274
- * Deprecate `:disable_with` in favor of `data: { disable_with: "Text" }` option from `submit_tag`, `button_tag` and `button_to` helpers.
636
+ Fixes #14462.
1275
637
 
1276
- *Carlos Galdino + Rafael Mendonça França*
638
+ *Rafael Mendonça França*
1277
639
 
1278
- * Remove `:mouseover` option from `image_tag` helper. *Rafael Mendonça França*
640
+ * Improve routing error page with fuzzy matching search.
1279
641
 
1280
- * The `select` method (select tag) forces `:include_blank` if `required` is true and
1281
- `display size` is one and `multiple` is not true. *Angelo Capilleri*
642
+ *Winston*
1282
643
 
1283
- * Copy literal route constraints to defaults so that url generation know about them.
1284
- The copied constraints are `:protocol`, `:subdomain`, `:domain`, `:host` and `:port`.
644
+ * Only make deeply nested routes shallow when parent is shallow.
1285
645
 
1286
- *Andrew White*
646
+ Fixes #14684.
1287
647
 
1288
- * `respond_to` and `respond_with` now raise `ActionController::UnknownFormat` instead
1289
- of directly returning head 406. The exception is rescued and converted to 406
1290
- in the exception handling middleware. *Steven Soroka*
648
+ *Andrew White*, *James Coglan*
1291
649
 
1292
- * Allows `assert_redirected_to` to match against a regular expression. *Andy Lindeman*
650
+ * Append link to bad code to backtrace when exception is `SyntaxError`.
1293
651
 
1294
- * Add backtrace to development routing error page. *Richard Schneeman*
652
+ *Boris Kuznetsov*
1295
653
 
1296
- * Replace `include_seconds` boolean argument with `include_seconds: true` option
1297
- in `distance_of_time_in_words` and `time_ago_in_words` signature. *Dmitriy Kiriyenko*
654
+ * Swapped the parameters of assert_equal in `assert_select` so that the
655
+ proper values were printed correctly.
1298
656
 
1299
- * Make current object and counter (when it applies) variables accessible when
1300
- rendering templates with :object / :collection. *Carlos Antonio da Silva*
657
+ Fixes #14422.
1301
658
 
1302
- * JSONP now uses mimetype `text/javascript` instead of `application/json`. *omjokine*
659
+ *Vishal Lal*
1303
660
 
1304
- * Allow to lazy load `default_form_builder` by passing a `String` instead of a constant. *Piotr Sarnacki*
661
+ * The method `shallow?` returns false if the parent resource is a singleton so
662
+ we need to check if we're not inside a nested scope before copying the :path
663
+ and :as options to their shallow equivalents.
1305
664
 
1306
- * Session arguments passed to `process` calls in functional tests are now merged into
1307
- the existing session, whereas previously they would replace the existing session.
1308
- This change may break some existing tests if they are asserting the exact contents of
1309
- the session but should not break existing tests that only assert individual keys.
665
+ Fixes #14388.
1310
666
 
1311
667
  *Andrew White*
1312
668
 
1313
- * In the routes DSL the `:via` option of `match` is now mandatory.
1314
-
1315
- For routes that respond to one single verb it is recommended to use the more specific
1316
- macros `get`, `post`, etc. instead. You can still map all HTTP verbs to one action
1317
- with `match`, but it has to be explictly configured using `:via => :all`.
1318
-
1319
- *José Valim and Yehuda Katz*
1320
-
1321
- * Add `index` method to FormBuilder class. *Jorge Bejar*
1322
-
1323
- * Remove the leading \n added by textarea on `assert_select`. *Santiago Pastorino*
1324
-
1325
- * Changed default value for `config.action_view.embed_authenticity_token_in_remote_forms`
1326
- to `false`. This change breaks remote forms that need to work also without JavaScript,
1327
- so if you need such behavior, you can either set it to `true` or explicitly pass
1328
- `authenticity_token: true` in form options.
1329
-
1330
- * Added `ActionDispatch::SSL` middleware that when included force all the requests to be under HTTPS protocol. *Rafael Mendonça França*
1331
-
1332
- * Add `include_hidden` option to select tag. With `include_hidden: false` select with `multiple` attribute doesn't generate hidden input with blank value. *Vasiliy Ermolovich*
1333
-
1334
- * Removed default `size` option from the `text_field`, `search_field`, `telephone_field`, `url_field`, `email_field` helpers. *Philip Arndt*
1335
-
1336
- * Removed default `cols` and `rows` options from the `text_area` helper. *Philip Arndt*
1337
-
1338
- * Adds support for layouts when rendering a partial with a given collection. *serabe*
1339
-
1340
- * Allows the route helper `root` to take a string argument. For example, `root 'pages#main'`. *bcardarella*
1341
-
1342
- * Forms of persisted records use always PATCH (via the `_method` hack). *fxn*
1343
-
1344
- * For resources, both PATCH and PUT are routed to the `update` action. *fxn*
1345
-
1346
- * Don't ignore `force_ssl` in development. This is a change of behavior - use a `:if` condition to recreate the old behavior.
1347
-
1348
- class AccountsController < ApplicationController
1349
- force_ssl if: :ssl_configured?
1350
-
1351
- def ssl_configured?
1352
- !Rails.env.development?
1353
- end
1354
- end
1355
-
1356
- *Pat Allan*
1357
-
1358
- * Adds support for the PATCH verb:
1359
- * Request objects respond to `patch?`.
1360
- * Routes have a new `patch` method, and understand `:patch` in the
1361
- existing places where a verb is configured, like `:via`.
1362
- * New method `patch` available in functional tests.
1363
- * If `:patch` is the default verb for updates, edits are
1364
- tunneled as PATCH rather than as PUT, and routing acts accordingly.
1365
- * New method `patch_via_redirect` available in integration tests.
1366
-
1367
- *dlee*
1368
-
1369
- * `expires_in` accepts a `must_revalidate` flag. If true, "must-revalidate"
1370
- is added to the Cache-Control header. *fxn*
1371
-
1372
- * Add `date_field` and `date_field_tag` helpers which render an `input[type="date"]` tag *Olek Janiszewski*
1373
-
1374
- * Adds `image_url`, `javascript_url`, `stylesheet_url`, `audio_url`, `video_url`, and `font_url`
1375
- to assets tag helper. These URL helpers will return the full path to your assets. This is useful
1376
- when you are going to reference this asset from external host. *Prem Sichanugrist*
1377
-
1378
- * Default responder will now always use your overridden block in `respond_with` to render your response. *Prem Sichanugrist*
1379
-
1380
- * Allow `value_method` and `text_method` arguments from `collection_select` and
1381
- `options_from_collection_for_select` to receive an object that responds to `:call`,
1382
- such as a `proc`, to evaluate the option in the current element context. This works
1383
- the same way with `collection_radio_buttons` and `collection_check_boxes`.
1384
-
1385
- *Carlos Antonio da Silva + Rafael Mendonça França*
1386
-
1387
- * Add `collection_check_boxes` form helper, similar to `collection_select`:
1388
- Example:
1389
-
1390
- collection_check_boxes :post, :author_ids, Author.all, :id, :name
1391
- # Outputs something like:
1392
- <input id="post_author_ids_1" name="post[author_ids][]" type="checkbox" value="1" />
1393
- <label for="post_author_ids_1">D. Heinemeier Hansson</label>
1394
- <input id="post_author_ids_2" name="post[author_ids][]" type="checkbox" value="2" />
1395
- <label for="post_author_ids_2">D. Thomas</label>
1396
- <input name="post[author_ids][]" type="hidden" value="" />
1397
-
1398
- The label/check_box pairs can be customized with a block.
1399
-
1400
- *Carlos Antonio da Silva + Rafael Mendonça França*
1401
-
1402
- * Add `collection_radio_buttons` form helper, similar to `collection_select`:
1403
- Example:
1404
-
1405
- collection_radio_buttons :post, :author_id, Author.all, :id, :name
1406
- # Outputs something like:
1407
- <input id="post_author_id_1" name="post[author_id]" type="radio" value="1" />
1408
- <label for="post_author_id_1">D. Heinemeier Hansson</label>
1409
- <input id="post_author_id_2" name="post[author_id]" type="radio" value="2" />
1410
- <label for="post_author_id_2">D. Thomas</label>
1411
-
1412
- The label/radio_button pairs can be customized with a block.
1413
-
1414
- *Carlos Antonio da Silva + Rafael Mendonça França*
1415
-
1416
- * `check_box` with `:form` html5 attribute will now replicate the `:form`
1417
- attribute to the hidden field as well. *Carlos Antonio da Silva*
1418
-
1419
- * `label` form helper accepts `for: nil` to not generate the attribute. *Carlos Antonio da Silva*
1420
-
1421
- * Add `:format` option to `number_to_percentage`. *Rodrigo Flores*
1422
-
1423
- * Add `config.action_view.logger` to configure logger for Action View. *Rafael Mendonça França*
1424
-
1425
- * Deprecated `ActionController::Integration` in favour of `ActionDispatch::Integration`.
1426
-
1427
- * Deprecated `ActionController::IntegrationTest` in favour of `ActionDispatch::IntegrationTest`.
1428
-
1429
- * Deprecated `ActionController::PerformanceTest` in favour of `ActionDispatch::PerformanceTest`.
1430
-
1431
- * Deprecated `ActionController::AbstractRequest` in favour of `ActionDispatch::Request`.
1432
-
1433
- * Deprecated `ActionController::Request` in favour of `ActionDispatch::Request`.
1434
-
1435
- * Deprecated `ActionController::AbstractResponse` in favour of `ActionDispatch::Response`.
1436
-
1437
- * Deprecated `ActionController::Response` in favour of `ActionDispatch::Response`.
1438
-
1439
- * Deprecated `ActionController::Routing` in favour of `ActionDispatch::Routing`.
669
+ * Make logging of CSRF failures optional (but on by default) with the
670
+ `log_warning_on_csrf_failure` configuration setting in
671
+ `ActionController::RequestForgeryProtection`.
1440
672
 
1441
- * `check_box helper` with `disabled: true` will generate a disabled
1442
- hidden field to conform with the HTML convention where disabled fields are
1443
- not submitted with the form. This is a behavior change, previously the hidden
1444
- tag had a value of the disabled checkbox. *Tadas Tamosauskas*
673
+ *John Barton*
1445
674
 
1446
- * `favicon_link_tag` helper will now use the favicon in app/assets by default. *Lucas Caton*
675
+ * Fix URL generation in controller tests with request-dependent
676
+ `default_url_options` methods.
1447
677
 
1448
- * `ActionView::Helpers::TextHelper#highlight` now defaults to the
1449
- HTML5 `mark` element. *Brian Cardarella*
678
+ *Tony Wooster*
1450
679
 
1451
- Please check [3-2-stable](https://github.com/rails/rails/blob/3-2-stable/actionpack/CHANGELOG.md) for previous changes.
680
+ Please check [4-1-stable](https://github.com/rails/rails/blob/4-1-stable/actionpack/CHANGELOG.md) for previous changes.