actionpack 3.0.0.beta3 → 3.0.0.beta4

data/lib/action_view/template/error.rb

@@ -4,6 +4,25 @@ module ActionView
   class ActionViewError < StandardError #:nodoc:
   end
 
+  class EncodingError < StandardError #:nodoc:
+  end
+
+  class WrongEncodingError < EncodingError #:nodoc:
+    def initialize(string, encoding)
+      @string, @encoding = string, encoding
+    end
+
+    def message
+      @string.force_encoding("BINARY")
+      "Your template was not saved as valid #{@encoding}. Please " \
+      "either specify #{@encoding} as the encoding for your template " \
+      "in your text editor, or mark the template with its " \
+      "encoding by inserting the following as the first line " \
+      "of the template:\n\n# encoding: <name of correct encoding>.\n\n" \
+      "The source of your template was:\n\n#{@string}"
+    end
+  end
+
   class MissingTemplate < ActionViewError #:nodoc:
     attr_reader :path
 
@@ -21,17 +40,18 @@ module ActionView
       super("Missing #{template_type} #{path} with #{details.inspect} in view paths #{display_paths}")
     end
   end
+
   class Template
     # The Template::Error exception is raised when the compilation of the template fails. This exception then gathers a
     # bunch of intimate details and uses it to report a very precise exception message.
     class Error < ActionViewError #:nodoc:
       SOURCE_CODE_RADIUS = 3
 
-      attr_reader :original_exception
+      attr_reader :original_exception, :backtrace
 
       def initialize(template, assigns, original_exception)
         @template, @assigns, @original_exception = template, assigns.dup, original_exception
-        @backtrace = compute_backtrace
+        @backtrace = original_exception.backtrace
       end
 
       def file_name
@@ -42,14 +62,6 @@ module ActionView
         ActiveSupport::Deprecation.silence { original_exception.message }
       end
 
-      def clean_backtrace
-        if defined?(Rails) && Rails.respond_to?(:backtrace_cleaner)
-          Rails.backtrace_cleaner.clean(original_exception.backtrace)
-        else
-          original_exception.backtrace
-        end
-      end
-
       def sub_template_message
         if @sub_templates
           "Trace of template inclusion: " +
@@ -87,29 +99,15 @@ module ActionView
         @line_number ||=
           if file_name
             regexp = /#{Regexp.escape File.basename(file_name)}:(\d+)/
-
-            $1 if message =~ regexp or clean_backtrace.find { |line| line =~ regexp }
+            $1 if message =~ regexp || backtrace.find { |line| line =~ regexp }
           end
       end
 
-      def to_s
-        "\n#{self.class} (#{message}) #{source_location}:\n" +
-        "#{source_extract}\n    #{clean_backtrace.join("\n    ")}\n\n"
-      end
-
-      # don't do anything nontrivial here. Any raised exception from here becomes fatal
-      # (and can't be rescued).
-      def backtrace
-        @backtrace
+      def annoted_source_code
+        source_extract(4)
       end
 
       private
-        def compute_backtrace
-          [
-            "#{source_location.capitalize}\n\n#{source_extract(4)}\n    " +
-            clean_backtrace.join("\n    ")
-          ]
-        end
 
         def source_location
           if line_number

data/lib/action_view/template/handlers.rb

@@ -19,7 +19,7 @@ module ActionView #:nodoc:
       @@default_template_handlers = nil
     
       def self.extensions
-        @@template_handlers.keys
+        @@template_extensions ||= @@template_handlers.keys
       end
 
       # Register a class that knows how to handle template files with the given

data/lib/action_view/template/handlers/erb.rb

@@ -1,9 +1,15 @@
 require 'active_support/core_ext/class/attribute_accessors'
 require 'active_support/core_ext/string/output_safety'
+require "action_view/template"
 require 'erubis'
 
 module ActionView
   class OutputBuffer < ActiveSupport::SafeBuffer
+    def initialize(*)
+      super
+      encode! if encoding_aware?
+    end
+
     def <<(value)
       super(value.to_s)
     end
@@ -17,65 +23,106 @@ module ActionView
     end
   end
 
-  module Template::Handlers
-    class Erubis < ::Erubis::Eruby
-      def add_preamble(src)
-        src << "@output_buffer = ActionView::OutputBuffer.new;"
-      end
+  class Template
+    module Handlers
+      class Erubis < ::Erubis::Eruby
+        def add_preamble(src)
+          src << "@output_buffer = ActionView::OutputBuffer.new;"
+        end
 
-      def add_text(src, text)
-        return if text.empty?
-        src << "@output_buffer.safe_concat('" << escape_text(text) << "');"
-      end
+        def add_text(src, text)
+          return if text.empty?
+          src << "@output_buffer.safe_concat('" << escape_text(text) << "');"
+        end
 
-      BLOCK_EXPR = /(do|\{)(\s*\|[^|]*\|)?\s*\Z/
+        BLOCK_EXPR = /\s+(do|\{)(\s*\|[^|]*\|)?\s*\Z/
 
-      def add_expr_literal(src, code)
-        if code =~ BLOCK_EXPR
-          src << '@output_buffer.append= ' << code
-        else
-          src << '@output_buffer.append= (' << code << ');'
+        def add_expr_literal(src, code)
+          if code =~ BLOCK_EXPR
+            src << '@output_buffer.append= ' << code
+          else
+            src << '@output_buffer.append= (' << code << ');'
+          end
         end
-      end
 
-      def add_stmt(src, code)
-        if code =~ BLOCK_EXPR
-          src << '@output_buffer.append_if_string= ' << code
-        else
-          super
+        def add_stmt(src, code)
+          if code =~ BLOCK_EXPR
+            src << '@output_buffer.append_if_string= ' << code
+          else
+            super
+          end
         end
-      end
 
-      def add_expr_escaped(src, code)
-        src << '@output_buffer.append= ' << escaped_expr(code) << ';'
-      end
+        def add_expr_escaped(src, code)
+          src << '@output_buffer.append= ' << escaped_expr(code) << ';'
+        end
 
-      def add_postamble(src)
-        src << '@output_buffer.to_s'
+        def add_postamble(src)
+          src << '@output_buffer.to_s'
+        end
       end
-    end
 
-    class ERB < Template::Handler
-      include Compilable
+      class ERB < Handler
+        include Compilable
 
-      ##
-      # :singleton-method:
-      # Specify trim mode for the ERB compiler. Defaults to '-'.
-      # See ERb documentation for suitable values.
-      cattr_accessor :erb_trim_mode
-      self.erb_trim_mode = '-'
+        ##
+        # :singleton-method:
+        # Specify trim mode for the ERB compiler. Defaults to '-'.
+        # See ERb documentation for suitable values.
+        cattr_accessor :erb_trim_mode
+        self.erb_trim_mode = '-'
 
-      self.default_format = Mime::HTML
+        self.default_format = Mime::HTML
 
-      cattr_accessor :erb_implementation
-      self.erb_implementation = Erubis
+        cattr_accessor :erb_implementation
+        self.erb_implementation = Erubis
 
-      def compile(template)
-        source = template.source.gsub(/\A(<%(#.*coding[:=]\s*(\S+)\s*)-?%>)\s*\n?/, '')
-        erb = "<% __in_erb_template=true %>#{source}"
-        result = self.class.erb_implementation.new(erb, :trim=>(self.class.erb_trim_mode == "-")).src
-        result = "#{$2}\n#{result}" if $2
-        result
+        ENCODING_TAG = Regexp.new("\\A(<%#{ENCODING_FLAG}-?%>)[ \\t]*")
+
+        def self.handles_encoding?
+          true
+        end
+
+        def compile(template)
+          if template.source.encoding_aware?
+            # First, convert to BINARY, so in case the encoding is
+            # wrong, we can still find an encoding tag
+            # (<%# encoding %>) inside the String using a regular
+            # expression
+            template_source = template.source.dup.force_encoding("BINARY")
+
+            erb = template_source.gsub(ENCODING_TAG, '')
+            encoding = $2
+
+            erb.force_encoding valid_encoding(template.source.dup, encoding)
+
+            # Always make sure we return a String in the default_internal
+            erb.encode!
+          else
+            erb = template.source.dup
+          end
+
+          self.class.erb_implementation.new(
+            erb,
+            :trim => (self.class.erb_trim_mode == "-")
+          ).src
+        end
+
+      private
+        def valid_encoding(string, encoding)
+          # If a magic encoding comment was found, tag the
+          # String with this encoding. This is for a case
+          # where the original String was assumed to be,
+          # for instance, UTF-8, but a magic comment
+          # proved otherwise
+          string.force_encoding(encoding) if encoding
+
+          # If the String is valid, return the encoding we found
+          return string.encoding if string.valid_encoding?
+
+          # Otherwise, raise an exception
+          raise WrongEncodingError.new(string, string.encoding)
+        end
       end
     end
   end

data/lib/action_view/template/resolver.rb

@@ -70,7 +70,10 @@ module ActionView
 
       Dir[query].reject { |p| File.directory?(p) }.map do |p|
         handler, format = extract_handler_and_format(p, formats)
-        Template.new(File.read(p), File.expand_path(p), handler,
+
+        contents = File.open(p, "rb") {|io| io.read }
+
+        Template.new(contents, File.expand_path(p), handler,
           :virtual_path => path, :format => format)
       end
     end

data/lib/action_view/test_case.rb

@@ -1,4 +1,5 @@
 require 'active_support/core_ext/object/blank'
+require 'action_controller'
 require 'action_controller/test_case'
 require 'action_view'
 
@@ -9,11 +10,16 @@ module ActionView
 
       attr_accessor :request, :response, :params
 
-      def self.controller_path
-        ''
+      class << self
+        attr_writer :controller_path
+      end
+
+      def controller_path=(path)
+        self.class.controller_path=(path)
       end
 
       def initialize
+        self.class.controller_path = ""
         @request = ActionController::TestRequest.new
         @response = ActionController::TestResponse.new
 
@@ -23,80 +29,99 @@ module ActionView
       end
     end
 
-    include ActionDispatch::Assertions, ActionDispatch::TestProcess
-    include ActionController::TemplateAssertions
-    include ActionView::Context
+    module Behavior
+      extend ActiveSupport::Concern
 
-    include ActionController::PolymorphicRoutes
-    include ActionController::RecordIdentifier
+      include ActionDispatch::Assertions, ActionDispatch::TestProcess
+      include ActionController::TemplateAssertions
+      include ActionView::Context
 
-    include ActionView::Helpers
-    include ActionController::Helpers
+      include ActionController::PolymorphicRoutes
+      include ActionController::RecordIdentifier
 
-    class_inheritable_accessor :helper_class
-    attr_accessor :controller, :output_buffer, :rendered
+      include AbstractController::Helpers
+      include ActionView::Helpers
 
-    setup :setup_with_controller
-    def setup_with_controller
-      @controller = TestController.new
-      @output_buffer = ActiveSupport::SafeBuffer.new
-      @rendered = ''
+      attr_accessor :controller, :output_buffer, :rendered
+      
+      module ClassMethods
+        def tests(helper_class)
+          self.helper_class = helper_class
+        end
 
-      self.class.send(:include_helper_modules!)
-      make_test_case_available_to_view!
-    end
+        def determine_default_helper_class(name)
+          mod = name.sub(/Test$/, '').constantize
+          mod.is_a?(Class) ? nil : mod
+        rescue NameError
+          nil
+        end
 
-    def config
-      @controller.config if @controller.respond_to?(:config)
-    end
+        def helper_method(*methods)
+          # Almost a duplicate from ActionController::Helpers
+          methods.flatten.each do |method|
+            _helpers.module_eval <<-end_eval
+              def #{method}(*args, &block)                    # def current_user(*args, &block)
+                _test_case.send(%(#{method}), *args, &block)  #   test_case.send(%(current_user), *args, &block)
+              end                                             # end
+            end_eval
+          end
+        end
 
-    def render(options = {}, local_assigns = {}, &block)
-      @rendered << output = _view.render(options, local_assigns, &block)
-      output
-    end
+        attr_writer :helper_class
 
-    def protect_against_forgery?
-      false
-    end
+        def helper_class
+          @helper_class ||= determine_default_helper_class(name)
+        end
 
-    class << self
-      def tests(helper_class)
-        self.helper_class = helper_class
-      end
+      private
 
-      def helper_class
-        if current_helper_class = read_inheritable_attribute(:helper_class)
-          current_helper_class
-        else
-          self.helper_class = determine_default_helper_class(name)
+        def include_helper_modules!
+          helper(helper_class) if helper_class
+          include _helpers
         end
+
       end
 
-      def determine_default_helper_class(name)
-        name.sub(/Test$/, '').constantize
-      rescue NameError
-        nil
+      def setup_with_controller
+        @controller = ActionView::TestCase::TestController.new
+        @output_buffer = ActiveSupport::SafeBuffer.new
+        @rendered = ''
+
+        self.class.send(:include_helper_modules!)
+        make_test_case_available_to_view!
+        say_no_to_protect_against_forgery!
       end
 
-      def helper_method(*methods)
-        # Almost a duplicate from ActionController::Helpers
-        methods.flatten.each do |method|
-          _helpers.module_eval <<-end_eval
-            def #{method}(*args, &block)                    # def current_user(*args, &block)
-              _test_case.send(%(#{method}), *args, &block)  #   test_case.send(%(current_user), *args, &block)
-            end                                             # end
-          end_eval
-        end
+      def config
+        @controller.config if @controller.respond_to?(:config)
       end
 
-      private
-        def include_helper_modules!
-          helper(helper_class) if helper_class
-          include _helpers
-        end
-    end
+      def render(options = {}, local_assigns = {}, &block)
+        @rendered << output = _view.render(options, local_assigns, &block)
+        output
+      end
+
+      included do
+        setup :setup_with_controller
+      end
 
     private
+
+      # Support the selector assertions
+      #
+      # Need to experiment if this priority is the best one: rendered => output_buffer
+      def response_from_page_or_rjs
+        HTML::Document.new(@rendered.blank? ? @output_buffer : @rendered).root
+      end
+
+      def say_no_to_protect_against_forgery!
+        _helpers.module_eval do
+          def protect_against_forgery?
+            false
+          end
+        end
+      end
+
       def make_test_case_available_to_view!
         test_case_instance = self
         _helpers.module_eval do
@@ -106,32 +131,35 @@ module ActionView
       end
 
       def _view
-        view = ActionView::Base.new(ActionController::Base.view_paths, _assigns, @controller)
-        view.singleton_class.send :include, _helpers
-        view.singleton_class.send :include, @controller._router.url_helpers
-        view.output_buffer = self.output_buffer
-        view
-      end
-
-      # Support the selector assertions
-      #
-      # Need to experiment if this priority is the best one: rendered => output_buffer
-      def response_from_page_or_rjs
-        HTML::Document.new(rendered.blank? ? output_buffer : rendered).root
+        @_view ||= begin
+                     view = ActionView::Base.new(ActionController::Base.view_paths, _assigns, @controller)
+                     view.singleton_class.send :include, _helpers
+                     view.singleton_class.send :include, @controller._router.url_helpers
+                     view.singleton_class.send :delegate, :alert, :notice, :to => "request.flash"
+                     view.output_buffer = self.output_buffer
+                     view
+                   end
       end
 
       EXCLUDE_IVARS = %w{
+        @_result
         @output_buffer
-        @fixture_cache
+        @rendered
+        @templates
+        @view_context_class
+        @layouts
+        @partials
+        @controller
+
         @method_name
-        @_result
+        @fixture_cache
         @loaded_fixtures
         @test_passed
-        @view
       }
 
       def _instance_variables
         instance_variables - EXCLUDE_IVARS
+        instance_variables
       end
 
       def _assigns
@@ -154,5 +182,10 @@ module ActionView
           super
         end
       end
+
+    end
+
+    include Behavior
+
   end
 end