actionmcp 0.7.0 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 328575eb20b901f6a8b7aa2caf13b1a23c1bd2021eb74408d2f36314e0fda829
-  data.tar.gz: da1a9c14363f3d9104cecc61af3e4dac402d623a0054c1b4318cc54e16a0dd0a
+  metadata.gz: bea2e23118051ba1a05eb00dfb44395841068fe6358b341e01a1951f7064a259
+  data.tar.gz: e1ff02d641a4684c0369fa252139edeb8bf1dae41193deeca122832bcb0ac318
 SHA512:
-  metadata.gz: dcdd5da1fa8d6e48f373cd6ae1219b80870aae0d965456f4a6ab9be837dea71245604d6e2f2f7d2a5cd4066ac04d672283c7415f507a50c0a93a0f8c38a65c7f
-  data.tar.gz: a09c09d16754784de58995065089fce4fadea61df562358485ea794998cda9662f22dad89fff72cd313906350da22927b24584dfa761d4dc28134e9a82f0040c
+  metadata.gz: '097b59b77ef2028887ef159f211a314a9a9fa83edb7ff26f50d62fc56a834bf5df96e7781c5cd715d511ee957736f242971f76baac3d8b1fffd213f6373afe5c'
+  data.tar.gz: 13582b839164819da648df7e319df9e8aac565f2792bee75c44d23d1fd7af531e01d6c7a8e82f63d46fc9cd68f7d42fe10622748202a6ca10dc99ff332d8d7a5

data/app/controllers/action_mcp/sse_controller.rb

@@ -1,7 +1,6 @@
 module ActionMCP
   class SSEController < ApplicationController
     HEARTBEAT_INTERVAL = 30 # TODO: The frequency of pings SHOULD be configurable
-    INITIALIZATION_TIMEOUT = 2
     include ActionController::Live
 
     # @route GET /sse (sse_out)
@@ -16,11 +15,13 @@ module ActionMCP
       send_endpoint_event(sse_in_url)
 
       begin
+        # Create SSE instance once outside the callback with retry parameter
+        sse = SSE.new(response.stream)
+
         # Start listener and process messages via the transport
         listener = SSEListener.new(mcp_session)
         if listener.start do |message|
           # Send with proper SSE formatting
-          sse = SSE.new(response.stream)
           sse.write(message)
         end
 
@@ -74,25 +75,22 @@ module ActionMCP
     def initialize(session)
       @session = session
       @stopped = false
-      @subscription_active = false
     end
 
     # Start listening using ActionCable's adapter
     def start(&callback)
       Rails.logger.debug "Starting listener for channel: #{session_key}"
 
-      # Set up success callback
       success_callback = -> {
-        Rails.logger.debug "Successfully subscribed to channel: #{session_key}"
+        puts "Successfully subscribed to channel: #{session_key}"
         @subscription_active = true
       }
 
-      # Set up message callback with detailed debugging
+      # Set up message callback
       message_callback = ->(raw_message) {
         begin
           # Try to parse the message if it's JSON
           message = MultiJson.load(raw_message)
-
           # Send the message to the callback
           callback.call(message) if callback && !@stopped
         rescue => e
@@ -102,7 +100,7 @@ module ActionMCP
       }
 
       # Subscribe using the ActionCable adapter
-      adapter.subscribe(session_key, message_callback, success_callback)
+      success = adapter.subscribe(session_key, message_callback, success_callback)
 
       # Give some time for the subscription to be established
       sleep 0.5
@@ -111,21 +109,10 @@ module ActionMCP
     end
 
     def stop
-      Rails.logger.debug "Stopping listener for: #{session_key}"
       @stopped = true
 
-      # Unsubscribe using the correct method signature
-      begin
-        # Create a dummy callback that matches the one we provided in start
-        @session.close!
-        Rails.logger.debug "Unsubscribed from: #{session_key}"
-      rescue => e
-        Rails.logger.error "Error unsubscribing from #{session_key}: #{e.message}"
-      end
-    end
-
-    def active?
-      @subscription_active
+      @session.close!
+      Rails.logger.debug "Unsubscribed from: #{session_key}"
     end
   end
 end

data/lib/action_mcp/engine.rb

@@ -15,6 +15,10 @@ module ActionMCP
     # Provide a configuration namespace for ActionMCP
     config.action_mcp = ActionMCP.configuration
 
+    config.to_prepare do
+      ActionMCP::ResourceTemplate.registered_templates.clear
+    end
+
     # Configure autoloading for the mcp/tools directory
     initializer "action_mcp.autoloading", before: :set_autoload_paths do |app|
       mcp_path = app.root.join("app/mcp")

data/lib/action_mcp/resource_template.rb

@@ -179,6 +179,8 @@ module ActionMCP
         ResourceTemplate.registered_templates.each do |registered_class|
           next if registered_class == self || registered_class.abstract?
           next unless registered_class.uri_template
+          # Ignore conflicts with resource templates that have the same name
+          next if registered_class.name == self.name
 
           existing_template_data = parse_uri_template(registered_class.uri_template)
 

data/lib/action_mcp/tool.rb

@@ -74,7 +74,7 @@ module ActionMCP
 
       return unless %w[number integer].include?(type)
 
-      validates prop_name, numericality: true
+      validates prop_name, numericality: true, allow_nil: true
     end
 
     # --------------------------------------------------------------------------

data/lib/action_mcp/transport/resources.rb

@@ -56,7 +56,7 @@ module ActionMCP
             content = resource.map(&:to_h)
             send_jsonrpc_response(id, result: { contents: content })
           else
-            send_jsonrpc_error(id, :resource_not_found, "Resource not found")
+            send_jsonrpc_error(id, :invalid_params, "Resource not found")
           end
         else
           send_jsonrpc_error(id, :invalid_params, "Invalid resource URI")

data/lib/action_mcp/version.rb

@@ -2,7 +2,7 @@
 
 require_relative "gem_version"
 module ActionMCP
-  VERSION = "0.7.0"
+  VERSION = "0.7.2"
 
   class << self
     alias version gem_version

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: actionmcp
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.2
 platform: ruby
 authors:
 - Abdelkader Boudih