actionmcp 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a8c8a94933ac8bd63140d48502c583f501779e7e5cdfa60f3d5dbaa095336865
-  data.tar.gz: 714a7e9f4ed1b7db0fa3814bc270be7b0f9fe075ecde6fc2a44d435df3a88e03
+  metadata.gz: 2076a5b8889ceab961159bae4bfd5c1a1dafab08d9ef8d9aba22f76d383d79ec
+  data.tar.gz: 30f65d94598ece958efeba9bbbf679cb7f3f2a0edc1ac886acc8b9d57eed890b
 SHA512:
-  metadata.gz: d7f572402551c7e210f81e9f0dbe7eef5f7344ab17227e4d0b7957329d0442aa11a6d5fe75479c0c65919dbe429e12f6bcb0f0a056c0f1009efcd5d3ade2472c
-  data.tar.gz: 38f6ed89c283df6d4c969b8f5efb88f32e459d8277e813061ef35b92a32de2ecc931abb73c8e1025714acfba455706d6e29d386ffbb3e007593791c0edc9de02
+  metadata.gz: 283f6f908e4607e3bd1a811840652d5c7a6ab749bd24d812a4a453178c3d7eb03896d407753b2379aa250ab6d4cdb62728d7d13fda012c9b271ae6ced04a486b
+  data.tar.gz: 389af0c9cc3747c6d5ea4245801867dd22af3b303d87167f0bbface5d3282c944e05ac7203410f9c0b501377dd1928f3a116a691a775d80f7cae7ba0dc27b98e

data/app/models/action_mcp/session/message.rb

@@ -14,6 +14,11 @@ module ActionMCP
     attr_reader :data
 
     after_create_commit :broadcast_message, if: :outgoing_message?
+    # Set is_ping on responses if the original request was a ping
+    after_create :handle_ping_response, if: -> { %w[response error].include?(message_type) }
+
+    # Scope to exclude both "ping" requests and their responses
+    scope :without_pings, -> { where(is_ping: false) }
 
     # @param payload [String, Hash]
     def data=(payload)
@@ -22,17 +27,14 @@ module ActionMCP
       # Store original version and attempt to determine type
       if payload.is_a?(String)
         self.message_text = payload
-
         begin
           parsed_json = MultiJson.load(payload)
           self.message_json = parsed_json
           process_json_content(parsed_json)
         rescue MultiJson::ParseError
-          # Not valid JSON, just store as text
           self.message_type = "text"
         end
       else
-        # Handle Hash or other JSON-serializable input
         self.message_json = payload
         self.message_text = MultiJson.dump(payload)
         process_json_content(payload)
@@ -43,7 +45,7 @@ module ActionMCP
       message_json.presence || message_text
     end
 
-    # Helper method to check if message is a particular type
+    # Helper methods
     def request?
       message_type == "request"
     end
@@ -67,19 +69,20 @@ module ActionMCP
     end
 
     def process_json_content(content)
-      # Determine message type based on JSON-RPC spec
       if content.is_a?(Hash) && content["jsonrpc"] == "2.0"
         if content.key?("id") && content.key?("method")
           self.message_type = "request"
-          self.jsonrpc_id = content["id"]
+          self.jsonrpc_id = content["id"].to_s
+          # Set is_ping to true if the method is "ping"
+          self.is_ping = true if content["method"] == "ping"
         elsif content.key?("method") && !content.key?("id")
           self.message_type = "notification"
         elsif content.key?("id") && content.key?("result")
           self.message_type = "response"
-          self.jsonrpc_id = content["id"]
+          self.jsonrpc_id = content["id"].to_s
         elsif content.key?("id") && content.key?("error")
           self.message_type = "error"
-          self.jsonrpc_id = content["id"]
+          self.jsonrpc_id = content["id"].to_s
         else
           self.message_type = "invalid_jsonrpc"
         end
@@ -87,5 +90,18 @@ module ActionMCP
         self.message_type = "non_jsonrpc_json"
       end
     end
+
+    def handle_ping_response
+      return unless jsonrpc_id.present?
+      request_message = session.messages.find_by(
+        jsonrpc_id: jsonrpc_id,
+        message_type: "request"
+      )
+      if request_message&.is_ping
+        self.is_ping = true
+        request_message.update(ping_acknowledged: true)
+        save! if changed?
+      end
+    end
   end
 end

data/app/models/action_mcp/session.rb

@@ -83,7 +83,9 @@ module ActionMCP
     end
 
     def send_ping!
-      write(JsonRpc::Request.new(id: Time.now.to_i, method: "ping"))
+      Session.logger.silence do
+        write(JsonRpc::Request.new(id: Time.now.to_i, method: "ping"))
+      end
     end
 
     private

data/db/migrate/20250314230152_add_is_ping_to_session_message.rb

@@ -0,0 +1,6 @@
+class AddIsPingToSessionMessage < ActiveRecord::Migration[8.0]
+  def change
+    add_column :action_mcp_session_messages, :is_ping, :boolean, default: false, null: false
+    add_column :action_mcp_session_messages, :ping_acknowledged, :boolean, default: false, null: false
+  end
+end

data/lib/action_mcp/capability.rb

@@ -10,7 +10,6 @@ module ActionMCP
 
     class_attribute :_capability_name, instance_accessor: false
     class_attribute :_description, instance_accessor: false, default: ""
-    class_attribute :abstract_tool, instance_accessor: false, default: false
 
     # use _capability_name or default_capability_name
     def self.capability_name

data/lib/action_mcp/resource_template.rb

@@ -2,10 +2,20 @@
 
 module ActionMCP
   class ResourceTemplate
-    class_attribute :abstract, instance_accessor: false, default: false
-
     class << self
-      attr_writer :abstract
+      def abstract?
+        @abstract ||= false
+      end
+
+      def abstract!
+        @abstract = true
+      end
+
+      def inherited(subclass)
+        super
+        subclass.instance_variable_set(:@abstract, false)
+      end
+
       attr_reader :description, :uri_template, :mime_type, :template_name, :parameters
 
       def parameter(name, description:, required: false)
@@ -48,14 +58,6 @@ module ActionMCP
         raise NotImplementedError, "Subclasses must implement the retrieve method"
       end
 
-      def abstract?
-        abstract
-      end
-
-      def abstract!
-        self.abstract = true
-      end
-
       def capability_name
         name.demodulize.underscore.sub(/_template$/, "")
       end
@@ -63,4 +65,4 @@ module ActionMCP
 
     attr_reader :description, :uri_template, :mime_type
   end
-end
+end

data/lib/action_mcp/version.rb

@@ -2,7 +2,7 @@
 
 require_relative "gem_version"
 module ActionMCP
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 
   class << self
     alias version gem_version

data/lib/generators/action_mcp/install/templates/mcp_resource_template.rb

@@ -1,3 +1,3 @@
-class MCPResourceTemplate < ActionMcp::ResourceTemplate
+class MCPResourceTemplate < ActionMCP::ResourceTemplate
   abstract!
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: actionmcp
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Abdelkader Boudih
 bindir: exe
 cert_chain: []
-date: 2025-03-14 00:00:00.000000000 Z
+date: 2025-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -114,6 +114,7 @@ files:
 - app/models/action_mcp/session/message.rb
 - config/routes.rb
 - db/migrate/20250308122801_create_action_mcp_sessions.rb
+- db/migrate/20250314230152_add_is_ping_to_session_message.rb
 - exe/actionmcp_cli
 - lib/action_mcp.rb
 - lib/action_mcp/capability.rb