actionmcp 0.17.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e33a00e3a56b0dba226465afd8ce6695158400bb5a26876fa92f72cea65a5418
-  data.tar.gz: 9243f9316686638c66f716d333803db0b8ad0e32d052728b1ca1e1dc5eda21cb
+  metadata.gz: cb964a85c5ae8f64c05730e054c3e252c22e8fe3eeea6230496929948ea51f68
+  data.tar.gz: a7cfd82678922926ef8beb28cc0346ebb583f826d1cc9ff9d8d54f55cecd08d7
 SHA512:
-  metadata.gz: d0bdf008e20cbe4bc36d4a295201eb16570fd5e5dc83c24fef759daac1c622c6b58ce16f671db06d326714587e7ecca1b22234829d9c59ea40759b9c78b8e976
-  data.tar.gz: 948bf31356b50d4004093890ca8a336a1e3eb41a85ce95d46e01a41f1a1823f0a2ff20fd849ab2eccda1b7569db9573ab0c84911ea263c2db0b85f2f20c07cdc
+  metadata.gz: f6c12f6088da3ca4e642fe9aac72d7caeacd9630619c61a1d2c93006e87ab2da7d35eb25467e086d6ecb5e3109546f0f61285e6f9c175183fb8b1365f7cbae96
+  data.tar.gz: 70cbe6bcbf594afcc7558f3c178771c5b2d9c06d00f7474288bfbe59d9da694ccef578c68a0c5cf9a6a571f4ef51f317ed2fa34d57600321364beffb5ba7fe77

data/app/models/action_mcp/session/message.rb

@@ -63,13 +63,14 @@ module ActionMCP
           begin
             parsed_json = MultiJson.load(payload)
             self.message_json = parsed_json
+            self.message_text = nil
             process_json_content(parsed_json)
           rescue MultiJson::ParseError
             self.message_type = "text"
           end
         else
           self.message_json = payload
-          self.message_text = MultiJson.dump(payload)
+          self.message_text = nil
           process_json_content(payload)
         end
       end

data/lib/action_mcp/resource_template.rb

@@ -9,6 +9,7 @@ module ActionMCP
     include ActiveModel::Validations
     include ResourceCallbacks
     include Logging
+    include UriAmbiguityChecker
 
     # Track all registered templates
     @registered_templates = []
@@ -195,40 +196,6 @@ module ActionMCP
                 "URI template conflict detected: '#{new_template}' conflicts with existing template '#{registered_class.uri_template}' registered by #{registered_class.name}"
         end
       end
-
-      # Determine if two normalized patterns could be ambiguous
-      def are_potentially_ambiguous?(pattern1, pattern2)
-        # If the patterns are exactly the same, they're definitely ambiguous
-        return true if pattern1 == pattern2
-
-        # Split into segments to compare structure
-        segments1 = pattern1.split("/")
-        segments2 = pattern2.split("/")
-
-        # If different number of segments, they can't be ambiguous
-        return false if segments1.size != segments2.size
-
-        # Count parameter segments
-        param_segments1 = segments1.count { |s| s.include?("{param}") }
-        param_segments2 = segments2.count { |s| s.include?("{param}") }
-
-        # If they have different number of parameter segments, they're not ambiguous
-        return false if param_segments1 != param_segments2
-
-        # If we have the same number of segments and same number of parameters,
-        # but the patterns aren't identical, they could be ambiguous
-        # due to parameter position swapping
-        if param_segments1.positive? && param_segments1 == param_segments2
-          # Create pattern maps (P for param, S for static)
-          pattern_map1 = segments1.map { |s| s.include?("{param}") ? "P" : "S" }
-          pattern_map2 = segments2.map { |s| s.include?("{param}") ? "P" : "S" }
-
-          # If pattern maps are different but have same param count, potentially ambiguous
-          return pattern_map1 != pattern_map2
-        end
-
-        false
-      end
     end
 
     # Initialize with attribute values

data/lib/action_mcp/tool_response.rb

@@ -72,6 +72,14 @@ module ActionMCP
       [ contents, is_error ].hash
     end
 
+    def success?
+      !is_error
+    end
+
+    def error?
+      is_error
+    end
+
     # Pretty print for better debugging
     def inspect
       "#<#{self.class.name} content: #{contents.inspect}, isError: #{is_error}>"

data/lib/action_mcp/uri_ambiguity_checker.rb

@@ -0,0 +1,74 @@
+module ActionMCP
+  module UriAmbiguityChecker
+    extend ActiveSupport::Concern
+
+    class_methods do
+      # Determines if a segment is a parameter
+      def parameter?(segment)
+        segment =~ /\A\{[a-z0-9_]+\}\z/
+      end
+
+      # Checks if two URI patterns could potentially match the same URI
+      def are_potentially_ambiguous?(pattern1, pattern2)
+        # If the patterns are exactly the same, they're definitely ambiguous
+        return true if pattern1 == pattern2
+
+        segments1 = pattern1.split("/")
+        segments2 = pattern2.split("/")
+
+        # If different number of segments, they can't be ambiguous
+        if segments1.size != segments2.size
+          return false
+        end
+
+        # Extract literals (non-parameters) from each pattern
+        literals1 = []
+        literals2 = []
+
+        segments1.each_with_index do |seg, i|
+          literals1 << [ seg, i ] unless parameter?(seg)
+        end
+
+        segments2.each_with_index do |seg, i|
+          literals2 << [ seg, i ] unless parameter?(seg)
+        end
+
+        # Check each segment for direct literal mismatches
+        segments1.zip(segments2).each_with_index do |(seg1, seg2), index|
+          param1 = parameter?(seg1)
+          param2 = parameter?(seg2)
+
+          # When both segments are literals, they must match exactly
+          if !param1 && !param2 && seg1 != seg2
+            return false
+          end
+        end
+
+        # Check for structural incompatibility in the literals
+        # If the same literals appear in different relative order, the patterns are structurally different
+        if literals1.size >= 2 && literals2.size >= 2
+          # Create arrays of just the literals (without positions)
+          lit_values1 = literals1.map(&:first)
+          lit_values2 = literals2.map(&:first)
+
+          # Find common literals
+          common_literals = lit_values1 & lit_values2
+
+          if common_literals.size >= 2
+            # Check if the relative ordering of common literals differs
+            common_literal_indices1 = common_literals.map { |lit| lit_values1.index(lit) }
+            common_literal_indices2 = common_literals.map { |lit| lit_values2.index(lit) }
+
+            # If the relative ordering is different, patterns are not ambiguous
+            if common_literal_indices1 != common_literal_indices2
+              return false
+            end
+          end
+        end
+
+        # If we got here, the patterns are potentially ambiguous
+        true
+      end
+    end
+  end
+end

data/lib/action_mcp/version.rb

@@ -2,7 +2,7 @@
 
 require_relative "gem_version"
 module ActionMCP
-  VERSION = "0.17.0"
+  VERSION = "0.19.0"
 
   class << self
     alias version gem_version

data/lib/tasks/action_mcp_tasks.rake

@@ -44,7 +44,7 @@ namespace :action_mcp do
     ActionMCP::ResourceTemplate.descendants.each do |resource|
       next if resource.abstract?
 
-      puts "\e[33m#{resource.capability_name}:\e[0m #{resource.description}" # Yellow name
+      puts "\e[33m#{resource.capability_name}:\e[0m #{resource.description} : #{resource.uri_template}" # Yellow name
     end
     puts "\n"
   end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionmcp
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.19.0
 platform: ruby
 authors:
 - Abdelkader Boudih
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-03-21 00:00:00.000000000 Z
+date: 2025-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actioncable
@@ -176,6 +177,7 @@ files:
 - lib/action_mcp/transport/tools.rb
 - lib/action_mcp/transport/transport_base.rb
 - lib/action_mcp/transport_handler.rb
+- lib/action_mcp/uri_ambiguity_checker.rb
 - lib/action_mcp/version.rb
 - lib/actionmcp.rb
 - lib/generators/action_mcp/install/install_generator.rb
@@ -197,6 +199,7 @@ metadata:
   source_code_uri: https://github.com/seuros/action_mcp
   changelog_uri: https://github.com/seuros/action_mcp/blob/master/CHANGELOG.md
   rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -211,7 +214,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.5
+rubygems_version: 3.5.22
+signing_key:
 specification_version: 4
 summary: Provides essential tooling for building Model Context Protocol (MCP) capable
   servers