actionmcp 0.10.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39f50d723aa2a52bcc863de6cec116970a5595719f4f974e21a91d40e6279685
-  data.tar.gz: d5dd09cf26636b709e928c36b710a7319d4afa05e4538fe090e4a7d9f0571533
+  metadata.gz: a4b4a90666d6b9f71c78a0c49373d75bd4c2007de573f8af3c37d621c4bfaf0c
+  data.tar.gz: 7c97ab30f559374971ca38e1f8aad6ecd6e54d5251891ba398277eaee53408c7
 SHA512:
-  metadata.gz: bec413dbeb4c8377f57f0d8a4942b0e04bc71412e8aea833730c521965e5b3e1f4803dd5f37553fa7d51d31baeefd8efde86bdb26309e698ae43546a2ad88957
-  data.tar.gz: 8790e5172337913ffc393bf1deaa4f09e689f85f9ba1bc611fcbbd261788cc625deed50fc361c3c1b8d131407777d39bf17461bf9f18893ed21597dd9edeefd1
+  metadata.gz: fc7f904a5d47a764498d276205c63b9d0ce16b44fce651159bf6d525978d23df1be6cf1060f4f289a82baf8b815f6630b7b0d023013989e7dd1e97c97b9eb7bd
+  data.tar.gz: 317f8156fb89000bc56c77ef4c9c4061d434f5c592355ac1021308bb8745750bffc0554d8aaf003300a7d59e4f31d3dcb842c96de87a47d32ee79807c0263884

data/lib/action_mcp/json_rpc_handler.rb

@@ -102,6 +102,8 @@ module ActionMCP
     #     }
     #   }
     def process_completion_complete(id, params)
+      # TODO: Not Implemented, but to remove the error message in the inspector
+      transport.send_jsonrpc_response(id, result: { completion: { values: [], total: 0, hasMore: false } })
       case params["ref"]["type"]
       when "ref/prompt"
         # TODO: Implement completion

data/lib/action_mcp/prompt_response.rb

@@ -3,8 +3,7 @@
 module ActionMCP
   class PromptResponse
     include Enumerable
-
-    attr_reader :messages
+    attr_reader :messages, :is_error
 
     # Delegate methods to the underlying messages array
     delegate :empty?, :size, :each, :find, :map, to: :messages
@@ -26,7 +25,7 @@ module ActionMCP
       self
     end
 
-    def mark_as_error!(symbol, message: nil, data: nil)
+    def mark_as_error!(symbol = :invalid_request, message: nil, data: nil)
       @is_error = true
       @symbol = symbol
       @error_message = message

data/lib/action_mcp/prompts_registry.rb

@@ -17,20 +17,7 @@ module ActionMCP
       def prompt_call(prompt_name, arguments)
         prompt = find(prompt_name)
         prompt = prompt.new(arguments)
-        prompt.valid?
-        if prompt.valid?
-          {
-            messages: [ {
-              role: "user",
-              content: prompt.call
-            } ]
-          }
-        else
-          {
-            content: prompt.errors.full_messages.map { |msg| Content::Text.new(msg) },
-            isError: true
-          }
-        end
+        prompt.call
       end
 
       def item_klass

data/lib/action_mcp/tool.rb

@@ -134,13 +134,11 @@ module ActionMCP
           perform # Invoke the subclass-specific logic if valid
         rescue => e
           # Handle exceptions during execution
-          @response.mark_as_error!
-          render text: "Error executing tool: #{e.message}"
+          @response.mark_as_error!(:internal_error, message: e.message)
         end
       else
         # Handle validation failure
-        @response.mark_as_error!
-        render text: "Invalid input: #{errors.full_messages.join(', ')}"
+        @response.mark_as_error!(:invalid_request, message: "Invalid input", data: errors.full_messages)
       end
 
       @response # Return the response with collected content

data/lib/action_mcp/tool_response.rb

@@ -19,17 +19,23 @@ module ActionMCP
     end
 
     # Mark response as error
-    def mark_as_error!
+    def mark_as_error!(symbol = :invalid_request, message: nil, data: nil)
       @is_error = true
+      @symbol = symbol
+      @error_message = message
+      @error_data = data
       self
     end
 
     # Convert to hash format expected by MCP protocol
-    def to_h(options = {})
-      {
-        content: @contents.map { |c| c.to_h },
-        isError: @is_error
-      }
+    def to_h
+      if @is_error
+        JsonRpc::JsonRpcError.new(@symbol, message: @error_message, data: @error_data).to_h
+      else
+        {
+          content: @contents.map { |c| c.to_h },
+        }
+      end
     end
 
     # Alias as_json to to_h for consistency

data/lib/action_mcp/tools_registry.rb

@@ -20,9 +20,11 @@ module ActionMCP
         tool = tool_class.new(arguments)
 
         tool.call.to_h
+      rescue RegistryBase::NotFound
+        error_response(:invalid_params, message: "Tool not found: #{tool_name}")
       rescue StandardError => e
         # FIXME, we should maybe not return the error message to the user
-        error_response([ "Tool execution failed: #{e.message}" ])
+        error_response(:invalid_params, message: "Tool execution failed: #{e.message}")
       end
 
       def item_klass
@@ -31,11 +33,9 @@ module ActionMCP
 
       private
 
-      def error_response(messages)
-        {
-          content: messages.map { |msg| Content::Text.new(msg) },
-          isError: true
-        }
+      def error_response(symbol, message: nil, data: nil)
+        response = ToolResponse.new
+        response.mark_as_error!(symbol, message: message, data: data)
       end
     end
   end

data/lib/action_mcp/transport/prompts.rb

@@ -7,12 +7,12 @@ module ActionMCP
       end
 
       def send_prompts_get(request_id, prompt_name, params)
-        send_jsonrpc_response(request_id, result: PromptsRegistry.prompt_call(prompt_name.to_s, params))
-      rescue RegistryBase::NotFound
-        send_jsonrpc_response(request_id, error: JsonRpc::JsonRpcError.new(
-          :method_not_found,
-          message: "Prompt not found: #{prompt_name}"
-        ).as_json)
+        result = PromptsRegistry.prompt_call(prompt_name.to_s, params)
+        if result.is_error
+          send_jsonrpc_response(request_id, error: result)
+        else
+          send_jsonrpc_response(request_id, result:)
+        end
       end
     end
   end

data/lib/action_mcp/transport/tools.rb

@@ -8,12 +8,11 @@ module ActionMCP
 
       def send_tools_call(request_id, tool_name, arguments, _meta = {})
         result = ToolsRegistry.tool_call(tool_name, arguments, _meta)
-        send_jsonrpc_response(request_id, result: result)
-      rescue RegistryBase::NotFound
-        send_jsonrpc_response(request_id, error: JsonRpc::JsonRpcError.new(
-          :method_not_found,
-          message: "Tool not found: #{tool_name}"
-        ).as_json)
+        if result.is_error
+          send_jsonrpc_response(request_id, error: result)
+        else
+          send_jsonrpc_response(request_id, result:)
+        end
       end
     end
   end

data/lib/action_mcp/version.rb

@@ -2,7 +2,7 @@
 
 require_relative "gem_version"
 module ActionMCP
-  VERSION = "0.10.0"
+  VERSION = "0.12.0"
 
   class << self
     alias version gem_version

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: actionmcp
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.12.0
 platform: ruby
 authors:
 - Abdelkader Boudih