actioninteractor 0.0.14 → 0.0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f08c637f81de888650ae3d393f950ab1175da21b5e6ef8372fb09e79cc74ed6c
-  data.tar.gz: 7f3e79960f36ec8798de280126c81bb01b0db3e4a40a46425b3474ef6b3bf3d2
+  metadata.gz: 1cf59e621fd60a8cfb99220e97d08b679bc639a38d161e4c3254720969f761c6
+  data.tar.gz: bdbd3020978080ea42f44a17424c9f0ae71787ebd8fe37cbbe9e2b00569ea70a
 SHA512:
-  metadata.gz: 97a5902178899624a1ce4f53f384b298d241bde185495076489097fc46a254531eef05dfe92475193a496bebdd66b8f7fe11847220719e14e39ee029354e4cf1
-  data.tar.gz: b212e659fb2a716e8f1fda31b61de2fc2700941da1ef9e07b88cc94c0bdf00042487ed335929ef3950dccdd2773c80aaeeec863ae207078d4a128cd8d4504258
+  metadata.gz: d55546b260465dedecc262964d10001f2e12964af2d6bc2d35a4546eaa6aed91131c109590a86b68b901b7fdcb64d3b180a77c4df712e139ce839fd8ebe16691
+  data.tar.gz: 01c4533072dd4020a359257e516b35fac8f80b316eadd2000e63de3b350aa81ae0d2f616357365fdecfadde5331bdad37cdc39a62b948448b39c0de4cd70323b

data/lib/action_interactor/base.rb

@@ -2,7 +2,7 @@
 
 module ActionInteractor
   class Base
-    attr_reader :params, :result
+    attr_reader :params, :results
 
     def initialize(params)
       @params = params
@@ -40,7 +40,7 @@ module ActionInteractor
     end
 
     def reset!
-      @result = {}
+      @results = Results.new
       @_success = false
       @_finished = false
     end
@@ -54,21 +54,12 @@ module ActionInteractor
       @_success = true
       @_finished = true
     end
-    alias_method :finish!, :success!
 
     def fail!
       @_success = false
       @_finished = true
     end
 
-    def add_result(key, value)
-      @result[key] = value
-    end
-
-    def results(items = {})
-      @result = items
-    end
-
     class << self
       def execute(params)
         new(params).tap(&:execute)

data/lib/action_interactor/results.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require "forwardable"
+
+module ActionInteractor
+  class Results
+    include Enumerable
+    extend Forwardable
+
+    attr_reader :_results
+
+    def_delegators :@_results, :clear, :keys, :values, :[], :delete
+
+    def initialize(*)
+      @_results = {}
+    end
+
+    def add(attribute, detail)
+      _results[attribute.to_sym] = detail
+    end
+  end
+end

data/lib/actioninteractor.rb

@@ -1,3 +1,8 @@
 # frozen_string_literal: true
 
-require "action_interactor/base"
+$:.unshift File.dirname(__FILE__)
+
+module ActionInteractor
+  autoload :Base, "action_interactor/base"
+  autoload :Results, "action_interactor/results"
+end

data/test/base_test.rb

@@ -1,5 +1,5 @@
 require "test/unit"
-require "actioninteractor"
+require_relative "../lib/actioninteractor"
 
 class BaseTest < Test::Unit::TestCase
   test ".execute does not raise error" do

data/test/inheritance_test.rb

@@ -1,5 +1,5 @@
 require "test/unit"
-require_relative "../lib/action_interactor/base.rb"
+require_relative "../lib/actioninteractor"
 
 class User
   attr_accessor :name
@@ -12,16 +12,17 @@ end
 class RegistrationInteractor < ActionInteractor::Base
   def execute
     return fail! unless params[:name]
-    add_result(:user, User.new(name: params[:name]))
-    finish!
+    results.add(:user, User.new(name: params[:name]))
+    success!
   end
 end
 
 class NotificationInteractor < ActionInteractor::Base
   def execute
     return fail! unless params[:name] || params[:email]
-    results(name: params[:name], email: params[:email])
-    finish!
+    results.add(:name, params[:name])
+    results.add(:email, params[:email])
+    success!
   end
 end
 
@@ -41,13 +42,13 @@ class InheritanceTest < Test::Unit::TestCase
   test "the result contains a user" do
     params = { name: 'John'}
     interactor = RegistrationInteractor.execute(params)
-    assert_instance_of(User, interactor.result[:user])
+    assert_instance_of(User, interactor.results[:user])
   end
 
   test "the result user name is John" do
     params = { name: 'John'}
     interactor = RegistrationInteractor.execute(params)
-    user = interactor.result[:user]
+    user = interactor.results[:user]
     assert_equal(user.name, 'John')
   end
 
@@ -78,9 +79,9 @@ class InheritanceTest < Test::Unit::TestCase
   test "the result user name is Taro and email is taro@example.com" do
     params = { name: 'Taro', email: 'taro@example.com'}
     interactor = NotificationInteractor.execute(params)
-    name = interactor.result[:name]
+    name = interactor.results[:name]
     assert_equal(name, 'Taro')
-    email = interactor.result[:email]
+    email = interactor.results[:email]
     assert_equal(email, 'taro@example.com')
   end
 end

data/test/results_test.rb

@@ -0,0 +1,14 @@
+require "test/unit"
+require_relative "../lib/actioninteractor"
+
+class ResultsTest < Test::Unit::TestCase
+  test "initialized correctly" do
+    assert_nothing_raised { ActionInteractor::Results.new }
+  end
+
+  test "add result for the key" do
+    results = ActionInteractor::Results.new
+    results.add(:foo, "bar")
+    assert_equal(results[:foo], "bar")
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actioninteractor
 version: !ruby/object:Gem::Version
-  version: 0.0.14
+  version: 0.0.15
 platform: ruby
 authors:
 - Ryo Hashimoto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-28 00:00:00.000000000 Z
+date: 2018-12-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -48,9 +48,11 @@ files:
 - Rakefile
 - actioninteractor.gemspec
 - lib/action_interactor/base.rb
+- lib/action_interactor/results.rb
 - lib/actioninteractor.rb
 - test/base_test.rb
 - test/inheritance_test.rb
+- test/results_test.rb
 homepage: https://github.com/ryohashimoto/lightrails
 licenses:
 - MIT
@@ -79,3 +81,4 @@ summary: Action Interactor provides a simple interface for performing operations
 test_files:
 - test/base_test.rb
 - test/inheritance_test.rb
+- test/results_test.rb