actioncable 7.2.3 → 8.0.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88ac9e42c67cca041d0460a69d0c15d4ae29a219701f121f04204a70b750c038
-  data.tar.gz: 2a6d999d4e3249b3b0bc8ea7434df42de661b18b34242ab2b35c4971d0701baa
+  metadata.gz: 8fbb636a677c963849f247b80e4b42f86c89925d34e326ddb0ec53745433e7ea
+  data.tar.gz: 7dc0e29e27c83651f099d3f3c2f2561ca2e01c37f9d543c9dbf258425576eb5f
 SHA512:
-  metadata.gz: 745a91a5943da893641b66f9246657695e3ddbfb8713e1d258612d59f628d5680f86c8e069be0530cad1209d9447b7aecd2833d9ee89eefaf3d2a28084fa4a64
-  data.tar.gz: e7948ddcc1ff1a16ec75a80f4e3c3dbed53037eaac8211eb79df326136f65b15c493b3614ca9f36230548ebfa117af4323c425ac17a7d0b298b71ee2ac65312b
+  metadata.gz: 2f771d4a87f7f3a599e36ce5f4f2648d6f312e4898b34d6709fd215fd64b65fa71b3ca768ef530069926c3aee88d32b15dffc323dff1fef13c2488ef1cbca83d
+  data.tar.gz: 7778ccb1dc1f864ec5b15d138f040e687d5d6efde6acbef35e45031338b83efcafbe33eed6ae8dcc17664825c42bda692e646c1ef4036f2f14bc040acc7f9b0c

data/CHANGELOG.md

@@ -1,91 +1,7 @@
-## Rails 7.2.3 (October 28, 2025) ##
+## Rails 8.0.0.beta1 (September 26, 2024) ##
 
-*   Fixed compatibility with `redis` gem `5.4.1`
+*   Add an `identifier` to the event payload for the ActiveSupport::Notification `transmit_subscription_confirmation.action_cable` and `transmit_subscription_rejection.action_cable`.
 
-    *Jean Boussier*
+    *Keith Schacht*
 
-*   Fixed a possible race condition in `stream_from`.
-
-    *OuYangJinTing*
-
-*   Ensure the Postgresql adapter always use a dedicated connection even during system tests.
-
-    Fix an issue with the Action Cable Postgresql adapter causing deadlock or various weird
-    pg client error during system tests.
-
-    *Jean Boussier*
-
-
-## Rails 7.2.2.2 (August 13, 2025) ##
-
-*   No changes.
-
-
-## Rails 7.2.2.1 (December 10, 2024) ##
-
-*   No changes.
-
-
-## Rails 7.2.2 (October 30, 2024) ##
-
-*   No changes.
-
-
-## Rails 7.2.1.2 (October 23, 2024) ##
-
-*   No changes.
-
-
-## Rails 7.2.1.1 (October 15, 2024) ##
-
-*   No changes.
-
-
-## Rails 7.2.1 (August 22, 2024) ##
-
-*   No changes.
-
-
-## Rails 7.2.0 (August 09, 2024) ##
-
-*   Bring `ActionCable::Connection::TestCookieJar` in alignment with `ActionDispatch::Cookies::CookieJar` in regards to setting the cookie value.
-
-    Before:
-
-    ```ruby
-    cookies[:foo] = { value: "bar" }
-    puts cookies[:foo] # => { value: "bar" }
-    ```
-
-    After:
-
-    ```ruby
-    cookies[:foo] = { value: "bar" }
-    puts cookies[:foo] # => "bar"
-    ```
-
-    *Justin Ko*
-
-*   Record ping on every Action Cable message.
-
-    Previously only `ping` and `welcome` message types were keeping the connection active.
-    Now every Action Cable message updates the `pingedAt` value, preventing the connection
-    from being marked as stale.
-
-    *yauhenininjia*
-
-*   Add two new assertion methods for Action Cable test cases: `assert_has_no_stream`
-    and `assert_has_no_stream_for`.
-
-    These methods can be used to assert that a stream has been stopped, e.g. via
-    `stop_stream` or `stop_stream_for`. They complement the already existing
-    `assert_has_stream` and `assert_has_stream_for` methods.
-
-    ```ruby
-    assert_has_no_stream "messages"
-    assert_has_no_stream_for User.find(42)
-    ```
-
-    *Sebastian Pöll*, *Junichi Sato*
-
-Please check [7-1-stable](https://github.com/rails/rails/blob/7-1-stable/actioncable/CHANGELOG.md) for previous changes.
+Please check [7-2-stable](https://github.com/rails/rails/blob/7-2-stable/actioncable/CHANGELOG.md) for previous changes.

data/README.md

@@ -19,6 +19,6 @@ Bug reports for the Ruby on \Rails project can be filed here:
 
 * https://github.com/rails/rails/issues
 
-Feature requests should be discussed on the rubyonrails-core forum here:
+Feature requests should be discussed on the rails-core mailing list here:
 
 * https://discuss.rubyonrails.org/c/rubyonrails-core

data/lib/action_cable/channel/base.rb

@@ -166,7 +166,6 @@ module ActionCable
 
         @reject_subscription = nil
         @subscription_confirmation_sent = nil
-        @unsubscribed = false
 
         delegate_connection_identifiers
       end
@@ -202,16 +201,11 @@ module ActionCable
       # cleanup with callbacks. This method is not intended to be called directly by
       # the user. Instead, override the #unsubscribed callback.
       def unsubscribe_from_channel # :nodoc:
-        @unsubscribed = true
         run_callbacks :unsubscribe do
           unsubscribed
         end
       end
 
-      def unsubscribed? # :nodoc:
-        @unsubscribed
-      end
-
       private
         # Called once a consumer has become a subscriber of the channel. Usually the
         # place to set up any streams you want this channel to be sending to the
@@ -315,7 +309,7 @@ module ActionCable
           unless subscription_confirmation_sent?
             logger.debug "#{self.class.name} is transmitting the subscription confirmation"
 
-            ActiveSupport::Notifications.instrument("transmit_subscription_confirmation.action_cable", channel_class: self.class.name) do
+            ActiveSupport::Notifications.instrument("transmit_subscription_confirmation.action_cable", channel_class: self.class.name, identifier: @identifier) do
               connection.transmit identifier: @identifier, type: ActionCable::INTERNAL[:message_types][:confirmation]
               @subscription_confirmation_sent = true
             end
@@ -330,7 +324,7 @@ module ActionCable
         def transmit_subscription_rejection
           logger.debug "#{self.class.name} is transmitting the subscription rejection"
 
-          ActiveSupport::Notifications.instrument("transmit_subscription_rejection.action_cable", channel_class: self.class.name) do
+          ActiveSupport::Notifications.instrument("transmit_subscription_rejection.action_cable", channel_class: self.class.name, identifier: @identifier) do
             connection.transmit identifier: @identifier, type: ActionCable::INTERNAL[:message_types][:rejection]
           end
         end

data/lib/action_cable/channel/streams.rb

@@ -88,8 +88,6 @@ module ActionCable
       # callback. Defaults to `coder: nil` which does no decoding, passes raw
       # messages.
       def stream_from(broadcasting, callback = nil, coder: nil, &block)
-        return if unsubscribed?
-
         broadcasting = String(broadcasting)
 
         # Don't send the confirmation until pubsub#subscribe is successful

data/lib/action_cable/connection/test_case.rb

@@ -75,8 +75,11 @@ module ActionCable
     #
     # ## Basic example
     #
-    # Unit tests are written by first simulating a connection attempt by calling
-    # `connect` and then asserting state, e.g. identifiers, have been assigned.
+    # Unit tests are written as follows:
+    #
+    # 1.  Simulate a connection attempt by calling `connect`.
+    # 2.  Assert state, e.g. identifiers, has been assigned.
+    #
     #
     #     class ApplicationCable::ConnectionTest < ActionCable::Connection::TestCase
     #       def test_connects_with_proper_cookie

data/lib/action_cable/gem_version.rb

@@ -9,10 +9,10 @@ module ActionCable
   end
 
   module VERSION
-    MAJOR = 7
-    MINOR = 2
-    TINY  = 3
-    PRE   = nil
+    MAJOR = 8
+    MINOR = 0
+    TINY  = 0
+    PRE   = "beta1"
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/action_cable/remote_connections.rb

@@ -39,45 +39,44 @@ module ActionCable
       RemoteConnection.new(server, identifier)
     end
 
-    private
-      # # Action Cable Remote Connection
-      #
-      # Represents a single remote connection found via
-      # `ActionCable.server.remote_connections.where(*)`. Exists solely for the
-      # purpose of calling #disconnect on that connection.
-      class RemoteConnection
-        class InvalidIdentifiersError < StandardError; end
+    # # Action Cable Remote Connection
+    #
+    # Represents a single remote connection found via
+    # `ActionCable.server.remote_connections.where(*)`. Exists solely for the
+    # purpose of calling #disconnect on that connection.
+    class RemoteConnection
+      class InvalidIdentifiersError < StandardError; end
 
-        include Connection::Identification, Connection::InternalChannel
+      include Connection::Identification, Connection::InternalChannel
 
-        def initialize(server, ids)
-          @server = server
-          set_identifier_instance_vars(ids)
-        end
+      def initialize(server, ids)
+        @server = server
+        set_identifier_instance_vars(ids)
+      end
 
-        # Uses the internal channel to disconnect the connection.
-        def disconnect(reconnect: true)
-          server.broadcast internal_channel, { type: "disconnect", reconnect: reconnect }
-        end
+      # Uses the internal channel to disconnect the connection.
+      def disconnect(reconnect: true)
+        server.broadcast internal_channel, { type: "disconnect", reconnect: reconnect }
+      end
 
-        # Returns all the identifiers that were applied to this connection.
-        redefine_method :identifiers do
-          server.connection_identifiers
-        end
+      # Returns all the identifiers that were applied to this connection.
+      redefine_method :identifiers do
+        server.connection_identifiers
+      end
 
-        protected
-          attr_reader :server
+      protected
+        attr_reader :server
 
-        private
-          def set_identifier_instance_vars(ids)
-            raise InvalidIdentifiersError unless valid_identifiers?(ids)
-            ids.each { |k, v| instance_variable_set("@#{k}", v) }
-          end
+      private
+        def set_identifier_instance_vars(ids)
+          raise InvalidIdentifiersError unless valid_identifiers?(ids)
+          ids.each { |k, v| instance_variable_set("@#{k}", v) }
+        end
 
-          def valid_identifiers?(ids)
-            keys = ids.keys
-            identifiers.all? { |id| keys.include?(id) }
-          end
-      end
+        def valid_identifiers?(ids)
+          keys = ids.keys
+          identifiers.all? { |id| keys.include?(id) }
+        end
+    end
   end
 end

data/lib/action_cable/subscription_adapter/postgresql.rb

@@ -35,17 +35,18 @@ module ActionCable
       end
 
       def with_subscriptions_connection(&block) # :nodoc:
-        # Action Cable is taking ownership over this database connection, and will
-        # perform the necessary cleanup tasks.
-        # We purposedly avoid #checkout to not end up with a pinned connection
-        ar_conn = ActiveRecord::Base.connection_pool.new_connection
+        ar_conn = ActiveRecord::Base.connection_pool.checkout.tap do |conn|
+          # Action Cable is taking ownership over this database connection, and will
+          # perform the necessary cleanup tasks
+          ActiveRecord::Base.connection_pool.remove(conn)
+        end
         pg_conn = ar_conn.raw_connection
 
         verify!(pg_conn)
         pg_conn.exec("SET application_name = #{pg_conn.escape_identifier(identifier)}")
         yield pg_conn
       ensure
-        ar_conn&.disconnect!
+        ar_conn.disconnect!
       end
 
       def with_broadcast_connection(&block) # :nodoc:

data/lib/action_cable/subscription_adapter/redis.rb

@@ -164,7 +164,7 @@ module ActionCable
                 begin
                   conn = @adapter.redis_connection_for_subscriptions
                   listen conn
-                rescue *CONNECTION_ERRORS
+                rescue ConnectionError
                   reset
                   if retry_connecting?
                     when_connected { resubscribe }
@@ -210,7 +210,7 @@ module ActionCable
             end
 
             if ::Redis::VERSION < "5"
-              CONNECTION_ERRORS = [::Redis::BaseConnectionError].freeze
+              ConnectionError = ::Redis::BaseConnectionError
 
               class SubscribedClient
                 def initialize(raw_client)
@@ -244,12 +244,7 @@ module ActionCable
                 SubscribedClient.new(conn._client)
               end
             else
-              CONNECTION_ERRORS = [
-                ::Redis::BaseConnectionError,
-
-                # Some older versions of redis-rb sometime leak underlying exceptions
-                RedisClient::ConnectionError,
-              ].freeze
+              ConnectionError = RedisClient::ConnectionError
 
               def extract_subscribed_client(conn)
                 conn

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: actioncable
 version: !ruby/object:Gem::Version
-  version: 7.2.3
+  version: 8.0.0.beta1
 platform: ruby
 authors:
 - Pratik Naik
 - David Heinemeier Hansson
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2024-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,28 +17,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.3
+        version: 8.0.0.beta1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.3
+        version: 8.0.0.beta1
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.3
+        version: 8.0.0.beta1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.3
+        version: 8.0.0.beta1
 - !ruby/object:Gem::Dependency
   name: nio4r
   requirement: !ruby/object:Gem::Requirement
@@ -153,11 +154,12 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v7.2.3/actioncable/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v7.2.3/
+  changelog_uri: https://github.com/rails/rails/blob/v8.0.0.beta1/actioncable/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v8.0.0.beta1/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v7.2.3/actioncable
+  source_code_uri: https://github.com/rails/rails/tree/v8.0.0.beta1/actioncable
   rubygems_mfa_required: 'true'
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -165,14 +167,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.1.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.5.16
+signing_key: 
 specification_version: 4
 summary: WebSocket framework for Rails.
 test_files: []