actioncable 7.2.2.2 → 8.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4b6b3db81be2ea4adf501baee068a3509f4bb3235e06f7be46e1579349114353
-  data.tar.gz: 3e1664cbaa02a478eb83edfe2b78f26acf5ba994fb21de5c9668feea4d61a749
+  metadata.gz: b5950ddf79b0417b9d031167d623e0ab30fdf9055847e31113e9c38cdd5f41ee
+  data.tar.gz: 1036c6f9afa0cef78179675a8a8c5e49074079364bde0fb71662fd8f31ec5ed8
 SHA512:
-  metadata.gz: d475935921662a40739b99f3cc495ea229b306190c214f63841ebf43f7c01225973b1bfa707f0b08f2a66c242a60a459841aeb665ef5aa4cca8daf1120563716
-  data.tar.gz: f188340811f4356a67766020fc78fa9e7e74a656c2cfecd18ae17a270dbadd1780a4bb185570df5f7d56ccb5712b9230f1948e19d256128668a62fc7b16804f6
+  metadata.gz: 4800620d87efb612cef53a992510aca7be81079f9a093f267fdf8b1ac03323103d465a3925de5524a7bf2cadb0ada6545f40f44d52d5f01c5696b9db97c99bb3
+  data.tar.gz: 86d543ad0837fa3fa617fddab3d34eb627e2443977c1249ecc02c5dbe8942b29af72481ca17089964b6194b0047c41f4e04a85bba8354aa2f78fe92c37592523

data/CHANGELOG.md

@@ -1,73 +1,58 @@
-## Rails 7.2.2.2 (August 13, 2025) ##
+## Rails 8.0.3 (September 22, 2025) ##
 
-*   No changes.
+*   Fixed compatibility with `redis` gem `5.4.1`
 
+    *Jean Boussier*
 
-## Rails 7.2.2.1 (December 10, 2024) ##
+*   Fixed a possible race condition in `stream_from`.
 
-*   No changes.
+    *OuYangJinTing*
 
 
-## Rails 7.2.2 (October 30, 2024) ##
+## Rails 8.0.2.1 (August 13, 2025) ##
 
 *   No changes.
 
 
-## Rails 7.2.1.2 (October 23, 2024) ##
+## Rails 8.0.2 (March 12, 2025) ##
 
 *   No changes.
 
 
-## Rails 7.2.1.1 (October 15, 2024) ##
+## Rails 8.0.1 (December 13, 2024) ##
 
-*   No changes.
+*   Ensure the Postgresql adapter always use a dedicated connection even during system tests.
 
+    Fix an issue with the Action Cable Postgresql adapter causing deadlock or various weird
+    pg client error during system tests.
 
-## Rails 7.2.1 (August 22, 2024) ##
+    *Jean Boussier*
 
-*   No changes.
 
+## Rails 8.0.0.1 (December 10, 2024) ##
 
-## Rails 7.2.0 (August 09, 2024) ##
+*   No changes.
 
-*   Bring `ActionCable::Connection::TestCookieJar` in alignment with `ActionDispatch::Cookies::CookieJar` in regards to setting the cookie value.
 
-    Before:
+## Rails 8.0.0 (November 07, 2024) ##
 
-    ```ruby
-    cookies[:foo] = { value: "bar" }
-    puts cookies[:foo] # => { value: "bar" }
-    ```
+*   No changes.
 
-    After:
 
-    ```ruby
-    cookies[:foo] = { value: "bar" }
-    puts cookies[:foo] # => "bar"
-    ```
+## Rails 8.0.0.rc2 (October 30, 2024) ##
 
-    *Justin Ko*
+*   No changes.
 
-*   Record ping on every Action Cable message.
 
-    Previously only `ping` and `welcome` message types were keeping the connection active.
-    Now every Action Cable message updates the `pingedAt` value, preventing the connection
-    from being marked as stale.
+## Rails 8.0.0.rc1 (October 19, 2024) ##
 
-    *yauhenininjia*
+*   No changes.
 
-*   Add two new assertion methods for Action Cable test cases: `assert_has_no_stream`
-    and `assert_has_no_stream_for`.
 
-    These methods can be used to assert that a stream has been stopped, e.g. via
-    `stop_stream` or `stop_stream_for`. They complement the already existing
-    `assert_has_stream` and `assert_has_stream_for` methods.
+## Rails 8.0.0.beta1 (September 26, 2024) ##
 
-    ```ruby
-    assert_has_no_stream "messages"
-    assert_has_no_stream_for User.find(42)
-    ```
+*   Add an `identifier` to the event payload for the ActiveSupport::Notification `transmit_subscription_confirmation.action_cable` and `transmit_subscription_rejection.action_cable`.
 
-    *Sebastian Pöll*, *Junichi Sato*
+    *Keith Schacht*
 
-Please check [7-1-stable](https://github.com/rails/rails/blob/7-1-stable/actioncable/CHANGELOG.md) for previous changes.
+Please check [7-2-stable](https://github.com/rails/rails/blob/7-2-stable/actioncable/CHANGELOG.md) for previous changes.

data/README.md

@@ -19,6 +19,6 @@ Bug reports for the Ruby on \Rails project can be filed here:
 
 * https://github.com/rails/rails/issues
 
-Feature requests should be discussed on the rails-core mailing list here:
+Feature requests should be discussed on the rubyonrails-core forum here:
 
 * https://discuss.rubyonrails.org/c/rubyonrails-core

data/lib/action_cable/channel/base.rb

@@ -2,7 +2,6 @@
 
 # :markup: markdown
 
-require "set"
 require "active_support/rescuable"
 require "active_support/parameter_filter"
 
@@ -166,6 +165,7 @@ module ActionCable
 
         @reject_subscription = nil
         @subscription_confirmation_sent = nil
+        @unsubscribed = false
 
         delegate_connection_identifiers
       end
@@ -201,11 +201,16 @@ module ActionCable
       # cleanup with callbacks. This method is not intended to be called directly by
       # the user. Instead, override the #unsubscribed callback.
       def unsubscribe_from_channel # :nodoc:
+        @unsubscribed = true
         run_callbacks :unsubscribe do
           unsubscribed
         end
       end
 
+      def unsubscribed? # :nodoc:
+        @unsubscribed
+      end
+
       private
         # Called once a consumer has become a subscriber of the channel. Usually the
         # place to set up any streams you want this channel to be sending to the
@@ -309,7 +314,7 @@ module ActionCable
           unless subscription_confirmation_sent?
             logger.debug "#{self.class.name} is transmitting the subscription confirmation"
 
-            ActiveSupport::Notifications.instrument("transmit_subscription_confirmation.action_cable", channel_class: self.class.name) do
+            ActiveSupport::Notifications.instrument("transmit_subscription_confirmation.action_cable", channel_class: self.class.name, identifier: @identifier) do
               connection.transmit identifier: @identifier, type: ActionCable::INTERNAL[:message_types][:confirmation]
               @subscription_confirmation_sent = true
             end
@@ -324,7 +329,7 @@ module ActionCable
         def transmit_subscription_rejection
           logger.debug "#{self.class.name} is transmitting the subscription rejection"
 
-          ActiveSupport::Notifications.instrument("transmit_subscription_rejection.action_cable", channel_class: self.class.name) do
+          ActiveSupport::Notifications.instrument("transmit_subscription_rejection.action_cable", channel_class: self.class.name, identifier: @identifier) do
             connection.transmit identifier: @identifier, type: ActionCable::INTERNAL[:message_types][:rejection]
           end
         end

data/lib/action_cable/channel/streams.rb

@@ -88,6 +88,8 @@ module ActionCable
       # callback. Defaults to `coder: nil` which does no decoding, passes raw
       # messages.
       def stream_from(broadcasting, callback = nil, coder: nil, &block)
+        return if unsubscribed?
+
         broadcasting = String(broadcasting)
 
         # Don't send the confirmation until pubsub#subscribe is successful

data/lib/action_cable/connection/identification.rb

@@ -2,8 +2,6 @@
 
 # :markup: markdown
 
-require "set"
-
 module ActionCable
   module Connection
     module Identification

data/lib/action_cable/connection/test_case.rb

@@ -75,11 +75,8 @@ module ActionCable
     #
     # ## Basic example
     #
-    # Unit tests are written as follows:
-    #
-    # 1.  Simulate a connection attempt by calling `connect`.
-    # 2.  Assert state, e.g. identifiers, has been assigned.
-    #
+    # Unit tests are written by first simulating a connection attempt by calling
+    # `connect` and then asserting state, e.g. identifiers, have been assigned.
     #
     #     class ApplicationCable::ConnectionTest < ActionCable::Connection::TestCase
     #       def test_connects_with_proper_cookie

data/lib/action_cable/gem_version.rb

@@ -9,10 +9,10 @@ module ActionCable
   end
 
   module VERSION
-    MAJOR = 7
-    MINOR = 2
-    TINY  = 2
-    PRE   = "2"
+    MAJOR = 8
+    MINOR = 0
+    TINY  = 3
+    PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/action_cable/remote_connections.rb

@@ -39,45 +39,44 @@ module ActionCable
       RemoteConnection.new(server, identifier)
     end
 
-    private
-      # # Action Cable Remote Connection
-      #
-      # Represents a single remote connection found via
-      # `ActionCable.server.remote_connections.where(*)`. Exists solely for the
-      # purpose of calling #disconnect on that connection.
-      class RemoteConnection
-        class InvalidIdentifiersError < StandardError; end
+    # # Action Cable Remote Connection
+    #
+    # Represents a single remote connection found via
+    # `ActionCable.server.remote_connections.where(*)`. Exists solely for the
+    # purpose of calling #disconnect on that connection.
+    class RemoteConnection
+      class InvalidIdentifiersError < StandardError; end
 
-        include Connection::Identification, Connection::InternalChannel
+      include Connection::Identification, Connection::InternalChannel
 
-        def initialize(server, ids)
-          @server = server
-          set_identifier_instance_vars(ids)
-        end
+      def initialize(server, ids)
+        @server = server
+        set_identifier_instance_vars(ids)
+      end
 
-        # Uses the internal channel to disconnect the connection.
-        def disconnect(reconnect: true)
-          server.broadcast internal_channel, { type: "disconnect", reconnect: reconnect }
-        end
+      # Uses the internal channel to disconnect the connection.
+      def disconnect(reconnect: true)
+        server.broadcast internal_channel, { type: "disconnect", reconnect: reconnect }
+      end
 
-        # Returns all the identifiers that were applied to this connection.
-        redefine_method :identifiers do
-          server.connection_identifiers
-        end
+      # Returns all the identifiers that were applied to this connection.
+      redefine_method :identifiers do
+        server.connection_identifiers
+      end
 
-        protected
-          attr_reader :server
+      protected
+        attr_reader :server
 
-        private
-          def set_identifier_instance_vars(ids)
-            raise InvalidIdentifiersError unless valid_identifiers?(ids)
-            ids.each { |k, v| instance_variable_set("@#{k}", v) }
-          end
+      private
+        def set_identifier_instance_vars(ids)
+          raise InvalidIdentifiersError unless valid_identifiers?(ids)
+          ids.each { |k, v| instance_variable_set("@#{k}", v) }
+        end
 
-          def valid_identifiers?(ids)
-            keys = ids.keys
-            identifiers.all? { |id| keys.include?(id) }
-          end
-      end
+        def valid_identifiers?(ids)
+          keys = ids.keys
+          identifiers.all? { |id| keys.include?(id) }
+        end
+    end
   end
 end

data/lib/action_cable/subscription_adapter/postgresql.rb

@@ -35,18 +35,17 @@ module ActionCable
       end
 
       def with_subscriptions_connection(&block) # :nodoc:
-        ar_conn = ActiveRecord::Base.connection_pool.checkout.tap do |conn|
-          # Action Cable is taking ownership over this database connection, and will
-          # perform the necessary cleanup tasks
-          ActiveRecord::Base.connection_pool.remove(conn)
-        end
+        # Action Cable is taking ownership over this database connection, and will
+        # perform the necessary cleanup tasks.
+        # We purposedly avoid #checkout to not end up with a pinned connection
+        ar_conn = ActiveRecord::Base.connection_pool.new_connection
         pg_conn = ar_conn.raw_connection
 
         verify!(pg_conn)
         pg_conn.exec("SET application_name = #{pg_conn.escape_identifier(identifier)}")
         yield pg_conn
       ensure
-        ar_conn.disconnect!
+        ar_conn&.disconnect!
       end
 
       def with_broadcast_connection(&block) # :nodoc:

data/lib/action_cable/subscription_adapter/redis.rb

@@ -164,7 +164,7 @@ module ActionCable
                 begin
                   conn = @adapter.redis_connection_for_subscriptions
                   listen conn
-                rescue ConnectionError
+                rescue *CONNECTION_ERRORS
                   reset
                   if retry_connecting?
                     when_connected { resubscribe }
@@ -210,7 +210,7 @@ module ActionCable
             end
 
             if ::Redis::VERSION < "5"
-              ConnectionError = ::Redis::BaseConnectionError
+              CONNECTION_ERRORS = [::Redis::BaseConnectionError].freeze
 
               class SubscribedClient
                 def initialize(raw_client)
@@ -244,7 +244,12 @@ module ActionCable
                 SubscribedClient.new(conn._client)
               end
             else
-              ConnectionError = RedisClient::ConnectionError
+              CONNECTION_ERRORS = [
+                ::Redis::BaseConnectionError,
+
+                # Some older versions of redis-rb sometime leak underlying exceptions
+                RedisClient::ConnectionError,
+              ].freeze
 
               def extract_subscribed_client(conn)
                 conn

data/lib/rails/generators/channel/channel_generator.rb

@@ -105,7 +105,7 @@ pin_all_from "app/javascript/channels", under: "channels"
         end
 
         def using_bun?
-          # Cannot assume bun.lockb has been generated yet so we look for a file known to
+          # Cannot assume Bun lockfile has been generated yet so we look for a file known to
           # be generated by the jsbundling-rails gem
           @using_bun ||= using_js_runtime? && root.join("bun.config.js").exist?
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: actioncable
 version: !ruby/object:Gem::Version
-  version: 7.2.2.2
+  version: 8.0.3
 platform: ruby
 authors:
 - Pratik Naik
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.2.2
+        version: 8.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.2.2
+        version: 8.0.3
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.2.2
+        version: 8.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.2.2
+        version: 8.0.3
 - !ruby/object:Gem::Dependency
   name: nio4r
   requirement: !ruby/object:Gem::Requirement
@@ -153,10 +153,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v7.2.2.2/actioncable/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v7.2.2.2/
+  changelog_uri: https://github.com/rails/rails/blob/v8.0.3/actioncable/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v8.0.3/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v7.2.2.2/actioncable
+  source_code_uri: https://github.com/rails/rails/tree/v8.0.3/actioncable
   rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
@@ -165,7 +165,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.1.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="