actioncable-next 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a2a646309358247e05b84be4246c044bfae6f289eab7776e5821d6c54e8b1f00
-  data.tar.gz: d2ec2b1f743af72cdc61a8be7c41e80778cff79d9335baa059fbd791272cf07a
+  metadata.gz: b86ee72b0095c7a8ce99b0d354231b2ac29145e07a1482387fa9664f1c9a08b8
+  data.tar.gz: e72beed883e8789189fa6811d6fb70cdc4e9efbec2ad9b259648c8575196aca3
 SHA512:
-  metadata.gz: 8ff34021af6ec2c0e69676ba92fb64f2f1c9a9141db355eaa1f16fc7e9e7f3e4689b79efd86ebada9fd698e9b76bf95a214969198feb0c4334bbebb86a0597ec
-  data.tar.gz: aed1822bc56226c76a02f6d9a95f3bc915fe429d3345bd3dbbc964ef6e384337347ed0496427b609788846951409042accb001ca157519f746997d512665b0d3
+  metadata.gz: 955b568fb0d4e01d81ad6871292515c1a3d742eef03067c6322d68b7c6908eeac12947aaef91cb9d4fcbccf2e3790ff84c797ad30e462db15179b04ee6a2d8a3
+  data.tar.gz: 3cc6151d155e3719b008bad22ecf4fbf0a401a5858a7ef5bd75a941debca5b26ac9d06cb30d781929d6da10399c9f534d06aed6ac7afd2ea7a96490066dc6891

data/CHANGELOG.md

@@ -2,4 +2,14 @@
 
 ## main
 
+## 0.1.2
+
+- Added a hack to prevent third-party extensions from changing the methods visibility.
+
+## 0.1.1
+
+- Added RSpec patch.
+
+## 0.1.0
+
 - Initial extraction.

data/README.md

@@ -15,3 +15,14 @@ gem "rails", "~> 7.0"
 ```
 
 Then, you can use Action Cable as before. Under the hood, the new implementation would be used.
+
+### RSpec support
+
+This gem also includes the corresponding patch for RSpec Rails (see [PR](https://github.com/palkan/rspec-rails/pull/1)). You MUST activate it explicitly
+by adding the following line to your `spec/rails_helper.rb`:
+
+```ruby
+# after rspec-rails is loaded
+require "rspec/rails"
+require "action_cable/next/rspec"
+```

data/lib/action_cable/connection/base.rb

@@ -162,4 +162,15 @@ module ActionCable
   end
 end
 
+# Hack to make sure legacy extensions do not changes the visibility of API methods
+# (see https://github.com/anycable/actioncable-next/issues/7)
+# We call it from the engine after application initialization.
+class << ActionCable::Connection::Base
+  def __restore_visibility__
+    %i[handle_open handle_close handle_channel_command transmit close].each do |method|
+      instance_method(method).owner.send(:public, method)
+    end
+  end
+end
+
 ActiveSupport.run_load_hooks(:action_cable_connection, ActionCable::Connection::Base)

data/lib/action_cable/engine.rb

@@ -94,5 +94,11 @@ module ActionCable
         end
       end
     end
+
+    config.after_initialize do
+      ActiveSupport.on_load(:action_cable_connection) do
+        ActionCable::Connection::Base.__restore_visibility__
+      end
+    end
   end
 end

data/lib/action_cable/next/rspec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+# RSpec patches from https://github.com/palkan/rspec-rails/pull/1
+
+require "rspec/rails/example/channel_example_group"
+
+if defined?(RSpec::Rails::ChannelExampleGroup)
+  RSpec::Rails::ChannelExampleGroup.prepend(Module.new do
+    def connection_class
+      (_connection_class || described_class).then do |klass|
+        # Connection class either specified explicitly or is a described class
+        next klass if klass && klass <= ::ActionCable::Connection::Base
+
+        # Otherwise, fallback to the default connection class
+        tests_connection ::ActionCable.server.config.connection_class.call
+
+        _connection_class
+      end
+    end
+  end)
+end
+
+RSpec::Rails::Matchers::ActionCable::HaveStream.prepend(Module.new do
+  def match(subscription)
+    case subscription
+    when ::ActionCable::Channel::Base
+      @actual = streams_for(subscription)
+      no_expected? ? actual.any? : actual.any? { |i| expected === i }
+    else
+      raise ArgumentError, "have_stream, have_stream_from and have_stream_from support expectations on subscription only"
+    end
+  end
+
+  private
+    def streams_for(subscription)
+      # In Rails 8, subscription.streams returns a real subscriptions hash,
+      # not a fake array of stream names like in Rails 6-7.
+      # So, we must use #stream_names instead.
+      subscription.respond_to?(:stream_names) ? subscription.stream_names : subscription.streams
+    end
+end)

data/lib/action_cable.rb

@@ -39,6 +39,7 @@ Zeitwerk::Loader.for_gem.tap do |loader|
     "#{lib}/action_cable/version.rb",
     "#{lib}/action_cable/deprecator.rb",
     "#{lib}/actioncable-next.rb",
+    "#{lib}/action_cable/next",
   )
 
   loader.do_not_eager_load(

data/lib/actioncable-next.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActionCableNext
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: actioncable-next
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Pratik Naik
 - David Heinemeier Hansson
 - Vladimir Dementyev
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-09-30 00:00:00.000000000 Z
+date: 2025-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -125,6 +125,7 @@ files:
 - lib/action_cable/engine.rb
 - lib/action_cable/gem_version.rb
 - lib/action_cable/helpers/action_cable_helper.rb
+- lib/action_cable/next/rspec.rb
 - lib/action_cable/remote_connections.rb
 - lib/action_cable/server/base.rb
 - lib/action_cable/server/broadcasting.rb
@@ -166,10 +167,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/anycable/actioncable-next
-  changelog_uri: https://github.com/anycable/actioncable-next/blob/v0.1.0/CHANGELOG.md
+  changelog_uri: https://github.com/anycable/actioncable-next/blob/v0.1.2/CHANGELOG.md
   source_code_uri: https://github.com/anycable/actioncable-next
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -184,8 +185,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.18
-signing_key:
+rubygems_version: 3.5.22
+signing_key: 
 specification_version: 4
 summary: Next-gen version of Action Cable
 test_files: []