actionagent 1.9.0 → 1.9.1

data/app/controllers/action_agent/api/feedback_ingest_controller.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module ActionAgent
+  module Api
+    # Server-to-server submission; end-user apps authenticate their own users
+    # and proxy feedback rather than exposing the ingest key in a browser.
+    class FeedbackIngestController < ActionController::API
+      include IngestAuthentication
+
+      def create
+        envelope = params.require(:feedback)
+        raise ActionController::ParameterMissing, :feedback unless envelope.is_a?(ActionController::Parameters)
+
+        input = envelope.permit(:trace_id, :feedback_id, :rating, :comment, :span_id, :user_reference)
+        trace = ActionAgent.trace_model.for_account(@account).find_by!(trace_id: input.delete(:trace_id))
+        record = nil
+        # Serialize concurrent changes and use the unique index for first-write
+        # races. Reusing an ID deliberately replaces the prior rating/comment.
+        trace.with_lock do
+          record = InteractionFeedback.find_or_initialize_by(
+            telemetry_trace_id: trace.id, feedback_id: input[:feedback_id])
+          record.update!(input)
+        end
+        render json: { feedback: record.as_json }, status: :ok
+      rescue ActiveRecord::RecordNotFound
+        render json: { error: "Trace not found; retry after trace ingestion completes" }, status: :not_found
+      rescue ActiveRecord::RecordInvalid => e
+        render json: { error: e.record.errors.full_messages }, status: :unprocessable_entity
+      rescue ActionController::ParameterMissing => e
+        render json: { error: e.message }, status: :bad_request
+      end
+    end
+  end
+end

data/app/controllers/action_agent/api/feedbacks_controller.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module ActionAgent
+  module Api
+    class FeedbacksController < BaseController
+      before_action :require_owner!
+
+      def index
+        traces = owned_traces
+        traces = owner_agents.find(params[:agent_id]).telemetry_traces(traces) if params[:agent_id].present?
+        scope = InteractionFeedback.where(telemetry_trace_id: traces.select(:id))
+        if params[:rating].present?
+          return render(json: { error: "Invalid rating" }, status: :bad_request) unless %w[positive negative].include?(params[:rating])
+          scope = scope.where(rating: params[:rating])
+        end
+        scope = scope.where("created_at >= ?", date_start(params[:from])) if params[:from].present?
+        scope = scope.where("created_at < ?", date_start(params[:to]) + 1.day) if params[:to].present?
+        counts = scope.group(:rating).count
+        total = counts.values.sum
+        page = clamped_param(:page, default: 1, min: 1, max: 100_000)
+        rows = scope.order(created_at: :desc, id: :desc).offset((page - 1) * 50).limit(50)
+        trace_ids = ActionAgent.trace_model.where(id: rows.map(&:telemetry_trace_id)).pluck(:id, :trace_id).to_h
+        render json: {
+          feedback: rows.map { |row| row.as_json.merge("trace_id" => trace_ids[row.telemetry_trace_id]) },
+          page: page, total: total, positive: counts.fetch("positive", 0), negative: counts.fetch("negative", 0),
+          positive_percentage: total.zero? ? nil : (100.0 * counts.fetch("positive", 0) / total).round(1)
+        }
+      rescue Date::Error
+        render json: { error: "Dates must use YYYY-MM-DD" }, status: :bad_request
+      end
+
+      private
+
+      def date_start(value)
+        date = Date.iso8601(value.to_s)
+        Time.zone.local(date.year, date.month, date.day)
+      end
+    end
+  end
+end

data/app/models/action_agent/interaction_feedback.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module ActionAgent
+  # Feedback is attached to a trace primary key, so tenant ownership follows
+  # the trace even when two tenants report the same external trace_id.
+  class InteractionFeedback < ApplicationRecord
+    belongs_to :telemetry_trace, class_name: "ActionAgent::TelemetryTrace"
+    validates :feedback_id, presence: true, length: { maximum: 128 }, uniqueness: { scope: :telemetry_trace_id }
+    validates :rating, inclusion: { in: %w[positive negative] }
+    validates :comment, length: { maximum: 5000 }
+    validates :span_id, length: { maximum: 128 }
+    validates :user_reference, length: { maximum: 255 }
+    validate :span_belongs_to_trace
+
+    private
+
+    def span_belongs_to_trace
+      return if span_id.blank? || telemetry_trace.nil?
+      return if Array(telemetry_trace.spans).any? { |span| span["span_id"] == span_id }
+
+      errors.add(:span_id, "must belong to the trace")
+    end
+  end
+end

data/config/routes.rb

@@ -32,6 +32,9 @@ ActionAgent::Engine.routes.draw do
     # Authenticated like trace ingest, with a bearer token.
     resources :evaluation_reports, only: [ :create ]
 
+    post "feedback", to: "feedback_ingest#create"
+    get "feedback", to: "feedbacks#index"
+
     # A JSON API has no :new or :edit forms to serve.
     resources :agents, except: [ :new, :edit ] do
       member do

data/lib/action_agent/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActionAgent
-  VERSION = "1.9.0"
+  VERSION = "1.9.1"
 end

data/lib/generators/action_agent/templates/migrations/027_create_active_agent_interaction_feedbacks.rb.erb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class CreateActiveAgentInteractionFeedbacks < ActiveRecord::Migration<%= migration_version %>
+  def change
+    create_table "#{ActionAgent.table_name_prefix}interaction_feedbacks" do |t|
+      t.references :telemetry_trace, null: false, foreign_key: { to_table: :active_agent_telemetry_traces, on_delete: :cascade }
+      t.string :feedback_id, null: false, limit: 128
+      t.string :rating, null: false, limit: 16
+      t.string :span_id, limit: 128
+      t.string :user_reference, limit: 255
+      t.text :comment
+      t.timestamps
+    end
+    add_index "#{ActionAgent.table_name_prefix}interaction_feedbacks",
+      [ :telemetry_trace_id, :feedback_id ], unique: true, name: "index_feedback_on_trace_and_feedback_id"
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actionagent
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 1.9.1
 platform: ruby
 authors:
 - Justin Bowen
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-10-15 00:00:00.000000000 Z
+date: 2026-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeagent
@@ -139,6 +139,8 @@ files:
 - app/controllers/action_agent/api/evaluation_reports_controller.rb
 - app/controllers/action_agent/api/evaluations_controller.rb
 - app/controllers/action_agent/api/explorations_controller.rb
+- app/controllers/action_agent/api/feedback_ingest_controller.rb
+- app/controllers/action_agent/api/feedbacks_controller.rb
 - app/controllers/action_agent/api/github_app_manifests_controller.rb
 - app/controllers/action_agent/api/github_connections_controller.rb
 - app/controllers/action_agent/api/github_installations_controller.rb
@@ -221,6 +223,7 @@ files:
 - app/models/action_agent/github_connection.rb
 - app/models/action_agent/github_installation.rb
 - app/models/action_agent/input_request.rb
+- app/models/action_agent/interaction_feedback.rb
 - app/models/action_agent/model_pricing.rb
 - app/models/action_agent/project.rb
 - app/models/action_agent/project_secret.rb
@@ -354,6 +357,7 @@ files:
 - lib/generators/action_agent/templates/migrations/024_add_kind_to_active_agent_project_secrets.rb.erb
 - lib/generators/action_agent/templates/migrations/025_create_active_agent_scenario_catalogs.rb.erb
 - lib/generators/action_agent/templates/migrations/026_add_evaluation_fixes_to_code_sessions.rb.erb
+- lib/generators/action_agent/templates/migrations/027_create_active_agent_interaction_feedbacks.rb.erb
 - lib/tasks/action_agent.rake
 - lib/tasks/browser.rake
 - lib/tasks/claude_code.rake