action_subscriber 5.1.0 → 5.1.1.pre0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4bbf1e3c0aa19fb12f357040d47534b4fb604512
-  data.tar.gz: 9564197baef37f53f422bb872b166efe7464f518
+  metadata.gz: a8cc908c265f2f8b2ae3ae18054c8cb44285c3a8
+  data.tar.gz: 866a49421a1e0124206c547094a7766d12478afb
 SHA512:
-  metadata.gz: e21e9bf51ce42e23203327f26ccf3d2b4aac06e3467f42e0c3047ae59cb7aba1c46334b48bb7f110090735181f827b2604e77e1ae09fd74ac91f5f64614ad2d9
-  data.tar.gz: 5db5241310a2c995e7bc2e248a2dbd8bc116c5e33d51f7b6fd4f18cb89a6dfa8eba1cdfa9216cb71840283fc3d70ac141d05ecb172c6e2e5eb6c1794eb09155a
+  metadata.gz: 7dd674665092e3a9a65716056bc7fd87892fbd56a69e9a1083cc5e79e9ccd71ecf193d527c2d861a9aa2c65b01e5586f7608bd3c067786131daf67ec65cf8724
+  data.tar.gz: f1cd31b1d875aab7cbb3fe5f385b187f9847ea0ec595fc6e52c3ee0d1cfeb5064c423fd7f62e132fb18bf39912a6e41749ffe51c878a4a95772d516f537f1988

data/lib/action_subscriber/middleware/env.rb

@@ -46,14 +46,21 @@ module ActionSubscriber
 
       def acknowledge
         fail ::RuntimeError, "you can't acknowledge messages under the polling API" unless @channel
+        return true if @has_been_acked
         acknowledge_multiple_messages = false
         @has_been_acked = true
         @channel.ack(@delivery_tag, acknowledge_multiple_messages)
         true
       end
 
+      def channel_open?
+        return false unless @channel
+        @channel.open?
+      end
+
       def nack
         fail ::RuntimeError, "you can't acknowledge messages under the polling API" unless @channel
+        return true if @has_been_nacked
         nack_multiple_messages = false
         requeue_message = true
         @has_been_nacked = true
@@ -63,6 +70,7 @@ module ActionSubscriber
 
       def reject
         fail ::RuntimeError, "you can't acknowledge messages under the polling API" unless @channel
+        return true if @has_been_rejected
         requeue_message = true
         @has_been_rejected = true
         @channel.reject(@delivery_tag, requeue_message)
@@ -70,15 +78,15 @@ module ActionSubscriber
       end
 
       def safe_acknowledge
-        acknowledge if uses_acknowledgements? && @channel && !has_used_delivery_tag?
+        acknowledge if uses_acknowledgements? && channel_open? && !has_used_delivery_tag?
       end
 
       def safe_nack
-        nack if uses_acknowledgements? && @channel && !has_used_delivery_tag?
+        nack if uses_acknowledgements? && channel_open? && !has_used_delivery_tag?
       end
 
       def safe_reject
-        reject if uses_acknowledgements? && @channel && !has_used_delivery_tag?
+        reject if uses_acknowledgements? && channel_open? && !has_used_delivery_tag?
       end
 
       def to_hash

data/lib/action_subscriber/middleware/error_handler.rb

@@ -22,7 +22,14 @@ module ActionSubscriber
           logger.error { "ActionSubscriber error handler raised error, but should never raise. Error: #{inner_error}" }
         end
       ensure
-        env.safe_nack # Make sure we attempt to `nack` a message that did not get processed if something fails
+        # This second rescue is a little extreme, but we need to be very cautious here to avoid errors
+        # being sent back to bunny or march_hare land.
+        begin
+          # Make sure we attempt to `nack` a message that did not get processed if something fails
+          env.safe_nack
+        rescue Exception => inner_error
+          logger.error { "ActionSubscriber error handler raised error while nack-ing message. Error: #{inner_error}" }
+        end
       end
     end
   end

data/lib/action_subscriber/rspec.rb

@@ -3,10 +3,18 @@ require 'rspec/core'
 module ActionSubscriber
   module RSpec
     class FakeChannel # A class that quacks like a RabbitMQ Channel
+      def initialize(opts = {})
+        @open = opts.fetch(:open, true)
+      end
+
       def ack(delivery_tag, acknowledge_multiple)
         true
       end
 
+      def open?
+        @open
+      end
+
       def nack(delivery_tag, acknowledge_multiple, requeue_message)
         true
       end
@@ -76,9 +84,10 @@ end
   shared_context 'action subscriber middleware env' do
     let(:app) { Proc.new { |inner_env| inner_env } }
     let(:env) { ActionSubscriber::Middleware::Env.new(UserSubscriber, 'encoded payload', message_properties) }
+    let(:channel) { ::ActionSubscriber::RSpec::FakeChannel.new }
     let(:message_properties) {{
       :action => :created,
-      :channel => ::ActionSubscriber::RSpec::FakeChannel.new,
+      :channel => channel,
       :content_type => "text/plain",
       :delivery_tag => "XYZ",
       :exchange => "events",

data/lib/action_subscriber/version.rb

@@ -1,3 +1,3 @@
 module ActionSubscriber
-  VERSION = "5.1.0"
+  VERSION = "5.1.1.pre0"
 end

data/spec/lib/action_subscriber/middleware/error_handler_spec.rb

@@ -9,6 +9,26 @@ describe ActionSubscriber::Middleware::ErrorHandler do
 
   let(:load_error) { ::LoadError.new("Boom!") }
   let(:runtime_error) { ::RuntimeError.new("Boom!") }
+  let(:message_properties) {{
+    :action => :created,
+    :channel => channel,
+    :content_type => "text/plain",
+    :delivery_tag => "XYZ",
+    :exchange => "events",
+    :headers => {},
+    :message_id => "MSG-123",
+    :routing_key => "amigo.user.created",
+    :queue => "test.amigo.user.created",
+    :uses_acknowledgements => true,
+  }}
+
+  it "calls safe_nack after successful execution" do
+    expect(env).to receive(:safe_nack).and_call_original
+    expect(env).to_not receive(:nack)
+
+    env.acknowledge
+    subject.call(env)
+  end
 
   context "when an exception occurs" do
     context "LoadError" do
@@ -23,18 +43,31 @@ describe ActionSubscriber::Middleware::ErrorHandler do
 
     context "RuntimError" do
       before { allow(app).to receive(:call).and_raise(runtime_error) }
+
       it "calls the exception handler with a RuntimeError" do
         handler = ::ActionSubscriber.configuration.error_handler
         expect(handler).to receive(:call).with(runtime_error, env.to_h)
 
         subject.call(env)
       end
-    end
 
-    it "calls safe_nack after execution" do
-      expect(env).to receive(:safe_nack)
+      it "calls safe_nack after execution" do
+        expect(env).to receive(:safe_nack).and_call_original
+        expect(env).to receive(:nack)
 
-      subject.call(env)
+        subject.call(env)
+      end
+
+      context "when the channel is closed without an ack" do
+        let(:channel) { ::ActionSubscriber::RSpec::FakeChannel.new(:open => false) }
+
+        it "calls safe_nack after execution" do
+          expect(env).to receive(:safe_nack).and_call_original
+          expect(env).to_not receive(:nack)
+
+          subject.call(env)
+        end
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: action_subscriber
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.1.1.pre0
 platform: ruby
 authors:
 - Brian Stien
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-26 00:00:00.000000000 Z
+date: 2018-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -292,12 +292,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: ActionSubscriber is a DSL that allows a rails app to consume messages from