action_subscriber 4.1.1 → 4.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ccc5f172b9d43f029ee19e805938749fab60ec6c
-  data.tar.gz: 7bfd593e871b37ef0fb4b5c8df37afa6878b8aff
+  metadata.gz: c531b1ce648c0d3f3057e7b9f9620fa605399fa9
+  data.tar.gz: 6134d0333d3689787c0bb0508cacb918fd82602d
 SHA512:
-  metadata.gz: b046598b87a58137b0309351e08639528ae785520047bbf323343a25e8cdd3891b996514377a2472e0c25570c0b043b7d75242dec23199951bdf5d1d14ff0c00
-  data.tar.gz: 7bfc28d4e05131c38c4a69a257f1e06d4f610b2b321d6671c16d0a8bd9c6c4965bc255c715c2a5a4a5bb063bbbf14f3f0d093ee6b729e9d5bca19c914980ccd5
+  metadata.gz: 1263da405d3719b7eaadacdd8bd67436b43bb8eb5cc68be20c543fa41fa74072ee3895b4bf3857bc50d8ed2dc3cf135dd444f061385c8f1bc77caf298e24d6e8
+  data.tar.gz: c9f2eac5ef35772f65be8abf90c110af9ecc8df9fbdb6b4f26ca86dbfc595b36fd666288de4c15c9fa377f628eb700154affec2591f7d7c687c7a21b25063dda

data/action_subscriber.gemspec

@@ -26,6 +26,7 @@ Gem::Specification.new do |spec|
   else
     spec.add_dependency 'bunny', '>= 1.5.0'
   end
+  spec.add_dependency 'concurrent-ruby'
   spec.add_dependency 'middleware'
   spec.add_dependency 'thor'
 

data/lib/action_subscriber/configuration.rb

@@ -4,6 +4,8 @@ require "action_subscriber/uri"
 module ActionSubscriber
   class Configuration
     attr_accessor :allow_low_priority_methods,
+                  :connection_reaping_interval,
+                  :connection_reaping_timeout_interval,
                   :decoder,
                   :default_exchange,
                   :error_handler,
@@ -28,6 +30,8 @@ module ActionSubscriber
 
     DEFAULTS = {
       :allow_low_priority_methods => false,
+      :connection_reaping_interval => 6,
+      :connection_reaping_timeout_interval => 5,
       :default_exchange => 'events',
       :heartbeat => 5,
       :host => 'localhost',

data/lib/action_subscriber/middleware/active_record/connection_management.rb

@@ -1,16 +1,52 @@
+require "concurrent"
+require "thread"
+
 module ActionSubscriber
   module Middleware
     module ActiveRecord
       class ConnectionManagement
+        START_MUTEX = ::Mutex.new
+
+        def self.start_timed_task!
+          if timed_task_started.false?
+            START_MUTEX.synchronize do
+              return if timed_task_started.true?
+
+              timed_task = ::Concurrent::TimerTask.new(
+                :execution_interval => ::ActionSubscriber.config.connection_reaping_interval,
+                :timeout_interval => ::ActionSubscriber.config.connection_reaping_timeout_interval) do
+
+                ::ActiveRecord::Base.clear_active_connections!
+                end
+
+              timed_task.execute
+              timed_task_started.make_true
+            end
+          end
+        end
+
+        def self.timed_task_started
+          if @timed_task_started.nil?
+            @timed_task_started = ::Concurrent::AtomicBoolean.new(false)
+          end
+
+          @timed_task_started
+        end
+
         def initialize(app)
           @app = app
         end
 
         def call(env)
-          @app.call(env)
-        ensure
-          ::ActiveRecord::Base.clear_active_connections!
+          def call(env)
+            @app.call(env)
+          end
+
+          self.class.start_timed_task!
+          call(env)
         end
+
+        timed_task_started
       end
     end
   end

data/lib/action_subscriber/middleware/active_record/query_cache.rb

@@ -2,26 +2,28 @@ module ActionSubscriber
   module Middleware
     module ActiveRecord
       class QueryCache
+        CURRENT_CONNECTION = "_action_subscriber_query_cache_current_connection".freeze
+
         def initialize(app)
           @app = app
         end
 
         def call(env)
-          enabled = ::ActiveRecord::Base.connection.query_cache_enabled
-          connection_id = ::ActiveRecord::Base.connection_id
-          ::ActiveRecord::Base.connection.enable_query_cache!
+          connection = ::Thread.current[CURRENT_CONNECTION] = ::ActiveRecord::Base.connection
+          enabled = connection.query_cache_enabled
+          connection.enable_query_cache!
 
           @app.call(env)
         ensure
-          restore_query_cache_settings(connection_id, enabled)
+          restore_query_cache_settings(enabled)
         end
 
-      private
+        private
 
-        def restore_query_cache_settings(connection_id, enabled)
-          ::ActiveRecord::Base.connection_id = connection_id
-          ::ActiveRecord::Base.connection.clear_query_cache
-          ::ActiveRecord::Base.connection.disable_query_cache! unless enabled
+        def restore_query_cache_settings(enabled)
+          ::Thread.current[CURRENT_CONNECTION].clear_query_cache
+          ::Thread.current[CURRENT_CONNECTION].disable_query_cache! unless enabled
+          ::Thread.current[CURRENT_CONNECTION] = nil
         end
       end
     end

data/lib/action_subscriber/version.rb

@@ -1,3 +1,3 @@
 module ActionSubscriber
-  VERSION = "4.1.1"
+  VERSION = "4.2.1"
 end

data/spec/lib/action_subscriber/middleware/active_record/connection_management_spec.rb

@@ -9,8 +9,8 @@ describe ActionSubscriber::Middleware::ActiveRecord::ConnectionManagement do
 
   it_behaves_like 'an action subscriber middleware'
 
-  it "clears active connections" do
-    expect(ActiveRecord::Base).to receive(:clear_active_connections!)
+  it "starts async task to clear connections" do
+    expect(ActionSubscriber::Middleware::ActiveRecord::ConnectionManagement).to receive(:start_timed_task!)
     subject.call(env)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: action_subscriber
 version: !ruby/object:Gem::Version
-  version: 4.1.1
+  version: 4.2.1
 platform: ruby
 authors:
 - Brian Stien
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-03 00:00:00.000000000 Z
+date: 2017-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -42,6 +42,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.0
+- !ruby/object:Gem::Dependency
+  name: concurrent-ruby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: middleware
   requirement: !ruby/object:Gem::Requirement
@@ -268,7 +282,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: ActionSubscriber is a DSL that allows a rails app to consume messages from