action_presenter 1.1 → 1.1.1

data/CHANGELOG.md

@@ -15,3 +15,7 @@
 
 * fix `present` helper to return presenter instance if no block is given (test braking change - release new minor version)
 * RSpec inspired way to define short and consise methods
+
+## Version 1.1.1
+
+* allow to scope variable when calling #present helper `present [:admin, @article]`

data/README.md

@@ -1,4 +1,4 @@
-## ActionPresenter [![Build Status](https://secure.travis-ci.org/zlw/action_presenter.png?branch=master)](http://travis-ci.org/zlw/action_presenter)
+# ActionPresenter [![Build Status](https://secure.travis-ci.org/zlw/action_presenter.png?branch=master)](http://travis-ci.org/zlw/action_presenter)
 
 Missing link between models and views.
 Use presenter pattern in Rails application without changing controllers.
@@ -29,7 +29,7 @@ Gem was tested under Ruby 1.9.2 and 1.9.3, Rails 3.2.1
 
 ## Usage
 
-Create presenter class
+### Creating presenter class
 
 ```ruby
 # /app/presenters/post_presenter.rb
@@ -48,7 +48,7 @@ end
 
 You can use all view helpers without any changes. Reference to model by method with the name passed to `presents` class method.
 
-and then use it in view
+### Calling presenter
 
 ```haml
 # /app/views/posts/index.html.haml
@@ -57,15 +57,33 @@ and then use it in view
   = p.content
 ```
 
-If You want to change presenter class pass it as second argument
+It will call (by default) `PostPresenter` (assuming that @post variable is instance of Post class)
 
-```haml
-# /app/views/post/show.html.haml
-- present @post, PostShowPresenter do |p|
-  = p.title
+There are some ways to change default presenter class
+
+#### 1. Pass class as second argument
+
+```ruby
+present @post, ArticlePresenter
+```
+
+It will call `ArticlePresenter` class
+
+#### 2. Scope variable
+
+```ruby
+present [:admin, @post]
 ```
 
-All that without any change in any model or controller
+It will call `Admin::PostPresenter` class
+
+**Please, keep in mind, that passing presenter class has higher priority than scope:**
+
+```ruby
+present [:admin, @post], ArticlePresenter
+```
+
+**It will also call `ArticlePresenter` class**
 
 ## Defaults
 
@@ -144,6 +162,15 @@ class TestArticlePresenter < ActionView::TestCase
 end
 ```
 
+## Feature requests, contributing to project
+
+Well, I am not sitting all day and thinking about fancy stuff that I could add to action_presenter. 
+Everytime I need something I add this to my current project, than extract it to this gem and release a new version.
+
+If you need something - please create an issue with feature request or, wchich is more welcome (my time is also limited), send pull request.
+
+Also if you something is missing/broken, please do not think `Man, this gem sucks and its author is shitty coder` and no longer use it! Let me know about it - create an issue or send patch.
+
 ## Maintainers
 
 * Krzysztof Zalewski (https://github.com/zlw, http://kzalewski.blogspot.com)

data/lib/action_presenter/version.rb

@@ -1,3 +1,3 @@
 module ActionPresenter
-  VERSION = "1.1"
+  VERSION = "1.1.1"
 end

data/lib/action_presenter/view_helper.rb

@@ -6,11 +6,27 @@ module ActionPresenter
       helper_method :present
     end
 
-    def present(object, klass = "#{object.class}Presenter".constantize)
+    def present(object, klass = nil)
+      klass ||= presenter_name object
       presenter = klass.new(object, view_context)
 
       return yield presenter if block_given?
       presenter
     end
+
+  private
+
+    def presenter_name(scope)
+      "#{klass_name(scope)}Presenter".constantize
+    end
+
+    def klass_name(scope)
+      return scope.class.to_s unless scope.is_a? Array
+      return scope.first.class.to_s if scope.length == 1
+
+      scope.map do |s|
+        s.is_a?(Symbol) ? s.capitalize : s.class
+      end.join('::')
+    end
   end
 end

data/spec/action_presenter/view_helper_spec.rb

@@ -6,19 +6,79 @@ require 'support/dummy_action_controller'
 describe ActionPresenter::ViewHelper do
   include ActionControllerHelper
 
-  it 'should call default presenter if presenter class is not given' do
-    helper.present('foobar') do |p|
-      p.should be_instance_of StringPresenter
+  context "#with block" do
+    it 'should call default presenter if presenter class is not given' do
+      helper.present('foo') do |p|
+        p.should be_instance_of StringPresenter
+      end
+    end
+
+    it 'should call given presenter class' do
+      klass = FoobarPresenter
+      helper.present('foo', klass) do |p|
+        p.should be_instance_of klass
+      end
+    end
+
+    it 'should call scoped presenter if no class is given' do
+      helper.present [:foo, 'foo'] do |p|
+        p.should be_instance_of Foo::StringPresenter
+      end
+    end
+
+    it 'should call given presenter class even if scope is given' do
+      klass = FoobarPresenter
+      helper.present [:foo, 'foo'], klass do |p|
+        p.should be_instance_of klass
+      end
     end
   end
 
-  it 'should call given presenter class' do
-    helper.present('foobar', FoobarPresenter) do |p|
-      p.should be_instance_of FoobarPresenter
+  context "#without block" do
+    it 'should return presenter instance if no block is given' do
+      helper.present('foo').should be_instance_of StringPresenter
+    end
+
+    it 'should return presenter instance if scope is given' do
+      helper.present([:foo, 'foo']).should be_instance_of Foo::StringPresenter
+    end
+
+    it "should return given presenter instance even if scope is given" do
+      klass = FoobarPresenter
+      helper.present([:foo, 'foo'], klass).should be_instance_of klass
     end
   end
 
-  it 'should return presenter instance if no block is given' do
-    helper.present('foobar').should be_instance_of StringPresenter
+  context "#private methods" do
+    context "#presenter_name" do
+      it 'should return constant for object' do
+        helper.should_receive(:klass_name).with('foo').and_return 'String'
+        helper.send(:presenter_name, 'foo').should == StringPresenter
+      end
+
+      it 'should return constant for one element array' do
+        helper.should_receive(:klass_name).with(['foo']).and_return 'String'
+        helper.send(:presenter_name, ['foo']).should == StringPresenter
+      end
+
+      it 'should return constant for few element array' do
+        helper.should_receive(:klass_name).with([:foo, 'foo']).and_return 'Foo::String'
+        helper.send(:presenter_name, [:foo, 'foo']).should == Foo::StringPresenter
+      end
+    end
+
+    context "#klass_name" do
+      it 'should return klass name for object' do
+        helper.send(:klass_name, 'foo').should == 'String'
+      end
+
+      it "should return klass name for one element array" do
+        helper.send(:klass_name, ['foo']).should == 'String'
+      end
+
+      it "should return klass name for few elements array" do
+        helper.send(:klass_name, [:foo, 'foo']).should == 'Foo::String'
+      end
+    end
   end
 end

data/spec/support/string_presenter.rb

@@ -8,4 +8,10 @@ class FoobarPresenter < ActionPresenter::Base
   def foobar
     'bar'
   end
+end
+
+
+module Foo
+  class StringPresenter < ActionPresenter::Base
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: action_presenter
 version: !ruby/object:Gem::Version
-  version: '1.1'
+  version: 1.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-27 00:00:00.000000000 Z
+date: 2012-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
-  requirement: &70356359315720 !ruby/object:Gem::Requirement
+  requirement: &70294413858660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70356359315720
+  version_requirements: *70294413858660
 - !ruby/object:Gem::Dependency
   name: named_accessors
-  requirement: &70356359300080 !ruby/object:Gem::Requirement
+  requirement: &70294413858200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70356359300080
+  version_requirements: *70294413858200
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70356359299600 !ruby/object:Gem::Requirement
+  requirement: &70294413840020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70356359299600
+  version_requirements: *70294413840020
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70356359299140 !ruby/object:Gem::Requirement
+  requirement: &70294413839580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70356359299140
+  version_requirements: *70294413839580
 description: Missing link between models and views. Use presenter pattern in Rails
   application without changing controllers.
 email:
@@ -100,7 +100,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3423536328799258601
+      hash: 1028900342905026486
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -109,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3423536328799258601
+      hash: 1028900342905026486
 requirements: []
 rubyforge_project: action_presenter
 rubygems_version: 1.8.16