action_policy 0.7.3 → 0.7.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21363e4337fbe0caea24309750d79d94bb9fa6c4ae0a9d0697b0e686519fa763
-  data.tar.gz: 8ac572534b621240640723ea5c6ec942a73b91e14f2d40e534889c2dc7ba9251
+  metadata.gz: d3680162e91000d7fb369fcfa17710f557c9a12435c5bf00c6fb367a5045b970
+  data.tar.gz: 000760f640032e5a0b44e9ea7918908a32c2568cefeffc747fa4ea45c46949bf
 SHA512:
-  metadata.gz: c1dd33d739cfdf1143b7cc2402c2e8bf7ebf1f1613fa7c650c72fddf0bd4fd4b5c924c920ff143ad582ab68524836f0d0c32641372c5999fdd95f6d9113078dc
-  data.tar.gz: 5fb9dbd9b1f19fb6bed19ddbeb99be9bd35495b2d0f89bd3fb0cd8fed59a0513c4a627fdd25291b56dcfc7cf9b60f64d351bb2b658d97351f9a7b5db2d1c4128
+  metadata.gz: f03892d33e150921d3ec4bdfe1038b017301825474597037585c45e0f780affdfd72ed5171c577cee007af69a8542d4172cb8266526a97895b9c3461b4b2abb3
+  data.tar.gz: e5d9a4259d5dcd8cac8a0cab28b6d85f3aedc46050c51057aa9d458b4c0b8597428bed1a6c57473f3836500b1696cfb1f4a4c1aeac868c2771bb443dc59f10fa

data/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 ## master
 
+## 0.7.5 (2025-05-09) 🎇
+
+- Ensure `result.value` is true or false. ([@palkan][])
+
+## 0.7.4 (2025-03-12)
+
+- Let authorize! return the policy record. ([@sedubois][])
+
+- Enable `allowance_to` as a helper method by default. ([@stephannv][])
+
+- Allow the `:through` option of `authorize` to be passed a Proc. ([@brendon][])
+
 ## 0.7.3 (2024-12-18)
 
 - Fix keeping the result object in concurrent (Fiber-ed) execution environments. ([@palkan][])
@@ -539,3 +551,5 @@ This value is now stored in a cache (if any) instead of just the call result (`t
 [@matsales28]: https://github.com/matsales28
 [@killondark]: https://github.com/killondark
 [@Spone]: https://github.com/Spone
+[@stephannv]: https://github.com/stephannv
+[@sedubois]: https://github.com/sedubois

data/lib/.rbnext/3.0/action_policy/behaviours/policy_for.rb

@@ -61,7 +61,7 @@ module ActionPolicy
 
       def policy_for_cache_key(record:, with: nil, namespace: nil, context: authorization_context, **__kwrest__)
         record_key = record._policy_cache_key(use_object_id: true)
-        context_key = context.values.map { _1._policy_cache_key(use_object_id: true) }.join(".")
+        context_key = context.values.map { it = _1;it._policy_cache_key(use_object_id: true) }.join(".")
 
         "#{namespace}/#{with}/#{context_key}/#{record_key}"
       end

data/lib/.rbnext/3.0/action_policy/policy/cache.rb

@@ -29,7 +29,7 @@ module ActionPolicy # :nodoc:
         [
           cache_namespace,
           *parts
-        ].map { _1._policy_cache_key }.join("/")
+        ].map { it = _1;it._policy_cache_key }.join("/")
       end
 
       def rule_cache_key(rule)

data/lib/.rbnext/3.0/action_policy/policy/execution_result.rb

@@ -16,7 +16,7 @@ module ActionPolicy
 
       # Populate the final value
       def load(value)
-        @value = value
+        @value = !!value
       end
 
       def success?() ;  @value == true; end

data/lib/.rbnext/3.0/action_policy/policy/pre_check.rb

@@ -78,8 +78,6 @@ module ActionPolicy
 
           rebuild_filter
         end
-        # rubocop: enable
-        # rubocop: enable
 
         def dup
           self.class.new(
@@ -127,7 +125,7 @@ module ActionPolicy
         def pre_check(*names, **options)
           names.each do |name|
             # do not allow pre-check override
-            check = pre_checks.find { _1.name == name }
+            check = pre_checks.find { it = _1;it.name == name }
             raise "Pre-check already defined: #{name}" unless check.nil?
 
             pre_checks << Check.new(self, name, **options)
@@ -136,14 +134,14 @@ module ActionPolicy
 
         def skip_pre_check(*names, **options)
           names.each do |name|
-            check = pre_checks.find { _1.name == name }
+            check = pre_checks.find { it = _1;it.name == name }
             raise "Pre-check not found: #{name}" if check.nil?
 
             # when no options provided we remove this check completely
             next pre_checks.delete(check) if options.empty?
 
             # otherwise duplicate and apply skip options
-            pre_checks[pre_checks.index(check)] = check.dup.tap { _1.skip!(**options) }
+            pre_checks[pre_checks.index(check)] = check.dup.tap { it = _1;it.skip!(**options) }
           end
         end
 

data/lib/.rbnext/3.0/action_policy/policy/reasons.rb

@@ -27,6 +27,8 @@ module ActionPolicy
       #   { policy_identifier => [rules, ...] }
       def details() ;  reasons.transform_keys(&:identifier); end
 
+      alias_method :to_h, :details
+
       def empty?() ;  reasons.empty?; end
 
       def present?() ;  !empty?; end

data/lib/.rbnext/3.0/action_policy/rspec/be_authorized_to.rb

@@ -51,7 +51,7 @@ module ActionPolicy
 
         @actual_calls = ActionPolicy::Testing::AuthorizeTracker.calls
 
-        actual_calls.any? { _1.matches?(policy, rule, target, context) }
+        actual_calls.any? { it = _1;it.matches?(policy, rule, target, context) }
       end
 
       def does_not_match?(*__rest__)
@@ -78,7 +78,7 @@ module ActionPolicy
 
       def formatted_calls
         actual_calls.map do
-          " - #{_1.inspect}"
+          it = _1;" - #{it.inspect}"
         end.join("\n")
       end
 

data/lib/.rbnext/3.0/action_policy/rspec/have_authorized_scope.rb

@@ -61,7 +61,7 @@ module ActionPolicy
 
         @actual_scopes = ActionPolicy::Testing::AuthorizeTracker.scopings
 
-        matching_scopes = actual_scopes.select { _1.matches?(policy, type, name, scope_options, context) }
+        matching_scopes = actual_scopes.select { it = _1;it.matches?(policy, type, name, scope_options, context) }
 
         return false if matching_scopes.empty?
 
@@ -114,7 +114,7 @@ module ActionPolicy
 
       def formatted_scopings
         actual_scopes.map do
-          " - #{_1.inspect}"
+          it = _1;" - #{it.inspect}"
         end.join("\n")
       end
     end

data/lib/.rbnext/3.0/action_policy/utils/pretty_print.rb

@@ -119,7 +119,7 @@ module ActionPolicy
 
       # Some lines should not be evaled
       def ignore_exp?(exp)
-        PrettyPrint.ignore_expressions.any? { exp.match?(_1) }
+        PrettyPrint.ignore_expressions.any? { it = _1;exp.match?(it) }
       end
     end
 

data/lib/.rbnext/3.1/action_policy/behaviours/policy_for.rb

@@ -61,7 +61,7 @@ module ActionPolicy
 
       def policy_for_cache_key(record:, with: nil, namespace: nil, context: authorization_context, **__kwrest__)
         record_key = record._policy_cache_key(use_object_id: true)
-        context_key = context.values.map { _1._policy_cache_key(use_object_id: true) }.join(".")
+        context_key = context.values.map { it = _1;it._policy_cache_key(use_object_id: true) }.join(".")
 
         "#{namespace}/#{with}/#{context_key}/#{record_key}"
       end

data/lib/.rbnext/3.2/action_policy/behaviours/policy_for.rb

@@ -61,7 +61,7 @@ module ActionPolicy
 
       def policy_for_cache_key(record:, with: nil, namespace: nil, context: authorization_context, **__kwrest__)
         record_key = record._policy_cache_key(use_object_id: true)
-        context_key = context.values.map { _1._policy_cache_key(use_object_id: true) }.join(".")
+        context_key = context.values.map { it = _1;it._policy_cache_key(use_object_id: true) }.join(".")
 
         "#{namespace}/#{with}/#{context_key}/#{record_key}"
       end

data/lib/.rbnext/3.2/action_policy/rspec/be_authorized_to.rb

@@ -51,7 +51,7 @@ module ActionPolicy
 
         @actual_calls = ActionPolicy::Testing::AuthorizeTracker.calls
 
-        actual_calls.any? { _1.matches?(policy, rule, target, context) }
+        actual_calls.any? { it = _1;it.matches?(policy, rule, target, context) }
       end
 
       def does_not_match?(*__rest__)
@@ -78,7 +78,7 @@ module ActionPolicy
 
       def formatted_calls
         actual_calls.map do
-          " - #{_1.inspect}"
+          it = _1;" - #{it.inspect}"
         end.join("\n")
       end
 

data/lib/.rbnext/3.2/action_policy/rspec/have_authorized_scope.rb

@@ -61,7 +61,7 @@ module ActionPolicy
 
         @actual_scopes = ActionPolicy::Testing::AuthorizeTracker.scopings
 
-        matching_scopes = actual_scopes.select { _1.matches?(policy, type, name, scope_options, context) }
+        matching_scopes = actual_scopes.select { it = _1;it.matches?(policy, type, name, scope_options, context) }
 
         return false if matching_scopes.empty?
 
@@ -114,7 +114,7 @@ module ActionPolicy
 
       def formatted_scopings
         actual_scopes.map do
-          " - #{_1.inspect}"
+          it = _1;" - #{it.inspect}"
         end.join("\n")
       end
     end

data/lib/.rbnext/{2.7 → 3.4}/action_policy/behaviours/policy_for.rb

@@ -13,12 +13,12 @@ module ActionPolicy
 
         policy_class = with || ::ActionPolicy.lookup(
           record,
-          namespace: namespace, context: context, allow_nil: allow_nil, default: default, strict_namespace: strict_namespace
+          namespace:, context:, allow_nil:, default:, strict_namespace:
         )
         policy_class&.new(record, **context)
       end
 
-      def authorization_context ;  @authorization_context ||= build_authorization_context; end
+      def authorization_context = @authorization_context ||= build_authorization_context
 
       def build_authorization_context
         Kernel.raise NotImplementedError, "Please, define `build_authorization_context` method!"
@@ -59,9 +59,9 @@ module ActionPolicy
         )
       end
 
-      def policy_for_cache_key(record:, with: nil, namespace: nil, context: authorization_context, **__kwrest__)
+      def policy_for_cache_key(record:, with: nil, namespace: nil, context: authorization_context, **)
         record_key = record._policy_cache_key(use_object_id: true)
-        context_key = context.values.map { |_1| _1._policy_cache_key(use_object_id: true) }.join(".")
+        context_key = context.values.map { it = _1;it._policy_cache_key(use_object_id: true) }.join(".")
 
         "#{namespace}/#{with}/#{context_key}/#{record_key}"
       end

data/lib/.rbnext/{2.7 → 3.4}/action_policy/i18n.rb

@@ -21,7 +21,7 @@ module ActionPolicy
       private
 
       def candidates_for(policy_class, rule)
-        policy_hierarchy = policy_class.ancestors.select { |_1| _1.respond_to?(:identifier) }
+        policy_hierarchy = policy_class.ancestors.select { it = _1;it.respond_to?(:identifier) }
         [
           *policy_hierarchy.map { |klass| :"policy.#{klass.identifier}.#{rule}" },
           :"policy.#{rule}",

data/lib/.rbnext/{2.7 → 3.4}/action_policy/policy/cache.rb

@@ -23,13 +23,13 @@ module ActionPolicy # :nodoc:
         end
       end
 
-      def cache_namespace() ;  ActionPolicy::CACHE_NAMESPACE; end
+      def cache_namespace() = ActionPolicy::CACHE_NAMESPACE
 
       def cache_key(*parts)
         [
           cache_namespace,
           *parts
-        ].map { |_1| _1._policy_cache_key }.join("/")
+        ].map { it = _1;it._policy_cache_key }.join("/")
       end
 
       def rule_cache_key(rule)
@@ -42,7 +42,7 @@ module ActionPolicy # :nodoc:
       end
 
       def context_cache_key
-        authorization_context.map { |_1, _2| _2._policy_cache_key.to_s }.join("/")
+        authorization_context.map { _2._policy_cache_key.to_s }.join("/")
       end
 
       def apply_with_cache(rule)

data/lib/.rbnext/{2.7 → 3.4}/action_policy/policy/pre_check.rb

@@ -52,7 +52,7 @@ module ActionPolicy
           filter.call(rule)
         end
 
-        def call(policy) ;  policy.send(name); end
+        def call(policy) = policy.send(name)
 
         def skip!(except: nil, only: nil)
           if !except.nil? && !only.nil?
@@ -78,8 +78,6 @@ module ActionPolicy
 
           rebuild_filter
         end
-        # rubocop: enable
-        # rubocop: enable
 
         def dup
           self.class.new(
@@ -127,7 +125,7 @@ module ActionPolicy
         def pre_check(*names, **options)
           names.each do |name|
             # do not allow pre-check override
-            check = pre_checks.find { |_1| _1.name == name }
+            check = pre_checks.find { it = _1;it.name == name }
             raise "Pre-check already defined: #{name}" unless check.nil?
 
             pre_checks << Check.new(self, name, **options)
@@ -136,14 +134,14 @@ module ActionPolicy
 
         def skip_pre_check(*names, **options)
           names.each do |name|
-            check = pre_checks.find { |_1| _1.name == name }
+            check = pre_checks.find { it = _1;it.name == name }
             raise "Pre-check not found: #{name}" if check.nil?
 
             # when no options provided we remove this check completely
             next pre_checks.delete(check) if options.empty?
 
             # otherwise duplicate and apply skip options
-            pre_checks[pre_checks.index(check)] = check.dup.tap { |_1| _1.skip!(**options) }
+            pre_checks[pre_checks.index(check)] = check.dup.tap { it = _1;it.skip!(**options) }
           end
         end
 

data/lib/.rbnext/{2.7 → 3.4}/action_policy/rspec/be_authorized_to.rb

@@ -51,14 +51,14 @@ module ActionPolicy
 
         @actual_calls = ActionPolicy::Testing::AuthorizeTracker.calls
 
-        actual_calls.any? { |_1| _1.matches?(policy, rule, target, context) }
+        actual_calls.any? { it = _1;it.matches?(policy, rule, target, context) }
       end
 
-      def does_not_match?(*__rest__)
+      def does_not_match?(*)
         raise "This matcher doesn't support negation"
       end
 
-      def supports_block_expectations?() ;  true; end
+      def supports_block_expectations?() = true
 
       def failure_message
         "expected #{formatted_record} " \
@@ -77,12 +77,12 @@ module ActionPolicy
       end
 
       def formatted_calls
-        actual_calls.map do |_1|
-          " - #{_1.inspect}"
+        actual_calls.map do
+          it = _1;" - #{it.inspect}"
         end.join("\n")
       end
 
-      def formatted_record(record = target) ;  ::RSpec::Support::ObjectFormatter.format(record); end
+      def formatted_record(record = target) = ::RSpec::Support::ObjectFormatter.format(record)
     end
   end
 end

data/lib/.rbnext/{2.7 → 3.4}/action_policy/rspec/have_authorized_scope.rb

@@ -61,7 +61,7 @@ module ActionPolicy
 
         @actual_scopes = ActionPolicy::Testing::AuthorizeTracker.scopings
 
-        matching_scopes = actual_scopes.select { |_1| _1.matches?(policy, type, name, scope_options, context) }
+        matching_scopes = actual_scopes.select { it = _1;it.matches?(policy, type, name, scope_options, context) }
 
         return false if matching_scopes.empty?
 
@@ -76,11 +76,11 @@ module ActionPolicy
         true
       end
 
-      def does_not_match?(*__rest__)
+      def does_not_match?(*)
         raise "This matcher doesn't support negation"
       end
 
-      def supports_block_expectations?() ;  true; end
+      def supports_block_expectations?() = true
 
       def failure_message
         "expected a scoping named :#{name} for type :#{type} " \
@@ -113,8 +113,8 @@ module ActionPolicy
       end
 
       def formatted_scopings
-        actual_scopes.map do |_1|
-          " - #{_1.inspect}"
+        actual_scopes.map do
+          it = _1;" - #{it.inspect}"
         end.join("\n")
       end
     end

data/lib/.rbnext/{2.7 → 3.4}/action_policy/utils/pretty_print.rb

@@ -119,7 +119,7 @@ module ActionPolicy
 
       # Some lines should not be evaled
       def ignore_exp?(exp)
-        PrettyPrint.ignore_expressions.any? { |_1| exp.match?(_1) }
+        PrettyPrint.ignore_expressions.any? { it = _1;exp.match?(it) }
       end
     end
 
@@ -127,7 +127,7 @@ module ActionPolicy
       attr_accessor :ignore_expressions
 
       if defined?(::Prism) && defined?(::MethodSource)
-        def available?() ;  true; end
+        def available?() = true
 
         def print_method(object, method_name)
           ast = Prism.parse(object.method(method_name).source)
@@ -135,9 +135,9 @@ module ActionPolicy
           Visitor.new(object).collect(ast)
         end
       else
-        def available?() ;  false; end
+        def available?() = false
 
-        def print_method(_, _) ;  ""; end
+        def print_method(_, _) = ""
       end
 
       def colorize(val)

data/lib/action_policy/behaviour.rb

@@ -33,11 +33,13 @@ module ActionPolicy
     # Policy is inferred from record
     # (unless explicitly specified through `with` option).
     #
+    # @return the policy record
     # Raises `ActionPolicy::Unauthorized` if check failed.
     def authorize!(record = :__undef__, to:, **options)
       policy = lookup_authorization_policy(record, **options)
 
       Authorizer.call(policy, authorization_rule_for(policy, to))
+      policy.record
     end
 
     # Checks that an activity is allowed for the current context (e.g. user).
@@ -62,8 +64,8 @@ module ActionPolicy
 
     private def build_authorization_context
       self.class.authorization_targets
-        .each_with_object({}) do |(key, meth), obj|
-        obj[key] = send(meth)
+        .each_with_object({}) do |(key, method_or_proc), obj|
+        obj[key] = method_or_proc.is_a?(Proc) ? method_or_proc.call : send(method_or_proc)
       end
     end
 
@@ -103,8 +105,8 @@ module ActionPolicy
       #     authorize :user
       #   end
       def authorize(key, through: nil)
-        meth = through || key
-        authorization_targets[key] = meth
+        method_or_proc = through || key
+        authorization_targets[key] = method_or_proc
       end
 
       def authorization_targets

data/lib/action_policy/behaviours/policy_for.rb

@@ -61,7 +61,7 @@ module ActionPolicy
 
       def policy_for_cache_key(record:, with: nil, namespace: nil, context: authorization_context, **)
         record_key = record._policy_cache_key(use_object_id: true)
-        context_key = context.values.map { _1._policy_cache_key(use_object_id: true) }.join(".")
+        context_key = context.values.map { it._policy_cache_key(use_object_id: true) }.join(".")
 
         "#{namespace}/#{with}/#{context_key}/#{record_key}"
       end

data/lib/action_policy/i18n.rb

@@ -21,7 +21,7 @@ module ActionPolicy
       private
 
       def candidates_for(policy_class, rule)
-        policy_hierarchy = policy_class.ancestors.select { _1.respond_to?(:identifier) }
+        policy_hierarchy = policy_class.ancestors.select { it.respond_to?(:identifier) }
         [
           *policy_hierarchy.map { |klass| :"policy.#{klass.identifier}.#{rule}" },
           :"policy.#{rule}",

data/lib/action_policy/policy/cache.rb

@@ -29,7 +29,7 @@ module ActionPolicy # :nodoc:
         [
           cache_namespace,
           *parts
-        ].map { _1._policy_cache_key }.join("/")
+        ].map { it._policy_cache_key }.join("/")
       end
 
       def rule_cache_key(rule)

data/lib/action_policy/policy/execution_result.rb

@@ -16,7 +16,7 @@ module ActionPolicy
 
       # Populate the final value
       def load(value)
-        @value = value
+        @value = !!value
       end
 
       def success?() = @value == true

data/lib/action_policy/policy/pre_check.rb

@@ -78,8 +78,6 @@ module ActionPolicy
 
           rebuild_filter
         end
-        # rubocop: enable
-        # rubocop: enable
 
         def dup
           self.class.new(
@@ -127,7 +125,7 @@ module ActionPolicy
         def pre_check(*names, **options)
           names.each do |name|
             # do not allow pre-check override
-            check = pre_checks.find { _1.name == name }
+            check = pre_checks.find { it.name == name }
             raise "Pre-check already defined: #{name}" unless check.nil?
 
             pre_checks << Check.new(self, name, **options)
@@ -136,14 +134,14 @@ module ActionPolicy
 
         def skip_pre_check(*names, **options)
           names.each do |name|
-            check = pre_checks.find { _1.name == name }
+            check = pre_checks.find { it.name == name }
             raise "Pre-check not found: #{name}" if check.nil?
 
             # when no options provided we remove this check completely
             next pre_checks.delete(check) if options.empty?
 
             # otherwise duplicate and apply skip options
-            pre_checks[pre_checks.index(check)] = check.dup.tap { _1.skip!(**options) }
+            pre_checks[pre_checks.index(check)] = check.dup.tap { it.skip!(**options) }
           end
         end
 

data/lib/action_policy/policy/reasons.rb

@@ -27,6 +27,8 @@ module ActionPolicy
       #   { policy_identifier => [rules, ...] }
       def details() = reasons.transform_keys(&:identifier)
 
+      alias_method :to_h, :details
+
       def empty?() = reasons.empty?
 
       def present?() = !empty?

data/lib/action_policy/rails/controller.rb

@@ -26,6 +26,7 @@ module ActionPolicy
       if respond_to?(:helper_method)
         helper_method :allowed_to?
         helper_method :authorized_scope
+        helper_method :allowance_to
       end
 
       attr_writer :authorize_count
@@ -44,13 +45,15 @@ module ActionPolicy
     # If record is not provided, tries to infer the resource class
     # from controller name (i.e. `controller_name.classify.safe_constantize`).
     #
+    # @return the policy record
     # Raises `ActionPolicy::Unauthorized` if check failed.
     def authorize!(record = :__undef__, to: nil, **options)
       to ||= :"#{action_name}?"
 
-      super
+      policy_record = super
 
       self.authorize_count += 1
+      policy_record
     end
 
     # Tries to infer the resource class from controller name

data/lib/action_policy/rspec/be_authorized_to.rb

@@ -51,7 +51,7 @@ module ActionPolicy
 
         @actual_calls = ActionPolicy::Testing::AuthorizeTracker.calls
 
-        actual_calls.any? { _1.matches?(policy, rule, target, context) }
+        actual_calls.any? { it.matches?(policy, rule, target, context) }
       end
 
       def does_not_match?(*)
@@ -78,7 +78,7 @@ module ActionPolicy
 
       def formatted_calls
         actual_calls.map do
-          " - #{_1.inspect}"
+          " - #{it.inspect}"
         end.join("\n")
       end
 

data/lib/action_policy/rspec/have_authorized_scope.rb

@@ -61,7 +61,7 @@ module ActionPolicy
 
         @actual_scopes = ActionPolicy::Testing::AuthorizeTracker.scopings
 
-        matching_scopes = actual_scopes.select { _1.matches?(policy, type, name, scope_options, context) }
+        matching_scopes = actual_scopes.select { it.matches?(policy, type, name, scope_options, context) }
 
         return false if matching_scopes.empty?
 
@@ -114,7 +114,7 @@ module ActionPolicy
 
       def formatted_scopings
         actual_scopes.map do
-          " - #{_1.inspect}"
+          " - #{it.inspect}"
         end.join("\n")
       end
     end

data/lib/action_policy/utils/pretty_print.rb

@@ -119,7 +119,7 @@ module ActionPolicy
 
       # Some lines should not be evaled
       def ignore_exp?(exp)
-        PrettyPrint.ignore_expressions.any? { exp.match?(_1) }
+        PrettyPrint.ignore_expressions.any? { exp.match?(it) }
       end
     end
 

data/lib/action_policy/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActionPolicy
-  VERSION = "0.7.3"
+  VERSION = "0.7.5"
 end

data/lib/ruby_lsp/action_policy/addon.rb

@@ -0,0 +1,170 @@
+# frozen_string_literal: true
+
+# From https://gist.github.com/skryukov/35539d57b51f38235faaace2c1a2c1a1
+
+require "active_support/inflector"
+
+module RubyLsp
+  module ActionPolicy
+    class Addon < ::RubyLsp::Addon
+      def name
+        "ActionPolicy"
+      end
+
+      def activate(global_state, outgoing_queue)
+        require "action_policy"
+        warn "[ActionPolicy] Activating Ruby LSP addon v#{::ActionPolicy::VERSION}"
+      end
+
+      def deactivate
+      end
+
+      def create_definition_listener(response_builder, node_context, uri, dispatcher)
+        Definition.new(response_builder, node_context, uri, dispatcher)
+      end
+    end
+
+    class Definition
+      include Requests::Support::Common
+      include ActiveSupport::Inflector
+
+      POLICY_SUPERCLASSES = ["ApplicationPolicy", "ActionPolicy::Base"].freeze
+
+      def initialize(response_builder, uri, node_context, dispatcher)
+        @response_builder = response_builder
+        @node_context = node_context
+        @uri = uri
+        @path = uri.to_standardized_path
+        @policy_rules_cache = {}
+
+        dispatcher.register(self, :on_symbol_node_enter)
+      end
+
+      def on_symbol_node_enter(node)
+        return unless in_authorize_call?
+
+        target = @node_context.call_node
+        # authorization target is the first argument (if explicit)
+        policy_class = find_policy_class(target.arguments&.child_node&.first)
+        return unless policy_class
+
+        policy_path = find_policy_file(policy_class)
+        return unless policy_path
+
+        ensure_policy_rules_cached(policy_path)
+        add_definition(policy_path, node.value)
+      end
+
+      private
+
+      def in_authorize_call?
+        call = @node_context.call_node
+        call.is_a?(Prism::CallNode) && call.message == "authorize!"
+      end
+
+      def find_policy_class(target)
+        content = File.read(@path)
+        document = Prism.parse(content)
+        class_node = find_containing_class(document.value)
+        return derive_policy_from_target(target) unless class_node
+
+        class_name = class_node.constant_path.slice
+        return unless class_name.end_with?("Controller", "Channel")
+
+        resource_name = class_name
+          .delete_suffix("Controller")
+          .delete_suffix("Channel")
+          .singularize
+        "#{resource_name}Policy"
+      end
+
+      def find_containing_class(root)
+        return unless root.respond_to?(:statements)
+
+        root.statements.body.find do |node|
+          node.is_a?(Prism::ClassNode) &&
+            node.constant_path.slice.end_with?("Controller", "Channel")
+        end
+      end
+
+      def derive_policy_from_target(target)
+        target_name = case target
+        when Prism::InstanceVariableReadNode
+          target.name.to_s[1..].classify
+        when Prism::ConstantReadNode
+          target.name.to_s
+        when NilClass
+          return
+        else
+          target.slice
+        end
+
+        target_name.end_with?("Policy") ? target_name : "#{target_name}Policy"
+      end
+
+      def find_policy_file(policy_class)
+        file_path = policy_class.gsub(/([a-z])([A-Z])/, "\\1_\\2").downcase
+        root_path = Dir.pwd
+
+        [
+          File.join(root_path, "app/policies/#{file_path}.rb"),
+          File.join(root_path, "app/policies/#{file_path}_policy.rb"),
+          *Dir.glob(File.join(root_path, "app/policies/**/#{file_path}.rb")),
+          *Dir.glob(File.join(root_path, "app/policies/**/#{file_path}_policy.rb"))
+        ].find { |path| File.exist?(path) }
+      end
+
+      def ensure_policy_rules_cached(policy_path)
+        return if @policy_rules_cache[policy_path]
+
+        content = File.read(policy_path)
+        document = Prism.parse(content)
+
+        document.value.statements.body.each do |stmt|
+          if stmt.is_a?(Prism::ClassNode)
+            @policy_rules_cache[policy_path] = extract_rules(stmt)
+            break
+          end
+        end
+      end
+
+      def extract_rules(node)
+        return {} unless node.body
+
+        rules = {}
+        private_section = false
+
+        node.body.child_nodes.each do |stmt|
+          case stmt
+          when Prism::CallNode
+            if stmt.message == "private"
+              private_section = true
+            elsif stmt.message == "alias_rule" && stmt.arguments&.arguments
+              stmt.arguments.arguments
+                .select { |arg| arg.is_a?(Prism::SymbolNode) }
+                .each { |arg| rules[arg.value] ||= stmt.location.start_line }
+            end
+          when Prism::DefNode
+            next if private_section
+            rules[stmt.name.to_s] = stmt.location.start_line
+          end
+        end
+        rules
+      end
+
+      def add_definition(policy_path, action)
+        rules = @policy_rules_cache[policy_path]
+        line_number = rules&.[](action.to_s)
+        return unless line_number
+
+        @response_builder << Interface::Location.new(
+          uri: URI::Generic.from_path(path: policy_path).to_s,
+          range: Interface::Range.new(
+            start: Interface::Position.new(line: line_number - 1, character: 0),
+            end: Interface::Position.new(line: line_number - 1, character: 0)
+          )
+        )
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: action_policy
 version: !ruby/object:Gem::Version
-  version: 0.7.3
+  version: 0.7.5
 platform: ruby
 authors:
 - Vladimir Dementyev
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-18 00:00:00.000000000 Z
+date: 2025-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-next-core
@@ -133,15 +133,6 @@ files:
 - LICENSE.txt
 - README.md
 - config/rubocop-rspec.yml
-- lib/.rbnext/2.7/action_policy/behaviours/policy_for.rb
-- lib/.rbnext/2.7/action_policy/i18n.rb
-- lib/.rbnext/2.7/action_policy/policy/cache.rb
-- lib/.rbnext/2.7/action_policy/policy/pre_check.rb
-- lib/.rbnext/2.7/action_policy/rails/scope_matchers/action_controller_params.rb
-- lib/.rbnext/2.7/action_policy/rails/scope_matchers/active_record.rb
-- lib/.rbnext/2.7/action_policy/rspec/be_authorized_to.rb
-- lib/.rbnext/2.7/action_policy/rspec/have_authorized_scope.rb
-- lib/.rbnext/2.7/action_policy/utils/pretty_print.rb
 - lib/.rbnext/3.0/action_policy/behaviours/policy_for.rb
 - lib/.rbnext/3.0/action_policy/behaviours/thread_memoized.rb
 - lib/.rbnext/3.0/action_policy/ext/policy_cache_key.rb
@@ -152,6 +143,8 @@ files:
 - lib/.rbnext/3.0/action_policy/policy/execution_result.rb
 - lib/.rbnext/3.0/action_policy/policy/pre_check.rb
 - lib/.rbnext/3.0/action_policy/policy/reasons.rb
+- lib/.rbnext/3.0/action_policy/rails/scope_matchers/action_controller_params.rb
+- lib/.rbnext/3.0/action_policy/rails/scope_matchers/active_record.rb
 - lib/.rbnext/3.0/action_policy/rspec/be_an_alias_of.rb
 - lib/.rbnext/3.0/action_policy/rspec/be_authorized_to.rb
 - lib/.rbnext/3.0/action_policy/rspec/have_authorized_scope.rb
@@ -169,6 +162,13 @@ files:
 - lib/.rbnext/3.2/action_policy/rspec/be_authorized_to.rb
 - lib/.rbnext/3.2/action_policy/rspec/have_authorized_scope.rb
 - lib/.rbnext/3.2/action_policy/utils/suggest_message.rb
+- lib/.rbnext/3.4/action_policy/behaviours/policy_for.rb
+- lib/.rbnext/3.4/action_policy/i18n.rb
+- lib/.rbnext/3.4/action_policy/policy/cache.rb
+- lib/.rbnext/3.4/action_policy/policy/pre_check.rb
+- lib/.rbnext/3.4/action_policy/rspec/be_authorized_to.rb
+- lib/.rbnext/3.4/action_policy/rspec/have_authorized_scope.rb
+- lib/.rbnext/3.4/action_policy/utils/pretty_print.rb
 - lib/action_policy.rb
 - lib/action_policy/authorizer.rb
 - lib/action_policy/base.rb
@@ -225,6 +225,7 @@ files:
 - lib/generators/rspec/templates/policy_spec.rb.tt
 - lib/generators/test_unit/policy_generator.rb
 - lib/generators/test_unit/templates/policy_test.rb.tt
+- lib/ruby_lsp/action_policy/addon.rb
 homepage: https://github.com/palkan/action_policy
 licenses:
 - MIT
@@ -234,7 +235,7 @@ metadata:
   documentation_uri: https://actionpolicy.evilmartians.io/
   homepage_uri: https://actionpolicy.evilmartians.io/
   source_code_uri: http://github.com/palkan/action_policy
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -250,7 +251,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.4.19
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Authorization framework for Ruby/Rails application
 test_files: []