action_network_rest 1.1.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1917a4b296e7224c3241742af15375a1c07f8ac6ec45131aaa9e6422b1dc0564
-  data.tar.gz: ed2cc9463b6b0f5a9621ecf1dde0873fa475ab88e9b15de6630fa0640dabc0c9
+  metadata.gz: 6c17dbaa0d2bb98ff782e6935fd6f2be4487615ed22723cf852c2e38a423e390
+  data.tar.gz: 075b4fd3bc99898d124a0d8126257eabb5034c149795b06f52e45c18b555d597
 SHA512:
-  metadata.gz: 3607a4d26767b60bc1615f7e7ce080b9f5b208461faf8c2c3707f8014fb41074eed92600340c8ff12a5204f64505a05cf3a99a395af74bb239d7f2e02ca6f374
-  data.tar.gz: 7226aaf245a03715d265ed29ac04147ecbef67244bb905d63d667a90256c53d28b886475b3cf69c684b137f6e4f183864156896c26ef1127deed6e3392e4025d
+  metadata.gz: ffff94abab45bedc8a263ab2aff6614390c065ceea0d098ba3f517d738733dd831e6030d460e9162e1fbb3cd52230d4c2bda159923439d9165b2ca49f7626b23
+  data.tar.gz: c69a7c00e2a31a22171df146af077f34a18ba710c7cfc6cae61beea2c06778e9d4328635a00825d84536ccf7c0df1e064fdfb7dc5b6d0c902cb5208a4b43c1e5

data/CHANGELOG.md

@@ -1,7 +1,15 @@
 # Changelog
 
+## [2.0.0] - 2026-06-30
+
+### Breaking Changes
+- When a response has a 403 status, now raises AuthorizationError. (Previously, ResponseError was raised in this case.)
+
+### Other Changes
+- Added a new error class ServerError, as a subclass of ResponseError. 5xx response statuses now raise this more specific type of error.
+
 ## [1.1.0] - 2026-02-11
 
 ### Breaking Changes
 - Now requires Faraday 2.x (previously supported Faraday 1.x)
-- Dropped support for Ruby versions older than 3.3. Officially supported versions are Ruby 3.3, 3.4, and 4.0.
+- Dropped support for Ruby versions older than 3.3. Officially supported versions are Ruby 3.3, 3.4, and 4.0.

data/lib/action_network_rest/response/raise_error.rb

@@ -3,34 +3,42 @@
 module ActionNetworkRest
   module Response
     class RaiseError < Faraday::Middleware
-      # rubocop:disable Style/GuardClause
       def on_complete(response)
         status_code = response[:status].to_i
+        return unless (400...600).cover?(status_code)
 
-        if (400...600).cover? status_code
-          if status_code == 400 && response[:body].include?('error')
-            error_hsh = JSON.parse(response[:body])
-            error_message = error_hsh['error']
-
-            if error_message == 'You must specify a valid person id'
-              raise MustSpecifyValidPersonId, error_message(response)
-            end
-          elsif status_code == 404
-            raise NotFoundError, error_message(response)
-          elsif status_code == 429
-            raise TooManyRequests, error_message(response)
-          else
-            raise ResponseError, error_message(response)
-          end
-        end
+        raise error_class_for(status_code, response), error_message(response)
       end
-      # rubocop:enable Style/GuardClause
 
       def error_message(response)
         "#{response[:method].to_s.upcase} #{response[:url]}: #{response[:status]} \n\n #{response[:body]}"
       end
+
+      private
+
+      def error_class_for(status_code, response)
+        case status_code
+        when 400 then bad_request_error_class(response)
+        when 403 then AuthorizationError
+        when 404 then NotFoundError
+        when 429 then TooManyRequests
+        when 500..599 then ServerError
+        else ResponseError
+        end
+      end
+
+      def bad_request_error_class(response)
+        return ResponseError unless response[:body].include?('error')
+
+        # A few specific 400 messages map to a dedicated exception; any other
+        # 400 still raises the generic ResponseError.
+        body_error = JSON.parse(response[:body])['error']
+        body_error == 'You must specify a valid person id' ? MustSpecifyValidPersonId : ResponseError
+      end
     end
 
+    class AuthorizationError < StandardError; end
+
     class MissingActionNetworkId < StandardError; end
 
     class MustSpecifyValidPersonId < StandardError; end
@@ -39,6 +47,11 @@ module ActionNetworkRest
 
     class ResponseError < StandardError; end
 
+    # Raised for 5xx responses. Subclasses ResponseError so existing rescues
+    # continue to catch server errors while allowing callers to distinguish
+    # transient server-side failures (worth retrying) from client errors.
+    class ServerError < ResponseError; end
+
     class TooManyRequests < StandardError; end
 
     class UsedAllRequestTries < StandardError; end

data/lib/action_network_rest/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActionNetworkRest
-  VERSION = '1.1.0'
+  VERSION = '2.0.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: action_network_rest
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Grey Moore