action_kit_rest 0.4.2 → 0.4.6

data/spec/lib/action_kit_rest/response/collection_spec.rb

@@ -1,26 +1,28 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-describe ActionKitRest::Response::Collection  do
-  let(:meta) { double() }
-  let(:objects) { double() }
+describe ActionKitRest::Response::Collection do
+  let(:meta) { double }
+  let(:objects) { double }
   subject { ActionKitRest::Response::Collection.new(meta, objects) }
 
   describe 'initialization' do
     it 'should set meta and objects' do
-      subject.meta.should == meta
-      subject.objects.should == objects
+      expect(subject.meta).to eq(meta)
+      expect(subject.objects).to eq(objects)
     end
   end
 
   describe 'each' do
     let(:item1) { double }
     let(:item2) { double }
-    let(:objects) { [ item1, item2 ] }
+    let(:objects) { [item1, item2] }
 
-    it "should return all collection items" do
-      subject.count.should == 2
-      subject.any? { |i| i == item1 }
-      subject.any? { |i| i == item2 }
+    it 'should return all collection items' do
+      expect(subject.count).to eq(2)
+      expect(subject.any? { |i| i == item1 }).to be_truthy
+      expect(subject.any? { |i| i == item2 }).to be_truthy
     end
   end
-end
+end

data/spec/lib/action_kit_rest/response/validation_error_spec.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe ActionKitRest::Response::ValidationError do
+  describe '#to_s' do
+    subject { ActionKitRest::Response::ValidationError.new(url: url, body: body) }
+
+    context 'with a normal URL and body' do
+      let(:url) { 'https://actionkit.example.com/rest/v1/page/1' }
+      let(:errors) { { 'zip' => 'invalid zip code' } }
+      let(:body) { { errors: errors }.to_json }
+
+      it 'should put information in the string' do
+        expect(subject.to_s).to eq "ActionKitRest::Response::ValidationError \n url: #{url} \n body: #{body} \n errors: #{errors.inspect}"
+      end
+    end
+
+    context 'with special characters in the body' do
+      let(:url) { 'https://actionkit.example.com/rest/v1/page/1' }
+      let(:errors) { { 'zip' => '☃' } }
+      let(:body) { { errors: errors }.to_json }
+
+      it 'should put information in the string' do
+        expect(subject.to_s).to eq "ActionKitRest::Response::ValidationError \n url: #{url} \n body: #{body} \n errors: #{errors.inspect}"
+      end
+    end
+
+    context 'with a body in ASCII-8BIT format' do
+      let(:url) { 'https://actionkit.example.com/rest/v1/page/1' }
+      let(:errors) { {'mailing_id' => ['לא הצלחנו לקשר בין מספר הזיהוי של רשימת הדיוור הזו לבין החשבון.']} }
+      let(:body) { { errors: errors }.to_json.b }
+
+      it 'should put information in the string' do
+        expect(subject.to_s).to eq "ActionKitRest::Response::ValidationError \n url: #{url} \n body: {\"errors\":#{errors.to_json}} \n errors: #{errors.inspect}"
+      end
+    end
+  end
+end

data/spec/lib/action_kit_rest/response/wrapper_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest::Response::Wrapper do
   describe 'initialization' do
     it "should be kind 'object' for objects" do
       body = double
-      response = double(:body => body)
+      response = double(body: body)
 
       wrapper = ActionKitRest::Response::Wrapper.new(response)
 
@@ -13,8 +15,8 @@ describe ActionKitRest::Response::Wrapper do
     end
 
     it "should be kind 'collection' for collections" do
-      body = double(:meta => '', :objects => [])
-      response = double(:body => body)
+      body = double(meta: '', objects: [])
+      response = double(body: body)
 
       wrapper = ActionKitRest::Response::Wrapper.new(response)
 
@@ -22,4 +24,4 @@ describe ActionKitRest::Response::Wrapper do
       wrapper.collection?.should be_truthy
     end
   end
-end
+end

data/spec/lib/action_kit_rest/user_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ActionKitRest::User do
@@ -11,16 +13,16 @@ describe ActionKitRest::User do
 
   subject { ActionKitRest.new(host: 'test.com') }
 
-  describe "retrieval" do
+  describe 'retrieval' do
     let(:request_path) { 'user/1/' }
 
     context 'without basic auth' do
       before(:each) do
-        stub_get(request_path).to_return(:body => body, :status => status,
-                                         :headers => {:content_type => "application/json; charset=utf-8"})
+        stub_get(request_path).to_return(body: body, status: status,
+                                         headers: { content_type: 'application/json; charset=utf-8' })
       end
 
-      describe ".get" do
+      describe '.get' do
         let(:status) { 200 }
 
         context 'without phones' do
@@ -36,9 +38,9 @@ describe ActionKitRest::User do
           let(:phone_body) { fixture('phone/object.json') }
 
           it 'should include phones' do
-            stub_get('phone/?user=1').to_return(:body => phone_body, :status => 200)
+            stub_get('phone/?user=1').to_return(body: phone_body, status: 200)
             expect(subject.user.get(1).phones.count).to eq 3
-            expect(subject.user.get(1).phones.map(&:phone)).to match_array(['7755555555', '7755555577', '310-310-3310'])
+            expect(subject.user.get(1).phones.map(&:phone)).to match_array(%w[7755555555 7755555577 310-310-3310])
           end
         end
       end
@@ -47,7 +49,7 @@ describe ActionKitRest::User do
         let(:body) { '' }
         let(:status) { 404 }
 
-        it "should raise an exception" do
+        it 'should raise an exception' do
           expect { subject.user.get(1) }.to raise_error(ActionKitRest::Response::NotFound)
         end
       end
@@ -59,8 +61,8 @@ describe ActionKitRest::User do
       subject { ActionKitRest.new(host: 'test.com', username: 'alice', password: 'somesecret') }
 
       before(:each) do
-        stub_get(request_path).with(basic_auth: ['alice', 'somesecret'])
-          .to_return(body: body, status: 200, headers: {content_type: "application/json; charset=utf-8"})
+        stub_get(request_path).with(basic_auth: %w[alice somesecret])
+                              .to_return(body: body, status: 200, headers: { content_type: 'application/json; charset=utf-8' })
       end
 
       it 'should return a user object' do

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec'
 require 'webmock/rspec'
 
@@ -16,11 +18,11 @@ RSpec.configure do |config|
   end
 
   config.mock_with :rspec do |mocks|
-    mocks.syntax = [:should, :expect]
+    mocks.syntax = %i[should expect]
   end
 
   config.expect_with :rspec do |c|
-    c.syntax = [:should, :expect]
+    c.syntax = %i[should expect]
   end
 end
 
@@ -37,11 +39,11 @@ def stub_put(path)
 end
 
 def stub_action_kit_request(method, path)
-  stub_request(method, 'https://test.com/rest/v1/' + path)
+  stub_request(method, "https://test.com/rest/v1/#{path}")
 end
 
 def fixture_path
-  File.expand_path("../fixtures", __FILE__)
+  File.expand_path('fixtures', __dir__)
 end
 
 def fixture(file)

data/spec/support/shared_contexts/stub_logger.rb

@@ -1,4 +1,6 @@
-shared_context "stub_logger" do
+# frozen_string_literal: true
+
+shared_context 'stub_logger' do
   before(:each) do
     logger = double
     allow(logger).to receive(:debug).and_return(true)
@@ -6,4 +8,4 @@ shared_context "stub_logger" do
     allow(ActionKitRest).to receive(:logger).and_return(logger)
     allow(Vertebrae::Base).to receive(:logger).and_return(logger)
   end
-end
+end

metadata

@@ -1,99 +1,105 @@
 --- !ruby/object:Gem::Specification
 name: action_kit_rest
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.6
 platform: ruby
 authors:
 - Nathan Woodhull
 - Diego Marcet
-- Jacinda Moore
+- Grey Moore
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-13 00:00:00.000000000 Z
+date: 2021-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: vertebrae
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '2.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '2.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: byebug
+  name: em-http-request
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 10.0.2
+        version: 1.1.5
     - - "<"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 10.0.2
+        version: 1.1.5
     - - "<"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: em-synchrony
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 1.0.6
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 1.0.6
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: eventmachine
   requirement: !ruby/object:Gem::Requirement
@@ -115,65 +121,61 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: em-synchrony
+  name: juwelier
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.6
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.6
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: em-http-request
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.5
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.5
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.7'
 - !ruby/object:Gem::Dependency
-  name: juwelier
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.9
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.9
-    - - "<"
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.3'
 description: Gem for interacting with the ActionKit API
 email: systems@controlshiftlabs.com
 executables: []
@@ -183,10 +185,11 @@ extra_rdoc_files:
 - README.md
 files:
 - ".document"
+- ".github/workflows/ci.yml"
 - ".rspec"
+- ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
-- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -244,6 +247,7 @@ files:
 - spec/lib/action_kit_rest/pages/event_campaign_page_spec.rb
 - spec/lib/action_kit_rest/pages/import_page_spec.rb
 - spec/lib/action_kit_rest/response/collection_spec.rb
+- spec/lib/action_kit_rest/response/validation_error_spec.rb
 - spec/lib/action_kit_rest/response/wrapper_spec.rb
 - spec/lib/action_kit_rest/user_spec.rb
 - spec/spec_helper.rb
@@ -267,7 +271,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.1
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: A wrapper for the ActionKit REST API

data/.travis.yml

@@ -1,3 +0,0 @@
-language: ruby
-rvm:
-  - "2.3.4"