action_kit_rest 0.4.0 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 995fff41c6ed27b3312687984f3e21393d612fb917ffb3ed57a4e98433f8aa8e
-  data.tar.gz: 64d389ebb6081dc92062d807dcdface85950faa49ad4f1c56e5b63517b68566e
+  metadata.gz: 719c1f9eff7913a9c74153afcd98ae22b046f641f7ad3a951d05650db38ccb08
+  data.tar.gz: 5bf33654f9fd0f7e8c3d305b35bf8864885e6f0b73bd9d8f183e96a295294cae
 SHA512:
-  metadata.gz: f0bd3a3ed3b45e291d767a50e6b81861e1b4d0faabd2eef87c51d3519bd230ea39238d47f2d0b61d07db1159a174d3b1c9c6ad60f90f786f1a9592ca23529324
-  data.tar.gz: 55fe5a33225fd90e4a37126bceb4f0c0a8ef3b6533fdaa7f8576105bbb9a951610986abdf52ca0ef526297da1519695a366c0d20de193c9612af5a365d3c2a31
+  metadata.gz: d949bf41d12791611c0893826515620f8e89630828709b8d6b22f64aaf11adc2bf549e3c2cb3166fd7d35429ca3073e42d9251dd1801c07770f879001610edbe
+  data.tar.gz: f2f7fed453b3518d7114b28b4d6b4f25fe1506a40ca8e0e24963ffa4eac1ce5dc5193beef908058677a8478277dd7c4b5533df403d5920391fb7b08474675cc9

data/.rubocop.yml

@@ -0,0 +1,26 @@
+AllCops:
+  DisabledByDefault: true
+
+Security:
+  Enabled: true
+
+Bundler/DuplicatedGem:
+  Enabled: true
+Bundler/InsecureProtocolSource:
+  Enabled: true
+Layout/IndentationStyle:
+  Enabled: true
+Layout/SpaceInsideRangeLiteral:
+  Enabled: true
+Lint:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Naming/AsciiIdentifiers:
+  Enabled: true
+Naming/ClassAndModuleCamelCase:
+  Enabled: true
+Naming/ConstantName:
+  Enabled: true
+Naming/FileName:
+  Enabled: true

data/.ruby-version

@@ -1 +1 @@
-2.5.3
+2.6.6

data/.travis.yml

@@ -1,3 +1,9 @@
 language: ruby
 rvm:
-  - "2.3.4"
+  - 2.6
+cache: bundler
+before_install:
+  - gem install bundler
+script:
+  - bundle exec rspec
+  - bundle exec rubocop

data/Gemfile

@@ -1,15 +1,17 @@
-source "http://rubygems.org"
+# frozen_string_literal: true
 
-gem 'vertebrae', '~> 0.5.0'
+source 'http://rubygems.org'
+
+gem 'vertebrae', '>= 0.6.0'
 
 group :development do
-  gem 'rspec', '~> 3.7'
-  gem 'webmock', '~> 3.3'
-  gem 'byebug', '>= 10.0.2', '<11.0'
   gem 'bundler', '>= 2.0', '<3.0'
-  gem 'eventmachine', '>=1.2.5', '<2.0'
-  gem 'em-synchrony', '>=1.0.6', '<2.0'
+  gem 'byebug'
   gem 'em-http-request', '>=1.1.5', '<2.0'
-  gem 'juwelier', '>=2.4.9', '<3.0'
+  gem 'em-synchrony', '>=1.0.6', '<2.0'
+  gem 'eventmachine', '>=1.2.5', '<2.0'
+  gem 'juwelier', git: 'https://github.com/flajann2/juwelier.git'
+  gem 'rspec', '~> 3.7'
+  gem 'rubocop'
+  gem 'webmock', '~> 3.3'
 end
-

data/Rakefile

@@ -1,47 +1,44 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 require 'rubygems'
 require 'bundler'
 begin
   Bundler.setup(:default, :development)
 rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
+  warn e.message
+  warn 'Run `bundle install` to install missing gems'
   exit e.status_code
 end
 require 'rake'
-require './lib/action_kit_rest/version.rb'
-
+require './lib/action_kit_rest/version'
 
 require 'juwelier'
 Juwelier::Tasks.new do |gem|
-  # gem is a Gem::Specification... see http://guides.rubygems.org/specification-reference/ for more options
-  gem.name = "action_kit_rest"
+  gem.name = 'action_kit_rest'
   gem.version = ActionKitRest::VERSION::STRING
-  gem.homepage = "http://github.com/controlshift/action_kit_rest"
-  gem.license = "MIT"
-  gem.summary = %Q{A wrapper for the ActionKit REST API}
-  gem.description = %Q{Gem for interacting with the ActionKit API}
-  gem.email = "systems@controlshiftlabs.com"
-  gem.authors = ["Nathan Woodhull", 'Diego Marcet', 'Jacinda Moore']
+  gem.homepage = 'http://github.com/controlshift/action_kit_rest'
+  gem.license = 'MIT'
+  gem.summary = %(A wrapper for the ActionKit REST API)
+  gem.description = %(Gem for interacting with the ActionKit API)
+  gem.email = 'systems@controlshiftlabs.com'
+  gem.authors = ['Nathan Woodhull', 'Diego Marcet', 'Grey Moore']
   # dependencies defined in Gemfile
 end
 Juwelier::RubygemsDotOrgTasks.new
 
-
 require 'rspec/core/rake_task'
 desc 'Default: run specs.'
-task :default => :spec
+task default: :spec
 
-desc "Run specs"
+desc 'Run specs'
 RSpec::Core::RakeTask.new do |t|
-  t.pattern = "./spec/**/*_spec.rb" # don't need this, it's default.
+  t.pattern = './spec/**/*_spec.rb' # don't need this, it's default.
   t.rspec_opts = '--color'
 end
 
 require 'rdoc/task'
 Rake::RDocTask.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
+  version = File.exist?('VERSION') ? File.read('VERSION') : ''
 
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title = "action_kit_rest #{version}"

data/action_kit_rest.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: action_kit_rest 0.4.0 ruby lib
+# stub: action_kit_rest 0.4.5 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "action_kit_rest".freeze
-  s.version = "0.4.0"
+  s.version = "0.4.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
-  s.authors = ["Nathan Woodhull".freeze, "Diego Marcet".freeze, "Jacinda Moore".freeze]
-  s.date = "2020-01-10"
+  s.authors = ["Nathan Woodhull".freeze, "Diego Marcet".freeze, "Grey Moore".freeze]
+  s.date = "2021-03-23"
   s.description = "Gem for interacting with the ActionKit API".freeze
   s.email = "systems@controlshiftlabs.com".freeze
   s.extra_rdoc_files = [
@@ -21,6 +21,7 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
     ".rspec",
+    ".rubocop.yml",
     ".ruby-gemset",
     ".ruby-version",
     ".travis.yml",
@@ -60,6 +61,7 @@ Gem::Specification.new do |s|
     "lib/action_kit_rest/version.rb",
     "spec/fixtures/action/event_create_action.json",
     "spec/fixtures/action/event_signup_action.json",
+    "spec/fixtures/allowed_user_field/get.json",
     "spec/fixtures/allowed_user_field/list.json",
     "spec/fixtures/allowed_user_field/list_filtered.json",
     "spec/fixtures/error.json",
@@ -80,6 +82,7 @@ Gem::Specification.new do |s|
     "spec/lib/action_kit_rest/pages/event_campaign_page_spec.rb",
     "spec/lib/action_kit_rest/pages/import_page_spec.rb",
     "spec/lib/action_kit_rest/response/collection_spec.rb",
+    "spec/lib/action_kit_rest/response/validation_error_spec.rb",
     "spec/lib/action_kit_rest/response/wrapper_spec.rb",
     "spec/lib/action_kit_rest/user_spec.rb",
     "spec/spec_helper.rb",
@@ -87,33 +90,46 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/controlshift/action_kit_rest".freeze
   s.licenses = ["MIT".freeze]
-  s.rubygems_version = "3.1.1".freeze
+  s.rubygems_version = "3.0.8".freeze
   s.summary = "A wrapper for the ActionKit REST API".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
-  end
 
-  if s.respond_to? :add_runtime_dependency then
-    s.add_runtime_dependency(%q<vertebrae>.freeze, ["~> 0.5.0"])
-    s.add_development_dependency(%q<rspec>.freeze, ["~> 3.7"])
-    s.add_development_dependency(%q<webmock>.freeze, ["~> 3.3"])
-    s.add_development_dependency(%q<byebug>.freeze, [">= 10.0.2", "< 11.0"])
-    s.add_development_dependency(%q<bundler>.freeze, [">= 2.0", "< 3.0"])
-    s.add_development_dependency(%q<eventmachine>.freeze, [">= 1.2.5", "< 2.0"])
-    s.add_development_dependency(%q<em-synchrony>.freeze, [">= 1.0.6", "< 2.0"])
-    s.add_development_dependency(%q<em-http-request>.freeze, [">= 1.1.5", "< 2.0"])
-    s.add_development_dependency(%q<juwelier>.freeze, [">= 2.4.9", "< 3.0"])
+    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
+      s.add_runtime_dependency(%q<vertebrae>.freeze, [">= 0.6.0"])
+      s.add_development_dependency(%q<bundler>.freeze, [">= 2.0", "< 3.0"])
+      s.add_development_dependency(%q<byebug>.freeze, [">= 0"])
+      s.add_development_dependency(%q<em-http-request>.freeze, [">= 1.1.5", "< 2.0"])
+      s.add_development_dependency(%q<em-synchrony>.freeze, [">= 1.0.6", "< 2.0"])
+      s.add_development_dependency(%q<eventmachine>.freeze, [">= 1.2.5", "< 2.0"])
+      s.add_development_dependency(%q<juwelier>.freeze, [">= 0"])
+      s.add_development_dependency(%q<rspec>.freeze, ["~> 3.7"])
+      s.add_development_dependency(%q<rubocop>.freeze, [">= 0"])
+      s.add_development_dependency(%q<webmock>.freeze, ["~> 3.3"])
+    else
+      s.add_dependency(%q<vertebrae>.freeze, [">= 0.6.0"])
+      s.add_dependency(%q<bundler>.freeze, [">= 2.0", "< 3.0"])
+      s.add_dependency(%q<byebug>.freeze, [">= 0"])
+      s.add_dependency(%q<em-http-request>.freeze, [">= 1.1.5", "< 2.0"])
+      s.add_dependency(%q<em-synchrony>.freeze, [">= 1.0.6", "< 2.0"])
+      s.add_dependency(%q<eventmachine>.freeze, [">= 1.2.5", "< 2.0"])
+      s.add_dependency(%q<juwelier>.freeze, [">= 0"])
+      s.add_dependency(%q<rspec>.freeze, ["~> 3.7"])
+      s.add_dependency(%q<rubocop>.freeze, [">= 0"])
+      s.add_dependency(%q<webmock>.freeze, ["~> 3.3"])
+    end
   else
-    s.add_dependency(%q<vertebrae>.freeze, ["~> 0.5.0"])
-    s.add_dependency(%q<rspec>.freeze, ["~> 3.7"])
-    s.add_dependency(%q<webmock>.freeze, ["~> 3.3"])
-    s.add_dependency(%q<byebug>.freeze, [">= 10.0.2", "< 11.0"])
+    s.add_dependency(%q<vertebrae>.freeze, [">= 0.6.0"])
     s.add_dependency(%q<bundler>.freeze, [">= 2.0", "< 3.0"])
-    s.add_dependency(%q<eventmachine>.freeze, [">= 1.2.5", "< 2.0"])
-    s.add_dependency(%q<em-synchrony>.freeze, [">= 1.0.6", "< 2.0"])
+    s.add_dependency(%q<byebug>.freeze, [">= 0"])
     s.add_dependency(%q<em-http-request>.freeze, [">= 1.1.5", "< 2.0"])
-    s.add_dependency(%q<juwelier>.freeze, [">= 2.4.9", "< 3.0"])
+    s.add_dependency(%q<em-synchrony>.freeze, [">= 1.0.6", "< 2.0"])
+    s.add_dependency(%q<eventmachine>.freeze, [">= 1.2.5", "< 2.0"])
+    s.add_dependency(%q<juwelier>.freeze, [">= 0"])
+    s.add_dependency(%q<rspec>.freeze, ["~> 3.7"])
+    s.add_dependency(%q<rubocop>.freeze, [">= 0"])
+    s.add_dependency(%q<webmock>.freeze, ["~> 3.3"])
   end
 end
 

data/lib/action_kit_rest.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'vertebrae'
 
 module ActionKitRest

data/lib/action_kit_rest/action.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class Action < Base
     def base_path
       'action'
     end
   end
-end
+end

data/lib/action_kit_rest/actions/event_create_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Actions
     class EventCreateAction < Action
@@ -9,11 +11,11 @@ module ActionKitRest
         ak_event_create_action = super
 
         # Aggregate fields parsed from referrenced entities' URI
-        ak_event_create_action.obj['event_id'] = ak_event_create_action.event.match(/\/rest\/v1\/event\/(\d*)\//)[1]
-        ak_event_create_action.obj['user_id'] = ak_event_create_action.user.match(/\/rest\/v1\/user\/(\d*)\//)[1]
+        ak_event_create_action.obj['event_id'] = ak_event_create_action.event.match(%r{/rest/v1/event/(\d*)/})[1]
+        ak_event_create_action.obj['user_id'] = ak_event_create_action.user.match(%r{/rest/v1/user/(\d*)/})[1]
 
         ak_event_create_action
       end
     end
   end
-end
+end

data/lib/action_kit_rest/actions/event_signup_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Actions
     class EventSignupAction < Action
@@ -9,11 +11,12 @@ module ActionKitRest
         ak_event_signup_action = super
 
         # Aggregate fields parsed from referrenced entities' URI
-        ak_event_signup_action.obj['event_signup_id'] = ak_event_signup_action.signup.match(/\/rest\/v1\/eventsignup\/(\d*)\//)[1]
-        ak_event_signup_action.obj['user_id'] = ak_event_signup_action.user.match(/\/rest\/v1\/user\/(\d*)\//)[1]
+        ak_event_signup_action.obj['event_signup_id'] =
+          ak_event_signup_action.signup.match(%r{/rest/v1/eventsignup/(\d*)/})[1]
+        ak_event_signup_action.obj['user_id'] = ak_event_signup_action.user.match(%r{/rest/v1/user/(\d*)/})[1]
 
         ak_event_signup_action
       end
     end
   end
-end
+end

data/lib/action_kit_rest/actions/unsubscribe_action.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   module Actions
     class UnsubscribeAction < Action
@@ -6,4 +8,4 @@ module ActionKitRest
       end
     end
   end
-end
+end

data/lib/action_kit_rest/allowed_user_field.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class AllowedUserField < Base
     def base_path
@@ -8,5 +10,13 @@ module ActionKitRest
       response = list(name: name)
       response.obj.first
     end
+
+    private
+
+    # We must override this, because the paths for allowed user fields use the name,
+    # not a numerical ID.
+    def extract_id_from_response(resp)
+      resp.response.headers['location'].split('/').last
+    end
   end
 end

data/lib/action_kit_rest/api.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class API < Vertebrae::API
-
     def request(*args)
-      ActionKitRest::Response::Wrapper.new( super(*args) )
+      ActionKitRest::Response::Wrapper.new(super(*args))
     end
 
     def post_json_request(path, params)
@@ -18,10 +19,10 @@ module ActionKitRest
     end
 
     def extract_data_from_params(params) # :nodoc:
-      if params.has_key?('data') && params['data'].present?
-        return params['data']
+      if params.key?('data') && params['data'].present?
+        params['data']
       else
-        return params
+        params
       end
     end
 
@@ -38,7 +39,8 @@ module ActionKitRest
         builder.use Faraday::Request::Multipart
         builder.use Faraday::Request::UrlEncoded
         if connection.configuration.authenticated?
-          builder.use Faraday::Request::BasicAuthentication, connection.configuration.username, connection.configuration.password
+          builder.use Faraday::Request::BasicAuthentication, connection.configuration.username,
+                      connection.configuration.password
         end
 
         builder.use Faraday::Response::Logger if ENV['DEBUG']
@@ -46,7 +48,7 @@ module ActionKitRest
         builder.use FaradayMiddleware::Mashify
         builder.use FaradayMiddleware::ParseJson
 
-        builder.use  ActionKitRest::Response::RaiseError
+        builder.use ActionKitRest::Response::RaiseError
         builder.adapter connection.configuration.adapter
       end
     end

data/lib/action_kit_rest/base.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
+
 module ActionKitRest
   class Base < Vertebrae::Model
-
     def list(filters = {})
       client.get_request(normalized_base_path, filters)
     end
@@ -31,11 +32,11 @@ module ActionKitRest
     end
 
     def extract_id_from_response(resp)
-      extract_id_from_location(resp.response.headers["location"])
+      extract_id_from_location(resp.response.headers['location'])
     end
 
     def extract_id_from_location(location)
-      location.scan(/\/(\d+)\/$/).first.first
+      location.scan(%r{/(\d+)/$}).first.first
     end
   end
-end
+end

data/lib/action_kit_rest/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'action_kit_rest/api'
 
 module ActionKitRest
@@ -9,19 +11,19 @@ module ActionKitRest
       self.clients = {}
     end
 
-    [:import, :signup, :donation, :unsubscribe, :event_campaign].each do |page_type|
+    %i[import signup donation unsubscribe event_campaign].each do |page_type|
       define_method "#{page_type}_page" do
         clients["#{page_type}_page"] ||= ("ActionKitRest::Pages::#{page_type.to_s.classify}Page".constantize).new(client: self)
       end
     end
 
-    [:unsubscribe, :event_create, :event_signup].each do |action|
+    %i[unsubscribe event_create event_signup].each do |action|
       define_method "#{action}_action" do
         clients["#{action}_action"] ||= ("ActionKitRest::Actions::#{action.to_s.classify}Action".constantize).new(client: self)
       end
     end
 
-    [:action, :page, :tag, :list, :user, :phone, :event, :language, :event_signup, :allowed_user_field].each do |thing|
+    %i[action page tag list user phone event language event_signup allowed_user_field].each do |thing|
       define_method thing do
         clients[thing] ||= ("ActionKitRest::#{thing.to_s.classify}".constantize).new(client: self)
       end