action_kit_rest 0.3.7 → 0.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8edd438498d9c58a5a841f4a4c3e6cdf60332afb1596053321b8e95880657cea
-  data.tar.gz: '048d66263cd0792e599aec8a79553bfe6068ab3c85bdfdee192258130792cb3a'
+  metadata.gz: 317f12658a694714e0daa94fce192f265b89f4e929e952e9a3ca2282564342a0
+  data.tar.gz: 3fa2bf0508101bb095b92fb48f24267f1ccfa2358194fc6c95463a8d8755293a
 SHA512:
-  metadata.gz: 908a607ba995531f20b4815458b2a83eec71393abbd5a59979cf85e24c3d0736585f2fa0918c399e194abc96b2273058d707bf90ba79c8a4e870ac593cb128f4
-  data.tar.gz: 1247bddf9d8d0ee0fa4a9ffbf6ea7b9cea15c34e8540838991ba17c238fef6a745b38502161251aa460853ad9482ea72166a8a4bdfa7a69ea1ef5812e424975e
+  metadata.gz: 8e305d2038f0d79db110442bda003084f4fc06d064d14a9c25353d072f4785228c8f88da18a6c51ce25db48cc3c1d130c6f354a457340fb5f2658f32c30043b5
+  data.tar.gz: bc614ab72455c91988e262086647207d4925d3e0139a74ec912f5279117e2d639e546a4e3b7f5e93bdba136280c96971f0971a9d8121d8db8a633f91c4872c10

data/action_kit_rest.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: action_kit_rest 0.3.7 ruby lib
+# stub: action_kit_rest 0.3.8 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "action_kit_rest".freeze
-  s.version = "0.3.7"
+  s.version = "0.3.8"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Nathan Woodhull".freeze, "Diego Marcet".freeze, "Jacinda Moore".freeze]
-  s.date = "2018-12-04"
+  s.date = "2018-12-05"
   s.description = "Gem for interacting with the ActionKit API".freeze
   s.email = "systems@controlshiftlabs.com".freeze
   s.extra_rdoc_files = [

data/lib/action_kit_rest/api.rb

@@ -37,7 +37,9 @@ module ActionKitRest
       connection.stack do |builder|
         builder.use Faraday::Request::Multipart
         builder.use Faraday::Request::UrlEncoded
-        builder.use Vertebrae::Request::BasicAuth, connection.configuration.authentication if connection.configuration.authenticated?
+        if connection.configuration.authenticated?
+          builder.use Faraday::Request::BasicAuthentication, connection.configuration.username, connection.configuration.password
+        end
 
         builder.use Faraday::Response::Logger if ENV['DEBUG']
 

data/lib/action_kit_rest/version.rb

@@ -2,7 +2,7 @@ module ActionKitRest
   module VERSION
     MAJOR = 0
     MINOR = 3
-    PATCH = 7
+    PATCH = 8
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.')

data/spec/lib/action_kit_rest/user_spec.rb

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
 describe ActionKitRest::User do
-  before(:each) do
-    @actionkit = ActionKitRest.new(host: 'test.com')
-
+  before :each do
     logger = double
     logger.stub(:debug).and_return(true)
 
@@ -11,45 +9,63 @@ describe ActionKitRest::User do
     Vertebrae::Base.stub(:logger).and_return(logger)
   end
 
+  subject { ActionKitRest.new(host: 'test.com') }
 
   describe "retrieval" do
     let(:request_path) { 'user/1/' }
 
-    before(:each) do
-      stub_get(request_path).to_return(:body => body, :status => status,
-                                       :headers => {:content_type => "application/json; charset=utf-8"})
-    end
+    context 'without basic auth' do
+      before(:each) do
+        stub_get(request_path).to_return(:body => body, :status => status,
+                                         :headers => {:content_type => "application/json; charset=utf-8"})
+      end
 
-    describe ".get" do
-      let(:status) { 200 }
+      describe ".get" do
+        let(:status) { 200 }
 
-      context 'without phones' do
-        let(:body) { fixture('user/object_without_phones.json') }
+        context 'without phones' do
+          let(:body) { fixture('user/object_without_phones.json') }
 
-        it 'should return a user object' do
-          expect(@actionkit.user.get(1).email).to eq 'walkers@wawd.com'
+          it 'should return a user object' do
+            expect(subject.user.get(1).email).to eq 'walkers@wawd.com'
+          end
+        end
+
+        context 'with phones' do
+          let(:body) { fixture('user/object_with_phones.json') }
+          let(:phone_body) { fixture('phone/object.json') }
+
+          it 'should include phones' do
+            stub_get('phone/?user=1').to_return(:body => phone_body, :status => 200)
+            expect(subject.user.get(1).phones.count).to eq 3
+            expect(subject.user.get(1).phones.map(&:phone)).to match_array(['7755555555', '7755555577', '310-310-3310'])
+          end
         end
       end
 
-      context 'with phones' do
-        let(:body) { fixture('user/object_with_phones.json') }
-        let(:phone_body) { fixture('phone/object.json') }
+      describe 'user not found' do
+        let(:body) { '' }
+        let(:status) { 404 }
 
-        it 'should include phones' do
-          stub_get('phone/?user=1').to_return(:body => phone_body, :status => 200)
-          expect(@actionkit.user.get(1).phones.count).to eq 3
-          expect(@actionkit.user.get(1).phones.map(&:phone)).to match_array(['7755555555', '7755555577', '310-310-3310'])
+        it "should raise an exception" do
+          expect { subject.user.get(1) }.to raise_error(ActionKitRest::Response::NotFound)
         end
       end
     end
 
-    describe 'user not found' do
-      let(:body) { '' }
-      let(:status) { 404 }
+    context 'with basic auth' do
+      let(:body) { fixture('user/object_without_phones.json') }
+
+      subject { ActionKitRest.new(host: 'test.com', username: 'alice', password: 'somesecret') }
+
+      before(:each) do
+        stub_get(request_path).with(basic_auth: ['alice', 'somesecret'])
+          .to_return(body: body, status: 200, headers: {content_type: "application/json; charset=utf-8"})
+      end
 
-      it "should raise an exception" do
-        expect { @actionkit.user.get(1) }.to raise_error(ActionKitRest::Response::NotFound)
+      it 'should return a user object' do
+        expect(subject.user.get(1).email).to eq 'walkers@wawd.com'
       end
     end
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: action_kit_rest
 version: !ruby/object:Gem::Version
-  version: 0.3.7
+  version: 0.3.8
 platform: ruby
 authors:
 - Nathan Woodhull
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-04 00:00:00.000000000 Z
+date: 2018-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: vertebrae