action_form 0.5.1 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d93e3e3b61abdc0ceb51759d16f352819d45ccbe1667998484473934da50ff2
-  data.tar.gz: 5f35ee9cc4f39a5ae05eaa445f3f230deef097089bfc88853acab530241ec0f9
+  metadata.gz: 30972262846891f251c02bb292dd4ba8043210edfd6c629ebf944a60eff8ae96
+  data.tar.gz: 4a28bdcb8db7cf0ceefb406b310f12dcf4e123ea686ff0d939a7204adc5d857c
 SHA512:
-  metadata.gz: cbfb9b48199cda2dc7ca78c368c58ecf3628fe5ef508f37e1dc7bfe4a4d3c9a6506ad210552c20e1575e6c50dfc3bac2d08512e3c4d70e9b296dfd9f2819b708
-  data.tar.gz: c71f8a0fc1c8aa5967f25d5f56702da3bccfa246ca0eae947d80403b80dcb0d46ce75e0a076b41976750e37bccdf4b1b99eac933eca595a3b3a824293a9b82f4
+  metadata.gz: 3f243e0ea21d55689b99cb73a320bf78ecb4dc57d97f896ee6a9d44991d9fb08bfefefeb84fa1df44be078bb6636be59116fd822e65282fe459535f203311762
+  data.tar.gz: af7ca8c553f37de8ffdbdb4febcd4b65aee352b3b2a19ad29155f59b15f13e244ef3cf3d0b84bdc2d09b903f7bc5dbdc19d8eacd0aa34736f48e3be6c2fb3add

data/README.md

@@ -627,7 +627,7 @@ ActionForm includes a composition system that allows form components (elements,
 
 #### **How Composition Works**
 
-When you create a form, all nested elements and subforms automatically have access to their owner through the `owner` accessor. Methods called on elements or subforms that are not defined locally are automatically delegated up the ownership chain, allowing you to access methods from the parent form or a custom host object.
+When you create a form, all nested elements and subforms automatically have access to their owner through the `owner` accessor. To delegate methods to the owner, you must prefix method calls with `owner_`. The `owner_` prefix is automatically stripped, and the method is then searched for on the ownership chain, allowing you to access methods from the parent form or a custom host object.
 
 #### **Automatic Ownership Chain**
 
@@ -639,9 +639,9 @@ class ProductForm < ActionForm::Base
     input(type: :text)
     output(type: :string)
 
-    # This method can call methods on the owner (ProductForm)
+    # Use owner_ prefix to delegate to owner's method
     def render?
-      name_render?  # Delegates to owner.name_render?
+      owner_name_render?  # Delegates to owner.name_render?
     end
   end
 
@@ -652,12 +652,12 @@ class ProductForm < ActionForm::Base
         output(type: :string)
 
         def render?
-          variants_name_render?  # Delegates to owner.variants_name_render?
+          owner_variants_name_render?  # Delegates to owner.variants_name_render?
         end
       end
 
       def render?
-        variants_subform_render?  # Delegates to owner.variants_subform_render?
+        owner_variants_subform_render?  # Delegates to owner.variants_subform_render?
       end
     end
   end
@@ -668,12 +668,12 @@ class ProductForm < ActionForm::Base
       output(type: :string)
 
       def render?
-        manufacturer_name_render?  # Delegates to owner.manufacturer_name_render?
+        owner_manufacturer_name_render?  # Delegates to owner.manufacturer_name_render?
       end
     end
   end
 
-  # Methods accessible by nested components
+  # Methods accessible by nested components via owner_ prefix
   def name_render?
     true
   end
@@ -725,7 +725,7 @@ class ProductForm < ActionForm::Base
     output(type: :string)
 
     def render?
-      name_render?  # Calls HostObject#name_render?
+      owner_name_render?  # Calls HostObject#name_render? via owner_ prefix
     end
   end
 
@@ -736,7 +736,7 @@ class ProductForm < ActionForm::Base
         output(type: :string)
 
         def render?
-          variants_name_render?  # Calls HostObject#variants_name_render?
+          owner_variants_name_render?  # Calls HostObject#variants_name_render?
         end
       end
 
@@ -745,12 +745,12 @@ class ProductForm < ActionForm::Base
         output(type: :float)
 
         def render?
-          variants_price_render?  # Calls HostObject#variants_price_render?
+          owner_variants_price_render?  # Calls HostObject#variants_price_render?
         end
       end
 
       def render?
-        variants_subform_render?  # Calls HostObject#variants_subform_render?
+        owner_variants_subform_render?  # Calls HostObject#variants_subform_render?
       end
     end
   end
@@ -761,7 +761,7 @@ class ProductForm < ActionForm::Base
       output(type: :string)
 
       def render?
-        manufacturer_name_render?  # Calls HostObject#manufacturer_name_render?
+        owner_manufacturer_name_render?  # Calls HostObject#manufacturer_name_render?
       end
     end
   end
@@ -775,7 +775,7 @@ form = ProductForm.new(object: product, owner: host)
 
 #### **Ownership Chain Traversal**
 
-The composition system supports multi-level ownership chains. When a method is called on an element or subform, it searches up the ownership chain until it finds the method:
+The composition system supports multi-level ownership chains. When a method is called with the `owner_` prefix on an element or subform, it searches up the ownership chain until it finds the method:
 
 ```ruby
 class GrandparentForm < ActionForm::Base
@@ -795,18 +795,19 @@ class ChildForm < ActionForm::Base
     input(type: :text)
 
     def render?
-      shared_helper  # Will find ParentForm#shared_helper first
+      owner_shared_helper  # Will find ParentForm#shared_helper first
     end
   end
 end
 
 # If ChildForm has ParentForm as owner, and ParentForm has GrandparentForm as owner:
-# The method lookup order is: ChildForm -> ParentForm -> GrandparentForm
+# The method lookup order is: ParentForm -> GrandparentForm
+# Note: Methods must be prefixed with owner_ to trigger delegation
 ```
 
 #### **Accessing Owner Directly**
 
-You can access the owner directly using the `owner` accessor:
+You can access the owner directly using the `owner` accessor. However, for delegation, it's recommended to use the `owner_` prefix pattern:
 
 ```ruby
 class ProductForm < ActionForm::Base
@@ -815,15 +816,26 @@ class ProductForm < ActionForm::Base
     output(type: :string)
 
     def disabled?
-      # Access owner's methods directly
-      owner.current_user && !owner.current_user.admin?
+      # Preferred: Use owner_ prefix for delegation
+      owner_is_discount_disabled?
+
+      # Alternative: Direct access via owner accessor (requires owner to be set)
+      # owner.current_user && !owner.current_user.admin?
     end
 
     def placeholder
-      owner.discount_placeholder_text
+      # Preferred: Use owner_ prefix
+      owner_discount_placeholder_text
+
+      # Alternative: Direct access
+      # owner.discount_placeholder_text
     end
   end
 
+  def is_discount_disabled?
+    current_user && !current_user.admin?
+  end
+
   def current_user
     @current_user ||= User.find(session[:user_id])
   end
@@ -834,6 +846,10 @@ class ProductForm < ActionForm::Base
 end
 ```
 
+**When to use each approach:**
+- **`owner_method_name`**: Recommended for delegation - automatically searches the ownership chain
+- **`owner.method_name`**: Use when you need direct access and the owner is guaranteed to be set, or when chaining methods with safe navigation (`owner.current_user&.admin?`)
+
 #### **Ownership Hierarchy**
 
 The ownership hierarchy is automatically established as follows:
@@ -855,10 +871,15 @@ class OrderForm < ActionForm::Base
     output(type: :string)
 
     def render?
-      owner.current_user&.admin?
+      # Use owner_ prefix to delegate to owner method
+      owner_can_render_admin_notes?
     end
   end
 
+  def can_render_admin_notes?
+    current_user&.admin?
+  end
+
   def current_user
     @current_user
   end
@@ -873,7 +894,8 @@ class RegistrationForm < ActionForm::Base
     output(type: :string)
 
     def disabled?
-      owner.email_locked?
+      # Delegate to owner's email_locked? method
+      owner_email_locked?
     end
   end
 
@@ -882,7 +904,7 @@ class RegistrationForm < ActionForm::Base
     output(type: :string)
 
     def disabled?
-      owner.email_locked?
+      owner_email_locked?
     end
   end
 
@@ -902,13 +924,14 @@ class SettingsForm < ActionForm::Base
         output(type: :bool)
 
         def render?
-          owner.feature_enabled?(:advanced_settings)
+          # Delegate with owner_ prefix
+          owner_feature_enabled?(:advanced_settings)
         end
       end
     end
 
     def render?
-      owner.feature_enabled?(:advanced_settings)
+      owner_feature_enabled?(:advanced_settings)
     end
   end
 

data/lib/action_form/composition.rb

@@ -20,22 +20,27 @@ module ActionForm
 
     module InstanceMethods # rubocop:disable Style/Documentation
       def method_missing(name, *attrs, **kwargs, &block)
-        if (handler = owners_chain.lazy.detect { |o| o.public_methods.include?(name) })
-          handler.public_send(name, *attrs, **kwargs, &block)
-        else
-          super
-        end
+        return super unless name.to_s.start_with?("owner_")
+
+        owner_method = name.to_s.sub("owner_", "").to_sym
+        return super unless (handler = owners_chain.detect { |o| o.respond_to?(owner_method) })
+
+        handler.public_send(owner_method, *attrs, **kwargs, &block)
       end
 
-      def respond_to_missing?(method_name, _include_private = false)
-        public_methods.detect { |m| m == :owner } || super
+      def respond_to_missing?(method_name, include_private = false)
+        return super unless method_name.to_s.start_with?("owner_")
+
+        owners_chain.any? { |o| o.respond_to?(method_name.to_s.sub("owner_", "").to_sym, include_private) }
       end
 
+      private
+
       def owners_chain
-        obj = self
-        Enumerator.new do |y|
-          y << obj = obj.owner while obj.public_methods.include?(:owner)
-        end
+        @owners_chain ||= Enumerator.new do |y|
+          obj = self
+          y << obj = obj.owner while obj.respond_to?(:owner)
+        end.lazy
       end
     end
   end

data/lib/action_form/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActionForm
-  VERSION = "0.5.1"
+  VERSION = "0.5.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: action_form
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.3
 platform: ruby
 authors:
 - Andrii Baran