action_controller_tweaks 0.3.1 → 0.3.2

data/.travis.yml

@@ -1,14 +1,15 @@
+# Send builds to container-based infrastructure
+# http://docs.travis-ci.com/user/workers/container-based-infrastructure/
+sudo: false
 language: ruby
 cache:
 - bundler
 rvm:
-  - 1.9.3
-  - 2.0
-  - 2.1
-  - 2.2
+  - 2.1.10
+  - 2.2.6
+  - 2.3.3
   - ruby-head
 gemfile:
-  - gemfiles/rails_3_2.gemfile
   - gemfiles/rails_4_0.gemfile
   - gemfiles/rails_4_1.gemfile
   - gemfiles/rails_4_2.gemfile
@@ -16,4 +17,9 @@ matrix:
   fast_finish: true
   allow_failures:
     - rvm: ruby-head
+  include:
+  - rvm: 2.3.3
+    gemfile: gemfiles/rails_5_0.gemfile
+  - rvm: ruby-head
+    gemfile: gemfiles/rails_5_0.gemfile
 

data/Appraisals

@@ -1,32 +1,32 @@
 
-appraise "rails_3_2" do
-  version = "~> 3.2.20"
-  gem 'activesupport', version
-  gem 'actionpack', version
-  gem 'activerecord', version
-  gem 'railties', version
-end
-
 appraise "rails_4_0" do
   version = "~> 4.0.12"
-  gem 'activesupport', version
-  gem 'actionpack', version
-  gem 'activerecord', version
-  gem 'railties', version
+  gem "activesupport", version
+  gem "actionpack", version
+  gem "activerecord", version
+  gem "railties", version
 end
 
 appraise "rails_4_1" do
   version = "~> 4.1.8"
-  gem 'activesupport', version
-  gem 'actionpack', version
-  gem 'activerecord', version
-  gem 'railties', version
+  gem "activesupport", version
+  gem "actionpack", version
+  gem "activerecord", version
+  gem "railties", version
 end
 
 appraise "rails_4_2" do
   version = "~> 4.2.0"
-  gem 'activesupport', version
-  gem 'actionpack', version
-  gem 'activerecord', version
-  gem 'railties', version
+  gem "activesupport", version
+  gem "actionpack", version
+  gem "activerecord", version
+  gem "railties", version
+end
+
+appraise "rails_5_0" do
+  version = "~> 5.0.0"
+  gem "activesupport", version
+  gem "actionpack", version
+  gem "activerecord", version
+  gem "railties", version
 end

data/CHANGELOG.md

@@ -1,19 +1,78 @@
-### Changelog
+# Change Log
+All notable changes to this project will be documented in this file.
+This project adheres to [Semantic Versioning](http://semver.org/).
 
 
-- **0.3.1**
-  - Fix session key still gets deleted when no option is set
-  - Fix options not passed to `#set_session` when `#set_session_with_expiry` is called
+## [Unreleased]
 
-- **0.3.0**
-  - Add method `#set_session_with_expiry`
-  - Add option `expires_in` and `expires_at` to #set_session
-  - Fix invalid header when using `#set_no_cache` for HTTP 1.0
-  - Raise error when reserved session key(s) is set through the provided method
+### Added
 
-- **0.2.0**
-  - Add option `expire_at` to #set_session
-  - Use semantic versioning
+- Nothing
+
+### Changed
+
+- Nothing
+
+### Fixed
+
+- Nothing
+
+
+## [0.3.2] - 2016-12-23
+
+### Changed
+
+- Call `before_action` on included class if exists
+- Add support for AR 5.0.x
+- Drop support for AR 3.x
+- Drop support for Ruby < 2.1
+
+### Fixed
+
+- Raise error if both `before_action` and `before_filter` does not exists
+
+
+## [0.3.1] - 2015-03-03
+
+### Fixed
+
+- Fix session key still gets deleted when no option is set
+- Fix options not passed to `#set_session` when `#set_session_with_expiry` is called
+
+
+## [0.3.0] - 2014-03-14
+
+### Added
+
+- Add method `#set_session_with_expiry`
+- Add option `expires_in` and `expires_at` to #set_session
+
+### Changed
+
+- Raise error when reserved session key(s) is set through the provided method
+
+### Fixed
+
+- Fix invalid header when using `#set_no_cache` for HTTP 1.0
+
+
+## [0.2.0] - 2014-01-17
+
+### Added
+
+- Add option `expire_at` to #set_session
+
+
+## 0.1 - 2013-08-30
+
+### Added
+
+- Initial Release
+
+
+[Unreleased]: https://github.com/AssetSync/asset_sync/compare/v0.3.2...HEAD
+[0.3.1]: https://github.com/AssetSync/asset_sync/compare/v0.3.1...v0.3.2
+[0.3.1]: https://github.com/AssetSync/asset_sync/compare/v0.3.0...v0.3.1
+[0.3.0]: https://github.com/AssetSync/asset_sync/compare/v0.2.0...v0.3.0
+[0.2.0]: https://github.com/AssetSync/asset_sync/compare/v0.1...v0.2.0
 
-- **0.1**
-  - Initial Release

data/Gemfile

@@ -1,2 +1,2 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 gemspec

data/README.md

@@ -1,10 +1,9 @@
-Action Controller Tweaks
-===========
+# Action Controller Tweaks
 
 ActionController is great, but could be better. Here are some tweaks for it.
 
-### Support
-===========
+
+## Status
 
 [![Build Status](http://img.shields.io/travis/PikachuEXE/action_controller_tweaks.svg?style=flat-square)](https://travis-ci.org/PikachuEXE/action_controller_tweaks)
 [![Gem Version](http://img.shields.io/gem/v/action_controller_tweaks.svg?style=flat-square)](http://badge.fury.io/rb/action_controller_tweaks)
@@ -12,15 +11,15 @@ ActionController is great, but could be better. Here are some tweaks for it.
 [![Coverage Status](http://img.shields.io/coveralls/PikachuEXE/action_controller_tweaks.svg?style=flat-square)](https://coveralls.io/r/PikachuEXE/action_controller_tweaks)
 [![Code Climate](http://img.shields.io/codeclimate/github/PikachuEXE/action_controller_tweaks.svg?style=flat-square)](https://codeclimate.com/github/PikachuEXE/action_controller_tweaks)
 
-Install
-=======
+
+## Installation
 
 ```ruby
 gem 'action_controller_tweaks'
 ```
 
-Usage
-=====
+
+## Usage
 
 Either include it in specific controller or just `ApplicationController`
 ```ruby

data/Rakefile

@@ -1,15 +1,18 @@
 require "appraisal"
 require "bundler"
 require "rspec/core/rake_task"
+require "rubocop/rake_task"
 
 Bundler::GemHelper.install_tasks
 
 RSpec::Core::RakeTask.new(:spec)
 
+RuboCop::RakeTask.new(:rubocop)
+
 if !ENV["APPRAISAL_INITIALIZED"] && !ENV["TRAVIS"]
   task :default do
     sh "appraisal install && rake appraisal spec"
   end
 else
-  task :default => :spec
+  task default: [:spec]
 end

data/action_controller_tweaks.gemspec

@@ -1,5 +1,5 @@
 # -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
+$LOAD_PATH.push File.expand_path("../lib", __FILE__)
 
 author_name = "PikachuEXE"
 gem_name = "action_controller_tweaks"
@@ -21,20 +21,19 @@ Gem::Specification.new do |s|
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_dependency "activesupport", ">= 3.2.0", "< 5.0.0"
-  s.add_dependency "actionpack", ">= 3.2.0", "< 5.0.0"
-
-
+  s.add_dependency "activesupport", ">= 4.0.0", "< 5.1.0"
+  s.add_dependency "actionpack", ">= 4.0.0", "< 5.1.0"
 
   s.add_development_dependency "bundler", ">= 1.0.0"
-  s.add_development_dependency "rake", ">= 0.9.2"
-  s.add_development_dependency "appraisal", "~> 1.0"
+  s.add_development_dependency "rake", "~> 10.0"
+  s.add_development_dependency "appraisal", "~> 2.0"
   s.add_development_dependency "rspec-rails", "~> 3.0"
   s.add_development_dependency "rspec-its", "~> 1.0"
-  s.add_development_dependency "activerecord", ">= 3.2.0", "< 5.0.0" # rspec-rails needs activerecord...
+  # rspec-rails needs activerecord...
+  s.add_development_dependency "activerecord", ">= 3.2.0", "< 5.0.0"
   s.add_development_dependency "sqlite3", ">= 1.3"
   s.add_development_dependency "database_cleaner", ">= 1.0"
   s.add_development_dependency "timecop", ">= 0.6"
@@ -42,6 +41,9 @@ Gem::Specification.new do |s|
   s.add_development_dependency "gem-release", ">= 0.7"
   # This is for rails < 4.1 on MRI 2.2 (and other later version I suppose)
   s.add_development_dependency "test-unit", ">= 3.0.0"
+  s.add_development_dependency "rubocop", "~> 0.30"
+
+  s.required_ruby_version = ">= 2.1.0"
 
   s.required_rubygems_version = ">= 1.4.0"
 end

data/gemfiles/rails_5_0.gemfile

@@ -0,0 +1,10 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activesupport", "~> 5.0.0"
+gem "actionpack", "~> 5.0.0"
+gem "activerecord", "~> 5.0.0"
+gem "railties", "~> 5.0.0"
+
+gemspec :path => "../"

data/lib/action_controller_tweaks.rb

@@ -1,8 +1,8 @@
-require 'active_support/concern'
+require "active_support/concern"
 
-require 'action_controller_tweaks/version'
-require 'action_controller_tweaks/caching'
-require 'action_controller_tweaks/session'
+require "action_controller_tweaks/version"
+require "action_controller_tweaks/caching"
+require "action_controller_tweaks/session"
 
 module ActionControllerTweaks
   extend ActiveSupport::Concern

data/lib/action_controller_tweaks/caching.rb

@@ -1,13 +1,17 @@
-require 'active_support/concern'
+require "active_support/concern"
 
 module ActionControllerTweaks
   module Caching
     extend ActiveSupport::Concern
 
     HEADERS = {
-      "Cache-Control" => "no-cache, no-store, max-age=0, must-revalidate, pre-check=0, post-check=0", # HTTP 1.1
-      "Pragma" => "no-cache", # HTTP 1.0
-      "Expires" => "Fri, 01 Jan 1990 00:00:00 GMT", # HTTP 1.0
+      # HTTP 1.1
+      "Cache-Control" => "no-cache, no-store, max-age=0, "\
+                         "must-revalidate, pre-check=0, post-check=0",
+      # HTTP 1.0
+      "Pragma"        => "no-cache",
+      # HTTP 1.0
+      "Expires"       => "Fri, 01 Jan 1990 00:00:00 GMT",
     }.freeze
 
     included do

data/lib/action_controller_tweaks/session.rb

@@ -1,5 +1,5 @@
-require 'active_support/concern'
-require 'active_support/time'
+require "active_support/concern"
+require "active_support/time"
 
 module ActionControllerTweaks
   module Session
@@ -10,6 +10,27 @@ module ActionControllerTweaks
       ReservedSessionKeyConflict = Class.new(ArgumentError)
     end
 
+    module OptionProcessor
+      def self.extract_expires_in(options)
+        expires_in = options.delete(:expires_in) || options.delete(:expire_in)
+        if expires_in && !expires_in.is_a?(Numeric)
+          fail InvalidOptionValue.new(:expires_in, expires_in, Numeric)
+        end
+        expires_in
+      end
+
+      def self.extract_expires_at(options)
+        expires_at = options.delete(:expires_at) || options.delete(:expire_at)
+        if expires_at && expires_at.respond_to?(:to_time)
+          expires_at = expires_at.to_time
+        end
+        if expires_at && !expires_at.is_a?(Time)
+          fail InvalidOptionValue.new(:expires_at, expires_at, Time)
+        end
+        expires_at
+      end
+    end
+
     RESERVED_SESSION_KEYS = %w( session_keys_to_expire )
     VALID_OPTION_KEYS = [
       :expires_in,
@@ -20,30 +41,46 @@ module ActionControllerTweaks
 
     class InvalidOptionValue < ArgumentError
       def self.new(option_key, options_value, expected_types)
-        super("option key `#{option_key}` should contain value with type(s): #{expected_types}, " +
+        super("option key `#{option_key}` should contain value with type(s): #{expected_types}, "\
           "but got <#{options_value.inspect}> (#{options_value.class})")
       end
     end
 
     included do
-      before_filter :delete_expired_session_keys
+      if respond_to?(:before_action)
+        before_action :_delete_expired_session_keys
+      elsif respond_to?(:before_filter)
+        before_filter :_delete_expired_session_keys
+      else
+        fail(
+          NotImplementedError,
+          "There is no `.before_action` nor `.before_filter` in this class",
+        )
+      end
 
       private
 
       # Set session just like `session[key] = value` but accept some options about expiry
       #
-      # @option expires_in [Integer] How long from now should the session value be expired
-      # @option expire_in [Integer] same as `expires_in`
-      # @option expires_at [Integer] What time should the session value be expired (using a time in the past would expire at next request)
-      # @option expire_at [Integer] same as `expires_at`
+      # @option expires_in [Integer]
+      #   How long from now should the session value be expired
+      # @option expire_in [Integer]
+      #   same as `expires_in`
+      # @option expires_at [Integer]
+      #   What time should the session value be expired
+      #   (using a time in the past would expire at next request)
+      # @option expire_at [Integer]
+      #   same as `expires_at`
       def set_session(key, value, options = {})
         if RESERVED_SESSION_KEYS.include?(key.to_s)
-          raise Errors::ReservedSessionKeyConflict.new, "you are trying to set #{value} to #{key}, but reserved by ActionControllerTweaks::Session"
+          fail Errors::ReservedSessionKeyConflict.new,
+            "you are trying to set #{value} to #{key}, "\
+            "but reserved by ActionControllerTweaks::Session"
         end
 
         session[key] = value
 
-        session[:session_keys_to_expire] = new_session_keys_to_expire(key, options)
+        session[:session_keys_to_expire] = _new_session_keys_to_expire(key, options)
       end
 
       # set value in session just like `set_session`, but checked option keys
@@ -51,30 +88,34 @@ module ActionControllerTweaks
       # @raise [ActionControllerTweaks::Session::Errors::InvalidOptionKeys]
       def set_session_with_expiry(key, value, options = {})
         option_keys = options.symbolize_keys.keys
-        required_option_key_present = option_keys.any? do |key|
-          VALID_OPTION_KEYS.include?(key)
+        required_option_key_present = option_keys.any? do |k|
+          VALID_OPTION_KEYS.include?(k)
         end
         invalid_option_key_absent = (option_keys - VALID_OPTION_KEYS.dup).empty?
-        (required_option_key_present && invalid_option_key_absent) or raise ActionControllerTweaks::Session::Errors::InvalidOptionKeys
+        unless required_option_key_present && invalid_option_key_absent
+          fail ActionControllerTweaks::Session::Errors::InvalidOptionKeys
+        end
 
         set_session(key, value, options)
       end
 
-      def delete_expired_session_keys
+      def _delete_expired_session_keys
         # Remove keys that are expired
         session_keys_to_expire.each do |key, expire_at_str|
-          begin
-            if Time.now > Time.parse(expire_at_str.to_s)
-              session.delete(key)
-              session_keys_to_expire.delete(key)
-            end
-          rescue
-            # Parse error
-            # Let's expire it to be safe
-            session.delete(key)
-            session_keys_to_expire.delete(key)
-          end
+          _delete_expired_session_key(key, expire_at_str)
+        end
+      end
+
+      def _delete_expired_session_key(key, expire_at_str)
+        if Time.now > Time.parse(expire_at_str.to_s)
+          session.delete(key)
+          session_keys_to_expire.delete(key)
         end
+      rescue
+        # Parse error
+        # Let"s expire it to be safe
+        session.delete(key)
+        session_keys_to_expire.delete(key)
       end
 
       def session_keys_to_expire
@@ -86,27 +127,15 @@ module ActionControllerTweaks
         session[:session_keys_to_expire]
       end
 
-      def new_session_keys_to_expire(key, options = {})
+      def _new_session_keys_to_expire(key, options = {})
         options.symbolize_keys!
 
         result = session_keys_to_expire
+        expires_in = OptionProcessor.extract_expires_in(options)
+        expires_at = OptionProcessor.extract_expires_at(options)
 
-        expires_in = options.delete(:expires_in) || options.delete(:expire_in)
-        expires_at = options.delete(:expires_at) || options.delete(:expire_at)
-
-        if expires_at && expires_at.respond_to?(:to_time)
-          expires_at = expires_at.to_time
-        end
-
-        raise InvalidOptionValue.new(:expires_in, expires_in, Numeric) if expires_in && !expires_in.is_a?(Numeric)
-        raise InvalidOptionValue.new(:expires_at, expires_at, Time) if expires_at && !expires_at.is_a?(Time)
-
-        if expires_in || expires_at
-          result[key] = if expires_in
-            expires_in.seconds.from_now
-          elsif expires_at
-            expires_at
-          end
+        if [expires_in, expires_at].any?
+          result[key] = expires_in ? expires_in.seconds.from_now : expires_at
         end
 
         result