action_controller_tweaks 0.3.0 → 0.3.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (26) hide show
  1. checksums.yaml +5 -5
  2. data/.gitignore +7 -1
  3. data/.travis.yml +18 -11
  4. data/Appraisals +40 -12
  5. data/CHANGELOG.md +101 -11
  6. data/Gemfile +1 -1
  7. data/README.md +12 -16
  8. data/Rakefile +2 -2
  9. data/action_controller_tweaks.gemspec +14 -10
  10. data/gemfiles/.bundle/config +2 -0
  11. data/gemfiles/rails_4_2.gemfile +11 -0
  12. data/gemfiles/rails_5_0.gemfile +11 -0
  13. data/gemfiles/rails_5_1.gemfile +10 -0
  14. data/gemfiles/rails_5_2.gemfile +10 -0
  15. data/gemfiles/rails_6_0.gemfile +10 -0
  16. data/lib/action_controller_tweaks.rb +4 -4
  17. data/lib/action_controller_tweaks/caching.rb +7 -4
  18. data/lib/action_controller_tweaks/session.rb +81 -47
  19. data/lib/action_controller_tweaks/version.rb +3 -1
  20. data/spec/action_controller_tweaks_spec.rb +464 -120
  21. data/spec/fixtures/application.rb +8 -5
  22. data/spec/fixtures/controllers.rb +7 -5
  23. data/spec/spec_helper.rb +35 -10
  24. metadata +96 -66
  25. data/gemfiles/rails3_2.gemfile +0 -9
  26. data/gemfiles/rails4_0.gemfile +0 -9
data/spec/fixtures/application.rb CHANGED
@@ -1,10 +1,13 @@
1
- require 'active_support/all'
2
- require 'action_controller'
3
- require 'action_dispatch'
1
+ require "active_support/all"
2
+ require "action_controller"
3
+ require "action_dispatch"
4
4
 
5
5
  module Rails
6
6
  class App
7
- def env_config; {} end
7
+ def env_config
8
+ {}
9
+ end
10
+
8
11
  def routes
9
12
  return @routes if defined?(@routes)
10
13
  @routes = ActionDispatch::Routing::RouteSet.new
@@ -18,4 +21,4 @@ module Rails
18
21
  def self.application
19
22
  @app ||= App.new
20
23
  end
21
- end
24
+ end
data/spec/fixtures/controllers.rb CHANGED
@@ -1,16 +1,18 @@
1
1
  class TestController < ActionController::Base
2
2
  include Rails.application.routes.url_helpers
3
3
 
4
- def render(*attributes); end
4
+ def render(*_attributes); end
5
5
  end
6
6
 
7
7
  class PostsController < TestController
8
8
  include ActionControllerTweaks
9
9
 
10
10
  def index
11
- if params[:no_cache]
12
- set_no_cache
13
- end
11
+ head(204)
12
+
13
+ set_no_cache if params[:no_cache]
14
14
  end
15
+ end
15
16
 
16
- end
17
+ class NotController
18
+ end
data/spec/spec_helper.rb CHANGED
@@ -1,23 +1,30 @@
1
1
  if ENV["TRAVIS"]
2
- require 'coveralls'
3
- Coveralls.wear!('rails')
2
+ require "coveralls"
3
+ Coveralls.wear!("rails")
4
4
  end
5
5
 
6
- require 'action_controller_tweaks'
6
+ require "action_controller_tweaks"
7
7
 
8
- require 'fixtures/application'
9
- require 'fixtures/controllers'
10
- require 'rspec/rails'
8
+ require "fixtures/application"
9
+ require "fixtures/controllers"
11
10
 
12
- require 'timecop'
13
- require 'logger'
11
+ require "rspec/rails"
12
+ require "rspec/its"
14
13
 
14
+ require "timecop"
15
+ require "logger"
16
+
17
+ # see https://github.com/rspec/rspec-rails/issues/1171
18
+ # prevent Test::Unit"s AutoRunner from executing during RSpec"s rake task
19
+ Test::Unit.run = true if defined?(Test::Unit) && Test::Unit.respond_to?(:run=)
15
20
 
16
21
  # For comparison
17
22
  class Hash
18
23
  def deep_include?(sub_hash)
19
24
  sub_hash.keys.all? do |key|
20
- self.has_key?(key) && if sub_hash[key].is_a?(Hash)
25
+ next unless self.key?(key)
26
+
27
+ if sub_hash[key].is_a?(Hash)
21
28
  self[key].is_a?(Hash) && self[key].deep_include?(sub_hash[key])
22
29
  else
23
30
  self[key] == sub_hash[key]
@@ -26,5 +33,23 @@ class Hash
26
33
  end
27
34
  end
28
35
 
29
- RSpec.configure do |config|
36
+ RSpec.configure do
37
+ end
38
+
39
+
40
+ # Monkey patch for rails 4.2 + ruby 2.6
41
+ # https://github.com/rails/rails/issues/34790
42
+ if RUBY_VERSION>='2.6.0'
43
+ if Rails.version < '5'
44
+ class ActionController::TestResponse < ActionDispatch::TestResponse
45
+ def recycle!
46
+ # hack to avoid MonitorMixin double-initialize error:
47
+ @mon_mutex_owner_object_id = nil
48
+ @mon_mutex = nil
49
+ initialize
50
+ end
51
+ end
52
+ else
53
+ puts "Monkeypatch for ActionController::TestResponse no longer needed"
54
+ end
30
55
  end
metadata CHANGED
@@ -1,201 +1,229 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: action_controller_tweaks
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.3.0
4
+ version: 0.3.5
5
5
  platform: ruby
6
6
  authors:
7
7
  - PikachuEXE
8
- autorequire:
8
+ autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2014-03-14 00:00:00.000000000 Z
11
+ date: 2020-09-07 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activesupport
15
15
  requirement: !ruby/object:Gem::Requirement
16
16
  requirements:
17
- - - '>='
17
+ - - ">="
18
18
  - !ruby/object:Gem::Version
19
- version: 3.2.0
20
- - - <
19
+ version: 4.1.0
20
+ - - "<"
21
21
  - !ruby/object:Gem::Version
22
- version: 5.0.0
22
+ version: 7.0.0
23
23
  type: :runtime
24
24
  prerelease: false
25
25
  version_requirements: !ruby/object:Gem::Requirement
26
26
  requirements:
27
- - - '>='
27
+ - - ">="
28
28
  - !ruby/object:Gem::Version
29
- version: 3.2.0
30
- - - <
29
+ version: 4.1.0
30
+ - - "<"
31
31
  - !ruby/object:Gem::Version
32
- version: 5.0.0
32
+ version: 7.0.0
33
33
  - !ruby/object:Gem::Dependency
34
34
  name: actionpack
35
35
  requirement: !ruby/object:Gem::Requirement
36
36
  requirements:
37
- - - '>='
37
+ - - ">="
38
38
  - !ruby/object:Gem::Version
39
- version: 3.2.0
40
- - - <
39
+ version: 4.1.0
40
+ - - "<"
41
41
  - !ruby/object:Gem::Version
42
- version: 5.0.0
42
+ version: 7.0.0
43
43
  type: :runtime
44
44
  prerelease: false
45
45
  version_requirements: !ruby/object:Gem::Requirement
46
46
  requirements:
47
- - - '>='
47
+ - - ">="
48
48
  - !ruby/object:Gem::Version
49
- version: 3.2.0
50
- - - <
49
+ version: 4.1.0
50
+ - - "<"
51
51
  - !ruby/object:Gem::Version
52
- version: 5.0.0
52
+ version: 7.0.0
53
53
  - !ruby/object:Gem::Dependency
54
54
  name: bundler
55
55
  requirement: !ruby/object:Gem::Requirement
56
56
  requirements:
57
- - - '>='
57
+ - - ">="
58
58
  - !ruby/object:Gem::Version
59
59
  version: 1.0.0
60
60
  type: :development
61
61
  prerelease: false
62
62
  version_requirements: !ruby/object:Gem::Requirement
63
63
  requirements:
64
- - - '>='
64
+ - - ">="
65
65
  - !ruby/object:Gem::Version
66
66
  version: 1.0.0
67
67
  - !ruby/object:Gem::Dependency
68
68
  name: rake
69
69
  requirement: !ruby/object:Gem::Requirement
70
70
  requirements:
71
- - - '>='
71
+ - - ">="
72
72
  - !ruby/object:Gem::Version
73
- version: 0.9.2
73
+ version: '10.0'
74
+ - - "<="
75
+ - !ruby/object:Gem::Version
76
+ version: '14.0'
74
77
  type: :development
75
78
  prerelease: false
76
79
  version_requirements: !ruby/object:Gem::Requirement
77
80
  requirements:
78
- - - '>='
81
+ - - ">="
82
+ - !ruby/object:Gem::Version
83
+ version: '10.0'
84
+ - - "<="
79
85
  - !ruby/object:Gem::Version
80
- version: 0.9.2
86
+ version: '14.0'
81
87
  - !ruby/object:Gem::Dependency
82
88
  name: appraisal
83
89
  requirement: !ruby/object:Gem::Requirement
84
90
  requirements:
85
- - - '>='
91
+ - - "~>"
86
92
  - !ruby/object:Gem::Version
87
- version: 0.5.2
93
+ version: '2.0'
88
94
  type: :development
89
95
  prerelease: false
90
96
  version_requirements: !ruby/object:Gem::Requirement
91
97
  requirements:
92
- - - '>='
98
+ - - "~>"
93
99
  - !ruby/object:Gem::Version
94
- version: 0.5.2
100
+ version: '2.0'
95
101
  - !ruby/object:Gem::Dependency
96
102
  name: rspec-rails
97
103
  requirement: !ruby/object:Gem::Requirement
98
104
  requirements:
99
- - - ~>
105
+ - - "~>"
100
106
  - !ruby/object:Gem::Version
101
- version: '2.6'
107
+ version: '4.0'
102
108
  type: :development
103
109
  prerelease: false
104
110
  version_requirements: !ruby/object:Gem::Requirement
105
111
  requirements:
106
- - - ~>
112
+ - - "~>"
107
113
  - !ruby/object:Gem::Version
108
- version: '2.6'
114
+ version: '4.0'
109
115
  - !ruby/object:Gem::Dependency
110
- name: activerecord
116
+ name: rspec-its
111
117
  requirement: !ruby/object:Gem::Requirement
112
118
  requirements:
113
- - - '>='
119
+ - - "~>"
114
120
  - !ruby/object:Gem::Version
115
- version: 3.2.0
116
- - - <
117
- - !ruby/object:Gem::Version
118
- version: 5.0.0
121
+ version: '1.0'
119
122
  type: :development
120
123
  prerelease: false
121
124
  version_requirements: !ruby/object:Gem::Requirement
122
125
  requirements:
123
- - - '>='
126
+ - - "~>"
127
+ - !ruby/object:Gem::Version
128
+ version: '1.0'
129
+ - !ruby/object:Gem::Dependency
130
+ name: activerecord
131
+ requirement: !ruby/object:Gem::Requirement
132
+ requirements:
133
+ - - ">="
124
134
  - !ruby/object:Gem::Version
125
- version: 3.2.0
126
- - - <
135
+ version: 4.0.0
136
+ type: :development
137
+ prerelease: false
138
+ version_requirements: !ruby/object:Gem::Requirement
139
+ requirements:
140
+ - - ">="
127
141
  - !ruby/object:Gem::Version
128
- version: 5.0.0
142
+ version: 4.0.0
129
143
  - !ruby/object:Gem::Dependency
130
144
  name: sqlite3
131
145
  requirement: !ruby/object:Gem::Requirement
132
146
  requirements:
133
- - - '>='
147
+ - - ">="
134
148
  - !ruby/object:Gem::Version
135
149
  version: '1.3'
136
150
  type: :development
137
151
  prerelease: false
138
152
  version_requirements: !ruby/object:Gem::Requirement
139
153
  requirements:
140
- - - '>='
154
+ - - ">="
141
155
  - !ruby/object:Gem::Version
142
156
  version: '1.3'
143
157
  - !ruby/object:Gem::Dependency
144
158
  name: database_cleaner
145
159
  requirement: !ruby/object:Gem::Requirement
146
160
  requirements:
147
- - - '>='
161
+ - - ">="
148
162
  - !ruby/object:Gem::Version
149
163
  version: '1.0'
150
164
  type: :development
151
165
  prerelease: false
152
166
  version_requirements: !ruby/object:Gem::Requirement
153
167
  requirements:
154
- - - '>='
168
+ - - ">="
155
169
  - !ruby/object:Gem::Version
156
170
  version: '1.0'
157
171
  - !ruby/object:Gem::Dependency
158
172
  name: timecop
159
173
  requirement: !ruby/object:Gem::Requirement
160
174
  requirements:
161
- - - '>='
175
+ - - ">="
162
176
  - !ruby/object:Gem::Version
163
177
  version: '0.6'
164
178
  type: :development
165
179
  prerelease: false
166
180
  version_requirements: !ruby/object:Gem::Requirement
167
181
  requirements:
168
- - - '>='
182
+ - - ">="
169
183
  - !ruby/object:Gem::Version
170
184
  version: '0.6'
171
185
  - !ruby/object:Gem::Dependency
172
186
  name: coveralls
173
187
  requirement: !ruby/object:Gem::Requirement
174
188
  requirements:
175
- - - '>='
189
+ - - ">="
176
190
  - !ruby/object:Gem::Version
177
191
  version: '0.7'
178
192
  type: :development
179
193
  prerelease: false
180
194
  version_requirements: !ruby/object:Gem::Requirement
181
195
  requirements:
182
- - - '>='
196
+ - - ">="
183
197
  - !ruby/object:Gem::Version
184
198
  version: '0.7'
185
199
  - !ruby/object:Gem::Dependency
186
200
  name: gem-release
187
201
  requirement: !ruby/object:Gem::Requirement
188
202
  requirements:
189
- - - '>='
203
+ - - ">="
190
204
  - !ruby/object:Gem::Version
191
205
  version: '0.7'
192
206
  type: :development
193
207
  prerelease: false
194
208
  version_requirements: !ruby/object:Gem::Requirement
195
209
  requirements:
196
- - - '>='
210
+ - - ">="
197
211
  - !ruby/object:Gem::Version
198
212
  version: '0.7'
213
+ - !ruby/object:Gem::Dependency
214
+ name: test-unit
215
+ requirement: !ruby/object:Gem::Requirement
216
+ requirements:
217
+ - - ">="
218
+ - !ruby/object:Gem::Version
219
+ version: 3.0.0
220
+ type: :development
221
+ prerelease: false
222
+ version_requirements: !ruby/object:Gem::Requirement
223
+ requirements:
224
+ - - ">="
225
+ - !ruby/object:Gem::Version
226
+ version: 3.0.0
199
227
  description: ActionController is great, but could be better. Here are some tweaks
200
228
  for it.
201
229
  email:
@@ -204,9 +232,9 @@ executables: []
204
232
  extensions: []
205
233
  extra_rdoc_files: []
206
234
  files:
207
- - .gitignore
208
- - .rspec
209
- - .travis.yml
235
+ - ".gitignore"
236
+ - ".rspec"
237
+ - ".travis.yml"
210
238
  - Appraisals
211
239
  - CHANGELOG.md
212
240
  - Gemfile
@@ -214,8 +242,12 @@ files:
214
242
  - README.md
215
243
  - Rakefile
216
244
  - action_controller_tweaks.gemspec
217
- - gemfiles/rails3_2.gemfile
218
- - gemfiles/rails4_0.gemfile
245
+ - gemfiles/.bundle/config
246
+ - gemfiles/rails_4_2.gemfile
247
+ - gemfiles/rails_5_0.gemfile
248
+ - gemfiles/rails_5_1.gemfile
249
+ - gemfiles/rails_5_2.gemfile
250
+ - gemfiles/rails_6_0.gemfile
219
251
  - lib/action_controller_tweaks.rb
220
252
  - lib/action_controller_tweaks/caching.rb
221
253
  - lib/action_controller_tweaks/session.rb
@@ -228,24 +260,23 @@ homepage: http://github.com/PikachuEXE/action_controller_tweaks
228
260
  licenses:
229
261
  - MIT
230
262
  metadata: {}
231
- post_install_message:
263
+ post_install_message:
232
264
  rdoc_options: []
233
265
  require_paths:
234
266
  - lib
235
267
  required_ruby_version: !ruby/object:Gem::Requirement
236
268
  requirements:
237
- - - '>='
269
+ - - ">="
238
270
  - !ruby/object:Gem::Version
239
- version: '0'
271
+ version: 2.4.0
240
272
  required_rubygems_version: !ruby/object:Gem::Requirement
241
273
  requirements:
242
- - - '>='
274
+ - - ">="
243
275
  - !ruby/object:Gem::Version
244
276
  version: 1.4.0
245
277
  requirements: []
246
- rubyforge_project:
247
- rubygems_version: 2.2.2
248
- signing_key:
278
+ rubygems_version: 3.1.4
279
+ signing_key:
249
280
  specification_version: 4
250
281
  summary: Some Tweaks for ActionController
251
282
  test_files:
@@ -253,4 +284,3 @@ test_files:
253
284
  - spec/fixtures/application.rb
254
285
  - spec/fixtures/controllers.rb
255
286
  - spec/spec_helper.rb
256
- has_rdoc: