action_args 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e820e5d9674aa0054496752320674fc8c57c364d
-  data.tar.gz: c854a76604f95d555872c93cc360ad42d19425e8
+  metadata.gz: 0bc1d9d90cd395b886fc828a35a63c5d0064af53
+  data.tar.gz: 15bbdff4daa2bfa5413ed8a1a14f54770359fd87
 SHA512:
-  metadata.gz: b82fea159869a228853c9362d9b321c9a4ef3e9f88b20be10a74b16c96c494317a96fa99936ff7ae2261812645cf89c6e68f959ee802eb942310c35df6126ccf
-  data.tar.gz: 85e3e9513651c34edce33142cc2fa4dc0d539f1eb9163a0464bcdb82686ebac6e549b2963406b56605f3376519b1d3847b576d2f14949749704ef80d4351960e
+  metadata.gz: 03ab97f8deb9229b3c1c158ad0d4a414324e848665c8ee3bf090dc4d9367a3bdf87d9991b9c054ae19436201dd10f942b1b401200d2b16949af994c2e1789c98
+  data.tar.gz: d1e480e53600b3a14e39741c85678f76fc8f3f1c3dba7a31b3fd27c9b1a5c7b40e911cfe37200e19e8dd7e05a5fa60b48ddc2789cbc93aefd6482f21c9ac6ea8

data/README.md

@@ -1,11 +1,11 @@
 # ActionArgs
 
-Controller action arguments parameterizer for Rails 3+
+Controller action arguments parameterizer for Rails 3 and 4
 
 
 ## What is this?
 
-ActionArgs is a Rails plugin that extends your controller action methods to look and act like simple general Ruby methods with meaningful parameters, or in short, Merbish.
+ActionArgs is a Rails plugin that extends your controller action methods to allow you to specify arguments of interest in the method definition for any action. - in short, Merbish.
 
 
 ## The Controllers
@@ -21,16 +21,18 @@ end
 ```
 
 Hitting "/hoge/fuga?piyo=foo" will call `fuga('foo')` and output 'foo'.
-So, you do never need to touch the ugly `params` Hash in order to fetch the request parameters.
+This allows you to explicitly state which members of the `params` Hash are used in your controller actions,
 
 
 ## StrongParameters
 
 ActionArgs plays very nice with Rails 4 StrongParameters.
 
-In this `show` action, ActionArgs `require`s the `id` parameter.
-Hence, if the `id` value has not been specified in the request parameter, it raises an error in the same way as usual Ruby methods do.
+### Required Parameters
+Method parameters that you specify are required. If a key of the same name does not exist in the params Hash,
+an ArgumentError is raised.
 
+In this `show` action, ActionArgs will require that `id` parameter is provided.
 ```ruby
 class UsersController < ApplicationController
   # the `id` parameter is mandatory
@@ -40,8 +42,8 @@ class UsersController < ApplicationController
 end
 ```
 
-If you don't want ActionArgs to check the existence of some action parameters, you can make them optional by defining their default values.
-Again, it just acts in the same way as usual Ruby methods do.
+### Optional Parameters
+Default parameter values are assigned in the standard way. Parameters with a default value will not require a matching item in the `params` Hash.
 
 ```ruby
 class UsersController < ApplicationController
@@ -52,7 +54,11 @@ class UsersController < ApplicationController
 end
 ```
 
-Hashes in the action method arguments simply respond to the StrongParameters' `permit` method.
+### StrongParameters - permit
+
+1. Inline declaration
+
+Hashes simply respond to the StrongParameters' `permit` method.
 
 ```ruby
 class UsersController < ApplicationController
@@ -63,10 +69,10 @@ class UsersController < ApplicationController
 end
 ```
 
-Moreover, ActionArgs provides declarative `permits` method for controller classes,
-so that you can DRY up your `permit` calls in the most comprehensible way.
-The `permits` method assumes the model class from the controller name, and
-`permit`s the action arguments containing attributes for that model.
+2. Declarative white-listing
+
+ActionArgs also provides a declarative `permits` method for controller classes.
+Use this to keep your `permit` calls DRY in a comprehensible way.
 
 ```ruby
 class UsersController < ApplicationController
@@ -213,7 +219,7 @@ class BooksController < ApplicationController
 end
 ```
 
-However, due to some implementational reasons, the `page` variable will be actually defaulted to nil when `page` parameter was not given.
+However, due to some implementation reasons, the `page` variable will be actually defaulted to nil when `page` parameter was not given.
 
 In order to provide default parameter values in perfect Ruby manner, we recommend you to use the Ruby 2.0 "keyword arguments" syntax instead.
 
@@ -229,4 +235,4 @@ This way, the `page` parameter will be defaulted to 1 as everyone might expect.
 
 ## Copyright
 
-Copyright (c) 2011 Asakusa.rb. See MIT-LICENSE for further details.
+Copyright (c) 2011~2013 Asakusa.rb. See MIT-LICENSE for further details.

data/gemfiles/rails_40.gemfile

@@ -1,8 +1,6 @@
 source 'https://rubygems.org'
 
-gem 'rails', github: 'rails/rails'
-gem 'activerecord-deprecated_finders', github: 'rails/activerecord-deprecated_finders'
-gem 'journey', github: 'rails/journey'
+gem 'rails', '>= 4.0.0'
 gem 'rspec-rails', '>= 2.0'
 
 gemspec :path => '../'

data/lib/action_args/abstract_controller.rb

@@ -3,6 +3,7 @@ module AbstractController
     if defined? ActionController::StrongParameters
       def send_action(method_name, *args)
         return send method_name, *args unless args.empty?
+        return send method_name, *args unless defined?(params)
 
         method_parameters = method(method_name).parameters
         ActionArgs::ParamsHandler.strengthen_params!(self.class, method_parameters, params)
@@ -29,6 +30,7 @@ module AbstractController
     else
       def send_action(method_name, *args)
         return send method_name, *args unless args.empty?
+        return send method_name, *args unless defined?(params)
 
         values = ActionArgs::ParamsHandler.extract_method_arguments_from_params method(method_name).parameters, params
         send method_name, *values

data/lib/action_args/version.rb

@@ -1,3 +1,3 @@
 module ActionArgs
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/spec/fake_app.rb

@@ -31,6 +31,19 @@ end
 class Store < ActiveRecord::Base
 end
 
+# mailers
+require "action_mailer/railtie"
+class UserMailer < ActionMailer::Base
+  def send_email_without_args
+    mail(
+      to:      'to@example.com',
+      from:    'from@example.com',
+      subject: 'Action Args!!!',
+      body:    'test'
+    )
+  end
+end
+
 # helpers
 module ApplicationHelper; end
 

data/spec/mailers/action_mailer_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe UserMailer do
+  describe '#send_email_without_args' do
+    it "should not raise NameError: undefined local variable or method `params' for ..." do
+      expect{ UserMailer.send_email_without_args }.to_not raise_error(NameError)
+    end
+  end
+end

data/spec/params_handler/params_handler_spec.rb

@@ -146,12 +146,16 @@ describe ActionArgs::ParamsHandler do
         its([:b]) { should be }
       end
 
-      context 'requiring via :key, permitting all scalars' do
-        let(:controller) { FugaController ||= Class.new(ApplicationController) { permits :a, :b; def a(fuga: {}) end } }
-        subject { params[:fuga] }
-        it { should be_permitted }
-        its([:a]) { should be }
-        its([:b]) { should be }
+      if RUBY_VERSION >= '2'
+        eval <<-KWARGS_TEST
+          context 'requiring via :key, permitting all scalars' do
+            let(:controller) { FugaController ||= Class.new(ApplicationController) { permits :a, :b; def a(fuga: {}) end } }
+            subject { params[:fuga] }
+            it { should be_permitted }
+            its([:a]) { should be }
+            its([:b]) { should be }
+          end
+        KWARGS_TEST
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: action_args
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Akira Matsuda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-21 00:00:00.000000000 Z
+date: 2013-07-25 00:00:00.000000000 Z
 dependencies: []
 description: Rails plugin gem that supports Merbish style controller action arguments.
 email:
@@ -40,6 +40,7 @@ files:
 - spec/controllers/strong_parameters_spec.rb
 - spec/fake_app.rb
 - spec/kwargs_controllers.rb
+- spec/mailers/action_mailer_spec.rb
 - spec/params_handler/params_handler_spec.rb
 - spec/spec_helper.rb
 homepage: http://asakusa.rubyist.net/
@@ -61,7 +62,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: action_args
-rubygems_version: 2.0.2
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Controller action arguments parameterizer for Rails 3+ & Ruby 1.9+
@@ -72,5 +73,6 @@ test_files:
 - spec/controllers/strong_parameters_spec.rb
 - spec/fake_app.rb
 - spec/kwargs_controllers.rb
+- spec/mailers/action_mailer_spec.rb
 - spec/params_handler/params_handler_spec.rb
 - spec/spec_helper.rb