act_with_bag 1.0.4 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3db0e2b3144028775d4671056b9aff91b6f48d4843a056fdc0e42bc115a18a86
-  data.tar.gz: 83a536b2e3a296c5d1bb50de2e4dee584327c8d6b0ba9e2d608d0018259e811d
+  metadata.gz: 4ecc3541b5c744c54c7f53770c3b7172e4935fb0d5f4b7e7edf39502e334ca6e
+  data.tar.gz: da6b991ddd14d98b4b079c258544b9fb4408d24f73553a796a71212c8865e23d
 SHA512:
-  metadata.gz: 8178f176d4cefe6bfdf990ef3d1d40310b866d5a18e36757a291c8ae490c312d5a41fe5be1380f7e66af1ff780015d1c6ea0fd57562bc413f75ce5ad048b85e5
-  data.tar.gz: 6b56cdf9bce4b173112d50cc8e167bb022994c0877edfbc665bdeab8b3ba7618f0813a929d4e29480bef8f581283d1c4a55b556a3f7b7c05bafe2515cae2ad40
+  metadata.gz: 8a5960ac831f6404d46b1843933bdf533203917187244442e0c38f74c41bdcf39b5651d1fde36b02190a757a92ebbe5a4f7fb4ca638a1087b9d2d503c91d4044
+  data.tar.gz: 69ec721ff96ccbd202daf926127a2f484e47244af0c9bb6abac5cf799eb175c5ec50ae4c9cb053d6b935165e1494b17b5b8e1f44bee1e1a69a68a3cb51008fb6

data/.github/workflows/rake.yml

@@ -1,26 +1,30 @@
-# under construction
-
+# see also https://github.com/whitequark/parser/blob/master/.github/workflows/test.yml
 name: Rake
 
-on: push
+#on: [push, pull_request]
+on: [push]
 
 jobs:
   test:
-    name: Rake
-#    runs-on: ubuntu-18.04
-    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+#        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-latest]
+        # Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
+#        ruby: [2.5, 2.6, 2.7, '3.0', head, jruby, jruby-head, truffleruby, truffleruby-head]
+        ruby: ["2.7.2", 3.1.0, head]
+        test_command: ["bundle exec rake test"]
+    runs-on: ${{ matrix.os }}
 
     steps:
-    - uses: actions/checkout@v1
-
-    - name: Setup Ruby
-#      uses: actions/setup-ruby@v1
-      uses: ruby/setup-ruby@v1
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7
-
-    - name: Install dependencies
-      run: gem install bundler && bundle install --jobs 4 --retry 3
-
-    - name: Run Rake
-      run: rake
+        ruby-version: ${{ matrix.ruby }}
+    - name: Bundle install
+      run: |
+        bundle config path /home/runner/bundle
+        bundle install
+        bundle update
+    - run: ${{ matrix.test_command }}

data/.ruby-gemset

@@ -1 +1 @@
-rails-6.1
+rails-7.0

data/.ruby-version

@@ -1 +1 @@
-ruby-2.7.2
+ruby-3.1.3

data/.watchr

@@ -1,5 +1,6 @@
-HH = '#' * 22  unless defined?(HH)
-H = '#' * 5    unless defined?(H)
+TESTING = %w[test]
+HH = "#" * 22 unless defined?(HH)
+H = "#" * 5 unless defined?(H)
 
 def usage
   puts <<-EOS
@@ -14,35 +15,47 @@ def run(cmd)
   system "/usr/bin/time --format '#{HH} Elapsed time %E' #{cmd}"
 end
 
-def run_it(type, file)
-  case type
-  when 'test';  run %(ruby -I test #{file})
-#  when 'spec';  run %(rspec -X #{file})
-  else;         puts "#{H} unknown type: #{type}, file: #{file}"
+def run_it(type, files)
+  files.split(" ").flatten.each do |file|
+    case type
+    when "test" then run %(bundle exec ruby -I test #{file})
+    #  when 'spec';  run %(rspec -X #{file})
+    else; puts "#{H} unknown type: #{type}, file: #{file}"
+    end
   end
 end
 
 def run_all_tests
   puts "\n#{HH} Running all tests #{HH}\n"
-  %w[test spec].each { |dir| run "rake #{dir}" if  File.exist?(dir) }
+  TESTING.each { |dir| run "bundle exec rake #{dir}" if File.exist?(dir) }
 end
 
 def run_matching_files(base)
-  base = base.split('_').first
-  %w[test spec].each { |type|
+  base = base.split("_").first
+  TESTING.each { |type|
     files = Dir["#{type}/**/*.rb"].select { |file| file =~ /#{base}_.*\.rb/ }
-    run_it type, files.join(' ')  unless files.empty?
+    run_it type, files.join(" ") unless files.empty?
   }
 end
 
-%w[test spec].each { |type|
+TESTING.each { |type|
   watch("#{type}/#{type}_helper\.rb") { run_all_tests }
-  watch('lib/.*\.rb')                 { run_all_tests }
-  watch("#{type}/.*/*_#{type}\.rb")   { |match| run_it type, match[0] }
+  watch("lib/.*\.rb") { run_all_tests }
+  watch("#{type}/.*/*_#{type}\.rb") { |match| run_it type, match[0] }
+  watch("#{type}/data/(.*)\.rb") { |match|
+    m1 = match[1]
+    run_matching_files("#{type}/#{m1}/#{m1}_#{type}.rb")
+  }
+}
+
+%w[rb erb haml slim].each { |type|
+  watch(".*/(.*)\.#{type}") { |match|
+    run_matching_files(match[1])
+  }
 }
 
 # Ctrl-\ or ctrl-4
-    Signal.trap('QUIT') { run_all_tests }
+Signal.trap("QUIT") { run_all_tests }
 # Ctrl-C
-    Signal.trap('INT')  { abort("Interrupted\n") }
+Signal.trap("INT") { abort("Interrupted\n") }
 usage

data/Appraisals

@@ -1,24 +1,24 @@
-appraise 'rails-6.1' do
-  gem 'rails', '~> 6.1'
-  gem 'dryer-config', '~> 6.0'
+appraise "rails-6.1" do
+  gem "rails", "~> 6.1"
+  gem "dryer-config", "~> 6.0"
 end
 
-appraise 'rails-6.0' do
-  gem 'rails', '~> 6.0'
-  gem 'dryer-config', '~> 6.0'
+appraise "rails-6.0" do
+  gem "rails", "~> 6.0"
+  gem "dryer-config", "~> 6.0"
 end
 
-#appraise 'rails-5.2' do
+# appraise 'rails-5.2' do
 #  gem 'rails', '~> 5.2.0'
 #  gem 'dryer-config', '~> 5.2.0'
-#end
+# end
 
-#appraise 'rails-5.0' do
+# appraise 'rails-5.0' do
 #  gem 'rails', '~> 5.0.0'
 #  gem 'dryer-config', '~> 5.0.0'
-#end
+# end
 
-#appraise 'rails-4.1' do
+# appraise 'rails-4.1' do
 #  gem 'rails', '= 4.1.1'
 ##  gem 'dryer-config', '~> 5.1.0'
-#end
+# end

data/Gemfile

@@ -1,11 +1,11 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 gemspec
 
-gem 'rails'
+gem "rails"
 
 group :test do
-  gem 'observr'
-  gem 'rubocop', require: false
-  gem 'simplecov', require: false
-  gem 'capybara'
+  gem "observr"
+  gem "standard", require: false
+  gem "simplecov", require: false
+  gem "ricecream"
 end

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2010-2021 Dittmar Krall - www.matique.com
+Copyright 2010-2022 Dittmar Krall - www.matiq.com
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -50,6 +50,23 @@ Using an "add_to_bag" in the subclass obsoletes the "serialize".
 Other records are untouched,
 i.e. the value of the field will be kept in the database.
 
+3. Keep an eye on YAML, the library to serialize the "bag",
+which for some versions is not tamper-proof
+and may required additional configuration in Rails.
+
+See also:
+~~~
+https://stackoverflow.com/questions/72970170/upgrading-to-rails-6-1-6-1-causes-psychdisallowedclass-tried-to-load-unspecif
+~~~
+
+The configuration
+"Rails.application.config.active_record.use_yaml_unsafe_load = true"
+is not recommended as it is a patch prone to attacks.
+
+The configuration
+"Rails.application.config.active_record.yaml_column_permitted_classes = [Symbol]"
+may be incomplete requiring additional classes like "Time" and "Date".
+(credits to Martin Sch�ttler).
 
 Example
 =======
@@ -91,4 +108,4 @@ Test
 
     rake
 
-Copyright (c) 2009-2020 [Dittmar Krall], released under the MIT license
+Copyright (c) 2009-2022 [Dittmar Krall], released under the MIT license

data/Rakefile

@@ -1,10 +1,10 @@
-require 'rake/testtask'
+require "rake/testtask"
 
-desc 'Run the tests.'
+desc "Run the tests."
 Rake::TestTask.new do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = 'test/**/*_test.rb'
+  t.libs << "lib"
+  t.libs << "test"
+  t.pattern = "test/**/*_test.rb"
   t.verbose = false
 end
 

data/act_with_bag.gemspec

@@ -1,27 +1,28 @@
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'act_with_bag/version'
+require "act_with_bag/version"
 
 Gem::Specification.new do |s|
-  s.name        = 'act_with_bag'
-  s.version     = ActWithBag::VERSION
-  s.summary     = %q{act_with_bag (baggies) gem}
-  s.description = %q{Add a bag to a Rails model}
-  s.authors     = ['Dittmar Krall']
-  s.email       = ['dittmar.krall@matique.de']
-  s.homepage    = 'http://matique.de'
+  s.name = "act_with_bag"
+  s.version = ActWithBag::VERSION
+  s.summary = "act_with_bag (baggies) gem"
+  s.description = "Add a bag to a Rails model"
+  s.authors = ["Dittmar Krall"]
+  s.email = ["dittmar.krall@matiq.com"]
+  s.homepage = "http://matiq.com"
+  s.license = "MIT"
+  s.platform = Gem::Platform::RUBY
 
-  s.license     = 'MIT'
-  s.platform    = Gem::Platform::RUBY
+  s.metadata["source_code_uri"] = "https://github.com/matique/act_with_bag"
 
-  s.files         = `git ls-files -z`.split("\x0")
-  s.test_files    = s.files.grep(%r{^(test|spec|features)/})
-  s.require_paths = ['lib']
+  s.files = `git ls-files -z`.split("\x0")
+  s.require_paths = ["lib"]
 
-  s.add_development_dependency 'bundler'
-  s.add_development_dependency 'rake'
-  s.add_development_dependency 'appraisal', '~> 2'
+  s.add_development_dependency "bundler"
+  s.add_development_dependency "rake"
+  s.add_development_dependency "appraisal"
+  s.add_development_dependency "combustion"
 
-  s.add_development_dependency 'minitest'
-  s.add_development_dependency 'sqlite3'
+  s.add_development_dependency "minitest"
+  s.add_development_dependency "sqlite3"
 end

data/gemfiles/rails_6.0.gemfile

@@ -7,9 +7,9 @@ gem "dryer-config", "~> 6.0"
 
 group :test do
   gem "observr"
-  gem "rubocop", require: false
+  gem "standard", require: false
   gem "simplecov", require: false
-  gem "capybara"
+  gem "ricecream"
 end
 
 gemspec path: "../"

data/gemfiles/rails_6.1.gemfile

@@ -7,9 +7,9 @@ gem "dryer-config", "~> 6.0"
 
 group :test do
   gem "observr"
-  gem "rubocop", require: false
+  gem "standard", require: false
   gem "simplecov", require: false
-  gem "capybara"
+  gem "ricecream"
 end
 
 gemspec path: "../"

data/lib/act_with_bag/version.rb

@@ -1,12 +1,12 @@
-# rubocop: disable all
-
 module ActWithBag
-  VERSION = '1.0.4'     # 2021-06-17
-# VERSION = '1.0.3'     # 2021-05-18
-# VERSION = '1.0.2'     # 2020-07-16
-# VERSION = '1.0.1'     # 2020-04-27
-# VERSION = '1.0.0'     # 2019-09-27
-# VERSION = '0.5.7'     # 2019-03-05
-# VERSION = '0.5.6'     # 2019-02-15
-# VERSION = '0.5.5'
+  VERSION = "1.1.1" # 2022-12-11
+  # VERSION = "1.1.0" # 2022-08-07
+  # VERSION = "1.0.4" # 2021-06-17
+  # VERSION = "1.0.3" # 2021-05-18
+  # VERSION = "1.0.2" # 2020-07-16
+  # VERSION = "1.0.1" # 2020-04-27
+  # VERSION = "1.0.0" # 2019-09-27
+  # VERSION = "0.5.7" # 2019-03-05
+  # VERSION = "0.5.6" # 2019-02-15
+  # VERSION = "0.5.5"
 end

data/lib/act_with_bag.rb

@@ -6,10 +6,12 @@ class << ActiveRecord::Base
     serialize :bag, Hash
 
     class_eval %{
-      def bag=(x)
-        #bag changes disabled as it must be handled by Bag himself
+      unless method_defined?(:bag=)
+        def bag=(x)
+          #bag changes disabled as it must be handled by Bag himself
+        end
       end
-    }
+    }, __FILE__, __LINE__ - 4
 
     @baggies_date ||= {}
     baglets.each { |b|
@@ -38,7 +40,7 @@ class << ActiveRecord::Base
           end
         }
       end
-    }
+    }, __FILE__, __LINE__ - 12
   end
 
   def merge(_bag, params)
@@ -60,23 +62,28 @@ class << ActiveRecord::Base
       next unless found
 
       ## weird Timestamp, Hash and YAML problem
-      res = [0]  if res == []
-      res[0] = 0  unless res[0] >= 0
+      res = [0] if res == []
+      res[0] = 0 unless res[0] >= 0
 
-      value = Date.new(*res) rescue nil
+      value = begin
+        Date.new(*res)
+      rescue
+        nil
+      end
       params[model][baggie] = value
     }
     params
   end
 
- protected
+  protected
+
   def accessor_present?(accessor)
     accessor_sym = accessor.to_sym
     res = false
 
-    res = true  if method_defined?(accessor_sym)
-    res = true  if respond_to?(:attribute_names) &&
-                   attribute_names.include?(accessor)
+    res = true if method_defined?(accessor_sym)
+    res = true if respond_to?(:attribute_names) &&
+      attribute_names.include?(accessor)
     if res
       #      logger.info "** Already defined #{self.to_s}.#{accessor}"
       # p "** act_to_bag: untouched accessor '#{self.to_s}.#{accessor}'"
@@ -86,7 +93,7 @@ class << ActiveRecord::Base
 
   def add_accessor(baggie, type)
     accessor = baggie.to_s
-    return  if accessor_present?(accessor)
+    return if accessor_present?(accessor)
 
     # MARS patch, new:
     #
@@ -103,11 +110,11 @@ class << ActiveRecord::Base
     # END
 
     type_sym = type.to_sym
-    typing = {integer: '.to_i', float: '.to_f',
-              string: '.to_s'}[type_sym] || ''
+    typing = {integer: ".to_i", float: ".to_f",
+              string: ".to_s"}[type_sym] || ""
     # p "add_accessor #{self.to_s} #{baggie.inspect} #{type_sym.inspect}"
 
-    @baggies_date[baggie] = type  if type_sym == :date
+    @baggies_date[baggie] = type if type_sym == :date
 
     if type_sym == :boolean
       class_eval %(
@@ -116,9 +123,8 @@ class << ActiveRecord::Base
           return res if res.class == FalseClass
           return res if res.class == TrueClass
           return res.to_i != 0
-          res
         end
-      )
+      ), __FILE__, __LINE__ - 7
 
       class_eval %(
         def #{accessor}=(value)
@@ -131,13 +137,13 @@ class << ActiveRecord::Base
             nil
           end
         end
-      )
+      ), __FILE__, __LINE__ - 11
 
       class_eval %(
         def #{accessor}?
           #{accessor}
         end
-      )
+      ), __FILE__, __LINE__ - 4
 
     else
 
@@ -145,7 +151,7 @@ class << ActiveRecord::Base
         def #{accessor}
           self.bag && self.bag[:#{baggie}]
         end
-      )
+      ), __FILE__, __LINE__ - 4
 
       class_eval %(
         def #{accessor}=(value)
@@ -157,7 +163,7 @@ class << ActiveRecord::Base
             nil
           end
         end
-      )
+      ), __FILE__, __LINE__ - 10
     end
   end
 end

data/test/accessor_test.rb

@@ -1,22 +1,18 @@
-require 'test_helper'
-
+require "test_helper"
 
 class Order < ActiveRecord::Base
   add_to_bag :category
 end
 
-
 class AccessorTest < ActiveSupport::TestCase
-
   def setup
     @order = Order.new
   end
 
   test "should reject overwriting of column category" do
-    value = 'abc'
+    value = "abc"
     assert @order.respond_to?(:category)
     @order.category = value
     assert_equal false, @order.bag.has_key?(:category)
   end
-
 end

data/test/bag_boolean_test.rb

@@ -1,13 +1,10 @@
-require 'test_helper'
-
+require "test_helper"
 
 class Order < ActiveRecord::Base
   add_to_bag bool: :boolean
 end
 
-
 class BagBooleanTest < ActiveSupport::TestCase
-
   def setup
     @order = Order.new
   end
@@ -22,7 +19,7 @@ class BagBooleanTest < ActiveSupport::TestCase
     assert_equal false, @order.bag.has_key?(:bool)
     @order.bool = 0
     assert_equal false, @order.bag.has_key?(:bool)
-    @order.bool = '0'
+    @order.bool = "0"
     assert_equal false, @order.bag.has_key?(:bool)
   end
 
@@ -37,5 +34,4 @@ class BagBooleanTest < ActiveSupport::TestCase
     @order.bool = false
     assert_equal false, @order.bag.has_key?(:bool)
   end
-
 end

data/test/bag_test.rb

@@ -1,7 +1,6 @@
-require 'test_helper'
+require "test_helper"
 
 class BagTest < ActiveSupport::TestCase
-
   def setup
     @order = Order.new
   end
@@ -15,38 +14,37 @@ class BagTest < ActiveSupport::TestCase
     assert @order.respond_to?(:flag)
     assert @order.respond_to?(:at)
 
-    assert @order.respond_to?('field=')
-    assert @order.respond_to?('flag=')
-    assert @order.respond_to?('flag?')
-    assert @order.respond_to?('at=')
+    assert @order.respond_to?(:field=)
+    assert @order.respond_to?(:flag=)
+    assert @order.respond_to?(:flag?)
+    assert @order.respond_to?(:at=)
   end
 
   test "string access to field" do
-    value = 'abc'
+    value = "abc"
     @order.field = value
     assert_equal value, @order.field
-    assert_not_equal 'def', @order.field
+    assert_not_equal "def", @order.field
   end
 
   test "date access to at" do
     value = DateTime.now
     @order.at = value
     assert_equal value, @order.at
-    assert_not_equal 'def', @order.at
+    assert_not_equal "def", @order.at
   end
 
   test "bag is hidden" do
-    value = 'abc'
+    value = "abc"
     @order.field = value
-    @order.bag = 'bad thing'
+    @order.bag = "bad thing"
     assert_equal value, @order.field
   end
 
   test "merge for :at :date" do
     model = :order
-    params = {model => {'at(1i)' => '1', 'at(2i)' => '2','at(3i)' => '3'}}
+    params = {model => {"at(1i)" => "1", "at(2i)" => "2", "at(3i)" => "3"}}
     res = Order.merge({}, params)
     assert_equal Date.new(1, 2, 3), res[model][:at]
   end
-
 end

data/test/boolean_test.rb

@@ -1,7 +1,6 @@
-require 'test_helper'
+require "test_helper"
 
 class BooleanTest < ActiveSupport::TestCase
-
   def setup
     @order = Order.new
   end
@@ -39,10 +38,10 @@ class BooleanTest < ActiveSupport::TestCase
   end
 
   test "string 1/0 returns a boolean" do
-    @order.flag = '1'
+    @order.flag = "1"
     assert_equal true, @order.flag
 
-    @order.flag = '0'
+    @order.flag = "0"
     assert_equal false, @order.flag
 
     @order.flag = nil
@@ -50,13 +49,12 @@ class BooleanTest < ActiveSupport::TestCase
   end
 
   test "'false' returns a boolean" do
-    @order.flag = 'false'
+    @order.flag = "false"
     assert_equal false, @order.flag
   end
 
   test "'true' returns a boolean" do
-    @order.flag = 'true'
+    @order.flag = "true"
     assert_equal true, @order.flag
   end
-
 end

data/test/clean_test.rb

@@ -1,20 +1,17 @@
-require 'test_helper'
-
+require "test_helper"
 
 class Order < ActiveRecord::Base
   add_to_bag :name
   add_to_bag :name2
 end
 
-
 class CleanTest < ActiveSupport::TestCase
-
   def setup
     @order = Order.new
   end
 
   test "assigning nil removes field from bag" do
-    value = 'abc'
+    value = "abc"
     assert_equal false, @order.bag.has_key?(:name)
     @order.name = value
     assert_equal true, @order.bag.has_key?(:name)
@@ -27,5 +24,4 @@ class CleanTest < ActiveSupport::TestCase
     @order.name2 = nil
     assert_equal false, @order.bag.has_key?(:name2)
   end
-
 end

data/test/delete_test.rb

@@ -1,26 +1,22 @@
-require 'test_helper'
-
+require "test_helper"
 
 class Order < ActiveRecord::Base
   add_to_bag :aa, :bb, :cc
   delete_from_bag :bb
 end
 
-
 class DeleteTest < ActiveSupport::TestCase
-
   def setup
     @order = Order.new
   end
 
   test "delete a field" do
-    @order.aa = 'aa'
-    @order.bb = 'bb'
-    @order.cc = 'cc'
+    @order.aa = "aa"
+    @order.bb = "bb"
+    @order.cc = "cc"
     @order.save
-    assert_equal 'aa', @order.aa
+    assert_equal "aa", @order.aa
     assert_nil @order.bb
-    assert_equal 'cc', @order.cc
+    assert_equal "cc", @order.cc
   end
-
 end

data/test/internal/app/models/application_record.rb

@@ -0,0 +1,3 @@
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end

data/test/internal/app/models/order.rb

@@ -0,0 +1,7 @@
+class Order < ActiveRecord::Base
+  before_save do |row|
+    row.errors.add :base, "panic" if row.category == "error"
+  end
+
+  add_to_bag :field, flag: :boolean, at: :date
+end

data/test/internal/config/database.yml

@@ -0,0 +1,3 @@
+test:
+  adapter:  sqlite3
+  database: db/test.sqlite3

data/test/internal/db/schema.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+ActiveRecord::Schema.define(version: 202208) do
+  create_table "orders", force: true do |t|
+    t.string :category
+    t.text :bag
+
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+
+  create_table "users", force: true do |t|
+    t.string :type
+    t.text :bag
+
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+end

data/test/sti_test.rb

@@ -1,5 +1,4 @@
-require 'test_helper'
-
+require "test_helper"
 
 class User < ActiveRecord::Base
   add_to_bag :name
@@ -9,9 +8,7 @@ class Administrator < User
   add_to_bag :key
 end
 
-
 class StiTest < ActiveSupport::TestCase
-
   def setup
     @user = User.new
     @admin = Administrator.new
@@ -24,7 +21,7 @@ class StiTest < ActiveSupport::TestCase
 
   test "STI field type" do
     assert_nil @user.type
-    assert_equal 'Administrator', @admin.type
+    assert_equal "Administrator", @admin.type
   end
 
   test "have bag" do
@@ -37,30 +34,29 @@ class StiTest < ActiveSupport::TestCase
     assert @admin.respond_to?(:name)
     assert @admin.respond_to?(:key)
 
-    assert @user.respond_to?('name=')
-    assert @admin.respond_to?('name=')
-    assert @admin.respond_to?('key=')
+    assert @user.respond_to?(:name=)
+    assert @admin.respond_to?(:name=)
+    assert @admin.respond_to?(:key=)
 
     assert_equal false, @user.respond_to?(:key)
-    assert_equal false, @user.respond_to?('key=')
+    assert_equal false, @user.respond_to?(:key=)
   end
 
   test "access to name & key" do
-    name = 'name'
-    key = 'key'
+    name = "name"
+    key = "key"
     @admin.name = name
     @admin.key = key
     assert_equal name, @admin.name
     assert_equal key, @admin.key
-    assert_not_equal 'def', @admin.name
-    assert_not_equal 'def', @admin.key
+    assert_not_equal "def", @admin.name
+    assert_not_equal "def", @admin.key
   end
 
   test "merge" do
     model = :administrator
-    params = {model => {'at(1i)' => '1', 'at(2i)' => '2','at(3i)' => '3'}}
+    params = {model => {"at(1i)" => "1", "at(2i)" => "2", "at(3i)" => "3"}}
     res = Administrator.merge({}, params)
     assert_nil res[model][:at]
   end
-
 end

data/test/string_test.rb

@@ -1,12 +1,10 @@
-require 'test_helper'
+require "test_helper"
 
 class Order < ActiveRecord::Base
   add_to_bag string: :string
 end
 
-
 class StringTest < ActiveSupport::TestCase
-
   def setup
     @order = Order.new
   end
@@ -14,10 +12,9 @@ class StringTest < ActiveSupport::TestCase
   test "assigning boolean to string" do
     value = false
     @order.string = value
-    assert_equal 'false', @order.string
+    assert_equal "false", @order.string
     value = true
     @order.string = value
-    assert_equal 'true', @order.string
+    assert_equal "true", @order.string
   end
-
 end

data/test/test_helper.rb

@@ -1,39 +1,17 @@
-if ENV['COVERAGE']
-  require 'simplecov'
+if ENV["COVERAGE"]
+  require "simplecov"
   SimpleCov.start do
-    add_filter '/test/'
+    add_filter "/test/"
   end
 end
 
-#require 'rails/test_help'
-require 'minitest/autorun'
-require 'minitest/benchmark'
-#require 'capybara/rails'
-
-require 'active_record'
-
-ActiveRecord::Base.establish_connection({
-  adapter:  'sqlite3',
-  database: 'bag.sqlite3'
-})
-
-ActiveRecord::Schema.define do
-  create_table 'orders', :force => true do |t|
-    t.string :category
-    t.column 'bag', :text
-  end
-end
-
-ActiveRecord::Schema.define do
-  create_table 'users', :force => true do |t|
-    t.string :type
-    t.text   :bag
-  end
+require "combustion"
+Combustion.path = "test/internal"
+Combustion.initialize! :active_record do
+  config.active_record.yaml_column_permitted_classes = [Symbol, Time, Date]
 end
 
-require File.dirname(__FILE__) + '/../lib/act_with_bag.rb'
-
-
-class Order < ActiveRecord::Base
-  add_to_bag :field, flag: :boolean, at: :date
-end
+require "rails/test_help"
+require "minitest/autorun"
+require "minitest/benchmark"
+# require 'capybara/rails'

data/test/type_test.rb

@@ -1,19 +1,30 @@
-require 'test_helper'
+require "test_helper"
 
 class Order < ActiveRecord::Base
   add_to_bag({i: :integer}, {f: :float})
 end
 
-
 class TypeTest < ActiveSupport::TestCase
-
   def setup
     @order = Order.new
   end
 
   test "miscellaneous values" do
+    [123, 2.3, "abc", nil, {a: 1}, [1, 2]].each { |value|
+      @order.field = value
+      assert_value value, @order.field
+
+      @order.save
+      id = @order.id
+      order = Order.find(id)
+      assert_value value, order.field
+    }
+  end
+
+  test "Time & Date" do
     time = Time.now
-    [123, 2.3, "abc", nil, {a: 1}, [1,2], time].each { |value|
+    today = Date.today
+    [time, today].each { |value|
       @order.field = value
       assert_value value, @order.field
 
@@ -38,10 +49,10 @@ class TypeTest < ActiveSupport::TestCase
     assert_kind_of Float, @order.f
   end
 
- private
+  private
+
   def assert_value(expect, actual)
-    assert_equal expect, actual  if expect
-    assert_nil   actual          unless expect
+    assert_equal expect, actual if expect
+    assert_nil actual unless expect
   end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: act_with_bag
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.1.1
 platform: ruby
 authors:
 - Dittmar Krall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-06-17 00:00:00.000000000 Z
+date: 2022-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -42,16 +42,30 @@ dependencies:
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: combustion
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -82,14 +96,13 @@ dependencies:
         version: '0'
 description: Add a bag to a Rails model
 email:
-- dittmar.krall@matique.de
+- dittmar.krall@matiq.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".github/workflows/rake.yml"
 - ".gitignore"
-- ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
 - ".watchr"
@@ -109,14 +122,19 @@ files:
 - test/boolean_test.rb
 - test/clean_test.rb
 - test/delete_test.rb
+- test/internal/app/models/application_record.rb
+- test/internal/app/models/order.rb
+- test/internal/config/database.yml
+- test/internal/db/schema.rb
 - test/sti_test.rb
 - test/string_test.rb
 - test/test_helper.rb
 - test/type_test.rb
-homepage: http://matique.de
+homepage: http://matiq.com
 licenses:
 - MIT
-metadata: {}
+metadata:
+  source_code_uri: https://github.com/matique/act_with_bag
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -132,18 +150,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.6
+rubygems_version: 3.3.26
 signing_key: 
 specification_version: 4
 summary: act_with_bag (baggies) gem
-test_files:
-- test/accessor_test.rb
-- test/bag_boolean_test.rb
-- test/bag_test.rb
-- test/boolean_test.rb
-- test/clean_test.rb
-- test/delete_test.rb
-- test/sti_test.rb
-- test/string_test.rb
-- test/test_helper.rb
-- test/type_test.rb
+test_files: []

data/.rubocop.yml

@@ -1,30 +0,0 @@
-inherit_from:
-  - ~/configs/.rubocop.yml
-
-AllCops:
-  Include:
-    - 'lib/**/*.rb'
-  Exclude:
-    - 'test/**/*'
-
-Layout/AccessModifierIndentation:
-  Enabled: false
-Layout/EmptyLinesAroundAccessModifier:
-  Enabled: false
-Layout/ExtraSpacing:
-  Enabled: false
-
-Metrics/AbcSize:
-  Enabled: false
-Metrics/CyclomaticComplexity:
-  Enabled: false
-Metrics/MethodLength:
-  Enabled: false
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-Style/EvalWithLocation:
-  Enabled: false
-Style/RescueModifier:
-  Exclude:
-    - 'lib/act_with_bag.rb'