act_with_bag 0.5.5 → 0.5.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d9b6f35194aec65e31ded77ab52e7325ec0390d0d1d13294c5865cf970f10ee2
-  data.tar.gz: 75461f8e3975de9b50cfbaedb83e6048328ca5e000ed4d420389d80a366a6e33
+  metadata.gz: f9d944ab63f66ac27dbe26f203d382255df7c6acde3559338cb1f05cb3dd420d
+  data.tar.gz: e1eabac9f4a018bf19c82d9efcff941d540a50a49099504cf70b88dedceb8dd6
 SHA512:
-  metadata.gz: d88b17459ad5d879f2317a401279617d8f6fee3484ecba1b9abec61283a508256b71546a8312793e5007d9695253d761ddbc099b1f9049a441eeae4b5159ebb6
-  data.tar.gz: a94b049e47f5c3b973f5cac273823fe9a2fec67acea6ba389d6d5355718152a3394a24379ed02eb4ae21b8f953f353d30e2e15b295b03a31d3bdc5ef9abd1e15
+  metadata.gz: f3d27f9b7ca2f6ceed944e6150faf92ed2414b537d50ebdbef7b87e5558a3315f1e32c7c2910b6201857e871850f8af25dae5932342946f630f41abe108cbd0d
+  data.tar.gz: 61492eb20e6b1ddb96086c5e03db7e30734cb3067619cb0d9a58144ac30c9905586f1e55caee67eaf06a4a778b6e8320fd084758fc5174bf297b25bd07b3f7d5

data/.travis.yml

@@ -2,20 +2,22 @@ language: ruby
 sudo: false
 
 bundler_args: --without production
-before_install: gem update bundler --no-document
+#before_install:
+#- gem update bundler --no-document
+#- gem update bundler --no-rdoc --no-ri
 script: "bundle exec rake test"
 
 rvm:
+  - 2.6.0
+  - 2.5.1
 #  - 1.9.3
 ##  - 2.2.3
 #  - 2.3.1
 ##  - 2.4.1
-  - 2.5.1
 
 gemfile:
-  - gemfiles/rails_5.0.gemfile
-  - gemfiles/rails_5.1.gemfile
   - gemfiles/rails_5.2.gemfile
+  - gemfiles/rails_5.1.gemfile
 
 matrix:
 #  exclude:

data/Appraisals

@@ -1,7 +1,7 @@
-appraise 'rails-5.0' do
-  gem 'rails', '~> 5.0.0'
-  gem 'dryer-config', '~> 5.0.0'
-end
+#appraise 'rails-5.0' do
+#  gem 'rails', '~> 5.0.0'
+#  gem 'dryer-config', '~> 5.0.0'
+#end
 
 appraise 'rails-5.1' do
   gem 'rails', '~> 5.1.0'

data/Gemfile

@@ -1,4 +1,5 @@
 source "https://rubygems.org"
+#ruby '2.6.0'
 gemspec
 
 gem 'rails'
@@ -8,6 +9,6 @@ group :test do
   gem 'simplecov', require: false
   gem 'minitest'
   gem 'capybara'
-  gem 'sqlite3'
+  gem 'sqlite3', '~> 1.3.6'
 #  gem 'slim'
 end

data/README.md

@@ -14,13 +14,13 @@ Install (migrate) one bag as a text field in a table to collect many fields.
 Additional fields or removal of them are easy;
 no migrations are required for them.
 
-Keep in mind that the collection is kept in a YAML bag, i.e.
-SQL commands can't access the bag fields.
+Keep in mind that the collection is kept in a YAML bag,
+i.e. SQL commands can't access the bag fields.
 
 Boolean and Date fields require explicit typing.
 
 Fields without typing accept any values which YAML can handle
-(e.g. @order.color = ['red', 'yellow']).
+(e.g. @order.colors = ['red', 'yellow']).
 
 Types :integer, :float and :string
 forces a conversion (.to_i, .to_f, .to_s) before storing the value,
@@ -40,13 +40,17 @@ Obsolete fields are deleted before_save by:
 Warning
 =======
 
-Please add a:
+1. Please add a:
 
     serialize :bag, Hash
 
 to each subclass accessing a bag field from a superclass.
 Using an "add_to_bag" in the subclass obsoletes the "serialize".
 
+2. delete_from_bag just delete the field from the record being saved.
+Other records are untouched,
+i.e. the value of the field will be kept in the database.
+
 
 Example
 =======
@@ -88,4 +92,4 @@ Test
 
     rake
 
-Copyright (c) 2009-2018 [Dittmar Krall], released under the MIT license
+Copyright (c) 2009-2019 [Dittmar Krall], released under the MIT license

data/act_with_bag.gemspec

@@ -21,5 +21,4 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'bundler', '~> 1'
   s.add_development_dependency 'rake', '~> 12'
   s.add_development_dependency 'appraisal', '~> 2'
-#  s.add_development_dependency 'combustion', '~> 0'
 end

data/gemfiles/rails_5.1.gemfile

@@ -10,7 +10,7 @@ group :test do
   gem "simplecov", require: false
   gem "minitest"
   gem "capybara"
-  gem "sqlite3"
+  gem "sqlite3", "~> 1.3.6"
 end
 
 gemspec path: "../"

data/gemfiles/rails_5.2.gemfile

@@ -10,7 +10,7 @@ group :test do
   gem "simplecov", require: false
   gem "minitest"
   gem "capybara"
-  gem "sqlite3"
+  gem "sqlite3", "~> 1.3.6"
 end
 
 gemspec path: "../"

data/lib/act_with_bag.rb

@@ -84,6 +84,19 @@ class << ActiveRecord::Base
   def add_accessor(baggie, type)
     accessor = baggie.to_s
     return  if accessor_present?(accessor)
+#MARS patch, new:
+    #
+    # The @baggies field is indispensable. Otherwise mistakes in renaming
+    # or deleting baggies (without renaming/deleting) the value entry from the
+    # bag, e. g. via delete_from_bag) cannot be detected in a clean way.
+    # Detecting the accessor would be not sufficient, as the accessor may be
+    # created by ActiveRecord::Base or the derived model and it may be
+    # doing completely other things (e. g. accessing a database column).
+    #
+    @baggies ||= {}
+    baggies = ( @baggies[self.to_s.underscore.to_sym] ||= {} )
+    baggies[ baggie ] = type
+#END
 
     type_sym = type.to_sym
     typing = {integer: '.to_i', float: '.to_f',

data/lib/act_with_bag/version.rb

@@ -1,3 +1,4 @@
 module ActWithBag
-  VERSION = '0.5.5'
+  VERSION = '0.5.6'     # 2019-02-15
+#  VERSION = '0.5.5'
 end

data/test/test_helper.rb

@@ -4,10 +4,10 @@ require 'rubygems'
 require 'minitest/autorun'
 require 'active_record'
 
-#SimpleCov.start do
-#  add_filter 'test'
-#  command_name 'Minitest'
-#end
+SimpleCov.start do
+  add_filter 'test'
+  command_name 'Minitest'
+end
 
 ActiveRecord::Base.establish_connection({
   adapter:  'sqlite3',

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: act_with_bag
 version: !ruby/object:Gem::Version
-  version: 0.5.5
+  version: 0.5.6
 platform: ruby
 authors:
 - Dittmar Krall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-26 00:00:00.000000000 Z
+date: 2019-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -69,7 +69,6 @@ files:
 - README.md
 - Rakefile
 - act_with_bag.gemspec
-- gemfiles/rails_5.0.gemfile
 - gemfiles/rails_5.1.gemfile
 - gemfiles/rails_5.2.gemfile
 - lib/act_with_bag.rb

data/gemfiles/rails_5.0.gemfile

@@ -1,16 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", "~> 5.0.0"
-gem "dryer-config", "~> 5.0.0"
-
-group :test do
-  gem "observr"
-  gem "simplecov", require: false
-  gem "minitest"
-  gem "capybara"
-  gem "sqlite3"
-end
-
-gemspec path: "../"