act-fluent-logger-rails 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da022b5df3afeaed17575f337eeed42f918e6844
-  data.tar.gz: 9332b7fbbefb9c774776d877b8de22ecb81aab92
+  metadata.gz: fb3b269dca0af21e27b94fe5fc0470ea8368f6d7
+  data.tar.gz: 1d8d7858797a83437b6af1ba5d6c434c31e41c82
 SHA512:
-  metadata.gz: 7d1a7c89d8eedfb64b07ebd69e9b90972e29a2e47cde4b4a354e87cc2773b6972162635d6fbdfbeb21c91b87ba3ac2bbae661447d00378b0a917bef46653a133
-  data.tar.gz: 71b560970dba82294045362445b55b6e13222e9bca1c037e7eab7e47b59c20b46f40a83def2aa91f667d262f158627866573067c6fe2587d58de5bec8f651482
+  metadata.gz: 9ba8d6eb2601eadb7aa8e1f0a91fcd8c9f0fd79c69832d11e66eb72a9b0284d917b6069c132978a4269b29329a0742c01cb99a331f0b6794af7aceb324acb4e7
+  data.tar.gz: a4b00ac33e2140b85f798fdd5e063124b7e31debb1a17213ba51ba68900c38a4d3ef6e5bdabf9605f3c74b415ca0dd0d939b3eb65ccdfa0fb96f4d3e353f7c08

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.8 / Nov 14 2015
+
+* Output Object#inspect if message is not String and not Exception.
+
 ## 0.1.7 / July 30 2015
 
 * Be able to log exceptions #15.

data/README.md

@@ -61,7 +61,7 @@ or set an environment variable FLUENTD_URL
  * fluent_host: The host name of Fluentd.
  * fluent_port: The port number of Fluentd.
  * tag: The tag of the Fluentd event.
- * messages_type: The type of log messags. 'string' or 'array'.
+ * messages_type: The type of log messages. 'string' or 'array'.
    If it is 'string', the log messages is a String.
 ```
 2013-01-18T15:04:50+09:00 foo {"messages":"Started GET \"/\" for 127.0.0.1 at 2013-01-18 15:04:49 +0900\nProcessing by TopController#index as HTML\nCompleted 200 OK in 635ms (Views: 479.3ms | ActiveRecord: 39.6ms)"],"level":"INFO"}

data/lib/act-fluent-logger-rails/logger.rb

@@ -75,10 +75,16 @@ module ActFluentLoggerRails
     def add_message(severity, message)
       @severity = severity if @severity < severity
 
-      if message.is_a? Exception
-        error_message = message.message + "\n" + message.backtrace.join("\n") + "\n"
-        message = error_message
-      end
+      message =
+        case message
+        when ::String
+          message
+        when ::Exception
+          "#{ message.message } (#{ message.class })\n" <<
+            (message.backtrace || []).join("\n")
+        else
+          message.inspect
+        end
 
       if message.encoding == Encoding::UTF_8
         @messages << message

data/lib/act-fluent-logger-rails/version.rb

@@ -1,3 +1,3 @@
 module ActFluentLoggerRails
-  VERSION = "0.1.7"
+  VERSION = "0.1.8"
 end

data/spec/logger_spec.rb

@@ -73,8 +73,15 @@ EOF
     end
 
     describe 'frozen ascii-8bit string' do
-      it 'join messages' do
+      before do
         logger.instance_variable_set(:@messages_type, :string)
+      end
+
+      after do
+        logger.instance_variable_set(:@messages_type, :array)
+      end
+
+      it 'join messages' do
         ascii = "\xe8\x8a\xb1".force_encoding('ascii-8bit').freeze
         logger.tagged([request]) {
           logger.info(ascii)
@@ -85,6 +92,29 @@ EOF
       end
     end
 
+    describe 'Exception' do
+      it 'output message, class, backtrace' do
+        begin
+          3 / 0
+        rescue => e
+          logger.tagged([request]) {
+            logger.error(e)
+          }
+          expect(@my_logger.log[0][1][:messages][0]).
+            to match(%r|divided by 0 \(ZeroDivisionError\).*spec/logger_spec\.rb:|m)
+        end
+      end
+    end
+
+    describe 'Object' do
+      it 'output inspect' do
+        x = Object.new
+        logger.tagged([request]) {
+          logger.info(x)
+        }
+        expect(@my_logger.log[0][1][:messages][0]).to eq(x.inspect)
+      end
+    end
   end
 
   describe "use ENV['FLUENTD_URL']" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: act-fluent-logger-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - TAHARA Yoshinori
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-30 00:00:00.000000000 Z
+date: 2015-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec