acread 0.5.3 → 0.6.0

data/Gemfile

@@ -3,6 +3,10 @@ source 'http://rubygems.org/'
 # gem dependencies
 gem 'rails', '>= 3.0'
 
+if Gem::Version.new(String.new(RUBY_VERSION)) > Gem::Version.new('1.9')
+  gem 'continuable', :path => '~/Projects/continuable'
+end
+
 # dependencies to develop your gem here.
 # Include everything needed to run rake, tests, features, etc.
 group :development do

data/README.md

@@ -9,6 +9,8 @@ When you deprecate an attribute, acread can helps you in 3 ways :
 1. ignore this atribute when serializing the object through to_json, to_xml ...
 1. helps your zero downtime migration by ignoring the attribute for objects already in memory when saving to database.
 
+Have a look at this [London Ruby Group Lightning talk](http://skillsmatter.com/podcast/ajax-ria/hulk-smash) for a quick description of that 3 steps.
+
 # Usage
 
 ## Installation
@@ -29,21 +31,26 @@ end
 ## find attribute usage
 you can catch the `DeprecatedAttributeError` exception and for example put a backtrace in a specific logger.
 
+If you are using ruby > 1.9, Acread use the gem continuable (https://github.com/cmaruz/continuable).
+The DeprecatedAttributeError can then be continued, this mean you can catch it and continue normal ActiveRecord behavior.
+You're code hunting can then be done without any effect on your datas by simply catching the exception, logging and continuing.
+
 ```ruby
 class ApplicationController
 	rescue_from DeprecatedAttributeError, :with => :log_deprecate
-	
+
 	private
-	
+
 	def deprecated_logger
 		@@deprecated_logger ||= Logger.new("#{Rails.root}/log/deprecated_calls.log")
 	end
-	
+
 	def log_deprecated e
 		deprecated_logger.error(e.stacktrace.join("\n"))
+    e.continue
 	end
 end
-```    
+```
 
 ## zero downtime migration
 When you are done with cleaning your code from any usage of deprecated attributes, you can prepare a migration including some drop_columns.
@@ -62,7 +69,7 @@ class RemoveLongNames < ActiveRecord::Migration
   end
 end
 ```
-    
+
 Then you can safely follow the steps :
 
 

data/VERSION

@@ -1 +1 @@
-0.5.3
+0.6.0

data/acread.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "acread"
-  s.version = "0.5.3"
+  s.version = "0.6.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["yann ARMAND", "Nick Campbell"]
-  s.date = "2012-12-06"
+  s.date = "2013-02-18"
   s.description = "An ActiveRecord Extension to deprecate attributes"
   s.email = "yann@harakys.com"
   s.extra_rdoc_files = [
@@ -41,6 +41,7 @@ Gem::Specification.new do |s|
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<rails>, [">= 3.0"])
+      s.add_runtime_dependency(%q<continuable>, [">= 0"])
       s.add_development_dependency(%q<shoulda>, [">= 0"])
       s.add_development_dependency(%q<rdoc>, [">= 3.12"])
       s.add_development_dependency(%q<bundler>, [">= 1.0.0"])
@@ -48,6 +49,7 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<sqlite3>, [">= 0"])
     else
       s.add_dependency(%q<rails>, [">= 3.0"])
+      s.add_dependency(%q<continuable>, [">= 0"])
       s.add_dependency(%q<shoulda>, [">= 0"])
       s.add_dependency(%q<rdoc>, [">= 3.12"])
       s.add_dependency(%q<bundler>, [">= 1.0.0"])
@@ -56,6 +58,7 @@ Gem::Specification.new do |s|
     end
   else
     s.add_dependency(%q<rails>, [">= 3.0"])
+    s.add_dependency(%q<continuable>, [">= 0"])
     s.add_dependency(%q<shoulda>, [">= 0"])
     s.add_dependency(%q<rdoc>, [">= 3.12"])
     s.add_dependency(%q<bundler>, [">= 1.0.0"])

data/lib/acread.rb

@@ -1,2 +1,7 @@
-require 'acread/active_record_ext'
+module Acread
+  def self.run_19?
+    Gem::Version.new(String.new(RUBY_VERSION)) > Gem::Version.new('1.9')
+  end
+end
 
+require 'acread/active_record_ext'

data/lib/acread/active_record_ext.rb

@@ -2,7 +2,8 @@ require 'active_record'
 require 'acread/deprecatable'
 
 class ActiveRecord::Base
-  extend Deprecatable
+
+  include Deprecatable
 
   def columns
     self.class.columns.reject { |c| (self.class.deprecated_attributes || []).include? c.name.to_s}

data/lib/acread/deprecatable.rb

@@ -1,32 +1,45 @@
+require 'continuable' if Acread::run_19?
+
 module Deprecatable
 
+  def self.included(base)
+    base.extend ClassMethods
+  end
+
   ACCESSORS = [ '', '=', '_before_type_cast', '?', '_changed?', '_change', '_will_change!', '_was']
 
-  def deprecate_attribute attr
-    @deprecated_attributes ||=[]
-    @deprecated_attributes << attr.to_s
-    overide_accessors attr
-  end
+  module ClassMethods
+    def deprecate_attribute(attr, opts={})
+      opts ||={}
+      @deprecated_attributes ||=[]
+      @deprecated_attributes << attr.to_s
+      overide_accessors attr, opts
+    end
 
-  def deprecated_attributes
-    @deprecated_attributes
-  end
+    def deprecated_attributes
+      @deprecated_attributes
+    end
 
-  def accessors
-    # TODO: replace this constant by an ActiveRecord inspection
-    ACCESSORS
-  end
+    def accessors
+      # TODO: replace this constant by an ActiveRecord inspection
+      ACCESSORS
+    end
 
-  def overide_accessors attr
-    msg = "You can't access atribute #{attr}, it has been deprecated"
-    accessors.each do |term|
-      define_method("#{attr}#{term}") do |*args|
-        raise DeprecatedAttributeError, msg
+    def overide_accessors(attr, opts)
+      msg = "You can't access atribute #{attr}, it has been deprecated"
+      accessors.each do |term|
+        define_method("#{attr}#{term}") do |*args|
+          raise DeprecatedAttributeError, msg
+          (args.length >0 ? super(args) : super()).first # call ActiveRecord behavior if previous exception have been continued
+        end
       end
     end
   end
 
-end
+  class DeprecatedAttributeError < Exception
+    include Continuable if Acread::run_19?
+  end
 
-class DeprecatedAttributeError < RuntimeError
 end
+
+

data/test/test_acread.rb

@@ -25,17 +25,28 @@ class TestAcread < Test::Unit::TestCase
   end
 
   def test_cretor_with_deprecated_field_raise_exception
-    assert_raise(DeprecatedAttributeError) { Person.create(:long_name => 'should not see this')    }
+    assert_raise(Deprecatable::DeprecatedAttributeError) { Person.create(:long_name => 'should not see this')    }
   end
 
   def test_read_deprecated_raise_exception
-    assert_raise(DeprecatedAttributeError) { @bob.long_name }
+    assert_raise(Deprecatable::DeprecatedAttributeError) { @bob.long_name }
   end
 
   def test_write_deprecated_raise_exception
-    assert_raise(DeprecatedAttributeError) { @bob.long_name = 'Bon' }
+    assert_raise(Deprecatable::DeprecatedAttributeError) { @bob.long_name = 'Bon' }
   end
 
+  def test_write_dreprecated_with_continuation
+    return true unless Acread::run_19?
+    v = 'failure'
+    begin
+      @bob.long_name = 'bobob'
+      v = @bob.long_name
+    rescue Deprecatable::DeprecatedAttributeError => e
+      e.continue
+    end
+    assert_equal 'bobob', v
+  end
 
   def test_hash_exclude_deprecated_attributes
     h = @bob.serializable_hash
@@ -50,18 +61,18 @@ class TestAcread < Test::Unit::TestCase
   def test_non_deprecated_class_can_read_all_attributes
     assert @james.long_name.is_a? String
   end
- 
+
   def test_non_deprecated_class_can_write_all_attributes
     s = 'james the short'
     @james.long_name = s
     assert @james.long_name == s
   end
-  
+
   def test_non_deprecated_class_columns_output_all_attributes
     h = @james.send(:columns).map(&:name)
     assert h.include? 'long_name'
   end
-  
+
   def test_non_deprecated_class_hash_output_all_attributes
     h = @james.serializable_hash
     assert h.keys.include? 'long_name'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acread
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.6.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-06 00:00:00.000000000 Z
+date: 2013-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -28,6 +28,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: continuable
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: shoulda
   requirement: !ruby/object:Gem::Requirement
@@ -143,7 +159,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1381916777911166831
+      hash: -2723091470666414279
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: