acp-sdk 0.3.0 → 0.5.0

data/lib/acp/transport/stdio.rb

@@ -15,6 +15,7 @@ class ACP::Transport::Stdio
   # @rbs @pending: Hash[untyped, Thread::Queue]
   # @rbs @next_id: Integer
   # @rbs @closed: bool
+  # @rbs @logger: ACP::Transport::_Logger
 
   CONNECTION_CLOSED = ACP::RequestError.new(
     code: ACP::RequestError::INTERNAL_ERROR, message: 'Connection closed'
@@ -22,8 +23,9 @@ class ACP::Transport::Stdio
 
   # @rbs input: _Reader
   # @rbs output: _Writer
+  # @rbs logger: ACP::Transport::_Logger
   # @rbs return: void
-  def initialize(input:, output:)
+  def initialize(input:, output:, logger: ACP::Transport::StderrLogger.new)
     @input = input
     @output = output
     @write_lock = Mutex.new
@@ -31,6 +33,7 @@ class ACP::Transport::Stdio
     @pending = {}
     @next_id = 0
     @closed = false
+    @logger = logger
   end
 
   # Returns the reader thread, which ends at EOF on input after releasing any
@@ -94,7 +97,7 @@ class ACP::Transport::Stdio
       # Run on the reader thread so notifications (session/update) keep their
       # order; a JSON-RPC notification has no reply to carry a handler error.
       handler = notifications[method]
-      quietly { handler.call(message['params']) } if handler
+      quietly('notification handler') { handler.call(message['params']) } if handler
     elsif message.key?('result')
       settle(message['id'], message['result'])
     elsif error.is_a?(Hash) && error['code'].is_a?(Integer) && error['message'].is_a?(String)
@@ -126,7 +129,7 @@ class ACP::Transport::Stdio
       case outcome
       when ACP::Transport::Reply
         reply(id, outcome.result)
-        quietly(&outcome.after)
+        quietly('reply after callback', &outcome.after)
       else reply(id, outcome)
       end
     end
@@ -136,12 +139,13 @@ class ACP::Transport::Stdio
   # Reply's after once the reply is on the wire. An exception must not kill
   # the reader thread or print a thread report.
   #
+  # @rbs label: String
   # @rbs &block: () -> void
   # @rbs return: void
-  def quietly
+  def quietly(label)
     yield
-  rescue StandardError
-    nil
+  rescue StandardError => e
+    @logger.error("#{label} raised #{e.class}: #{e.message}")
   end
 
   # Handlers are application code at the protocol boundary: an exception
@@ -198,6 +202,9 @@ class ACP::Transport::Stdio
     end
   end
 
+  # A closed peer must not kill the thread writing the reply: the reader has
+  # to keep draining input so pending requests still settle at EOF.
+  #
   # @rbs message: Hash[String, untyped]
   # @rbs return: void
   def write(message)
@@ -206,5 +213,7 @@ class ACP::Transport::Stdio
       @output.write(line)
       @output.flush
     end
+  rescue Errno::EPIPE => e
+    @logger.warn("write to closed peer: #{e.class}: #{e.message}")
   end
 end

data/lib/acp/types/session_update/tool_call.rb

@@ -9,6 +9,9 @@ class ACP::Types::SessionUpdate::ToolCall
   # @dynamic title
   attr_reader :title #: String
 
+  # @dynamic name
+  attr_reader :name #: String?
+
   # @dynamic kind
   attr_reader :kind #: String?
 
@@ -32,6 +35,7 @@ class ACP::Types::SessionUpdate::ToolCall
 
   # @rbs tool_call_id: String
   # @rbs title: String
+  # @rbs name: String?
   # @rbs kind: String?
   # @rbs status: String?
   # @rbs content: Array[ACP::Types::ToolCallContent::t]?
@@ -43,6 +47,7 @@ class ACP::Types::SessionUpdate::ToolCall
   def initialize(
     tool_call_id:,
     title:,
+    name: nil,
     kind: nil,
     status: nil,
     content: nil,
@@ -53,6 +58,7 @@ class ACP::Types::SessionUpdate::ToolCall
   )
     @tool_call_id = tool_call_id
     @title = title
+    @name = name
     @kind = kind
     @status = status
     @content = content
@@ -69,6 +75,7 @@ class ACP::Types::SessionUpdate::ToolCall
     new(
       tool_call_id: hash.fetch('toolCallId'),
       title: hash.fetch('title'),
+      name: hash['name'],
       kind: hash['kind'],
       status: hash['status'],
       content: hash['content']&.map { |item| ACP::Types::ToolCallContent.from_h(item) },
@@ -85,6 +92,7 @@ class ACP::Types::SessionUpdate::ToolCall
       'sessionUpdate' => 'tool_call',
       'toolCallId' => tool_call_id,
       'title' => title,
+      'name' => name,
       'kind' => kind,
       'status' => status,
       'content' => content&.map(&:to_h),

data/lib/acp/types/session_update/tool_call_update.rb

@@ -15,6 +15,9 @@ class ACP::Types::SessionUpdate::ToolCallUpdate
   # @dynamic title
   attr_reader :title #: String?
 
+  # @dynamic name
+  attr_reader :name #: String?
+
   # @dynamic content
   attr_reader :content #: Array[ACP::Types::ToolCallContent::t]?
 
@@ -34,6 +37,7 @@ class ACP::Types::SessionUpdate::ToolCallUpdate
   # @rbs kind: String?
   # @rbs status: String?
   # @rbs title: String?
+  # @rbs name: String?
   # @rbs content: Array[ACP::Types::ToolCallContent::t]?
   # @rbs locations: Array[ACP::Types::ToolCallLocation]?
   # @rbs raw_input: untyped
@@ -45,6 +49,7 @@ class ACP::Types::SessionUpdate::ToolCallUpdate
     kind: nil,
     status: nil,
     title: nil,
+    name: nil,
     content: nil,
     locations: nil,
     raw_input: nil,
@@ -55,6 +60,7 @@ class ACP::Types::SessionUpdate::ToolCallUpdate
     @kind = kind
     @status = status
     @title = title
+    @name = name
     @content = content
     @locations = locations
     @raw_input = raw_input
@@ -71,6 +77,7 @@ class ACP::Types::SessionUpdate::ToolCallUpdate
       kind: hash['kind'],
       status: hash['status'],
       title: hash['title'],
+      name: hash['name'],
       content: hash['content']&.map { |item| ACP::Types::ToolCallContent.from_h(item) },
       locations: hash['locations']&.map { |item| ACP::Types::ToolCallLocation.from_h(item) },
       raw_input: hash['rawInput'],
@@ -87,6 +94,7 @@ class ACP::Types::SessionUpdate::ToolCallUpdate
       'kind' => kind,
       'status' => status,
       'title' => title,
+      'name' => name,
       'content' => content&.map(&:to_h),
       'locations' => locations&.map(&:to_h),
       'rawInput' => raw_input,

data/lib/acp/types/tool_call.rb

@@ -9,6 +9,9 @@ class ACP::Types::ToolCall
   # @dynamic title
   attr_reader :title #: String
 
+  # @dynamic name
+  attr_reader :name #: String?
+
   # @dynamic kind
   attr_reader :kind #: String?
 
@@ -32,6 +35,7 @@ class ACP::Types::ToolCall
 
   # @rbs tool_call_id: String
   # @rbs title: String
+  # @rbs name: String?
   # @rbs kind: String?
   # @rbs status: String?
   # @rbs content: Array[ACP::Types::ToolCallContent::t]?
@@ -43,6 +47,7 @@ class ACP::Types::ToolCall
   def initialize(
     tool_call_id:,
     title:,
+    name: nil,
     kind: nil,
     status: nil,
     content: nil,
@@ -53,6 +58,7 @@ class ACP::Types::ToolCall
   )
     @tool_call_id = tool_call_id
     @title = title
+    @name = name
     @kind = kind
     @status = status
     @content = content
@@ -69,6 +75,7 @@ class ACP::Types::ToolCall
     new(
       tool_call_id: hash.fetch('toolCallId'),
       title: hash.fetch('title'),
+      name: hash['name'],
       kind: hash['kind'],
       status: hash['status'],
       content: hash['content']&.map { |item| ACP::Types::ToolCallContent.from_h(item) },
@@ -84,6 +91,7 @@ class ACP::Types::ToolCall
     {
       'toolCallId' => tool_call_id,
       'title' => title,
+      'name' => name,
       'kind' => kind,
       'status' => status,
       'content' => content&.map(&:to_h),

data/lib/acp/types/tool_call_update.rb

@@ -15,6 +15,9 @@ class ACP::Types::ToolCallUpdate
   # @dynamic title
   attr_reader :title #: String?
 
+  # @dynamic name
+  attr_reader :name #: String?
+
   # @dynamic content
   attr_reader :content #: Array[ACP::Types::ToolCallContent::t]?
 
@@ -34,6 +37,7 @@ class ACP::Types::ToolCallUpdate
   # @rbs kind: String?
   # @rbs status: String?
   # @rbs title: String?
+  # @rbs name: String?
   # @rbs content: Array[ACP::Types::ToolCallContent::t]?
   # @rbs locations: Array[ACP::Types::ToolCallLocation]?
   # @rbs raw_input: untyped
@@ -45,6 +49,7 @@ class ACP::Types::ToolCallUpdate
     kind: nil,
     status: nil,
     title: nil,
+    name: nil,
     content: nil,
     locations: nil,
     raw_input: nil,
@@ -55,6 +60,7 @@ class ACP::Types::ToolCallUpdate
     @kind = kind
     @status = status
     @title = title
+    @name = name
     @content = content
     @locations = locations
     @raw_input = raw_input
@@ -71,6 +77,7 @@ class ACP::Types::ToolCallUpdate
       kind: hash['kind'],
       status: hash['status'],
       title: hash['title'],
+      name: hash['name'],
       content: hash['content']&.map { |item| ACP::Types::ToolCallContent.from_h(item) },
       locations: hash['locations']&.map { |item| ACP::Types::ToolCallLocation.from_h(item) },
       raw_input: hash['rawInput'],
@@ -86,6 +93,7 @@ class ACP::Types::ToolCallUpdate
       'kind' => kind,
       'status' => status,
       'title' => title,
+      'name' => name,
       'content' => content&.map(&:to_h),
       'locations' => locations&.map(&:to_h),
       'rawInput' => raw_input,

data/lib/acp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ACP
-  VERSION = '0.3.0'
+  VERSION = '0.5.0'
 end

data/sig/generated/acp/agent_connection/client.rbs

@@ -55,6 +55,14 @@ class ACP::AgentConnection::Client
   # @rbs return: ACP::Types::ReleaseTerminalResponse | ACP::RequestError
   def release_terminal: (ACP::Types::ReleaseTerminalRequest request) -> (ACP::Types::ReleaseTerminalResponse | ACP::RequestError)
 
+  # @rbs request: ACP::Types::CreateElicitationRequest
+  # @rbs return: ACP::Types::CreateElicitationResponse | ACP::RequestError
+  def create_elicitation: (ACP::Types::CreateElicitationRequest request) -> (ACP::Types::CreateElicitationResponse | ACP::RequestError)
+
+  # @rbs notification: ACP::Types::CompleteElicitationNotification
+  # @rbs return: void
+  def complete_elicitation: (ACP::Types::CompleteElicitationNotification notification) -> void
+
   private
 
   # @rbs rpc_method: String
@@ -68,11 +76,4 @@ class ACP::AgentConnection::Client
   # @rbs request: ACP::AgentConnection::_Response
   # @rbs return: untyped
   def terminal_call: (String rpc_method, ACP::AgentConnection::_Parser type, ACP::AgentConnection::_Response request) -> untyped
-
-  # Same method-not-found code a peer would send, but with a message that says
-  # the refusal was local, so logs can tell the two cases apart.
-  #
-  # @rbs capability: String
-  # @rbs return: ACP::RequestError
-  def unadvertised: (String capability) -> ACP::RequestError
 end

data/sig/generated/acp/agent_connection/optional_method/logout.rbs

@@ -0,0 +1,13 @@
+# Generated from lib/acp/agent_connection/optional_method/logout.rb with RBS::Inline
+
+module ACP::AgentConnection::OptionalMethod::Logout
+  # @rbs return: String
+  def rpc_method: () -> String
+
+  # @rbs return: Symbol
+  def agent_method: () -> Symbol
+
+  # @rbs initialize_response: ACP::Types::InitializeResponse
+  # @rbs return: bool
+  def advertised?: (ACP::Types::InitializeResponse initialize_response) -> bool
+end

data/sig/generated/acp/agent_connection.rbs

@@ -1,12 +1,18 @@
 # Generated from lib/acp/agent_connection.rb with RBS::Inline
 
 class ACP::AgentConnection
-  @transport: ACP::AgentConnection::_Transport
-
-  @initialize_response: ACP::Types::InitializeResponse
+  @logger: ACP::Transport::_Logger
 
   @factory: ^(ACP::AgentConnection::Client) -> ACP::AgentConnection::_Agent
 
+  @auth_methods: Array[ACP::Types::AuthMethod::t]
+
+  @agent_info: ACP::Types::Implementation?
+
+  @capabilities: ACP::Types::AgentCapabilities
+
+  @transport: ACP::AgentConnection::_Transport
+
   PROTOCOL_VERSION: Integer
 
   OPTIONAL: Array[ACP::AgentConnection::_OptionalMethod]
@@ -20,9 +26,10 @@ class ACP::AgentConnection
   # @rbs capabilities: ACP::Types::AgentCapabilities
   # @rbs agent_info: ACP::Types::Implementation?
   # @rbs auth_methods: Array[ACP::Types::AuthMethod::t]
+  # @rbs logger: ACP::Transport::_Logger
   # @rbs &factory: (ACP::AgentConnection::Client) -> ACP::AgentConnection::_Agent
   # @rbs return: void
-  def initialize: (transport: ACP::AgentConnection::_Transport, capabilities: ACP::Types::AgentCapabilities, ?agent_info: ACP::Types::Implementation?, ?auth_methods: Array[ACP::Types::AuthMethod::t]) { (ACP::AgentConnection::Client) -> ACP::AgentConnection::_Agent } -> void
+  def initialize: (transport: ACP::AgentConnection::_Transport, capabilities: ACP::Types::AgentCapabilities, ?agent_info: ACP::Types::Implementation?, ?auth_methods: Array[ACP::Types::AuthMethod::t], ?logger: ACP::Transport::_Logger) { (ACP::AgentConnection::Client) -> ACP::AgentConnection::_Agent } -> void
 
   # @rbs return: Thread
   def start: () -> Thread
@@ -38,6 +45,13 @@ class ACP::AgentConnection
   # @rbs return: Hash[String, ^(untyped) -> void]
   def notifications: (ACP::AgentConnection::_Agent agent) -> Hash[String, ^(untyped) -> void]
 
+  # A notification has no reply to carry a parse failure.
+  #
+  # @rbs agent: ACP::AgentConnection::_Agent
+  # @rbs params: untyped
+  # @rbs return: void
+  def cancel: (ACP::AgentConnection::_Agent agent, untyped params) -> void
+
   # Generated from_h raises on a missing key or a value of the wrong shape.
   #
   # @rbs type: ACP::AgentConnection::_Parser
@@ -50,6 +64,18 @@ class ACP::AgentConnection
   # @rbs return: ACP::Types::InitializeResponse
   def connect: (ACP::AgentConnection::Client client, ACP::Types::InitializeRequest request) -> ACP::Types::InitializeResponse
 
+  # @rbs auth_methods: Array[ACP::Types::AuthMethod::t]
+  # @rbs return: ACP::Types::InitializeResponse
+  def initialize_response: (Array[ACP::Types::AuthMethod::t] auth_methods) -> ACP::Types::InitializeResponse
+
+  # @rbs capabilities: ACP::Types::ClientCapabilities
+  # @rbs return: Array[ACP::Types::AuthMethod::t]
+  def auth_methods: (ACP::Types::ClientCapabilities capabilities) -> Array[ACP::Types::AuthMethod::t]
+
+  # @rbs method: ACP::Types::AuthMethod::t
+  # @rbs return: bool
+  def terminal_auth_method?: (ACP::Types::AuthMethod::t method) -> bool
+
   # session_created runs after the reply because the client must know the
   # session id before updates for it (e.g. available commands) arrive.
   #

data/sig/generated/acp/client_connection.rbs

@@ -1,23 +1,36 @@
 # Generated from lib/acp/client_connection.rb with RBS::Inline
 
 class ACP::ClientConnection
+  @logger: ACP::Transport::_Logger
+
   @streams: Hash[String, Thread::Queue]
 
   @lock: Thread::Mutex
 
+  @fs_capabilities: ACP::Types::FileSystemCapabilities?
+
   @updates: ACP::ClientConnection::_UpdateHandler
 
+  @write_text_file: (^(ACP::Types::WriteTextFileRequest) -> (ACP::Types::WriteTextFileResponse | ACP::RequestError))?
+
+  @read_text_file: (^(ACP::Types::ReadTextFileRequest) -> (ACP::Types::ReadTextFileResponse | ACP::RequestError))?
+
   @permission: ACP::ClientConnection::_PermissionHandler
 
   @transport: ACP::AgentConnection::_Transport
 
+  PROTOCOL_VERSION: Integer
+
   IGNORE: ^(ACP::Types::SessionNotification) -> void
 
   # @rbs transport: ACP::AgentConnection::_Transport
   # @rbs permission: ACP::ClientConnection::_PermissionHandler
+  # @rbs read_text_file: (^(ACP::Types::ReadTextFileRequest) -> (ACP::Types::ReadTextFileResponse | ACP::RequestError))?
+  # @rbs write_text_file: (^(ACP::Types::WriteTextFileRequest) -> (ACP::Types::WriteTextFileResponse | ACP::RequestError))?
   # @rbs updates: ACP::ClientConnection::_UpdateHandler
+  # @rbs logger: ACP::Transport::_Logger
   # @rbs return: void
-  def initialize: (transport: ACP::AgentConnection::_Transport, permission: ACP::ClientConnection::_PermissionHandler, ?updates: ACP::ClientConnection::_UpdateHandler) -> void
+  def initialize: (transport: ACP::AgentConnection::_Transport, permission: ACP::ClientConnection::_PermissionHandler, ?read_text_file: (^(ACP::Types::ReadTextFileRequest) -> (ACP::Types::ReadTextFileResponse | ACP::RequestError))?, ?write_text_file: (^(ACP::Types::WriteTextFileRequest) -> (ACP::Types::WriteTextFileResponse | ACP::RequestError))?, ?updates: ACP::ClientConnection::_UpdateHandler, ?logger: ACP::Transport::_Logger) -> void
 
   # @rbs return: Thread
   def start: () -> Thread
@@ -47,10 +60,44 @@ class ACP::ClientConnection
   # @rbs return: ACP::Types::ListSessionsResponse | ACP::RequestError
   def session_list: (ACP::Types::ListSessionsRequest request) -> (ACP::Types::ListSessionsResponse | ACP::RequestError)
 
+  # The agent does not replay history on resume, so unlike session_load there
+  # is nothing to stream and no block is taken.
+  #
+  # @rbs request: ACP::Types::ResumeSessionRequest
+  # @rbs return: ACP::Types::ResumeSessionResponse | ACP::RequestError
+  def session_resume: (ACP::Types::ResumeSessionRequest request) -> (ACP::Types::ResumeSessionResponse | ACP::RequestError)
+
+  # @rbs request: ACP::Types::CloseSessionRequest
+  # @rbs return: ACP::Types::CloseSessionResponse | ACP::RequestError
+  def session_close: (ACP::Types::CloseSessionRequest request) -> (ACP::Types::CloseSessionResponse | ACP::RequestError)
+
+  # @rbs request: ACP::Types::DeleteSessionRequest
+  # @rbs return: ACP::Types::DeleteSessionResponse | ACP::RequestError
+  def session_delete: (ACP::Types::DeleteSessionRequest request) -> (ACP::Types::DeleteSessionResponse | ACP::RequestError)
+
   # @rbs notification: ACP::Types::CancelNotification
   # @rbs return: void
   def session_cancel: (ACP::Types::CancelNotification notification) -> void
 
+  # @rbs request: ACP::Types::SetSessionModeRequest
+  # @rbs return: ACP::Types::SetSessionModeResponse | ACP::RequestError
+  def session_set_mode: (ACP::Types::SetSessionModeRequest request) -> (ACP::Types::SetSessionModeResponse | ACP::RequestError)
+
+  # The reply carries the session's complete option list, so it replaces any
+  # state held from an earlier reply rather than merging into it.
+  #
+  # @rbs request: ACP::Types::SetSessionConfigOptionRequest
+  # @rbs return: ACP::Types::SetSessionConfigOptionResponse | ACP::RequestError
+  def session_set_config_option: (ACP::Types::SetSessionConfigOptionRequest request) -> (ACP::Types::SetSessionConfigOptionResponse | ACP::RequestError)
+
+  # @rbs request: ACP::Types::AuthenticateRequest
+  # @rbs return: ACP::Types::AuthenticateResponse | ACP::RequestError
+  def authenticate: (ACP::Types::AuthenticateRequest request) -> (ACP::Types::AuthenticateResponse | ACP::RequestError)
+
+  # @rbs request: ACP::Types::LogoutRequest
+  # @rbs return: ACP::Types::LogoutResponse | ACP::RequestError
+  def logout: (ACP::Types::LogoutRequest request) -> (ACP::Types::LogoutResponse | ACP::RequestError)
+
   private
 
   # @rbs type: ACP::AgentConnection::_Parser
@@ -70,7 +117,8 @@ class ACP::ClientConnection
   def stream: (String session_id, String method, Hash[String, untyped] params) { (ACP::Types::SessionUpdate::t) -> void } -> (Hash[String, untyped] | ACP::RequestError)
 
   # Pushes under the lock so a stream cannot close its queue between the
-  # lookup and the push.
+  # lookup and the push. A malformed notification has no reply to carry the
+  # failure.
   #
   # @rbs params: untyped
   # @rbs return: void
@@ -79,4 +127,21 @@ class ACP::ClientConnection
   # @rbs params: untyped
   # @rbs return: (ACP::Types::RequestPermissionResponse | ACP::RequestError)
   def request_permission: (untyped params) -> (ACP::Types::RequestPermissionResponse | ACP::RequestError)
+
+  # The routes are registered at start, before connect records the advertised
+  # capabilities, so each one answers -32601 until then.
+  #
+  # @rbs params: untyped
+  # @rbs return: (ACP::Types::ReadTextFileResponse | ACP::RequestError)
+  def read_text_file: (untyped params) -> (ACP::Types::ReadTextFileResponse | ACP::RequestError)
+
+  # @rbs params: untyped
+  # @rbs return: (ACP::Types::WriteTextFileResponse | ACP::RequestError)
+  def write_text_file: (untyped params) -> (ACP::Types::WriteTextFileResponse | ACP::RequestError)
+
+  # The fs capabilities initialize advertises that no injected handler serves.
+  #
+  # @rbs capabilities: ACP::Types::FileSystemCapabilities?
+  # @rbs return: Array[String]
+  def unserved_fs_methods: (ACP::Types::FileSystemCapabilities? capabilities) -> Array[String]
 end

data/sig/generated/acp/request_error.rbs

@@ -50,9 +50,33 @@ class ACP::RequestError
   # @rbs return: ACP::RequestError
   def self.invalid_params: () -> ACP::RequestError
 
+  # The method-not-found code for a method the client's capabilities do not
+  # advertise, with a message that names the capability so it can be told
+  # apart from an unknown method.
+  #
+  # @rbs capability: String
+  # @rbs return: ACP::RequestError
+  def self.unadvertised: (String capability) -> ACP::RequestError
+
   # @rbs return: ACP::RequestError
   def self.internal_error: () -> ACP::RequestError
 
+  # The message tells a malformed peer reply apart from an internal error a
+  # handler raised, though both use the -32603 code.
+  #
+  # @rbs response: untyped
+  # @rbs return: ACP::RequestError
+  def self.invalid_response: (untyped response) -> ACP::RequestError
+
+  # A local refusal of an initialize reply that names a version the SDK does
+  # not speak; the message names both versions so logs can tell it from a
+  # peer's error.
+  #
+  # @rbs requested: Integer
+  # @rbs returned: Integer
+  # @rbs return: ACP::RequestError
+  def self.unsupported_protocol_version: (requested: Integer, returned: Integer) -> ACP::RequestError
+
   # @rbs return: ACP::RequestError
   def self.request_cancelled: () -> ACP::RequestError
 

data/sig/generated/acp/transport/stderr_logger.rbs

@@ -0,0 +1,13 @@
+# Generated from lib/acp/transport/stderr_logger.rb with RBS::Inline
+
+# The default sink for dropped messages and swallowed errors: the spec
+# sanctions agents logging to stderr.
+class ACP::Transport::StderrLogger
+  # @rbs message: String
+  # @rbs return: void
+  def warn: (String message) -> void
+
+  # @rbs message: String
+  # @rbs return: void
+  def error: (String message) -> void
+end

data/sig/generated/acp/transport/stdio.rbs

@@ -6,6 +6,8 @@
 # outbound request mid-turn and still see notifications (e.g. session/cancel)
 # that arrive meanwhile.
 class ACP::Transport::Stdio
+  @logger: ACP::Transport::_Logger
+
   @closed: bool
 
   @next_id: Integer
@@ -24,8 +26,9 @@ class ACP::Transport::Stdio
 
   # @rbs input: _Reader
   # @rbs output: _Writer
+  # @rbs logger: ACP::Transport::_Logger
   # @rbs return: void
-  def initialize: (input: _Reader, output: _Writer) -> void
+  def initialize: (input: _Reader, output: _Writer, ?logger: ACP::Transport::_Logger) -> void
 
   # Returns the reader thread, which ends at EOF on input after releasing any
   # pending outbound requests.
@@ -73,9 +76,10 @@ class ACP::Transport::Stdio
   # Reply's after once the reply is on the wire. An exception must not kill
   # the reader thread or print a thread report.
   #
+  # @rbs label: String
   # @rbs &block: () -> void
   # @rbs return: void
-  def quietly: () { () -> void } -> void
+  def quietly: (String label) { () -> void } -> void
 
   # Handlers are application code at the protocol boundary: an exception
   # becomes an error response instead of killing the thread serving it.
@@ -105,6 +109,9 @@ class ACP::Transport::Stdio
   # @rbs return: void
   def close: () -> void
 
+  # A closed peer must not kill the thread writing the reply: the reader has
+  # to keep draining input so pending requests still settle at EOF.
+  #
   # @rbs message: Hash[String, untyped]
   # @rbs return: void
   def write: (Hash[String, untyped] message) -> void

data/sig/generated/acp/types/session_update/tool_call.rbs

@@ -7,6 +7,9 @@ class ACP::Types::SessionUpdate::ToolCall
   # @dynamic title
   attr_reader title: String
 
+  # @dynamic name
+  attr_reader name: String?
+
   # @dynamic kind
   attr_reader kind: String?
 
@@ -30,6 +33,7 @@ class ACP::Types::SessionUpdate::ToolCall
 
   # @rbs tool_call_id: String
   # @rbs title: String
+  # @rbs name: String?
   # @rbs kind: String?
   # @rbs status: String?
   # @rbs content: Array[ACP::Types::ToolCallContent::t]?
@@ -38,7 +42,7 @@ class ACP::Types::SessionUpdate::ToolCall
   # @rbs raw_output: untyped
   # @rbs meta: Hash[String, untyped]?
   # @rbs return: void
-  def initialize: (tool_call_id: String, title: String, ?kind: String?, ?status: String?, ?content: Array[ACP::Types::ToolCallContent::t]?, ?locations: Array[ACP::Types::ToolCallLocation]?, ?raw_input: untyped, ?raw_output: untyped, ?meta: Hash[String, untyped]?) -> void
+  def initialize: (tool_call_id: String, title: String, ?name: String?, ?kind: String?, ?status: String?, ?content: Array[ACP::Types::ToolCallContent::t]?, ?locations: Array[ACP::Types::ToolCallLocation]?, ?raw_input: untyped, ?raw_output: untyped, ?meta: Hash[String, untyped]?) -> void
 
   # @rbs hash: Hash[String, untyped]
   # @rbs return: ACP::Types::SessionUpdate::ToolCall

data/sig/generated/acp/types/session_update/tool_call_update.rbs

@@ -13,6 +13,9 @@ class ACP::Types::SessionUpdate::ToolCallUpdate
   # @dynamic title
   attr_reader title: String?
 
+  # @dynamic name
+  attr_reader name: String?
+
   # @dynamic content
   attr_reader content: Array[ACP::Types::ToolCallContent::t]?
 
@@ -32,13 +35,14 @@ class ACP::Types::SessionUpdate::ToolCallUpdate
   # @rbs kind: String?
   # @rbs status: String?
   # @rbs title: String?
+  # @rbs name: String?
   # @rbs content: Array[ACP::Types::ToolCallContent::t]?
   # @rbs locations: Array[ACP::Types::ToolCallLocation]?
   # @rbs raw_input: untyped
   # @rbs raw_output: untyped
   # @rbs meta: Hash[String, untyped]?
   # @rbs return: void
-  def initialize: (tool_call_id: String, ?kind: String?, ?status: String?, ?title: String?, ?content: Array[ACP::Types::ToolCallContent::t]?, ?locations: Array[ACP::Types::ToolCallLocation]?, ?raw_input: untyped, ?raw_output: untyped, ?meta: Hash[String, untyped]?) -> void
+  def initialize: (tool_call_id: String, ?kind: String?, ?status: String?, ?title: String?, ?name: String?, ?content: Array[ACP::Types::ToolCallContent::t]?, ?locations: Array[ACP::Types::ToolCallLocation]?, ?raw_input: untyped, ?raw_output: untyped, ?meta: Hash[String, untyped]?) -> void
 
   # @rbs hash: Hash[String, untyped]
   # @rbs return: ACP::Types::SessionUpdate::ToolCallUpdate

data/sig/generated/acp/types/tool_call.rbs

@@ -7,6 +7,9 @@ class ACP::Types::ToolCall
   # @dynamic title
   attr_reader title: String
 
+  # @dynamic name
+  attr_reader name: String?
+
   # @dynamic kind
   attr_reader kind: String?
 
@@ -30,6 +33,7 @@ class ACP::Types::ToolCall
 
   # @rbs tool_call_id: String
   # @rbs title: String
+  # @rbs name: String?
   # @rbs kind: String?
   # @rbs status: String?
   # @rbs content: Array[ACP::Types::ToolCallContent::t]?
@@ -38,7 +42,7 @@ class ACP::Types::ToolCall
   # @rbs raw_output: untyped
   # @rbs meta: Hash[String, untyped]?
   # @rbs return: void
-  def initialize: (tool_call_id: String, title: String, ?kind: String?, ?status: String?, ?content: Array[ACP::Types::ToolCallContent::t]?, ?locations: Array[ACP::Types::ToolCallLocation]?, ?raw_input: untyped, ?raw_output: untyped, ?meta: Hash[String, untyped]?) -> void
+  def initialize: (tool_call_id: String, title: String, ?name: String?, ?kind: String?, ?status: String?, ?content: Array[ACP::Types::ToolCallContent::t]?, ?locations: Array[ACP::Types::ToolCallLocation]?, ?raw_input: untyped, ?raw_output: untyped, ?meta: Hash[String, untyped]?) -> void
 
   # @rbs hash: Hash[String, untyped]
   # @rbs return: ACP::Types::ToolCall