acme-client 2.0.17 → 2.0.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 417bc7e66063768660e078a24866ac390792f42c861742054ee4d6269297bb3d
-  data.tar.gz: 29d839f6c57f17ca85dcce3bad8b505bf9bc75a7ae4ea5baca55c341b29cf238
+  metadata.gz: a0e6e77d3b55948efdac0659c7252a685c791029599c734cb593444e3d3d4936
+  data.tar.gz: 14e2a2ec2a520db7bffef10f069dae5ca51ce58d0b0d8c0f15353dd622025ac2
 SHA512:
-  metadata.gz: b769d1192fcbf7468cea7637a79398d19a1561da94e34e1e08c15108dba6923b2f2c4d38c2a6404699111b42455c97217eec46ba5fbb66c6a0e0661230743b0b
-  data.tar.gz: aa3deacd0ad900db154efaf3d6e231faf2b8f8ac01e9a02cfafb4b17f7993e13c8bad00321545b4a042e49ba68540b4be874ca5024828ac0299edf7c47d7c246
+  metadata.gz: bbde5262664481e7e11c69d9604e4cd65a5cd4983cc5aaeca418f6abcb88787562968f745b8a4cac7bad423463ed2d1a76a9eeea69ff540e4dabd17f84f49b52
+  data.tar.gz: 62e069ee6a2b9dd8a38081aaac7c07f00d84fea78ab923a3a9fb9fafd538c0af5e2e9e4f2fd02737910cadbd0365879ef106ba93fc3e7106d467edd3e0fbe2b7

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## `2.0.19`
+
+* Fix an issue CSR generation. Version should be set to zero according to the spec. It's causing issue with some ACME server implementation.
+
+## `2.0.18`
+
+* Fix an issue public key encoding. `OpenSSL::BN` cause keys with leading zero to fail.
+
 ## `2.0.17`
 
 * Fix bug where depending on call order `jws` get generated with the wrong `kid`

data/acme-client.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'webmock', '~> 3.8'
   spec.add_development_dependency 'webrick', '~> 1.7'
 
+  spec.add_runtime_dependency 'base64', '~> 0.2.0'
   spec.add_runtime_dependency 'faraday', '>= 1.0', '< 3.0.0'
   spec.add_runtime_dependency 'faraday-retry', '>= 1.0', '< 3.0.0'
 end

data/lib/acme/client/certificate_request.rb

@@ -89,7 +89,7 @@ class Acme::Client::CertificateRequest
       end
       csr.public_key = @private_key
       csr.subject = generate_subject
-      csr.version = 2
+      csr.version = 0
       add_extension(csr)
       csr.sign @private_key, @digest
     end

data/lib/acme/client/jwk/ecdsa.rb

@@ -50,8 +50,8 @@ class Acme::Client::JWK::ECDSA < Acme::Client::JWK::Base
     {
       crv: @curve_params[:jwa_crv],
       kty: 'EC',
-      x: Acme::Client::Util.urlsafe_base64(coordinates[:x].to_s(2)),
-      y: Acme::Client::Util.urlsafe_base64(coordinates[:y].to_s(2))
+      x: Acme::Client::Util.urlsafe_base64(coordinates[:x]),
+      y: Acme::Client::Util.urlsafe_base64(coordinates[:y])
     }
   end
 
@@ -92,8 +92,8 @@ class Acme::Client::JWK::ECDSA < Acme::Client::JWK::Base
       hex_y = hex[2 + data_len / 2, data_len / 2]
 
       {
-        x: OpenSSL::BN.new([hex_x].pack('H*'), 2),
-        y: OpenSSL::BN.new([hex_y].pack('H*'), 2)
+        x: [hex_x].pack('H*'),
+        y: [hex_y].pack('H*')
       }
     end
   end

data/lib/acme/client/version.rb

@@ -2,6 +2,6 @@
 
 module Acme
   class Client
-    VERSION = '2.0.17'.freeze
+    VERSION = '2.0.19'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acme-client
 version: !ruby/object:Gem::Version
-  version: 2.0.17
+  version: 2.0.19
 platform: ruby
 authors:
 - Charles Barbier
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-13 00:00:00.000000000 Z
+date: 2024-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
+- !ruby/object:Gem::Dependency
+  name: base64
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement