acme-client 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 64374fceebb44c96455db6bda3486fdff6afcb54548fb073177d972ddfe5ea58
-  data.tar.gz: fcfe92ab66fe177c4ead06cf605f9207187250cafae6b6135e3b941fb20b9ed2
+  metadata.gz: 05f87acfd3874c1d642f80201ef97d81abee4c36e97f194227f0a4cf3501f981
+  data.tar.gz: 688ad48aca9ef6350f0350a8ed719f8efea00c611995124c56c1221160219152
 SHA512:
-  metadata.gz: 81a260cebd6797af5f1bfd2fc9249fb8969aa69eaf806c9849fc37ffe327a03a5eec8287606297d4d2bf62cdcfcde4a182d96fac5de0d58b4771b81d2b0aa45d
-  data.tar.gz: 2231b13253d255bc83004fd67d17bfcbf69ab94d593c4bc41f9509ef11a1f49a947bf01921334fed4e024184ad96d5fd595e11f2d8e9790b2d27a3ecb963c761
+  metadata.gz: e23b7f8b4116da8dd7bc9834ef4fb441bb90f2f3a54fae653bed0a3ea56d6d0a7b98642df443dd08834ffdd46b3f5b86b995d3b4eb4253f6f43511babe010592
+  data.tar.gz: 706a2d72509b69a754c0a40d676652bde2f2ed284abdbed26982991c65ac42beb74586fddf2f790144de839f7ef570cae31617a882574459093a5ab157dc65a4

data/.gitignore

@@ -8,3 +8,4 @@
 /spec/reports/
 /tmp/
 /vendor/bundle
+/.idea/

data/.rubocop.yml

@@ -7,7 +7,7 @@ AllCops:
 Rails:
   Enabled: false
 
-Naming/FileName:
+Style/FileName:
   Exclude:
     - 'lib/acme-client.rb'
 
@@ -66,7 +66,7 @@ Metrics/ParameterLists:
   Max: 5
   CountKeywordArgs: false
 
-Layout/EndAlignment:
+Lint/EndAlignment:
   Enabled: false
 
 Style/ParallelAssignment:
@@ -135,5 +135,5 @@ Style/ExpandPathArguments:
 Security/JSONLoad:
   Enabled: false
 
-Naming/AccessorMethodName:
+Style/AccessorMethodName:
   Enabled: false

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+## `2.0.2`
+
+* Fix constant lookup on InvalidDirectory
+* Forward connection options when fetching nonce
+* Fix splats without parenthesis warning
+
+
+## `2.0.1`
+
+* Properly require URI
+
 ## `2.0.0`
 
 * Release of the `ACMEv2` branch

data/lib/acme/client.rb

@@ -177,7 +177,8 @@ class Acme::Client
   end
 
   def get_nonce
-    response = Faraday.head(endpoint_for(:new_nonce), nil, 'User-Agent' => USER_AGENT)
+    connection = new_connection(endpoint: endpoint_for(:new_nonce))
+    response = connection.head(nil, nil, 'User-Agent' => USER_AGENT)
     nonces << response.headers['replay-nonce']
     true
   end
@@ -268,12 +269,18 @@ class Acme::Client
     endpoint = "#{uri.scheme}://#{uri.hostname}:#{uri.port}"
     @connections ||= {}
     @connections[mode] ||= {}
-    @connections[mode][endpoint] ||= new_connection(endpoint: endpoint, mode: mode)
+    @connections[mode][endpoint] ||= new_acme_connection(endpoint: endpoint, mode: mode)
   end
 
-  def new_connection(endpoint:, mode:)
-    Faraday.new(endpoint, **@connection_options) do |configuration|
+  def new_acme_connection(endpoint:, mode:)
+    new_connection(endpoint: endpoint) do |configuration|
       configuration.use Acme::Client::FaradayMiddleware, client: self, mode: mode
+    end
+  end
+
+  def new_connection(endpoint:)
+    Faraday.new(endpoint, **@connection_options) do |configuration|
+      yield(configuration) if block_given?
       configuration.adapter Faraday.default_adapter
     end
   end

data/lib/acme/client/resources/account.rb

@@ -13,19 +13,19 @@ class Acme::Client::Resources::Account
   end
 
   def update(contact: nil, terms_of_service_agreed: nil)
-    assign_attributes **@client.account_update(
+    assign_attributes(**@client.account_update(
       contact: contact, terms_of_service_agreed: term_of_service
-    ).to_h
+    ).to_h)
     true
   end
 
   def deactivate
-    assign_attributes **@client.account_deactivate.to_h
+    assign_attributes(**@client.account_deactivate.to_h)
     true
   end
 
   def reload
-    assign_attributes **@client.account.to_h
+    assign_attributes(**@client.account.to_h)
     true
   end
 

data/lib/acme/client/resources/authorization.rb

@@ -9,12 +9,12 @@ class Acme::Client::Resources::Authorization
   end
 
   def deactivate
-    assign_attributes **@client.deactivate_authorization(url: url).to_h
+    assign_attributes(**@client.deactivate_authorization(url: url).to_h)
     true
   end
 
   def reload
-    assign_attributes **@client.authorization(url: url).to_h
+    assign_attributes(**@client.authorization(url: url).to_h)
     true
   end
 

data/lib/acme/client/resources/challenges/base.rb

@@ -17,14 +17,22 @@ class Acme::Client::Resources::Challenges::Base
   end
 
   def reload
-    assign_attributes **@client.challenge(url: url).to_h
+    assign_attributes(**@client.challenge(url: url).to_h)
     true
   end
 
-  def request_validation
-    assign_attributes **@client.request_challenge_validation(
-      url: url, key_authorization: key_authorization
+  def send_challenge_vallidation(url:, key_authorization:)
+    @client.request_challenge_validation(
+      url: url,
+      key_authorization: key_authorization
     ).to_h
+  end
+
+  def request_validation
+    assign_attributes(**send_challenge_vallidation(
+      url: url,
+      key_authorization: key_authorization
+    ))
     true
   end
 

data/lib/acme/client/resources/directory.rb

@@ -63,7 +63,8 @@ class Acme::Client::Resources::Directory
     end
     result
   rescue JSON::ParserError => exception
-    raise InvalidDirectory, "Invalid directory url\n#{@directory} did not return a valid directory\n#{exception.inspect}"
+    raise Acme::Client::Error::InvalidDirectory,
+      "Invalid directory url\n#{@directory} did not return a valid directory\n#{exception.inspect}"
   end
 
   def fetch_directory

data/lib/acme/client/resources/order.rb

@@ -9,7 +9,7 @@ class Acme::Client::Resources::Order
   end
 
   def reload
-    assign_attributes **@client.order(url: url).to_h
+    assign_attributes(**@client.order(url: url).to_h)
     true
   end
 
@@ -20,7 +20,7 @@ class Acme::Client::Resources::Order
   end
 
   def finalize(csr:)
-    assign_attributes **@client.finalize(url: finalize_url, csr: csr).to_h
+    assign_attributes(**@client.finalize(url: finalize_url, csr: csr).to_h)
     true
   end
 

data/lib/acme/client/version.rb

@@ -2,6 +2,6 @@
 
 module Acme
   class Client
-    VERSION = '2.0.1'.freeze
+    VERSION = '2.0.2'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acme-client
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Charles Barbier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-27 00:00:00.000000000 Z
+date: 2019-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -48,22 +48,22 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.3.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.3.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.3'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -88,22 +88,22 @@ dependencies:
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.21'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.21.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.21'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.21.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.21'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -185,8 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Client for the ACME protocol.