acidic_job 1.0.0.rc6 → 1.0.0.rc7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '004839711b3d3c8bec8ab08dec1d4c5c855fa4f69f659b9c220c151d5003d6d4'
-  data.tar.gz: 46dd79d7e3a83c019dd449c3846986c358b8f572ba3b2ca811087cd567e105e2
+  metadata.gz: 6583544dc3b3545721d81facda79a461cb8a3a7a8078d2dc309dbc887c0dc1a7
+  data.tar.gz: 89f94171898b64372b85b6dcca3c4f6134e608f39c4aadeb8a776ce7c1a6e294
 SHA512:
-  metadata.gz: ba94864fc9c8b710959bd21ec0f53d4a42bacce974e5d985d92060ffe3215102889573dc5b04bbe697a03506df7c270d20fbfc73d5316e04b977c2d47f0588b8
-  data.tar.gz: caee8a65b86e58266730487f52185b9c5dcb64801f6db241b8ffa256d8d741ea9668a673371bdca1da806cc8dff8c62f742a69f86086442dac4b64d63649ec52
+  metadata.gz: 25fb20afe5782e1e73f23c2c020948ba732f25e9abb9cf32dcc5803eb74fa7f3c3bb4e674aaf6bd80263d235251fc043b5ee23f2176cdb0b2e99397c1e74ef7a
+  data.tar.gz: a09e720a54df383804b54d63b1acf8bd6b2bc912e05dea373f2912b87bbaa5f4e7e60413491ae13e4c780ba99e5cc842e73774837a08dbc87d8e223502534a70

data/README.md

@@ -183,7 +183,7 @@ class Job < ActiveJob::Base
 ```
 
 > [!TIP]
-> You should think carefully about what constitutes a unique execution of a workflow. Imagine you had a workflow job for balance transers. Jill transfers $10 to John. Your system **must** be able to differentiate between retries of this transfer and new independent transfers. If you were only to use the `sender`, `recipient`, and `amount` as your `unique_by` values, then if Jill tries to transfer another $10 to John at some point in the future, that work will be considered a retry of the first transfer and not a new transfer.
+> You should think carefully about what constitutes a unique execution of a workflow. Imagine you had a workflow job for balance transfers. Jill transfers $10 to John. Your system **must** be able to differentiate between retries of this transfer and new independent transfers. If you were only to use the `sender`, `recipient`, and `amount` as your `unique_by` values, then if Jill tries to transfer another $10 to John at some point in the future, that work will be considered a retry of the first transfer and not a new transfer.
 
 
 ### Orchestrating steps

data/lib/acidic_job/engine.rb

@@ -26,14 +26,20 @@ module AcidicJob
         require_relative "serializers/exception_serializer"
         require_relative "serializers/new_record_serializer"
         require_relative "serializers/job_serializer"
-        require_relative "serializers/range_serializer"
-
-        ActiveJob::Serializers.add_serializers(
-          Serializers::ExceptionSerializer,
-          Serializers::NewRecordSerializer,
-          Serializers::JobSerializer,
-          Serializers::RangeSerializer
-        )
+
+        serializers = [
+          Serializers::ExceptionSerializer.instance,
+          Serializers::NewRecordSerializer.instance,
+          Serializers::JobSerializer.instance
+        ]
+
+        # Rails 7.1+ includes a RangeSerializer, so only add ours for older versions
+        unless defined?(ActiveJob::Serializers::RangeSerializer)
+          require_relative "serializers/range_serializer"
+          serializers << Serializers::RangeSerializer.instance
+        end
+
+        ActiveJob::Serializers.add_serializers(*serializers)
       end
     end
 

data/lib/acidic_job/serializers/exception_serializer.rb

@@ -26,6 +26,10 @@ module AcidicJob
       def serialize?(argument)
         defined?(Exception) && argument.is_a?(Exception)
       end
+
+      def klass
+        ::Exception
+      end
     end
   end
 end

data/lib/acidic_job/serializers/job_serializer.rb

@@ -22,6 +22,10 @@ module AcidicJob
       def serialize?(argument)
         defined?(::ActiveJob::Base) && argument.class < ::ActiveJob::Base
       end
+
+      def klass
+        ::ActiveJob::Base
+      end
     end
   end
 end

data/lib/acidic_job/serializers/new_record_serializer.rb

@@ -20,6 +20,10 @@ module AcidicJob
       def serialize?(argument)
         defined?(::ActiveRecord) && argument.respond_to?(:new_record?) && argument.new_record?
       end
+
+      def klass
+        ::ActiveRecord::Base
+      end
     end
   end
 end

data/lib/acidic_job/serializers/range_serializer.rb

@@ -2,25 +2,25 @@
 
 require "active_job/serializers/object_serializer"
 
-# :nocov:
 module AcidicJob
   module Serializers
+    # This serializer is only used for Rails versions prior to 7.1,
+    # which introduced ActiveJob::Serializers::RangeSerializer.
     class RangeSerializer < ::ActiveJob::Serializers::ObjectSerializer
       KEYS = %w[begin end exclude_end].freeze
 
       def serialize(range)
-        args = Arguments.serialize([ range.begin, range.end, range.exclude_end? ])
+        args = ::ActiveJob::Arguments.serialize([range.begin, range.end, range.exclude_end?])
         super(KEYS.zip(args).to_h)
       end
 
       def deserialize(hash)
-        klass.new(*Arguments.deserialize(hash.values_at(*KEYS)))
+        klass.new(*::ActiveJob::Arguments.deserialize(hash.values_at(*KEYS)))
       end
 
-      private def klass
+      def klass
         ::Range
       end
     end
   end
 end
-# :nocov:

data/lib/acidic_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AcidicJob
-  VERSION = "1.0.0.rc6"
+  VERSION = "1.0.0.rc7"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acidic_job
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc6
+  version: 1.0.0.rc7
 platform: ruby
 authors:
 - Stephen Margheim