acidic_job 1.0.0.beta.9 → 1.0.0.beta.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 55e96056c881f1a048efc79156db98799bd911ac8417803260499ef1d9f69ff7
-  data.tar.gz: 52ae51638b01352db67279455f08b086c2be8c725914fe32c84542d9b5927325
+  metadata.gz: 6c2f5b13489acc0e87c1de14248857c107d794a60d0af9a3cafdc5606c80929c
+  data.tar.gz: 6bc97dda18375d3efd1cd37c7c6c2642b2cbe6c44a73e3451e07ebcce738ab30
 SHA512:
-  metadata.gz: 4b6a2f319942e8f5973255453608edab836b8e02c421ab3291725b171817f100061319b0fed5af60a706ae8b4eabc15f3b62f146eeff0a97474fa817547a53ff
-  data.tar.gz: 6fa11549153a9334089a59534e049e59fba1a5f353069d49ec347238f3e6f26b18b0deb618414e99b33a33400554d05b0ebc29389c12ce1c0e5cb5c727ef90c1
+  metadata.gz: 586158e2ccfa061f7efa636dd14ef9d83be1105d32e964e29a77df6728e941d8506379794e7144b8ec41f8c4e7187fae6de66cf7c37c16fd07d45a6e84bdb849
+  data.tar.gz: fdf9c926a74abc99262c76a508f07dd87de823958b5ea3230a5c6f98c17cb2f93153a32f8d34cb4c27145f0a5838a5e2090a32f815b7e8c61a50f7aafa65b39e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    acidic_job (1.0.0.beta.9)
+    acidic_job (1.0.0.beta.10)
       activejob
       activerecord
       activesupport

data/lib/acidic_job/serializer.rb

@@ -10,11 +10,11 @@ module AcidicJob
         return if json.nil? || json.empty?
 
         data = JSON.parse(json)
-        Arguments.deserialize(data).first
+        Arguments.send :deserialize_argument, data
       end
 
       def dump(obj)
-        data = Arguments.serialize [obj]
+        data = Arguments.send :serialize_argument, obj
         data.to_json
       rescue ActiveJob::SerializationError
         raise UnserializableValue

data/lib/acidic_job/serializers/job_serializer.rb

@@ -6,24 +6,16 @@ module AcidicJob
   module Serializers
     class JobSerializer < ::ActiveJob::Serializers::ObjectSerializer
       def serialize(job)
-        super(job.serialize)
+        # don't serialize the `enqueued_at` value, as ActiveRecord will check if the Run record has changed
+        # by comparing the deserialized database value with a temporary in-memory generated value.
+        # That temporary in-memory generated value can sometimes have an `enqueued_at` value that is 1 second off
+        # from the original. In this case, ActiveRecord will think the record has unsaved changes and block the lock.
+        super(job.as_json.merge("job_class" => job.class.name))
       end
 
       def deserialize(hash)
-        job = ActiveJob::Base.deserialize(hash)
+        job = ::ActiveJob::Base.deserialize(hash)
         job.send(:deserialize_arguments_if_needed)
-        # this is a shim to ensure we can work with Ruby 2.7 as well as 3.0+
-        # :nocov:
-        if job.arguments.last.is_a?(Hash)
-          *args, kwargs = job.arguments
-        else
-          args = job.arguments
-          kwargs = {}
-        end
-        # :nocov:
-        job.instance_variable_set(:@__acidic_job_args, args)
-        job.instance_variable_set(:@__acidic_job_kwargs, kwargs)
-
         job
       end
 

data/lib/acidic_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AcidicJob
-  VERSION = "1.0.0.beta.9"
+  VERSION = "1.0.0.beta.10"
 end

data/lib/acidic_job/workflow.rb

@@ -50,10 +50,6 @@ module AcidicJob
       wrapped_method = WorkflowStep.new(run: @run, job: @job).wrapped
       current_step = @run.current_step_name
 
-      # can't reproduce yet, but saw a bug in production where
-      # nested awaits workflows had an unsaved `workflow` attribute
-      @run.save! if @run.has_changes_to_save?
-
       AcidicJob.logger.log_run_event("Executing #{current_step}...", @job, @run)
       @run.with_lock do
         @step_result = wrapped_method.call(@run)
@@ -64,10 +60,6 @@ module AcidicJob
     def run_step_result
       next_step = @run.next_step_name
 
-      # can't reproduce yet, but saw a bug in production where
-      # nested awaits workflows had an unsaved `workflow` attribute
-      @run.save! if @run.has_changes_to_save?
-
       AcidicJob.logger.log_run_event("Progressing to #{next_step}...", @job, @run)
       @run.with_lock do
         @step_result.call(run: @run)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acidic_job
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta.9
+  version: 1.0.0.beta.10
 platform: ruby
 authors:
 - fractaledmind
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-08-11 00:00:00.000000000 Z
+date: 2022-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob