achecker 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81cb83286205d2f7a2422edaf1da303ca3b32f21f1b98fd94f3b316a21248679
-  data.tar.gz: 822ebb9607a6e5a35e9a48779683bd4d56f243493c93eeff5f2e9a109ce0d576
+  metadata.gz: 6d61483eaa32ce5d2657c48a3a9349a1e325918690544993e6ce92ce299c77fa
+  data.tar.gz: 7f706edf00a80751a9f3504462df5b907195ea5c992cd0e8b8e5d66cc0cafc16
 SHA512:
-  metadata.gz: 8c557df7575c0763bcabeb2453bed0659e7fb84c3bf02c77e483819040853464fe751a4b51d2da6cc7dc62170ed6c2c58878d5e1aab2fb1cc7be13ebc6ba0ca5
-  data.tar.gz: f817494396fbf8c48b8904c221eff8928d38c254af22a158fdf8589ece7cae4640d0860a0bc50ead3b8f21cfd002936e839cf7abadc54388ece3ac9ad6884c81
+  metadata.gz: 6b446d4735926b58e259a97baa245bce17637e7865c797e64d73629ca0894e732be334a13b34cf93e1f6c7a2dce0263254a57fa7fa5d96a1c814967aabc97377
+  data.tar.gz: 8e589db1376e92a8d82d419bc69d061fe94511b3e854f3aa1f96899edf06e8b9bad4d65c8631fcde795c96c095947fa12db91e0b470bcbc6b291e481782cdaf3

data/lib/achecker/api.rb

@@ -6,8 +6,10 @@ module AChecker
 
   class Api
 
-    def initialize(id)
-      @url_builder = UrlBuilder.new(id)
+    BASE_URL = "https://achecker.ca/checkacc.php"
+
+    def initialize(id, achecker_url = nil)
+      @url_builder = UrlBuilder.new(id, achecker_url || BASE_URL)
       @result_builder = CheckResultBuilder.new
     end
 
@@ -15,7 +17,9 @@ module AChecker
       url = @url_builder.build(target_url, "rest")
       response = Net::HTTP.get_response(url)
 
-      raise "Error processing \"#{target_url}\". Response status code #{response.code}" unless response.kind_of?(Net::HTTPSuccess)
+      unless response.kind_of?(Net::HTTPSuccess) then
+        raise "Error processing \"#{target_url}\". Response status code #{response.code} returned when requesting to achecker at #{url}"
+      end
 
       @result_builder.build(target_url, @url_builder.build(target_url, "html"), response.body)
     end

data/lib/achecker/url_builder.rb

@@ -4,14 +4,13 @@ module AChecker
 
   class UrlBuilder
 
-    BASE_URL = "https://achecker.ca/checkacc.php"
-
-    def initialize(id = nil)
+    def initialize(id, achecker_url)
       @id = id
+      @achecker_url = achecker_url
     end
 
     def build(target_url, output)
-      url = "#{BASE_URL}?uri=#{CGI::escape(target_url)}&output=#{output}"
+      url = "#{@achecker_url}?uri=#{CGI::escape(target_url)}&output=#{output}"
       url = "#{url}&id=#{@id}" if output == "rest"
       URI(url)
     end

data/lib/achecker/version.rb

@@ -1,3 +1,3 @@
 module AChecker
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/spec/achecker/api_spec.rb

@@ -8,10 +8,9 @@ module AChecker
 
     describe "#check" do
 
-      it "should check url" do
-        id = "12345678"
-        url = CGI::escape("http://example.com/some-resource/")
-        xml = <<-eos
+      let(:id) { "12345678" }
+      let(:url) { CGI::escape("http://example.com/some-resource/") }
+      let(:xml) { <<-eos
           <?xml version="1.0" encoding="ISO-8859-1"?>
           <resultset>
             <summary>
@@ -19,20 +18,37 @@ module AChecker
             </summary>
           </resultset>
         eos
+      }
+     
+      context "when achecker url is not provided" do
+        it "should check url" do
+          stub_request(:get, "https://achecker.ca/checkacc.php")
+            .with(:query => {"uri" => url, "id" => id, "output" => "rest"})
+            .to_return(:body => xml)
 
+          api = Api.new(id)
 
-        stub_request(:get, "https://achecker.ca/checkacc.php")
-          .with(:query => {"uri" => url, "id" => id, "output" => "rest"})
-          .to_return(:body => xml)
+          result = api.check(url)
 
-        api = Api.new(id)
+          expect(result.url).to eq(url)
+          expect(result.num_errors).to eq(30)
+        end
+      end
 
-        result = api.check(url)
+      context "when achecker url is provided" do
+        it "should check url" do
+          stub_request(:get, "https://some.url/checkacc.php")
+            .with(:query => {"uri" => url, "id" => id, "output" => "rest"})
+            .to_return(:body => xml)
 
-        expect(result.url).to eq(url)
-        expect(result.num_errors).to eq(30)
-      end
+          api = Api.new(id, "https://some.url/checkacc.php")
 
+          result = api.check(url)
+
+          expect(result.url).to eq(url)
+          expect(result.num_errors).to eq(30)
+        end
+      end
     end
 
   end

data/spec/achecker/url_builder_spec.rb

@@ -4,11 +4,12 @@ module AChecker
 
   describe UrlBuilder do
 
-    let(:id) { "12345" }
-    let(:builder) { UrlBuilder.new(id) }
-
     describe "#build" do
 
+      let(:id) { "12345" }
+      let(:achecker_url) { "https://some.other.url/checkacc.php" } 
+      let(:builder) { UrlBuilder.new(id, achecker_url) }
+
       context "when output is rest" do
         it "should set the id" do
           url = builder.build("http://target.url", "rest").to_s
@@ -23,6 +24,11 @@ module AChecker
         end
       end
 
+      it "should use the provided url" do
+        url = builder.build("http://target.url", "rest").to_s
+        expect(url).to start_with(achecker_url)
+      end
+
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: achecker
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Rafael Magrin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-10 00:00:00.000000000 Z
+date: 2020-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri